[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150246#comment-16150246 ] ASF GitHub Bot commented on FLINK-7299: --- Github user soniclavier closed the pull request at: https://github.com/apache/flink/pull/4422 > Write GenericRecord using AvroOutputFormat > -- > > Key: FLINK-7299 > URL: https://issues.apache.org/jira/browse/FLINK-7299 > Project: Flink > Issue Type: Improvement > Components: Batch Connectors and Input/Output Formats >Reporter: Vishnu Viswanath >Assignee: Vishnu Viswanath >Priority: Minor > Fix For: 1.4.0 > > > Allow AvroOutputFormat to write GenericRecords -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150223#comment-16150223 ] ASF GitHub Bot commented on FLINK-7299: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4422 Thanks a lot! I merged this. 👌 Could you please close this PR? > Write GenericRecord using AvroOutputFormat > -- > > Key: FLINK-7299 > URL: https://issues.apache.org/jira/browse/FLINK-7299 > Project: Flink > Issue Type: Improvement > Components: Batch Connectors and Input/Output Formats >Reporter: Vishnu Viswanath >Assignee: Vishnu Viswanath >Priority: Minor > Fix For: 1.4.0 > > > Allow AvroOutputFormat to write GenericRecords -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149117#comment-16149117 ] ASF GitHub Bot commented on FLINK-7299: --- Github user soniclavier commented on the issue: https://github.com/apache/flink/pull/4422 @aljoscha Thanks for taking a look. I have modified the test. > Write GenericRecord using AvroOutputFormat > -- > > Key: FLINK-7299 > URL: https://issues.apache.org/jira/browse/FLINK-7299 > Project: Flink > Issue Type: Improvement > Components: Batch Connectors and Input/Output Formats >Reporter: Vishnu Viswanath >Assignee: Vishnu Viswanath >Priority: Minor > > Allow AvroOutputFormat to write GenericRecords -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148778#comment-16148778 ] ASF GitHub Bot commented on FLINK-7299: --- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4422 Thanks for opening this PR! 😄 Could you please also verify that the records are correctly written in the test? I.e. read the file and compare against what was written. Otherwise the changes look good and it's great that you added a test in the first place! > Write GenericRecord using AvroOutputFormat > -- > > Key: FLINK-7299 > URL: https://issues.apache.org/jira/browse/FLINK-7299 > Project: Flink > Issue Type: Improvement > Components: Batch Connectors and Input/Output Formats >Reporter: Vishnu Viswanath >Assignee: Vishnu Viswanath >Priority: Minor > > Allow AvroOutputFormat to write GenericRecords -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108207#comment-16108207 ] ASF GitHub Bot commented on FLINK-7299: --- Github user soniclavier commented on the issue: https://github.com/apache/flink/pull/4422 Link to passed Travis build : https://travis-ci.org/soniclavier/flink/builds/259243850 > Write GenericRecord using AvroOutputFormat > -- > > Key: FLINK-7299 > URL: https://issues.apache.org/jira/browse/FLINK-7299 > Project: Flink > Issue Type: Improvement > Components: Batch Connectors and Input/Output Formats >Reporter: Vishnu Viswanath >Assignee: Vishnu Viswanath >Priority: Minor > > Allow AvroOutputFormat to write GenericRecords -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7299) Write GenericRecord using AvroOutputFormat
[ https://issues.apache.org/jira/browse/FLINK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106809#comment-16106809 ] ASF GitHub Bot commented on FLINK-7299: --- GitHub user soniclavier opened a pull request: https://github.com/apache/flink/pull/4422 [FLINK-7299][AVRO] Write GenericRecord using AvroOutputFormat ## What is the purpose of the change Allow writing Avro GenericRecord using AvroOutputFormat. ## Brief change log - Added condition in AvroOutputFormat to check if avroValue is an instance of GenericRecord and create a GenericDatumWriter. ## Verifying this change This change added tests and can be verified as follows: - Added unit tests- testGenericRecord() in AvroOutputFormatTest to write GenericRecords. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: yes - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no ## Documentation - Does this pull request introduce a new feature?: no (not a major feature) - If yes, how is the feature documented? not applicable You can merge this pull request into a Git repository by running: $ git pull https://github.com/soniclavier/flink FLINK-7299-GenericRecord-in-AvroOutputFormat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4422.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4422 commit 1c71ca43bcd5d4733e581f80637b531ba447e9dc Author: Vishnu Viswanath Date: 2017-07-31T04:58:28Z [FLINK-7299][AVRO] Write GenericRecord using AvroOutputFormat > Write GenericRecord using AvroOutputFormat > -- > > Key: FLINK-7299 > URL: https://issues.apache.org/jira/browse/FLINK-7299 > Project: Flink > Issue Type: Improvement > Components: Batch Connectors and Input/Output Formats >Reporter: Vishnu Viswanath >Assignee: Vishnu Viswanath >Priority: Minor > > Allow AvroOutputFormat to write GenericRecords -- This message was sent by Atlassian JIRA (v6.4.14#64029)
