[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168489#comment-16168489 ] ASF GitHub Bot commented on FLINK-7402: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4562 > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > Fix For: 1.4.0 > > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168414#comment-16168414 ] ASF GitHub Bot commented on FLINK-7402: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4562 Merging ... > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151397#comment-16151397 ] ASF GitHub Bot commented on FLINK-7402: --- Github user tedyu commented on the issue: https://github.com/apache/flink/pull/4562 lgtm > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141044#comment-16141044 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4562 @NicoK Great, tt's too useful for me, thank you very much! > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139508#comment-16139508 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4562 @NicoK Than you for your review, I have reverted the imports changed by IDE, thanks > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138193#comment-16138193 ] ASF GitHub Bot commented on FLINK-7402: --- Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134711249 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -18,6 +18,12 @@ package org.apache.flink.runtime.io.network.netty; +import java.io.IOException; +import java.io.ObjectInputStream; +import java.io.ObjectOutputStream; +import java.nio.ByteBuffer; +import java.util.List; + --- End diff -- sorry for bothering you again, but please revert this change in the import order (it's also against the order defined by our checkstyle) > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138153#comment-16138153 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134704354 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,9 +220,7 @@ void releaseBuffer() { @Override ByteBuf write(ByteBufAllocator allocator) throws IOException { - if (null == buffer) { - throw new NullPointerException(); - } + Preconditions.checkNotNull(buffer, "When deserializing the buffer should have to be requested first."); --- End diff -- Great, thank you for your suggestion :) > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138128#comment-16138128 ] ASF GitHub Bot commented on FLINK-7402: --- Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134699645 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,9 +220,7 @@ void releaseBuffer() { @Override ByteBuf write(ByteBufAllocator allocator) throws IOException { - if (null == buffer) { - throw new NullPointerException(); - } + Preconditions.checkNotNull(buffer, "When deserializing the buffer should have to be requested first."); --- End diff -- Actually, the message should rather be `No buffer instance to serialize.` since the constructor leading to this code path is only used for de-serialization. > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137761#comment-16137761 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4562 @tedyu @NicoK Than you for your suggestions, it sounds good to me, thanks > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134843#comment-16134843 ] ASF GitHub Bot commented on FLINK-7402: --- Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134166175 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,6 +220,10 @@ void releaseBuffer() { @Override ByteBuf write(ByteBufAllocator allocator) throws IOException { + if (null == buffer) { + throw new NullPointerException(); --- End diff -- actually, better use `Preconditions#checkNotNull(T)` - an additional error message there usually does not make too much sense as the failure is clear > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug > Components: Network >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133081#comment-16133081 ] ASF GitHub Bot commented on FLINK-7402: --- Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r133980441 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,6 +220,10 @@ void releaseBuffer() { @Override ByteBuf write(ByteBufAllocator allocator) throws IOException { + if (null == buffer) { + throw new NullPointerException(); --- End diff -- Add exception message to provide more information. > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131944#comment-16131944 ] ASF GitHub Bot commented on FLINK-7402: --- GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4562 [FLINK-7402] Fix ineffective null check in NettyMessage#write() ## What is the purpose of the change Fix ineffective null check in NettyMessage#write() ## Brief change log *(for example:)* - *Add null check and remove unnecessary null check* ## Verifying this change *(Please pick either of the following options)* No test case ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjureel/flink FLINK-7402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4562.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4562 commit e289b37cf8adce56876b47ee33ed161058bf64e6 Author: zjureel Date: 2017-08-18T06:43:34Z [FLINK-7402] Fix ineffective null check in NettyMessage#write() > Ineffective null check in NettyMessage#write() > -- > > Key: FLINK-7402 > URL: https://issues.apache.org/jira/browse/FLINK-7402 > Project: Flink > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > > Here is the null check in finally block: > {code} > finally { > if (buffer != null) { > buffer.recycle(); > } > {code} > But buffer has been dereferenced in the try block without guard. -- This message was sent by Atlassian JIRA (v6.4.14#64029)