[jira] [Commented] (FLINK-7443) Store and deserializer fields in MetricFetcher should be final

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126892#comment-16126892
 ] 

ASF GitHub Bot commented on FLINK-7443:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4539


> Store and deserializer fields in MetricFetcher should be final
> --
>
> Key: FLINK-7443
> URL: https://issues.apache.org/jira/browse/FLINK-7443
> Project: Flink
>  Issue Type: Improvement
>  Components: Metrics
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The {{MetricStore}} and {{MetricDumpDeserializer}} fields in the 
> {{MetricFetcher}} should be final, as they are not meant to be overwritten 
> and are even used for synchronization.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7443) Store and deserializer fields in MetricFetcher should be final

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126890#comment-16126890
 ] 

ASF GitHub Bot commented on FLINK-7443:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4539
  
true, will change the jira category. merging.


> Store and deserializer fields in MetricFetcher should be final
> --
>
> Key: FLINK-7443
> URL: https://issues.apache.org/jira/browse/FLINK-7443
> Project: Flink
>  Issue Type: Improvement
>  Components: Metrics
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The {{MetricStore}} and {{MetricDumpDeserializer}} fields in the 
> {{MetricFetcher}} should be final, as they are not meant to be overwritten 
> and are even used for synchronization.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7443) Store and deserializer fields in MetricFetcher should be final

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126495#comment-16126495
 ] 

ASF GitHub Bot commented on FLINK-7443:
---

Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/4539
  
+1 but I'm only seeing an improvement and not a bug


> Store and deserializer fields in MetricFetcher should be final
> --
>
> Key: FLINK-7443
> URL: https://issues.apache.org/jira/browse/FLINK-7443
> Project: Flink
>  Issue Type: Bug
>  Components: Metrics
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The {{MetricStore}} and {{MetricDumpDeserializer}} fields in the 
> {{MetricFetcher}} should be final, as they are not meant to be overwritten 
> and are even used for synchronization.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7443) Store and deserializer fields in MetricFetcher should be final

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125594#comment-16125594
 ] 

ASF GitHub Bot commented on FLINK-7443:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/4539

[FLINK-7443] [metrics] MetricFetcher store and deserializer fields now final

The MetricStore and MetricDumpDeserializer fields in the MetricFetcher 
should be final, as they are not meant to be overwritten and are even used for 
synchronization.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 7443

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4539


commit 476b6d3055055c5b40eb6c3ee68ebb6c2f21165b
Author: zentol 
Date:   2017-08-14T12:12:51Z

[FLINK-7443] [metrics] MetricFetcher store and deserializer fields now final




> Store and deserializer fields in MetricFetcher should be final
> --
>
> Key: FLINK-7443
> URL: https://issues.apache.org/jira/browse/FLINK-7443
> Project: Flink
>  Issue Type: Bug
>  Components: Metrics
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The {{MetricStore}} and {{MetricDumpDeserializer}} fields in the 
> {{MetricFetcher}} should be final, as they are not meant to be overwritten 
> and are even used for synchronization.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)