[jira] [Commented] (FLINK-7572) Improve TableSchema ValidationException message.

2017-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153560#comment-16153560
 ] 

ASF GitHub Bot commented on FLINK-7572:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4640


> Improve TableSchema ValidationException message.
> 
>
> Key: FLINK-7572
> URL: https://issues.apache.org/jira/browse/FLINK-7572
> Project: Flink
>  Issue Type: Improvement
>Reporter: sunjincheng
>Assignee: sunjincheng
>
> When sql is very complicated(e.g.: more than 100+ tables), the following 
> exception information is very confusing:
> {code}
> org.apache.flink.table.api.TableException: Table column names must be unique. 
> at org.apache.flink.table.api.TableSchema.(TableSchema.scala:36)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7572) Improve TableSchema ValidationException message.

2017-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153421#comment-16153421
 ] 

ASF GitHub Bot commented on FLINK-7572:
---

Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4640
  
Thanks for the PR @sunjincheng121. I'll merge this.


> Improve TableSchema ValidationException message.
> 
>
> Key: FLINK-7572
> URL: https://issues.apache.org/jira/browse/FLINK-7572
> Project: Flink
>  Issue Type: Improvement
>Reporter: sunjincheng
>Assignee: sunjincheng
>
> When sql is very complicated(e.g.: more than 100+ tables), the following 
> exception information is very confusing:
> {code}
> org.apache.flink.table.api.TableException: Table column names must be unique. 
> at org.apache.flink.table.api.TableSchema.(TableSchema.scala:36)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7572) Improve TableSchema ValidationException message.

2017-09-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLINK-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153007#comment-16153007
 ] 

ASF GitHub Bot commented on FLINK-7572:
---

GitHub user sunjincheng121 opened a pull request:

https://github.com/apache/flink/pull/4640

[FLINK-7572][table]Improve TableSchema and FlinkTable validation exce…

## What is the purpose of the change
Currently, the exception message of `TableScheam` and `FlinkTable` a little 
confusing,In this PR. we want improve the exception message .


## Brief change log

  - *Improve TableSchema column name and column type validation exception 
message*
  - *Improve TableSchema column name duplicate validation exception message*
  - *Improve FlinkTable field name and field type validation exception 
message*
  - *Improve FlinkTable field name duplicate validation exception message*

## Verifying this change
- This change is verified by the new  
`TableSchemaValidationTest#testColumnNameAndColumnTypeNotEqual` 
`TableSchemaValidationTest#testColumnNamesDuplicate` and 
`FlinkTableValidationTest#testFieldNamesDuplicate`.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not documented)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sunjincheng121/flink FLINK-7572-PR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4640


commit 555828aa6a257921f52fb87b8ab5f2afff78eee0
Author: sunjincheng121 
Date:   2017-09-05T00:55:03Z

[FLINK-7572][table]Improve TableSchema and FlinkTable validation exception 
message




> Improve TableSchema ValidationException message.
> 
>
> Key: FLINK-7572
> URL: https://issues.apache.org/jira/browse/FLINK-7572
> Project: Flink
>  Issue Type: Improvement
>Reporter: sunjincheng
>Assignee: sunjincheng
>
> When sql is very complicated(e.g.: more than 100+ tables), the following 
> exception information is very confusing:
> {code}
> org.apache.flink.table.api.TableException: Table column names must be unique. 
> at org.apache.flink.table.api.TableSchema.(TableSchema.scala:36)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)