[jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions
[
https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245575#comment-16245575
]
ASF GitHub Bot commented on FLINK-7979:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4948
Thanks for understanding!
> Use Log.*(Object, Throwable) overload to log exceptions
> ---
>
> Key: FLINK-7979
> URL: https://issues.apache.org/jira/browse/FLINK-7979
> Project: Flink
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Hai Zhou UTC+8
>Assignee: Hai Zhou UTC+8
>Priority: Critical
> Fix For: 1.5.0
>
>
> I found some code that logging an exception, through convert the exception to
> string or call .getMessage. {{.getMessage()}}.
> I think the better way is to use the Logger method overloads which take
> {{`Throwable`}} as a parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions
[
https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243589#comment-16243589
]
ASF GitHub Bot commented on FLINK-7979:
---
Github user yew1eb closed the pull request at:
https://github.com/apache/flink/pull/4948
> Use Log.*(Object, Throwable) overload to log exceptions
> ---
>
> Key: FLINK-7979
> URL: https://issues.apache.org/jira/browse/FLINK-7979
> Project: Flink
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Hai Zhou UTC+8
>Assignee: Hai Zhou UTC+8
>Priority: Critical
> Fix For: 1.5.0
>
>
> I found some code that logging an exception, through convert the exception to
> string or call .getMessage. {{.getMessage()}}.
> I think the better way is to use the Logger method overloads which take
> {{`Throwable`}} as a parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions
[
https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243586#comment-16243586
]
ASF GitHub Bot commented on FLINK-7979:
---
Github user yew1eb commented on the issue:
https://github.com/apache/flink/pull/4948
@StephanEwen
make sense.
I will close this PR.
> Use Log.*(Object, Throwable) overload to log exceptions
> ---
>
> Key: FLINK-7979
> URL: https://issues.apache.org/jira/browse/FLINK-7979
> Project: Flink
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Hai Zhou UTC+8
>Assignee: Hai Zhou UTC+8
>Priority: Critical
> Fix For: 1.5.0
>
>
> I found some code that logging an exception, through convert the exception to
> string or call .getMessage. {{.getMessage()}}.
> I think the better way is to use the Logger method overloads which take
> {{`Throwable`}} as a parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions
[
https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240300#comment-16240300
]
ASF GitHub Bot commented on FLINK-7979:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4948
Sorry, I am opposed to changing that.
Sometimes an author explicitly wants to append parts of the parent
exception message to make it easier to navigate exception stack traces. I think
we should let authors do that when they think it helps making exceptions more
understandable.
> Use Log.*(Object, Throwable) overload to log exceptions
> ---
>
> Key: FLINK-7979
> URL: https://issues.apache.org/jira/browse/FLINK-7979
> Project: Flink
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Hai Zhou UTC+8
>Assignee: Hai Zhou UTC+8
>Priority: Critical
> Fix For: 1.5.0
>
>
> I found some code that logging an exception, through convert the exception to
> string or call .getMessage. {{.getMessage()}}.
> I think the better way is to use the Logger method overloads which take
> {{`Throwable`}} as a parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FLINK-7979) Use Log.*(Object, Throwable) overload to log exceptions
[
https://issues.apache.org/jira/browse/FLINK-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239199#comment-16239199
]
ASF GitHub Bot commented on FLINK-7979:
---
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4948
[FLINK-7979][minor] Use Log.*(Object, Throwable) overload to log exceptions
## What is the purpose of the change
When logging an exception, we often convert the exception to string or call
`.getMessage()`. Instead we can use the log method overloads which take
`Throwable` as a parameter.
## Brief change log
- *Remove unnecessary `e.getMessage()`, logging exception use
LOG.\*(Object, Throwable)*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-7979
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4948.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4948
commit 0aaaca204f7441f3619fd68d7df7aad91e5d5af9
Author: yew1eb
Date: 2017-11-04T12:56:35Z
[FLINK-7979][Minor] Use Log.*(Object, Throwable) overload to log exceptions
> Use Log.*(Object, Throwable) overload to log exceptions
> ---
>
> Key: FLINK-7979
> URL: https://issues.apache.org/jira/browse/FLINK-7979
> Project: Flink
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Hai Zhou UTC+8
>Assignee: Hai Zhou UTC+8
>Priority: Critical
> Fix For: 1.5.0
>
>
> I found some code that logging an exception, through convert the exception to
> string or call .getMessage. {{.getMessage()}}.
> I think the better way is to use the Logger method overloads which take
> {{`Throwable`}} as a parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
