[jira] [Commented] (FLINK-7993) Kafka 08 curator shading pattern out-of-sync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240393#comment-16240393
 ] 

ASF GitHub Bot commented on FLINK-7993:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4953


> Kafka 08 curator shading pattern out-of-sync
> 
>
> Key: FLINK-7993
> URL: https://issues.apache.org/jira/browse/FLINK-7993
> Project: Flink
>  Issue Type: Bug
>  Components: Build System, Kafka Connector
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.4.0
>
>
> The kafka 08 shading pattern for curator is out-of-sync with flink-runtime.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7993) Kafka 08 curator shading pattern out-of-sync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240385#comment-16240385
 ] 

ASF GitHub Bot commented on FLINK-7993:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4953
  
merging.


> Kafka 08 curator shading pattern out-of-sync
> 
>
> Key: FLINK-7993
> URL: https://issues.apache.org/jira/browse/FLINK-7993
> Project: Flink
>  Issue Type: Bug
>  Components: Build System, Kafka Connector
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.4.0
>
>
> The kafka 08 shading pattern for curator is out-of-sync with flink-runtime.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7993) Kafka 08 curator shading pattern out-of-sync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240255#comment-16240255
 ] 

ASF GitHub Bot commented on FLINK-7993:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4953
  
yes


> Kafka 08 curator shading pattern out-of-sync
> 
>
> Key: FLINK-7993
> URL: https://issues.apache.org/jira/browse/FLINK-7993
> Project: Flink
>  Issue Type: Bug
>  Components: Build System, Kafka Connector
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.4.0
>
>
> The kafka 08 shading pattern for curator is out-of-sync with flink-runtime.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7993) Kafka 08 curator shading pattern out-of-sync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240250#comment-16240250
 ] 

ASF GitHub Bot commented on FLINK-7993:
---

Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4953
  
This looks good! And I imagine you checked this manually by running a Job 
using the Kafka 0.8 connector?


> Kafka 08 curator shading pattern out-of-sync
> 
>
> Key: FLINK-7993
> URL: https://issues.apache.org/jira/browse/FLINK-7993
> Project: Flink
>  Issue Type: Bug
>  Components: Build System, Kafka Connector
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.4.0
>
>
> The kafka 08 shading pattern for curator is out-of-sync with flink-runtime.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-7993) Kafka 08 curator shading pattern out-of-sync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240180#comment-16240180
 ] 

ASF GitHub Bot commented on FLINK-7993:
---

GitHub user zentol opened a pull request:

https://github.com/apache/flink/pull/4953

[FLINK-7993][kafka] Sync curator shading patterns

## What is the purpose of the change

This PR syncs the curator shading patterns in flink-runtime and 
flink-connector-kafka-0.8.

Further changes:
* added a note that the patterns have to be kept in sync
* removed an ineffective artifact inclusion from the kafka shading 
configuration
  * since curator was set to provided it was never included anyway

## Verifying this change

Create a simple kafka/zk setup as per 
https://kafka.apache.org/082/documentation.html#quickstart and run an example 
job that contains a kafka consumer, with checkpointing enabled.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zentol/flink 7993

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4953


commit 57652901f1c7fb37c805aebe0cf9ea87465dbba6
Author: zentol 
Date:   2017-11-06T11:47:27Z

[FLINK-7993][kafka] Sync curator shading patterns




> Kafka 08 curator shading pattern out-of-sync
> 
>
> Key: FLINK-7993
> URL: https://issues.apache.org/jira/browse/FLINK-7993
> Project: Flink
>  Issue Type: Bug
>  Components: Build System, Kafka Connector
>Affects Versions: 1.4.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Blocker
> Fix For: 1.4.0
>
>
> The kafka 08 shading pattern for curator is out-of-sync with flink-runtime.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)