[jira] [Commented] (FLINK-8024) Let ClusterOverviewHandler directly extend from AbstractRestHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245442#comment-16245442
 ] 

ASF GitHub Bot commented on FLINK-8024:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4982


> Let ClusterOverviewHandler directly extend from AbstractRestHandler
> ---
>
> Key: FLINK-8024
> URL: https://issues.apache.org/jira/browse/FLINK-8024
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST
>Affects Versions: 1.5.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to get rid of the {{LegacyRestHandler}} we should add a proper 
> implementation of {{ClusterOverviewHandler}} which extends from 
> {{AbstractRestHandler}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8024) Let ClusterOverviewHandler directly extend from AbstractRestHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245426#comment-16245426
 ] 

ASF GitHub Bot commented on FLINK-8024:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/4982
  
Thanks for your review @zentol. Merging.


> Let ClusterOverviewHandler directly extend from AbstractRestHandler
> ---
>
> Key: FLINK-8024
> URL: https://issues.apache.org/jira/browse/FLINK-8024
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST
>Affects Versions: 1.5.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to get rid of the {{LegacyRestHandler}} we should add a proper 
> implementation of {{ClusterOverviewHandler}} which extends from 
> {{AbstractRestHandler}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8024) Let ClusterOverviewHandler directly extend from AbstractRestHandler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243949#comment-16243949
 ] 

ASF GitHub Bot commented on FLINK-8024:
---

GitHub user tillrohrmann opened a pull request:

https://github.com/apache/flink/pull/4982

[FLINK-8024] Let ClusterOverviewHandler directly extend from 
AbstractRestHandler

## What is the purpose of the change

Let ClusterOverviewHandler directly extend from AbstractRestHandler.

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tillrohrmann/flink 
generalizedClusterOverviewHandler

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4982


commit 18d8d1af433715a24c2d2e354d8dcf2efb30c49d
Author: Till Rohrmann 
Date:   2017-11-04T13:56:11Z

[FLINK-8000] Sort Rest handler URLS in RestServerEndpoint

Introduce special RestHandlerUrlComparator to sort REST URLs such that
URLs with path parameters are sorted after those without or fewer.

E.g. the following order would be established

/jobs
/jobs/overview
/jobs/:jobid
/jobs/:jobid/config
/:*

commit bdc5d0eaf803475eb9fc550be3ab59cd176c2894
Author: Till Rohrmann 
Date:   2017-11-06T17:48:53Z

[FLINK-8024] Let ClusterOverviewHandler directly extend from 
AbstractRestHandler




> Let ClusterOverviewHandler directly extend from AbstractRestHandler
> ---
>
> Key: FLINK-8024
> URL: https://issues.apache.org/jira/browse/FLINK-8024
> Project: Flink
>  Issue Type: Sub-task
>  Components: REST
>Affects Versions: 1.5.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to get rid of the {{LegacyRestHandler}} we should add a proper 
> implementation of {{ClusterOverviewHandler}} which extends from 
> {{AbstractRestHandler}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)