[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822402#comment-16822402 ] Truong Duc Kien commented on FLINK-8033: I also think that Flink should target Java 11 directly. For what it's worth, Scala is only going to support Java 11, skipping 9 and 10 [Scala JDK Compatiblity|https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html] Spark is also doing the same with SPARK-24417 > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813444#comment-16813444 ] Till Rohrmann commented on FLINK-8033: -- This is a very good pointer [~tasanuma0829]. We should check whether this also affects Flink's Java 9 support or not. If yes, then I guess that we still need to solve most of the Java 9 problems in order to support Java 11 but we could directly switch to it (maybe some problems only occur with Java 9 which we would not have to fix then). One of the big problems of adding Java 11 support is the removal of some of the unsafe APIs. Flink heavily uses them and we need to figure out how to properly replace them. The important bit is to make the replacement in a way that Flink's Java 8 version does not suffer from performance regressions. In the worst case, this could mean that we have different code paths for the different Java versions. > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812167#comment-16812167 ] Takanobu Asanuma commented on FLINK-8033: - bq. because you still have to solve most of the issues you encounter with java 9 (and 10) on the way to 11 There was an exception in Hadoop. HADOOP-15905 is a bug of JDK 9/10 which has been fixed in JDK 11. It is difficult to handle such a problem since JDK 9/10 have been EOL. That's why we closed HADOOP-11123(supporting JDK 9) as duplicate/superceded of HADOOP-15338(supporting JDK 11). > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811156#comment-16811156 ] Chesnay Schepler commented on FLINK-8033: - because you still have to solve most of the issues you encounter with java 9 (and 10) on the way to 11, and actually having some usable milestones in between is rather helpful when it comes to planning things. > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811075#comment-16811075 ] David Anderson commented on FLINK-8033: --- [~Zentol] I'm no longer hearing any interest in Java 9 from users I work with, since it is already EOL. Why aren't we focused on Java 11 (LTS) instead? https://issues.apache.org/jira/browse/FLINK-10725 > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711064#comment-16711064 ] Takanobu Asanuma commented on FLINK-8033: - FYI, Hadoop stopped fixing the incompatibilities of JDK 9/10 as they are EOL, and focuses on supporting JDK 8/11. Please see HADOOP-11123. > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > Fix For: 1.8.0 > > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668612#comment-16668612 ] Sina Madani commented on FLINK-8033: Java 9 has been end-of-life Since March 2018, and Java 10 since September 2018. Wouldn't it make more sense to change this issue to support Java 11 (which is LTS) instead? > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[
https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644904#comment-16644904
]
ASF GitHub Bot commented on FLINK-8033:
---
zentol closed pull request #48: [FLINK-8033] Add flink-shaded-asm6
URL: https://github.com/apache/flink-shaded/pull/48
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-shaded-asm-6/packaged_licenses/LICENSE.asm.txt
b/flink-shaded-asm-6/packaged_licenses/LICENSE.asm.txt
new file mode 100644
index 000..62ffbcc
--- /dev/null
+++ b/flink-shaded-asm-6/packaged_licenses/LICENSE.asm.txt
@@ -0,0 +1,31 @@
+ASM: a very small and fast Java bytecode manipulation framework
+
+Copyright (c) 2000-2011 INRIA, France Telecom
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+
+1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holders nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
+LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+THE POSSIBILITY OF SUCH DAMAGE.
\ No newline at end of file
diff --git a/flink-shaded-asm-6/pom.xml b/flink-shaded-asm-6/pom.xml
new file mode 100644
index 000..85b7855
--- /dev/null
+++ b/flink-shaded-asm-6/pom.xml
@@ -0,0 +1,108 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+
+4.0.0
+
+
+org.apache.flink
+flink-shaded
+5.0
+..
+
+
+flink-shaded-asm-${asm.major.version}
+${asm.version}-5.0
+
+jar
+
+
+6
+${asm.major.version}.2.1
+
+
+
+
+org.ow2.asm
+asm
+${asm.version}
+
+
+
+org.ow2.asm
+asm-tree
+${asm.version}
+
+
+
+org.ow2.asm
+asm-analysis
+${asm.version}
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-shade-plugin
+
+3.1.1
+
+
+shade-flink
+package
+
+shade
+
+
+
true
+
${project.basedir}/target/dependency-reduced-pom.xml
+
+
+org.ow2.asm:*
+
+
+
+
+org.objectweb
+
org.apache.flink.shaded.asm6.org.objectweb
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/pom.xml b/pom.xml
index 7581102..e1e9505 100644
--- a/pom.xml
+++ b/pom.xml
@@ -54,6 +54,7 @@ under the License.
flink-shaded-force-shading
flink-shaded-asm-5
+flink-shaded-asm-6
fl
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641561#comment-16641561 ] ASF GitHub Bot commented on FLINK-8033: --- zentol opened a new pull request #48: [FLINK-8033] Add flink-shaded-asm6 URL: https://github.com/apache/flink-shaded/pull/48 This PR adds `flink-shaded-asm6`. This module is required for both java 9 compatibility and scala 2.12 support. Previous versions of asm do not work under java 9. Since our current version of the `maven-shade-plugin` (3.0.0) does not work for projects making use of java 9 modularization we use a newer version (3.1.1, 3.1.0 is the minimum required version) for `flink-shaded-asm6`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou >Assignee: Chesnay Schepler >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327153#comment-16327153 ] Stephan Ewen commented on FLINK-8033: - IIRC, we need to bump Netty to a newer version, because our current Netty version is not Java 9 compatible. > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 >Priority: Major > Fix For: 1.5.0 > > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244309#comment-16244309 ] Hai Zhou UTC+8 commented on FLINK-8033: --- thx [~greghogan], the description has been updated. > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > This is a JIRA to track all issues that found to make Flink compatible with > Java 9. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (FLINK-8033) Build Flink with JDK 9
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244288#comment-16244288 ] Greg Hogan commented on FLINK-8033: --- Does "support" imply more than compiling and running Flink with Java 9? > Build Flink with JDK 9 > -- > > Key: FLINK-8033 > URL: https://issues.apache.org/jira/browse/FLINK-8033 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.4.0 >Reporter: Hai Zhou UTC+8 > Fix For: 1.5.0 > > > This is a JIRA to track all issues that found to support Flink on Java 9 in > the future. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
