[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

[Tzu-Li (Gordon) Tai (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272335#comment-16272335
 ] 

Tzu-Li (Gordon) Tai commented on FLINK-8076:


Merged!

1.5: be913100d8657c7a0acdaa92557af51ab69af0ab

> Upgrade KinesisProducer to 0.10.6 to set properties approperiately
> --
>
> Key: FLINK-8076
> URL: https://issues.apache.org/jira/browse/FLINK-8076
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.4.0
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272322#comment-16272322
 ] 

ASF GitHub Bot commented on FLINK-8076:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5017


> Upgrade KinesisProducer to 0.10.6 to set properties approperiately
> --
>
> Key: FLINK-8076
> URL: https://issues.apache.org/jira/browse/FLINK-8076
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.4.0
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270326#comment-16270326
 ] 

ASF GitHub Bot commented on FLINK-8076:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5017
  
Merging ...


> Upgrade KinesisProducer to 0.10.6 to set properties approperiately
> --
>
> Key: FLINK-8076
> URL: https://issues.apache.org/jira/browse/FLINK-8076
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.4.0
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266580#comment-16266580
 ] 

ASF GitHub Bot commented on FLINK-8076:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5017
  
Thanks @bowenli86!
The changes LGTM. Will merge this soon.


> Upgrade KinesisProducer to 0.10.6 to set properties approperiately
> --
>
> Key: FLINK-8076
> URL: https://issues.apache.org/jira/browse/FLINK-8076
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.4.0
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253961#comment-16253961
 ] 

ASF GitHub Bot commented on FLINK-8076:
---

Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/5017
  
cc @tzulitai 


> Upgrade KinesisProducer to 0.10.6 to set properties approperiately
> --
>
> Key: FLINK-8076
> URL: https://issues.apache.org/jira/browse/FLINK-8076
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.4.0
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8076) Upgrade KinesisProducer to 0.10.6 to set properties approperiately

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252932#comment-16252932
 ] 

ASF GitHub Bot commented on FLINK-8076:
---

GitHub user bowenli86 opened a pull request:

https://github.com/apache/flink/pull/5017

[FLINK-8076] Upgrade KinesisProducer to 0.10.6 to set properties 
approperiately

## What is the purpose of the change

https://github.com/awslabs/amazon-kinesis-producer/issues/124 has been 
resolved in kpl 0.10.6, thus we don't need to explicitly set a few default 
configs anymore.

## Brief change log

- upgraded kpl from 0.10.5 to 0.10.6
- removed some legacy code
- updated unit tests

## Verifying this change


This change added tests and can be verified as follows:

- testRateLimitInProducerConfiguration()
- testThreadingModelInProducerConfiguration()
- testThreadPoolSizeInProducerConfiguration()

## Does this pull request potentially affect one of the following parts:

none

## Documentation

none

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bowenli86/flink FLINK-8076

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5017


commit 0a292d6e0467e8db02f112575f257b3819697c24
Author: Bowen Li 
Date:   2017-11-15T04:31:03Z

[FLINK-8076] Upgrade KinesisProducer to 0.10.6 to set properties 
approperiately




> Upgrade KinesisProducer to 0.10.6 to set properties approperiately
> --
>
> Key: FLINK-8076
> URL: https://issues.apache.org/jira/browse/FLINK-8076
> Project: Flink
>  Issue Type: Improvement
>  Components: Kinesis Connector
>Affects Versions: 1.4.0
>Reporter: Bowen Li
>Assignee: Bowen Li
> Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)