[jira] [Commented] (FLINK-8427) Checkstyle for org.apache.flink.optimizer.costs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326243#comment-16326243
 ] 

ASF GitHub Bot commented on FLINK-8427:
---

Github user greghogan closed the pull request at:

https://github.com/apache/flink/pull/5294


> Checkstyle for org.apache.flink.optimizer.costs
> ---
>
> Key: FLINK-8427
> URL: https://issues.apache.org/jira/browse/FLINK-8427
> Project: Flink
>  Issue Type: Improvement
>  Components: Optimizer
>Affects Versions: 1.5.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8427) Checkstyle for org.apache.flink.optimizer.costs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325708#comment-16325708
 ] 

ASF GitHub Bot commented on FLINK-8427:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/5294
  
I would ignore the optimizer module TBH. There are no recent contributions 
to the module, so we don't benefit from cleaner PR. I also don't know what will 
happen to the module when we start unifying the batch APIs, which 
probably will be either be a full rewrite or removal.


> Checkstyle for org.apache.flink.optimizer.costs
> ---
>
> Key: FLINK-8427
> URL: https://issues.apache.org/jira/browse/FLINK-8427
> Project: Flink
>  Issue Type: Improvement
>  Components: Optimizer
>Affects Versions: 1.5.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-8427) Checkstyle for org.apache.flink.optimizer.costs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325544#comment-16325544
 ] 

ASF GitHub Bot commented on FLINK-8427:
---

GitHub user greghogan opened a pull request:

https://github.com/apache/flink/pull/5294

[FLINK-8427] [optimizer] Checkstyle for org.apache.flink.optimizer.costs

## What is the purpose of the change

Enforce checkstyle for org.apache.flink.optimizer.costs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greghogan/flink 
8427_checkstyle_for_org_apache_flink_optimizer_costs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5294


commit 54f0303541aa737723081d1d927b14c877527de3
Author: Greg Hogan 
Date:   2018-01-12T21:12:37Z

Optimize imports

commit 6b969f5048132bafe80330d28c156f6530a9a22b
Author: Greg Hogan 
Date:   2018-01-12T21:15:13Z

Trailing whitespace

commit a61f7b862a20142f29375237d5b428b40dee75c3
Author: Greg Hogan 
Date:   2018-01-12T21:18:10Z

[FLINK-8427] [optimizer] Checkstyle for org.apache.flink.optimizer.costs




> Checkstyle for org.apache.flink.optimizer.costs
> ---
>
> Key: FLINK-8427
> URL: https://issues.apache.org/jira/browse/FLINK-8427
> Project: Flink
>  Issue Type: Improvement
>  Components: Optimizer
>Affects Versions: 1.5.0
>Reporter: Greg Hogan
>Assignee: Greg Hogan
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)