[jira] [Commented] (FLINK-8476) ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
[
https://issues.apache.org/jira/browse/FLINK-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345170#comment-16345170
]
ASF GitHub Bot commented on FLINK-8476:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5338
> ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
> --
>
> Key: FLINK-8476
> URL: https://issues.apache.org/jira/browse/FLINK-8476
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Trivial
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT}} is unused and should probably
> be deprecated.
> [~till.rohrmann]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8476) ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
[
https://issues.apache.org/jira/browse/FLINK-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343222#comment-16343222
]
ASF GitHub Bot commented on FLINK-8476:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5338
merging.
> ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
> --
>
> Key: FLINK-8476
> URL: https://issues.apache.org/jira/browse/FLINK-8476
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Trivial
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT}} is unused and should probably
> be deprecated.
> [~till.rohrmann]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8476) ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
[
https://issues.apache.org/jira/browse/FLINK-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340631#comment-16340631
]
ASF GitHub Bot commented on FLINK-8476:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5338
Thanks, good change, +1
> ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
> --
>
> Key: FLINK-8476
> URL: https://issues.apache.org/jira/browse/FLINK-8476
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Trivial
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT}} is unused and should probably
> be deprecated.
> [~till.rohrmann]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8476) ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
[
https://issues.apache.org/jira/browse/FLINK-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335676#comment-16335676
]
ASF GitHub Bot commented on FLINK-8476:
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5338
[FLINK-8476][config][HA] Deprecate HA config constants
## What is the purpose of the change
This PR deprecates multiple HA-related `ConfigConstants`.
## Brief change log
Deprecated:
- CC#HA_MODE as it is completely subsumed by HAOptions#HA_MODE
- CC#HA_JOB_DELAY as it is completely subsumed by HAOptions#HA_JOB_DELAY
- CC#DEFAULT_HA_MODE as subsumed by HAOptions#HA_MODE
- still used by 2 tests (HighAvailabilityModeTest / TestingUtils
(scala))
- CC#DEFAULT_HA_JOB_MANAGER_PORT as it is no longer used
## Verifying this change
Only modifies annotations / javadocs so it shouldn't affect functionality.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8476
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5338
commit af2d4d7d94b3ed4a54b2310f7feaba0ac3142321
Author: zentol
Date: 2018-01-23T11:32:06Z
[FLINK-8476][config][HA] Deprecate HA config constants
> ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
> --
>
> Key: FLINK-8476
> URL: https://issues.apache.org/jira/browse/FLINK-8476
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Chesnay Schepler
>Priority: Trivial
> Fix For: 1.5.0
>
>
> {{ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT}} is unused and should probably
> be deprecated.
> [~till.rohrmann]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8476) ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
[
https://issues.apache.org/jira/browse/FLINK-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335499#comment-16335499
]
Till Rohrmann commented on FLINK-8476:
--
Yes indeed [~Zentol]. I think we can remove
{{ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT}}.
> ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused
> --
>
> Key: FLINK-8476
> URL: https://issues.apache.org/jira/browse/FLINK-8476
> Project: Flink
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Priority: Trivial
>
> {{ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT}} is unused and should probably
> be deprecated.
> [~till.rohrmann]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
