[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428313#comment-16428313
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5808
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428165#comment-16428165
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5808
merging.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426664#comment-16426664
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5808
Thanks @zentol for review. 👍
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425224#comment-16425224
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5808
Hi, @zentol I have updated the code based on your suggestions. Could you
can take another look when available ?
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425189#comment-16425189
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179062944
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
--- End diff --
oh my god.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425188#comment-16425188
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179062712
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
--- End diff --
Oh. Sorry. I see.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425186#comment-16425186
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179062374
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -321,8 +321,8 @@
* credit-based flow control.
*/
@Deprecated
- public static final ConfigOption
NETWORK_CREDIT_BASED_FLOW_CONTROL_ENABLED =
-
key("taskmanager.network.credit-based-flow-control.enabled")
+ public static final ConfigOption
TASKMANAGER_NETWORK_CREDIT_MODEL =
--- End diff --
Will change.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425182#comment-16425182
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179061417
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
--- End diff --
```
public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
key("taskmanager.registration.initial-backoff")
.defaultValue("500 ms")
>
.withDeprecatedKeys("taskmanager.initial-registration-pause")
.withDescription("");
```
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425162#comment-16425162
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179060468
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
--- End diff --
I think there already has deprecated key
```"taskmanager.initial-registration-pause"``` in the
```ConfigConstants.java``` file. Below:
```
/**
* The initial registration pause between two consecutive registration
attempts. The pause
* is doubled for each new registration attempt until it reaches the
maximum registration pause.
*
* @deprecated use {@link TaskManagerOptions#INITIAL_REGISTRATION_BACKOFF}
instead
*/
@Deprecated
public static final String TASK_MANAGER_INITIAL_REGISTRATION_PAUSE =
"taskmanager.initial-registration-pause";
```
Or, I am guessing what you mean is that I should change the value
```taskmanager.initial-registration-pause``` to
```taskmanager.registration.initial-backoff``` in ```ConfigConstants.java```
file. But you said ((nor should we change the value)) before. So, Hmm. Am I
missing something ?
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425150#comment-16425150
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179056634
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+* @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
--- End diff --
Ah. Makes better sense to me.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425145#comment-16425145
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179055088
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+* @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
--- End diff --
There is no reference because the project works against
`TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD`. We keep this field
around since it is in a `@Public` class, and thus part of the stable API.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425141#comment-16425141
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179054013
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+* @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
--- End diff --
But confused me is that there is no reference to this field in project.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425140#comment-16425140
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179053677
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+* @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
--- End diff --
will change.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425111#comment-16425111
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045129
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -153,13 +153,13 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
- public static final ConfigOption
DEBUG_MEMORY_USAGE_START_LOG_THREAD =
- key("taskmanager.debug.memory.startLogThread")
+ public static final ConfigOption DEBUG_MEMORY_LOG =
+ key("taskmanager.debug.memory.log")
.defaultValue(false)
.withDescription("Flag indicating whether to start a
thread, which repeatedly logs the memory usage of the JVM.");
- public static final ConfigOption
DEBUG_MEMORY_USAGE_LOG_INTERVAL_MS =
- key("taskmanager.debug.memory.logIntervalMs")
+ public static final ConfigOption DEBUG_MEMORY_USAGE_LOG_INTERVAL =
+ key("taskmanager.debug.memory.log-interval")
--- End diff --
missing deprecated key `"taskmanager.debug.memory.logIntervalMs"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425114#comment-16425114
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045805
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+* @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
/**
* The interval (in ms) for the log thread to log the current memory
usage.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_LOG_INTERVAL_MS} instead
--- End diff --
I would revert the renaming; it' a useful piece of info that we're dealing
with milliseconds.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425107#comment-16425107
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179044920
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
--- End diff --
missing deprecated key `"taskmanager.initial-registration-pause"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425115#comment-16425115
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045294
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -321,8 +321,8 @@
* credit-based flow control.
*/
@Deprecated
- public static final ConfigOption
NETWORK_CREDIT_BASED_FLOW_CONTROL_ENABLED =
-
key("taskmanager.network.credit-based-flow-control.enabled")
+ public static final ConfigOption
TASKMANAGER_NETWORK_CREDIT_MODEL =
+ key("taskmanager.network.credit-model")
--- End diff --
even though this key is new I would still add the deprecated key
`"taskmanager.network.credit-based-flow-control.enabled"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425106#comment-16425106
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179044730
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
-* @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+* @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
--- End diff --
We can't rename this variable (nor should we change the value) since this
class is `@Public`. The referral to the `TaskManagerOptions` is enough.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425110#comment-16425110
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045089
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -153,13 +153,13 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
- public static final ConfigOption
DEBUG_MEMORY_USAGE_START_LOG_THREAD =
- key("taskmanager.debug.memory.startLogThread")
+ public static final ConfigOption DEBUG_MEMORY_LOG =
+ key("taskmanager.debug.memory.log")
--- End diff --
missing deprecated key `"taskmanager.debug.memory.startLogThread"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425113#comment-16425113
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045016
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
.defaultValue("500 ms")
- .withDescription("The initial registration pause
between two consecutive registration attempts. The pause" +
- " is doubled for each new registration attempt
until it reaches the maximum registration pause.");
+ .withDescription("The initial registration backoff
between two consecutive registration attempts. The backoff" +
+ " is doubled for each new registration attempt
until it reaches the maximum registration backoff.");
/**
-* The maximum registration pause between two consecutive registration
attempts.
+* The maximum registration backoff between two consecutive
registration attempts.
*/
- public static final ConfigOption MAX_REGISTRATION_PAUSE =
- key("taskmanager.max-registration-pause")
+ public static final ConfigOption REGISTRATION_MAX_BACKOFF =
+ key("taskmanager.registration.max-backoff")
.defaultValue("30 s")
- .withDescription("The maximum registration pause
between two consecutive registration attempts. The max" +
- " registration pause requires a time unit
specifier (ms/s/min/h/d).");
+ .withDescription("The maximum registration backoff
between two consecutive registration attempts. The max" +
+ " registration backoff requires a time unit
specifier (ms/s/min/h/d).");
/**
-* The pause after a registration has been refused by the job manager
before retrying to connect.
+* The backoff after a registration has been refused by the job manager
before retrying to connect.
*/
- public static final ConfigOption REFUSED_REGISTRATION_PAUSE =
- key("taskmanager.refused-registration-pause")
+ public static final ConfigOption REFUSED_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.refused-backoff")
--- End diff --
missing deprecated key `"taskmanager.refused-registration-pause"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDurati
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425108#comment-16425108
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179044973
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
.defaultValue("500 ms")
- .withDescription("The initial registration pause
between two consecutive registration attempts. The pause" +
- " is doubled for each new registration attempt
until it reaches the maximum registration pause.");
+ .withDescription("The initial registration backoff
between two consecutive registration attempts. The backoff" +
+ " is doubled for each new registration attempt
until it reaches the maximum registration backoff.");
/**
-* The maximum registration pause between two consecutive registration
attempts.
+* The maximum registration backoff between two consecutive
registration attempts.
*/
- public static final ConfigOption MAX_REGISTRATION_PAUSE =
- key("taskmanager.max-registration-pause")
+ public static final ConfigOption REGISTRATION_MAX_BACKOFF =
--- End diff --
missing deprecated key `"taskmanager.max-registration-pause"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425112#comment-16425112
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045392
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -321,8 +321,8 @@
* credit-based flow control.
*/
@Deprecated
- public static final ConfigOption
NETWORK_CREDIT_BASED_FLOW_CONTROL_ENABLED =
-
key("taskmanager.network.credit-based-flow-control.enabled")
+ public static final ConfigOption
TASKMANAGER_NETWORK_CREDIT_MODEL =
--- End diff --
remove `TASKMANAGER_` prefix, it is redundant as the option is defined int
he `TaskManagerOptions`.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425109#comment-16425109
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045058
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
-* The initial registration pause between two consecutive registration
attempts. The pause
-* is doubled for each new registration attempt until it reaches the
maximum registration pause.
+* The initial registration backoff between two consecutive
registration attempts. The backoff
+* is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
.defaultValue("500 ms")
- .withDescription("The initial registration pause
between two consecutive registration attempts. The pause" +
- " is doubled for each new registration attempt
until it reaches the maximum registration pause.");
+ .withDescription("The initial registration backoff
between two consecutive registration attempts. The backoff" +
+ " is doubled for each new registration attempt
until it reaches the maximum registration backoff.");
/**
-* The maximum registration pause between two consecutive registration
attempts.
+* The maximum registration backoff between two consecutive
registration attempts.
*/
- public static final ConfigOption MAX_REGISTRATION_PAUSE =
- key("taskmanager.max-registration-pause")
+ public static final ConfigOption REGISTRATION_MAX_BACKOFF =
+ key("taskmanager.registration.max-backoff")
.defaultValue("30 s")
- .withDescription("The maximum registration pause
between two consecutive registration attempts. The max" +
- " registration pause requires a time unit
specifier (ms/s/min/h/d).");
+ .withDescription("The maximum registration backoff
between two consecutive registration attempts. The max" +
+ " registration backoff requires a time unit
specifier (ms/s/min/h/d).");
/**
-* The pause after a registration has been refused by the job manager
before retrying to connect.
+* The backoff after a registration has been refused by the job manager
before retrying to connect.
*/
- public static final ConfigOption REFUSED_REGISTRATION_PAUSE =
- key("taskmanager.refused-registration-pause")
+ public static final ConfigOption REFUSED_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.refused-backoff")
.defaultValue("10 s")
- .withDescription("The pause after a registration has
been refused by the job manager before retrying to connect.");
+ .withDescription("The backoff after a registration has
been refused by the job manager before retrying to connect.");
/**
-* Defines the maximum time it can take for the TaskManager
registration. If the duration is
+* Defines the timeout it can take for the TaskManager registration. If
the duration is
* exceeded without a successful registration, then the TaskManager
terminates.
*/
- public static final ConfigOption MAX_REGISTRATION_DURATION =
- key("taskmanager.maxRegistrationDuration")
+ public static final ConfigOption REGISTRATION_TIMEOUT =
+ key("taskmanager.registration.timeout")
--- End diff --
missing deprecated key `"taskmanager.maxRegistrationDuration"`
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424817#comment-16424817
]
ASF GitHub Bot commented on FLINK-8835:
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5808
cc @StephanEwen @aljoscha
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424030#comment-16424030
]
ASF GitHub Bot commented on FLINK-8835:
---
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5808
[FLINK-8835] [taskmanager] Fix TaskManager config keys
## What is the purpose of the change
Fix TaskManager config keys to make it easier for users.
## Brief change log
Change the original key and variable name to a easier way.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink
flink-8835-taskmanager-config-key
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5808
commit a4df41079edd228ea346227f2f04b41d694c0420
Author: zhangminglei
Date: 2018-04-03T13:23:19Z
[FLINK-8835] [taskmanager] Fix TaskManager config keys
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423928#comment-16423928
]
mingleizhang commented on FLINK-8835:
-
Sorry for later. [~Zentol] I forgot this issue, I will give a PR soon.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> * {{taskmanager.exactly-once.blocking.data.enabled}} to
> {{task.checkpoint.alignment.blocking}} (we already have
> {{task.checkpoint.alignment.max-size}})
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423919#comment-16423919
]
Chesnay Schepler commented on FLINK-8835:
-
[~mingleizhang] How far along are you with this issue? The variable name does
not have to match the key.
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> * {{taskmanager.exactly-once.blocking.data.enabled}} to
> {{task.checkpoint.alignment.blocking}} (we already have
> {{task.checkpoint.alignment.max-size}})
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-8835) Fix TaskManager config keys
[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385857#comment-16385857
]
mingleizhang commented on FLINK-8835:
-
Hi, [~StephanEwen] I would like to confirm one stuff with you. I think we just
rename the key name is enough, but I found, Is it necessary to refactor the
corresponding method and variable name ? I do not think so. Because only the
keys name exposes to users while method and variable name only exposes to
developer.
like the following, I just want to rename the key to
{{taskmanager.registration.initial-backoff}}, instead rename the
{{INITIAL_REGISTRATION_PAUSE}}.What do you think of that ? Thanks.
{code:java}
public static final ConfigOption INITIAL_REGISTRATION_PAUSE =
key("taskmanager.registration.initial-backoff")
.defaultValue("500 ms")
{code}
> Fix TaskManager config keys
> ---
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
>Reporter: Stephan Ewen
>Assignee: mingleizhang
>Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> * {{taskmanager.exactly-once.blocking.data.enabled}} to
> {{task.checkpoint.alignment.blocking}} (we already have
> {{task.checkpoint.alignment.max-size}})
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
