[jira] [Commented] (FLINK-9223) bufferConsumers should be closed in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
[
https://issues.apache.org/jira/browse/FLINK-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447359#comment-16447359
]
ASF GitHub Bot commented on FLINK-9223:
---
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5882
> bufferConsumers should be closed in
> SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
> -
>
> Key: FLINK-9223
> URL: https://issues.apache.org/jira/browse/FLINK-9223
> Project: Flink
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: vinoyang
>Priority: Minor
>
> {code}
> BufferConsumer[] bufferConsumers = Arrays.stream(bufferBuilders).map(
> BufferBuilder::createBufferConsumer
> ).toArray(BufferConsumer[]::new);
> {code}
> After operation on bufferConsumers is done, the BufferConsumer's in the array
> should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9223) bufferConsumers should be closed in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
[
https://issues.apache.org/jira/browse/FLINK-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446905#comment-16446905
]
ASF GitHub Bot commented on FLINK-9223:
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5882
Looks good, thanks!
Will merge this in the next batch...
> bufferConsumers should be closed in
> SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
> -
>
> Key: FLINK-9223
> URL: https://issues.apache.org/jira/browse/FLINK-9223
> Project: Flink
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: vinoyang
>Priority: Minor
>
> {code}
> BufferConsumer[] bufferConsumers = Arrays.stream(bufferBuilders).map(
> BufferBuilder::createBufferConsumer
> ).toArray(BufferConsumer[]::new);
> {code}
> After operation on bufferConsumers is done, the BufferConsumer's in the array
> should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9223) bufferConsumers should be closed in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
[
https://issues.apache.org/jira/browse/FLINK-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445369#comment-16445369
]
ASF GitHub Bot commented on FLINK-9223:
---
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5882
[FLINK-9223] bufferConsumers should be closed in
SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
## What is the purpose of the change
*This pull request closes buffer consumers in
SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd after
operation has done*
## Brief change log
- *Call close method after operation on bufferConsumers is done*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9223
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5882.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5882
commit 6c4608857b5450493c24c1b77df0e6665dfc2725
Author: yanghua
Date: 2018-04-20T06:11:45Z
[FLINK-9223] bufferConsumers should be closed in
SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
> bufferConsumers should be closed in
> SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
> -
>
> Key: FLINK-9223
> URL: https://issues.apache.org/jira/browse/FLINK-9223
> Project: Flink
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: vinoyang
>Priority: Minor
>
> {code}
> BufferConsumer[] bufferConsumers = Arrays.stream(bufferBuilders).map(
> BufferBuilder::createBufferConsumer
> ).toArray(BufferConsumer[]::new);
> {code}
> After operation on bufferConsumers is done, the BufferConsumer's in the array
> should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9223) bufferConsumers should be closed in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
[
https://issues.apache.org/jira/browse/FLINK-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445370#comment-16445370
]
ASF GitHub Bot commented on FLINK-9223:
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5882
cc @tillrohrmann
> bufferConsumers should be closed in
> SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd
> -
>
> Key: FLINK-9223
> URL: https://issues.apache.org/jira/browse/FLINK-9223
> Project: Flink
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: vinoyang
>Priority: Minor
>
> {code}
> BufferConsumer[] bufferConsumers = Arrays.stream(bufferBuilders).map(
> BufferBuilder::createBufferConsumer
> ).toArray(BufferConsumer[]::new);
> {code}
> After operation on bufferConsumers is done, the BufferConsumer's in the array
> should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
