[
https://issues.apache.org/jira/browse/FLINK-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540744#comment-16540744
]
ASF GitHub Bot commented on FLINK-9818:
---
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6314
[FLINK-9818] Add cluster component command line parser
## What is the purpose of the change
The cluster component command line parser is responsible for parsing the
common command line
arguments with which the cluster components are started. These include the
configDir, webui-port
and dynamic properties.
cc @GJL
## Verifying this change
- Added `EntrypointClusterConfigurationParserFactoryTest` and
`ClusterConfigurationParserFactoryTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink commandLineParser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6314
commit b798af824433657ca215f8598112094a23819ee0
Author: Till Rohrmann
Date: 2018-07-11T15:30:53Z
[hotfix] Make PackagedProgram(Class, String...) constructor public
commit b577425b67dd5b33a8094989f7a25145ac60d542
Author: Till Rohrmann
Date: 2018-07-11T15:41:27Z
[FLINK-9818] Add cluster component command line parser
The cluster component command line parser is responsible for parsing the
common command line
arguments with which the cluster components are started. These include the
configDir, webui-port
and dynamic properties.
> Add cluster component command line parser
> -
>
> Key: FLINK-9818
> URL: https://issues.apache.org/jira/browse/FLINK-9818
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
>Affects Versions: 1.6.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> In order to parse command line options for the cluster components
> ({{TaskManagerRunner}}, {{ClusterEntrypoints}}), we should add a
> {{CommandLineParser}} which supports the common command line options
> ({{--configDir}}, {{--webui-port}} and dynamic properties which can override
> configuration values).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
