[jira] [Updated] (FLINK-12459) YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of classpath between user jars and flink jars
[ https://issues.apache.org/jira/browse/FLINK-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12459: --- Labels: pull-request-available (was: ) > YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of > classpath between user jars and flink jars > -- > > Key: FLINK-12459 > URL: https://issues.apache.org/jira/browse/FLINK-12459 > Project: Flink > Issue Type: Improvement > Components: Command Line Client >Reporter: Victor Wong >Assignee: Victor Wong >Priority: Minor > Labels: pull-request-available > Attachments: image-2019-05-09-15-04-36-360.png > > > When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think > the user jars should come after all flink libs in runtime classpath, > including "flink.jar". > But actually it's not: > org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster > !image-2019-05-09-15-04-36-360.png! > I'm not sure if it's an expected behavior, because if a user forgets to mark > Flink dependencies as "provided", it causes conflicts in detached mode. > Can we optimize it like this: > [https://github.com/apache/flink/commit/86f264d76b3cfd89346f8c5ab2b8a9e99600aaee] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-12459) YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of classpath between user jars and flink jars
[ https://issues.apache.org/jira/browse/FLINK-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Wong updated FLINK-12459: Description: When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think the user jars should come after all flink libs in runtime classpath, including "flink.jar". But actually it's not: org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster !image-2019-05-09-15-04-36-360.png! I'm not sure if it's an expected behavior, because if a user forgets to mark Flink dependencies as "provided", it causes conflicts in detached mode. was: When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think the user jars should come after all flink libs in runtime classpath, including "flink.jar". But actually it's not: org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster !image-2019-05-09-15-04-36-360.png! I'm not sure if it's an expected behavior, because if a user forgets to mark Flink dependencies as "provided", it causes conflicts in detached mode. Can we optimize it like this: [https://github.com/apache/flink/commit/86f264d76b3cfd89346f8c5ab2b8a9e99600aaee] > YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of > classpath between user jars and flink jars > -- > > Key: FLINK-12459 > URL: https://issues.apache.org/jira/browse/FLINK-12459 > Project: Flink > Issue Type: Improvement > Components: Command Line Client >Reporter: Victor Wong >Assignee: Victor Wong >Priority: Minor > Labels: pull-request-available > Attachments: image-2019-05-09-15-04-36-360.png > > Time Spent: 10m > Remaining Estimate: 0h > > When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think > the user jars should come after all flink libs in runtime classpath, > including "flink.jar". > But actually it's not: > org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster > !image-2019-05-09-15-04-36-360.png! > I'm not sure if it's an expected behavior, because if a user forgets to mark > Flink dependencies as "provided", it causes conflicts in detached mode. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-12459) YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of classpath between user jars and flink jars
[ https://issues.apache.org/jira/browse/FLINK-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Wong updated FLINK-12459: Description: When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think the user jars should come after all flink libs in runtime classpath, including "flink.jar". But actually it's not: org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster !image-2019-05-09-15-04-36-360.png! I'm not sure if it's an expected behavior, because if a user forgets to mark Flink dependencies as "provided", it causes conflicts in detached mode. Can we optimize it like this: [https://github.com/apache/flink/commit/86f264d76b3cfd89346f8c5ab2b8a9e99600aaee] was: When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think the user jars should come after all flink libs in runtime classpath, including "flink.jar". But actually it's not: org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster !image-2019-05-09-15-04-36-360.png! I'm not sure if it's an expected behavior, because if a user forgets to mark Flink dependencies as "provided", it causes conflicts in detached mode. > YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of > classpath between user jars and flink jars > -- > > Key: FLINK-12459 > URL: https://issues.apache.org/jira/browse/FLINK-12459 > Project: Flink > Issue Type: Improvement > Components: Command Line Client >Reporter: Victor Wong >Assignee: Victor Wong >Priority: Minor > Attachments: image-2019-05-09-15-04-36-360.png > > > When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think > the user jars should come after all flink libs in runtime classpath, > including "flink.jar". > But actually it's not: > org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster > !image-2019-05-09-15-04-36-360.png! > I'm not sure if it's an expected behavior, because if a user forgets to mark > Flink dependencies as "provided", it causes conflicts in detached mode. > Can we optimize it like this: > [https://github.com/apache/flink/commit/86f264d76b3cfd89346f8c5ab2b8a9e99600aaee] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-12459) YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of classpath between user jars and flink jars
[ https://issues.apache.org/jira/browse/FLINK-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor Wong updated FLINK-12459: Summary: YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of classpath between user jars and flink jars (was: YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of classpath between user jars and flink jar) > YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR should affect the order of > classpath between user jars and flink jars > -- > > Key: FLINK-12459 > URL: https://issues.apache.org/jira/browse/FLINK-12459 > Project: Flink > Issue Type: Improvement > Components: Command Line Client >Reporter: Victor Wong >Assignee: Victor Wong >Priority: Minor > Attachments: image-2019-05-09-15-04-36-360.png > > > When setting YarnConfigOptions#CLASSPATH_INCLUDE_USER_JAR to "LAST", I think > the user jars should come after all flink libs in runtime classpath, > including "flink.jar". > But actually it's not: > org.apache.flink.yarn.AbstractYarnClusterDescriptor#startAppMaster > !image-2019-05-09-15-04-36-360.png! > I'm not sure if it's an expected behavior, because if a user forgets to mark > Flink dependencies as "provided", it causes conflicts in detached mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
