[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song updated FLINK-13692:
-
Fix Version/s: (was: 1.14.0)
(was: 1.9.4)
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Minor
> Labels: auto-deprioritized-major
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-13692:
---
Labels: auto-deprioritized-major (was: stale-major)
Priority: Minor (was: Major)
This issue was labeled "stale-major" 7 ago and has not received any updates so
it is being deprioritized. If this ticket is actually Major, please raise the
priority and ask a committer to assign you the issue or revive the public
discussion.
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Minor
> Labels: auto-deprioritized-major
> Fix For: 1.9.4, 1.14.0
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz updated FLINK-13692:
-
Fix Version/s: (was: 1.13.0)
1.14.0
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Labels: stale-major
> Fix For: 1.9.4, 1.14.0
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-13692:
---
Labels: stale-major (was: )
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Labels: stale-major
> Fix For: 1.9.4, 1.13.0
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-13692:
---
Fix Version/s: (was: 1.12.0)
1.13.0
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.9.4, 1.13.0
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dian Fu updated FLINK-13692:
Fix Version/s: (was: 1.9.3)
1.9.4
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.11.0, 1.9.4
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hequn Cheng updated FLINK-13692:
Fix Version/s: (was: 1.9.2)
1.9.3
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.11.0, 1.9.3
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated FLINK-13692:
--
Fix Version/s: (was: 1.10.0)
1.11.0
Change fix version to 1.11.0 since we already reached feature freeze for 1.10.0
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.9.2, 1.11.0
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-13692:
Fix Version/s: (was: 1.9.1)
1.9.2
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.10.0, 1.9.2
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-13692:
--
Description:
With FLINK-11159 we changed the signature of
{{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}}
to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which
causes users of this interface having to adapt their implementation and
recompile it. Since {{CompletedCheckpointStore}} is no public API, this change
is technically ok, but not so nice.
If we decide to provide backwards compatibility, then we should still keep
{{getLatestCheckpoint()}} and add a deprecation annotation to it. At least, we
should update the JavaDocs of the
{{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
passed parameter states.
was:
With FLINK-11159 we changed the signature of
{{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}}
to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which
causes users of this interface to adapt their implementation and recompile it.
Since {{CompletedCheckpointStore}} is no public API, this change is technically
ok, but not so nice.
If we decide to provide backwards compatibility, then we should still keep
{{getLatestCheckpoint()}} and add a deprecation annotation to it. At least, we
should update the JavaDocs of the
{{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
passed parameter states.
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.10.0, 1.9.1
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface having to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible?
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-13692:
--
Summary: Make CompletedCheckpointStore backwards compatible? (was: Make
CompletedCheckpointStore backwards compatible)
> Make CompletedCheckpointStore backwards compatible?
> ---
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.10.0, 1.9.1
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (FLINK-13692) Make CompletedCheckpointStore backwards compatible
[
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-13692:
--
Description:
With FLINK-11159 we changed the signature of
{{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}}
to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which
causes users of this interface to adapt their implementation and recompile it.
Since {{CompletedCheckpointStore}} is no public API, this change is technically
ok, but not so nice.
If we decide to provide backwards compatibility, then we should still keep
{{getLatestCheckpoint()}} and add a deprecation annotation to it. At least, we
should update the JavaDocs of the
{{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
passed parameter states.
was:
With FLINK-11159 we changed the signature of
{{CompletedCheckpointStore#getLatestCheckpoint}} from {{getLatestCheckpoint()}}
to {{getLatestCheckpoint(boolean)}}. This is an API breaking change which
causes users of this interface to adapt their implementation and recompile it.
Since {{CompletedCheckpointStore}} is no public API, this change is technically
ok, but not so nice.
If we decide to provide backwards compatibility, then we should still keep
{{getLatestCheckpoint()}} and add a deprecation annotation to it. Otherwise we
should close this issue.
> Make CompletedCheckpointStore backwards compatible
> --
>
> Key: FLINK-13692
> URL: https://issues.apache.org/jira/browse/FLINK-13692
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Till Rohrmann
>Priority: Major
> Fix For: 1.10.0, 1.9.1
>
>
> With FLINK-11159 we changed the signature of
> {{CompletedCheckpointStore#getLatestCheckpoint}} from
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API
> breaking change which causes users of this interface to adapt their
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no
> public API, this change is technically ok, but not so nice.
> If we decide to provide backwards compatibility, then we should still keep
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least,
> we should update the JavaDocs of the
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the
> passed parameter states.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
