[jira] [Updated] (FLINK-15975) Test may fail due if HashMap iterates in a different order

2020-02-28 Thread Chesnay Schepler (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chesnay Schepler updated FLINK-15975:
-
Component/s: Tests

> Test may fail due if HashMap iterates in a different order
> --
>
> Key: FLINK-15975
> URL: https://issues.apache.org/jira/browse/FLINK-15975
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive, Tests
>Reporter: testfixer0
>Assignee: testfixer0
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: FLINK-15975-000.patch, FLINK-15975-001.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The test `testMap` in `HiveGenericUDFTest` may fail due if HashMap iterates 
> in a different order. `testMap` depends on `getConversion` and 
> `toFlinkObject` in class `MapObjectInspector`. When the `inspector` is the 
> instance of `MapObjectInspector`, it can return a `HashMap`. However, 
> `HashMap` does not guarantee any specific order of entries. Thus, the test 
> can fail due to a different iteration order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-15975) Test may fail due if HashMap iterates in a different order

2020-02-15 Thread testfixer0 (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

testfixer0 updated FLINK-15975:
---
Description: The test `testMap` in `HiveGenericUDFTest` may fail due if 
HashMap iterates in a different order. `testMap` depends on `getConversion` and 
`toFlinkObject` in class `MapObjectInspector`. When the `inspector` is the 
instance of `MapObjectInspector`, it can return a `HashMap`. However, `HashMap` 
does not guarantee any specific order of entries. Thus, the test can fail due 
to a different iteration order.  (was: The test `testMap` in 
`HiveGenericUDFTest` fails. As you suggested, we'd be better to change 
assertions in test code to cater to the indeterminacy.  So, I propose a new 
proposal. )

> Test may fail due if HashMap iterates in a different order
> --
>
> Key: FLINK-15975
> URL: https://issues.apache.org/jira/browse/FLINK-15975
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive
>Reporter: testfixer0
>Priority: Minor
>  Labels: pull-request-available
> Attachments: FLINK-15975-000.patch, FLINK-15975-001.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The test `testMap` in `HiveGenericUDFTest` may fail due if HashMap iterates 
> in a different order. `testMap` depends on `getConversion` and 
> `toFlinkObject` in class `MapObjectInspector`. When the `inspector` is the 
> instance of `MapObjectInspector`, it can return a `HashMap`. However, 
> `HashMap` does not guarantee any specific order of entries. Thus, the test 
> can fail due to a different iteration order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-15975) Test may fail due if HashMap iterates in a different order

2020-02-15 Thread testfixer0 (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

testfixer0 updated FLINK-15975:
---
Summary: Test may fail due if HashMap iterates in a different order  (was: 
Use LinkedHashMap for deterministic iterations)

> Test may fail due if HashMap iterates in a different order
> --
>
> Key: FLINK-15975
> URL: https://issues.apache.org/jira/browse/FLINK-15975
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive
>Reporter: testfixer0
>Priority: Minor
>  Labels: pull-request-available
> Attachments: FLINK-15975-000.patch, FLINK-15975-001.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The test `testMap` in `HiveGenericUDFTest` fails. As you suggested, we'd be 
> better to change assertions in test code to cater to the indeterminacy.  So, 
> I propose a new proposal. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)