[jira] [Updated] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak
[
https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-18061:
---
Labels: pull-request-available (was: )
> TableResult#collect should return closeable iterator to avoid resource leak
> ---
>
> Key: FLINK-18061
> URL: https://issues.apache.org/jira/browse/FLINK-18061
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Reporter: godfrey he
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.11.0
>
>
> as discussed in ML:
> http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e...@apache.org%3e,
> we should return a closeable iterator for TableResult#collect method *to
> avoid resource leak*. The suggested change is:
> {code:java}
> public interface TableResult {
> CloseableIterator collect();
> }
> {code}
> we use existing {{org.apache.flink.util.CloseableIterator}} instead of
> additional api class, and {{CollectResultIterator}} can also inherit from
> {{CloseableIterator}}.
> This change does not break current api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak
[
https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated FLINK-18061:
---
Description:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e...@apache.org%3e,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableIterator collect();
}
{code}
we use existing {{org.apache.flink.util.CloseableIterator}} instead of
additional api class, and {{CollectResultIterator}} can also inherit from
{{CloseableIterator}}.
This change does not break current api.
was:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e...@apache.org%3e,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
{code}
This change does not break current api.
> TableResult#collect should return closeable iterator to avoid resource leak
> ---
>
> Key: FLINK-18061
> URL: https://issues.apache.org/jira/browse/FLINK-18061
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Reporter: godfrey he
>Priority: Blocker
> Fix For: 1.11.0
>
>
> as discussed in ML:
> http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e...@apache.org%3e,
> we should return a closeable iterator for TableResult#collect method *to
> avoid resource leak*. The suggested change is:
> {code:java}
> public interface TableResult {
> CloseableIterator collect();
> }
> {code}
> we use existing {{org.apache.flink.util.CloseableIterator}} instead of
> additional api class, and {{CollectResultIterator}} can also inherit from
> {{CloseableIterator}}.
> This change does not break current api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak
[
https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated FLINK-18061:
---
Description:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e...@apache.org%3e,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
{code}
This change does not break current api.
was:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
{code}
This change does not break current api.
> TableResult#collect should return closeable iterator to avoid resource leak
> ---
>
> Key: FLINK-18061
> URL: https://issues.apache.org/jira/browse/FLINK-18061
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Reporter: godfrey he
>Priority: Blocker
> Fix For: 1.11.0
>
>
> as discussed in ML:
> http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3cd4ee47e1-0214-aa2f-f5ac-c9daf708e...@apache.org%3e,
> we should return a closeable iterator for TableResult#collect method *to
> avoid resource leak*. The suggested change is:
> {code:java}
> public interface TableResult {
> CloseableRowIterator collect();
> }
> public interface CloseableRowIterator extends Iterator, AutoCloseable {
> }
> {code}
> This change does not break current api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak
[
https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated FLINK-18061:
---
Description:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
This change does not break current api.
was:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
```
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
```
This change does not break current api.
> TableResult#collect should return closeable iterator to avoid resource leak
> ---
>
> Key: FLINK-18061
> URL: https://issues.apache.org/jira/browse/FLINK-18061
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Reporter: godfrey he
>Priority: Blocker
> Fix For: 1.11.0
>
>
> as discussed in ML:
> http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
> we should return a closeable iterator for TableResult#collect method *to
> avoid resource leak*. The suggested change is:
> {code:java}
> public interface TableResult {
> CloseableRowIterator collect();
> }
> public interface CloseableRowIterator extends Iterator, AutoCloseable {
> }
> This change does not break current api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak
[
https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated FLINK-18061:
---
Description:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
{code}
This change does not break current api.
was:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
{code:java}
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
This change does not break current api.
> TableResult#collect should return closeable iterator to avoid resource leak
> ---
>
> Key: FLINK-18061
> URL: https://issues.apache.org/jira/browse/FLINK-18061
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Reporter: godfrey he
>Priority: Blocker
> Fix For: 1.11.0
>
>
> as discussed in ML:
> http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
> we should return a closeable iterator for TableResult#collect method *to
> avoid resource leak*. The suggested change is:
> {code:java}
> public interface TableResult {
> CloseableRowIterator collect();
> }
> public interface CloseableRowIterator extends Iterator, AutoCloseable {
> }
> {code}
> This change does not break current api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-18061) TableResult#collect should return closeable iterator to avoid resource leak
[
https://issues.apache.org/jira/browse/FLINK-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he updated FLINK-18061:
---
Description:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
```
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
```
This change does not break current api.
was:
as discussed in ML:
http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
we should return a closeable iterator for TableResult#collect method *to avoid
resource leak*. The suggested change is:
public interface TableResult {
CloseableRowIterator collect();
}
public interface CloseableRowIterator extends Iterator, AutoCloseable {
}
This change does not break current api.
> TableResult#collect should return closeable iterator to avoid resource leak
> ---
>
> Key: FLINK-18061
> URL: https://issues.apache.org/jira/browse/FLINK-18061
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API
>Reporter: godfrey he
>Priority: Blocker
> Fix For: 1.11.0
>
>
> as discussed in ML:
> http://mail-archives.apache.org/mod_mbox/flink-dev/202005.mbox/%3CCADQYLGuk%2BnnrPv-PR6Gi7D_rZqp_DhjfA%3DVtkRB-aGPxYxOQPw%40mail.gmail.com%3E,
> we should return a closeable iterator for TableResult#collect method *to
> avoid resource leak*. The suggested change is:
> ```
> public interface TableResult {
> CloseableRowIterator collect();
> }
> public interface CloseableRowIterator extends Iterator, AutoCloseable {
> }
> ```
> This change does not break current api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
