[jira] [Updated] (FLINK-24251) Make default constructor of BinaryStringData construct empty binary string again
[ https://issues.apache.org/jira/browse/FLINK-24251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng updated FLINK-24251: Summary: Make default constructor of BinaryStringData construct empty binary string again (was: Make default constructor of BinaryStringData private) > Make default constructor of BinaryStringData construct empty binary string > again > > > Key: FLINK-24251 > URL: https://issues.apache.org/jira/browse/FLINK-24251 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Runtime >Reporter: Caizhi Weng >Priority: Minor > > In FLINK-23289 we add a not null checking for {{BinarySection}}. After the > change the default constructor of {{BinaryStringData}} will now construct a > {{BinaryStringData}} with {{null}} Java object and {{null}} > {{BinarySection}}. This is different from the behavior before where the > default constructor constructs an empty binary string. > Although {{BinaryStringData}} is an internal class, it might confuse some > developers (actually I myself have been confused) if they build their > programs around this class. So we should make the default constructor > construct an empty binary string again without breaking the not null checking. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-24251) Make default constructor of BinaryStringData construct empty binary string again
[ https://issues.apache.org/jira/browse/FLINK-24251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24251: --- Labels: pull-request-available (was: ) > Make default constructor of BinaryStringData construct empty binary string > again > > > Key: FLINK-24251 > URL: https://issues.apache.org/jira/browse/FLINK-24251 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Runtime >Reporter: Caizhi Weng >Priority: Minor > Labels: pull-request-available > > In FLINK-23289 we add a not null checking for {{BinarySection}}. After the > change the default constructor of {{BinaryStringData}} will now construct a > {{BinaryStringData}} with {{null}} Java object and {{null}} > {{BinarySection}}. This is different from the behavior before where the > default constructor constructs an empty binary string. > Although {{BinaryStringData}} is an internal class, it might confuse some > developers (actually I myself have been confused) if they build their > programs around this class. So we should make the default constructor > construct an empty binary string again without breaking the not null checking. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-24251) Make default constructor of BinaryStringData construct empty binary string again
[ https://issues.apache.org/jira/browse/FLINK-24251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-24251: --- Labels: pull-request-available stale-minor (was: pull-request-available) I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help the community manage its development. I see this issues has been marked as Minor but is unassigned and neither itself nor its Sub-Tasks have been updated for 180 days. I have gone ahead and marked it "stale-minor". If this ticket is still Minor, please either assign yourself or give an update. Afterwards, please remove the label or in 7 days the issue will be deprioritized. > Make default constructor of BinaryStringData construct empty binary string > again > > > Key: FLINK-24251 > URL: https://issues.apache.org/jira/browse/FLINK-24251 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Runtime >Reporter: Caizhi Weng >Priority: Minor > Labels: pull-request-available, stale-minor > > In FLINK-23289 we add a not null checking for {{BinarySection}}. After the > change the default constructor of {{BinaryStringData}} will now construct a > {{BinaryStringData}} with {{null}} Java object and {{null}} > {{BinarySection}}. This is different from the behavior before where the > default constructor constructs an empty binary string. > Although {{BinaryStringData}} is an internal class, it might confuse some > developers (actually I myself have been confused) if they build their > programs around this class. So we should make the default constructor > construct an empty binary string again without breaking the not null checking. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-24251) Make default constructor of BinaryStringData construct empty binary string again
[ https://issues.apache.org/jira/browse/FLINK-24251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-24251: --- Labels: auto-deprioritized-minor pull-request-available (was: pull-request-available stale-minor) Priority: Not a Priority (was: Minor) This issue was labeled "stale-minor" 7 days ago and has not received any updates so it is being deprioritized. If this ticket is actually Minor, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > Make default constructor of BinaryStringData construct empty binary string > again > > > Key: FLINK-24251 > URL: https://issues.apache.org/jira/browse/FLINK-24251 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Runtime >Reporter: Caizhi Weng >Priority: Not a Priority > Labels: auto-deprioritized-minor, pull-request-available > > In FLINK-23289 we add a not null checking for {{BinarySection}}. After the > change the default constructor of {{BinaryStringData}} will now construct a > {{BinaryStringData}} with {{null}} Java object and {{null}} > {{BinarySection}}. This is different from the behavior before where the > default constructor constructs an empty binary string. > Although {{BinaryStringData}} is an internal class, it might confuse some > developers (actually I myself have been confused) if they build their > programs around this class. So we should make the default constructor > construct an empty binary string again without breaking the not null checking. -- This message was sent by Atlassian Jira (v8.20.1#820001)