Re: [PR] [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. [flink]
mbalassi closed pull request #20779: [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. URL: https://github.com/apache/flink/pull/20779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. [flink]
mbalassi commented on PR #20779: URL: https://github.com/apache/flink/pull/20779#issuecomment-1909689756 Closing this as the relevant work has been merged as part of #24065. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. [flink]
mbalassi closed pull request #20671: [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. URL: https://github.com/apache/flink/pull/20671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. [flink]
mbalassi commented on PR #20671: URL: https://github.com/apache/flink/pull/20671#issuecomment-1909689236 Closing this as the relevant work has been merged as part of #24065. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. [flink]
mbalassi commented on PR #20779: URL: https://github.com/apache/flink/pull/20779#issuecomment-1878422305 Hi @SwimSweet, given your lack of response @ferenc-csaky offered to build on your work and take it forward based on my comments above. Hope that is OK, he is planning to post an updated PR next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema. [flink]
mbalassi commented on code in PR #20779:
URL: https://github.com/apache/flink/pull/20779#discussion_r1413932510
##
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java:
##
@@ -485,6 +486,19 @@ public class KubernetesConfigOptions {
.withDescription(
"The user agent to be used for contacting with
Kubernetes APIServer.");
+public static final ConfigOption
KUBERNETES_USER_ARTIFACTS_EMPTYDIR_ENABLE =
+ConfigOptions.key("kubernetes.user.artifacts.emptyDir.enable")
+.booleanType()
+.defaultValue(true)
Review Comment:
What is a good use case for disabling this by the way? I would keep it
default in all cases that come to mind.
##
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/factory/KubernetesJobManagerFactoryTest.java:
##
@@ -468,4 +470,47 @@ void testSetJobManagerDeploymentReplicas() throws
Exception {
assertThat(kubernetesJobManagerSpecification.getDeployment().getSpec().getReplicas())
.isEqualTo(JOBMANAGER_REPLICAS);
}
+
+@Test
+public void testArtifactsEmptyDirVolume() throws IOException {
+flinkConfig.set(ArtifactFetchOptions.USER_ARTIFACTS_BASE_DIR,
"/opt/artifacts");
Review Comment:
`/opt/artifacts` is reused in the next test, please refactor it to a const.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
