Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]
XComp commented on code in PR #22931:
URL: https://github.com/apache/flink/pull/22931#discussion_r1457044758
##
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##
@@ -143,12 +144,14 @@ private OperatorCoordinatorHolder(
public void lazyInitialize(
GlobalFailureHandler globalFailureHandler,
-ComponentMainThreadExecutor mainThreadExecutor) {
+ComponentMainThreadExecutor mainThreadExecutor,
+@Nullable CheckpointCoordinator checkpointCoordinator) {
this.globalFailureHandler = globalFailureHandler;
this.mainThreadExecutor = mainThreadExecutor;
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
-context.lazyInitialize(globalFailureHandler, mainThreadExecutor);
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
Review Comment:
Thanks for clarification. Doing it as a hotfix commit in one other PR makes
sense because of the reasons you mentioned. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]
lindong28 commented on code in PR #22931:
URL: https://github.com/apache/flink/pull/22931#discussion_r1456726081
##
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##
@@ -143,12 +144,14 @@ private OperatorCoordinatorHolder(
public void lazyInitialize(
GlobalFailureHandler globalFailureHandler,
-ComponentMainThreadExecutor mainThreadExecutor) {
+ComponentMainThreadExecutor mainThreadExecutor,
+@Nullable CheckpointCoordinator checkpointCoordinator) {
this.globalFailureHandler = globalFailureHandler;
this.mainThreadExecutor = mainThreadExecutor;
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
-context.lazyInitialize(globalFailureHandler, mainThreadExecutor);
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
Review Comment:
@XComp Thanks for catching this. No, we didn't do it intentionally. I
believe it is introduced when Yunfeng rebased the PR. I didn't catch this issue
because I didn't go over the entire PR end-to-end very carefully when there is
only minor remaining comments in the last 2 rounds of review.
It seems that the extra invocation of `lazyInitialize()` would not introduce
any visible performance or correctness issue. Maybe one of us can fix it in our
next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]
lindong28 commented on code in PR #22931:
URL: https://github.com/apache/flink/pull/22931#discussion_r1456726081
##
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##
@@ -143,12 +144,14 @@ private OperatorCoordinatorHolder(
public void lazyInitialize(
GlobalFailureHandler globalFailureHandler,
-ComponentMainThreadExecutor mainThreadExecutor) {
+ComponentMainThreadExecutor mainThreadExecutor,
+@Nullable CheckpointCoordinator checkpointCoordinator) {
this.globalFailureHandler = globalFailureHandler;
this.mainThreadExecutor = mainThreadExecutor;
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
-context.lazyInitialize(globalFailureHandler, mainThreadExecutor);
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
Review Comment:
@XComp Thanks for catching this. No, we didn't do it intentionally. I
believe it is introduced when Yunfeng rebased the. I didn't catch this issue
because I didn't go over the entire PR end-to-end very carefully when there is
only minor remaining comments in the last 2 rounds of review.
It seems that the extra invocation of `lazyInitialize()` would not introduce
any visible performance or correctness issue. Maybe one of us can fix it in our
next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FLINK-32514] Support configuring checkpointing interval during process backlog [flink]
XComp commented on code in PR #22931:
URL: https://github.com/apache/flink/pull/22931#discussion_r1455086469
##
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##
@@ -143,12 +144,14 @@ private OperatorCoordinatorHolder(
public void lazyInitialize(
GlobalFailureHandler globalFailureHandler,
-ComponentMainThreadExecutor mainThreadExecutor) {
+ComponentMainThreadExecutor mainThreadExecutor,
+@Nullable CheckpointCoordinator checkpointCoordinator) {
this.globalFailureHandler = globalFailureHandler;
this.mainThreadExecutor = mainThreadExecutor;
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
-context.lazyInitialize(globalFailureHandler, mainThreadExecutor);
+context.lazyInitialize(globalFailureHandler, mainThreadExecutor,
checkpointCoordinator);
Review Comment:
@lindong28 @yunfengzhou-hub Is initializing the `OperatorCoordinatorHolder`
twice done deliberately here? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
