Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

[via GitHub]

HuangXingBo merged PR #23894:
URL: https://github.com/apache/flink/pull/23894


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

[via GitHub]

liuyongvs commented on PR #23894:
URL: https://github.com/apache/flink/pull/23894#issuecomment-1860241060

   > LTGM. BTW, should we also update this function in pyflink? cc @HuangXingBo 
Further more, please modify the description of this pr.
   
   the python code of  has no use, we do not need modify
   ```
   def set_idle_state_retention_time(self,
 min_time: datetime.timedelta,
 max_time: datetime.timedelta):
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

[via GitHub]

liuyongvs commented on PR #23894:
URL: https://github.com/apache/flink/pull/23894#issuecomment-1857586748

   @xuyangzhong thanks for your review and fix the description of pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

[via GitHub]

liuyongvs commented on PR #23894:
URL: https://github.com/apache/flink/pull/23894#issuecomment-1854976683

   hi @lsyldliu @xuyangzhong  will you also help review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

[via GitHub]

liuyongvs commented on PR #23894:
URL: https://github.com/apache/flink/pull/23894#issuecomment-1849338235

   hi @snuyanzin @dawidwys  could you help review this pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

[via GitHub]

flinkbot commented on PR #23894:
URL: https://github.com/apache/flink/pull/23894#issuecomment-1846727842

   
   ## CI report:
   
   * 4b38e0f7e69cc63a7977745e702a6e797e19a5ea UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org