Re: [PR] [FLINK-34244] Update Confluent Platform to 7.4.4 [flink-connector-kafka]
MartijnVisser merged PR #81: URL: https://github.com/apache/flink-connector-kafka/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34244] Update Confluent Platform to 7.4.4 [flink-connector-kafka]
MartijnVisser commented on code in PR #81: URL: https://github.com/apache/flink-connector-kafka/pull/81#discussion_r1483192402 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/DockerImageVersions.java: ## @@ -24,7 +24,9 @@ */ public class DockerImageVersions { -public static final String KAFKA = "confluentinc/cp-kafka:7.2.2"; +public static final String KAFKA = "confluentinc/cp-kafka:7.4.4"; -public static final String SCHEMA_REGISTRY = "confluentinc/cp-schema-registry:7.2.2"; +public static final String SCHEMA_REGISTRY = "confluentinc/cp-schema-registry:7.4.4"; + +public static final String ZOOKEEPER = "zookeeper:3.4.14"; Review Comment: Filed https://issues.apache.org/jira/browse/FLINK-34415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34244] Update Confluent Platform to 7.4.4 [flink-connector-kafka]
MartijnVisser commented on code in PR #81: URL: https://github.com/apache/flink-connector-kafka/pull/81#discussion_r1483185495 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/DockerImageVersions.java: ## @@ -24,7 +24,9 @@ */ public class DockerImageVersions { -public static final String KAFKA = "confluentinc/cp-kafka:7.2.2"; +public static final String KAFKA = "confluentinc/cp-kafka:7.4.4"; -public static final String SCHEMA_REGISTRY = "confluentinc/cp-schema-registry:7.2.2"; +public static final String SCHEMA_REGISTRY = "confluentinc/cp-schema-registry:7.4.4"; + +public static final String ZOOKEEPER = "zookeeper:3.4.14"; Review Comment: It's the one that was used before as well. As a follow-up, I'll open a refactoring ticket to move away from the Zookeeper based tests in favor of KRaft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-34244] Update Confluent Platform to 7.4.4 [flink-connector-kafka]
snuyanzin commented on code in PR #81: URL: https://github.com/apache/flink-connector-kafka/pull/81#discussion_r1483182849 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/DockerImageVersions.java: ## @@ -24,7 +24,9 @@ */ public class DockerImageVersions { -public static final String KAFKA = "confluentinc/cp-kafka:7.2.2"; +public static final String KAFKA = "confluentinc/cp-kafka:7.4.4"; -public static final String SCHEMA_REGISTRY = "confluentinc/cp-schema-registry:7.2.2"; +public static final String SCHEMA_REGISTRY = "confluentinc/cp-schema-registry:7.4.4"; + +public static final String ZOOKEEPER = "zookeeper:3.4.14"; Review Comment: is this ok to use so old zookeeper? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org