Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
PatrickRen merged PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
yuxiqian commented on PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212#issuecomment-2066306357 Seems removing connector jar dependencies break SQL Job E2e tests. Need to fix this first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
yuxiqian commented on PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212#issuecomment-2048899914 > It reminds me that there's an automatic license check in CI of Flink repo. Maybe we can also do it in Flink CDC: > > https://github.com/apache/flink/blob/dec5e9e659dd09346781c97c940a20a6cbc63678/tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java#L141-L181 Addressed in #3218. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
PatrickRen commented on PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212#issuecomment-2047289933 @yuxiqian I won't take it as a blocker. We can have a try to see if it is complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
yuxiqian commented on PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212#issuecomment-2047199663 @PatrickRen Sure! Shall I add the license checking script in this PR or open another one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
PatrickRen commented on PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212#issuecomment-2047166475 It reminds me that there's an automatic license check in CI of Flink repo. Maybe we can also do it in Flink CDC: https://github.com/apache/flink/blob/dec5e9e659dd09346781c97c940a20a6cbc63678/tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java#L141-L181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35055][cdc] Exclude connector dependencies with questionable licenses from fat jar packages [flink-cdc]
PatrickRen commented on code in PR #3212: URL: https://github.com/apache/flink-cdc/pull/3212#discussion_r1559208717 ## docs/content/docs/connectors/legacy-flink-cdc-sources/db2-cdc.md: ## @@ -55,6 +55,26 @@ put it under `/lib/`. [flink-sql-connector-db2-cdc](https://mvnrepository.com/artifact/com.ververica/flink-sql-connector-db2-cdc), more released versions will be available in the Maven central warehouse. +Since Db2 Connector's IPLA license is incompatible with Flink CDC project, we can't provide Db2 connector in prebuilt connector jar packages. +You may need to configure the following dependencies manually. Review Comment: What about providing a link for downloading the JAR we cannot provide? Same for all connectors with license issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
