Re: [PR] [FLINK-35124] Include Maven build configuration in the pristine source clone [flink-connector-shared-utils]

2024-04-18 Thread via GitHub


dannycranmer merged PR #40:
URL: https://github.com/apache/flink-connector-shared-utils/pull/40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [FLINK-35124] Include Maven build configuration in the pristine source clone [flink-connector-shared-utils]

2024-04-18 Thread via GitHub


dannycranmer commented on PR #40:
URL: 
https://github.com/apache/flink-connector-shared-utils/pull/40#issuecomment-2063479840

   >  But did you find the reason why the suppressions.xml path ends up being 
/tools/maven/suppressions.xml and not tools/maven/suppressions.xml ?
   
   No, but I think this is a red herring. It resolves the correct file even 
though there is a `/` at the start. The Flink config is the same 
https://github.com/apache/flink/blob/master/pom.xml#L2196. If it were looking 
there as an absolute path, it would not find it on my machine!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org