Re: [PR] [hotfix] Synchronize CI pipeline setup [flink-connector-kafka]

[via GitHub]

MartijnVisser merged PR #78:
URL: https://github.com/apache/flink-connector-kafka/pull/78


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix] Synchronize CI pipeline setup [flink-connector-kafka]

[via GitHub]

snuyanzin commented on PR #78:
URL: 
https://github.com/apache/flink-connector-kafka/pull/78#issuecomment-1896939681

   yeah... initially there were already 2 jdks (8, 11) in ci for PRs and that's 
why I've just added other jdks there...
   Now amount of ci jobs per is growing together with number of jdks + possibly 
twice because of python...
   
   it would make sense to follow something similar we have in Flink main repo 
where everything is built with jdk8 for PRs and all other jdks are 
participating only during nightlies 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix] Synchronize CI pipeline setup [flink-connector-kafka]

[via GitHub]

snuyanzin commented on code in PR #78:
URL: 
https://github.com/apache/flink-connector-kafka/pull/78#discussion_r1453213115


##
.github/workflows/push_pr.yml:
##
@@ -25,19 +25,12 @@ jobs:
   compile_and_test:
 strategy:
   matrix:
-flink: [ 1.17.1, 1.18.0 ]
-jdk: [ 8, 11, 17 ]
-exclude:
-  - jdk: 17
-flink: 1.17.1
+flink: [ 1.17.2 ]
+jdk: [ '8, 11' ]
+include:
+  - flink: 1.18.1
+jdk: '8, 11, 17'
 uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils
 with:
   flink_version: ${{ matrix.flink }}
-  jdk_version: ${{ matrix.jdk }}
-  python_test:
-strategy:
-  matrix:
-flink: [ 1.17.1, 1.18.0 ]
-uses: 
apache/flink-connector-shared-utils/.github/workflows/python_ci.yml@ci_utils
-with:
-  flink_version: ${{ matrix.flink }}

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix] Synchronize CI pipeline setup [flink-connector-kafka]

[via GitHub]

MartijnVisser commented on code in PR #78:
URL: 
https://github.com/apache/flink-connector-kafka/pull/78#discussion_r1453198204


##
.github/workflows/push_pr.yml:
##
@@ -25,19 +25,12 @@ jobs:
   compile_and_test:
 strategy:
   matrix:
-flink: [ 1.17.1, 1.18.0 ]
-jdk: [ 8, 11, 17 ]
-exclude:
-  - jdk: 17
-flink: 1.17.1
+flink: [ 1.17.2 ]
+jdk: [ '8, 11' ]
+include:
+  - flink: 1.18.1
+jdk: '8, 11, 17'
 uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils
 with:
   flink_version: ${{ matrix.flink }}
-  jdk_version: ${{ matrix.jdk }}
-  python_test:
-strategy:
-  matrix:
-flink: [ 1.17.1, 1.18.0 ]
-uses: 
apache/flink-connector-shared-utils/.github/workflows/python_ci.yml@ci_utils
-with:
-  flink_version: ${{ matrix.flink }}

Review Comment:
   I think we should keep them in for PRs, and actually we should also have 
them for weekly runs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [hotfix] Synchronize CI pipeline setup [flink-connector-kafka]

[via GitHub]

MartijnVisser commented on code in PR #78:
URL: 
https://github.com/apache/flink-connector-kafka/pull/78#discussion_r1453193893


##
.github/workflows/push_pr.yml:
##
@@ -25,19 +25,12 @@ jobs:
   compile_and_test:
 strategy:
   matrix:
-flink: [ 1.17.1, 1.18.0 ]
-jdk: [ 8, 11, 17 ]
-exclude:
-  - jdk: 17
-flink: 1.17.1
+flink: [ 1.17.2 ]
+jdk: [ '8, 11' ]
+include:
+  - flink: 1.18.1
+jdk: '8, 11, 17'
 uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils
 with:
   flink_version: ${{ matrix.flink }}
-  jdk_version: ${{ matrix.jdk }}
-  python_test:
-strategy:
-  matrix:
-flink: [ 1.17.1, 1.18.0 ]
-uses: 
apache/flink-connector-shared-utils/.github/workflows/python_ci.yml@ci_utils
-with:
-  flink_version: ${{ matrix.flink }}

Review Comment:
   Oh wow I completely missed the Python part. Let me check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org