Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub


ruanhang1993 commented on PR #20:
URL: 
https://github.com/apache/flink-connector-mongodb/pull/20#issuecomment-1857208606

   Hi, @Jiabao-Sun .
   I think using all SNAPSHOT versions could help us to check the changes in 
Flink. Let's keep the settings now. Close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub


ruanhang1993 closed pull request #20: [hotfix] Test connector against Flink 
1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version
URL: https://github.com/apache/flink-connector-mongodb/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub


ruanhang1993 commented on PR #20:
URL: 
https://github.com/apache/flink-connector-mongodb/pull/20#issuecomment-1857189111

   @Jiabao-Sun Thanks for the quick reply.
   I am not sure whether this PR is correct. It seems like every connector has 
different settings for the CI to use the SNAPSHOT version.
   
   - JDBC connector only uses the SNAPSHOT versions for main branch in 
push_pr.yml and weekly.yml.
   - ES connector uses uses the SNAPSHOT and release versions for main branch 
in push_pr.yml and only uses the SNAPSHOT versions for main branch in  
weekly.yml.
   - Kafka connector uses uses the SNAPSHOT and release versions for main 
branch in push_pr.yml and  weekly.yml.
   
   I will see more about this and maybe discuss it in the dev mail list.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [hotfix] Test connector against Flink 1.16.2, 1.17.1, 1.18.0 instead of Flink SNAPSHOT version [flink-connector-mongodb]

2023-12-14 Thread via GitHub


boring-cyborg[bot] commented on PR #20:
URL: 
https://github.com/apache/flink-connector-mongodb/pull/20#issuecomment-1855933326

   Thanks for opening this pull request! Please check out our contributing 
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org