[jira] [Commented] (GEODE-4054) Create module for Protobuf message-based Java driver

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295996#comment-16295996
 ] 

ASF subversion and git services commented on GEODE-4054:


Commit f0c038c1c4bae794a4c22ae49c131f3da5965a79 in geode's branch 
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f0c038c ]

GEODE-4054: Fixing integration test failure with experimental client

The gradle build is generating a gemfire.properties file with an
mcast-port, but this test needs to run with mcast disabled.


> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3781) Users would like PDX to JDBC connector

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3781.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Users would like PDX to JDBC connector
> --
>
> Key: GEODE-3781
> URL: https://issues.apache.org/jira/browse/GEODE-3781
> Project: Geode
>  Issue Type: Wish
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> Users would like easy inline caching
> This is the epic for the inline caching improvements -- write behind, write 
> through, read through.
> The goal is here to allow users easy mapping of region to table.  Either the 
> user can provide a simple field to column config file and it is injected at 
> runtime (more flexible) or we use a simple name to name mapping with no 
> configuration needed.  
> Feedback 1: "people don't like the idea of every team writing the same kind 
> of write behind logic again and again"
> Feedback 2: "I write a lot of boiler plate code over and over again for this 
> very thing"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3823) Implement CacheLoader for JDBC to PDX

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3823.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement CacheLoader for JDBC to PDX
> -
>
> Key: GEODE-3823
> URL: https://issues.apache.org/jira/browse/GEODE-3823
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> This is for a 'read through' to the DB scenario when the entry is not found 
> in a Region.  This implementation should take a result set and convert to PDX 
> for the cache.
> Make a SQL statement to query by the key provided.  dbName must match the 
> Region name.
> Check each ResultSet field for type and convert. Create a PDXInstance insert 
> values.  Region can (should?) have its type set so we'll know what the type 
> is.
>
> If the value is not in the cache it should take configured JDBC credentials 
> and connect to DB
> Should log any connection error and retry x amount of times
> On connect should execute query using the provided key as UID
> On successful query should create PDX object, map JDBC values to PDX object, 
> put PDX object in the cache, return value
> Should only return one value -- multiple values should be logged and error
> JDBC execution errors should be logged



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3783) Implement AsyncEventListener for PDX to JDBC

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3783.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement AsyncEventListener for PDX to JDBC
> 
>
> Key: GEODE-3783
> URL: https://issues.apache.org/jira/browse/GEODE-3783
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> This is to implement an AsyncEventListener for a write behind caching 
> scenario.  Something was put or updated in the Region and it should be 
> persisted into a DB asynchronously. 
> Should take the JDBC configuration from cache.xml and connect to the DB 
> Should log a DB connection failure and retry x number of times
> Should take the PDX object and convert it to a JDBC statement for DB 
> update/insert
> Should retry on a fail 
> Should log all failed DB attempts



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3782) Implement CacheWriter for PDX to JDBC

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3782.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement CacheWriter for PDX to JDBC
> -
>
> Key: GEODE-3782
> URL: https://issues.apache.org/jira/browse/GEODE-3782
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> This is for write through from the backend-db --- region.put that should be 
> synchronously written through to the DB
> Most actions are the same as on GEODE-3783 -- except this is a synchronous 
> operation so if the DB update fails in any way the region.put should also 
> fail and return na error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3991) Implement list jdbc-region-mapping command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3991.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement list jdbc-region-mapping command
> --
>
> Key: GEODE-3991
> URL: https://issues.apache.org/jira/browse/GEODE-3991
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Lynn Gallinat
> Fix For: 1.4.0
>
>
> NAME
> list jdbc-mapping
> SYNOPSIS
> List the all the JDBC stores for all regions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4075) Add 'experimental' to JDBC code

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4075.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Add 'experimental' to JDBC code
> ---
>
> Key: GEODE-4075
> URL: https://issues.apache.org/jira/browse/GEODE-4075
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Lynn Gallinat
> Fix For: 1.4.0
>
>
> This should be labeled as 'experimental' for the next release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3990) Implement alter jdbc-region-mapping command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3990.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement alter jdbc-region-mapping command
> ---
>
> Key: GEODE-3990
> URL: https://issues.apache.org/jira/browse/GEODE-3990
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> SYNTAX
> alter jdbc-mapping --region=value [--data-source=value] 
> [--pdx-name=value][--table=value] [--id=value[,value...]] 
> [--add-field=('name': value, ['column': value,] ['class': value,] ['type': 
> value])] [--remove-field=value]
> PARAMETERS
> data-source
> for JDBC connection.
>   Required: false
> pdx-name
> for GemFire PDX to parse the PDX fields.
> Required: false
> region
> Name/path of the region to be associated with DB table.
> Required: true
> Table 
> to be associated with GemFire region.
> Required: false
> id
> the key in the identification of a GemFire object.
> Required: false
> add-field
> JSON text specifying the mapping from a GemFire PdxInstance field to a DB 
> column.
> Required: false
> remove-field
> Name of existing PdxInstance field to remove
> required: false



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3989) Implement destroy jdbc-region-mapping command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3989.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement destroy jdbc-region-mapping command
> -
>
> Key: GEODE-3989
> URL: https://issues.apache.org/jira/browse/GEODE-3989
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Lynn Gallinat
> Fix For: 1.4.0
>
>
> destroy jdbc-mapping --region=value
> PARAMETERS
> region
> Name/path of the region that the GPDB store is associated with
> Required: true



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3992) Implement describe jdbc-region-mapping command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3992.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement describe jdbc-region-mapping command
> --
>
> Key: GEODE-3992
> URL: https://issues.apache.org/jira/browse/GEODE-3992
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> SYNTAX
> describe jdbc-mapping --region=value
> PARAMETERS
> region
> Name/path of the region that has the JDBC store.
> Required: true



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4065) Refactor Cli functions to reduce duplicate code

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4065.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Refactor Cli functions to reduce duplicate code
> ---
>
> Key: GEODE-4065
> URL: https://issues.apache.org/jira/browse/GEODE-4065
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> Most of the code in the different cli functions is the exact same or very 
> similar. Refactor out an abstract base class for that common code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3988) Implement create jdbc-region-mapping command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3988.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement create jdbc-region-mapping command
> 
>
> Key: GEODE-3988
> URL: https://issues.apache.org/jira/browse/GEODE-3988
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> {noformat}
> NAME
> create jdbc-region-mapping
> SYNOPSIS
> Specify the mapping between DB table columns and the GemFire region 
> fields.
> SYNTAX
> create jdbc-region-mapping --connection-name=value --region=value 
> --table=value --pdx-name=[value] [--primary-key-in-value] 
> [--fields=field:db-column[,field:db-column...]]
> PARAMETERS
> connection-name
> Name of the previously created JDBC connection configuration to be 
> used
> Required: true
> pdx-name
> Name for GemFire PDX to parse the PDX fields.
> Required: false
> region
> Name/path of the region to be associated with DB table.
>   Required: true
> table
> Name of DB table to be associated with GemFire region. 
> Required: true
> primary-key-in-value
> Is the value for the primary key located in the region entry value 
> (as opposed to being the entry key).
> Required: false
> Default: false (currently)
> fields
> Key, value pairs for mapping fields of Pdx instance to database 
> columns.
> Required: false
> Default: Pdx field names are used as database column names
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4021) Implement describe jdbc-connection command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4021.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement describe jdbc-connection command
> --
>
> Key: GEODE-4021
> URL: https://issues.apache.org/jira/browse/GEODE-4021
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Kirk Lund
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> Need to be able to describe details of a single JDBC connection via GFSH.
> {noformat}
> NAME
> describe jdbc-connection
> SYNOPSIS
> Display information about a jdbc connection.
> SYNTAX
> describe jdbc-connection --name=value
> PARAMETERS
> name
> Name of the jdbc connection to be described.
> Required: true
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4020) Implement list jdbc-connection command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4020.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement list jdbc-connection command
> --
>
> Key: GEODE-4020
> URL: https://issues.apache.org/jira/browse/GEODE-4020
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> Need to be able to list all existing JDBC connections via GFSH.
> {noformat}
> NAME
> list jdbc-connection
> SYNOPSIS
> Display jdbc connections for all members.
> SYNTAX
> list jdbc-connection
> PARAMETERS
> none
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4022) Implement destroy jdbc-connection command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4022.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement destroy jdbc-connection command
> -
>
> Key: GEODE-4022
> URL: https://issues.apache.org/jira/browse/GEODE-4022
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.4.0
>
>
> Need to be able to destroy an existing JDBC connection via GFSH.
> {noformat}
> NAME
> destroy jdbc-connection
> SYNOPSIS
> Destroy/Remove the specified jdbc connection.
> SYNTAX
> destroy jdbc-connection --name=value
> PARAMETERS
> name
> Name of the jdbc connection to be destroyed.
> Required: true
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4017) Implement alter jdbc-connection command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4017.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement alter jdbc-connection command
> ---
>
> Key: GEODE-4017
> URL: https://issues.apache.org/jira/browse/GEODE-4017
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Kirk Lund
>Assignee: Lynn Gallinat
> Fix For: 1.4.0
>
>
> Need to be able to alter an existing JDBC connection via GFSH.
> {noformat}
> NAME
> alter jdbc-connection
> SYNOPSIS
> This provides the ability to alter the parameters necessary to 
> communicate with a database through JDBC.
> SYNTAX
> alter jdbc-connection [--url=value] [--user=value] [--password=value] 
> [--params=key:value[,key:value...]]
> PARAMETERS
> url
> Change the url location for the database
> Required: false
> user
> Change name of user to connect to database as
> Required: false
> password
> Change the password to use when connecting to database
> Required: false
> Params
> Change the additional parameters to use when connecting to database. 
> No parameters are yet supported
> Required: false
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3824) Implement create jdbc-connection command

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-3824.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> Implement create jdbc-connection command
> 
>
> Key: GEODE-3824
> URL: https://issues.apache.org/jira/browse/GEODE-3824
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> Need to be able to configure establish a JDBC connection via GFSH and 
> reference it when tying a region to a DB via PDX-JDBC.
> {noformat}
> NAME
> create jdbc-connection
> SYNOPSIS
> Create a connection for communicating with a database through JDBC.
> SYNTAX
> create jdbc-connection --name=value --url=value [--user=value] 
> [--password=value] [--params=key:value[,key:value...]]
> PARAMETERS
> name
> Name of the connection to be created.
> Required: true
> url
> URL location for the database.
> Required: true
> user
> User name to use when connecting to database.
> Required: false
> password
> Password to use when connecting to database.
> Required: false
> params
> Additional parameters to use when connecting to database.
> Required: false
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-4079.


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3781) Users would like PDX to JDBC connector

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295978#comment-16295978
 ] 

ASF subversion and git services commented on GEODE-3781:


Commit 56bd06dea4a1b41575633fe20eac8165efa573c5 in geode's branch 
refs/heads/develop from lgallinat
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=56bd06d ]

Feature/geode 3781: JDBC Connector (#1176)

GEODE-3781: add geode-connectors module

Introduce new PDX JDBC Connector Service:
* GEODE-3782: implement JdbcWriter
* GEODE-3783: implement JdbcAsyncWriter
* GEODE-3823: implement JdbcLoader

> Users would like PDX to JDBC connector
> --
>
> Key: GEODE-3781
> URL: https://issues.apache.org/jira/browse/GEODE-3781
> Project: Geode
>  Issue Type: Wish
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
>
> Users would like easy inline caching
> This is the epic for the inline caching improvements -- write behind, write 
> through, read through.
> The goal is here to allow users easy mapping of region to table.  Either the 
> user can provide a simple field to column config file and it is injected at 
> runtime (more flexible) or we use a simple name to name mapping with no 
> configuration needed.  
> Feedback 1: "people don't like the idea of every team writing the same kind 
> of write behind logic again and again"
> Feedback 2: "I write a lot of boiler plate code over and over again for this 
> very thing"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3782) Implement CacheWriter for PDX to JDBC

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295979#comment-16295979
 ] 

ASF subversion and git services commented on GEODE-3782:


Commit 56bd06dea4a1b41575633fe20eac8165efa573c5 in geode's branch 
refs/heads/develop from lgallinat
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=56bd06d ]

Feature/geode 3781: JDBC Connector (#1176)

GEODE-3781: add geode-connectors module

Introduce new PDX JDBC Connector Service:
* GEODE-3782: implement JdbcWriter
* GEODE-3783: implement JdbcAsyncWriter
* GEODE-3823: implement JdbcLoader

> Implement CacheWriter for PDX to JDBC
> -
>
> Key: GEODE-3782
> URL: https://issues.apache.org/jira/browse/GEODE-3782
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
>
> This is for write through from the backend-db --- region.put that should be 
> synchronously written through to the DB
> Most actions are the same as on GEODE-3783 -- except this is a synchronous 
> operation so if the DB update fails in any way the region.put should also 
> fail and return na error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3823) Implement CacheLoader for JDBC to PDX

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295981#comment-16295981
 ] 

ASF subversion and git services commented on GEODE-3823:


Commit 56bd06dea4a1b41575633fe20eac8165efa573c5 in geode's branch 
refs/heads/develop from lgallinat
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=56bd06d ]

Feature/geode 3781: JDBC Connector (#1176)

GEODE-3781: add geode-connectors module

Introduce new PDX JDBC Connector Service:
* GEODE-3782: implement JdbcWriter
* GEODE-3783: implement JdbcAsyncWriter
* GEODE-3823: implement JdbcLoader

> Implement CacheLoader for JDBC to PDX
> -
>
> Key: GEODE-3823
> URL: https://issues.apache.org/jira/browse/GEODE-3823
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
>
> This is for a 'read through' to the DB scenario when the entry is not found 
> in a Region.  This implementation should take a result set and convert to PDX 
> for the cache.
> Make a SQL statement to query by the key provided.  dbName must match the 
> Region name.
> Check each ResultSet field for type and convert. Create a PDXInstance insert 
> values.  Region can (should?) have its type set so we'll know what the type 
> is.
>
> If the value is not in the cache it should take configured JDBC credentials 
> and connect to DB
> Should log any connection error and retry x amount of times
> On connect should execute query using the provided key as UID
> On successful query should create PDX object, map JDBC values to PDX object, 
> put PDX object in the cache, return value
> Should only return one value -- multiple values should be logged and error
> JDBC execution errors should be logged



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3783) Implement AsyncEventListener for PDX to JDBC

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295980#comment-16295980
 ] 

ASF subversion and git services commented on GEODE-3783:


Commit 56bd06dea4a1b41575633fe20eac8165efa573c5 in geode's branch 
refs/heads/develop from lgallinat
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=56bd06d ]

Feature/geode 3781: JDBC Connector (#1176)

GEODE-3781: add geode-connectors module

Introduce new PDX JDBC Connector Service:
* GEODE-3782: implement JdbcWriter
* GEODE-3783: implement JdbcAsyncWriter
* GEODE-3823: implement JdbcLoader

> Implement AsyncEventListener for PDX to JDBC
> 
>
> Key: GEODE-3783
> URL: https://issues.apache.org/jira/browse/GEODE-3783
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
>
> This is to implement an AsyncEventListener for a write behind caching 
> scenario.  Something was put or updated in the Region and it should be 
> persisted into a DB asynchronously. 
> Should take the JDBC configuration from cache.xml and connect to the DB 
> Should log a DB connection failure and retry x number of times
> Should take the PDX object and convert it to a JDBC statement for DB 
> update/insert
> Should retry on a fail 
> Should log all failed DB attempts



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295965#comment-16295965
 ] 

ASF GitHub Bot commented on GEODE-4079:
---

karensmolermiller closed pull request #1180: GEODE-4079 Identify hash indexes 
as deprecated in docs
URL: https://github.com/apache/geode/pull/1180
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb 
b/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb
index 0f8f8af367..e8302ad8d8 100644
--- a/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb
+++ b/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb
@@ -34,8 +34,6 @@ gfsh> define index --name=myIndex1 --expression=exp1 
--region=/exampleRegion
 
 gfsh> define index --name=myIndex2 --expression="c.exp2" 
--region="/exampleRegion e, e.collection1 c" 
 
-gfsh> define index --name=myIndex3 --expression=exp3 --region=/exampleRegion 
--type=hash 
-
 gfsh> create defined indexes
  
 ```
@@ -56,7 +54,6 @@ Message : Region ' /r3' not found: from  /r3Occurred on 
following members
 QueryService queryService = cache.getQueryService();
 queryService.defineIndex("name1", "indexExpr1", "regionPath1");
 queryService.defineIndex("name2", "indexExpr2", "regionPath2");
-queryService.defineHashIndex("name3", "indexExpr3", "regionPath2");
 queryService.defineKeyIndex("name4", "indexExpr4", "regionPath2");
 List indexes = queryService.createDefinedIndexes();
 ```
diff --git a/geode-docs/developing/query_index/creating_an_index.html.md.erb 
b/geode-docs/developing/query_index/creating_an_index.html.md.erb
index abac6f340d..69846b32d7 100644
--- a/geode-docs/developing/query_index/creating_an_index.html.md.erb
+++ b/geode-docs/developing/query_index/creating_an_index.html.md.erb
@@ -29,7 +29,7 @@ To create an index, use one of the following `QueryService` 
methods:
 
 -   `createIndex`. Creates the default type of index, a range index. Use this 
type of index if you will be writing queries that will be doing any kind of 
comparison operation besides an equality comparison.
 -   `createKeyIndex`. Creates a key index. See [Creating Key 
Indexes](creating_key_indexes.html#concept_09E29507AF0D42CF81D261B030D0B7C8) 
for more information.
--   `createHashIndex`. Creates a hash index. See [Creating Hash 
Indexes](creating_hash_indexes.html#concept_5C7614F71F394C62ACA1BDC5684A7AC4) 
for more information.
+-   **Deprecated.** `createHashIndex`. Creates a hash index. See [Creating 
Hash 
Indexes](creating_hash_indexes.html#concept_5C7614F71F394C62ACA1BDC5684A7AC4) 
for more information.
 -   `createDefinedIndexes`. Creates multiple indexes that were previously 
defined using `defineIndex`. See [Creating Multiple Indexes at 
Once](create_multiple_indexes.html) for more information.
 
 The following sections provide examples of index creation:
@@ -39,7 +39,6 @@ The following sections provide examples of index creation:
 ``` pre
 gfsh> create index --name=myIndex --expression=status --region=/exampleRegion
 gfsh> create index --name=myKeyIndex --type=key --expression=id 
--region=/exampleRegion
-gfsh> create index --name=myHashIndex --type=hash --expression=mktValue 
--region=/exampleRegion
 ```
 
 See [Index 
Commands](../../tools_modules/gfsh/quick_ref_commands_by_area.html#topic_688C66526B4649AFA51C0F72F34FA45E)
 for more examples.
@@ -50,7 +49,6 @@ See [Index 
Commands](../../tools_modules/gfsh/quick_ref_commands_by_area.html#to
 QueryService qs = cache.getQueryService();
  qs.createIndex("myIndex", "status", "/exampleRegion");
  qs.createKeyIndex("myKeyIndex", "id", "/exampleRegion");
- qs.createHashIndex("myHashIndex", "mktValue", "/exampleRegion");
 ```
 
 **Using cache.xml:**
@@ -61,7 +59,6 @@ QueryService qs = cache.getQueryService();
  
  
  
- 
  ...
 
 ```
diff --git 
a/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb 
b/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb
index e785749d50..be8a119975 100644
--- a/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb
+++ b/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb
@@ -19,8 +19,10 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
+**Hash indexes are deprecated.**
 <%=vars.product_name%> supports the creation of hash indexes for the purpose 
of performing equality-based queries.
 
+
 ## Hash Index Performance
 
 The performance of put operations and recovery time when using a hash index 
@@ -58,6 +60,8 @@ If memory is not a concern, use a range index instead of a 
hash index.
 
 

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295966#comment-16295966
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit afd72b06050bf84e456e982880e0ce639aec0001 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=afd72b0 ]

GEODE-4079 Identify hash indexes as deprecated in docs (#1180)



> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4118) CI failure: org.apache.geode.management.ClientHealthStatsDUnitTest > testClientHealthStats_DurableClient FAILED

[Shelley Lynn Hughes-Godfrey (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295961#comment-16295961
 ] 

Shelley Lynn Hughes-Godfrey commented on GEODE-4118:


Additional information from Barry:
{noformat}
That test creates 2 durable clients, closes them both with keepAlive=true, then 
verifies there are still 2 using MBeans. It only finds 1. 
Its hard to tell where that issue is. It could be MBean or durable client 
actually being closed when it shouldn't have been.

Whats interesting is all the validation up to that point passed - 2 
ClientHealthStatuses, numCients is 2.

But then numSubscriptions is 1
{noformat}

> CI failure: org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_DurableClient FAILED
> ---
>
> Key: GEODE-4118
> URL: https://issues.apache.org/jira/browse/GEODE-4118
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>
> The following failure occurred in CI on geode 1.3
> From geode 1.3:
> {noformat}
> org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_DurableClient FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$45/1125579520.run
>  in VM 0 running on Host c321364c7e23 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_DurableClient(ClientHealthStatsDUnitTest.java:160)
> Caused by:
> org.junit.ComparisonFailure: expected:<[2]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.verifyClientStats(ClientHealthStatsDUnitTest.java:333)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.lambda$testClientHealthStats_DurableClient$1db6af62$1(ClientHealthStatsDUnitTest.java:160)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4118) CI failure: org.apache.geode.management.ClientHealthStatsDUnitTest > testClientHealthStats_DurableClient FAILED

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-4118:
---
Affects Version/s: 1.3.0

> CI failure: org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_DurableClient FAILED
> ---
>
> Key: GEODE-4118
> URL: https://issues.apache.org/jira/browse/GEODE-4118
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
>
> The following failure occurred in CI on geode 1.3
> From geode 1.3:
> {noformat}
> org.apache.geode.management.ClientHealthStatsDUnitTest > 
> testClientHealthStats_DurableClient FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$45/1125579520.run
>  in VM 0 running on Host c321364c7e23 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_DurableClient(ClientHealthStatsDUnitTest.java:160)
> Caused by:
> org.junit.ComparisonFailure: expected:<[2]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.verifyClientStats(ClientHealthStatsDUnitTest.java:333)
> at 
> org.apache.geode.management.ClientHealthStatsDUnitTest.lambda$testClientHealthStats_DurableClient$1db6af62$1(ClientHealthStatsDUnitTest.java:160)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4118) CI failure: org.apache.geode.management.ClientHealthStatsDUnitTest > testClientHealthStats_DurableClient FAILED

[Shelley Lynn Hughes-Godfrey (JIRA)]

Shelley Lynn Hughes-Godfrey created GEODE-4118:
--

 Summary: CI failure: 
org.apache.geode.management.ClientHealthStatsDUnitTest > 
testClientHealthStats_DurableClient FAILED
 Key: GEODE-4118
 URL: https://issues.apache.org/jira/browse/GEODE-4118
 Project: Geode
  Issue Type: Bug
  Components: client queues
Reporter: Shelley Lynn Hughes-Godfrey


The following failure occurred in CI on geode 1.3

>From geode 1.3:
{noformat}
org.apache.geode.management.ClientHealthStatsDUnitTest > 
testClientHealthStats_DurableClient FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.management.ClientHealthStatsDUnitTest$$Lambda$45/1125579520.run
 in VM 0 running on Host c321364c7e23 with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at 
org.apache.geode.management.ClientHealthStatsDUnitTest.testClientHealthStats_DurableClient(ClientHealthStatsDUnitTest.java:160)

Caused by:
org.junit.ComparisonFailure: expected:<[2]> but was:<[1]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.management.ClientHealthStatsDUnitTest.verifyClientStats(ClientHealthStatsDUnitTest.java:333)
at 
org.apache.geode.management.ClientHealthStatsDUnitTest.lambda$testClientHealthStats_DurableClient$1db6af62$1(ClientHealthStatsDUnitTest.java:160)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-551) CI Failure: MemoryThresholdsOffHeapDUnitTest.testPRLoadRejection failed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295921#comment-16295921
 ] 

ASF GitHub Bot commented on GEODE-551:
--

pivotal-eshu opened a new pull request #1183: GEODE-551: make sure accessor 
gets critical by putting into its local region
URL: https://github.com/apache/geode/pull/1183
 
 
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI Failure: MemoryThresholdsOffHeapDUnitTest.testPRLoadRejection failed
> ---
>
> Key: GEODE-551
> URL: https://issues.apache.org/jira/browse/GEODE-551
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Hitesh Khamesra
>Assignee: Eric Shu
>  Labels: CI, Flaky
>
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest$35.call
>  in VM 1 running on Host zambia.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:369)
> at dunit.VM.invoke(VM.java:312)
> at dunit.VM.invoke(VM.java:280)
> at 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest.testPRLoadRejection(MemoryThresholdsOffHeapDUnitTest.java:1068)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> 

[jira] [Commented] (GEODE-4114) Remove all instances of GemFireCacheImpl.getInstance from geode-lucene

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295912#comment-16295912
 ] 

ASF GitHub Bot commented on GEODE-4114:
---

nabarunnag opened a new pull request #1182: GEODE-4114: Removed usage of 
GemFireCacheImpl.getInstance in geode-lu…
URL: https://github.com/apache/geode/pull/1182
 
 
   …cene
   
* Removed the used of GemFireCacheImpl.getInstance and replaced it with 
the local instance being used.
* There was no need to call close on GemFireCacheImpl when 
CacheCreation was used in the test case.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove all instances of GemFireCacheImpl.getInstance from geode-lucene
> --
>
> Key: GEODE-4114
> URL: https://issues.apache.org/jira/browse/GEODE-4114
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Remove all instances of GemFireCacheImpl.getInstance from geode-lucene and 
> replace with the local instance of cache present in the test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-551) CI Failure: MemoryThresholdsOffHeapDUnitTest.testPRLoadRejection failed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295911#comment-16295911
 ] 

ASF subversion and git services commented on GEODE-551:
---

Commit b45a7542e469caf2798bacbf387fb34186180e9c in geode's branch 
refs/heads/feature/GEODE-551 from [~eshu]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b45a754 ]

GEODE-551: Make sure accessor gets critical by putting into local region 
instead of putting into parititioned region.


> CI Failure: MemoryThresholdsOffHeapDUnitTest.testPRLoadRejection failed
> ---
>
> Key: GEODE-551
> URL: https://issues.apache.org/jira/browse/GEODE-551
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Hitesh Khamesra
>Assignee: Eric Shu
>  Labels: CI, Flaky
>
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest$35.call
>  in VM 1 running on Host zambia.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:369)
> at dunit.VM.invoke(VM.java:312)
> at dunit.VM.invoke(VM.java:280)
> at 
> com.gemstone.gemfire.cache.management.MemoryThresholdsOffHeapDUnitTest.testPRLoadRejection(MemoryThresholdsOffHeapDUnitTest.java:1068)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
> at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: junit.framework.AssertionFailedError
> at junit.framework.Assert.fail(Assert.java:55)
> at junit.framework.Assert.assertTrue(Assert.java:22)
> at junit.framework.Assert.assertTrue(Assert.java:31)
> at junit.framework.TestCase.assertTrue(TestCase.java:201)
> at 
> 

[jira] [Resolved] (GEODE-4054) Create module for Protobuf message-based Java driver

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge resolved GEODE-4054.
--
Resolution: Fixed

> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4084) rename handshake.proto

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan resolved GEODE-4084.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> rename handshake.proto
> --
>
> Key: GEODE-4084
> URL: https://issues.apache.org/jira/browse/GEODE-4084
> Project: Geode
>  Issue Type: Task
>  Components: client/server
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
> Fix For: 1.4.0
>
>
> We envision having another handshake between client & server in the future.  
> Since the current Handshake is going to remain fixed in content for the 
> foreseeable future we should rename it to something more like 
> "NewConnectionVersion" or something.  Then we can introduce a Handshake with 
> more information exchange in the future.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4117) CacheXmlParserJUnitTest time-to-run can be reduced

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295896#comment-16295896
 ] 

ASF GitHub Bot commented on GEODE-4117:
---

kirklund opened a new pull request #1181: GEODE-4117: use loopback instead of 
non-existent server host
URL: https://github.com/apache/geode/pull/1181
 
 
   This change speeds up the test to run in just over 2 seconds instead of 
taking over 2 minutes to complete.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CacheXmlParserJUnitTest time-to-run can be reduced
> --
>
> Key: GEODE-4117
> URL: https://issues.apache.org/jira/browse/GEODE-4117
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from about 2 
> minutes to about 2 seconds with the following change:
> {noformat}
> diff --git 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
>  
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> index 0a76a77c8..8c648c359 100644
> --- 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> +++ 
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> @@ -22,7 +22,7 @@
>  version="1.0">
>   
>
> -
> +   
> 
>  
>  {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-4117) CacheXmlParserJUnitTest time-to-run can be reduced

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-4117:


Assignee: Kirk Lund

> CacheXmlParserJUnitTest time-to-run can be reduced
> --
>
> Key: GEODE-4117
> URL: https://issues.apache.org/jira/browse/GEODE-4117
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from about 2 
> minutes to about 2 seconds with the following change:
> {noformat}
> diff --git 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
>  
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> index 0a76a77c8..8c648c359 100644
> --- 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> +++ 
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> @@ -22,7 +22,7 @@
>  version="1.0">
>   
>
> -
> +   
> 
>  
>  {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4117) CacheXmlParserJUnitTest time-to-run can be reduced

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4117:
-
Description: 
CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from about 2 
minutes to about 2 seconds with the following change:
{noformat}
diff --git 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
index 0a76a77c8..8c648c359 100644
--- 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
+++ 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
@@ -22,7 +22,7 @@
 version="1.0">
  
   
-
+   

 
 {noformat}

  was:
CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from > 2 minutes 
to about 2 seconds with the following change:
{noformat}
diff --git 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
index 0a76a77c8..8c648c359 100644
--- 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
+++ 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
@@ -22,7 +22,7 @@
 version="1.0">
  
   
-
+   

 
 {noformat}


> CacheXmlParserJUnitTest time-to-run can be reduced
> --
>
> Key: GEODE-4117
> URL: https://issues.apache.org/jira/browse/GEODE-4117
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>
> CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from about 2 
> minutes to about 2 seconds with the following change:
> {noformat}
> diff --git 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
>  
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> index 0a76a77c8..8c648c359 100644
> --- 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> +++ 
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> @@ -22,7 +22,7 @@
>  version="1.0">
>   
>
> -
> +   
> 
>  
>  {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4117) CacheXmlParserJUnitTest time-to-run can be reduced

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4117:
-
Description: 
CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from > 2 minutes 
to about 2 seconds with the following change:
{noformat}
diff --git 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
index 0a76a77c8..8c648c359 100644
--- 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
+++ 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
@@ -22,7 +22,7 @@
 version="1.0">
  
   
-
+   

 
 {noformat}

  was:
CacheXmlParserJUnitTest time-to-run can be reduced by 92844.42379182157% from > 
2 minutes to about 2 seconds with the following change:
{noformat}
diff --git 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
index 0a76a77c8..8c648c359 100644
--- 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
+++ 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
@@ -22,7 +22,7 @@
 version="1.0">
  
   
-
+   

 
 {noformat}


> CacheXmlParserJUnitTest time-to-run can be reduced
> --
>
> Key: GEODE-4117
> URL: https://issues.apache.org/jira/browse/GEODE-4117
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>
> CacheXmlParserJUnitTest time-to-run can be reduced by 92,844% from > 2 
> minutes to about 2 seconds with the following change:
> {noformat}
> diff --git 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
>  
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> index 0a76a77c8..8c648c359 100644
> --- 
> a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> +++ 
> b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
> @@ -22,7 +22,7 @@
>  version="1.0">
>   
>
> -
> +   
> 
>  
>  {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4117) CacheXmlParserJUnitTest time-to-run can be reduced

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-4117:


 Summary: CacheXmlParserJUnitTest time-to-run can be reduced
 Key: GEODE-4117
 URL: https://issues.apache.org/jira/browse/GEODE-4117
 Project: Geode
  Issue Type: Improvement
  Components: tests
Reporter: Kirk Lund


CacheXmlParserJUnitTest time-to-run can be reduced by 92844.42379182157% from > 
2 minutes to about 2 seconds with the following change:
{noformat}
diff --git 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
index 0a76a77c8..8c648c359 100644
--- 
a/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
+++ 
b/geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testSimpleClientCacheXml.cache.xml
@@ -22,7 +22,7 @@
 version="1.0">
  
   
-
+   

 
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4112) Replace FunctionAdapter with Function in geode-lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295851#comment-16295851
 ] 

ASF GitHub Bot commented on GEODE-4112:
---

nabarunnag closed pull request #1178: GEODE-4112: Replaced FunctionAdapter with 
Function in geode-lucene
URL: https://github.com/apache/geode/pull/1178
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):



 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace FunctionAdapter with Function in geode-lucene module
> 
>
> Key: GEODE-4112
> URL: https://issues.apache.org/jira/browse/GEODE-4112
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Replace FunctionAdapter with Function in geode-lucene module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4090) Use an enum for Error.errorCode, rather than an int32

[Brian Baynes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes resolved GEODE-4090.
-
   Resolution: Fixed
 Assignee: Brian Rowe
Fix Version/s: 1.4.0

> Use an enum for Error.errorCode, rather than an int32
> -
>
> Key: GEODE-4090
> URL: https://issues.apache.org/jira/browse/GEODE-4090
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Brian Rowe
> Fix For: 1.4.0
>
>
> Currently, the error codes in the new protocol are returned as integers and 
> are documented on the wiki in
> https://cwiki.apache.org/confluence/display/GEODE/Error+Codes and in the code 
> in ProtocolErrorCodes.
> Protobuf has support for enums, we should use an enum instead of an int32 for 
> the error code so that the list of possible errors is part of the protobuf 
> specification. This will make it clearer to the user what each error code 
> means and will prevent them from having to put the constants in their own 
> code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4116) Can't get PDX objects using the new protocol

[Dan Smith (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith updated GEODE-4116:
-
Attachment: pdx_get_failure.diff

Test that demonstrates this issue.

> Can't get PDX objects using the new protocol
> 
>
> Key: GEODE-4116
> URL: https://issues.apache.org/jira/browse/GEODE-4116
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
> Attachments: pdx_get_failure.diff
>
>
> The new client protocol doesn't correctly support PDX objects. The 
> GetRequestOperationHandler directly calls region.get, which will 
> *deserialize* the value stored in the region. The operation handler is 
> expecting to get a PdxInstance back, but that will only happen if the cache 
> has read-serialized set to true.
> I've attached a unit test that demonstrates this issue. If a region contains 
> PDX objects and read-serialized is set to false (the default), the new 
> protocol will throw exceptions if you try to get a value.
> {noformat}
> [error 2017/12/18 15:00:23.302 PST  
> tid=51] Received Get request with unsupported encoding: {}
> org.apache.geode.internal.protocol.serialization.exception.UnsupportedEncodingTypeException:
>  We cannot translate: class 
> org.apache.geode.internal.protocol.protobuf.v1.acceptance.CacheOperationsJUnitTest$TestPdxObject
>  into a specific Protobuf Encoding
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.EncodingTypeTranslator.getEncodingTypeForObject(EncodingTypeTranslator.java:63)
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.utilities.ProtobufUtilities.createEncodedValue(ProtobufUtilities.java:64)
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.operations.GetRequestOperationHandler.process(GetRequestOperationHandler.java:66)
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.operations.GetRequestOperationHandler.process(GetRequestOperationHandler.java:40)
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.ProtobufOpsProcessor.processOperation(ProtobufOpsProcessor.java:83)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4116) Can't get PDX objects using the new protocol

[Dan Smith (JIRA)]

Dan Smith created GEODE-4116:


 Summary: Can't get PDX objects using the new protocol
 Key: GEODE-4116
 URL: https://issues.apache.org/jira/browse/GEODE-4116
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Dan Smith


The new client protocol doesn't correctly support PDX objects. The 
GetRequestOperationHandler directly calls region.get, which will *deserialize* 
the value stored in the region. The operation handler is expecting to get a 
PdxInstance back, but that will only happen if the cache has read-serialized 
set to true.

I've attached a unit test that demonstrates this issue. If a region contains 
PDX objects and read-serialized is set to false (the default), the new protocol 
will throw exceptions if you try to get a value.

{noformat}
[error 2017/12/18 15:00:23.302 PST  
tid=51] Received Get request with unsupported encoding: {}
org.apache.geode.internal.protocol.serialization.exception.UnsupportedEncodingTypeException:
 We cannot translate: class 
org.apache.geode.internal.protocol.protobuf.v1.acceptance.CacheOperationsJUnitTest$TestPdxObject
 into a specific Protobuf Encoding
at 
org.apache.geode.internal.protocol.protobuf.v1.EncodingTypeTranslator.getEncodingTypeForObject(EncodingTypeTranslator.java:63)
at 
org.apache.geode.internal.protocol.protobuf.v1.utilities.ProtobufUtilities.createEncodedValue(ProtobufUtilities.java:64)
at 
org.apache.geode.internal.protocol.protobuf.v1.operations.GetRequestOperationHandler.process(GetRequestOperationHandler.java:66)
at 
org.apache.geode.internal.protocol.protobuf.v1.operations.GetRequestOperationHandler.process(GetRequestOperationHandler.java:40)
at 
org.apache.geode.internal.protocol.protobuf.v1.ProtobufOpsProcessor.processOperation(ProtobufOpsProcessor.java:83)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4115) Remove nullability of InternalLocator.myDS

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-4115:

Issue Type: Improvement  (was: Bug)

> Remove nullability of InternalLocator.myDS
> --
>
> Key: GEODE-4115
> URL: https://issues.apache.org/jira/browse/GEODE-4115
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> {code}
>   /**
>* The distributed system owned by this locator, if any. Note that if a ds 
> already exists because
>* the locator is being colocated in a normal member this field will be 
> null.
>*/
>   private InternalDistributedSystem myDs;
> {code}
> I don't think that this should be nullable. It makes things more complicated 
> -- when we start a colocated locator, the protobuf protocol statistics 
> initialization has to check {{InternalDistributedSystem.getAnyInstance()}} to 
> get a DS. Can that call be null? I'm not sure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4115) Remove nullability of InternalLocator.myDS

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-4115:
---

 Summary: Remove nullability of InternalLocator.myDS
 Key: GEODE-4115
 URL: https://issues.apache.org/jira/browse/GEODE-4115
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Galen O'Sullivan


{code}
  /**
   * The distributed system owned by this locator, if any. Note that if a ds 
already exists because
   * the locator is being colocated in a normal member this field will be null.
   */
  private InternalDistributedSystem myDs;
{code}

I don't think that this should be nullable. It makes things more complicated -- 
when we start a colocated locator, the protobuf protocol statistics 
initialization has to check {{InternalDistributedSystem.getAnyInstance()}} to 
get a DS. Can that call be null? I'm not sure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4114) Remove all instances of GemFireCacheImpl.getInstance from geode-lucene

[nabarun (JIRA)]

nabarun created GEODE-4114:
--

 Summary: Remove all instances of GemFireCacheImpl.getInstance from 
geode-lucene
 Key: GEODE-4114
 URL: https://issues.apache.org/jira/browse/GEODE-4114
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


Remove all instances of GemFireCacheImpl.getInstance from geode-lucene and 
replace with the local instance of cache present in the test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-1988) CI failure: ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer fails with NoSubscriptionServersAvailableException: Primary discovery fail

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-1988:
---
Affects Version/s: 1.4.0

> CI failure: 
> ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer
>  fails with NoSubscriptionServersAvailableException: Primary discovery failed.
> -
>
> Key: GEODE-1988
> URL: https://issues.apache.org/jira/browse/GEODE-1988
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Darrel Schneider
>  Labels: ci
> Fix For: 1.3.0
>
> Attachments: 
> TEST-org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest.xml
>
>
> :geode-core:distributedTest
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest 
> > testRegisterCreatesInvalidEntry FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$18/601024495.run
>  in VM 3 running on Host 583dcf0e97d9 with 4 VMs
> Caused by:
> java.lang.AssertionError: failed while registering interest
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> Caused by:
> 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> 7578 tests completed, 1 failed, 588 skipped



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-1988) CI failure: ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer fails with NoSubscriptionServersAvailableException: Primary discovery fail

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-1988:
---
Affects Version/s: 1.3.0

> CI failure: 
> ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer
>  fails with NoSubscriptionServersAvailableException: Primary discovery failed.
> -
>
> Key: GEODE-1988
> URL: https://issues.apache.org/jira/browse/GEODE-1988
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Darrel Schneider
>  Labels: ci
> Fix For: 1.3.0
>
> Attachments: 
> TEST-org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest.xml
>
>
> :geode-core:distributedTest
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest 
> > testRegisterCreatesInvalidEntry FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$18/601024495.run
>  in VM 3 running on Host 583dcf0e97d9 with 4 VMs
> Caused by:
> java.lang.AssertionError: failed while registering interest
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> Caused by:
> 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> 7578 tests completed, 1 failed, 588 skipped



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (GEODE-1988) CI failure: ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer fails with NoSubscriptionServersAvailableException: Primary discove

[Shelley Lynn Hughes-Godfrey (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295776#comment-16295776
 ] 

Shelley Lynn Hughes-Godfrey edited comment on GEODE-1988 at 12/18/17 10:39 PM:
---

Re-opening as this was seen during CI on geode 1.3 as well as geode 1.4.

Failure from geode 1.3:
{noformat}
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest > 
testRegisterCreatesInvalidEntry FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/961935784.run
 in VM 3 running on Host de56e27ff16f with 4 VMs

Caused by:
java.lang.AssertionError: failed while registering interest

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.
{noformat}

Failure from geode 1.4:
{noformat}
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest > 
testRegisterCreatesInvalidEntry FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/1306182528.run
 in VM 3 running on Host 97127cced386 with 4 VMs

Caused by:
java.lang.AssertionError: failed while registering interest

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.
{noformat}


was (Author: lhughesgodfrey):
Re-opening as this was seen during CI on geode 1.3 as well as geode 1.4.

Failure from geode 1.3:
```
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest > 
testRegisterCreatesInvalidEntry FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/961935784.run
 in VM 3 running on Host de56e27ff16f with 4 VMs

Caused by:
java.lang.AssertionError: failed while registering interest

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.
```

Failure from geode 1.4:
```
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest > 
testRegisterCreatesInvalidEntry FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/1306182528.run
 in VM 3 running on Host 97127cced386 with 4 VMs

Caused by:
java.lang.AssertionError: failed while registering interest

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.
```

> CI failure: 
> ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer
>  fails with NoSubscriptionServersAvailableException: Primary discovery failed.
> -
>
> Key: GEODE-1988
> URL: https://issues.apache.org/jira/browse/GEODE-1988
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Darrel Schneider
>  Labels: ci
> Fix For: 1.3.0
>
> Attachments: 
> TEST-org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest.xml
>
>
> :geode-core:distributedTest
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest 
> > testRegisterCreatesInvalidEntry FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$18/601024495.run
>  in VM 3 running on Host 583dcf0e97d9 with 4 VMs
> Caused by:
> java.lang.AssertionError: failed while registering interest
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> 

[jira] [Commented] (GEODE-4054) Create module for Protobuf message-based Java driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295778#comment-16295778
 ] 

ASF GitHub Bot commented on GEODE-4054:
---

galen-pivotal commented on a change in pull request #1179: GEODE-4054: Create 
module for Protobuf message-based Java driver
URL: https://github.com/apache/geode/pull/1179#discussion_r157620414
 
 

 ##
 File path: 
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/statistics/ProtobufClientStatisticsImpl.java
 ##
 @@ -35,6 +37,9 @@
   private final int authenticationFailuresId;
 
   public ProtobufClientStatisticsImpl(StatisticsFactory statisticsFactory, 
String statisticsName) {
+if (statisticsFactory == null) {
 
 Review comment:
   @upthewaterspout @PivotalSarge I'm curious that this can happen. I thought 
we'd put logic in so that the statistics initialization would be separate. 
However, looking at `InternalLocator.myDS` it looks like the variable may be 
null... we should fix that at some point.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4093) New protocol throws NPE on embedded locator

[Dan Smith (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-4093.
--
   Resolution: Fixed
Fix Version/s: 1.4.0

> New protocol throws NPE on embedded locator
> ---
>
> Key: GEODE-4093
> URL: https://issues.apache.org/jira/browse/GEODE-4093
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
> Fix For: 1.4.0
>
>
> The new client protocol throws an NPE when using an embedded locator
> {noformat}
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.protocol.protobuf.statistics.ProtobufClientStatisticsImpl.(ProtobufClientStatisticsImpl.java:39)
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.ProtobufProtocolService.initializeStatistics(ProtobufProtocolService.java:34)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:392)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (GEODE-1988) CI failure: ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer fails with NoSubscriptionServersAvailableException: Primary discovery fai

[Shelley Lynn Hughes-Godfrey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey reopened GEODE-1988:


Re-opening as this was seen during CI on geode 1.3 as well as geode 1.4.

Failure from geode 1.3:
```
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest > 
testRegisterCreatesInvalidEntry FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/961935784.run
 in VM 3 running on Host de56e27ff16f with 4 VMs

Caused by:
java.lang.AssertionError: failed while registering interest

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.
```

Failure from geode 1.4:
```
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest > 
testRegisterCreatesInvalidEntry FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/1306182528.run
 in VM 3 running on Host 97127cced386 with 4 VMs

Caused by:
java.lang.AssertionError: failed while registering interest

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.
```

> CI failure: 
> ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer
>  fails with NoSubscriptionServersAvailableException: Primary discovery failed.
> -
>
> Key: GEODE-1988
> URL: https://issues.apache.org/jira/browse/GEODE-1988
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Darrel Schneider
>  Labels: ci
> Fix For: 1.3.0
>
> Attachments: 
> TEST-org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest.xml
>
>
> :geode-core:distributedTest
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest 
> > testRegisterCreatesInvalidEntry FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$18/601024495.run
>  in VM 3 running on Host 583dcf0e97d9 with 4 VMs
> Caused by:
> java.lang.AssertionError: failed while registering interest
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> Caused by:
> 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> 7578 tests completed, 1 failed, 588 skipped



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4098) Mutex guarding buckets statuses container has no timeout hanldling

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295760#comment-16295760
 ] 

ASF GitHub Bot commented on GEODE-4098:
---

pivotal-jbarrett commented on issue #169: GEODE-4098, add mutex timeout 
URL: https://github.com/apache/geode-native/pull/169#issuecomment-352576309
 
 
   @igorbarc What is the expected behavior of these functions should they 
return without updating the member data? Under what circumstances is this mutex 
held indefinitely that making it timed is corrected? Strikes me that this fix 
is hiding the real issue.
   
   Can you please also correct formatting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Mutex guarding buckets statuses container has no timeout hanldling
> --
>
> Key: GEODE-4098
> URL: https://issues.apache.org/jira/browse/GEODE-4098
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Igor Barchak
> Fix For: 1.2.0
>
>
> Mutex guarding buckets statuses container has no timeout handling,in 
> ClientMetadataService.cpp
> Can cause messages stuck on client 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-4112) Replace FunctionAdapter with Function in geode-lucene module

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun reassigned GEODE-4112:
--

Assignee: nabarun

> Replace FunctionAdapter with Function in geode-lucene module
> 
>
> Key: GEODE-4112
> URL: https://issues.apache.org/jira/browse/GEODE-4112
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Replace FunctionAdapter with Function in geode-lucene module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4080) Improve JSON encoding for new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295753#comment-16295753
 ] 

ASF GitHub Bot commented on GEODE-4080:
---

WireBaron commented on a change in pull request #1171: GEODE-4080: Protobuf 
JSON objects are in a proto string
URL: https://github.com/apache/geode/pull/1171#discussion_r157615529
 
 

 ##
 File path: 
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/utilities/ProtobufEncodingTypes.java
 ##
 @@ -28,22 +35,25 @@
   BOOLEAN(Boolean.class),
   DOUBLE(Double.class),
   FLOAT(Float.class),
-  BINARY(byte[].class);
+  BINARY(byte[].class),
+
+  // This will probably have to change once the protocol supports multiple 
object encodings.
+  PDX_OBJECT(PdxInstance.class);
 
 Review comment:
   I kind of liked having this enum as a way to identify which types were 
en/de-codable directly by the protobuf code as opposed to those needing a 
custom encoder/decoder provided by the server (and also by the client).  
Without that distinction, does it make sense to move this enum into the 
ProtobufSerializationService class?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve JSON encoding for new protocol
> --
>
> Key: GEODE-4080
> URL: https://issues.apache.org/jira/browse/GEODE-4080
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> One of the encoding types in the new protobuf protocol is called 
> {{CustomEncodedValue}}. However, users aren't really free to encode their own 
> types. Also, packing JSON into a byte array is going to be harder for users 
> than just sending ti as a string. Let's make the JSON type a string and put 
> the custom value type in later when we actually have support for custom 
> encoding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4080) Improve JSON encoding for new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295754#comment-16295754
 ] 

ASF GitHub Bot commented on GEODE-4080:
---

WireBaron commented on a change in pull request #1171: GEODE-4080: Protobuf 
JSON objects are in a proto string
URL: https://github.com/apache/geode/pull/1171#discussion_r157615958
 
 

 ##
 File path: 
geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/serialization/codec/JsonPdxConverter.java
 ##
 @@ -17,19 +17,29 @@
 import org.apache.geode.annotations.Experimental;
 
 Review comment:
   Hmm, curiously I can't seem to add a comment to line 15, but did we want to 
rethink the package name now that we're no longer calling these codecs?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve JSON encoding for new protocol
> --
>
> Key: GEODE-4080
> URL: https://issues.apache.org/jira/browse/GEODE-4080
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> One of the encoding types in the new protobuf protocol is called 
> {{CustomEncodedValue}}. However, users aren't really free to encode their own 
> types. Also, packing JSON into a byte array is going to be harder for users 
> than just sending ti as a string. Let's make the JSON type a string and put 
> the custom value type in later when we actually have support for custom 
> encoding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4113) Enhance experimental Java driver to support putting and getting objects

[Michael Dodge (JIRA)]

Michael Dodge created GEODE-4113:


 Summary: Enhance experimental Java driver to support putting and 
getting objects
 Key: GEODE-4113
 URL: https://issues.apache.org/jira/browse/GEODE-4113
 Project: Geode
  Issue Type: New Feature
  Components: client/server
Reporter: Michael Dodge


The Protobuf message-based Java experimental driver currently only supports 
putting and getting primitive Java values. It would be cool if it supported 
generic, run-of-the-mill Java objects and JSON.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4093) New protocol throws NPE on embedded locator

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295726#comment-16295726
 ] 

ASF subversion and git services commented on GEODE-4093:


Commit b16f984a7e94bdd02c511d1fb54ac132e726cce5 in geode's branch 
refs/heads/develop from [~upthewaterspout]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b16f984 ]

GEODE-4093: new protocol needs to work on an embedded locator

With an embedded locator, the new protocol was throwing an NPE in the
locator.


> New protocol throws NPE on embedded locator
> ---
>
> Key: GEODE-4093
> URL: https://issues.apache.org/jira/browse/GEODE-4093
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
>
> The new client protocol throws an NPE when using an embedded locator
> {noformat}
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.protocol.protobuf.statistics.ProtobufClientStatisticsImpl.(ProtobufClientStatisticsImpl.java:39)
>   at 
> org.apache.geode.internal.protocol.protobuf.v1.ProtobufProtocolService.initializeStatistics(ProtobufProtocolService.java:34)
>   at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:392)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4054) Create module for Protobuf message-based Java driver

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295725#comment-16295725
 ] 

ASF subversion and git services commented on GEODE-4054:


Commit 2f596638c68472ccacb0085d8982b574ca645cc4 in geode's branch 
refs/heads/develop from [~PivotalSarge]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2f59663 ]

GEODE-4054: Create module for Protobuf message-based client


> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4054) Create module for Protobuf message-based Java driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295724#comment-16295724
 ] 

ASF GitHub Bot commented on GEODE-4054:
---

upthewaterspout closed pull request #1179: GEODE-4054: Create module for 
Protobuf message-based Java driver
URL: https://github.com/apache/geode/pull/1179
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/geode-experimental-driver/build.gradle 
b/geode-experimental-driver/build.gradle
new file mode 100644
index 00..ce3eb46057
--- /dev/null
+++ b/geode-experimental-driver/build.gradle
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+dependencies {
+compile project(':geode-common')
+compile project(':geode-protobuf-messages')
+
+compile 'com.google.protobuf:protobuf-java:' + 
project.'protobuf-java.version'
+testCompile project(':geode-core')
+testCompile project(':geode-junit')
+testCompile project(':geode-protobuf')
+testCompile project(':geode-client-protocol')
+testCompile files(project(':geode-core').sourceSets.test.output)
+}
diff --git 
a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java
 
b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java
new file mode 100644
index 00..59e9f8246c
--- /dev/null
+++ 
b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/Driver.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.experimental.driver;
+
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.geode.annotations.Experimental;
+
+/**
+ * Defines the behaviors of a driver for communicating with a GemFire server 
by way of the new
+ * protocol.
+ *
+ * This code is an experimental prototype and is presented "as is" 
with no warranty,
+ * suitability, or fitness of purpose implied.
+ */
+@Experimental
+public interface Driver {
+  /**
+   * Retrieves a set of unique names of regions in the GemFire server to which 
this driver is
+   * connected.
+   *
+   * @return Set of strings of names that uniquely identify regions.
+   * @throws IOException
+   */
+  Set getRegionNames() throws IOException;
+
+  /**
+   * Creates an implementation of the region interface for the region with the 
unique name of
+   * regionName.
+   *
+   * @param regionName String that uniquely identifies the region.
+   * @param  Type of region keys.
+   * @param  Type of region values.
+   * @return
+   */
+   Region getRegion(String regionName);
+}
diff --git 
a/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java
 
b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java
new file mode 100644
index 00..267bb3d551
--- /dev/null
+++ 
b/geode-experimental-driver/src/main/java/org/apache/geode/experimental/driver/DriverFactory.java
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information 

[jira] [Commented] (GEODE-4080) Improve JSON encoding for new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295723#comment-16295723
 ] 

ASF GitHub Bot commented on GEODE-4080:
---

galen-pivotal commented on issue #1171: GEODE-4080: Protobuf JSON objects are 
in a proto string
URL: https://github.com/apache/geode/pull/1171#issuecomment-352567973
 
 
   Updated in response to feedback and rebased.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve JSON encoding for new protocol
> --
>
> Key: GEODE-4080
> URL: https://issues.apache.org/jira/browse/GEODE-4080
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> One of the encoding types in the new protobuf protocol is called 
> {{CustomEncodedValue}}. However, users aren't really free to encode their own 
> types. Also, packing JSON into a byte array is going to be harder for users 
> than just sending ti as a string. Let's make the JSON type a string and put 
> the custom value type in later when we actually have support for custom 
> encoding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295671#comment-16295671
 ] 

ASF GitHub Bot commented on GEODE-4079:
---

karensmolermiller opened a new pull request #1180: GEODE-4079 Identify hash 
indexes as deprecated in docs
URL: https://github.com/apache/geode/pull/1180
 
 
   I have marked all subsections on hash indexes as deprecated, and I have 
removed all examples (java code, XML, and gfsh commands) that demonstrated how 
to do things with hash indexes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4025) Write functional tests with external DB

[Anilkumar Gingade (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade updated GEODE-4025:
-
Issue Type: Test  (was: Sub-task)
Parent: (was: GEODE-3781)

> Write functional tests with external DB
> ---
>
> Key: GEODE-4025
> URL: https://issues.apache.org/jira/browse/GEODE-4025
> Project: Geode
>  Issue Type: Test
>  Components: regions
>Reporter: Fred Krone
>
> We will need an operational test infrastructure to do integration testing 
> with an external database.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4009) Use connection pooling JDBC library for PDX-JDBC

[Anilkumar Gingade (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade updated GEODE-4009:
-
Issue Type: Improvement  (was: Sub-task)
Parent: (was: GEODE-3781)

> Use connection pooling JDBC library for PDX-JDBC
> 
>
> Key: GEODE-4009
> URL: https://issues.apache.org/jira/browse/GEODE-4009
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Fred Krone
>Assignee: Kirk Lund
>
> We need a JDBC library for connection pooling, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-4109) if the experimental eviction code is being used then a log message should say so

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-4109.
-
   Resolution: Fixed
Fix Version/s: 1.4.0

> if the experimental eviction code is being used then a log message should say 
> so
> 
>
> Key: GEODE-4109
> URL: https://issues.apache.org/jira/browse/GEODE-4109
> Project: Geode
>  Issue Type: Bug
>  Components: eviction
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
> Fix For: 1.4.0
>
>
> If the new experimental eviction code is configured, then a log message 
> should say so.
> This will help diagnose issues caused by using the experimental feature.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (GEODE-4015) CI failure: ConflationDUnitTest.testTwoRegionsTwoWriters fails with AssertionError

[Barry Oglesby (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295626#comment-16295626
 ] 

Barry Oglesby edited comment on GEODE-4015 at 12/18/17 8:21 PM:


Saw this again. This time it contains a valid description: {{Expected 
counterUpdate to be 2. Instead it was 4.}}
{noformat}
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > 
testTwoRegionsTwoWriters FAILED
java.lang.AssertionError: Test failed due to exception
at org.apache.geode.test.dunit.Assert.fail(Assert.java:66)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:155)

Caused by:
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$63/2018334479.run
 in VM 2 running on Host c6e716e8ef5f with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:153)

Caused by:
java.lang.AssertionError: Event never occurred after 6 ms: 
Expected counterUpdate to be 2. Instead it was 4.
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:504)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.lambda$testTwoRegionsTwoWriters$bb17a952$10(ConflationDUnitTest.java:153)
{noformat}


was (Author: barry.oglesby):
Saw this again:
{noformat}
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > 
testTwoRegionsTwoWriters FAILED
java.lang.AssertionError: Test failed due to exception
at org.apache.geode.test.dunit.Assert.fail(Assert.java:66)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:155)

Caused by:
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$63/2018334479.run
 in VM 2 running on Host c6e716e8ef5f with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:153)

Caused by:
java.lang.AssertionError: Event never occurred after 6 ms: 
Expected counterUpdate to be 2. Instead it was 4.
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:504)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.lambda$testTwoRegionsTwoWriters$bb17a952$10(ConflationDUnitTest.java:153)
{noformat}

> CI failure: ConflationDUnitTest.testTwoRegionsTwoWriters fails with 
> AssertionError
> --
>
> Key: GEODE-4015
> URL: https://issues.apache.org/jira/browse/GEODE-4015
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barry Oglesby
> Fix For: 1.4.0
>
>
> Both testTwoRegionsTwoWriters and testTwoRegionsOneWriter failed with the 
> same AssertionError:
> {noformat}
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > 
> testTwoRegionsTwoWriters FAILED
> java.lang.AssertionError: Test failed due to exception
> at org.apache.geode.test.dunit.Assert.fail(Assert.java:66)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:155)
> Caused by:
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$193/1316585270.run
>  in VM 2 running on Host 6b07584084c4 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> 

[jira] [Reopened] (GEODE-4015) CI failure: ConflationDUnitTest.testTwoRegionsTwoWriters fails with AssertionError

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby reopened GEODE-4015:
--

Saw this again:
{noformat}
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > 
testTwoRegionsTwoWriters FAILED
java.lang.AssertionError: Test failed due to exception
at org.apache.geode.test.dunit.Assert.fail(Assert.java:66)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:155)

Caused by:
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$63/2018334479.run
 in VM 2 running on Host c6e716e8ef5f with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:153)

Caused by:
java.lang.AssertionError: Event never occurred after 6 ms: 
Expected counterUpdate to be 2. Instead it was 4.
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:504)
at 
org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.lambda$testTwoRegionsTwoWriters$bb17a952$10(ConflationDUnitTest.java:153)
{noformat}

> CI failure: ConflationDUnitTest.testTwoRegionsTwoWriters fails with 
> AssertionError
> --
>
> Key: GEODE-4015
> URL: https://issues.apache.org/jira/browse/GEODE-4015
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barry Oglesby
> Fix For: 1.4.0
>
>
> Both testTwoRegionsTwoWriters and testTwoRegionsOneWriter failed with the 
> same AssertionError:
> {noformat}
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > 
> testTwoRegionsTwoWriters FAILED
> java.lang.AssertionError: Test failed due to exception
> at org.apache.geode.test.dunit.Assert.fail(Assert.java:66)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:155)
> Caused by:
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$193/1316585270.run
>  in VM 2 running on Host 6b07584084c4 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsTwoWriters(ConflationDUnitTest.java:153)
> Caused by:
> java.lang.AssertionError: Event never occurred after 6 ms: 
> null
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:506)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.lambda$testTwoRegionsTwoWriters$bb17a952$10(ConflationDUnitTest.java:153)
> {noformat}
> {noformat}
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest > 
> testTwoRegionsOneWriter FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest$$Lambda$221/1553950035.run
>  in VM 2 running on Host 6b07584084c4 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.testTwoRegionsOneWriter(ConflationDUnitTest.java:183)
> Caused by:
> java.lang.AssertionError: Event never occurred after 6 ms: null
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
> at 
> org.apache.geode.internal.cache.tier.sockets.ConflationDUnitTest.assertCounterSizes(ConflationDUnitTest.java:506)
> at 
> 

[jira] [Updated] (GEODE-4106) Backup of DiskStoreIF file fails when relative path provided as destination

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-4106:
--
Fix Version/s: 1.4.0

> Backup of DiskStoreIF file fails when relative path provided as destination
> ---
>
> Key: GEODE-4106
> URL: https://issues.apache.org/jira/browse/GEODE-4106
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.4.0
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> Backup functions correctly when absolute paths are used and when relative 
> paths are used, only the DiskStoreIF file is copied to the incorrect location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3799) Create plugin system for specifying where a backup is stored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295601#comment-16295601
 ] 

ASF GitHub Bot commented on GEODE-3799:
---

nreich closed pull request #1177: Revert "GEODE-3799: Move backups towards a 
pluggable architecture (#1…
URL: https://github.com/apache/geode/pull/1177
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
b/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
index e3ea1fb39c..e3701e0a1c 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
@@ -28,8 +28,6 @@
 import java.nio.channels.ClosedByInterruptException;
 import java.nio.channels.FileChannel;
 import java.nio.channels.FileLock;
-import java.nio.file.Files;
-import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
@@ -38,7 +36,6 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
-import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 import java.util.Set;
@@ -61,11 +58,9 @@
 import java.util.concurrent.locks.ReentrantReadWriteLock.WriteLock;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
-import java.util.stream.Collectors;
 
 import it.unimi.dsi.fastutil.ints.IntOpenHashSet;
 import it.unimi.dsi.fastutil.longs.LongOpenHashSet;
-import org.apache.commons.io.FileUtils;
 import org.apache.logging.log4j.Logger;
 
 import org.apache.geode.CancelCriterion;
@@ -1962,8 +1957,6 @@ private void loadFiles(boolean needsOplogs) {
 deleteFiles(overflowFileFilter);
   }
 
-  cleanupOrphanedBackupDirectories();
-
   persistentOplogs.createOplogs(needsOplogs, persistentBackupFiles);
   finished = true;
 
@@ -1989,28 +1982,6 @@ private void loadFiles(boolean needsOplogs) {
 }
   }
 
-  private void cleanupOrphanedBackupDirectories() {
-for (DirectoryHolder directoryHolder : getDirectoryHolders()) {
-  try {
-List backupDirectories = 
Files.list(directoryHolder.getDir().toPath())
-.filter((path) -> path.getFileName().toString()
-.startsWith(BackupManager.DATA_STORES_TEMPORARY_DIRECTORY))
-.filter(p -> Files.isDirectory(p)).collect(Collectors.toList());
-for (Path backupDirectory : backupDirectories) {
-  try {
-logger.info("Deleting orphaned backup temporary directory: " + 
backupDirectory);
-FileUtils.deleteDirectory(backupDirectory.toFile());
-  } catch (IOException e) {
-logger.warn("Failed to remove orphaned backup temporary directory: 
" + backupDirectory,
-e);
-  }
-}
-  } catch (IOException e) {
-logger.warn(e);
-  }
-}
-  }
-
   /**
* The diskStats are at PR level.Hence if the region is a bucket region, the 
stats should not be
* closed, but the figures of entriesInVM and overflowToDisk contributed by 
that bucket need to be
diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupDefinition.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupDefinition.java
deleted file mode 100644
index 685d03b474..00
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupDefinition.java
+++ /dev/null
@@ -1,83 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for additional 
information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
- * or implied. See the License for the specific language governing permissions 
and limitations under
- * the License.
- */
-package org.apache.geode.internal.cache.backup;
-
-import java.nio.file.Path;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.Set;
-
-import org.apache.geode.cache.DiskStore;
-
-class BackupDefinition {
-  private final Map oplogFilesByDiskStore = 

[jira] [Commented] (GEODE-3799) Create plugin system for specifying where a backup is stored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295600#comment-16295600
 ] 

ASF GitHub Bot commented on GEODE-3799:
---

nreich commented on issue #1177: Revert "GEODE-3799: Move backups towards a 
pluggable architecture (#1…
URL: https://github.com/apache/geode/pull/1177#issuecomment-352541073
 
 
   GEODE-4106 (PR#1173) has been closed and merged, making this reversion no 
longer necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create plugin system for specifying where a backup is stored
> 
>
> Key: GEODE-3799
> URL: https://issues.apache.org/jira/browse/GEODE-3799
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> The current logic merges the moving/copying of files with the determining of 
> what to backup. To make it possible to store a backup in cloud storage or 
> other locations, we need to separate these concerns, putting the variable, 
> location-based logic, into a plugin architecture.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken

[Jason Huynh (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295551#comment-16295551
 ] 

Jason Huynh commented on GEODE-3813:


Here are my interpretation of the results from the dev list:
- deprecate current "ALL_KEYS" and List passing behavior in registerInterest()
- add registerInterestForAllKeys();
- add registerInterestForKeys(T... keys)
- add registerInterestForKeys(Iterablekeys)

I believe this will have to be done in two phases.
Phase 1:
- Deprecate ALL_KEYS and List passing behavior
- Add warnings when ALL_KEYS or Lists are passed to the current registerInterest
- add registerInterestForAllKeys();
- optional (add registerInterestForKeys(Iterable and add 
registerInterestForKeys(T...) where it does the iteration on the client and 
just calls registerInterest(T) for each key.  This is not optimal but is 
definitely doable if needed)

Phase 2: (Major version/possibly breaking change)
- remove behavior of List (there is a specific messages for this)
- remove behavior of ALL_KEYS from the code.  
- add and optimize registerInterestForKeys(Iterable) to do the iteration on 
the server
- add registerInterest(T... keys)

When Phase 1 is complete, possibly open a new ticket for Phase 1


> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
>  Issue Type: Bug
>  Components: client queues, regions
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>
> The registerInterest API works for single key registration but is broken for 
> all other types of registration if the Region is declared with type 
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding 
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4054) Create module for Protobuf message-based Java driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295522#comment-16295522
 ] 

ASF GitHub Bot commented on GEODE-4054:
---

PivotalSarge opened a new pull request #1179: GEODE-4054: Create module for 
Protobuf message-based Java driver
URL: https://github.com/apache/geode/pull/1179
 
 
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [X] Have you written or updated unit tests to verify your changes?
   
   - [N/A] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4054) Create module for Protobuf message-based Java driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295528#comment-16295528
 ] 

ASF GitHub Bot commented on GEODE-4054:
---

PivotalSarge commented on issue #1179: GEODE-4054: Create module for Protobuf 
message-based Java driver
URL: https://github.com/apache/geode/pull/1179#issuecomment-352532919
 
 
   @upthewaterspout @galen-pivotal @WireBaron @bschuchardt 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4112) Replace FunctionAdapter with Function in geode-lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295520#comment-16295520
 ] 

ASF GitHub Bot commented on GEODE-4112:
---

nabarunnag opened a new pull request #1178: GEODE-4112: Replaced 
FunctionAdapter with Function in geode-lucene
URL: https://github.com/apache/geode/pull/1178
 
 
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Replace FunctionAdapter with Function in geode-lucene module
> 
>
> Key: GEODE-4112
> URL: https://issues.apache.org/jira/browse/GEODE-4112
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Replace FunctionAdapter with Function in geode-lucene module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-4112) Replace FunctionAdapter with Function in geode-lucene module

[nabarun (JIRA)]

nabarun created GEODE-4112:
--

 Summary: Replace FunctionAdapter with Function in geode-lucene 
module
 Key: GEODE-4112
 URL: https://issues.apache.org/jira/browse/GEODE-4112
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


Replace FunctionAdapter with Function in geode-lucene module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4108) LRUListWithAsyncSorting has a static thread pool

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-4108:
--
Issue Type: Sub-task  (was: Bug)
Parent: GEODE-3622

> LRUListWithAsyncSorting has a static thread pool
> 
>
> Key: GEODE-4108
> URL: https://issues.apache.org/jira/browse/GEODE-4108
> Project: Geode
>  Issue Type: Sub-task
>  Components: eviction
>Reporter: Darrel Schneider
>
> LRUListWithAsyncSorting has a static thread pool. It should instead have a 
> thread pool whose life is limited to the life of the cache. That way if the 
> cache is closed the thread pool will be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4088) add a dunit test to prove TX will have different behavior for region.keySet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295471#comment-16295471
 ] 

ASF GitHub Bot commented on GEODE-4088:
---

jhuynh1 closed pull request #1159: GEODE-4088: add a dunit test to show the 
client region keySet() in TX
URL: https://github.com/apache/geode/pull/1159
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add a dunit test to prove TX will have different behavior for region.keySet
> ---
>
> Key: GEODE-4088
> URL: https://issues.apache.org/jira/browse/GEODE-4088
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>
> Some code used region.keySet() at client side with policy NORMAL. It expected 
> to get local entries only. But in TX, it will actually iterate server 
> region's entries. 
> I introduced a dunit test to show the difference with and without TX. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4088) add a dunit test to prove TX will have different behavior for region.keySet

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295473#comment-16295473
 ] 

ASF subversion and git services commented on GEODE-4088:


Commit 8d868303d9275d45eadd46325f9bdaa7e225ea8a in geode's branch 
refs/heads/develop from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8d86830 ]

GEODE-4088: add a dunit test to show the client region keySet() in TX (#1159)



> add a dunit test to prove TX will have different behavior for region.keySet
> ---
>
> Key: GEODE-4088
> URL: https://issues.apache.org/jira/browse/GEODE-4088
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>
> Some code used region.keySet() at client side with policy NORMAL. It expected 
> to get local entries only. But in TX, it will actually iterate server 
> region's entries. 
> I introduced a dunit test to show the difference with and without TX. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4057) [CI Failure] PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295467#comment-16295467
 ] 

ASF GitHub Bot commented on GEODE-4057:
---

nabarunnag closed pull request #1126: GEODE-4057: Cleaning up previous cache.
URL: https://github.com/apache/geode/pull/1126
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/JUnit4CacheTestCase.java
 
b/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/JUnit4CacheTestCase.java
index 0750be302e..5cbc37045d 100644
--- 
a/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/JUnit4CacheTestCase.java
+++ 
b/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/JUnit4CacheTestCase.java
@@ -16,6 +16,7 @@
 
 import static org.apache.geode.distributed.ConfigurationProperties.MCAST_PORT;
 import static 
org.apache.geode.distributed.internal.DistributionConfig.GEMFIRE_PREFIX;
+import static org.junit.Assert.assertNull;
 
 import java.io.File;
 import java.io.FileWriter;
@@ -220,23 +221,33 @@ public final InternalCache getCache(final boolean client) 
{
 
   public final InternalCache getCache(final boolean client, final CacheFactory 
factory) {
 synchronized (JUnit4CacheTestCase.class) {
+  if (!(cache instanceof GemFireCacheImpl) && cache != null) {
+addIgnoreExceptionIfClient(client);
+return cache;
+  }
+
   InternalCache gemFireCache = GemFireCacheImpl.getInstance();
-  if (gemFireCache != null && !gemFireCache.isClosed()
-  && gemFireCache.getCancelCriterion().isCancelInProgress()) {
+  if (gemFireCache != null && 
gemFireCache.getCancelCriterion().isCancelInProgress()) {
 Awaitility.await("waiting for cache to close").atMost(30, 
TimeUnit.SECONDS)
-.until(gemFireCache::isClosed);
+.until(() -> assertNull(GemFireCacheImpl.getInstance()));
   }
-  if (cache == null || cache.isClosed()) {
+
+  if (GemFireCacheImpl.getInstance() == null) {
 cache = null;
 createCache(client, factory);
   }
-  if (client && cache != null) {
-IgnoredException.addIgnoredException("java.net.ConnectException");
-  }
+
+  addIgnoreExceptionIfClient(client);
   return cache;
 }
   }
 
+  private void addIgnoreExceptionIfClient(boolean client) {
+if (client && cache != null) {
+  IgnoredException.addIgnoredException("java.net.ConnectException");
+}
+  }
+
   /**
* Creates a client cache from the factory if one does not already exist.
*
@@ -245,19 +256,15 @@ public final InternalCache getCache(final boolean client, 
final CacheFactory fac
   public final ClientCache getClientCache(final ClientCacheFactory factory) {
 synchronized (JUnit4CacheTestCase.class) {
   InternalCache gemFireCache = GemFireCacheImpl.getInstance();
-  if (gemFireCache != null && !gemFireCache.isClosed()
-  && gemFireCache.getCancelCriterion().isCancelInProgress()) {
+  if (gemFireCache != null && 
gemFireCache.getCancelCriterion().isCancelInProgress()) {
 Awaitility.await("waiting for cache to close").atMost(30, 
TimeUnit.SECONDS)
-.until(gemFireCache::isClosed);
+.until(() -> assertNull(GemFireCacheImpl.getInstance()));
   }
-  if (cache == null || cache.isClosed()) {
-cache = null;
+  if (cache == null) {
 disconnectFromDS();
 cache = (InternalCache) factory.create();
   }
-  if (cache != null) {
-IgnoredException.addIgnoredException("java.net.ConnectException");
-  }
+  IgnoredException.addIgnoredException("java.net.ConnectException");
   return (ClientCache) cache;
 }
   }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI Failure] 
> PartitionedRegionCqQueryOptimizedExecuteDUnitTest.testCqExecuteWithoutQueryExecution
> -
>
> Key: GEODE-4057
> URL: https://issues.apache.org/jira/browse/GEODE-4057
> Project: Geode
>  Issue Type: Bug
>  Components: cq
>Reporter: nabarun
>
> *+Failure+*: Apache Geode Concourse CI Distributed Test RunID#7
> *+More logs can be found in+* : 
> http://files.apachegeode-ci.info/builds/1.4.0-build.150/test-results/distributedTest/
> 

[jira] [Resolved] (GEODE-4042) Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of hardcoding to /tmp

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-4042.

Resolution: Fixed

I'm going to resolve this ticket for now.  The tests do take in the system 
property java.io.tmpDir.  If the test is run through gradle, gradle currently 
does not pass any of the settings down to the test VMs.

The reverted commit would do this, but it may impact other tests.  If it is 
needed, another ticket can be opened to pass down specific properties down to 
the test vms

> Cargo tests for Jetty and Tomcat should use java.io.tmpdir instead of 
> hardcoding to /tmp
> 
>
> Key: GEODE-4042
> URL: https://issues.apache.org/jira/browse/GEODE-4042
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> Currently the Cargo Tests for the session state module are hard coded to run 
> off of /tmp.  Instead it should probably be pointed towards using 
> java.io.tmpdir.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4061) Adding coordinator in list member command output

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295451#comment-16295451
 ] 

ASF subversion and git services commented on GEODE-4061:


Commit fdcdbc0d0a77c9f983bcfc6d8d9909365b4c95a0 in geode's branch 
refs/heads/develop from [~dineshpune]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fdcdbc0 ]

Feature/GEODE-4061 : Adding coordinator in list member command output (#1138)

* bump release version

* GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)

* GEODE-3873: User Guide - remove version drop-down menu from page headers

* GEODE-4061:printing coordinator in list member command
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
modified:   
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java

*  GEODE-4061: First review comments
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java


> Adding coordinator in list member command output
> 
>
> Key: GEODE-4061
> URL: https://issues.apache.org/jira/browse/GEODE-4061
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: dinesh ak
>
> no way to find out the coordinator apart from log messages.
> i have added coordinator in list member command output.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4061) Adding coordinator in list member command output

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295452#comment-16295452
 ] 

ASF subversion and git services commented on GEODE-4061:


Commit fdcdbc0d0a77c9f983bcfc6d8d9909365b4c95a0 in geode's branch 
refs/heads/develop from [~dineshpune]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fdcdbc0 ]

Feature/GEODE-4061 : Adding coordinator in list member command output (#1138)

* bump release version

* GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)

* GEODE-3873: User Guide - remove version drop-down menu from page headers

* GEODE-4061:printing coordinator in list member command
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
modified:   
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java

*  GEODE-4061: First review comments
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java


> Adding coordinator in list member command output
> 
>
> Key: GEODE-4061
> URL: https://issues.apache.org/jira/browse/GEODE-4061
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: dinesh ak
>
> no way to find out the coordinator apart from log messages.
> i have added coordinator in list member command output.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2670) Update pulse endpoint interceptors

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295449#comment-16295449
 ] 

ASF subversion and git services commented on GEODE-2670:


Commit fdcdbc0d0a77c9f983bcfc6d8d9909365b4c95a0 in geode's branch 
refs/heads/develop from [~dineshpune]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fdcdbc0 ]

Feature/GEODE-4061 : Adding coordinator in list member command output (#1138)

* bump release version

* GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)

* GEODE-3873: User Guide - remove version drop-down menu from page headers

* GEODE-4061:printing coordinator in list member command
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
modified:   
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java

*  GEODE-4061: First review comments
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java


> Update pulse endpoint interceptors
> --
>
> Key: GEODE-2670
> URL: https://issues.apache.org/jira/browse/GEODE-2670
> Project: Geode
>  Issue Type: Bug
>  Components: pulse, security
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
> Fix For: 1.1.1, 1.2.0
>
>
> Steps to reproduce:
> 1) in gfsh, start up a locator with a security manager
> 2) in the browser, try to connect to pulse: http://localhost:7070/pulse
> 3) when presented a login page, try a invalid username/password.
> 4) when getting "incorrect password" hint, use the same username, try using 
> the correct password for that user. It would still say "incorrect password".
> Also, repeat above step 1 and 2, 
> 3), use a correct username and password that only have cluster:read previlage.
> 4) try to access the dataBrowser.html, expect to get denied access, but is 
> still able to access. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4061) Adding coordinator in list member command output

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295448#comment-16295448
 ] 

ASF subversion and git services commented on GEODE-4061:


Commit fdcdbc0d0a77c9f983bcfc6d8d9909365b4c95a0 in geode's branch 
refs/heads/develop from [~dineshpune]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fdcdbc0 ]

Feature/GEODE-4061 : Adding coordinator in list member command output (#1138)

* bump release version

* GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)

* GEODE-3873: User Guide - remove version drop-down menu from page headers

* GEODE-4061:printing coordinator in list member command
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
modified:   
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java

*  GEODE-4061: First review comments
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java


> Adding coordinator in list member command output
> 
>
> Key: GEODE-4061
> URL: https://issues.apache.org/jira/browse/GEODE-4061
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: dinesh ak
>
> no way to find out the coordinator apart from log messages.
> i have added coordinator in list member command output.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4061) Adding coordinator in list member command output

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295447#comment-16295447
 ] 

ASF GitHub Bot commented on GEODE-4061:
---

pdxrunner closed pull request #1138: Feature/GEODE-4061 : Adding coordinator in 
list member command output
URL: https://github.com/apache/geode/pull/1138
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
index f9e5544aef..1a787f383d 100644
--- 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
+++ 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
@@ -314,4 +314,9 @@ public boolean waitForDeparture(DistributedMember mbr)
*/
   public void releaseQuorumChecker(QuorumChecker checker);
 
+  /**
+   * return the coordinator for the view.
+   */
+  public DistributedMember getCoordinator();
+
 }
diff --git 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
index 49336962f5..9232c6e04d 100644
--- 
a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
+++ 
b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
@@ -1401,6 +1401,7 @@ private boolean isJoining() {
*
* @return the current membership view coordinator
*/
+  @Override
   public DistributedMember getCoordinator() {
 latestViewReadLock.lock();
 try {
diff --git 
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
 
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
index 34207cdbb9..6b25800082 100644
--- 
a/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
+++ 
b/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
@@ -22,6 +22,8 @@
 import org.springframework.shell.core.annotation.CliOption;
 
 import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.distributed.internal.membership.MembershipManager;
 import org.apache.geode.internal.cache.InternalCache;
 import org.apache.geode.management.cli.CliMetaData;
 import org.apache.geode.management.cli.ConverterHint;
@@ -59,7 +61,11 @@ public Result listMember(@CliOption(key = 
{CliStrings.GROUP}, unspecifiedDefault
   if (memberSet.isEmpty()) {
 result = 
ResultBuilder.createInfoResult(CliStrings.LIST_MEMBER__MSG__NO_MEMBER_FOUND);
   } else {
+
 TabularResultData resultData = ResultBuilder.createTabularResultData();
+final String coordinatorMember = getCoordinator();
+resultData.accumulate("Name", "Coordinator:");
+resultData.accumulate("Id", coordinatorMember);
 for (DistributedMember member : memberSet) {
   resultData.accumulate("Name", member.getName());
   resultData.accumulate("Id", member.getId());
@@ -74,4 +80,18 @@ public Result listMember(@CliOption(key = 
{CliStrings.GROUP}, unspecifiedDefault
 }
 return result;
   }
+
+  private String getCoordinator() {
+String result = "unknown";
+InternalDistributedSystem ids = 
InternalDistributedSystem.getConnectedInstance();
+if ((ids != null) && (ids.isConnected())) {
+  MembershipManager mmgr = 
ids.getDistributionManager().getMembershipManager();
+  DistributedMember coord = mmgr.getCoordinator();
+  if (coord != null) {
+result = coord.toString();
+  }
+}
+
+return result;
+  }
 }
diff --git 
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
 
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
index 3ad80a91d0..c95fcfa9ba 100644
--- 
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java
@@ -67,6 +67,7 @@ public void listAllMembers() throws Exception {
 assertThat(output).contains("server-1");
 assertThat(output).contains("server-2");
 assertThat(output).contains("server-3");
+

[jira] [Commented] (GEODE-3873) User Guide: Drop-down menu for earlier versions doesn't work

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295450#comment-16295450
 ] 

ASF subversion and git services commented on GEODE-3873:


Commit fdcdbc0d0a77c9f983bcfc6d8d9909365b4c95a0 in geode's branch 
refs/heads/develop from [~dineshpune]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fdcdbc0 ]

Feature/GEODE-4061 : Adding coordinator in list member command output (#1138)

* bump release version

* GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)

* GEODE-3873: User Guide - remove version drop-down menu from page headers

* GEODE-4061:printing coordinator in list member command
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java
modified:   
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListMembersCommandDUnitTest.java

*  GEODE-4061: First review comments
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
modified:   
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ListMembersCommand.java


> User Guide: Drop-down menu for earlier versions doesn't work
> 
>
> Key: GEODE-3873
> URL: https://issues.apache.org/jira/browse/GEODE-3873
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.1.0, 1.2.1, 1.4.0
>
>
> The User Guide header contains a drop-down menu showing earlier versions of 
> the manual, but the links don't work. Also, the drop-down for v1.1 doesn't 
> have a link for the newer version, 1.2.
> This is both a currently broken implementation and a future maintenance 
> headache.
> Since all (currently 3) versions are accessible from the Geode website's Docs 
> page, let's just eliminate the version drop-down menu altogether.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-4054) Create module for Protobuf message-based Java driver

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge updated GEODE-4054:
-
Description: Create a module, geode-experimental-driver, that contains a 
simple Java driver that exercises the Protobuf messages and the new protocol.  
(was: Create a module, geode-protobuf-client, that contains a simple Java 
client that exercises the Protobuf messages and the new protocol. This client 
should allow the interaction with a locator and cache server based on 
command-line arguments, a file of commands, or an interactive shell.)

> Create module for Protobuf message-based Java driver
> 
>
> Key: GEODE-4054
> URL: https://issues.apache.org/jira/browse/GEODE-4054
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Michael Dodge
>
> Create a module, geode-experimental-driver, that contains a simple Java 
> driver that exercises the Protobuf messages and the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4106) Backup of DiskStoreIF file fails when relative path provided as destination

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295366#comment-16295366
 ] 

ASF GitHub Bot commented on GEODE-4106:
---

nreich closed pull request #1173: GEODE-4106: Fix relative path destinations 
for backups
URL: https://github.com/apache/geode/pull/1173
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/main/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestination.java
 
b/geode-core/src/main/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestination.java
index 997ab10323..2955d6e7aa 100644
--- 
a/geode-core/src/main/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestination.java
+++ 
b/geode-core/src/main/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestination.java
@@ -73,9 +73,9 @@ private void backupDiskInitFiles(Map 
diskInitFiles) throws IOEx
 for (Map.Entry entry : diskInitFiles.entrySet()) {
   Path destinationDirectory = getOplogBackupDir(entry.getKey(),
   ((DiskStoreImpl) entry.getKey()).getInforFileDirIndex());
-  
Files.createDirectories(destinationDirectory.resolve(destinationDirectory));
-  Files.copy(entry.getValue(), 
destinationDirectory.resolve(destinationDirectory)
-  .resolve(entry.getValue().getFileName()), 
StandardCopyOption.COPY_ATTRIBUTES);
+  Files.createDirectories(destinationDirectory);
+  Files.copy(entry.getValue(), 
destinationDirectory.resolve(entry.getValue().getFileName()),
+  StandardCopyOption.COPY_ATTRIBUTES);
 }
   }
 
diff --git 
a/geode-core/src/test/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestinationTest.java
 
b/geode-core/src/test/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestinationTest.java
index 752d88cb41..a969a0542b 100644
--- 
a/geode-core/src/test/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestinationTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/internal/cache/backup/FileSystemBackupDestinationTest.java
@@ -28,12 +28,18 @@
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.nio.file.Paths;
 
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.apache.commons.io.FileUtils;
+import org.junit.After;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
 
 import org.apache.geode.internal.cache.DiskStoreImpl;
 import org.apache.geode.internal.cache.GemFireCacheImpl;
@@ -42,7 +48,9 @@
 import org.apache.geode.test.junit.categories.IntegrationTest;
 
 @Category(IntegrationTest.class)
+@RunWith(JUnitParamsRunner.class)
 public class FileSystemBackupDestinationTest {
+  private static final Path RELATIVE_TARGET_DIR = Paths.get("backupTest");
 
   @Rule
   public TemporaryFolder tempDir = new TemporaryFolder();
@@ -60,17 +68,26 @@ public void setup() throws IOException {
 when(restoreScript.generate(any())).thenReturn(tempDir.newFile());
   }
 
+  @After
+  public void tearDown() throws IOException {
+// Testing relative paths forces creation of files in working dir instead 
of temporary folder
+if (Files.exists(RELATIVE_TARGET_DIR)) {
+  FileUtils.deleteDirectory(RELATIVE_TARGET_DIR.toFile());
+}
+  }
+
   @Test
-  public void userFilesAreBackedUp() throws Exception {
+  @Parameters({"true", "false"})
+  public void userFilesAreBackedUp(boolean useRelativePath) throws Exception {
 Path userFile = tempDir.newFile("userFile").toPath();
 Path userSubdir = tempDir.newFolder("userSubDir").toPath();
 Path userFileInDir = Files.write(userSubdir.resolve("fileInDir"), new 
byte[] {});
 backupDefinition.addUserFilesToBackup(userFile);
 backupDefinition.addUserFilesToBackup(userSubdir);
 
-executeBackup();
+executeBackup(useRelativePath);
 
-Path userDir = targetDir.resolve(USER_FILES_DIRECTORY);
+Path userDir = getTargetDir(useRelativePath).resolve(USER_FILES_DIRECTORY);
 assertThat(userDir.resolve(userFile.getFileName())).exists();
 assertThat(userDir.resolve(userSubdir.getFileName())).exists();
 
assertThat(userDir.resolve(userSubdir.getFileName()).resolve(userFileInDir.getFileName()))
@@ -78,16 +95,17 @@ public void userFilesAreBackedUp() throws Exception {
   }
 
   @Test
-  public void deployedJarsAreBackedUp() throws Exception {
+  @Parameters({"true", "false"})
+  public void deployedJarsAreBackedUp(boolean useRelativePath) throws 
Exception {
 Path jarFile = tempDir.newFile("jarFile").toPath();
 

[jira] [Commented] (GEODE-4106) Backup of DiskStoreIF file fails when relative path provided as destination

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295367#comment-16295367
 ] 

ASF subversion and git services commented on GEODE-4106:


Commit 15402eb26c96c11332cbc624aad9f6dc1eaa69c0 in geode's branch 
refs/heads/develop from [~nreich]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=15402eb ]

GEODE-4106: Fix relative path destinations for backups (#1173)

* GEODE-4106: Fix relative path destinations for backups


> Backup of DiskStoreIF file fails when relative path provided as destination
> ---
>
> Key: GEODE-4106
> URL: https://issues.apache.org/jira/browse/GEODE-4106
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.4.0
>Reporter: Nick Reich
>Assignee: Nick Reich
>
> Backup functions correctly when absolute paths are used and when relative 
> paths are used, only the DiskStoreIF file is copied to the incorrect location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4106) Backup of DiskStoreIF file fails when relative path provided as destination

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295368#comment-16295368
 ] 

ASF subversion and git services commented on GEODE-4106:


Commit 15402eb26c96c11332cbc624aad9f6dc1eaa69c0 in geode's branch 
refs/heads/develop from [~nreich]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=15402eb ]

GEODE-4106: Fix relative path destinations for backups (#1173)

* GEODE-4106: Fix relative path destinations for backups


> Backup of DiskStoreIF file fails when relative path provided as destination
> ---
>
> Key: GEODE-4106
> URL: https://issues.apache.org/jira/browse/GEODE-4106
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.4.0
>Reporter: Nick Reich
>Assignee: Nick Reich
>
> Backup functions correctly when absolute paths are used and when relative 
> paths are used, only the DiskStoreIF file is copied to the incorrect location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3799) Create plugin system for specifying where a backup is stored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295365#comment-16295365
 ] 

ASF GitHub Bot commented on GEODE-3799:
---

nreich commented on issue #1177: Revert "GEODE-3799: Move backups towards a 
pluggable architecture (#1…
URL: https://github.com/apache/geode/pull/1177#issuecomment-352508430
 
 
   GEODE-4106 is ready and passed all precheckin tests. I will pull it in.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create plugin system for specifying where a backup is stored
> 
>
> Key: GEODE-3799
> URL: https://issues.apache.org/jira/browse/GEODE-3799
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> The current logic merges the moving/copying of files with the determining of 
> what to backup. To make it possible to store a backup in cloud storage or 
> other locations, we need to separate these concerns, putting the variable, 
> location-based logic, into a plugin architecture.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4080) Improve JSON encoding for new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295354#comment-16295354
 ] 

ASF GitHub Bot commented on GEODE-4080:
---

upthewaterspout commented on a change in pull request #1171: GEODE-4080: 
Protobuf JSON objects are in a proto string
URL: https://github.com/apache/geode/pull/1171#discussion_r157550131
 
 

 ##
 File path: 
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufSerializationService.java
 ##
 @@ -14,42 +14,124 @@
  */
 package org.apache.geode.internal.protocol.protobuf.v1;
 
+import com.google.protobuf.ByteString;
+
 import org.apache.geode.annotations.Experimental;
+import 
org.apache.geode.internal.protocol.protobuf.v1.utilities.ProtobufPrimitiveTypes;
+import 
org.apache.geode.internal.protocol.protobuf.v1.utilities.exception.UnknownProtobufPrimitiveType;
 import org.apache.geode.internal.protocol.serialization.SerializationService;
-import org.apache.geode.internal.protocol.serialization.SerializationType;
-import org.apache.geode.internal.protocol.serialization.TypeCodec;
-import 
org.apache.geode.internal.protocol.serialization.exception.UnsupportedEncodingTypeException;
-import 
org.apache.geode.internal.protocol.serialization.registry.SerializationCodecRegistry;
-import 
org.apache.geode.internal.protocol.serialization.registry.exception.CodecNotRegisteredForTypeException;
+import org.apache.geode.internal.protocol.serialization.codec.JsonPdxConverter;
+import 
org.apache.geode.internal.protocol.serialization.exception.EncodingException;
+import org.apache.geode.pdx.JSONFormatterException;
+import org.apache.geode.pdx.PdxInstance;
 
 @Experimental
-public class ProtobufSerializationService implements 
SerializationService {
-  private SerializationCodecRegistry serializationCodecRegistry = new 
SerializationCodecRegistry();
+public class ProtobufSerializationService implements 
SerializationService {
+  private final JsonPdxConverter jsonPdxConverter = new JsonPdxConverter();
 
   public ProtobufSerializationService() {}
 
+  /**
+   * @param value the value to be encoded
+   *
+   * @return EncodedValue message with the serialized value
+   * @throws EncodingException
+   */
   @Override
-  public byte[] encode(BasicTypes.EncodingType encodingTypeValue, Object value)
-  throws UnsupportedEncodingTypeException, 
CodecNotRegisteredForTypeException {
-TypeCodec codecForType = getTypeCodecForProtobufType(encodingTypeValue);
-return codecForType.encode(value);
+  public BasicTypes.EncodedValue encode(Object value) throws EncodingException 
{
+BasicTypes.EncodedValue.Builder builder = 
BasicTypes.EncodedValue.newBuilder();
+try {
+  ProtobufPrimitiveTypes protobufPrimitiveTypes =
+  ProtobufPrimitiveTypes.valueOf(value.getClass());
+  switch (protobufPrimitiveTypes) {
+case INT: {
+  builder.setIntResult((Integer) value);
+  break;
+}
+case LONG: {
+  builder.setLongResult((Long) value);
+  break;
+}
+case SHORT: {
+  builder.setShortResult((Short) value);
+  break;
+}
+case BYTE: {
+  builder.setByteResult((Byte) value);
+  break;
+}
+case DOUBLE: {
+  builder.setDoubleResult((Double) value);
+  break;
+}
+case FLOAT: {
+  builder.setFloatResult((Float) value);
+  break;
+}
+case BINARY: {
+  builder.setBinaryResult(ByteString.copyFrom((byte[]) value));
+  break;
+}
+case BOOLEAN: {
+  builder.setBooleanResult((Boolean) value);
+  break;
+}
+case STRING: {
+  builder.setStringResult((String) value);
+  break;
+}
+  }
+} catch (UnknownProtobufPrimitiveType unknownProtobufPrimitiveType) {
+  if (value instanceof PdxInstance) {
 
 Review comment:
   We shouldn't be throwing and catching exceptions for something which is a 
normal event - in this case handling a PDX value.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve JSON encoding for new protocol
> --
>
> Key: GEODE-4080
> URL: https://issues.apache.org/jira/browse/GEODE-4080
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> One of the encoding types in the new protobuf protocol is called 
> {{CustomEncodedValue}}. However, users aren't really free to encode their own 
> types. Also, packing JSON into a 

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

[Karen Smoler Miller (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295351#comment-16295351
 ] 

Karen Smoler Miller commented on GEODE-4079:


Reopening this ticket for updating the documentation.


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3799) Create plugin system for specifying where a backup is stored

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295352#comment-16295352
 ] 

ASF GitHub Bot commented on GEODE-3799:
---

kirklund opened a new pull request #1177: Revert "GEODE-3799: Move backups 
towards a pluggable architecture (#1…
URL: https://github.com/apache/geode/pull/1177
 
 
   …109)"
   
   The CI/CD pipeline is blocked due to lots of test failures caused by the 
commit for GEODE-3799. This commit reverts that commit until it can be 
reintroduced when GEODE-4106 is fixed.
   
   If GEODE-4106 is ready now then we could potentially commit that instead(?).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create plugin system for specifying where a backup is stored
> 
>
> Key: GEODE-3799
> URL: https://issues.apache.org/jira/browse/GEODE-3799
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.4.0
>
>
> The current logic merges the moving/copying of files with the determining of 
> what to backup. To make it possible to store a backup in cloud storage or 
> other locations, we need to separate these concerns, putting the variable, 
> location-based logic, into a plugin architecture.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-4079:
--

Assignee: Karen Smoler Miller

> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3991) Implement list jdbc-region-mapping command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295329#comment-16295329
 ] 

ASF GitHub Bot commented on GEODE-3991:
---

dgkimura closed pull request #166: GEODE-3991: Update callbacks to take region 
by reference
URL: https://github.com/apache/geode-native/pull/166
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/clicache/src/Region.cpp b/clicache/src/Region.cpp
index f4f58671..b498e62b 100644
--- a/clicache/src/Region.cpp
+++ b/clicache/src/Region.cpp
@@ -248,8 +248,8 @@ namespace Apache
   {
 return false;
   }
-  auto out1 = 
m_nativeptr->get_shared_ptr()->getCache().createDataOutput();
-  auto out2 = 
m_nativeptr->get_shared_ptr()->getCache().createDataOutput();
+  auto out1 = 
m_nativeptr->get_conditional_shared_ptr()->getCache().createDataOutput();
+  auto out2 = 
m_nativeptr->get_conditional_shared_ptr()->getCache().createDataOutput();
   val1->toData(*out1);
   val2->toData(*out2);
 
diff --git a/clicache/src/Region.hpp b/clicache/src/Region.hpp
index 072c5584..ec63a0df 100644
--- a/clicache/src/Region.hpp
+++ b/clicache/src/Region.hpp
@@ -26,7 +26,7 @@
 
 #include "IRegion.hpp"
 #include "ISubscriptionService.hpp"
-#include "native_shared_ptr.hpp"
+#include "native_conditional_shared_ptr.hpp"
 
 namespace Apache
 {
@@ -271,9 +271,16 @@ namespace Apache
 gcnew Region( nativeptr );
 }
 
+inline static IRegion^
+Create(native::Region* nativeptr)
+{
+  return __nullptr == nativeptr ? nullptr :
+gcnew Region(nativeptr);
+}
+
 std::shared_ptr GetNative()
 {
-  return m_nativeptr->get_shared_ptr();
+  return m_nativeptr->get_conditional_shared_ptr();
 }
 
 
@@ -283,8 +290,13 @@ namespace Apache
 /// 
 /// The native object pointer
 inline Region( std::shared_ptr nativeptr )
-   {
-  m_nativeptr = gcnew native_shared_ptr(nativeptr);
+{
+  m_nativeptr = gcnew 
native_conditional_shared_ptr(nativeptr);
+}
+
+inline Region(native::Region* nativeptr)
+{
+  m_nativeptr = gcnew 
native_conditional_shared_ptr(nativeptr);
 }
 
 inline std::shared_ptr 
get(std::shared_ptr& key, 
std::shared_ptr& callbackArg);
@@ -292,7 +304,7 @@ namespace Apache
 bool AreValuesEqual(std::shared_ptr& 
val1, std::shared_ptr& val2);
 bool isPoolInMultiuserMode();
 
-native_shared_ptr^ m_nativeptr;
+native_conditional_shared_ptr^ m_nativeptr;
 
   };
 
diff --git a/clicache/src/impl/CacheLoader.hpp 
b/clicache/src/impl/CacheLoader.hpp
index cc67a3e2..c7c1af73 100644
--- a/clicache/src/impl/CacheLoader.hpp
+++ b/clicache/src/impl/CacheLoader.hpp
@@ -41,10 +41,10 @@ namespace Apache
   public interface class ICacheLoaderProxy
   {
   public:
-std::shared_ptr load( const 
std::shared_ptr& region,
+std::shared_ptr 
load(apache::geode::client::Region& region,
   const std::shared_ptr& key, 
const std::shared_ptr& helper );
 
-void close( const std::shared_ptr& 
region );
+void close(apache::geode::client::Region& region );
   };
 
   generic
@@ -61,10 +61,10 @@ namespace Apache
 m_loader = loader;
   }
 
-  virtual std::shared_ptr load( 
const std::shared_ptr& region,
+  virtual std::shared_ptr load( 
apache::geode::client::Region& region,
 const std::shared_ptr& key, 
const std::shared_ptr& helper )
   {
-IRegion^ gregion = Region::Create(region);
+IRegion^ gregion = Region::Create();
 
 TKey gkey = Serializable::GetManagedValueGeneric(key);
 
@@ -73,9 +73,9 @@ namespace Apache
 return 
Serializable::GetUnmanagedValueGeneric(m_loader->Load(gregion, gkey, 
ghelper));
   }
 
-  virtual void close( const 
std::shared_ptr& region )
+  virtual void close(apache::geode::client::Region& region )
   {
-IRegion^ gregion = Region::Create(region);
+IRegion^ gregion = Region::Create();
 m_loader->Close(gregion);
   }
   };
diff --git a/clicache/src/impl/ManagedCacheLoader.cpp 
b/clicache/src/impl/ManagedCacheLoader.cpp
index 9d5ba28a..6b331825 100644
--- a/clicache/src/impl/ManagedCacheLoader.cpp
+++ b/clicache/src/impl/ManagedCacheLoader.cpp
@@ -213,7 

[jira] [Commented] (GEODE-3991) Implement list jdbc-region-mapping command

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295330#comment-16295330
 ] 

ASF subversion and git services commented on GEODE-3991:


Commit 5d5ee22f85cf7733f32f6b455d1b88e493f69f01 in geode-native's branch 
refs/heads/develop from [~dkimura]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5d5ee22 ]

GEODE-3991: Update callbacks to take region by reference (#166)



> Implement list jdbc-region-mapping command
> --
>
> Key: GEODE-3991
> URL: https://issues.apache.org/jira/browse/GEODE-3991
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, regions
>Reporter: Fred Krone
>Assignee: Lynn Gallinat
>
> NAME
> list jdbc-mapping
> SYNOPSIS
> List the all the JDBC stores for all regions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4110) Extend LocatorServerStartupRule to be able to start a client VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295258#comment-16295258
 ] 

ASF GitHub Bot commented on GEODE-4110:
---

jdeppe-pivotal commented on a change in pull request #1175: GEODE-4110: extend 
LocatorServerStartupRule to start a client VM.
URL: https://github.com/apache/geode/pull/1175#discussion_r157542250
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 ##
 @@ -308,30 +278,68 @@ public MemberVM startServerAsEmbededLocator(int index, 
Properties properties) th
   serverStarter.before();
   return serverStarter;
 });
-return setMember(index, new MemberVM(server, serverVM, 
useTempWorkingDir()));
+
+MemberVM memberVM = new MemberVM(server, serverVM, useTempWorkingDir());
+occupiedVMs.put(index, memberVM);
+return memberVM;
   }
 
   public void stopVM(int index) {
 stopVM(index, true);
   }
 
   public void stopVM(int index, boolean cleanWorkingDir) {
-MemberVM member = members.get(index);
-// user has started a server/locator in this VM
-if (member != null) {
-  member.stopMember(cleanWorkingDir);
-}
-// user may have used this VM as a client VM
-else {
-  getVM(index).invoke(() -> MemberStarterRule.disconnectDSIfAny());
+VMProvider member = occupiedVMs.get(index);
+
+if (member == null)
+  return;
+
+member.stopVM(cleanWorkingDir);
+  }
+
+  public ClientVM startClientVM(int index, String username, String password,
 
 Review comment:
   I don't really like this signature but I guess the only way around would be 
with a `withServerPort` style of builder. For now it's OK though until we get 
more usage patterns for client VMs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Extend LocatorServerStartupRule to be able to start a client VM
> ---
>
> Key: GEODE-4110
> URL: https://issues.apache.org/jira/browse/GEODE-4110
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>
> Now locatorServerStartupRule has startLocatorVM and has startServerVM, 
> sometimes we found ourselves in need of a startClientVM method as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2665) Add gfsh command to destroy async-event-queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295222#comment-16295222
 ] 

ASF GitHub Bot commented on GEODE-2665:
---

pdxrunner commented on a change in pull request #1116: GEODE-2665: Add Gfsh 
command to delete async event queues
URL: https://github.com/apache/geode/pull/1116#discussion_r157534615
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DestroyAsyncEventQueueFunctionTest.java
 ##
 @@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.functions;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.LinkedList;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.asyncqueue.AsyncEventQueue;
+import org.apache.geode.cache.asyncqueue.internal.AsyncEventQueueImpl;
+import org.apache.geode.cache.execute.FunctionContext;
+import org.apache.geode.cache.execute.ResultSender;
+import org.apache.geode.internal.cache.GemFireCacheImpl;
+import org.apache.geode.internal.cache.execute.FunctionContextImpl;
+import org.apache.geode.management.internal.configuration.domain.XmlEntity;
+import org.apache.geode.test.fake.Fakes;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+@Category(UnitTest.class)
+public class DestroyAsyncEventQueueFunctionTest {
+
+  private static final String TEST_AEQ_ID = "Test-AEQ";
+  private AsyncEventQueue mockAEQ;
+  private FunctionContext mockContext;
+  private DestroyAsyncEventQueueFunctionArgs mockArgs;
+  private GemFireCacheImpl cache;
+
+  @Before
+  public void setUp() throws Exception {
+mockAEQ = mock(AsyncEventQueueImpl.class);
+mockContext = mock(FunctionContext.class);
+mockArgs = mock(DestroyAsyncEventQueueFunctionArgs.class);
+cache = Fakes.cache();
+
+when(mockArgs.getId()).thenReturn(TEST_AEQ_ID);
+when(mockAEQ.getId()).thenReturn(TEST_AEQ_ID);
+  }
+
+  @Test
+  public void execute_validAeqId_OK() throws Throwable {
+XmlEntity xmlEntity = mock(XmlEntity.class);
+DestroyAsyncEventQueueFunction spyFunction = 
spy(DestroyAsyncEventQueueFunction.class);
+doReturn(xmlEntity).when(spyFunction).getAEQXmlEntity(anyString(), 
anyString());
+when(cache.getAsyncEventQueue(TEST_AEQ_ID)).thenReturn(mockAEQ);
+
+TestResultSender resultSender = new TestResultSender();
+FunctionContext context = new FunctionContextImpl(cache, "functionId", 
mockArgs, resultSender);
+spyFunction.execute(context);
+
+List results = resultSender.getResults();
+assertThat(results.size()).isEqualTo(1);
+CliFunctionResult result = (CliFunctionResult) results.get(0);
+assertThat(result.isSuccessful()).isTrue();
+assertThat(result.getXmlEntity()).isNotNull();
+assertThat(result.getThrowable()).isNull();
+  }
+
+  @Test
+  public void execute_nonexistentAeqId_returnsError() throws Throwable {
+when(cache.getAsyncEventQueue(TEST_AEQ_ID)).thenReturn(null);
+
+TestResultSender resultSender = new TestResultSender();
+
+FunctionContext context = new FunctionContextImpl(cache, "functionId", 
mockArgs, resultSender);
+new DestroyAsyncEventQueueFunction().execute(context);
+List results = resultSender.getResults();
+assertThat(results.size()).isEqualTo(1);
+CliFunctionResult result = (CliFunctionResult) results.get(0);
+assertThat(result.isSuccessful()).isFalse();
+assertThat(result.getMessage()).containsPattern(TEST_AEQ_ID + ".*not 
found");
+  }
+
+  @Test
+  public void execute_nonexistentAeqIdIfExists_returnsSuccess() throws 
Throwable {
+when(cache.getAsyncEventQueue(TEST_AEQ_ID)).thenReturn(null);
+when(mockArgs.isIfExists()).thenReturn(true);
+
+TestResultSender resultSender = new TestResultSender();
+
+ 

[jira] [Commented] (GEODE-2665) Add gfsh command to destroy async-event-queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295223#comment-16295223
 ] 

ASF GitHub Bot commented on GEODE-2665:
---

pdxrunner commented on a change in pull request #1116: GEODE-2665: Add Gfsh 
command to delete async event queues
URL: https://github.com/apache/geode/pull/1116#discussion_r157534671
 
 

 ##
 File path: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DestroyAsyncEventQueueCommandDUnitTest.java
 ##
 @@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import java.io.IOException;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.internal.cache.wan.MyAsyncEventListener;
+import org.apache.geode.management.internal.cli.json.GfJsonException;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+
+@Category(DistributedTest.class)
+public class DestroyAsyncEventQueueCommandDUnitTest {
+
+  private static MemberVM locator, server1, server2, server3;
+
+  @Rule
+  public LocatorServerStartupRule lsRule = new LocatorServerStartupRule();
+
+  @Rule
+  public GfshCommandRule gfsh = new GfshCommandRule();
+
+  @Before
+  public void setUp() throws Exception {
+locator = lsRule.startLocatorVM(0);
+server1 = lsRule.startServerVM(1, "group1", locator.getPort());
+server2 = lsRule.startServerVM(2, locator.getPort());
+gfsh.connectAndVerify(locator);
+  }
+
+  @Test
+  public void destroyAeq_returnsSuccess() {
+gfsh.executeAndAssertThat(
+"create async-event-queue --id=queue1 --listener=" + 
MyAsyncEventListener.class.getName())
+.statusIsSuccess();
+
 
 Review comment:
   Good catch! Adding this check to the existing tests showed that the Function 
implementation was not returning the correct XmlEntity, so that was corrected 
as well. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add gfsh command to destroy async-event-queue
> -
>
> Key: GEODE-2665
> URL: https://issues.apache.org/jira/browse/GEODE-2665
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Kenneth Howe
> Fix For: 1.4.0
>
>
> Currently, there is only an {{create async-event-queue}} command in gfsh, we 
> need the corresponding {{destroy async-event-queue}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-2665) Add gfsh command to destroy async-event-queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295201#comment-16295201
 ] 

ASF GitHub Bot commented on GEODE-2665:
---

pdxrunner commented on a change in pull request #1116: GEODE-2665: Add Gfsh 
command to delete async event queues
URL: https://github.com/apache/geode/pull/1116#discussion_r157532234
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DestroyAsyncEventQueueCommand.java
 ##
 @@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.management.internal.cli.i18n.CliStrings.IFEXISTS;
+import static 
org.apache.geode.management.internal.cli.i18n.CliStrings.IFEXISTS_HELP;
+
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.management.cli.ConverterHint;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.functions.CliFunctionResult;
+import 
org.apache.geode.management.internal.cli.functions.DestroyAsyncEventQueueFunction;
+import 
org.apache.geode.management.internal.cli.functions.DestroyAsyncEventQueueFunctionArgs;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+import org.apache.geode.management.internal.configuration.domain.XmlEntity;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission;
+
+public class DestroyAsyncEventQueueCommand implements GfshCommand {
+  public static final String DESTROY_ASYNC_EVENT_QUEUE = "destroy 
async-event-queue";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__HELP = "destroy an 
Async Event Queue";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__ID = "id";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__ID__HELP =
+  "ID of the queue to be destroyed.";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__GROUP__HELP =
+  "Group(s) of members on which to destroy the async event queue.";
+
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_NOT_FOUND =
+  "Async event queue \"%s\" not found";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_DESTROYED =
+  "Async event queue \"%s\" destroyed";
+
+  @CliCommand(value = DESTROY_ASYNC_EVENT_QUEUE, help = 
DESTROY_ASYNC_EVENT_QUEUE__HELP)
+  @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
+  operation = ResourcePermission.Operation.MANAGE)
+  public Result destroyAsyncEventQueue(
+  @CliOption(key = DESTROY_ASYNC_EVENT_QUEUE__ID, mandatory = true,
+  help = DESTROY_ASYNC_EVENT_QUEUE__ID__HELP) String aeqId,
+  @CliOption(key = {CliStrings.GROUP, CliStrings.GROUPS},
+  optionContext = ConverterHint.MEMBERGROUP,
+  help = DESTROY_ASYNC_EVENT_QUEUE__GROUP__HELP) String[] onGroups,
+  @CliOption(key = IFEXISTS, help = IFEXISTS_HELP, specifiedDefaultValue = 
"true",
+  unspecifiedDefaultValue = "false") boolean ifExists)
+  throws Throwable {
+DestroyAsyncEventQueueFunctionArgs asyncEventQueueDestoryFunctionArgs =
+new DestroyAsyncEventQueueFunctionArgs(aeqId, ifExists);
+
+Set members = getMembers(onGroups, null);
 
 Review comment:
   Good catch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add gfsh command to destroy async-event-queue
> -
>

[jira] [Commented] (GEODE-2665) Add gfsh command to destroy async-event-queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295200#comment-16295200
 ] 

ASF GitHub Bot commented on GEODE-2665:
---

pdxrunner commented on a change in pull request #1116: GEODE-2665: Add Gfsh 
command to delete async event queues
URL: https://github.com/apache/geode/pull/1116#discussion_r157532093
 
 

 ##
 File path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DestroyAsyncEventQueueCommand.java
 ##
 @@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.management.internal.cli.i18n.CliStrings.IFEXISTS;
+import static 
org.apache.geode.management.internal.cli.i18n.CliStrings.IFEXISTS_HELP;
+
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.management.cli.ConverterHint;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.functions.CliFunctionResult;
+import 
org.apache.geode.management.internal.cli.functions.DestroyAsyncEventQueueFunction;
+import 
org.apache.geode.management.internal.cli.functions.DestroyAsyncEventQueueFunctionArgs;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+import org.apache.geode.management.internal.configuration.domain.XmlEntity;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission;
+
+public class DestroyAsyncEventQueueCommand implements GfshCommand {
+  public static final String DESTROY_ASYNC_EVENT_QUEUE = "destroy 
async-event-queue";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__HELP = "destroy an 
Async Event Queue";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__ID = "id";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__ID__HELP =
+  "ID of the queue to be destroyed.";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__GROUP__HELP =
+  "Group(s) of members on which to destroy the async event queue.";
+
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_NOT_FOUND =
+  "Async event queue \"%s\" not found";
+  public static final String DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_DESTROYED =
+  "Async event queue \"%s\" destroyed";
+
+  @CliCommand(value = DESTROY_ASYNC_EVENT_QUEUE, help = 
DESTROY_ASYNC_EVENT_QUEUE__HELP)
+  @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
+  operation = ResourcePermission.Operation.MANAGE)
+  public Result destroyAsyncEventQueue(
+  @CliOption(key = DESTROY_ASYNC_EVENT_QUEUE__ID, mandatory = true,
+  help = DESTROY_ASYNC_EVENT_QUEUE__ID__HELP) String aeqId,
+  @CliOption(key = {CliStrings.GROUP, CliStrings.GROUPS},
+  optionContext = ConverterHint.MEMBERGROUP,
+  help = DESTROY_ASYNC_EVENT_QUEUE__GROUP__HELP) String[] onGroups,
+  @CliOption(key = IFEXISTS, help = IFEXISTS_HELP, specifiedDefaultValue = 
"true",
+  unspecifiedDefaultValue = "false") boolean ifExists)
+  throws Throwable {
+DestroyAsyncEventQueueFunctionArgs asyncEventQueueDestoryFunctionArgs =
+new DestroyAsyncEventQueueFunctionArgs(aeqId, ifExists);
+
+Set members = getMembers(onGroups, null);
+if (members.size() == 0) {
+  String message = 
String.format(DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_NOT_FOUND, aeqId);
 
 Review comment:
   Good point. However in light of Jinmei's comment, I'm removing this 
conditional.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific