[jira] [Updated] (GEODE-4449) Replace macro-templates with plain templates to allow better debugging
[ https://issues.apache.org/jira/browse/GEODE-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4449: -- Labels: pull-request-available (was: ) > Replace macro-templates with plain templates to allow better debugging > -- > > Key: GEODE-4449 > URL: https://issues.apache.org/jira/browse/GEODE-4449 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: David Kimura >Priority: Major > Labels: pull-request-available > > Replace macro-templates in CacheableBuiltins.hpp from... > _GEODE_CACHEABLE_ARRAY_TYPE_(int8_t, CacheableBytes); > _GEODE_CACHEABLE_ARRAY_TYPE_(std::shared_ptr, > CacheableStringArray); > into... > using CacheableBytes = CacheableArray; > using CacheableStringArray = CacheableArray, > GeodeTypeIds::CacheableStringArray>; > It also makes the code debuggable since most debuggers can step through > templates, but not macros. It also removes an unnecessary level of > indirection by the preprocessor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359754#comment-16359754 ] ASF subversion and git services commented on GEODE-3967: Commit 08755b7f10539ee96ed0b24eefc88ae4a534406a in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=08755b7 ] GEODE-3967: There're following 6 problems fixed here: 1) When ConcurrentCacheModificationException happened, GatewaySenderEventImpl should save the status and notify gatewaysender if it hold primary queue, because other member might have put the event into the secondary queue. 2) In AbstractUpdateOperation's doPutOrCreate's 3 tries of basicUpdate, the 3rd try should allow both create and update. 3) Let event with CME not to dispatch. The old logic does not allow CME event to enqueue. This is wrong, because an event without CME might have been added into the secondary queue. So we should enqueue it, but not to dispatch. 4) Let UPDATE_VERSION_STAMP not to enqueue if not primary queue, because the event did not fire in pair. 5) AbstractGatewaySenderEventProcessor put loop of filter in wrong place, which caused UPDATE_VERSION_STAMP and CME events are not ignored. 6) shouldSendVersionEvents for Remote sender should return true, since we no longer support 7.0.1 any more. > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4615) Deadlock shutting down client cache
[
https://issues.apache.org/jira/browse/GEODE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359750#comment-16359750
]
ASF subversion and git services commented on GEODE-4615:
Commit cb82c21f22fc8a56958f4091fed5d90dc055190e in geode's branch
refs/heads/feature/GEODE-3967 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=cb82c21 ]
GEODE-4615 Deadlock shutting down client cache
Disallow adding a new connection to the ConnectionMap when it is being
closed.
This revision replaces the connection map's connection list with a
poisoned list under sync and then closes each connection outside
of the connection map's lock. This removes the lock inversion since
the closing thread no longer holds the map's lock. The thread adding
a connection will either see closing==true or it will try to add
the connection to the poisoned list. Either results in it
throwing a CacheClosedException.
> Deadlock shutting down client cache
> ---
>
> Key: GEODE-4615
> URL: https://issues.apache.org/jira/browse/GEODE-4615
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Affects Versions: 1.1.0
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> A test became deadlocked when a thread executing a query was requesting a PDX
> type ID from its server at the same time another thread was closing the
> cache. I wrote a unit test to reproduce this problem. Here is the deadlock:
>
> {noformat}
> "ConnectionManagerJUnitTest thread":
> at
> org.apache.geode.cache.client.internal.pooling.PooledConnection.internalDestroy(PooledConnection.java:76)
> - waiting to lock <0x00076bbc3d20> (a
> org.apache.geode.cache.client.internal.pooling.PooledConnection)
> at
> org.apache.geode.cache.client.internal.pooling.PooledConnection.internalClose(PooledConnection.java:101)
> at
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$ConnectionMap.close(ConnectionManagerImpl.java:1164)
> - locked <0x00076b848f30> (a
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$ConnectionMap)
> at
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerJUnitTest$3.run(ConnectionManagerJUnitTest.java:613)
> "main":
> at
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$ConnectionMap.addConnection(ConnectionManagerImpl.java:1059)
> - waiting to lock <0x00076b848f30> (a
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$ConnectionMap)
> at
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.addConnection(ConnectionManagerImpl.java:463)
> at
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.borrowConnection(ConnectionManagerImpl.java:245)
> at
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerJUnitTest.testThatMapCloseCausesCacheClosedException(ConnectionManagerJUnitTest.java:631)
> - locked <0x00076bbc3d20> (a
> org.apache.geode.cache.client.internal.pooling.PooledConnection)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4Ide
[jira] [Commented] (GEODE-4636) Spotless should not adjust block comments
[ https://issues.apache.org/jira/browse/GEODE-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359748#comment-16359748 ] ASF subversion and git services commented on GEODE-4636: Commit 3114c21dfd0271528fe8e4998a7be3d1b0962a17 in geode's branch refs/heads/feature/GEODE-3967 from [~prhomberg] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3114c21 ] GEODE-4636: Update Style XML to allow human-readable spacing in comments (#1415) * Sort style xml but change no values. * Set join_lines_in_comments from false to true. > Spotless should not adjust block comments > - > > Key: GEODE-4636 > URL: https://issues.apache.org/jira/browse/GEODE-4636 > Project: Geode > Issue Type: Improvement >Reporter: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-2667) Need API to destroy gateway receiver
[
https://issues.apache.org/jira/browse/GEODE-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359753#comment-16359753
]
ASF subversion and git services commented on GEODE-2667:
Commit 4a9e6518f2a3811941a48a95d398557bd2bf2f97 in geode's branch
refs/heads/feature/GEODE-3967 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4a9e651 ]
GEODE-2667: Add API to destroy GatewayReceiver (#1410)
* Added API to destroy a cache server
* Added new RemoveCacheServerProfileMessage
* The hasCacheServer flag in the profile is set to false if size of cache
servers is 0
* Destroying GatewayReceiver will remove the jmx bean and proxy bean
> Need API to destroy gateway receiver
> -
>
> Key: GEODE-2667
> URL: https://issues.apache.org/jira/browse/GEODE-2667
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Swapnil Bawaskar
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A {{GatewayReceiver}} can be created from {{GatewayReceiverFactory}},
> however, there is no API for destroying the {{GatewayReceiver}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4642) PowerMock any() arguments in tests can fail intermittently
[
https://issues.apache.org/jira/browse/GEODE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359749#comment-16359749
]
ASF subversion and git services commented on GEODE-4642:
Commit 03b7c1444090d45df54acba548efd827ba31151b in geode's branch
refs/heads/feature/GEODE-3967 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=03b7c14 ]
GEODE-4642: Remove PowerMock any() method calls from non-mock invocations.
> PowerMock any() arguments in tests can fail intermittently
> --
>
> Key: GEODE-4642
> URL: https://issues.apache.org/jira/browse/GEODE-4642
> Project: Geode
> Issue Type: Bug
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> See the Travis failure of PR #1415:
> https://travis-ci.org/apache/geode/builds/339119584?utm_source=github_status&utm_medium=notification
> {noformat}
> :geode-core:testPicked up _JAVA_OPTIONS: -Xmx1024m -Xms512m
> org.apache.geode.cache.query.internal.types.TypeUtilsJUnitTest >
> getRegionEntryTypeShouldReturnTheProperTypeImplementation FAILED
> org.mockito.exceptions.misusing.InvalidUseOfMatchersException:
> Misplaced or misused argument matcher detected here:
> -> at
> org.apache.geode.cache.query.internal.types.TypeUtilsJUnitTest.lambda$booleanCompareShouldThrowExceptionIfValuesAreNotInstancesOfBoolean$7(TypeUtilsJUnitTest.java:441)
> -> at
> org.apache.geode.cache.query.internal.types.TypeUtilsJUnitTest.lambda$booleanCompareShouldThrowExceptionIfValuesAreNotInstancesOfBoolean$8(TypeUtilsJUnitTest.java:444)
> -> at
> org.apache.geode.cache.query.internal.types.TypeUtilsJUnitTest.lambda$booleanCompareShouldThrowExceptionIfValuesAreNotInstancesOfBoolean$9(TypeUtilsJUnitTest.java:447)
> You cannot use argument matchers outside of verification or stubbing.
> Examples of correct usage of argument matchers:
> when(mock.get(anyInt())).thenReturn(null);
> doThrow(new
> RuntimeException()).when(mock).someVoidMethod(anyObject());
> verify(mock).someMethod(contains("foo"))
> This message may appear after an NullPointerException if the last matcher
> is returning an object
> like any() but the stubbed method signature expect a primitive argument,
> in this case,
> use primitive alternatives.
> when(mock.get(any())); // bad use, will raise NPE
> when(mock.get(anyInt())); // correct usage use
> Also, this error might show up because you use argument matchers with
> methods that cannot be mocked.
> Following methods *cannot* be stubbed/verified:
> final/private/equals()/hashCode().
> Mocking methods declared on non-public parent classes is not supported.
> at
> org.apache.geode.cache.query.internal.types.TypeUtilsJUnitTest.getRegionEntryTypeShouldReturnTheProperTypeImplementation(TypeUtilsJUnitTest.java:429)
> 4020 tests completed, 1 failed, 8 skipped
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4613) Gfsh's prints out error message after shutdown --include-locators
[ https://issues.apache.org/jira/browse/GEODE-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359751#comment-16359751 ] ASF subversion and git services commented on GEODE-4613: Commit 024110c7cec2b91d1f82c9ab6ea327fb273d in geode's branch refs/heads/feature/GEODE-3967 from [~jinmeiliao] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=024110c ] GEODE-4613: always redirect jdk loggers to file no matter what mode Gfsh is in. (#1424) > Gfsh's prints out error message after shutdown --include-locators > - > > Key: GEODE-4613 > URL: https://issues.apache.org/jira/browse/GEODE-4613 > Project: Geode > Issue Type: Bug > Components: gfsh >Affects Versions: 1.4.0 >Reporter: Jinmei Liao >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Steps to reproduce: > gfsh>start locator --name=locator > gfsh>start server --name=server > gfsh>shutdown --include-locators > As a lot of data in memory will be lost, including possibly events in queues, > do you really want to shutdown the entire distributed system? (Y/n): y > Shutdown is triggered > Failed to restart: java.io.IOException: Failed to get a RMI stub: > javax.naming.CommunicationException [Root exception is > java.rmi.NoSuchObjectException: no such object in table] > gfsh> > No longer connected to 10.118.33.243[1099]. > Failed to call the method close():java.rmi.ConnectException: Connection > refused to host: 127.0.0.1; nested exception is: > java.net.ConnectException: Connection refused (Connection refused) > Failed to check connection: java.rmi.NoSuchObjectException: no such object in > table > stopping > Error In gfsh.log: > [severe 2018/02/06 13:53:33.931 PST JMX client heartbeat 2 tid=0x2d] > (msgTID=45 msgSN=11) No longer connected to 10.118.33.243[1099]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359752#comment-16359752
]
ASF subversion and git services commented on GEODE-3813:
Commit 66dbc8eb8d8fca7b55aed80322970400ee5f3627 in geode's branch
refs/heads/feature/GEODE-3967 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=66dbc8e ]
GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior (#1376)
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3967) if put hits concurrent modification exception should still notify serial gateway sender
[ https://issues.apache.org/jira/browse/GEODE-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359755#comment-16359755 ] ASF subversion and git services commented on GEODE-3967: Commit 7d47d2a4cd19fe4a69a3a471a1ac7458466c9fd7 in geode's branch refs/heads/feature/GEODE-3967 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d47d2a ] GEODE-3967: change version to 150 > if put hits concurrent modification exception should still notify serial > gateway sender > --- > > Key: GEODE-3967 > URL: https://issues.apache.org/jira/browse/GEODE-3967 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: xiaojian zhou >Assignee: xiaojian zhou >Priority: Major > Labels: pull-request-available > > In serial gateway sender, the event arrives at secondary will be put into > unprocessedMap and wait for event from primary queue to distribute over, then > remove it from the unprocessedMap. > If the put at primary member (member with primary queue) failed with CME, the > event in unprocessedMap will never be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
