[jira] [Closed] (GEODE-9464) Add a non-Steeltoe Asp.Net Core SessionState sample app to SessionStateCore
[ https://issues.apache.org/jira/browse/GEODE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9464. -- > Add a non-Steeltoe Asp.Net Core SessionState sample app to SessionStateCore > --- > > Key: GEODE-9464 > URL: https://issues.apache.org/jira/browse/GEODE-9464 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The current Asp.Net sample app uses Steeltoe for discovery and registration > of our sessionstate provider. We need a non-Steeltoe sample as well, since > not everyone uses Steeltoe. > This will be a good test of our NuGet access to the SessionState Core > artifacts and its dependencies. > Note: Ensure that the web application runs on all platforms. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9511) Allow Default WindowsSDK in ACE cmake build
[
https://issues.apache.org/jira/browse/GEODE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell closed GEODE-9511.
--
> Allow Default WindowsSDK in ACE cmake build
> ---
>
> Key: GEODE-9511
> URL: https://issues.apache.org/jira/browse/GEODE-9511
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Labels: pull-request-available
>
> The cmake configuration file for ACE currently uses the CMAKE_SYSTEM_VERSION
> variable to set the WindowsTargetPlatformVersion for ACE's build system
> (called MPC):
> set ( _CONFIGURE_COMMAND ${MPC} -static ${MPC_FLAGS}
> -name_modifier "*_${MPC_TYPE}_static"
> -value_template MultiProcessorCompilation=true
> -value_template WindowsTargetPlatformVersion=${CMAKE_SYSTEM_VERSION} set (
> _CONFIGURE_COMMAND ${MPC} -static ${MPC_FLAGS}
> -name_modifier "*_${MPC_TYPE}_static"
> -value_template MultiProcessorCompilation=true
> -value_template WindowsTargetPlatformVersion=${CMAKE_SYSTEM_VERSION}
>
> This requires the user to pass in a proper value for CMAKE_SYSTEM_VERSION on
> the cmake config line:
> cmake -DCMAKE_SYSTEM_VERSION=10.0.19041.0
> due to an apparent error in the default value of this variable which leaves
> off the last part (i.e., .0 above).
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9631) Create test for credential re-auth
[ https://issues.apache.org/jira/browse/GEODE-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-9631. Resolution: Fixed > Create test for credential re-auth > -- > > Key: GEODE-9631 > URL: https://issues.apache.org/jira/browse/GEODE-9631 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Ernest Burghardt >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > Geode now has the ability to re-auth client connections (see > [RFC|[https://cwiki.apache.org/confluence/display/GEODE/On+Demand+Geode+Authentication+Expiration+and+Re-authentication])] > Test should cover estblishing authenticated connection to a geode cluster, > performing cluster operations, requesting re-auth and ensuring cluster > operations work after re-auth. > Considerations for Durable and non-Durable clients should also be addressed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9631) Create test for credential re-auth
[ https://issues.apache.org/jira/browse/GEODE-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9631. -- > Create test for credential re-auth > -- > > Key: GEODE-9631 > URL: https://issues.apache.org/jira/browse/GEODE-9631 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Ernest Burghardt >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > Geode now has the ability to re-auth client connections (see > [RFC|[https://cwiki.apache.org/confluence/display/GEODE/On+Demand+Geode+Authentication+Expiration+and+Re-authentication])] > Test should cover estblishing authenticated connection to a geode cluster, > performing cluster operations, requesting re-auth and ensuring cluster > operations work after re-auth. > Considerations for Durable and non-Durable clients should also be addressed. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9600) Add Programmatic Cluster Support to NetCore.Test
[ https://issues.apache.org/jira/browse/GEODE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-9600. Resolution: Fixed > Add Programmatic Cluster Support to NetCore.Test > > > Key: GEODE-9600 > URL: https://issues.apache.org/jira/browse/GEODE-9600 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > We just need to bring a few files over from the new clicache test framework > (clicache/integration-test2): > * Cluster.cs > * Gfsh.cs > * GfshExecute.cs -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9600) Add Programmatic Cluster Support to NetCore.Test
[ https://issues.apache.org/jira/browse/GEODE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9600. -- > Add Programmatic Cluster Support to NetCore.Test > > > Key: GEODE-9600 > URL: https://issues.apache.org/jira/browse/GEODE-9600 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > We just need to bring a few files over from the new clicache test framework > (clicache/integration-test2): > * Cluster.cs > * Gfsh.cs > * GfshExecute.cs -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-9719. Resolution: Fixed > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9741) Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline
[ https://issues.apache.org/jira/browse/GEODE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-9741. Assignee: Michael Martell Resolution: Fixed > Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline > - > > Key: GEODE-9741 > URL: https://issues.apache.org/jira/browse/GEODE-9741 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > Currently the VS 2019 builds use the old toolchain (v141). All tests pass > with v142, so just requires a small change to CI code, as well as adding the > v142 tools to the Windows images. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-9754) Test C++20 apps with VS 2019 toolchain build of geode-native
[ https://issues.apache.org/jira/browse/GEODE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell reassigned GEODE-9754: -- Assignee: Michael Martell > Test C++20 apps with VS 2019 toolchain build of geode-native > > > Key: GEODE-9754 > URL: https://issues.apache.org/jira/browse/GEODE-9754 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > > This is to ensure that C++20 applications can link and run against our latest > geode-native build that uses the v142 toolchain. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9719) Switch .NET Core Tests to Xunit Fixtures
[ https://issues.apache.org/jira/browse/GEODE-9719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9719. -- Assignee: Michael Martell > Switch .NET Core Tests to Xunit Fixtures > > > Key: GEODE-9719 > URL: https://issues.apache.org/jira/browse/GEODE-9719 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > The programmatic cluster support brought in by > [GEODE-9600|http://example.com] currently starts and stops the geode cluster > for each test. This ticket is to switch the tests to an Xunit fixture model > wherein all tests for netcore-lib will be run against a single cluster > start/stop, and similarly for netcore-session. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9741) Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline
[ https://issues.apache.org/jira/browse/GEODE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9741. -- > Add Latest Toolchain (v142) to Visual Studio 2019 CI Pipeline > - > > Key: GEODE-9741 > URL: https://issues.apache.org/jira/browse/GEODE-9741 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > Labels: pull-request-available > > Currently the VS 2019 builds use the old toolchain (v141). All tests pass > with v142, so just requires a small change to CI code, as well as adding the > v142 tools to the Windows images. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9754) Test C++20 apps with VS 2019 toolchain build of geode-native
[ https://issues.apache.org/jira/browse/GEODE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9754. -- > Test C++20 apps with VS 2019 toolchain build of geode-native > > > Key: GEODE-9754 > URL: https://issues.apache.org/jira/browse/GEODE-9754 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > > This is to ensure that C++20 applications can link and run against our latest > geode-native build that uses the v142 toolchain. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9754) Test C++20 apps with VS 2019 toolchain build of geode-native
[ https://issues.apache.org/jira/browse/GEODE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-9754. Resolution: Fixed > Test C++20 apps with VS 2019 toolchain build of geode-native > > > Key: GEODE-9754 > URL: https://issues.apache.org/jira/browse/GEODE-9754 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > > This is to ensure that C++20 applications can link and run against our latest > geode-native build that uses the v142 toolchain. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-9848) Duplicate and Unnecessary REGISTER_INTEREST Message Sent to Server
Michael Martell created GEODE-9848: -- Summary: Duplicate and Unnecessary REGISTER_INTEREST Message Sent to Server Key: GEODE-9848 URL: https://issues.apache.org/jira/browse/GEODE-9848 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell In the course of debugging a RegisterAllKeys bug (GEMNC-508), it was discovered that a second REGISTER_INTEREST message is being sent to the same server. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9848) Duplicate and Unnecessary REGISTER_INTEREST Message Sent to Server
[ https://issues.apache.org/jira/browse/GEODE-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450731#comment-17450731 ] Michael Martell commented on GEODE-9848: With the fix, registerAllKeys(false, true) is twice as fast as shown below. These are the results of running the RegisterInterestBM, registerInterestAllKeysInitialValues) benchmark with .5 million and 1 million keys. Elapsed Time (seconds) Number of Keys With Fix Without Fix == = 50 11.7 22.8 10023.2 44.8 > Duplicate and Unnecessary REGISTER_INTEREST Message Sent to Server > -- > > Key: GEODE-9848 > URL: https://issues.apache.org/jira/browse/GEODE-9848 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > > In the course of debugging a RegisterAllKeys bug (GEMNC-508), it was > discovered that a second REGISTER_INTEREST message is being sent to the same > server. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (GEODE-9848) Duplicate and Unnecessary REGISTER_INTEREST Message Sent to Server
[ https://issues.apache.org/jira/browse/GEODE-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450731#comment-17450731 ] Michael Martell edited comment on GEODE-9848 at 11/29/21, 10:46 PM: With the fix, registerAllKeys(false, true) is twice as fast as shown below. These are the results of running the RegisterInterestBM, registerInterestAllKeysInitialValues) benchmark with .5 million and 1 million keys. Elapsed Time (seconds) Number of Keys With Fix Without Fix == = 50 11.7 22.8 100 23.2 44.8 was (Author: mmartell): With the fix, registerAllKeys(false, true) is twice as fast as shown below. These are the results of running the RegisterInterestBM, registerInterestAllKeysInitialValues) benchmark with .5 million and 1 million keys. Elapsed Time (seconds) Number of Keys With Fix Without Fix == = 50 11.7 22.8 10023.2 44.8 > Duplicate and Unnecessary REGISTER_INTEREST Message Sent to Server > -- > > Key: GEODE-9848 > URL: https://issues.apache.org/jira/browse/GEODE-9848 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > > In the course of debugging a RegisterAllKeys bug (GEMNC-508), it was > discovered that a second REGISTER_INTEREST message is being sent to the same > server. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9688) .Net core builds should be x64
[ https://issues.apache.org/jira/browse/GEODE-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-9688. Resolution: Fixed > .Net core builds should be x64 > -- > > Key: GEODE-9688 > URL: https://issues.apache.org/jira/browse/GEODE-9688 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: needsTriage, pull-request-available > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-9688) .Net core builds should be x64
[ https://issues.apache.org/jira/browse/GEODE-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-9688. -- .NET Core builds are now strictly 64 bits. > .Net core builds should be x64 > -- > > Key: GEODE-9688 > URL: https://issues.apache.org/jira/browse/GEODE-9688 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Ernest Burghardt >Priority: Major > Labels: needsTriage, pull-request-available > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-9886) Remove(key) needs to return bool
Michael Martell created GEODE-9886: -- Summary: Remove(key) needs to return bool Key: GEODE-9886 URL: https://issues.apache.org/jira/browse/GEODE-9886 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell The Remove(key) API in c-bindings needs to return a bool. Currently it returns void. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10014) Add support for building nativeclient against older geode releases
Michael Martell created GEODE-10014: --- Summary: Add support for building nativeclient against older geode releases Key: GEODE-10014 URL: https://issues.apache.org/jira/browse/GEODE-10014 Project: Geode Issue Type: Task Components: native client Reporter: Michael Martell Currently, the nativeclient's java test module (javaobject.jar) depends on a very recent version of geode (1.15.0-build.546 or higher). This ticket is to add support for building this jar file against older versions of geode which do not contain the new AuthenticationExpiredException. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-8954) Use a GEODE_VERSION variable for the CI
[ https://issues.apache.org/jira/browse/GEODE-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-8954: --- Priority: Minor (was: Major) > Use a GEODE_VERSION variable for the CI > > > Key: GEODE-8954 > URL: https://issues.apache.org/jira/browse/GEODE-8954 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > > Several CI related files have GEODE_VERSION hardcodes. This includes > .lgtm.yml, serveral Dockerfiles and Packer files. This ticket is to create a > variable that can be utilized and passed in as opposed to hardcoding in a > bunch of files. > Setting the variable and passing in to *_docker build_* as an argument seems > prudent. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10016) Use Thread Name In Log Messages
Michael Martell created GEODE-10016: --- Summary: Use Thread Name In Log Messages Key: GEODE-10016 URL: https://issues.apache.org/jira/browse/GEODE-10016 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell The native client logging system currently prints the threadId in all log messages. Since all internally created native client threads are named, we should print the threadName instead of threadId. Note: Lots of log messages are running on an application thread which was not created internally by the native client. Messages running on these threads should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10016) Use Thread Name In Log Messages
[ https://issues.apache.org/jira/browse/GEODE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10016: Description: The native client logging system currently prints the threadId in all log messages. Since all internally created native client threads are named, we should print the threadName instead of threadId. This will be extremely helpful to understanding the flow of messages since there are many background threads in the native client. Note: Lots of log messages are running on an application thread which was not created internally by the native client. Messages running on these threads should continue to print the threadId. was: The native client logging system currently prints the threadId in all log messages. Since all internally created native client threads are named, we should print the threadName instead of threadId. Note: Lots of log messages are running on an application thread which was not created internally by the native client. Messages running on these threads should continue to print the threadId. Priority: Minor (was: Major) > Use Thread Name In Log Messages > --- > > Key: GEODE-10016 > URL: https://issues.apache.org/jira/browse/GEODE-10016 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Minor > > The native client logging system currently prints the threadId in all log > messages. Since all internally created native client threads are named, we > should print the threadName instead of threadId. This will be extremely > helpful to understanding the flow of messages since there are many background > threads in the native client. > Note: Lots of log messages are running on an application thread which was not > created internally by the native client. Messages running on these threads > should continue to print the threadId. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10040) Fix intermittent clicache test failures
Michael Martell created GEODE-10040: --- Summary: Fix intermittent clicache test failures Key: GEODE-10040 URL: https://issues.apache.org/jira/browse/GEODE-10040 Project: Geode Issue Type: Test Components: native client Reporter: Michael Martell Occassionaly we see timeouts in the CI when running the legacy clicache tests. These appear to mostly be timeouts waiting for gfsh commands to complete. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10058) Remove Defunct NetCore from geode-native repo and CI
Michael Martell created GEODE-10058: --- Summary: Remove Defunct NetCore from geode-native repo and CI Key: GEODE-10058 URL: https://issues.apache.org/jira/browse/GEODE-10058 Project: Geode Issue Type: Task Reporter: Michael Martell This project is being replaced by a pure C# client for .NET Core. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10058) Remove Defunct NetCore and C-Bindiings from geode-native repo and CI
[ https://issues.apache.org/jira/browse/GEODE-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10058: Summary: Remove Defunct NetCore and C-Bindiings from geode-native repo and CI (was: Remove Defunct NetCore from geode-native repo and CI) > Remove Defunct NetCore and C-Bindiings from geode-native repo and CI > > > Key: GEODE-10058 > URL: https://issues.apache.org/jira/browse/GEODE-10058 > Project: Geode > Issue Type: Task >Reporter: Michael Martell >Priority: Major > > This project is being replaced by a pure C# client for .NET Core. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10058) Remove Defunct NetCore and C-Bindiings from geode-native repo and CI
[ https://issues.apache.org/jira/browse/GEODE-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10058: Description: This project is being replaced by a pure C# client for .NET Core. Also, move the SessionState code to a new branch since it's not throw away code. was:This project is being replaced by a pure C# client for .NET Core. > Remove Defunct NetCore and C-Bindiings from geode-native repo and CI > > > Key: GEODE-10058 > URL: https://issues.apache.org/jira/browse/GEODE-10058 > Project: Geode > Issue Type: Task >Reporter: Michael Martell >Priority: Major > > This project is being replaced by a pure C# client for .NET Core. > Also, move the SessionState code to a new branch since it's not throw away > code. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10065) Fix regexp in gnmsg for handshake messages
Michael Martell created GEODE-10065: --- Summary: Fix regexp in gnmsg for handshake messages Key: GEODE-10065 URL: https://issues.apache.org/jira/browse/GEODE-10065 Project: Geode Issue Type: Bug Reporter: Michael Martell gnmsg tool has a bug in the regexp for handshake messages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-5743) Refactor PdxType logic
[
https://issues.apache.org/jira/browse/GEODE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498142#comment-17498142
]
Michael Martell commented on GEODE-5743:
My name may be on this but I'm pretty sure I didn't write this ticket. And I
certainly haven't done the work.
> Refactor PdxType logic
> --
>
> Key: GEODE-5743
> URL: https://issues.apache.org/jira/browse/GEODE-5743
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Priority: Major
>
> It isn't publicly facing so I can be tackled after the next release but It
> should be refactored to make separate between C++ and .NET clean. This looks
> like the only faked type in the registry now to handle C++ and .NET override
> behavior. The rest have already been replaced with {{*Handler}} interfaces.
> This should be refactored out. It is not really a primitive type, it just
> pretends to be one. Give it the same treatment we did for {{PdxTypeHandler}}
> and {{DataSerializableHandler}}. In fact rename {{PdxTypeHander}} to
> {{PdxSerializableHandler}}, the current name is confusing with {{PdxType}},
> which is the meta-data about PDX objects. Then implement this {{PdxType}}
> logic as {{PdxTypeHandler}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-10085) Multiple Locators Not Working in New .NET Test Framework
Michael Martell created GEODE-10085: --- Summary: Multiple Locators Not Working in New .NET Test Framework Key: GEODE-10085 URL: https://issues.apache.org/jira/browse/GEODE-10085 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell If a cluster with more than one locator is used in the new .NET test framework, the test will fail. The failure results from trying to start JmxManager when it is already running. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10088) Support ServerGroups in new .NET test framework
Michael Martell created GEODE-10088: --- Summary: Support ServerGroups in new .NET test framework Key: GEODE-10088 URL: https://issues.apache.org/jira/browse/GEODE-10088 Project: Geode Issue Type: Test Components: native client Reporter: Michael Martell The current clicache/integration-test2 test framework does not support server groups. Adding this support will help in creating a protocol document, as several messages support groups. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10088) Support ServerGroups in new test frameworks
[ https://issues.apache.org/jira/browse/GEODE-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10088: Description: The new integration test framewoks for .NET and C++ do not support server groups. Adding this support will help in creating a protocol document, as several messages support groups. (was: The current clicache/integration-test2 test framework does not support server groups. Adding this support will help in creating a protocol document, as several messages support groups.) Priority: Minor (was: Major) Summary: Support ServerGroups in new test frameworks (was: Support ServerGroups in new .NET test framework) > Support ServerGroups in new test frameworks > --- > > Key: GEODE-10088 > URL: https://issues.apache.org/jira/browse/GEODE-10088 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Priority: Minor > > The new integration test framewoks for .NET and C++ do not support server > groups. Adding this support will help in creating a protocol document, as > several messages support groups. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10058) Remove Defunct NetCore and C-Bindings from geode-native repo and CI
[ https://issues.apache.org/jira/browse/GEODE-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10058: Summary: Remove Defunct NetCore and C-Bindings from geode-native repo and CI (was: Remove Defunct NetCore and C-Bindiings from geode-native repo and CI) > Remove Defunct NetCore and C-Bindings from geode-native repo and CI > --- > > Key: GEODE-10058 > URL: https://issues.apache.org/jira/browse/GEODE-10058 > Project: Geode > Issue Type: Task >Reporter: Michael Martell >Priority: Major > > This project is being replaced by a pure C# client for .NET Core. > Also, move the SessionState code to a new branch since it's not throw away > code. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (GEODE-10058) Remove Defunct NetCore and C-Bindings from geode-native repo and CI
[ https://issues.apache.org/jira/browse/GEODE-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell closed GEODE-10058. --- > Remove Defunct NetCore and C-Bindings from geode-native repo and CI > --- > > Key: GEODE-10058 > URL: https://issues.apache.org/jira/browse/GEODE-10058 > Project: Geode > Issue Type: Task >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > This project is being replaced by a pure C# client for .NET Core. > Also, move the SessionState code to a new branch since it's not throw away > code. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10058) Remove Defunct NetCore and C-Bindings from geode-native repo and CI
[ https://issues.apache.org/jira/browse/GEODE-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-10058. - Resolution: Fixed > Remove Defunct NetCore and C-Bindings from geode-native repo and CI > --- > > Key: GEODE-10058 > URL: https://issues.apache.org/jira/browse/GEODE-10058 > Project: Geode > Issue Type: Task >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > This project is being replaced by a pure C# client for .NET Core. > Also, move the SessionState code to a new branch since it's not throw away > code. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10218) Launch Cluster with Attachability Flag
Michael Martell created GEODE-10218: --- Summary: Launch Cluster with Attachability Flag Key: GEODE-10218 URL: https://issues.apache.org/jira/browse/GEODE-10218 Project: Geode Issue Type: Test Components: native client Reporter: Michael Martell To assist with protocol analysis it is very helpful to be able to step through the server code in the Intellij debugger while running native client test code. However, to be allowed to set breakpoints in the server code, the server must be started with the special flag below: ```--J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT``` This ticket is to add support for the above flag in the native client test frameworks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10218) Launch Cluster with Attachability Flag
[ https://issues.apache.org/jira/browse/GEODE-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10218: Description: To assist with protocol analysis it is very helpful to be able to step through the server code in the Intellij debugger while running native client test code. However, to be allowed to set breakpoints in the server code, the server must be started with the special flag below: --J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT This ticket is to add support for the above flag in the native client test frameworks. was: To assist with protocol analysis it is very helpful to be able to step through the server code in the Intellij debugger while running native client test code. However, to be allowed to set breakpoints in the server code, the server must be started with the special flag below: ```--J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT``` This ticket is to add support for the above flag in the native client test frameworks. > Launch Cluster with Attachability Flag > -- > > Key: GEODE-10218 > URL: https://issues.apache.org/jira/browse/GEODE-10218 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Minor > > To assist with protocol analysis it is very helpful to be able to step > through the server code in the Intellij debugger while running native client > test code. However, to be allowed to set breakpoints in the server code, the > server must be started with the special flag below: > > --J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT > This ticket is to add support for the above flag in the native client test > frameworks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-10218) Launch Cluster with Attachability Flag
[ https://issues.apache.org/jira/browse/GEODE-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell reassigned GEODE-10218: --- Assignee: Michael Martell Priority: Minor (was: Major) > Launch Cluster with Attachability Flag > -- > > Key: GEODE-10218 > URL: https://issues.apache.org/jira/browse/GEODE-10218 > Project: Geode > Issue Type: Test > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Minor > > To assist with protocol analysis it is very helpful to be able to step > through the server code in the Intellij debugger while running native client > test code. However, to be allowed to set breakpoints in the server code, the > server must be started with the special flag below: > ```--J=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:FREEPORT``` > This ticket is to add support for the above flag in the native client test > frameworks. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10227) Remove Redundant Calls to sendRequestForChunkedResponse
Michael Martell created GEODE-10227: --- Summary: Remove Redundant Calls to sendRequestForChunkedResponse Key: GEODE-10227 URL: https://issues.apache.org/jira/browse/GEODE-10227 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell TcrEndpoint::sendRequestConn contains redundant calls to TcrConnection::sendRequestForChunkedResponse which should be removed. The current code is illustrated by the following: ```if (messageType == a || messageType == b) sendRequestForChunkedResponse() else sendRequestForChunkedResponse ``` -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-10227) Remove Redundant Calls to sendRequestForChunkedResponse
[ https://issues.apache.org/jira/browse/GEODE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell reassigned GEODE-10227: --- Assignee: Michael Martell > Remove Redundant Calls to sendRequestForChunkedResponse > --- > > Key: GEODE-10227 > URL: https://issues.apache.org/jira/browse/GEODE-10227 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Major > > TcrEndpoint::sendRequestConn contains redundant calls to > TcrConnection::sendRequestForChunkedResponse which should be removed. The > current code is illustrated by the following: > ```if (messageType == a || messageType == b) > sendRequestForChunkedResponse() > else > sendRequestForChunkedResponse > ``` -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10227) Remove Redundant Calls to sendRequestForChunkedResponse
[ https://issues.apache.org/jira/browse/GEODE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-10227: Priority: Minor (was: Major) > Remove Redundant Calls to sendRequestForChunkedResponse > --- > > Key: GEODE-10227 > URL: https://issues.apache.org/jira/browse/GEODE-10227 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Assignee: Michael Martell >Priority: Minor > > TcrEndpoint::sendRequestConn contains redundant calls to > TcrConnection::sendRequestForChunkedResponse which should be removed. The > current code is illustrated by the following: > ```if (messageType == a || messageType == b) > sendRequestForChunkedResponse() > else > sendRequestForChunkedResponse > ``` -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10227) Remove Redundant Calls to sendRequestForChunkedResponse
[
https://issues.apache.org/jira/browse/GEODE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-10227:
Description:
TcrEndpoint::sendRequestConn contains redundant calls to
TcrConnection::sendRequestForChunkedResponse which should be removed. The
current code is illustrated by the following:
{code:java}
if (messageType == a || messageType == b)
sendRequestForChunkedResponse()
else
sendRequestForChunkedResponse(){code}
was:
TcrEndpoint::sendRequestConn contains redundant calls to
TcrConnection::sendRequestForChunkedResponse which should be removed. The
current code is illustrated by the following:
```if (messageType == a || messageType == b)
sendRequestForChunkedResponse()
else
sendRequestForChunkedResponse
```
> Remove Redundant Calls to sendRequestForChunkedResponse
> ---
>
> Key: GEODE-10227
> URL: https://issues.apache.org/jira/browse/GEODE-10227
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Assignee: Michael Martell
>Priority: Minor
>
> TcrEndpoint::sendRequestConn contains redundant calls to
> TcrConnection::sendRequestForChunkedResponse which should be removed. The
> current code is illustrated by the following:
> {code:java}
> if (messageType == a || messageType == b)
> sendRequestForChunkedResponse()
> else
> sendRequestForChunkedResponse(){code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-10227) Remove Redundant Calls to sendRequestForChunkedResponse
[
https://issues.apache.org/jira/browse/GEODE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell resolved GEODE-10227.
-
Resolution: Fixed
> Remove Redundant Calls to sendRequestForChunkedResponse
> ---
>
> Key: GEODE-10227
> URL: https://issues.apache.org/jira/browse/GEODE-10227
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Assignee: Michael Martell
>Priority: Minor
>
> TcrEndpoint::sendRequestConn contains redundant calls to
> TcrConnection::sendRequestForChunkedResponse which should be removed. The
> current code is illustrated by the following:
> {code:java}
> if (messageType == a || messageType == b)
> sendRequestForChunkedResponse()
> else
> sendRequestForChunkedResponse(){code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (GEODE-10227) Remove Redundant Calls to sendRequestForChunkedResponse
[
https://issues.apache.org/jira/browse/GEODE-10227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell reopened GEODE-10227:
-
> Remove Redundant Calls to sendRequestForChunkedResponse
> ---
>
> Key: GEODE-10227
> URL: https://issues.apache.org/jira/browse/GEODE-10227
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Martell
>Assignee: Michael Martell
>Priority: Minor
> Labels: pull-request-available
>
> TcrEndpoint::sendRequestConn contains redundant calls to
> TcrConnection::sendRequestForChunkedResponse which should be removed. The
> current code is illustrated by the following:
> {code:java}
> if (messageType == a || messageType == b)
> sendRequestForChunkedResponse()
> else
> sendRequestForChunkedResponse(){code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-10237) Remove no-ack from transaction test
Michael Martell created GEODE-10237: --- Summary: Remove no-ack from transaction test Key: GEODE-10237 URL: https://issues.apache.org/jira/browse/GEODE-10237 Project: Geode Issue Type: Test Reporter: Michael Martell The testThinClientTransactionWithSticky test is run against both ack and no-ack scoped regions. The no-ack scoped portion causes regular failure of this test and should be removed (see GEODE-9108). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10269) Failover tests without durability are flaky
Michael Martell created GEODE-10269: --- Summary: Failover tests without durability are flaky Key: GEODE-10269 URL: https://issues.apache.org/jira/browse/GEODE-10269 Project: Geode Issue Type: Test Components: native client Reporter: Michael Martell Failover tests that use subscriptions can fail due to connection issues. Specifically, events that a client has subscribed to can be lost if the client hasn't finished connecting to a new server that is hosting the subscription queue. These tests should be rewritten to ensure lost events are resent. A good way to do this is to use the new test framework which allows multiple clients to run in the same process. This allows multiple clients to coordinate and request resend of missed events. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (GEODE-4313) Incorrect JVM Argument in gfsh
Michael Martell created GEODE-4313:
--
Summary: Incorrect JVM Argument in gfsh
Key: GEODE-4313
URL: https://issues.apache.org/jira/browse/GEODE-4313
Project: Geode
Issue Type: Bug
Components: gfsh
Reporter: Michael Martell
When running the attached Powershell script to start a locator and server on
Windows, the output of the start server command is incorrent.
*{color:#14892c}Here's the script:{color}*
param(
[Parameter(HelpMessage="C# src directory")]
[string] $cssrc = "C:\gemfire-dotnetsession",
[Parameter(HelpMessage="Geode root directory")]
[string] $gfrootdir = "C:\gemfire"
)
$ErrorActionPreference = "Stop"
$IPADDRESS = "localhost"
$DIRGUID = "samplewebapps"
pushd $cssrc
echo "" "Killing java processes..." ""
Stop-Process -name java -ErrorAction Ignore
Remove-Item -Recurse -Force "c:\temp\*"
echo "" "Starting gemfire up..." ""
pushd ${gfrootdir}\bin
.\gfsh.bat `
-e "start locator --name=locator --http-service-port=0
--dir=C:/temp/${DIRGUID} --bind-address=${IPADDRESS}
--J=-Dgemfire.jmx-manager-hostname-for-clients=${IPADDRESS}
--J=-Dgeode.feature-protobuf-protocol=false
--enable-cluster-configuration=true" `
-e "configure pdx --read-serialized=true" `
-e "start server --name=gbp-server --log-level=error --dir=C:/temp/${DIRGUID}
--bind-address=${IPADDRESS} --J=-XX:+UseG1GC" `
-e "alter runtime --enable-statistics=true" `
-e "alter runtime --statistic-archive-file=Statistics.gfs" `
-e "create region --name=session --type=PARTITION" `
-e "deploy
--jar=${cssrc}\build\SessionStateStoreFunctions\SessionStateStoreFunctions.jar"
if (!$?) \{exit 1}
popd
{color:#d04437}*Here's the output (Note the error string highlighted in red
below, where the actual IP Address is concatenated with the loopback
IP):*{color}
S C:\gemfire-dotnetsession> C:\gemfire-dotnetsession\bin\RunLocalhostGemfire.ps1
Killing java processes...
Starting gemfire up...
(1) Executing - start locator --name=locator --http-service-port=0
--dir=C:/temp/samplewebapps --bind-address=localhost
--J=-Dgemfire.jmx-manager-hostname-for-clients=lo
calhost --J=-Dgeode.feature-protobuf-protocol=false
--enable-cluster-configuration=true
...
Locator in C:\temp\samplewebapps on 127.0.0.1[10334] as locator is currently
online.
Process ID: 19968
Uptime: 3 seconds
Geode Version: 9.1.1
Java Version: 1.8.0_131
Log File: C:\temp\samplewebapps\locator.log
JVM Arguments: -Dgemfire.http-service-port=0
-Dgemfire.enable-cluster-configuration=true
-Dgemfire.load-cluster-configuration-from-dir=false -Dgemfire.jmx-manager-hostna
me-for-clients=localhost -Dgeode.feature-protobuf-protocol=false
-Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true
-Dsun.rmi.dgc.server.gcInterval=
9223372036854775806
Class-Path:
C:\gemfire\lib\geode-core-9.1.1.jar;C:\gemfire\lib\geode-dependencies.jar
Successfully connected to: JMX Manager [host=localhost, port=1099]
Cluster configuration service is up and running.
(2) Executing - configure pdx --read-serialized=true
persistent = false
read-serialized = true
ignore-unread-fields = false
(3) Executing - start server --name=gbp-server --log-level=error
--dir=C:/temp/samplewebapps --bind-address=localhost --J=-XX:+UseG1GC
Server in C:\temp\samplewebapps on 10.118.33.191[40404] as gbp-server is
currently online.
Process ID: 4376
Uptime: 4 seconds
Geode Version: 9.1.1
Java Version: 1.8.0_131
Log File: C:\temp\samplewebapps\gbp-server.log
JVM Arguments:
{color:#d04437}-Dgemfire.default.locators=10.118.33.191:127.0.0.1[10334]{color}
-Dgemfire.use-cluster-configuration=true -Dgemfire.bind-address=localhost
-Dgemfire.start-dev-re
st-api=false -Dgemfire.log-level=error -XX:+UseG1GC
-XX:OnOutOfMemoryError=taskkill /F /PID %p
-Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true -D
sun.rmi.dgc.server.gcInterval=9223372036854775806
Class-Path:
C:\gemfire\lib\geode-core-9.1.1.jar;C:\gemfire\lib\geode-dependencies.jar
(4) Executing - alter runtime --enable-statistics=true
Runtime configuration altered successfully for the following member(s)
127.0.0.1(gbp-server:4376):1025
(5) Executing - alter runtime --statistic-archive-file=Statistics.gfs
Runtime configuration altered successfully for the following member(s)
127.0.0.1(gbp-server:4376):1025
(6) Executing - create region --name=session --type=PARTITION
Member | Status
-- | -
gbp-server | Region "/session" created on "gbp-server"
(7) Executing - deploy
--jar=C:\gemfire-dotnetsession\build\SessionStateStoreFunctions\SessionStateStoreFunctions.jar
Member | Deployed JAR | Deployed JAR Location
-- | -- |
--
gbp-server | SessionStateStoreFunctions.jar |
C:\temp\samplewebapps\SessionStateStoreFunctions.v1...
PS C:\gemfire-dotnets
[jira] [Updated] (GEODE-4313) Incorrect JVM Argument in gfsh
[
https://issues.apache.org/jira/browse/GEODE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-4313:
---
Environment: This issue was seen in version 9.1.1 of gemfire running on
Windows 10.
Priority: Minor (was: Major)
> Incorrect JVM Argument in gfsh
> --
>
> Key: GEODE-4313
> URL: https://issues.apache.org/jira/browse/GEODE-4313
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Environment: This issue was seen in version 9.1.1 of gemfire running
> on Windows 10.
>Reporter: Michael Martell
>Priority: Minor
>
> When running the attached Powershell script to start a locator and server on
> Windows, the output of the start server command is incorrent.
> *{color:#14892c}Here's the script:{color}*
> param(
> [Parameter(HelpMessage="C# src directory")]
> [string] $cssrc = "C:\gemfire-dotnetsession",
> [Parameter(HelpMessage="Geode root directory")]
> [string] $gfrootdir = "C:\gemfire"
> )
> $ErrorActionPreference = "Stop"
> $IPADDRESS = "localhost"
> $DIRGUID = "samplewebapps"
> pushd $cssrc
> echo "" "Killing java processes..." ""
> Stop-Process -name java -ErrorAction Ignore
> Remove-Item -Recurse -Force "c:\temp\*"
> echo "" "Starting gemfire up..." ""
> pushd ${gfrootdir}\bin
> .\gfsh.bat `
> -e "start locator --name=locator --http-service-port=0
> --dir=C:/temp/${DIRGUID} --bind-address=${IPADDRESS}
> --J=-Dgemfire.jmx-manager-hostname-for-clients=${IPADDRESS}
> --J=-Dgeode.feature-protobuf-protocol=false
> --enable-cluster-configuration=true" `
> -e "configure pdx --read-serialized=true" `
> -e "start server --name=gbp-server --log-level=error
> --dir=C:/temp/${DIRGUID} --bind-address=${IPADDRESS} --J=-XX:+UseG1GC" `
> -e "alter runtime --enable-statistics=true" `
> -e "alter runtime --statistic-archive-file=Statistics.gfs" `
> -e "create region --name=session --type=PARTITION" `
> -e "deploy
> --jar=${cssrc}\build\SessionStateStoreFunctions\SessionStateStoreFunctions.jar"
> if (!$?) \{exit 1}
> popd
>
> {color:#d04437}*Here's the output (Note the error string highlighted in red
> below, where the actual IP Address is concatenated with the loopback
> IP):*{color}
> S C:\gemfire-dotnetsession>
> C:\gemfire-dotnetsession\bin\RunLocalhostGemfire.ps1
> Killing java processes...
> Starting gemfire up...
> (1) Executing - start locator --name=locator --http-service-port=0
> --dir=C:/temp/samplewebapps --bind-address=localhost
> --J=-Dgemfire.jmx-manager-hostname-for-clients=lo
> calhost --J=-Dgeode.feature-protobuf-protocol=false
> --enable-cluster-configuration=true
> ...
> Locator in C:\temp\samplewebapps on 127.0.0.1[10334] as locator is currently
> online.
> Process ID: 19968
> Uptime: 3 seconds
> Geode Version: 9.1.1
> Java Version: 1.8.0_131
> Log File: C:\temp\samplewebapps\locator.log
> JVM Arguments: -Dgemfire.http-service-port=0
> -Dgemfire.enable-cluster-configuration=true
> -Dgemfire.load-cluster-configuration-from-dir=false
> -Dgemfire.jmx-manager-hostna
> me-for-clients=localhost -Dgeode.feature-protobuf-protocol=false
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true
> -Dsun.rmi.dgc.server.gcInterval=
> 9223372036854775806
> Class-Path:
> C:\gemfire\lib\geode-core-9.1.1.jar;C:\gemfire\lib\geode-dependencies.jar
> Successfully connected to: JMX Manager [host=localhost, port=1099]
> Cluster configuration service is up and running.
> (2) Executing - configure pdx --read-serialized=true
> persistent = false
> read-serialized = true
> ignore-unread-fields = false
> (3) Executing - start server --name=gbp-server --log-level=error
> --dir=C:/temp/samplewebapps --bind-address=localhost --J=-XX:+UseG1GC
>
> Server in C:\temp\samplewebapps on 10.118.33.191[40404] as gbp-server is
> currently online.
> Process ID: 4376
> Uptime: 4 seconds
> Geode Version: 9.1.1
> Java Version: 1.8.0_131
> Log File: C:\temp\samplewebapps\gbp-server.log
> JVM Arguments:
> {color:#d04437}-Dgemfire.default.locators=10.118.33.191:127.0.0.1[10334]{color}
> -Dgemfire.use-cluster-configuration=true -Dgemfire.bind-address=localhost
> -Dgemfire.start-dev-re
> st-api=false -Dgemfire.log-level=error -XX:+UseG1GC
> -XX:OnOutOfMemoryError=taskkill /F /PID %p
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true -D
> sun.rmi.dgc.server.gcInterval=9223372036854775806
> Class-Path:
> C:\gemfire\lib\geode-core-9.1.1.jar;C:\gemfire\lib\geode-dependencies.jar
> (4) Executing - alter runtime --enable-statistics=true
> Runtime configuration altered successfully for the following member(s)
> 127.0.0.1(gbp-server:4376):1025
>
> (5) Executing - alter runtime --statistic-archive-file=Statistics.gfs
> Runtime configuration altered successfully for the following member(s)
> 127.0.0.1(gbp-server:4376):1025
>
> (6) Executing - cr
[jira] [Created] (GEODE-4667) Statistics Doesn't Support Multiple Caches
Michael Martell created GEODE-4667: -- Summary: Statistics Doesn't Support Multiple Caches Key: GEODE-4667 URL: https://issues.apache.org/jira/browse/GEODE-4667 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell The testThinClientMultipleCaches integration test was failing on multi-core systems on Windows, but passed on single-core systems. The problem is solved by turning off the hostStats sampler, i.e., SystemProperties.DefaultSamplingEnabled = false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4668) Refactor CacheHelper::addServerLocatorEPs
Michael Martell created GEODE-4668: -- Summary: Refactor CacheHelper::addServerLocatorEPs Key: GEODE-4668 URL: https://issues.apache.org/jira/browse/GEODE-4668 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Two enhancements needed to this function: * make the function addServerLocatorEPs static * pass the PoolFactory parameter (2nd parameter to this function) by reference instead of by value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4677) Remove FLAKY Designation from Tests That Are Now STABLE
Michael Martell created GEODE-4677: -- Summary: Remove FLAKY Designation from Tests That Are Now STABLE Key: GEODE-4677 URL: https://issues.apache.org/jira/browse/GEODE-4677 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Recent removal of HostStats support (GEODE-4667) has made some of the flaky tests pass consistently. This ticket is to capture the work of removing the FLAKY designation from the CMakeLists.txt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4723) Not Able to Parse geode.properties duration-timeout
Michael Martell created GEODE-4723: -- Summary: Not Able to Parse geode.properties duration-timeout Key: GEODE-4723 URL: https://issues.apache.org/jira/browse/GEODE-4723 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell This looks like a bug related to the switch to std::chrono for all time values. Plan: * Create a new ThinClientSystemPropertiesTests.cs (we currently only have cli tests for the Auth params) * Add a test to verify that duration-timeout is parsed properly (this will likely fail) * Fix the failing test by updating the parser to support std::chrono.duration We were able to workaround this problem by appending an s to the parameter in the file: i.e., in geode.properties we changed duration-timeout as below: changed from: duration-timeout = 12345 to: duration-timeout = 12345s -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4799) Remove static member variables from Apache.Geode.Client.Serializable
Michael Martell created GEODE-4799: -- Summary: Remove static member variables from Apache.Geode.Client.Serializable Key: GEODE-4799 URL: https://issues.apache.org/jira/browse/GEODE-4799 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Currently this class contains a bunch of static member variables. These need to be converted to instance variables. This change will allow each cache instance to have its own custom serializer without needing to use a chained serializer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5045) Boost Fails to Build on Windows with Multiple Visual Studio Versions Installed
Michael Martell created GEODE-5045: -- Summary: Boost Fails to Build on Windows with Multiple Visual Studio Versions Installed Key: GEODE-5045 URL: https://issues.apache.org/jira/browse/GEODE-5045 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell If you try to build native client on Windows with multiple versions of Visual Studio installed, you may fail to build the Boost library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5101) Cmake Find Module for Geode Native Not Correct
Michael Martell created GEODE-5101: -- Summary: Cmake Find Module for Geode Native Not Correct Key: GEODE-5101 URL: https://issues.apache.org/jira/browse/GEODE-5101 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell FindGeodeNaitve.cmake is hardcoded to look for the geode-native install in an apache-geode subdirectory. This should not be hardcoded, but should look in the install folder. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-7041) Write Test for FunctionService::OnServers() in New Test Framework
Michael Martell created GEODE-7041: -- Summary: Write Test for FunctionService::OnServers() in New Test Framework Key: GEODE-7041 URL: https://issues.apache.org/jira/browse/GEODE-7041 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Currently there are no C++ tests for this API. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GEODE-7060) Fix ACE Resource Leak
Michael Martell created GEODE-7060: -- Summary: Fix ACE Resource Leak Key: GEODE-7060 URL: https://issues.apache.org/jira/browse/GEODE-7060 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell When running the gemfire-node-client putall.js test inside a loop, we get the following error after about 400 iterations: line is 'ACE_Semaphore::ACE_Semaphore: No space left on device' on iteration 384 This reference indicates the problem is due to not calling remove() on the ACE::Mutex objects. https://comp.soft-sys.ace.narkive.com/ppIGa8Mp/ace-users-ace-sv-semaphore-complex-no-space-left-on-device -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (GEODE-7285) Several Examples Don't Work on Windows
Michael Martell created GEODE-7285: -- Summary: Several Examples Don't Work on Windows Key: GEODE-7285 URL: https://issues.apache.org/jira/browse/GEODE-7285 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell The list of examples below do not work do to a mismatch between the server start/stop scripts and the code. Specifically, several scripts create/destroy a region of one name, but the example code tries to use a region of a different name. Broken examples: * continuousquery (Windows) * dataserializable (Windows) * pdxserializable (Windows) * pdxserializer (Windows) * transaction (Windows) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7285) Several Examples Don't Work on Windows
[ https://issues.apache.org/jira/browse/GEODE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-7285. Resolution: Fixed > Several Examples Don't Work on Windows > -- > > Key: GEODE-7285 > URL: https://issues.apache.org/jira/browse/GEODE-7285 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The list of examples below do not work do to a mismatch between the server > start/stop scripts and the code. Specifically, several scripts create/destroy > a region of one name, but the example code tries to use a region of a > different name. > Broken examples: > * continuousquery (Windows) > * dataserializable (Windows) > * pdxserializable (Windows) > * pdxserializer (Windows) > * transaction (Windows) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-7490) Support for Building native client with Visual Studio 2019
Michael Martell created GEODE-7490: -- Summary: Support for Building native client with Visual Studio 2019 Key: GEODE-7490 URL: https://issues.apache.org/jira/browse/GEODE-7490 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Visual Studio 2019 supports many new development features including builtin support for .NET Core and closer adherence to C++ standards. This ticket is to fix several issues related to building the native client with VS 2019. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7490) Support for Building native client with Visual Studio 2019
[ https://issues.apache.org/jira/browse/GEODE-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-7490. Fix Version/s: 1.11.0 Resolution: Fixed > Support for Building native client with Visual Studio 2019 > --- > > Key: GEODE-7490 > URL: https://issues.apache.org/jira/browse/GEODE-7490 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Visual Studio 2019 supports many new development features including builtin > support for .NET Core and closer adherence to C++ standards. This ticket is > to fix several issues related to building the native client with VS 2019. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-7511) Support Long DNS Names
Michael Martell created GEODE-7511: -- Summary: Support Long DNS Names Key: GEODE-7511 URL: https://issues.apache.org/jira/browse/GEODE-7511 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Fix For: 1.11.0 NodeJS client was failing on PCC 1.9.1. Long DNS was introduced in PCC 1.9.1 for locator and server members. The spec for DNS says names can be up to approximately 256 characters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-7511) Support Long DNS Names
[ https://issues.apache.org/jira/browse/GEODE-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-7511: --- Issue Type: Bug (was: Improvement) > Support Long DNS Names > -- > > Key: GEODE-7511 > URL: https://issues.apache.org/jira/browse/GEODE-7511 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > Fix For: 1.11.0 > > > NodeJS client was failing on PCC 1.9.1. Long DNS was introduced in PCC 1.9.1 > for locator and server members. The spec for DNS says names can be up to > approximately 256 characters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-7511) Support Long DNS Names
[ https://issues.apache.org/jira/browse/GEODE-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-7511: --- Fix Version/s: (was: 1.11.0) > Support Long DNS Names > -- > > Key: GEODE-7511 > URL: https://issues.apache.org/jira/browse/GEODE-7511 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > > NodeJS client was failing on PCC 1.9.1. Long DNS was introduced in PCC 1.9.1 > for locator and server members. The spec for DNS says names can be up to > approximately 256 characters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7511) Support Long DNS Names
[ https://issues.apache.org/jira/browse/GEODE-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell resolved GEODE-7511. Fix Version/s: 1.11.0 Resolution: Fixed > Support Long DNS Names > -- > > Key: GEODE-7511 > URL: https://issues.apache.org/jira/browse/GEODE-7511 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Michael Martell >Priority: Major > Fix For: 1.11.0 > > Time Spent: 50m > Remaining Estimate: 0h > > NodeJS client was failing on PCC 1.9.1. Long DNS was introduced in PCC 1.9.1 > for locator and server members. The spec for DNS says names can be up to > approximately 256 characters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-7557) Google Test Hang in IDE
Michael Martell created GEODE-7557:
--
Summary: Google Test Hang in IDE
Key: GEODE-7557
URL: https://issues.apache.org/jira/browse/GEODE-7557
Project: Geode
Issue Type: Bug
Components: native client
Reporter: Michael Martell
We use Boost Process in our Cluster integration test framework to start Gfsh
and launch locators and servers. This code hangs indefinitely when run from
within an IDE, we speculate it has something to do with the standard output
from the Gfsh process being improperly handled when the stream closes as the
process terminates; it seems we do get several lines of output indicating the
pipe works until process termination.
The offending line of code can be found in
cppcache\integration\framework\GfshExecute.cpp:72
```
while (outStream && std::getline(outStream, line)) {
```
We don't see this problem when running the test harness from the command line,
even through ctest.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-7557) Google Test Hang in IDE
[
https://issues.apache.org/jira/browse/GEODE-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-7557:
---
Description:
We use Boost Process in our Cluster integration test framework to start Gfsh
and launch locators and servers. This code hangs indefinitely when run from
within an IDE, we speculate it has something to do with the standard output
from the Gfsh process being improperly handled when the stream closes as the
process terminates; it seems we do get several lines of output indicating the
pipe works until process termination.
The offending line of code can be found in
cppcache\integration\framework\GfshExecute.cpp:72
```
while (outStream && std::getline(outStream, line)) {
```
We don't see this problem when running the test harness from the command line,
even through ctest.
Notes: It is curious that only the SSL tests experience this hang in the IDE.
That may be a clue to the issue.
was:
We use Boost Process in our Cluster integration test framework to start Gfsh
and launch locators and servers. This code hangs indefinitely when run from
within an IDE, we speculate it has something to do with the standard output
from the Gfsh process being improperly handled when the stream closes as the
process terminates; it seems we do get several lines of output indicating the
pipe works until process termination.
The offending line of code can be found in
cppcache\integration\framework\GfshExecute.cpp:72
```
while (outStream && std::getline(outStream, line)) {
```
We don't see this problem when running the test harness from the command line,
even through ctest.
> Google Test Hang in IDE
> ---
>
> Key: GEODE-7557
> URL: https://issues.apache.org/jira/browse/GEODE-7557
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Michael Martell
>Priority: Major
>
> We use Boost Process in our Cluster integration test framework to start Gfsh
> and launch locators and servers. This code hangs indefinitely when run from
> within an IDE, we speculate it has something to do with the standard output
> from the Gfsh process being improperly handled when the stream closes as the
> process terminates; it seems we do get several lines of output indicating the
> pipe works until process termination.
> The offending line of code can be found in
> cppcache\integration\framework\GfshExecute.cpp:72
>
> ```
> while (outStream && std::getline(outStream, line)) {
> ```
> We don't see this problem when running the test harness from the command
> line, even through ctest.
>
> Notes: It is curious that only the SSL tests experience this hang in the IDE.
> That may be a clue to the issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-7562) Fix Support for JSON Objects
Michael Martell created GEODE-7562:
--
Summary: Fix Support for JSON Objects
Key: GEODE-7562
URL: https://issues.apache.org/jira/browse/GEODE-7562
Project: Geode
Issue Type: Bug
Components: native client
Reporter: Michael Martell
As a client developer, I need to be able to put/get JSON values of different
types.
NC is supposed to support put/get of JSON-formatted objects using PDX and the
class name "__GEMFIRE_JSON". For a single value of JSON, this appears to work
properly, but if there are more than one type with this class name,
`region::get` breaks down. The puts work, but when the values come back from
the region the NC maps all of the values to the first type.
For instance, the JSON object "\{ foo: 'bar' }" is put in the region with key
1, then the value "\{ baz: 7 }" is put with key 2. When get(key1) is called,
you get back a PDX representation of "\{ foo: 'bar' }", but when get(key2) is
called, instead of "\{ baz: 7}", you get back "\{ foo: }", i.e. one field,
named foo, with no value, instead of one field named baz with value 7.
We believe the NC is using a map for types based on class name rather than type
ID, but are not 100% certain yet what's specifically wrong.
Acceptance criteria:
i. There is a new integration test which creates a region, puts two JSON
values with different structures, gets them back, and compares the retrieved
values to the originals.
ii. Said test is passing in the standard NC integration test suite.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-7646) Simplify SSL Examples by Eliminating Need for LD_LIBRARY_PATH on Linux
Michael Martell created GEODE-7646: -- Summary: Simplify SSL Examples by Eliminating Need for LD_LIBRARY_PATH on Linux Key: GEODE-7646 URL: https://issues.apache.org/jira/browse/GEODE-7646 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell The new SSL examples for the native client currently require the LD_LIBRARY_PATH environment variable to include the path to our crypto library (libcryptoImpl.so) on Linux. This ticket is to eliminate the need for this environment variable and make Linux and OSX be consistent. The driving force to fix this was the recent switch to using RPATH to bake in the path to our crypto library into the executable. On newer versions of OSX, System Integrity Protection (SIP) ignores LD_LIBRARY_PATH. Using RPATH was the solution for this. However, until this fix the RPATH solution doesn't work on Linux. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-7697) Add Dependency on OpenSSL 1.1 to Native Client
Michael Martell created GEODE-7697: -- Summary: Add Dependency on OpenSSL 1.1 to Native Client Key: GEODE-7697 URL: https://issues.apache.org/jira/browse/GEODE-7697 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell Native client depends on OpenSSL 1.1 to avoid issues with multithreading. This ticket is to enforce this dependency via the cmake find_package command. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-5192) Fix license header in src files
[ https://issues.apache.org/jira/browse/GEODE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469052#comment-16469052 ] Michael Martell commented on GEODE-5192: Closing due to duplicate of GEODE-5191. > Fix license header in src files > --- > > Key: GEODE-5192 > URL: https://issues.apache.org/jira/browse/GEODE-5192 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Ernest Burghardt >Priority: Major > > the following files don’t include correct ASF headers: > Files with unapproved licenses: > ./clicache/integration-test/TestCacheXmlInitializationN.cs > ./clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs > ./clicache/src/native_conditional_shared_ptr.hpp > ./clicache/src/native_shared_ptr.hpp > ./clicache/test/[AssemblyInfo.cpp.in|http://assemblyinfo.cpp.in/] > ./clicache/test/Utils.hpp > ./cmake/PrecompiledHeader.cmake > ./dependencies/boost/solaris.patch > ./packer/windows/vs-2015-admin.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5372) gfsh process occasional fails to exit in Windows
Michael Martell created GEODE-5372: -- Summary: gfsh process occasional fails to exit in Windows Key: GEODE-5372 URL: https://issues.apache.org/jira/browse/GEODE-5372 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell Occasionally the gfsh process used by the C++/CLI integration tests fails to exit. Stack trace: Apache.Geode.Client.IntegrationTests.RegionTest.PutOnOneCacheGetOnAnotherCache [FAIL] System.InvalidOperationException : Process must exit before requested information can be determined. Stack Trace: at System.Diagnostics.Process.EnsureState(State state) at System.Diagnostics.Process.get_ExitCode() D:\nativeclient\clicache\integration-test2\GeodeServer.cs(113,0): at GeodeServer..ctor(String regionName, Boolean readSerialized, Boolean useSsl) D:\nativeclient\clicache\integration-test2\RegionTest.cs(31,0): at Apache.Geode.Client.IntegrationTests.RegionTest.PutOnOneCacheGetOnAnotherCache() Finished: Apache.Geode.IntegrationTests2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5381) Wrong name for code coverage in BUILDING.md
Michael Martell created GEODE-5381: -- Summary: Wrong name for code coverage in BUILDING.md Key: GEODE-5381 URL: https://issues.apache.org/jira/browse/GEODE-5381 Project: Geode Issue Type: Bug Components: native client Reporter: Michael Martell The BUILDING.md is saying to use -DUSE_CODE_COVERAGE=ON when configuring geode-native for code coverage. Should be -DUSE_CPP_COVERAGE=ON instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5434) Region data is not updated when CQ and RegisterAllKey are used together in NativeClient
[
https://issues.apache.org/jira/browse/GEODE-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545283#comment-16545283
]
Michael Martell commented on GEODE-5434:
Your sample app above doesn't compile with latest geode-native. Looks like
there have been significant changes in this area. Please tell me the git SHA
you were using.
Thanks,
Mike
> Region data is not updated when CQ and RegisterAllKey are used together in
> NativeClient
> ---
>
> Key: GEODE-5434
> URL: https://issues.apache.org/jira/browse/GEODE-5434
> Project: Geode
> Issue Type: Bug
> Components: client/server, cq, native client
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> When CQ and RegisterAllKey are used together in NativeClient, the latest data
> can not be geted. I have created a simple application to confirm this issue.
> It exists below and the confirmation procedure is as follows:
> [https://github.com/masaki-yamakawa/GeodeNativeSample/blob/master/csharp/GeodeSample/GeodeSample/CqAndRegisterAllKeysBug.cs]
> # Start Locator with gfsh. (start locator -name=\{Name})
> # Start CacheServer with gfsh. (start server -name=\{Name})
> # Create an exampleRegion with gfsh. (create region --name=exampleRegion
> --type=REPLICATE)
> # Put data to exampleRegion with gfsh. (put --region=exampleRegion --key='1'
> --value='1'; put --region=exampleRegion --key='2' --value='2')
> # Execute CqAndRegisterAllKeysBug.cs.
> # Update exampleRegion's data with gfsh. (put --region=exampleRegion
> --key='1' --value='11'; put --region=exampleRegion --key='2' --value='22')
> # You can see that the data with key=1 has not been updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5434) Region data is not updated when CQ and RegisterAllKey are used together in NativeClient
[
https://issues.apache.org/jira/browse/GEODE-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545476#comment-16545476
]
Michael Martell commented on GEODE-5434:
The above code was run against nativeclient 9.2, not geode-native.
> Region data is not updated when CQ and RegisterAllKey are used together in
> NativeClient
> ---
>
> Key: GEODE-5434
> URL: https://issues.apache.org/jira/browse/GEODE-5434
> Project: Geode
> Issue Type: Bug
> Components: client/server, cq, native client
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> When CQ and RegisterAllKey are used together in NativeClient, the latest data
> can not be geted. I have created a simple application to confirm this issue.
> It exists below and the confirmation procedure is as follows:
> [https://github.com/masaki-yamakawa/GeodeNativeSample/blob/master/csharp/GeodeSample/GeodeSample/CqAndRegisterAllKeysBug.cs]
> # Start Locator with gfsh. (start locator -name=\{Name})
> # Start CacheServer with gfsh. (start server -name=\{Name})
> # Create an exampleRegion with gfsh. (create region --name=exampleRegion
> --type=REPLICATE)
> # Put data to exampleRegion with gfsh. (put --region=exampleRegion --key='1'
> --value='1'; put --region=exampleRegion --key='2' --value='2')
> # Execute CqAndRegisterAllKeysBug.cs.
> # Update exampleRegion's data with gfsh. (put --region=exampleRegion
> --key='1' --value='11'; put --region=exampleRegion --key='2' --value='22')
> # You can see that the data with key=1 has not been updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GEODE-5634) Upgrade to latest xunit modules
Michael Martell created GEODE-5634: -- Summary: Upgrade to latest xunit modules Key: GEODE-5634 URL: https://issues.apache.org/jira/browse/GEODE-5634 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Upgrade the core modules from version 2.3.1 => 2.4.0 and xunit.analyzers 0.8.0 => 0.10.0 "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5638) Organize/Cleanup the geode-native project structure
Michael Martell created GEODE-5638: -- Summary: Organize/Cleanup the geode-native project structure Key: GEODE-5638 URL: https://issues.apache.org/jira/browse/GEODE-5638 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Currently we 31 projects in the geode-native solution (see attached). We should organize these projects into folders. We started this a while back, putting all test projects into the test folder. However, we've let a bunch of new test projects leak out into the top level. Other projects could also be grouped together into folders to improve clarity and navigation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5743) Refactor PdxType logic
Michael Martell created GEODE-5743:
--
Summary: Refactor PdxType logic
Key: GEODE-5743
URL: https://issues.apache.org/jira/browse/GEODE-5743
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Michael Martell
It isn't publicly facing so I can be tackled after the next release but It
should be refactored to make separate between C++ and .NET clean. This looks
like the only faked type in the registry now to handle C++ and .NET override
behavior. The rest have already been replaced with {{*Handler}} interfaces.
This should be refactored out. It is not really a primitive type, it just
pretends to be one. Give it the same treatment we did for {{PdxTypeHandler}}
and {{DataSerializableHandler}}. In fact rename {{PdxTypeHander}} to
{{PdxSerializableHandler}}, the current name is confusing with {{PdxType}},
which is the meta-data about PDX objects. Then implement this {{PdxType}} logic
as {{PdxTypeHandler}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GEODE-5818) Port Remaining csharp test projects to be generated by cmake
Michael Martell created GEODE-5818: -- Summary: Port Remaining csharp test projects to be generated by cmake Key: GEODE-5818 URL: https://issues.apache.org/jira/browse/GEODE-5818 Project: Geode Issue Type: Task Components: native client Reporter: Michael Martell These projects need porting to cmake: * ./FwkClient/FwkClient.csproj.in * ./DUnitFramework/DUnitFramework.csproj.in * ./NewFwkLib/NewFwkLib.csproj.in * ./FwkLauncher/FwkLauncher.csproj.in * ./PdxVersion2Lib/PdxVersion2Lib.csproj.in * ./PdxVersion1Lib/PdxVersion1Lib.csproj.in * ./FwkUtil/FwkUtil.csproj.in * ./SecurityUtil/SecurityUtil.csproj.in -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5825) Write Tests Using New Framework to Increase Code Coverage in Key Areas
Michael Martell created GEODE-5825: -- Summary: Write Tests Using New Framework to Increase Code Coverage in Key Areas Key: GEODE-5825 URL: https://issues.apache.org/jira/browse/GEODE-5825 Project: Geode Issue Type: Task Components: native client Reporter: Michael Martell Plan: * start by rerunning all STABLE tests locally to generate a new report * use results to write new tests against any public APIs that aren't being covered -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
Michael Martell created GEODE-5837: -- Summary: Create New Tests to Fix Coverage Holes in TcrMessage Key: GEODE-5837 URL: https://issues.apache.org/jira/browse/GEODE-5837 Project: Geode Issue Type: Task Components: native client Reporter: Michael Martell -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Description: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader(1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType,1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input,1334 :const char* methodName,1335 : uint32_t& partLen,1336 : uint8_t isLastChunk) > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * > inline static ChunkObjectType readChunkPartHeader(1259 : > TcrMessage& msg, DataInput& input, DSCode expectedFirstType,1260 > : int32_t expectedPartType, const char* methodName, uint32_t& > partLen,1261 : uint8_t isLastChunk) > * > inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& > input,1334 :const > char* methodName,1335 : > uint32_t& partLen,1336 : >uint8_t isLastChunk) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: TcrMessage-lcov1.PNG > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage-lcov1.PNG, TcrMessage-lcov2.PNG > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * > inline static ChunkObjectType readChunkPartHeader(1259 : > TcrMessage& msg, DataInput& input, DSCode expectedFirstType,1260 > : int32_t expectedPartType, const char* methodName, uint32_t& > partLen,1261 : uint8_t isLastChunk) > * > inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& > input,1334 :const > char* methodName,1335 : > uint32_t& partLen,1336 : >uint8_t isLastChunk) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: TcrMessage-lcov2.PNG > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage-lcov1.PNG, TcrMessage-lcov2.PNG > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * > inline static ChunkObjectType readChunkPartHeader(1259 : > TcrMessage& msg, DataInput& input, DSCode expectedFirstType,1260 > : int32_t expectedPartType, const char* methodName, uint32_t& > partLen,1261 : uint8_t isLastChunk) > * > inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& > input,1334 :const > char* methodName,1335 : > uint32_t& partLen,1336 : >uint8_t isLastChunk) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Description: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 : uint8_t isLastChunk) lcov results are shown in the attachments was: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader(1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType,1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input,1334 :const char* methodName,1335 : uint32_t& partLen,1336 : uint8_t isLastChunk) > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage-lcov1.PNG, TcrMessage-lcov2.PNG > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Description: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 : uint8_t isLastChunk) * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 : uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader) lcov results are shown in the attachments was: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 : uint8_t isLastChunk) lcov results are shown in the attachments > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage-lcov1.PNG, TcrMessage-lcov2.PNG > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: TcrMessage.cpp.gcov.html > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage-lcov1.PNG, TcrMessage-lcov2.PNG, > TcrMessage.cpp.gcov.html > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: (was: TcrMessage.cpp.gcov.html) > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: (was: TcrMessage-lcov2.PNG) > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: (was: TcrMessage-lcov1.PNG) > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: TcrMessage.hpp.gcov.html > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.func.html, > TcrMessage.hpp.gcov.html > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: TcrMessage.hpp.func.html TcrMessage.cpp.gcov.html > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.func.html, > TcrMessage.hpp.gcov.html > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Description: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 : uint8_t isLastChunk) * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 : uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader) lcov results are shown in the attachments was: Significant pieces of code in TcrMessage are not being tested. New tests should be written to test the following: * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 : uint8_t isLastChunk) * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 : uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader) lcov results are shown in the attachments > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.gcov.html > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 : > uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[ https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Martell updated GEODE-5837: --- Attachment: (was: TcrMessage.hpp.func.html) > Create New Tests to Fix Coverage Holes in TcrMessage > > > Key: GEODE-5837 > URL: https://issues.apache.org/jira/browse/GEODE-5837 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Martell >Priority: Major > Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.gcov.html > > > Significant pieces of code in TcrMessage are not being tested. New tests > should be written to test the following: > * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, > DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, > const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk) > * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, > DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, > 1336 : uint8_t isLastChunk) > * > void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 > : uint16_t endpointmemId, 725 > : const uint8_t > isLastChunkAndisSecurityHeader) > lcov results are shown in the attachments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-5837:
---
Description:
Significant pieces of code in TcrMessage are not being tested. New tests should
be written to test the following:
* inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
* inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336
: uint8_t isLastChunk)
* void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
*
void TcrMessage::readOldValue(DataInput& input)
*
void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
*
inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227
:bool defaultString)
*
void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes,
884 : int32_t len, 885
: uint8_t
isLastChunkAndSecurityHeader)
*
void TcrMessage::handleByteArrayResponse( 896 : const char*
bytearray, int32_t len, uint16_t endpointMemId, 897 : const
SerializationRegistry& serializationRegistry, 898 :
MemberListForVersionStamp& memberListForVersionStamp)
*
TcrMessageClearRegion::TcrMessageClearRegion(1401 :
DataOutput* dataOutput, const Region* region,1402 : const
std::shared_ptr& aCallbackArgument,1403 :
std::chrono::milliseconds messageResponsetimeout,1404 6 :
ThinClientBaseDM* connectionDM)
*
TcrMessageGetDurableCqs::TcrMessageGetDurableCqs(1599 0 :
DataOutput* dataOutput, ThinClientBaseDM* connectionDM) {1600 0 :
m_request.reset(dataOutput)
*
TcrMessageCreateRegion::TcrMessageCreateRegion(1938 :
DataOutput* dataOutput, const std::string& str1, const std::string& str2,
1939 0 : bool isDurable, bool receiveValues, ThinClientBaseDM*
connectionDM)
*
TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
dataOutput,2015 :
int ordinal, int txid,2016 0 :
int status)
*
TcrMessageTxFailover::TcrMessageTxFailover(DataOutput* dataOutput) {2061
0 : m_msgType = TcrMessage::TX_FAILOVER;2062 0 :
m_request.reset(dataOutput)
*
TcrMessageSize::TcrMessageSize(DataOutput* dataOutput, const char* regionName)
{2484 0 : m_request.reset(dataOutput
*
TcrMessageRemoveUserAuth::TcrMessageRemoveUserAuth(2516 0 :
DataOutput* dataOutput, bool keepAlive, ThinClientBaseDM* connectionDM) {
2517 0 : m_request.reset(dataOutput)
*
void TcrMessage::addSecurityPart(int64_t connectionId, int64_t unique_id,
2558 : TcrConnection* conn)
*
void TcrMessage::addSecurityPart(int64_t connectionId, TcrConnection* conn)
*
TcrMessageAddPdxEnum::TcrMessageAddPdxEnum(2685 :
DataOutput* dataOutput, const std::shared_ptr& pdxType,2686
0 : ThinClientBaseDM* connectionDM, int32_t pdxTypeId)
*
void TcrMessage::readEventIdPart(DataInput& input, bool skip, int32_t parts)
*
std::shared_ptr TcrMessage::readDSMember(2874
: apache::geode::client::DataInput& input)
*
void TcrMessage::readHashMapForGCVersions(2904 :
apache::geode::client::DataInput& input,2905 :
std::shared_ptr& value)
*
lcov results are shown in the attachments
was:
Significant pieces of code in TcrMessage are not being tested. New tests should
be written to test the following:
* inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
* inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336
: uint8_t isLastChunk)
* void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
lcov results are shown in the attachments
> Create New Tests to Fix Coverage Holes in TcrMessage
>
>
>
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-5837:
---
Description:
Significant pieces of code in TcrMessage are not being tested. New tests should
be written to test the following:
* inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
* inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336
: uint8_t isLastChunk)
* void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
*
void TcrMessage::readOldValue(DataInput& input)
*
void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
*
inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227 : bool
defaultString)
*
void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes, 884 :
int32_t len, 885 : uint8_t isLastChunkAndSecurityHeader)
*
void TcrMessage::handleByteArrayResponse( 896 : const char* bytearray, int32_t
len, uint16_t endpointMemId, 897 : const SerializationRegistry&
serializationRegistry, 898 : MemberListForVersionStamp&
memberListForVersionStamp)
*
TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
dataOutput, 2015 : int ordinal, int txid, 2016 0 : int status)
*
TcrMessageTxFailover::TcrMessageTxFailover(DataOutput* dataOutput) { 2061 0 :
m_msgType = TcrMessage::TX_FAILOVER; 2062 0 : m_request.reset(dataOutput)
*
void TcrMessage::addSecurityPart(int64_t connectionId, int64_t unique_id, 2558
: TcrConnection* conn)
*
void TcrMessage::addSecurityPart(int64_t connectionId, TcrConnection* conn)
*
void TcrMessage::readEventIdPart(DataInput& input, bool skip, int32_t parts)
*
std::shared_ptr TcrMessage::readDSMember( 2874 :
apache::geode::client::DataInput& input)
*
void TcrMessage::readHashMapForGCVersions( 2904 :
apache::geode::client::DataInput& input, 2905 :
std::shared_ptr& value)
*
void TcrMessage::readHashSetForGCVersions(2937 :
apache::geode::client::DataInput& input,2938 :
std::shared_ptr& value)
*
lcov results are shown in the attachments
was:
Significant pieces of code in TcrMessage are not being tested. New tests should
be written to test the following:
* inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
* inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336
: uint8_t isLastChunk)
* void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
*
void TcrMessage::readOldValue(DataInput& input)
*
void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
*
inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227
:bool defaultString)
*
void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes,
884 : int32_t len, 885
: uint8_t
isLastChunkAndSecurityHeader)
*
void TcrMessage::handleByteArrayResponse( 896 : const char*
bytearray, int32_t len, uint16_t endpointMemId, 897 : const
SerializationRegistry& serializationRegistry, 898 :
MemberListForVersionStamp& memberListForVersionStamp)
*
TcrMessageClearRegion::TcrMessageClearRegion(1401 :
DataOutput* dataOutput, const Region* region,1402 : const
std::shared_ptr& aCallbackArgument,1403 :
std::chrono::milliseconds messageResponsetimeout,1404 6 :
ThinClientBaseDM* connectionDM)
*
TcrMessageGetDurableCqs::TcrMessageGetDurableCqs(1599 0 :
DataOutput* dataOutput, ThinClientBaseDM* connectionDM) {1600 0 :
m_request.reset(dataOutput)
*
TcrMessageCreateRegion::TcrMessageCreateRegion(1938 :
DataOutput* dataOutput, const std::string& str1, const std::string& str2,
1939 0 : bool isDurable, bool receiveValues, ThinClientBaseDM*
connectionDM)
*
TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
dataOutput,2015 :
int ordinal, int txid,2016 0 :
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-5837:
---
Attachment: (was: TcrMessage.cpp.gcov.html)
> Create New Tests to Fix Coverage Holes in TcrMessage
>
>
> Key: GEODE-5837
> URL: https://issues.apache.org/jira/browse/GEODE-5837
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Michael Martell
>Priority: Major
>
> Significant pieces of code in TcrMessage are not being tested. New tests
> should be written to test the following:
> * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
> DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
> const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
> * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
> DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen,
> 1336 : uint8_t isLastChunk)
> * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
> uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
> *
> void TcrMessage::readOldValue(DataInput& input)
> *
> void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
> *
> inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227 : bool
> defaultString)
> *
> void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes, 884
> : int32_t len, 885 : uint8_t isLastChunkAndSecurityHeader)
> *
> void TcrMessage::handleByteArrayResponse( 896 : const char* bytearray,
> int32_t len, uint16_t endpointMemId, 897 : const SerializationRegistry&
> serializationRegistry, 898 : MemberListForVersionStamp&
> memberListForVersionStamp)
> *
> TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
> dataOutput, 2015 : int ordinal, int txid, 2016 0 : int status)
> *
> TcrMessageTxFailover::TcrMessageTxFailover(DataOutput* dataOutput) { 2061 0
> : m_msgType = TcrMessage::TX_FAILOVER; 2062 0 : m_request.reset(dataOutput)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, int64_t unique_id,
> 2558 : TcrConnection* conn)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, TcrConnection* conn)
> *
> void TcrMessage::readEventIdPart(DataInput& input, bool skip, int32_t parts)
> *
> std::shared_ptr TcrMessage::readDSMember( 2874 :
> apache::geode::client::DataInput& input)
> *
> void TcrMessage::readHashMapForGCVersions( 2904 :
> apache::geode::client::DataInput& input, 2905 :
> std::shared_ptr& value)
> *
> void TcrMessage::readHashSetForGCVersions(2937 :
> apache::geode::client::DataInput& input,2938 :
> std::shared_ptr& value)
> *
> lcov results are shown in the attachments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-5837:
---
Attachment: (was: TcrMessage.hpp.gcov.html)
> Create New Tests to Fix Coverage Holes in TcrMessage
>
>
> Key: GEODE-5837
> URL: https://issues.apache.org/jira/browse/GEODE-5837
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Michael Martell
>Priority: Major
>
> Significant pieces of code in TcrMessage are not being tested. New tests
> should be written to test the following:
> * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
> DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
> const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
> * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
> DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen,
> 1336 : uint8_t isLastChunk)
> * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
> uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
> *
> void TcrMessage::readOldValue(DataInput& input)
> *
> void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
> *
> inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227 : bool
> defaultString)
> *
> void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes, 884
> : int32_t len, 885 : uint8_t isLastChunkAndSecurityHeader)
> *
> void TcrMessage::handleByteArrayResponse( 896 : const char* bytearray,
> int32_t len, uint16_t endpointMemId, 897 : const SerializationRegistry&
> serializationRegistry, 898 : MemberListForVersionStamp&
> memberListForVersionStamp)
> *
> TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
> dataOutput, 2015 : int ordinal, int txid, 2016 0 : int status)
> *
> TcrMessageTxFailover::TcrMessageTxFailover(DataOutput* dataOutput) { 2061 0
> : m_msgType = TcrMessage::TX_FAILOVER; 2062 0 : m_request.reset(dataOutput)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, int64_t unique_id,
> 2558 : TcrConnection* conn)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, TcrConnection* conn)
> *
> void TcrMessage::readEventIdPart(DataInput& input, bool skip, int32_t parts)
> *
> std::shared_ptr TcrMessage::readDSMember( 2874 :
> apache::geode::client::DataInput& input)
> *
> void TcrMessage::readHashMapForGCVersions( 2904 :
> apache::geode::client::DataInput& input, 2905 :
> std::shared_ptr& value)
> *
> void TcrMessage::readHashSetForGCVersions(2937 :
> apache::geode::client::DataInput& input,2938 :
> std::shared_ptr& value)
> *
> lcov results are shown in the attachments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-5837:
---
Attachment: TcrMessage.hpp.gcov.html
> Create New Tests to Fix Coverage Holes in TcrMessage
>
>
> Key: GEODE-5837
> URL: https://issues.apache.org/jira/browse/GEODE-5837
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.gcov.html
>
>
> Significant pieces of code in TcrMessage are not being tested. New tests
> should be written to test the following:
> * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
> DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
> const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
> * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
> DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen,
> 1336 : uint8_t isLastChunk)
> * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
> uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
> *
> void TcrMessage::readOldValue(DataInput& input)
> *
> void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
> *
> inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227 : bool
> defaultString)
> *
> void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes, 884
> : int32_t len, 885 : uint8_t isLastChunkAndSecurityHeader)
> *
> void TcrMessage::handleByteArrayResponse( 896 : const char* bytearray,
> int32_t len, uint16_t endpointMemId, 897 : const SerializationRegistry&
> serializationRegistry, 898 : MemberListForVersionStamp&
> memberListForVersionStamp)
> *
> TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
> dataOutput, 2015 : int ordinal, int txid, 2016 0 : int status)
> *
> TcrMessageTxFailover::TcrMessageTxFailover(DataOutput* dataOutput) { 2061 0
> : m_msgType = TcrMessage::TX_FAILOVER; 2062 0 : m_request.reset(dataOutput)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, int64_t unique_id,
> 2558 : TcrConnection* conn)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, TcrConnection* conn)
> *
> void TcrMessage::readEventIdPart(DataInput& input, bool skip, int32_t parts)
> *
> std::shared_ptr TcrMessage::readDSMember( 2874 :
> apache::geode::client::DataInput& input)
> *
> void TcrMessage::readHashMapForGCVersions( 2904 :
> apache::geode::client::DataInput& input, 2905 :
> std::shared_ptr& value)
> *
> void TcrMessage::readHashSetForGCVersions(2937 :
> apache::geode::client::DataInput& input,2938 :
> std::shared_ptr& value)
> *
> lcov results are shown in the attachments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-5837) Create New Tests to Fix Coverage Holes in TcrMessage
[
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Martell updated GEODE-5837:
---
Attachment: TcrMessage.cpp.gcov.html
> Create New Tests to Fix Coverage Holes in TcrMessage
>
>
> Key: GEODE-5837
> URL: https://issues.apache.org/jira/browse/GEODE-5837
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Michael Martell
>Priority: Major
> Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.gcov.html
>
>
> Significant pieces of code in TcrMessage are not being tested. New tests
> should be written to test the following:
> * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg,
> DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType,
> const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
> * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg,
> DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen,
> 1336 : uint8_t isLastChunk)
> * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 :
> uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
> *
> void TcrMessage::readOldValue(DataInput& input)
> *
> void TcrMessage::readLongPart(DataInput& input, uint64_t* intValue)
> *
> inline void TcrMessage::readCallbackObjectPart(DataInput& input, 227 : bool
> defaultString)
> *
> void TcrMessage::chunkSecurityHeader(int skipPart, const uint8_t* bytes, 884
> : int32_t len, 885 : uint8_t isLastChunkAndSecurityHeader)
> *
> void TcrMessage::handleByteArrayResponse( 896 : const char* bytearray,
> int32_t len, uint16_t endpointMemId, 897 : const SerializationRegistry&
> serializationRegistry, 898 : MemberListForVersionStamp&
> memberListForVersionStamp)
> *
> TcrMessageTxSynchronization::TcrMessageTxSynchronization(DataOutput*
> dataOutput, 2015 : int ordinal, int txid, 2016 0 : int status)
> *
> TcrMessageTxFailover::TcrMessageTxFailover(DataOutput* dataOutput) { 2061 0
> : m_msgType = TcrMessage::TX_FAILOVER; 2062 0 : m_request.reset(dataOutput)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, int64_t unique_id,
> 2558 : TcrConnection* conn)
> *
> void TcrMessage::addSecurityPart(int64_t connectionId, TcrConnection* conn)
> *
> void TcrMessage::readEventIdPart(DataInput& input, bool skip, int32_t parts)
> *
> std::shared_ptr TcrMessage::readDSMember( 2874 :
> apache::geode::client::DataInput& input)
> *
> void TcrMessage::readHashMapForGCVersions( 2904 :
> apache::geode::client::DataInput& input, 2905 :
> std::shared_ptr& value)
> *
> void TcrMessage::readHashSetForGCVersions(2937 :
> apache::geode::client::DataInput& input,2938 :
> std::shared_ptr& value)
> *
> lcov results are shown in the attachments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
