[jira] [Resolved] (GEODE-10377) Add getter for CacheServiceProfile list to CacheDistributionAdvisor
[ https://issues.apache.org/jira/browse/GEODE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-10377. Resolution: Won't Do Instead of using a getter, extensions will use reflection. > Add getter for CacheServiceProfile list to CacheDistributionAdvisor > --- > > Key: GEODE-10377 > URL: https://issues.apache.org/jira/browse/GEODE-10377 > Project: Geode > Issue Type: New Feature > Components: core >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > > Clients of CacheDistributionAdvisor could use this feature to determine > features of members of the cluster. For example, the version of extensions on > other members could be determined, enhancing forward and backward > compatibility to simplify rolling upgrades of extensions. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (GEODE-10377) Add getter for CacheServiceProfile list to CacheDistributionAdvisor
[ https://issues.apache.org/jira/browse/GEODE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-10377: -- Assignee: Ray Ingles > Add getter for CacheServiceProfile list to CacheDistributionAdvisor > --- > > Key: GEODE-10377 > URL: https://issues.apache.org/jira/browse/GEODE-10377 > Project: Geode > Issue Type: New Feature > Components: core >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.15.0, needsTriage > > Clients of CacheDistributionAdvisor could use this feature to determine > features of members of the cluster. For example, the version of extensions on > other members could be determined, enhancing forward and backward > compatibility to simplify rolling upgrades of extensions. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (GEODE-10377) Add getter for CacheServiceProfile list to CacheDistributionAdvisor
[ https://issues.apache.org/jira/browse/GEODE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles updated GEODE-10377: --- Labels: blocks-1.15.0 needsTriage (was: needsTriage) > Add getter for CacheServiceProfile list to CacheDistributionAdvisor > --- > > Key: GEODE-10377 > URL: https://issues.apache.org/jira/browse/GEODE-10377 > Project: Geode > Issue Type: New Feature > Components: core >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Major > Labels: blocks-1.15.0, needsTriage > > Clients of CacheDistributionAdvisor could use this feature to determine > features of members of the cluster. For example, the version of extensions on > other members could be determined, enhancing forward and backward > compatibility to simplify rolling upgrades of extensions. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (GEODE-10377) Add getter for CacheServiceProfile list to CacheDistributionAdvisor
[ https://issues.apache.org/jira/browse/GEODE-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles updated GEODE-10377: --- Labels: needsTriage (was: ) > Add getter for CacheServiceProfile list to CacheDistributionAdvisor > --- > > Key: GEODE-10377 > URL: https://issues.apache.org/jira/browse/GEODE-10377 > Project: Geode > Issue Type: New Feature > Components: core >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Major > Labels: needsTriage > > Clients of CacheDistributionAdvisor could use this feature to determine > features of members of the cluster. For example, the version of extensions on > other members could be determined, enhancing forward and backward > compatibility to simplify rolling upgrades of extensions. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (GEODE-10377) Add getter for CacheServiceProfile list to CacheDistributionAdvisor
Ray Ingles created GEODE-10377: -- Summary: Add getter for CacheServiceProfile list to CacheDistributionAdvisor Key: GEODE-10377 URL: https://issues.apache.org/jira/browse/GEODE-10377 Project: Geode Issue Type: New Feature Components: core Affects Versions: 1.15.0 Reporter: Ray Ingles Clients of CacheDistributionAdvisor could use this feature to determine features of members of the cluster. For example, the version of extensions on other members could be determined, enhancing forward and backward compatibility to simplify rolling upgrades of extensions. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (GEODE-10157) Add unit tests for all Delta classes in package org.apache.geode.redis.internal.data
[
https://issues.apache.org/jira/browse/GEODE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles resolved GEODE-10157.
Fix Version/s: 1.15.0
Resolution: Fixed
Tests for all Redis delta types.
> Add unit tests for all Delta classes in package
> org.apache.geode.redis.internal.data
>
>
> Key: GEODE-10157
> URL: https://issues.apache.org/jira/browse/GEODE-10157
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Jens Deppe
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> Expand on tests in
> {{org.apache.geode.redis.internal.data.DeltaClassesJUnitTest}} for all other
> delta-related classes in this package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (GEODE-10157) Add unit tests for all Delta classes in package org.apache.geode.redis.internal.data
[
https://issues.apache.org/jira/browse/GEODE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles reassigned GEODE-10157:
--
Assignee: Ray Ingles
> Add unit tests for all Delta classes in package
> org.apache.geode.redis.internal.data
>
>
> Key: GEODE-10157
> URL: https://issues.apache.org/jira/browse/GEODE-10157
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Jens Deppe
>Assignee: Ray Ingles
>Priority: Major
>
> Expand on tests in
> {{org.apache.geode.redis.internal.data.DeltaClassesJUnitTest}} for all other
> delta-related classes in this package.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-10116) Enable native Redis TCL tests for List data type
[ https://issues.apache.org/jira/browse/GEODE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-10116. Fix Version/s: 1.15.0 Resolution: Fixed Enabled all currently-available Redis List TCL tests. > Enable native Redis TCL tests for List data type > > > Key: GEODE-10116 > URL: https://issues.apache.org/jira/browse/GEODE-10116 > Project: Geode > Issue Type: Improvement >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > The native redis TCL-based test suite has several tests for the List data > type, which should be enabled when Geode-for-Redis support is sufficient to > support them. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-10116) Enable native Redis TCL tests for List data type
[ https://issues.apache.org/jira/browse/GEODE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-10116: -- Assignee: Ray Ingles > Enable native Redis TCL tests for List data type > > > Key: GEODE-10116 > URL: https://issues.apache.org/jira/browse/GEODE-10116 > Project: Geode > Issue Type: Improvement >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > > The native redis TCL-based test suite has several tests for the List data > type, which should be enabled when Geode-for-Redis support is sufficient to > support them. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9953) Implement LTRIM
[ https://issues.apache.org/jira/browse/GEODE-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9953. --- Fix Version/s: 1.15.0 Resolution: Fixed Implement LTRIM with associated tests. > Implement LTRIM > --- > > Key: GEODE-9953 > URL: https://issues.apache.org/jira/browse/GEODE-9953 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Implement the [LTRIM|https://redis.io/commands/ltrim] command. > > +Acceptance Criteria+ > The command has been implemented along with appropriate unit and system tests. > > The command has been tested using the redis-cli tool and verified against > native redis. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-9953) Implement LTRIM
[ https://issues.apache.org/jira/browse/GEODE-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9953: - Assignee: Ray Ingles > Implement LTRIM > --- > > Key: GEODE-9953 > URL: https://issues.apache.org/jira/browse/GEODE-9953 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > > Implement the [LTRIM|https://redis.io/commands/ltrim] command. > > +Acceptance Criteria+ > The command has been implemented along with appropriate unit and system tests. > > The command has been tested using the redis-cli tool and verified against > native redis. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10204) Add test cases for SizeableByteArray
Ray Ingles created GEODE-10204: -- Summary: Add test cases for SizeableByteArray Key: GEODE-10204 URL: https://issues.apache.org/jira/browse/GEODE-10204 Project: Geode Issue Type: Test Components: redis Reporter: Ray Ingles For example, clearSublist() was added for LTRIM support and needs tests. Any public method without tests should have coverage. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10198) LINSERT is case-sensitive for arguments
Ray Ingles created GEODE-10198: -- Summary: LINSERT is case-sensitive for arguments Key: GEODE-10198 URL: https://issues.apache.org/jira/browse/GEODE-10198 Project: Geode Issue Type: Bug Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles Qualifier arguments for LINSERT (e.g. BEFORE, AFTER) are only recognized if they are uppercased. Native Redis is not case-sensitive with respect to these arguments. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10194) Redis LSET against nonexistent key produces incorrect error
[ https://issues.apache.org/jira/browse/GEODE-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-10194. Resolution: Won't Fix When a command causes multiple errors, the specific error returned is not critical. > Redis LSET against nonexistent key produces incorrect error > --- > > Key: GEODE-10194 > URL: https://issues.apache.org/jira/browse/GEODE-10194 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: needsTriage > > When the command "lset nosuchkey 10 foo" is run against Geode for Redis, it > produces the error: > ERR index out of range > but it should produce the error: > ERR no such key -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-10194) Redis LSET against nonexistent key produces incorrect error
[ https://issues.apache.org/jira/browse/GEODE-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-10194: -- Assignee: Ray Ingles > Redis LSET against nonexistent key produces incorrect error > --- > > Key: GEODE-10194 > URL: https://issues.apache.org/jira/browse/GEODE-10194 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: needsTriage > > When the command "lset nosuchkey 10 foo" is run against Geode for Redis, it > produces the error: > ERR index out of range > but it should produce the error: > ERR no such key -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10194) Redis LSET against nonexistent key produces incorrect error
Ray Ingles created GEODE-10194: -- Summary: Redis LSET against nonexistent key produces incorrect error Key: GEODE-10194 URL: https://issues.apache.org/jira/browse/GEODE-10194 Project: Geode Issue Type: Bug Components: redis Reporter: Ray Ingles When the command "lset nosuchkey 10 foo" is run against Geode for Redis, it produces the error: ERR index out of range but it should produce the error: ERR no such key -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-9967) The Geode wiki page about the "Redis Adaptor" should be updated
[ https://issues.apache.org/jira/browse/GEODE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9967: - Assignee: Ray Ingles > The Geode wiki page about the "Redis Adaptor" should be updated > --- > > Key: GEODE-9967 > URL: https://issues.apache.org/jira/browse/GEODE-9967 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Eric Zoerner >Assignee: Ray Ingles >Priority: Major > > This wiki page is out of date for the 1.15 release and should be updated: > https://cwiki.apache.org/confluence/display/GEODE/Geode+Redis+Adapter -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-10116) Enable native Redis TCL tests for List data type
Ray Ingles created GEODE-10116: -- Summary: Enable native Redis TCL tests for List data type Key: GEODE-10116 URL: https://issues.apache.org/jira/browse/GEODE-10116 Project: Geode Issue Type: Improvement Reporter: Ray Ingles The native redis TCL-based test suite has several tests for the List data type, which should be enabled when Geode-for-Redis support is sufficient to support them. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9892) Create Infrastructure for Redis Lists
[ https://issues.apache.org/jira/browse/GEODE-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9892. --- Fix Version/s: 1.16.0 Resolution: Fixed Adds LPUSH, LPOP, and LLEN Redis commands, with associated data structures. > Create Infrastructure for Redis Lists > - > > Key: GEODE-9892 > URL: https://issues.apache.org/jira/browse/GEODE-9892 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.16.0 > > > Create the infrastructure for supporting Redis Lists including: > * Use of the appropriate underlying Java collection > * Implementing the [LPUSH|https://redis.io/commands/lpush] Command > * Implementing the [LRANGE|https://redis.io/commands/lrange] command > +Acceptance Critera+ > The LPUSH and LRANGE commands have been implemented with appropriate unit > testing. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-10013) Remove unused code in Geode for Redis tests
[ https://issues.apache.org/jira/browse/GEODE-10013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-10013. Fix Version/s: 1.16.0 Resolution: Fixed Small cleanup of unneeded test code. > Remove unused code in Geode for Redis tests > --- > > Key: GEODE-10013 > URL: https://issues.apache.org/jira/browse/GEODE-10013 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.16.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.16.0 > > > Several Geode for Redis tests contain redundant server.stop() calls and > unnecessary "canStoreBinaryData" tests. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-10013) Remove unused code in Geode for Redis tests
[ https://issues.apache.org/jira/browse/GEODE-10013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-10013: -- Assignee: Ray Ingles > Remove unused code in Geode for Redis tests > --- > > Key: GEODE-10013 > URL: https://issues.apache.org/jira/browse/GEODE-10013 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.16.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > > Several Geode for Redis tests contain redundant server.stop() calls and > unnecessary "canStoreBinaryData" tests. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (GEODE-10005) Upgrade to Eclipse Jetty 11.0.x
[
https://issues.apache.org/jira/browse/GEODE-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles updated GEODE-10005:
---
Priority: Minor (was: Blocker)
> Upgrade to Eclipse Jetty 11.0.x
> ---
>
> Key: GEODE-10005
> URL: https://issues.apache.org/jira/browse/GEODE-10005
> Project: Geode
> Issue Type: Improvement
>Reporter: John Blum
>Priority: Minor
>
> In order to release _Spring Boot for Apache Geode_ (SBDG) {{2.0}}, based on
> _Spring Boot_ {{3.0}}, the transitive dependency must minimally match _Spring
> Boot's_ minimum [(major.mionr)
> version|https://github.com/spring-projects/spring-boot/blob/v3.0.0-M1/spring-boot-project/spring-boot-dependencies/build.gradle#L645-L651]
> requirement for *Eclipse Jetty*.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (GEODE-10005) Upgrade to Eclipse Jetty 11.0.x
[
https://issues.apache.org/jira/browse/GEODE-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles updated GEODE-10005:
---
Priority: Blocker (was: Minor)
> Upgrade to Eclipse Jetty 11.0.x
> ---
>
> Key: GEODE-10005
> URL: https://issues.apache.org/jira/browse/GEODE-10005
> Project: Geode
> Issue Type: Improvement
>Reporter: John Blum
>Priority: Blocker
>
> In order to release _Spring Boot for Apache Geode_ (SBDG) {{2.0}}, based on
> _Spring Boot_ {{3.0}}, the transitive dependency must minimally match _Spring
> Boot's_ minimum [(major.mionr)
> version|https://github.com/spring-projects/spring-boot/blob/v3.0.0-M1/spring-boot-project/spring-boot-dependencies/build.gradle#L645-L651]
> requirement for *Eclipse Jetty*.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-10013) Remove unused code in Geode for Redis tests
Ray Ingles created GEODE-10013: -- Summary: Remove unused code in Geode for Redis tests Key: GEODE-10013 URL: https://issues.apache.org/jira/browse/GEODE-10013 Project: Geode Issue Type: Improvement Components: redis Affects Versions: 1.16.0 Reporter: Ray Ingles Several Geode for Redis tests contain redundant server.stop() calls and unnecessary "canStoreBinaryData" tests. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9528) CI Failure: DistributionAdvisorIntegrationTest > verifyMembershipListenerIsRemovedAfterForceDisconnect
[
https://issues.apache.org/jira/browse/GEODE-9528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles resolved GEODE-9528.
---
Resolution: Fixed
No current plans to backport.
> CI Failure: DistributionAdvisorIntegrationTest >
> verifyMembershipListenerIsRemovedAfterForceDisconnect
> --
>
> Key: GEODE-9528
> URL: https://issues.apache.org/jira/browse/GEODE-9528
> Project: Geode
> Issue Type: Bug
> Components: membership
>Affects Versions: 1.12.5, 1.13.5, 1.14.0
>Reporter: Owen Nichols
>Assignee: Barrett Oglesby
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> {noformat}
> org.apache.geode.distributed.internal.DistributionAdvisorIntegrationTest >
> verifyMembershipListenerIsRemovedAfterForceDisconnect FAILED
> org.junit.ComparisonFailure: expected:<[fals]e> but was:<[tru]e>
> at
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.distributed.internal.DistributionAdvisorIntegrationTest.verifyMembershipListenerIsRemovedAfterForceDisconnect(DistributionAdvisorIntegrationTest.java:57)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (GEODE-9528) CI Failure: DistributionAdvisorIntegrationTest > verifyMembershipListenerIsRemovedAfterForceDisconnect
[
https://issues.apache.org/jira/browse/GEODE-9528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles reopened GEODE-9528:
---
Seems to be showing up in CI still
> CI Failure: DistributionAdvisorIntegrationTest >
> verifyMembershipListenerIsRemovedAfterForceDisconnect
> --
>
> Key: GEODE-9528
> URL: https://issues.apache.org/jira/browse/GEODE-9528
> Project: Geode
> Issue Type: Bug
> Components: membership
>Affects Versions: 1.12.5, 1.13.5, 1.14.0
>Reporter: Owen Nichols
>Assignee: Barrett Oglesby
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> {noformat}
> org.apache.geode.distributed.internal.DistributionAdvisorIntegrationTest >
> verifyMembershipListenerIsRemovedAfterForceDisconnect FAILED
> org.junit.ComparisonFailure: expected:<[fals]e> but was:<[tru]e>
> at
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.distributed.internal.DistributionAdvisorIntegrationTest.verifyMembershipListenerIsRemovedAfterForceDisconnect(DistributionAdvisorIntegrationTest.java:57)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (GEODE-9892) Create Infrastructure for Redis Lists
[ https://issues.apache.org/jira/browse/GEODE-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9892: - Assignee: Ray Ingles > Create Infrastructure for Redis Lists > - > > Key: GEODE-9892 > URL: https://issues.apache.org/jira/browse/GEODE-9892 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > > Create the infrastructure for supporting Redis Lists including: > * Use of the appropriate underlying Java collection > * Implementing the [LPUSH|https://redis.io/commands/lpush] Command > * Implementing the [LRANGE|https://redis.io/commands/lrange] command > +Acceptance Critera+ > The LPUSH and LRANGE commands have been implemented with appropriate unit > testing. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (GEODE-9869) Remove redis-related options from gfsh commands
[
https://issues.apache.org/jira/browse/GEODE-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles reassigned GEODE-9869:
-
Assignee: Ray Ingles
> Remove redis-related options from gfsh commands
> ---
>
> Key: GEODE-9869
> URL: https://issues.apache.org/jira/browse/GEODE-9869
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, redis
>Reporter: Jens Deppe
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
>
> To work towards Geode modularity, remove the redis-related options from gfsh
> commands. Specifically {{gfsh start server}} supports:
> * {{--geode-for-redis-port}}
> * {{--geode-for-redis-bind-address}}
> * {{--geode-for-redis-username}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9869) Remove redis-related options from gfsh commands
[
https://issues.apache.org/jira/browse/GEODE-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles resolved GEODE-9869.
---
Fix Version/s: 1.15.0
Resolution: Fixed
Remove the GFSH options related to geode-for-redis and update docs, examples,
and tests to set such options via Java properties.
> Remove redis-related options from gfsh commands
> ---
>
> Key: GEODE-9869
> URL: https://issues.apache.org/jira/browse/GEODE-9869
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, redis
>Reporter: Jens Deppe
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> To work towards Geode modularity, remove the redis-related options from gfsh
> commands. Specifically {{gfsh start server}} supports:
> * {{--geode-for-redis-port}}
> * {{--geode-for-redis-bind-address}}
> * {{--geode-for-redis-username}}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9917) CI Failure: (Windows) ManagementAdapterTest > testHandlingNotificationsConcurrently
Ray Ingles created GEODE-9917:
-
Summary: CI Failure: (Windows) ManagementAdapterTest >
testHandlingNotificationsConcurrently
Key: GEODE-9917
URL: https://issues.apache.org/jira/browse/GEODE-9917
Project: Geode
Issue Type: Bug
Components: management
Affects Versions: 1.15.0
Reporter: Ray Ingles
{{> Task :geode-core:integrationTest
ManagementAdapterTest > testHandlingNotificationsConcurrently FAILED
java.lang.RuntimeException: java.util.concurrent.TimeoutException
at
org.apache.geode.test.junit.rules.ConcurrencyRule$ProtectedErrorCollector.verify(ConcurrencyRule.java:489)
at
org.apache.geode.test.junit.rules.ConcurrencyRule.executeInParallel(ConcurrencyRule.java:154)
at
org.apache.geode.management.internal.beans.ManagementAdapterTest.testHandlingNotificationsConcurrently(ManagementAdapterTest.java:122)
Caused by:
java.util.concurrent.TimeoutException
at java.util.concurrent.FutureTask.get(FutureTask.java:204)
at
org.apache.geode.test.junit.rules.ConcurrencyRule.awaitFuture(ConcurrencyRule.java:227)
at
org.apache.geode.test.junit.rules.ConcurrencyRule.awaitFutures(ConcurrencyRule.java:219)
at
org.apache.geode.test.junit.rules.ConcurrencyRule.executeInParallel(ConcurrencyRule.java:153)
... 1 more}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9916) CI Failure: RestAPIOnRegionFunctionExecutionDUnitTest > testOnRegionExecutionWithPartitionRegion
Ray Ingles created GEODE-9916:
-
Summary: CI Failure: RestAPIOnRegionFunctionExecutionDUnitTest >
testOnRegionExecutionWithPartitionRegion
Key: GEODE-9916
URL: https://issues.apache.org/jira/browse/GEODE-9916
Project: Geode
Issue Type: Bug
Components: rest (dev)
Affects Versions: 1.15.0
Reporter: Ray Ingles
See related test artifacts.
{{RestAPIOnRegionFunctionExecutionDUnitTest >
testOnRegionExecutionWithPartitionRegion[1] FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.test.dunit.internal.IdentifiableCallable.call in VM 0 running
on Host
heavy-lifter-ffd951ad-1cd6-50b7-9fe2-e85ab1050b68.c.apachegeode-ci.internal
with 4 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
at org.apache.geode.test.dunit.VM.invoke(VM.java:461)
at
org.apache.geode.rest.internal.web.controllers.RestAPIOnRegionFunctionExecutionDUnitTest.createCacheAndRegisterFunction(RestAPIOnRegionFunctionExecutionDUnitTest.java:135)
at
org.apache.geode.rest.internal.web.controllers.RestAPIOnRegionFunctionExecutionDUnitTest.testOnRegionExecutionWithPartitionRegion(RestAPIOnRegionFunctionExecutionDUnitTest.java:178)
Caused by:
java.lang.IllegalStateException: A connection to a distributed system
already exists in this VM. It has the following configuration:
ack-severe-alert-threshold="0"}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9915) CI Failure: PersistentPartitionedRegionDistributedTest > testCacheCloseDuringBucketMoveDoesntCauseDataLoss
Ray Ingles created GEODE-9915: - Summary: CI Failure: PersistentPartitionedRegionDistributedTest > testCacheCloseDuringBucketMoveDoesntCauseDataLoss Key: GEODE-9915 URL: https://issues.apache.org/jira/browse/GEODE-9915 Project: Geode Issue Type: Bug Components: tests Reporter: Ray Ingles NPE during execution, see linked test artifacts. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (GEODE-9914) CI Failures: JmxServerReconnectDistributedTest
Ray Ingles created GEODE-9914: - Summary: CI Failures: JmxServerReconnectDistributedTest Key: GEODE-9914 URL: https://issues.apache.org/jira/browse/GEODE-9914 Project: Geode Issue Type: Bug Components: jmx Affects Versions: 1.14.0, 1.13.0, 1.15.0 Reporter: Ray Ingles Multiple failures in the latest regression in different places. Possibly related to bumping versions of dependencies due to Log4j bug fixes? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (GEODE-9716) ZRemRangeByScoreDUnitTest.zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown fails intermittently
[
https://issues.apache.org/jira/browse/GEODE-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles resolved GEODE-9716.
---
Fix Version/s: 1.15.0
Resolution: Fixed
Added extra debug info to help narrow down issue if it happens again.
> ZRemRangeByScoreDUnitTest.zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown
> fails intermittently
> ---
>
> Key: GEODE-9716
> URL: https://issues.apache.org/jira/browse/GEODE-9716
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Hale Bales
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown fails rarely
> with the following stack trace:
> {code:java}
> ZRemRangeByScoreDUnitTest >
> zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown FAILED
> org.opentest4j.AssertionFailedError:
> expected: 500L
> but was: 0L
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.sortedset.ZRemRangeByScoreDUnitTest.zRemRangeByScoreWithRetries(ZRemRangeByScoreDUnitTest.java:253)
> at
> org.apache.geode.redis.internal.executor.sortedset.ZRemRangeByScoreDUnitTest.doZRemRangeByScoreWithRetries(ZRemRangeByScoreDUnitTest.java:237)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (GEODE-9716) ZRemRangeByScoreDUnitTest.zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown fails intermittently
[
https://issues.apache.org/jira/browse/GEODE-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles reassigned GEODE-9716:
-
Assignee: Ray Ingles (was: Hale Bales)
> ZRemRangeByScoreDUnitTest.zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown
> fails intermittently
> ---
>
> Key: GEODE-9716
> URL: https://issues.apache.org/jira/browse/GEODE-9716
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Hale Bales
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
>
> zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown fails rarely
> with the following stack trace:
> {code:java}
> ZRemRangeByScoreDUnitTest >
> zRemRangeByScoreRemovesMembersFromSortedSetAfterPrimaryShutsDown FAILED
> org.opentest4j.AssertionFailedError:
> expected: 500L
> but was: 0L
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.sortedset.ZRemRangeByScoreDUnitTest.zRemRangeByScoreWithRetries(ZRemRangeByScoreDUnitTest.java:253)
> at
> org.apache.geode.redis.internal.executor.sortedset.ZRemRangeByScoreDUnitTest.doZRemRangeByScoreWithRetries(ZRemRangeByScoreDUnitTest.java:237)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9895) CI Failure: ConnectionPoolDUnitTest > basicTestLifetimeExpire
Ray Ingles created GEODE-9895:
-
Summary: CI Failure: ConnectionPoolDUnitTest >
basicTestLifetimeExpire
Key: GEODE-9895
URL: https://issues.apache.org/jira/browse/GEODE-9895
Project: Geode
Issue Type: Bug
Components: client/server
Affects Versions: 1.15.0
Reporter: Ray Ingles
{{ConnectionPoolDUnitTest > basicTestLifetimeExpire FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.test.dunit.internal.IdentifiableRunnable.run in VM 2 running
on Host
heavy-lifter-8ad734f8-fc08-5ba3-bad2-7388aa23c427.c.apachegeode-ci.internal
with 4 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
at org.apache.geode.test.dunit.VM.invoke(VM.java:435)
at
org.apache.geode.cache.ConnectionPoolDUnitTest.basicTestLifetimeExpire(ConnectionPoolDUnitTest.java:813)
Caused by:
org.apache.geode.cache.client.ServerOperationException: remote server
on
heavy-lifter-8ad734f8-fc08-5ba3-bad2-7388aa23c427(121494:loner):40384:38a873a8:
: While performing a remote put
at
org.apache.geode.cache.client.internal.PutOp$PutOpImpl.processAck(PutOp.java:372)
at
org.apache.geode.cache.client.internal.PutOp$PutOpImpl.processResponse(PutOp.java:274)
at
org.apache.geode.cache.client.internal.AbstractOp.attemptReadResponse(AbstractOp.java:221)
at
org.apache.geode.cache.client.internal.AbstractOp.attempt(AbstractOp.java:394)
at
org.apache.geode.cache.client.internal.ConnectionImpl.execute(ConnectionImpl.java:284)
at
org.apache.geode.cache.client.internal.pooling.PooledConnection.execute(PooledConnection.java:358)
at
org.apache.geode.cache.client.internal.OpExecutorImpl.executeWithPossibleReAuthentication(OpExecutorImpl.java:760)
at
org.apache.geode.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:151)
at
org.apache.geode.cache.client.internal.OpExecutorImpl.execute(OpExecutorImpl.java:120)
at
org.apache.geode.cache.client.internal.PoolImpl.execute(PoolImpl.java:805)
at
org.apache.geode.cache.client.internal.PutOp.execute(PutOp.java:92)
at
org.apache.geode.cache.client.internal.ServerRegionProxy.put(ServerRegionProxy.java:158)
at
org.apache.geode.internal.cache.LocalRegion.serverPut(LocalRegion.java:3045)
at
org.apache.geode.internal.cache.LocalRegion.cacheWriteBeforePut(LocalRegion.java:3160)
at
org.apache.geode.internal.cache.map.RegionMapPut.invokeCacheWriter(RegionMapPut.java:244)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutIfPreconditionsSatisified(AbstractRegionMapPut.java:295)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutOnSynchronizedRegionEntry(AbstractRegionMapPut.java:282)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutOnRegionEntryInMap(AbstractRegionMapPut.java:273)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.addRegionEntryToMapAndDoPut(AbstractRegionMapPut.java:251)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPutRetryingIfNeeded(AbstractRegionMapPut.java:216)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doWithIndexInUpdateMode(AbstractRegionMapPut.java:198)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:180)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
at
org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
at
org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
at
org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2045)
at
org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5615)
at
org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5593)
at
org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
at
org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5050)
at
org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1646)
at
org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1633)
at
org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:445)
at
org.apache.geode.cache.ConnectionPoolDUnitTest.lambda$basicTestLifetimeExpire$f09ad7da$1(ConnectionPoolDUnitTest.java:825)
Caused by:
org.apache.geode.cache.RegionDestroyedException: Server connection
from [id
[jira] [Created] (GEODE-9894) CI Failure: RedundancyLevelPart1DUnitTest > testRedundancySpecifiedNonPrimaryEPFailsDetectionByUnregisterInterest
Ray Ingles created GEODE-9894:
-
Summary: CI Failure: RedundancyLevelPart1DUnitTest >
testRedundancySpecifiedNonPrimaryEPFailsDetectionByUnregisterInterest
Key: GEODE-9894
URL: https://issues.apache.org/jira/browse/GEODE-9894
Project: Geode
Issue Type: Bug
Components: client queues, client/server
Affects Versions: 1.15.0
Reporter: Ray Ingles
{{> Task :geode-core:distributedTest
RedundancyLevelPart1DUnitTest >
testRedundancySpecifiedNonPrimaryEPFailsDetectionByUnregisterInterest FAILED
org.awaitility.core.ConditionTimeoutException: Assertion condition defined
as a org.apache.geode.internal.cache.tier.sockets.RedundancyLevelPart1DUnitTest
Expecting value to be true but was false within 5 minutes.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:939)
at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
at
org.apache.geode.internal.cache.tier.sockets.RedundancyLevelPart1DUnitTest.testRedundancySpecifiedNonPrimaryEPFailsDetectionByUnregisterInterest(RedundancyLevelPart1DUnitTest.java:326)
Caused by:
org.opentest4j.AssertionFailedError:
Expecting value to be true but was false
at sun.reflect.GeneratedConstructorAccessor25.newInstance(Unknown
Source)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.geode.internal.cache.tier.sockets.RedundancyLevelPart1DUnitTest.lambda$testRedundancySpecifiedNonPrimaryEPFailsDetectionByUnregisterInterest$13(RedundancyLevelPart1DUnitTest.java:329)}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9891) CacheStatisticsPartitionedRegionDUnitTest > testDisabledStatistics FAILED
Ray Ingles created GEODE-9891:
-
Summary: CacheStatisticsPartitionedRegionDUnitTest >
testDisabledStatistics FAILED
Key: GEODE-9891
URL: https://issues.apache.org/jira/browse/GEODE-9891
Project: Geode
Issue Type: Bug
Components: core
Affects Versions: 1.15.0
Reporter: Ray Ingles
{{> Task :geode-core:distributedTest}}
{{CacheStatisticsPartitionedRegionDUnitTest > testDisabledStatistics FAILED}}
{{org.gradle.internal.exceptions.DefaultMultiCauseException: Multiple
Failures (2 failures)}}
{{ org.apache.geode.distributed.DistributedSystemDisconnectedException:
Distribution manager on
heavy-lifter-531607ac-c474-5030-83b9-b0e677f37a36(231826):46001 started at
Sat Dec 11 19:06:24 UTC 2021: Member isn't responding to heartbeat requests}}
{{ java.lang.AssertionError: Suspicious strings were written to the log
during this run.}}
{{Fix the strings or use IgnoredException.addIgnoredException to ignore.}}
{{---}}
{{Found suspect string in 'dunit_suspect-local.log' at line 535}}
{{[fatal 2021/12/11 19:06:44.320 UTC tid=83]
Membership service failure: Member isn't responding to heartbeat requests}}
{{ ...}}
{{Caused by:}}
{{org.apache.geode.distributed.DistributedSystemDisconnectedException:
Distribution manager on
heavy-lifter-531607ac-c474-5030-83b9-b0e677f37a36(231826):46001 started at
Sat Dec 11 19:06:24 UTC 2021: Member isn't responding to heartbeat requests,
caused by org.apache.geode.ForcedDisconnectException: Member isn't responding
to heartbeat requests}}
{{...}}
{{Caused by:}}
{{org.apache.geode.ForcedDisconnectException: Member isn't
responding to heartbeat requests}}
{{at
org.apache.geode.distributed.internal.DistributionImpl$LifecycleListenerImpl.forcedDisconnect(DistributionImpl.java:941)}}
{{at
org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.lambda$uncleanShutdownDS$0(GMSMembership.java:1793)}}
{{at java.lang.Thread.run(Thread.java:748)}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9890) DistributedAckRegionCCEDUnitTest > testClearOnNonReplicateWithConcurrentEvents FAILED
Ray Ingles created GEODE-9890:
-
Summary: DistributedAckRegionCCEDUnitTest >
testClearOnNonReplicateWithConcurrentEvents FAILED
Key: GEODE-9890
URL: https://issues.apache.org/jira/browse/GEODE-9890
Project: Geode
Issue Type: Bug
Components: client/server
Affects Versions: 1.12.0
Reporter: Ray Ingles
This has similar behavior to GEODE-7702, but Gester states that the underlying
cause doesn't apply to 1.12, so we're opening up a new ticket. The error seen
is:
{{> Task :geode-core:distributedTest}}
{{org.apache.geode.cache30.DistributedAckRegionCCEDUnitTest >
testClearOnNonReplicateWithConcurrentEvents FAILED}}
{{org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a lambda expression in
org.apache.geode.cache30.MultiVMRegionTestCase expected:<[6]> but was:<[3]>
within 300 seconds.}}
{{at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)}}
{{at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:122)}}
{{at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)}}
{{at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)}}
{{at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)}}
{{at
org.apache.geode.cache30.MultiVMRegionTestCase.versionTestClearOnNonReplicateWithConcurrentEvents(MultiVMRegionTestCase.java:6447)}}
{{at
org.apache.geode.cache30.DistributedAckRegionCCEDUnitTest.testClearOnNonReplicateWithConcurrentEvents(DistributedAckRegionCCEDUnitTest.java:268)}}
{{Caused by:}}
{{org.junit.ComparisonFailure: expected:<[6]> but was:<[3]>}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (GEODE-9889) LettucePubSubIntegrationTest > subscribePsubscribeSameClient FAILED
[
https://issues.apache.org/jira/browse/GEODE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles updated GEODE-9889:
--
Description:
Seen in a CI build:
{{> Task :geode-apis-compatible-with-redis:integrationTest}}
{{org.apache.geode.redis.internal.executor.pubsub.LettucePubSubIntegrationTest
> subscribePsubscribeSameClient FAILED}}
{{org.junit.ComparisonFailure: expected:<[2]L> but was:<[0]L>}}
was:
Seen in a CI build:
{{> Task :geode-apis-compatible-with-redis:integrationTest}}
{{org.apache.geode.redis.internal.executor.pubsub.LettucePubSubIntegrationTest
> subscribePsubscribeSameClient FAILED}}
{{org.junit.ComparisonFailure: expected:<[2]L> but was:<[0]L>}}
{{770 tests completed, 1 failed, 5 skipped}}
{{=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=}}
{{[*http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.2-build.0897/test-results/integrationTest/1639264779/*]}}
{{=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=}}
{{Test report artifacts from this job are available at:}}
{{[*http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.2-build.0897/test-artifacts/1639264779/integrationtestfiles-openjdk11-1.14.2-build.0897.tgz*]}}
> LettucePubSubIntegrationTest > subscribePsubscribeSameClient FAILED
> ---
>
> Key: GEODE-9889
> URL: https://issues.apache.org/jira/browse/GEODE-9889
> Project: Geode
> Issue Type: Bug
> Components: redis
>Affects Versions: 1.14.0
>Reporter: Ray Ingles
>Priority: Major
>
> Seen in a CI build:
>
> {{> Task :geode-apis-compatible-with-redis:integrationTest}}
> {{org.apache.geode.redis.internal.executor.pubsub.LettucePubSubIntegrationTest
> > subscribePsubscribeSameClient FAILED}}
> {{org.junit.ComparisonFailure: expected:<[2]L> but was:<[0]L>}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9889) LettucePubSubIntegrationTest > subscribePsubscribeSameClient FAILED
Ray Ingles created GEODE-9889:
-
Summary: LettucePubSubIntegrationTest >
subscribePsubscribeSameClient FAILED
Key: GEODE-9889
URL: https://issues.apache.org/jira/browse/GEODE-9889
Project: Geode
Issue Type: Bug
Components: redis
Affects Versions: 1.14.0
Reporter: Ray Ingles
Seen in a CI build:
{{> Task :geode-apis-compatible-with-redis:integrationTest}}
{{org.apache.geode.redis.internal.executor.pubsub.LettucePubSubIntegrationTest
> subscribePsubscribeSameClient FAILED}}
{{org.junit.ComparisonFailure: expected:<[2]L> but was:<[0]L>}}
{{770 tests completed, 1 failed, 5 skipped}}
{{=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=}}
{{[*http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.2-build.0897/test-results/integrationTest/1639264779/*]}}
{{=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=}}
{{Test report artifacts from this job are available at:}}
{{[*http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.2-build.0897/test-artifacts/1639264779/integrationtestfiles-openjdk11-1.14.2-build.0897.tgz*]}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (GEODE-9885) StringsDUnitTest.givenBucketsMoveDuringAppend_thenDataIsNotLost fails with duplicated append
Ray Ingles created GEODE-9885:
-
Summary:
StringsDUnitTest.givenBucketsMoveDuringAppend_thenDataIsNotLost fails with
duplicated append
Key: GEODE-9885
URL: https://issues.apache.org/jira/browse/GEODE-9885
Project: Geode
Issue Type: Bug
Components: redis
Affects Versions: 1.15.0
Reporter: Ray Ingles
The test appends a lot of strings to a key. It wound up adding (at least one)
extra string to the stored string:
{{java.util.concurrent.ExecutionException: java.lang.AssertionError: unexpected
-\{append0}-key-3-27680- at index 27681 iterationCount=61995 in string}}
The string "\{append0}-key-3-27680-" appeared twice in sequence.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (GEODE-9690) Restore Redis TCL integration test patch file
[ https://issues.apache.org/jira/browse/GEODE-9690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9690. --- Fix Version/s: 1.15.0 Resolution: Fixed Patch file restored. > Restore Redis TCL integration test patch file > - > > Key: GEODE-9690 > URL: https://issues.apache.org/jira/browse/GEODE-9690 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: needsTriage, pull-request-available > Fix For: 1.15.0 > > > GEODE-9567 accidentally removed the Redis TCL patch file. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9690) Restore Redis TCL integration test patch file
[ https://issues.apache.org/jira/browse/GEODE-9690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9690: - Assignee: Ray Ingles > Restore Redis TCL integration test patch file > - > > Key: GEODE-9690 > URL: https://issues.apache.org/jira/browse/GEODE-9690 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: needsTriage, pull-request-available > > GEODE-9567 accidentally removed the Redis TCL patch file. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9690) Restore Redis TCL integration test patch file
Ray Ingles created GEODE-9690: - Summary: Restore Redis TCL integration test patch file Key: GEODE-9690 URL: https://issues.apache.org/jira/browse/GEODE-9690 Project: Geode Issue Type: Bug Components: redis Reporter: Ray Ingles GEODE-9567 accidentally removed the Redis TCL patch file. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9567) Geode for Redis Rename
[ https://issues.apache.org/jira/browse/GEODE-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9567. --- Fix Version/s: 1.15.0 Resolution: Fixed Updated to "Geode for Redis" - directories, filenames, help contents > Geode for Redis Rename > -- > > Key: GEODE-9567 > URL: https://issues.apache.org/jira/browse/GEODE-9567 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > The current naming convention we have for compatibility with Redis that uses > the naming scheme compatible-with-redis* requires change to geode-for-redis. > This includes product and test source code, documentation, region name, > statistics, log files, build artifacts, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9650) Radish LOLWUT command
[ https://issues.apache.org/jira/browse/GEODE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9650: - Assignee: Ray Ingles > Radish LOLWUT command > - > > Key: GEODE-9650 > URL: https://issues.apache.org/jira/browse/GEODE-9650 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > > Implement the LOLWUT command, which allows command-line users to quickly > check the software version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9650) Radish LOLWUT command
[ https://issues.apache.org/jira/browse/GEODE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9650. --- Fix Version/s: 1.15.0 Resolution: Fixed > Radish LOLWUT command > - > > Key: GEODE-9650 > URL: https://issues.apache.org/jira/browse/GEODE-9650 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Implement the LOLWUT command, which allows command-line users to quickly > check the software version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9650) Radish LOLWUT command
Ray Ingles created GEODE-9650: - Summary: Radish LOLWUT command Key: GEODE-9650 URL: https://issues.apache.org/jira/browse/GEODE-9650 Project: Geode Issue Type: New Feature Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles Implement the LOLWUT command, which allows command-line users to quickly check the software version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9567) Geode for Redis Rename
[ https://issues.apache.org/jira/browse/GEODE-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418160#comment-17418160 ] Ray Ingles commented on GEODE-9567: --- Pull request located here: https://github.com/apache/geode/pull/6887 > Geode for Redis Rename > -- > > Key: GEODE-9567 > URL: https://issues.apache.org/jira/browse/GEODE-9567 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > > The current naming convention we have for compatibility with Redis that uses > the naming scheme compatible-with-redis* requires change to geode-for-redis. > This includes product and test source code, documentation, region name, > statistics, log files, build artifacts, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9567) Geode for Redis Rename
[ https://issues.apache.org/jira/browse/GEODE-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9567: - Assignee: Ray Ingles > Geode for Redis Rename > -- > > Key: GEODE-9567 > URL: https://issues.apache.org/jira/browse/GEODE-9567 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > > The current naming convention we have for compatibility with Redis that uses > the naming scheme compatible-with-redis* requires change to geode-for-redis. > This includes product and test source code, documentation, region name, > statistics, log files, build artifacts, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9495) remove thread sleep from PubSubNativeRedisAcceptanceTest class cleanup
[ https://issues.apache.org/jira/browse/GEODE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9495. --- Fix Version/s: 1.15.0 Resolution: Fixed Dynamically checks the TIME_WAIT value (which determines how long sockets are held after closing) for Linux and OSX to minimize sleep time. > remove thread sleep from PubSubNativeRedisAcceptanceTest class cleanup > -- > > Key: GEODE-9495 > URL: https://issues.apache.org/jira/browse/GEODE-9495 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Hale Bales >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > GEODE-9338 includes the addition of a Thread.sleep(24) in the class > cleanup. This wait is necessary to allow the sockets used in this class to > exit the TIME_WAIT state. Out of Mac, Linux, and Windows, Windows has the > longest default TIME_WAIT, which is 240 seconds. So currently at the end of > the PubSubNativeRedisAcceptanceTest tests, we wait for 240 seconds. > Another solution was proposed that involved parsing netstat outputs to find > out when enough sockets have been freed, but the complexity didn't buy us > much there. > A potential other solution would be to reduce the TIME_WAIT period when > running the tests in CI. > If we don't wait for the TIME_WAIT period to be up then other tests being run > after it will get bind exceptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9495) remove thread sleep from PubSubNativeRedisAcceptanceTest class cleanup
[ https://issues.apache.org/jira/browse/GEODE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9495: - Assignee: Ray Ingles > remove thread sleep from PubSubNativeRedisAcceptanceTest class cleanup > -- > > Key: GEODE-9495 > URL: https://issues.apache.org/jira/browse/GEODE-9495 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Hale Bales >Assignee: Ray Ingles >Priority: Major > > GEODE-9338 includes the addition of a Thread.sleep(24) in the class > cleanup. This wait is necessary to allow the sockets used in this class to > exit the TIME_WAIT state. Out of Mac, Linux, and Windows, Windows has the > longest default TIME_WAIT, which is 240 seconds. So currently at the end of > the PubSubNativeRedisAcceptanceTest tests, we wait for 240 seconds. > Another solution was proposed that involved parsing netstat outputs to find > out when enough sockets have been freed, but the complexity didn't buy us > much there. > A potential other solution would be to reduce the TIME_WAIT period when > running the tests in CI. > If we don't wait for the TIME_WAIT period to be up then other tests being run > after it will get bind exceptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9435) Implement ZREMRANGEBYRANK Command
[ https://issues.apache.org/jira/browse/GEODE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404683#comment-17404683 ] Ray Ingles commented on GEODE-9435: --- https://github.com/apache/geode/pull/6803 > Implement ZREMRANGEBYRANK Command > - > > Key: GEODE-9435 > URL: https://issues.apache.org/jira/browse/GEODE-9435 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: redis > > Implement the [ZREMRANGEBYRANK|https://redis.io/commands/zremrangebyrank] > command. > > +Acceptance Criteria+ > > The command has been implemented along with appropriate unit tests. > > The command has been added to the AbstractHitsMissesIntegrationTest. The > command has been tested using the redis-cli tool and verified against native > redis. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9535) CI Failure: Tomcat7ClientServerTest > newContainersShouldShareDataAccess
[
https://issues.apache.org/jira/browse/GEODE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles updated GEODE-9535:
--
Labels: (was: pull-request-available)
> CI Failure: Tomcat7ClientServerTest > newContainersShouldShareDataAccess
>
>
> Key: GEODE-9535
> URL: https://issues.apache.org/jira/browse/GEODE-9535
> Project: Geode
> Issue Type: Test
> Components: http session
>Reporter: Jens Deppe
>Priority: Major
>
> {noformat}
> > Task :geode-assembly:distributedTest
> org.apache.geode.session.tests.Tomcat7ClientServerTest >
> newContainersShouldShareDataAccess FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm0.log' at line 423
> [fatal 2021/08/21 21:05:18.691 UTC tid=855]
> Exception in processing request from 10.0.0.108
> java.lang.Exception: Improperly configured client detected - use
> addPoolLocator to configure its locators instead of addPoolServer.
> at
> org.apache.geode.distributed.internal.ProtocolCheckerImpl.checkProtocol(ProtocolCheckerImpl.java:31)
> at
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:342)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> ---
> Found suspect string in 'dunit_suspect-vm0.log' at line 540
> [fatal 2021/08/21 21:05:30.875 UTC tid=855]
> Exception in processing request from 10.0.0.108
> java.lang.Exception: Improperly configured client detected - use
> addPoolLocator to configure its locators instead of addPoolServer.
> at
> org.apache.geode.distributed.internal.ProtocolCheckerImpl.checkProtocol(ProtocolCheckerImpl.java:31)
> at
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:342)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> at org.junit.Assert.fail(Assert.java:89)
> at
> org.apache.geode.test.dunit.internal.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:409)
> at
> org.apache.geode.test.dunit.internal.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:425)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.after(ClusterStartupRule.java:186)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.access$100(ClusterStartupRule.java:70)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule$1.evaluate(ClusterStartupRule.java:141)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
> at
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.ja
[jira] [Assigned] (GEODE-9435) Implement ZREMRANGEBYRANK Command
[ https://issues.apache.org/jira/browse/GEODE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9435: - Assignee: Ray Ingles > Implement ZREMRANGEBYRANK Command > - > > Key: GEODE-9435 > URL: https://issues.apache.org/jira/browse/GEODE-9435 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: redis > > Implement the [ZREMRANGEBYRANK|https://redis.io/commands/zremrangebyrank] > command. > > +Acceptance Criteria+ > > The command has been implemented along with appropriate unit tests. > > The command has been added to the AbstractHitsMissesIntegrationTest. The > command has been tested using the redis-cli tool and verified against native > redis. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9499) RedisData does not need an object reference to implement Delta
[ https://issues.apache.org/jira/browse/GEODE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9499. --- Fix Version/s: 1.15.0 Resolution: Fixed Implements static ThreadLocal storage for delta information in RedisData to avoid an object reference per instance. > RedisData does not need an object reference to implement Delta > -- > > Key: GEODE-9499 > URL: https://issues.apache.org/jira/browse/GEODE-9499 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Darrel Schneider >Assignee: Ray Ingles >Priority: Major > Fix For: 1.15.0 > > > Currently every redis data structure implements the RedisData interface. Part > of that implementation is Delta support. The way it is implemented is by > storing a reference to a DeltaInfo instance in each RedisData. Most of the > time this reference is null but it still takes up 8 bytes (4 if oops are > compressed). It is only non-null while an update is in progress. > What we could do instead is store the reference to the DeltaInfo in a thread > local. That works because we are careful to run each redis command that > modifies a RedisData on the primary. We lock the primary down during the > operation to prevent it from moving. So when it comes time for the primary to > call toDelta on the RedisData instance to distribute it to the secondary, > this call will done on the same thread so our hasDelta and toDelta can just > read the ThreadLocal. This will save us one object reference for every > redis key we store. > Something else we could consider doing is to pass the DeltaInfo as the > callback arg when we do the region put. But this would require change to core > geode to detect that the callback arg is a DeltaInfo and to use it to compute > the delta bytes that are stored on the EntryEventImpl. This is doable and may > even perform better but would require changes to the core. It would probably > be a bit faster than the ThreadLocal solution just because of the extra > latency in setting and reading a ThreadLocal compared to a stack parameter -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9379) Implement ZREVRANGEBYSCORE Command
[ https://issues.apache.org/jira/browse/GEODE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9379. --- Fix Version/s: 1.15.0 Resolution: Fixed > Implement ZREVRANGEBYSCORE Command > -- > > Key: GEODE-9379 > URL: https://issues.apache.org/jira/browse/GEODE-9379 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available, redis > Fix For: 1.15.0 > > > Implement the [ZREVRANGEBYSCORE|https://redis.io/commands/zrevrangebyscore] > command. > > Acceptance Criteria > The ZREVRANGEBYSCORE command has been implemented along with appropriate unit > tests. > > The command has been added to the AbstractHitsMissesIntegrationTest. > The command has been tested using the redis-cli tool. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9499) RedisData does not need an object reference to implement Delta
[ https://issues.apache.org/jira/browse/GEODE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9499: - Assignee: Ray Ingles > RedisData does not need an object reference to implement Delta > -- > > Key: GEODE-9499 > URL: https://issues.apache.org/jira/browse/GEODE-9499 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Darrel Schneider >Assignee: Ray Ingles >Priority: Major > > Currently every redis data structure implements the RedisData interface. Part > of that implementation is Delta support. The way it is implemented is by > storing a reference to a DeltaInfo instance in each RedisData. Most of the > time this reference is null but it still takes up 8 bytes (4 if oops are > compressed). It is only non-null while an update is in progress. > What we could do instead is store the reference to the DeltaInfo in a thread > local. That works because we are careful to run each redis command that > modifies a RedisData on the primary. We lock the primary down during the > operation to prevent it from moving. So when it comes time for the primary to > call toDelta on the RedisData instance to distribute it to the secondary, > this call will done on the same thread so our hasDelta and toDelta can just > read the ThreadLocal. This will save us one object reference for every > redis key we store. > Something else we could consider doing is to pass the DeltaInfo as the > callback arg when we do the region put. But this would require change to core > geode to detect that the callback arg is a DeltaInfo and to use it to compute > the delta bytes that are stored on the EntryEventImpl. This is doable and may > even perform better but would require changes to the core. It would probably > be a bit faster than the ThreadLocal solution just because of the extra > latency in setting and reading a ThreadLocal compared to a stack parameter -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9302) Benchmark instability in PartitionedPutStringBenchmark
[
https://issues.apache.org/jira/browse/GEODE-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401795#comment-17401795
]
Ray Ingles commented on GEODE-9302:
---
(Note that for [benchmark-base
#128|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/benchmark-base/builds/128],
there may have been other issues with this run.)
> Benchmark instability in PartitionedPutStringBenchmark
> --
>
> Key: GEODE-9302
> URL: https://issues.apache.org/jira/browse/GEODE-9302
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
>
> A benchmark failure due to the recently-introduced
> PartitionedPutStringBenchmark was observed:
> {noformat}
> This is ITERATION 1 of benchmarking against baseline.
> P2pPartitionedGetBenchmark avg ops/sec
> Baseline:853001.60 Test:867151.67 Difference: +1.7%
> avg latency
> Baseline:842007.55 Test:828545.06 Difference: -1.6%
> P2pPartitionedPutBenchmark avg ops/sec
> Baseline:128283.47 Test:126510.92 Difference: -1.4%
> avg latency
> Baseline: 5785619.62 Test: 5915913.49 Difference: +2.3%
> P2pPartitionedPutBytesBenchmark avg ops/sec
> Baseline:175658.08 Test:174865.97 Difference: -0.5%
> avg latency
> Baseline: 4130071.43 Test: 4130753.09 Difference: +0.0%
>PartitionedFunctionExecutionBenchmark avg ops/sec
> Baseline:254788.26 Test:268132.99 Difference: +5.2%
> avg latency
> Baseline:846158.41 Test:804199.42 Difference: -5.0%
> PartitionedFunctionExecutionWithArgumentsBenchmark avg ops/sec
> Baseline:278669.87 Test:281504.58 Difference: +1.0%
> avg latency
> Baseline: 1031826.82 Test: 1021314.54 Difference: -1.0%
> PartitionedFunctionExecutionWithFiltersBenchmark avg ops/sec
> Baseline:372204.82 Test:348815.81 Difference: -6.3%
> avg latency
> Baseline: 1545217.38 Test: 1649706.37 Difference: +6.8%
> PartitionedGetBenchmark avg ops/sec
> Baseline:823740.09 Test:819044.99 Difference: -0.6%
> avg latency
> Baseline:872172.75 Test:877580.02 Difference: +0.6%
> PartitionedGetLongBenchmark avg ops/sec
> Baseline: 1047221.43 Test: 1045565.89 Difference: -0.2%
> avg latency
> Baseline:685757.55 Test:687005.43 Difference: +0.2%
>PartitionedGetStringBenchmark avg ops/sec
> Baseline: 1055904.14 Test: 1045420.73 Difference: -1.0%
> avg latency
> Baseline:680031.44 Test:687045.15 Difference: +1.0%
> PartitionedIndexedQueryBenchmark avg ops/sec
> Baseline: 31596.35 Test: 31653.48 Difference: +0.2%
> avg latency
> Baseline: 18221302.10 Test: 18216097.86 Difference: -0.0%
> PartitionedNonIndexedQueryBenchmark avg ops/sec
> Baseline:95.78 Test: 100.35 Difference: +4.8%
> avg latency
> Baseline: 750871203.78 Test: 716853923.95 Difference: -4.5%
> PartitionedPutAllBenchmark avg ops/sec
> Baseline: 8675.75 Test: 8628.10 Difference: -0.5%
> avg latency
> Baseline: 16595044.73 Test: 16685258.91 Difference: +0.5%
> PartitionedPutAllLongBenchmark avg ops/sec
> Baseline: 1382.38 Test: 1380.50 Difference: -0.1%
> avg latency
> Baseline: 104866853.92 Test: 104775538.34 Difference: -0.1%
> PartitionedPutBenchmark avg ops/sec
> Baseline:491790.40 Test:479926.75 Difference: -2.4%
> avg latency
> Baseline: 1461947.23 Test:
[jira] [Assigned] (GEODE-9379) Implement ZREVRANGEBYSCORE Command
[ https://issues.apache.org/jira/browse/GEODE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9379: - Assignee: Ray Ingles > Implement ZREVRANGEBYSCORE Command > -- > > Key: GEODE-9379 > URL: https://issues.apache.org/jira/browse/GEODE-9379 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: redis > > Implement the [ZREVRANGEBYSCORE|https://redis.io/commands/zrevrangebyscore] > command. > > Acceptance Criteria > The ZREVRANGEBYSCORE command has been implemented along with appropriate unit > tests. > > The command has been added to the AbstractHitsMissesIntegrationTest. > The command has been tested using the redis-cli tool. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9378) Implement ZRANGEBYSCORE Command
[ https://issues.apache.org/jira/browse/GEODE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9378. --- Fix Version/s: 1.15.0 Resolution: Fixed Implement ZRANGEBYSCORE command, including LIMIT option. > Implement ZRANGEBYSCORE Command > --- > > Key: GEODE-9378 > URL: https://issues.apache.org/jira/browse/GEODE-9378 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available, redis > Fix For: 1.15.0 > > > Implement the [ZRANGEBYSCORE|https://redis.io/commands/zrangebyscore] command. > +Acceptance Criteria+ > The ZRANGEBYSCORE command has been implemented along with appropriate unit > tests. > > The command has been added to the AbstractHitsMissesIntegrationTest. > The command has been tested using the redis-cli tool. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9378) Implement ZRANGEBYSCORE Command
[ https://issues.apache.org/jira/browse/GEODE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9378: - Assignee: Ray Ingles > Implement ZRANGEBYSCORE Command > --- > > Key: GEODE-9378 > URL: https://issues.apache.org/jira/browse/GEODE-9378 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available, redis > > Implement the [ZRANGEBYSCORE|https://redis.io/commands/zrangebyscore] command. > +Acceptance Criteria+ > The ZRANGEBYSCORE command has been implemented along with appropriate unit > tests. > > The command has been added to the AbstractHitsMissesIntegrationTest. > The command has been tested using the redis-cli tool. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9375) Implement ZRANGE Command
[ https://issues.apache.org/jira/browse/GEODE-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9375. --- Fix Version/s: 1.15.0 Resolution: Fixed Implements ZRANGE command, allows other zset range commands to be worked on. > Implement ZRANGE Command > > > Key: GEODE-9375 > URL: https://issues.apache.org/jira/browse/GEODE-9375 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: redis > Fix For: 1.15.0 > > > Implement the [ZRANGE|https://redis.io/commands/zrange] command to be > compatible with Redis 5.x. Do not implement the new options available in 6.x. > > +Acceptance Criteria+ > The ZRANGE command has been implemented and tested with unit tests. > The command has been added to the AbstractHitsMissesIntegrationTest. > The command has been tested using the redis-cli tool. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9413) Enable native Redis TCL tests for zset (sorted set) data type
Ray Ingles created GEODE-9413: - Summary: Enable native Redis TCL tests for zset (sorted set) data type Key: GEODE-9413 URL: https://issues.apache.org/jira/browse/GEODE-9413 Project: Geode Issue Type: Test Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles Enough commands are now implemented to enable running the native Redis integration tests against Geode radish. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9342) Handle a double reply of "inf" in the same way as Redis
[
https://issues.apache.org/jira/browse/GEODE-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles resolved GEODE-9342.
---
Fix Version/s: 1.15.0
Resolution: Fixed
> Handle a double reply of "inf" in the same way as Redis
> ---
>
> Key: GEODE-9342
> URL: https://issues.apache.org/jira/browse/GEODE-9342
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Sarah Abbey
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> Currently, in `Coder.java` `stringToDouble` and `doubleToString` methods, we
> return "Infinity" or "-Infinity", but native Redis returns "inf" or "-inf"
> respectively, as seen in `networking.c`:
> {code:java}
> void addReplyDouble(client *c, double d) {
> char dbuf[128], sbuf[128];
> int dlen, slen;
> if (isinf(d)) {
> /* Libc in odd systems (Hi Solaris!) will format infinite in a
> * different way, so better to handle it in an explicit way. */
> addReplyBulkCString(c, d > 0 ? "inf" : "-inf");
> } else {
> dlen = snprintf(dbuf,sizeof(dbuf),"%.17g",d);
> slen = snprintf(sbuf,sizeof(sbuf),"$%d\r\n%s\r\n",dlen,dbuf);
> addReplyString(c,sbuf,slen);
> }
> }
> {code}
> We should return "inf" or "-inf" like native Redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9342) Handle a double reply of "inf" in the same way as Redis
[
https://issues.apache.org/jira/browse/GEODE-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles reassigned GEODE-9342:
-
Assignee: Ray Ingles (was: Hale Bales)
> Handle a double reply of "inf" in the same way as Redis
> ---
>
> Key: GEODE-9342
> URL: https://issues.apache.org/jira/browse/GEODE-9342
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Sarah Abbey
>Assignee: Ray Ingles
>Priority: Major
> Labels: pull-request-available
>
> Currently, in `Coder.java` `stringToDouble` and `doubleToString` methods, we
> return "Infinity" or "-Infinity", but native Redis returns "inf" or "-inf"
> respectively, as seen in `networking.c`:
> {code:java}
> void addReplyDouble(client *c, double d) {
> char dbuf[128], sbuf[128];
> int dlen, slen;
> if (isinf(d)) {
> /* Libc in odd systems (Hi Solaris!) will format infinite in a
> * different way, so better to handle it in an explicit way. */
> addReplyBulkCString(c, d > 0 ? "inf" : "-inf");
> } else {
> dlen = snprintf(dbuf,sizeof(dbuf),"%.17g",d);
> slen = snprintf(sbuf,sizeof(sbuf),"$%d\r\n%s\r\n",dlen,dbuf);
> addReplyString(c,sbuf,slen);
> }
> }
> {code}
> We should return "inf" or "-inf" like native Redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9375) Implement ZRANGE Command
[ https://issues.apache.org/jira/browse/GEODE-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9375: - Assignee: Ray Ingles > Implement ZRANGE Command > > > Key: GEODE-9375 > URL: https://issues.apache.org/jira/browse/GEODE-9375 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Assignee: Ray Ingles >Priority: Major > Labels: redis > > Implement the [ZRANGE|https://redis.io/commands/zrange] command to be > compatible with Redis 5.x. Do not implement the new options available in 6.x. > > +Acceptance Criteria+ > The ZRANGE command has been implemented and tested with unit tests. > The command has been added to the AbstractHitsMissesIntegrationTest. > The command has been tested using the redis-cli tool. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9329) Implement data structures needed for Redis leaderboard use case
[ https://issues.apache.org/jira/browse/GEODE-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9329. --- Fix Version/s: 1.15.0 Resolution: Fixed Supports O(1) lookups and O(N) rank operations > Implement data structures needed for Redis leaderboard use case > --- > > Key: GEODE-9329 > URL: https://issues.apache.org/jira/browse/GEODE-9329 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Implement the data structures needed to fully support Sorted Sets in Radish. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9232) Serialization state differences between primary and secondary impact tests
[ https://issues.apache.org/jira/browse/GEODE-9232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9232. --- Resolution: Won't Fix A different testing approach has been adopted (see, e.g. ZAddDUnitTest.java) that does not require knowledge of the serialization state on different servers. > Serialization state differences between primary and secondary impact tests > -- > > Key: GEODE-9232 > URL: https://issues.apache.org/jira/browse/GEODE-9232 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Ray Ingles >Priority: Major > > When confirming the implementation of the 'Sizeable' interface for Radish > (GEODE-9136), testing proved difficult because the size of data could be > different between the primary and secondary. On the primary, the data would > be stored deserialized, but on the secondary, it could be stored serialized, > even after a delta was applied. > Some way of either forcing deserialization, or else validating size while > serialized, needs to be found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9329) Implement data structures needed for Redis leaderboard use case
Ray Ingles created GEODE-9329: - Summary: Implement data structures needed for Redis leaderboard use case Key: GEODE-9329 URL: https://issues.apache.org/jira/browse/GEODE-9329 Project: Geode Issue Type: New Feature Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles Implement the data structures needed to fully support Sorted Sets in Radish. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9317) ZADD/ZSCORE do not properly handle infinity
[ https://issues.apache.org/jira/browse/GEODE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9317: - Assignee: (was: Ray Ingles) > ZADD/ZSCORE do not properly handle infinity > --- > > Key: GEODE-9317 > URL: https://issues.apache.org/jira/browse/GEODE-9317 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Major > > Native Redis accepts values like "inf", "+inf", "-infinity", etc. Currently > Radish considers these values invalid and returns "ERR value is not a valid > float". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9317) ZADD/ZSCORE do not properly handle infinity
[ https://issues.apache.org/jira/browse/GEODE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles updated GEODE-9317: -- Priority: Critical (was: Major) > ZADD/ZSCORE do not properly handle infinity > --- > > Key: GEODE-9317 > URL: https://issues.apache.org/jira/browse/GEODE-9317 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Critical > > Native Redis accepts values like "inf", "+inf", "-infinity", etc. Currently > Radish considers these values invalid and returns "ERR value is not a valid > float". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9317) ZADD/ZSCORE do not properly handle infinity
[ https://issues.apache.org/jira/browse/GEODE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9317: - Assignee: Ray Ingles > ZADD/ZSCORE do not properly handle infinity > --- > > Key: GEODE-9317 > URL: https://issues.apache.org/jira/browse/GEODE-9317 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > > Native Redis accepts values like "inf", "+inf", "-infinity", etc. Currently > Radish considers these values invalid and returns "ERR value is not a valid > float". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9317) ZADD/ZSCORE do not properly handle infinity
Ray Ingles created GEODE-9317: - Summary: ZADD/ZSCORE do not properly handle infinity Key: GEODE-9317 URL: https://issues.apache.org/jira/browse/GEODE-9317 Project: Geode Issue Type: Bug Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles Native Redis accepts values like "inf", "+inf", "-infinity", etc. Currently Radish considers these values invalid and returns "ERR value is not a valid float". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9233) Implement ZADD and ZSCORE
[ https://issues.apache.org/jira/browse/GEODE-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9233. --- Fix Version/s: 1.15.0 Resolution: Fixed > Implement ZADD and ZSCORE > - > > Key: GEODE-9233 > URL: https://issues.apache.org/jira/browse/GEODE-9233 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Initial implementation of the Redis ZADD and ZSCORE commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9233) Implement ZADD and ZSCORE
[ https://issues.apache.org/jira/browse/GEODE-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9233: - Assignee: Ray Ingles > Implement ZADD and ZSCORE > - > > Key: GEODE-9233 > URL: https://issues.apache.org/jira/browse/GEODE-9233 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > > Initial implementation of the Redis ZADD and ZSCORE commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9233) Implement ZADD and ZSCORE
[ https://issues.apache.org/jira/browse/GEODE-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351320#comment-17351320 ] Ray Ingles commented on GEODE-9233: --- Well, there's an existing pull request (linked above) that's almost approved. If you want to look it over and make suggestions, it'd be very welcome! > Implement ZADD and ZSCORE > - > > Key: GEODE-9233 > URL: https://issues.apache.org/jira/browse/GEODE-9233 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Major > Labels: pull-request-available > > Initial implementation of the Redis ZADD and ZSCORE commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9304) Make RedisSortedSet's measurement of byes in use more accurate
Ray Ingles created GEODE-9304: - Summary: Make RedisSortedSet's measurement of byes in use more accurate Key: GEODE-9304 URL: https://issues.apache.org/jira/browse/GEODE-9304 Project: Geode Issue Type: Bug Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles The current calculation of bytes in use by RedisSortedSet is inaccurate, and needs to be improved. Once a strategy for size calculation for classes using Object2ObjectCustomHash and OrderStatisticsTree has been decided, it should be implemented for this data type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9242) CI failure in PutAllClientServerDistributedTest > testEventIdOutOfOrderInPartitionRegionSingleHop
[
https://issues.apache.org/jira/browse/GEODE-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ray Ingles updated GEODE-9242:
--
Affects Version/s: 1.15.0
> CI failure in PutAllClientServerDistributedTest >
> testEventIdOutOfOrderInPartitionRegionSingleHop
> -
>
> Key: GEODE-9242
> URL: https://issues.apache.org/jira/browse/GEODE-9242
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Affects Versions: 1.15.0
>Reporter: Ray Ingles
>Priority: Major
> Labels: release-blocker
>
> CI failure artifacts here:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/214]
>
> Stack trace as follows:
>
> {code:java}
> > Task :geode-cq:distributedTest
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest >
> testEventIdOutOfOrderInPartitionRegionSingleHop FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest$$Lambda$365/1949439489.run
> in VM 2 running on Host 1cd9d0b3a09e with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
> at
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest.testEventIdOutOfOrderInPartitionRegionSingleHop(PutAllClientServerDistributedTest.java:2547)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition defined
> as a lambda expression in
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest that uses
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest$Counter
> expected:<[100]> but was:<[91]> within 5 minutes.
> at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest.lambda$testEventIdOutOfOrderInPartitionRegionSingleHop$46f2d07$1(PutAllClientServerDistributedTest.java:2548)
> Caused by:
> org.junit.ComparisonFailure: expected:<[100]> but was:<[91]>
> at sun.reflect.GeneratedConstructorAccessor43.newInstance(Unknown Source)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.PutAllClientServerDistributedTest.lambda$null$86(PutAllClientServerDistributedTest.java:2548)
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9242) CI failure in PutAllClientServerDistributedTest > testEventIdOutOfOrderInPartitionRegionSingleHop
Ray Ingles created GEODE-9242:
-
Summary: CI failure in PutAllClientServerDistributedTest >
testEventIdOutOfOrderInPartitionRegionSingleHop
Key: GEODE-9242
URL: https://issues.apache.org/jira/browse/GEODE-9242
Project: Geode
Issue Type: Bug
Components: client/server
Reporter: Ray Ingles
CI failure artifacts here:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/214]
Stack trace as follows:
{code:java}
> Task :geode-cq:distributedTest
org.apache.geode.internal.cache.PutAllClientServerDistributedTest >
testEventIdOutOfOrderInPartitionRegionSingleHop FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.internal.cache.PutAllClientServerDistributedTest$$Lambda$365/1949439489.run
in VM 2 running on Host 1cd9d0b3a09e with 4 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
at
org.apache.geode.internal.cache.PutAllClientServerDistributedTest.testEventIdOutOfOrderInPartitionRegionSingleHop(PutAllClientServerDistributedTest.java:2547)
Caused by:
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as
a lambda expression in
org.apache.geode.internal.cache.PutAllClientServerDistributedTest that uses
org.apache.geode.internal.cache.PutAllClientServerDistributedTest$Counter
expected:<[100]> but was:<[91]> within 5 minutes.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
at
org.apache.geode.internal.cache.PutAllClientServerDistributedTest.lambda$testEventIdOutOfOrderInPartitionRegionSingleHop$46f2d07$1(PutAllClientServerDistributedTest.java:2548)
Caused by:
org.junit.ComparisonFailure: expected:<[100]> but was:<[91]>
at sun.reflect.GeneratedConstructorAccessor43.newInstance(Unknown Source)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.geode.internal.cache.PutAllClientServerDistributedTest.lambda$null$86(PutAllClientServerDistributedTest.java:2548)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9241) CI failure in PartitionedRegionCqQueryDUnitTest > testPutAllWithCQLocalDestroy
Ray Ingles created GEODE-9241:
-
Summary: CI failure in PartitionedRegionCqQueryDUnitTest >
testPutAllWithCQLocalDestroy
Key: GEODE-9241
URL: https://issues.apache.org/jira/browse/GEODE-9241
Project: Geode
Issue Type: Bug
Components: cq
Affects Versions: 1.15.0
Reporter: Ray Ingles
CI failure seen here:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/213]
Stack trace as follows:
{code:java}
> Task :geode-cq:distributedTest
org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest >
testPutAllWithCQLocalDestroy FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest$$Lambda$82/1306882276.run
in VM 2 running on Host cae68a7c0ae3 with 4 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:631)
at org.apache.geode.test.dunit.VM.invoke(VM.java:448)
at
org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.testPutAllWithCQLocalDestroy(PartitionedRegionCqQueryDUnitTest.java:178)
Caused by:
org.junit.ComparisonFailure: expected:<9[99]> but was:<9[75]>
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
org.apache.geode.cache.query.cq.dunit.PartitionedRegionCqQueryDUnitTest.lambda$testPutAllWithCQLocalDestroy$c93719d5$3(PartitionedRegionCqQueryDUnitTest.java:186)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9233) Implement ZADD and ZSCORE
[ https://issues.apache.org/jira/browse/GEODE-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles updated GEODE-9233: -- Description: Initial implementation of the Redis ZADD and ZSCORE commands. (was: Inititial implementation of the Redis ZADD and ZSCORE commands.) > Implement ZADD and ZSCORE > - > > Key: GEODE-9233 > URL: https://issues.apache.org/jira/browse/GEODE-9233 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Priority: Major > > Initial implementation of the Redis ZADD and ZSCORE commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9233) Implement ZADD and ZSCORE
Ray Ingles created GEODE-9233: - Summary: Implement ZADD and ZSCORE Key: GEODE-9233 URL: https://issues.apache.org/jira/browse/GEODE-9233 Project: Geode Issue Type: Improvement Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles Inititial implementation of the Redis ZADD and ZSCORE commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9232) Serialization state differences between primary and secondary impact tests
Ray Ingles created GEODE-9232: - Summary: Serialization state differences between primary and secondary impact tests Key: GEODE-9232 URL: https://issues.apache.org/jira/browse/GEODE-9232 Project: Geode Issue Type: Bug Components: redis Reporter: Ray Ingles When confirming the implementation of the 'Sizeable' interface for Radish (GEODE-9136), testing proved difficult because the size of data could be different between the primary and secondary. On the primary, the data would be stored deserialized, but on the secondary, it could be stored serialized, even after a delta was applied. Some way of either forcing deserialization, or else validating size while serialized, needs to be found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9115) CI failure: org.apache.geode.redis.internal.executor.pubsub.LettucePubSubIntegrationTest > quitWhileSubscribe FAILED
Ray Ingles created GEODE-9115: - Summary: CI failure: org.apache.geode.redis.internal.executor.pubsub.LettucePubSubIntegrationTest > quitWhileSubscribe FAILED Key: GEODE-9115 URL: https://issues.apache.org/jira/browse/GEODE-9115 Project: Geode Issue Type: Bug Components: redis Affects Versions: 1.15.0 Reporter: Ray Ingles See https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/119 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9113) CI failure: org.apache.geode.redis.internal.data.RedisHashTest > hscanSnaphots_shouldExpireAfterExpiryPeriod
Ray Ingles created GEODE-9113:
-
Summary: CI failure:
org.apache.geode.redis.internal.data.RedisHashTest >
hscanSnaphots_shouldExpireAfterExpiryPeriod
Key: GEODE-9113
URL: https://issues.apache.org/jira/browse/GEODE-9113
Project: Geode
Issue Type: Bug
Components: redis
Affects Versions: 1.15.0
Reporter: Ray Ingles
{{org.apache.geode.redis.internal.data.RedisHashTest >
hscanSnaphots_shouldExpireAfterExpiryPeriod FAILED
org.awaitility.core.ConditionTimeoutException: Assertion condition defined
as a lambda expression in org.apache.geode.redis.internal.data.RedisHashTest
that uses org.apache.geode.redis.internal.data.RedisHash null within 2 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
at
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
at
org.apache.geode.redis.internal.data.RedisHashTest.hscanSnaphots_shouldExpireAfterExpiryPeriod(RedisHashTest.java:254)
}}
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/117
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-9037) Do not expose unsupported commands in Geode compatibility with Redis
[ https://issues.apache.org/jira/browse/GEODE-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9037. --- Resolution: Fixed Merged on both open and closed side. > Do not expose unsupported commands in Geode compatibility with Redis > > > Key: GEODE-9037 > URL: https://issues.apache.org/jira/browse/GEODE-9037 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Fix For: 1.14.0, 1.15.0 > > > The distinction between 'supported' and 'unsupported' commands is no longer > useful and will be removed. Any commands still listed as unsupported will now > respond if they were unimplemented/unknown. > A system property will allow them to be enabled solely for tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9029) Initial stub support Redis SLOWLOG command
[ https://issues.apache.org/jira/browse/GEODE-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9029. --- Fix Version/s: (was: 1.15.0) (was: 1.14.0) Resolution: Duplicate Actually fixed in GEODE-9032 > Initial stub support Redis SLOWLOG command > -- > > Key: GEODE-9029 > URL: https://issues.apache.org/jira/browse/GEODE-9029 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0 > > This is used by Redis monitoring tools (e.g. Datadog). A stub implementation > is sufficient; the current implementation will be moved to the Supported > category. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9029) Initial stub support Redis SLOWLOG command
[ https://issues.apache.org/jira/browse/GEODE-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles updated GEODE-9029: -- Fix Version/s: 1.15.0 1.14.0 > Initial stub support Redis SLOWLOG command > -- > > Key: GEODE-9029 > URL: https://issues.apache.org/jira/browse/GEODE-9029 > Project: Geode > Issue Type: New Feature > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0 > Fix For: 1.14.0, 1.15.0 > > > This is used by Redis monitoring tools (e.g. Datadog). A stub implementation > is sufficient; the current implementation will be moved to the Supported > category. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9037) Do not expose unsupported commands in Geode compatibility with Redis
[ https://issues.apache.org/jira/browse/GEODE-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles updated GEODE-9037: -- Fix Version/s: 1.15.0 1.14.0 > Do not expose unsupported commands in Geode compatibility with Redis > > > Key: GEODE-9037 > URL: https://issues.apache.org/jira/browse/GEODE-9037 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Fix For: 1.14.0, 1.15.0 > > > The distinction between 'supported' and 'unsupported' commands is no longer > useful and will be removed. Any commands still listed as unsupported will now > respond if they were unimplemented/unknown. > A system property will allow them to be enabled solely for tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9035) Enable all Hash tests in pipeline native-Redis tests
[ https://issues.apache.org/jira/browse/GEODE-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles reassigned GEODE-9035: - Assignee: Ray Ingles > Enable all Hash tests in pipeline native-Redis tests > > > Key: GEODE-9035 > URL: https://issues.apache.org/jira/browse/GEODE-9035 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > > All hash commands are now supported in the compatibility-with-Redis > subsystem. This will enable the native Redis integration tests (written in > TCL) to run the Hash test suite against Geode compatibility-with-Redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9035) Enable all Hash tests in pipeline native-Redis tests
[ https://issues.apache.org/jira/browse/GEODE-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray Ingles resolved GEODE-9035. --- Fix Version/s: 1.15.0 Resolution: Fixed > Enable all Hash tests in pipeline native-Redis tests > > > Key: GEODE-9035 > URL: https://issues.apache.org/jira/browse/GEODE-9035 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Ray Ingles >Assignee: Ray Ingles >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > All hash commands are now supported in the compatibility-with-Redis > subsystem. This will enable the native Redis integration tests (written in > TCL) to run the Hash test suite against Geode compatibility-with-Redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
