[ 
https://issues.apache.org/jira/browse/GEODE-8970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406952#comment-17406952
 ] 

Kirk Lund edited comment on GEODE-8970 at 8/30/21, 9:33 PM:
------------------------------------------------------------

{{MicrometerBinderTest}} failed because the server failed to start within the 
{{startServer}} setup:

{noformat}
Executing 889fbdd0a4f9ec5a: gfsh -e start server --name=server 
--dir=C:\Users\geode\AppData\Local\Temp\junit7809244121723738090 
--server-port=26437 
--classpath=C:\Users\geode\AppData\Local\Temp\junit4985974788060045051\metrics-publishing-service.jar
 --http-service-port=0 --J=-Dgemfire.enable-cluster-config=true 
--J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
--J=-Dgemfire.jmx-manager-port=26438 -e sleep --time=1
[info 2021/08/28 00:21:35.636 GMT  <pool-20-thread-1> tid=0x8c] 

[info 2021/08/28 00:21:35.636 GMT  <pool-20-thread-1> tid=0x8c] (1) Executing - 
 start server --name=server 
--dir=C:\Users\geode\AppData\Local\Temp\junit7809244121723738090 
--server-port=26437 
--classpath=C:\Users\geode\AppData\Local\Temp\junit4985974788060045051\metrics-publishing-service.jar
 --http-service-port=0 --J=-Dgemfire.enable-cluster-config=true 
--J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
--J=-Dgemfire.jmx-manager-port=26438

[info 2021/08/28 00:21:35.636 GMT  <pool-20-thread-1> tid=0x8c] 

[info 2021/08/28 00:21:42.964 GMT  <pool-20-thread-1> tid=0x8c] ...[error 
2021/08/28 00:21:42.964 GMT  <ControlFileWatchdog@3569fc08 monitoring 
vf.gf.server.status> tid=0x29] Unable to control process with 
C:\Users\geode\AppData\Local\Temp\junit7809244121723738090\vf.gf.server.status. 
Please add tools.jar from JDK to classpath for improved process control.
{noformat}

This appears to be a bug in FileProcessController caused by creating the result 
file by its final name ({{vf.gf.server.status}}) before writing the contents of 
the file.

The fix should be to create a result file with a temporary name, write the 
complete contents to that file, and then rename the file to 
{{vf.gf.server.status}}.

The {{stopServer}} teardown should also change to check {{clientCache}} and 
{{serverPool}} for null before calling them.


was (Author: klund):
{{MicrometerBinderTest}} failed because the server failed to start within the 
{{startServer}} setup:

{noformat}
Executing 889fbdd0a4f9ec5a: gfsh -e start server --name=server 
--dir=C:\Users\geode\AppData\Local\Temp\junit7809244121723738090 
--server-port=26437 
--classpath=C:\Users\geode\AppData\Local\Temp\junit4985974788060045051\metrics-publishing-service.jar
 --http-service-port=0 --J=-Dgemfire.enable-cluster-config=true 
--J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
--J=-Dgemfire.jmx-manager-port=26438 -e sleep --time=1
[info 2021/08/28 00:21:35.636 GMT  <pool-20-thread-1> tid=0x8c] 

[info 2021/08/28 00:21:35.636 GMT  <pool-20-thread-1> tid=0x8c] (1) Executing - 
 start server --name=server 
--dir=C:\Users\geode\AppData\Local\Temp\junit7809244121723738090 
--server-port=26437 
--classpath=C:\Users\geode\AppData\Local\Temp\junit4985974788060045051\metrics-publishing-service.jar
 --http-service-port=0 --J=-Dgemfire.enable-cluster-config=true 
--J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true 
--J=-Dgemfire.jmx-manager-port=26438

[info 2021/08/28 00:21:35.636 GMT  <pool-20-thread-1> tid=0x8c] 

[info 2021/08/28 00:21:42.964 GMT  <pool-20-thread-1> tid=0x8c] ...[error 
2021/08/28 00:21:42.964 GMT  <ControlFileWatchdog@3569fc08 monitoring 
vf.gf.server.status> tid=0x29] Unable to control process with 
C:\Users\geode\AppData\Local\Temp\junit7809244121723738090\vf.gf.server.status. 
Please add tools.jar from JDK to classpath for improved process control.
{noformat}

This appears to be a bug in FileProcessController caused by creating the result 
file by its final name ({{vf.gf.server.status}}) before writing the contents of 
the file.

The fix should be to create a result file with a temporary name, write the 
complete contents to that file, and then rename the file to 
{{vf.gf.server.status}}.

> CI failure: MicrometerBinderTest.jvmThreadMetricsBinderExists fails with 
> NullPointerException during stopServer
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-8970
>                 URL: https://issues.apache.org/jira/browse/GEODE-8970
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 1.13.1
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: GeodeOperationAPI
>
> {noformat}
> org.apache.geode.metrics.MicrometerBinderTest > jvmThreadMetricsBinderExists 
> FAILED
>     org.junit.ComparisonFailure: [Exit value from process started by 
> [5649fcaf482615ff: gfsh -e connect --jmx-manager=localhost[22864] -e deploy 
> --jar=/tmp/junit654213865788865628/function.jar]] expected:<[0]> but was:<[1]>
>         at 
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>         at 
> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>         at 
> jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>         at 
> org.apache.geode.test.junit.rules.gfsh.GfshExecution.awaitTermination(GfshExecution.java:137)
>         at 
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:139)
>         at 
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:150)
>         at 
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:114)
>         at 
> org.apache.geode.metrics.MicrometerBinderTest.startServer(MicrometerBinderTest.java:95)
>     java.lang.NullPointerException
>         at 
> org.apache.geode.metrics.MicrometerBinderTest.stopServer(MicrometerBinderTest.java:111)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to