[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492827#comment-17492827
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell merged pull request #917:
URL: https://github.com/apache/geode-native/pull/917


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492820#comment-17492820
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806070730



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0" CACHE STRING "First build 
containing AuthenticationExpiredException")

Review comment:
   Removed.

##
File path: tests/javaobject/CMakeLists.txt
##
@@ -22,6 +22,11 @@ include(UseJava)
 
 file(GLOB_RECURSE SOURCES "*.java")
 
+# Check for versions of GEODE that don't support AuthenticationExpiredException
+if (${Geode_VERSION} VERSION_LESS ${GEODE_AUTHEXPIREDEXCEPTION_VERSION})

Review comment:
   No longer need to define the variable. Switched to searching for the 
Java class.

##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,8 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION_FULL ${var})

Review comment:
   Good catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > 

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492812#comment-17492812
 ] 

ASF GitHub Bot commented on GEODE-10004:


pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806084212



##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,8 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION_FULL ${var})

Review comment:
   Unless I'm mistaken, nothing in this change depends on Geode_VERSION any 
more, so there should be no changes necessary in this file.  Please remove, we 
don't want to accidentally introduce any new ways to break the build.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492700#comment-17492700
 ] 

ASF subversion and git services commented on GEODE-10004:
-

Commit 64e728ee8dc5972fcb4c6ac648bf8209af6944fa in geode-native's branch 
refs/heads/develop from Michael Martell
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=64e728e ]

GEODE-10004: support older geode versions (#917)

* Check for class existence instead of version.

> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492698#comment-17492698
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell merged pull request #917:
URL: https://github.com/apache/geode-native/pull/917


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492143#comment-17492143
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806108856



##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,8 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION_FULL ${var})

Review comment:
   Good catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492131#comment-17492131
 ] 

ASF GitHub Bot commented on GEODE-10004:


pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806084212



##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,8 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION_FULL ${var})

Review comment:
   Unless I'm mistaken, nothing in this change depends on Geode_VERSION any 
more, so there should be no changes necessary in this file.  Please remove, we 
don't want to accidentally introduce any new ways to break the build.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492115#comment-17492115
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806072155



##
File path: tests/javaobject/CMakeLists.txt
##
@@ -22,6 +22,11 @@ include(UseJava)
 
 file(GLOB_RECURSE SOURCES "*.java")
 
+# Check for versions of GEODE that don't support AuthenticationExpiredException
+if (${Geode_VERSION} VERSION_LESS ${GEODE_AUTHEXPIREDEXCEPTION_VERSION})

Review comment:
   No longer need to define the variable. Switched to searching for the 
Java class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492113#comment-17492113
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806070730



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0" CACHE STRING "First build 
containing AuthenticationExpiredException")

Review comment:
   Removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491173#comment-17491173
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r805041305



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0" CACHE STRING "First build 
containing AuthenticationExpiredException")

Review comment:
   Seems reasonable to put it in the cmake config file for the project it 
applies to.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491172#comment-17491172
 ] 

ASF GitHub Bot commented on GEODE-10004:


pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r805041043



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0" CACHE STRING "First build 
containing AuthenticationExpiredException")

Review comment:
   See Martell's comment - this is a string variable because there may be 
different version(s) to test against, depending on which product is being built.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491171#comment-17491171
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r805040012



##
File path: tests/javaobject/CMakeLists.txt
##
@@ -22,6 +22,11 @@ include(UseJava)
 
 file(GLOB_RECURSE SOURCES "*.java")
 
+# Check for versions of GEODE that don't support AuthenticationExpiredException
+if (${Geode_VERSION} VERSION_LESS ${GEODE_AUTHEXPIREDEXCEPTION_VERSION})

Review comment:
   It needs to be a variable that we can override on the cmake config 
command line, for closed source builds:
  cmake ... -DGEODE_AUTHEXPIREDEXCEPTION_VERSION=9.15.0




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491169#comment-17491169
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r805034612



##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,7 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+  set(Geode_VERSION ${var})

Review comment:
   Good catch! No longer need the build number since we're just comparing 
with first 3 parts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491134#comment-17491134
 ] 

ASF GitHub Bot commented on GEODE-10004:


pivotal-jbarrett commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r804977432



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0" CACHE STRING "First build 
containing AuthenticationExpiredException")

Review comment:
   Why is this a cache variable and why in the root project. This should 
just be a string literal in the javaobject project.

##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,7 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+  set(Geode_VERSION ${var})

Review comment:
   I agree, the group 1 has all the parts we care about in the version.

##
File path: tests/javaobject/CMakeLists.txt
##
@@ -22,6 +22,11 @@ include(UseJava)
 
 file(GLOB_RECURSE SOURCES "*.java")
 
+# Check for versions of GEODE that don't support AuthenticationExpiredException
+if (${Geode_VERSION} VERSION_LESS ${GEODE_AUTHEXPIREDEXCEPTION_VERSION})

Review comment:
   Use version literal, `"1.15.0"`, here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start 

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491115#comment-17491115
 ] 

ASF GitHub Bot commented on GEODE-10004:


pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r804954533



##
File path: cmake/FindGeode.cmake
##
@@ -73,7 +73,7 @@ if(Geode_gfsh_EXECUTABLE)
 # TODO error checking
   else()
 if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
-  set(Geode_VERSION "${CMAKE_MATCH_1}")
+  set(Geode_VERSION ${var})

Review comment:
   What is this all about?  I don't understand why we need a change in the 
Geode find module...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490690#comment-17490690
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r804380249



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First 
build containing AuthenticationExpiredException")

Review comment:
   Good suggestion. Makes sense to use 1.15.0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490374#comment-17490374
 ] 

ASF GitHub Bot commented on GEODE-10004:


pivotal-jbarrett commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r803887968



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First 
build containing AuthenticationExpiredException")

Review comment:
   Also the GA release ends up with build 0 too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490373#comment-17490373
 ] 

ASF GitHub Bot commented on GEODE-10004:


pivotal-jbarrett commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r803887440



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First 
build containing AuthenticationExpiredException")

Review comment:
   Ok, fair enough, but why the specific build number. When building 
locally on your machine, since Apache doesn't do binary releases, that build 
number is almost always 0. Just detect "1.15.0". We don't need to handle 
building sources between GAs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490367#comment-17490367
 ] 

ASF GitHub Bot commented on GEODE-10004:


pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r803874498



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First 
build containing AuthenticationExpiredException")

Review comment:
   Just because that's a more complex fix, and neither of us really have a 
clue how to implement it using cmake.  Like how would we do this, go dump the 
class list from a jar file after we find Geode?  Which of the umpteen Geode jar 
files should we look in?  How do we run the jar tool at this stage via cmake?  
After we do or do not find the exception class, how do we put that back into a 
cmake variable we can use to conditionally compile our Java?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489982#comment-17489982
 ] 

ASF GitHub Bot commented on GEODE-10004:


pivotal-jbarrett commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r803341661



##
File path: CMakeLists.txt
##
@@ -61,6 +61,7 @@ set(PRODUCT_BUILDDATE "1970-01-01" CACHE STRING "Product 
build date")
 set(PRODUCT_SOURCE_REVISION "" CACHE 
STRING "Product source SHA")
 set(PRODUCT_SOURCE_REPOSITORY "" CACHE STRING "Product source 
branch")
 set(PRODUCT_BITS "${BUILD_BITS}bit")
+set(GEODE_AUTHEXPIREDEXCEPTION_VERSION "1.15.0-build.546" CACHE STRING "First 
build containing AuthenticationExpiredException")

Review comment:
   Why not just test for the existence of the exception class or not and 
set a "has feature" type flag?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486076#comment-17486076
 ] 

ASF GitHub Bot commented on GEODE-10004:


mmartell opened a new pull request #917:
URL: https://github.com/apache/geode-native/pull/917


   This PR is to update the cmake config files for tests/javaobject to allow 
building javaobject.jar against geode versions that pre-date the addition of 
throwing AuthenticationExpiredExceptions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10004) Starting server should fail fast when server port and redis port are the same

[Jens Deppe (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485009#comment-17485009
 ] 

Jens Deppe commented on GEODE-10004:


Geode has other 'server' components that could all produce conflicting port 
issues - WAN gateways, JMX, http and memcache come to mind.

> Starting server should fail fast when server port and redis port are the same
> -
>
> Key: GEODE-10004
> URL: https://issues.apache.org/jira/browse/GEODE-10004
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, redis
>Affects Versions: 1.15.0, 1.16.0
>Reporter: Hale Bales
>Priority: Major
>
> When starting a cluster with GFSH with geode-for-redis enabled, starting a 
> server fails when the geode-for-redis-port and server-port are set to the 
> same port. It fails with the below stacktrace, but does not fail fast. We 
> should be able to detect this issue before we reach the point of getting a 
> bind exception.
> stacktrace:
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: An IO error occurred 
> while starting a Server in /Users/hbales/workspace/geode/itch-proud-alpha on 
> hbales-a01.vmware.com[6379]: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:863)
> at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:739)
> at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:258)
> Caused by: java.net.BindException: Failed to create server socket on 
> 192.168.0.4[6379]
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:75)
> at 
> org.apache.geode.internal.net.SCClusterSocketCreator.createServerSocket(SCClusterSocketCreator.java:55)
> at 
> org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:522)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:573)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorBuilder.create(AcceptorBuilder.java:291)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.createAcceptor(CacheServerImpl.java:420)
> at 
> org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:377)
> at 
> org.apache.geode.distributed.ServerLauncher.startCacheServer(ServerLauncher.java:1039)
> at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:837)
> ... 2 more
> Caused by: java.net.BindException: Address already in use (Bind failed)
> at java.net.PlainSocketImpl.socketBind(Native Method)
> at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
> at java.net.ServerSocket.bind(ServerSocket.java:375)
> at 
> org.apache.geode.distributed.internal.tcpserver.ClusterSocketCreatorImpl.createServerSocket(ClusterSocketCreatorImpl.java:72)
> ... 10 more
> {code}
> series of GFSH commands that led to this error:
> {code:java}
> > start locator
> > start server --J=-Dgemfire.geode-for-redis-enabled=true 
> > --J=-Dgemfire.geode-for-redis-port=6379 --server-port=6379
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)