[jira] [Commented] (GEODE-10404) Fix compilation for Java 11
[ https://issues.apache.org/jira/browse/GEODE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580616#comment-17580616 ] ASF subversion and git services commented on GEODE-10404: - Commit b3f8a08c3b79e2036a0ae964658d1849affa7e79 in geode-native's branch refs/heads/develop from Mario Salazar de Torres [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=b3f8a08c3 ] GEODE-10404: Fix javaobject compilation for Java 11 (#980) - After merging #973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by specifying UTF-8 encoding while compiling. > Fix compilation for Java 11 > --- > > Key: GEODE-10404 > URL: https://issues.apache.org/jira/browse/GEODE-10404 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > It seems that after merging > [#973|https://github.com/apache/geode-native/pull/973], compilation with > Geode Native Docker build image for version 1.15.0 is broken. This is the > compilation error: > {noformat} > tests/javaobject/ComparePdxInstanceFunction.java:42: error: unmappable > character (0xAC) for encoding US-ASCII > pdxInstanceFactory.writeString("utfHugeField", longString + "???"); > {noformat} > As it seems, the latest docker image is using Java 11, which handles UTF-8 > strings in a different way to Java 8, so that's why compilation is working > with packer images and not with Docker build image. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10404) Fix compilation for Java 11
[ https://issues.apache.org/jira/browse/GEODE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580615#comment-17580615 ] ASF GitHub Bot commented on GEODE-10404: albertogpz merged PR #980: URL: https://github.com/apache/geode-native/pull/980 > Fix compilation for Java 11 > --- > > Key: GEODE-10404 > URL: https://issues.apache.org/jira/browse/GEODE-10404 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > It seems that after merging > [#973|https://github.com/apache/geode-native/pull/973], compilation with > Geode Native Docker build image for version 1.15.0 is broken. This is the > compilation error: > {noformat} > tests/javaobject/ComparePdxInstanceFunction.java:42: error: unmappable > character (0xAC) for encoding US-ASCII > pdxInstanceFactory.writeString("utfHugeField", longString + "???"); > {noformat} > As it seems, the latest docker image is using Java 11, which handles UTF-8 > strings in a different way to Java 8, so that's why compilation is working > with packer images and not with Docker build image. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10404) Fix compilation for Java 11
[ https://issues.apache.org/jira/browse/GEODE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17574170#comment-17574170 ] ASF GitHub Bot commented on GEODE-10404: gaussianrecurrence opened a new pull request, #980: URL: https://github.com/apache/geode-native/pull/980 - After merging #973, javaobject compilation was broken for Java 11. The build passed since packer images uses Java 8, but as docker build images uses Java 11, compilation is failing there. - Root cause of the compilation issue is the difference in UTF-8 string handling between Java 8 and Java 11. - So, the issue was fixed by using unicode hexcode codepoint characters, rather than the actual codepoint. > Fix compilation for Java 11 > --- > > Key: GEODE-10404 > URL: https://issues.apache.org/jira/browse/GEODE-10404 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage > > It seems that after merging > [#973|https://github.com/apache/geode-native/pull/973], compilation with > Geode Native Docker build image for version 1.15.0 is broken. This is the > compilation error: > {noformat} > tests/javaobject/ComparePdxInstanceFunction.java:42: error: unmappable > character (0xAC) for encoding US-ASCII > pdxInstanceFactory.writeString("utfHugeField", longString + "???"); > {noformat} > As it seems, the latest docker image is using Java 11, which handles UTF-8 > strings in a different way to Java 8, so that's why compilation is working > with packer images and not with Docker build image. -- This message was sent by Atlassian Jira (v8.20.10#820010)