[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173600#comment-16173600
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/master from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173599#comment-16173599
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/master from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173605#comment-16173605
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 0b881b515eb1dcea974f0f5c1b40da03d42af9cf in geode's branch 
refs/heads/master from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0b881b5 ]

GEODE-3249 Validate internal client/server messages

This change leaves the security hole in place but allows you to plug
it by setting the system property

geode.disallow-internal-messages-without-credentials=true

Clients must be upgraded to the release containing this change if you
set this system property to true and client/server authentication is
enabled.  Otherwise client messages to register PDX types or
Instantiators will be rejected by the servers.

New tests have been added to perform backward-compatibility testing
with the old security implementation and the internal message command
classes have been modified to perform validation of credentials if
the system property is set to true.

(cherry picked from commit abbb359fe59ea3e74462fe48890918108a0edda3)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173598#comment-16173598
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/master from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173603#comment-16173603
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit afcd9817bc28069453861c935f428e89b8c7ff5d in geode's branch 
refs/heads/master from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=afcd981 ]

GEODE-3249 Validate internal client/server messages

The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client.  This message class does require
credentials and shouldn't be included in the set of internal messages.

(cherry picked from commit f2492bf0abdc662cc080f1e2c0f17257e05604a3)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173601#comment-16173601
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 99b0fd6f9b0c73540f46c8c98acc089b67be791d in geode's branch 
refs/heads/master from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99b0fd6 ]

GEODE-3249: internal messages should require credentials

Removed unnecessary statement in one of the tests added for this ticket.

(cherry picked from commit 7cbbf67f3ae313920421fe24f15a72ce27ea2308)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173602#comment-16173602
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 1bb1cae34814bdca298e476f8b88d19e4bc0dd51 in geode's branch 
refs/heads/master from [~karensmolermiller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1bb1cae ]

GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735

(cherry picked from commit d83ba36e8143054f8ce1fab4eec08641de8384f5)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173604#comment-16173604
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 4626e88a44ac7009d0bc4dbe09d60204080e34a6 in geode's branch 
refs/heads/master from [~karensmolermiller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4626e88 ]

GEODE-3249 Revise docs for internal msg validation

(cherry picked from commit 06431c371b0984835b802916391ff17626104214)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173584#comment-16173584
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 99b0fd6f9b0c73540f46c8c98acc089b67be791d in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99b0fd6 ]

GEODE-3249: internal messages should require credentials

Removed unnecessary statement in one of the tests added for this ticket.

(cherry picked from commit 7cbbf67f3ae313920421fe24f15a72ce27ea2308)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173585#comment-16173585
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 1bb1cae34814bdca298e476f8b88d19e4bc0dd51 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1bb1cae ]

GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735

(cherry picked from commit d83ba36e8143054f8ce1fab4eec08641de8384f5)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173586#comment-16173586
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit afcd9817bc28069453861c935f428e89b8c7ff5d in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=afcd981 ]

GEODE-3249 Validate internal client/server messages

The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client.  This message class does require
credentials and shouldn't be included in the set of internal messages.

(cherry picked from commit f2492bf0abdc662cc080f1e2c0f17257e05604a3)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159111#comment-16159111
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 0b881b515eb1dcea974f0f5c1b40da03d42af9cf in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0b881b5 ]

GEODE-3249 Validate internal client/server messages

This change leaves the security hole in place but allows you to plug
it by setting the system property

geode.disallow-internal-messages-without-credentials=true

Clients must be upgraded to the release containing this change if you
set this system property to true and client/server authentication is
enabled.  Otherwise client messages to register PDX types or
Instantiators will be rejected by the servers.

New tests have been added to perform backward-compatibility testing
with the old security implementation and the internal message command
classes have been modified to perform validation of credentials if
the system property is set to true.

(cherry picked from commit abbb359fe59ea3e74462fe48890918108a0edda3)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159108#comment-16159108
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 4626e88a44ac7009d0bc4dbe09d60204080e34a6 in geode's branch 
refs/heads/release/1.2.1 from [~karensmolermiller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4626e88 ]

GEODE-3249 Revise docs for internal msg validation

(cherry picked from commit 06431c371b0984835b802916391ff17626104214)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159104#comment-16159104
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 06431c371b0984835b802916391ff17626104214 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=06431c3 ]

GEODE-3249 Revise docs for internal msg validation


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159054#comment-16159054
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit abbb359fe59ea3e74462fe48890918108a0edda3 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=abbb359 ]

GEODE-3249 Validate internal client/server messages

This change leaves the security hole in place but allows you to plug
it by setting the system property

geode.disallow-internal-messages-without-credentials=true

Clients must be upgraded to the release containing this change if you
set this system property to true and client/server authentication is
enabled.  Otherwise client messages to register PDX types or
Instantiators will be rejected by the servers.

New tests have been added to perform backward-compatibility testing
with the old security implementation and the internal message command
classes have been modified to perform validation of credentials if
the system property is set to true.


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148313#comment-16148313
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit f2492bf0abdc662cc080f1e2c0f17257e05604a3 in geode's branch 
refs/heads/feature/GEODE-3543 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2492bf ]

GEODE-3249 Validate internal client/server messages

The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client.  This message class does require
credentials and shouldn't be included in the set of internal messages.


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148081#comment-16148081
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit afcd9817bc28069453861c935f428e89b8c7ff5d in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=afcd981 ]

GEODE-3249 Validate internal client/server messages

The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client.  This message class does require
credentials and shouldn't be included in the set of internal messages.

(cherry picked from commit f2492bf0abdc662cc080f1e2c0f17257e05604a3)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148036#comment-16148036
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit f2492bf0abdc662cc080f1e2c0f17257e05604a3 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2492bf ]

GEODE-3249 Validate internal client/server messages

The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client.  This message class does require
credentials and shouldn't be included in the set of internal messages.


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141739#comment-16141739
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 1bb1cae34814bdca298e476f8b88d19e4bc0dd51 in geode's branch 
refs/heads/release/1.2.1 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1bb1cae ]

GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735

(cherry picked from commit d83ba36e8143054f8ce1fab4eec08641de8384f5)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139309#comment-16139309
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit d83ba36e8143054f8ce1fab4eec08641de8384f5 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d83ba36 ]

GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139028#comment-16139028
 ] 

ASF GitHub Bot commented on GEODE-3249:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/735

GEODE-3249 Document geode.allow-internal-messages-without-credentials

@bschuchardt @metatype Please review documentation of the new property.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3249

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #735


commit 440dd6fbb7184acad7a4436f82e35b912155a24d
Author: Karen Miller 
Date:   2017-08-23T20:25:19Z

GEODE-3249 Document geode.allow-internal-messages-without-credentials




> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138555#comment-16138555
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138556#comment-16138556
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138554#comment-16138554
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit c8a365418fd185198b61113991e2947dc69d249e in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c8a3654 ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true

(cherry picked from commit 6be38cad729d56f355c7586ec994bfef933c5e65)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138557#comment-16138557
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 99b0fd6f9b0c73540f46c8c98acc089b67be791d in geode's branch 
refs/heads/release/1.2.1 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=99b0fd6 ]

GEODE-3249: internal messages should require credentials

Removed unnecessary statement in one of the tests added for this ticket.

(cherry picked from commit 7cbbf67f3ae313920421fe24f15a72ce27ea2308)


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: docs, messaging
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0, 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128976#comment-16128976
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 6be38cad729d56f355c7586ec994bfef933c5e65 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6be38ca ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128974#comment-16128974
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 6be38cad729d56f355c7586ec994bfef933c5e65 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6be38ca ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128975#comment-16128975
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 6be38cad729d56f355c7586ec994bfef933c5e65 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6be38ca ]

GEODE-3249: Validate internal client/server messages

This is a squashed commit of the following from feature/GEODE-3249b:

commit c16b151e57169733186f0c029d1957da32d59635
"spotless" fixes

commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general 
overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property 
set.

The system property is
  geode.allow-internal-messages-without-credentials=true


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128046#comment-16128046
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit f8e7ddd5e4696907ce60a14f581ef1ca83e65232 in geode's branch 
refs/heads/feature/GEODE-3249b from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f8e7ddd ]

GEODE-3249: Validate internal client/server messages

This was merely a matter of changing the server to require the credentials
and changing the client to send credentials.  I removed the general overriding
of AbstractOp.processSecureBytes() because it made no sense.  If the server
sends a secure byte "part" in a message the client is obligated to process
it or the next message it sends will cause a security violation.

I've added a server-side property that folks can set to allow old clients
to continue to work.  This must be used to roll the servers forward to the
new version that contains this change.  Clients must then be rolled
forward & the servers can then be rolled once again without the property set.

The system property is
  geode.allow-internal-messages-without-credentials=true


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128029#comment-16128029
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 5987dd000e9ac8b254be097f5ac5c4d11857fb74 in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5987dd0 ]

Merge branch 'feature/GEODE-3249' of 
https://git-wip-us.apache.org/repos/asf/geode into feature/GEODE-3249


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128025#comment-16128025
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 6c2ea4ac87298feedd44df40aa3df1899a0f6880 in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6c2ea4a ]

GEODE-3249: Validate internal client/server messages

Work in progress.

Messages that could harm a server now send credentials.
TODO: perform authorization checks on the server


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128026#comment-16128026
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit a07d987d25da37231acf0315d5376a3ec39cbb59 in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a07d987 ]

GEODE-3249

Moved new test code into a new test method instead of overloading
an existing test method.


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128030#comment-16128030
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 5987dd000e9ac8b254be097f5ac5c4d11857fb74 in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5987dd0 ]

Merge branch 'feature/GEODE-3249' of 
https://git-wip-us.apache.org/repos/asf/geode into feature/GEODE-3249


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128027#comment-16128027
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit e0fbb3cce45528362c1df67bf191ddc4846a9a7f in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e0fbb3c ]

GEODE-3249: internal messages should have credentials

added a system property to allow old clients to not send credentials and
a unit test of this change


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127721#comment-16127721
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 6ee5771dd1156b3d754662259e30e635702721b8 in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6ee5771 ]

GEODE-3249: internal messages should have credentials

Require all client-side message classes to invoke processSecureBytes().

Allow client PR metadata fetch from a background thread with no
credentials.


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124225#comment-16124225
 ] 

Bruce Schuchardt commented on GEODE-3249:
-

with the latest changes the test 
ClientAuthorizationTwoDUnitTest.testAllOpsWithFailover2 is failing.  Precheckin 
is otherwise green.

> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3249) Validate internal client/server messages

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120771#comment-16120771
 ] 

ASF subversion and git services commented on GEODE-3249:


Commit 41e14ddb3c8269556f4ef13951b6708c8d23acc5 in geode's branch 
refs/heads/feature/GEODE-3249 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=41e14dd ]

GEODE-3249: internal messages should have credentials

added a system property to allow old clients to not send credentials and
a unit test of this change


> Validate internal client/server messages
> 
>
> Key: GEODE-3249
> URL: https://issues.apache.org/jira/browse/GEODE-3249
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Anthony Baker
>Assignee: Bruce Schuchardt
> Fix For: 1.2.1
>
>
> Some message types can not be invoked directly by an end user.  For 
> validation purposes, we should treat these messages the same way we treat 
> normal messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)