[jira] [Commented] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

2017-08-25 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142493#comment-16142493
 ] 

ASF subversion and git services commented on GEODE-3522:


Commit 755f636240b901e3039527e6c968445c06f03c24 in geode's branch 
refs/heads/develop from [~lhughesgodfrey]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=755f636 ]

GEODE-3522: create via load needs to add event to AEQ under same lock as update 
to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, which 
allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.

This closes #744


> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

2017-08-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142494#comment-16142494
 ] 

ASF GitHub Bot commented on GEODE-3522:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/744


> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3522) puts via a load need to update AEQ and data region under a single lock (to prevent bucket movement during processing)

2017-08-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142291#comment-16142291
 ] 

ASF GitHub Bot commented on GEODE-3522:
---

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/744

GEODE-3522: create via load needs to add event to AEQ under same lock…

… as update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.

@upthewaterspout, @boglesby

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #744


commit afbfd708185cc7ed82490699c033c40263e4aa76
Author: Lynn Hughes-Godfrey 
Date:   2017-08-25T21:46:17Z

GEODE-3522: create via load needs to add event to AEQ under same lock as 
update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.




> puts via a load need to update AEQ and data region under a single lock (to 
> prevent bucket movement during processing)
> -
>
> Key: GEODE-3522
> URL: https://issues.apache.org/jira/browse/GEODE-3522
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0, 1.3.0, 1.2.1
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> New entries created via a loader can miss creating their lucene index if the 
> primary is moved between adding the entry to the AEQ and into the localRegion.
> handleWANEvent needs to be executed under the same lock held for putting a 
> new entry into the data region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)