[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377237#comment-16377237
]
ASF subversion and git services commented on GEODE-3813:
Commit 94db6a7d3d473fec40540c510858e60ce47cd741 in geode's branch
refs/heads/feature/GEODE-4738 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=94db6a7 ]
GEODE-3813: Improved and fixed formatting in javaDoc for deprecated behavior
(#1500)
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues, docs
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374845#comment-16374845
]
ASF subversion and git services commented on GEODE-3813:
Commit 94db6a7d3d473fec40540c510858e60ce47cd741 in geode's branch
refs/heads/develop from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=94db6a7 ]
GEODE-3813: Improved and fixed formatting in javaDoc for deprecated behavior
(#1500)
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues, docs
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362750#comment-16362750
]
ASF subversion and git services commented on GEODE-3813:
Commit 49cb2eb6fb18966d9fc6c49548edfaf6047a51cc in geode's branch
refs/heads/feature/GEODE-3967 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=49cb2eb ]
GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior (#1438)
* Now with lazy default pool initialization from GEODE-4511, readyForEvents
will throw
IllegalStateException if no pools available.
* Modified tests based on new behavior introduced in GEODE-4511
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362619#comment-16362619
]
ASF subversion and git services commented on GEODE-3813:
Commit 49cb2eb6fb18966d9fc6c49548edfaf6047a51cc in geode's branch
refs/heads/develop from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=49cb2eb ]
GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior (#1438)
* Now with lazy default pool initialization from GEODE-4511, readyForEvents
will throw
IllegalStateException if no pools available.
* Modified tests based on new behavior introduced in GEODE-4511
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362446#comment-16362446
]
ASF subversion and git services commented on GEODE-3813:
Commit 273d510a332c663853473747136ee74489b370af in geode's branch
refs/heads/feature/GEODE-3967 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=273d510 ]
Revert "GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior
(#1376)"
This reverts commit 66dbc8eb8d8fca7b55aed80322970400ee5f3627.
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361563#comment-16361563
]
ASF subversion and git services commented on GEODE-3813:
Commit 273d510a332c663853473747136ee74489b370af in geode's branch
refs/heads/develop from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=273d510 ]
Revert "GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior
(#1376)"
This reverts commit 66dbc8eb8d8fca7b55aed80322970400ee5f3627.
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359752#comment-16359752
]
ASF subversion and git services commented on GEODE-3813:
Commit 66dbc8eb8d8fca7b55aed80322970400ee5f3627 in geode's branch
refs/heads/feature/GEODE-3967 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=66dbc8e ]
GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior (#1376)
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359077#comment-16359077
]
ASF subversion and git services commented on GEODE-3813:
Commit 66dbc8eb8d8fca7b55aed80322970400ee5f3627 in geode's branch
refs/heads/develop from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=66dbc8e ]
GEODE-3813: Deprecating RegisterInterest ALL_KEYS and List behavior (#1376)
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-3813) Region registerInterest API usage of type parameters is broken
[
https://issues.apache.org/jira/browse/GEODE-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295551#comment-16295551
]
Jason Huynh commented on GEODE-3813:
Here are my interpretation of the results from the dev list:
- deprecate current "ALL_KEYS" and List passing behavior in registerInterest()
- add registerInterestForAllKeys();
- add registerInterestForKeys(T... keys)
- add registerInterestForKeys(Iterablekeys)
I believe this will have to be done in two phases.
Phase 1:
- Deprecate ALL_KEYS and List passing behavior
- Add warnings when ALL_KEYS or Lists are passed to the current registerInterest
- add registerInterestForAllKeys();
- optional (add registerInterestForKeys(Iterable and add
registerInterestForKeys(T...) where it does the iteration on the client and
just calls registerInterest(T) for each key. This is not optimal but is
definitely doable if needed)
Phase 2: (Major version/possibly breaking change)
- remove behavior of List (there is a specific messages for this)
- remove behavior of ALL_KEYS from the code.
- add and optimize registerInterestForKeys(Iterable) to do the iteration on
the server
- add registerInterest(T... keys)
When Phase 1 is complete, possibly open a new ticket for Phase 1
> Region registerInterest API usage of type parameters is broken
> --
>
> Key: GEODE-3813
> URL: https://issues.apache.org/jira/browse/GEODE-3813
> Project: Geode
> Issue Type: Bug
> Components: client queues, regions
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>
> The registerInterest API works for single key registration but is broken for
> all other types of registration if the Region is declared with type
> parameters:
> Single key (works):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1);
> {noformat}
> ALL_KEYS token is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest("ALL_KEYS");
> {noformat}
> List of keys is broken (fails to compile):
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> List listOfKeys = new ArrayList<>();
> listOfKeys.add(1);
> listOfKeys.add(2);
> region.registerInterest(listOfKeys);
> {noformat}
> When this ticket is fixed and the API is updated, we should consider adding
> support for var args:
> {noformat}
> Region region = clientRegionFactory.create(regionName);
> region.registerInterest(1, 2, 3);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
