[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301706#comment-16301706
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

jdeppe-pivotal closed pull request #1199: GEODE-4030, GEODE-3495: Bump 
dependencies to new versions
URL: https://github.com/apache/geode/pull/1199
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
 
b/extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
index 48a5662e94..aae5a2d728 100644
--- 
a/extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
+++ 
b/extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
@@ -21,21 +21,16 @@
 import static org.junit.Assert.assertTrue;
 
 import java.io.File;
-import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.ArrayList;
 import java.util.EnumSet;
 import java.util.Enumeration;
 import java.util.List;
 import java.util.StringTokenizer;
-import java.util.concurrent.TimeUnit;
 
 import javax.servlet.DispatcherType;
 import javax.servlet.RequestDispatcher;
-import javax.servlet.ServletException;
 import javax.servlet.http.Cookie;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
 import javax.servlet.http.HttpSession;
 
 import com.meterware.httpunit.GetMethodWebRequest;
@@ -106,7 +101,7 @@ public void setUp() throws Exception {
 servletHolder = tester.addServlet(BasicServlet.class, "/hello");
 servletHolder.setInitParameter("test.callback", "callback_1");
 
-/**
+/*
  * This starts the servlet. Our wrapped servlets *must* start immediately 
otherwise the
  * ServletContext is not captured correctly.
  */
@@ -120,19 +115,13 @@ public void tearDown() throws Exception {
 
   @Test
   public void testSanity() throws Exception {
-Callback c = new Callback() {
-  @Override
-  public void call(HttpServletRequest request, HttpServletResponse 
response)
-  throws IOException {
-PrintWriter out = response.getWriter();
-out.write("Hello World");
-  }
+Callback c = (request, response) -> {
+  PrintWriter out = response.getWriter();
+  out.write("Hello World");
 };
 
 tester.setAttribute("callback_1", c);
 tester.start();
-// ContextManager.getInstance().putContext(
-// servletHolder.getServlet().getServletConfig().getServletContext());
 
 request.setMethod("GET");
 request.setURI("/test/hello");
@@ -147,19 +136,13 @@ public void call(HttpServletRequest request, 
HttpServletResponse response)
 
   @Test
   public void testSessionGenerated() throws Exception {
-Callback c = new Callback() {
-  @Override
-  public void call(HttpServletRequest request, HttpServletResponse 
response)
-  throws IOException {
-PrintWriter out = response.getWriter();
-out.write(request.getSession().getId());
-  }
+Callback c = (request, response) -> {
+  PrintWriter out = response.getWriter();
+  out.write(request.getSession().getId());
 };
 
 tester.setAttribute("callback_1", c);
 tester.start();
-// ContextManager.getInstance().putContext(
-// servletHolder.getServlet().getServletConfig().getServletContext());
 
 request.setMethod("GET");
 request.setURI("/test/hello");
@@ -172,10 +155,15 @@ public void call(HttpServletRequest request, 
HttpServletResponse response)
 
 List cookies = getCookies(response);
 assertEquals("Session id != JSESSIONID from cookie", response.getContent(),
-cookies.get(0).getValue());
+getSessionCookie(cookies).getValue());
 
 Region r = getRegion();
-assertNotNull("Session not found in region", 
r.get(cookies.get(0).getValue()));
+assertNotNull("Session not found in region", 
r.get(getSessionCookie(cookies).getValue()));
+  }
+
+  private Cookie getSessionCookie(List cookies) {
+return cookies.stream().filter(cookie -> 
cookie.getName().equals("JSESSIONID"))
+.reduce((oldCookie, cookie) -> cookie).get();
   }
 
 
@@ -184,24 +172,18 @@ public void call(HttpServletRequest request, 
HttpServletResponse response)
*/
   @Test
   public void testSessionNotGenerated() throws Exception {
-Callback c = new Callback() {
-  @Override
-  public void call(HttpServletRequest request, HttpServletRespon

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301705#comment-16301705
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

jdeppe-pivotal commented on issue #1199: GEODE-4030, GEODE-3495: Bump 
dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#issuecomment-353642720
 
 
   Merged manually after making some review changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301704#comment-16301704
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

jdeppe-pivotal commented on a change in pull request #1199: GEODE-4030, 
GEODE-3495: Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158528962
 
 

 ##
 File path: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java
 ##
 @@ -585,21 +622,6 @@ public void testSSLWithTLSProtocol() throws Exception {
 validateConnection(restEndpoint, "TLS", props);
   }
 
-  @Test
-  public void testSSLWithTLSv11Protocol() throws Exception {
 
 Review comment:
   Regardless, it's still possible to do it (even if it's bad). Some people 
will need it for older clients that can only do TLSv1.1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301698#comment-16301698
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

metatype commented on a change in pull request #1199: GEODE-4030, GEODE-3495: 
Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158528539
 
 

 ##
 File path: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java
 ##
 @@ -585,21 +622,6 @@ public void testSSLWithTLSProtocol() throws Exception {
 validateConnection(restEndpoint, "TLS", props);
   }
 
-  @Test
-  public void testSSLWithTLSv11Protocol() throws Exception {
 
 Review comment:
   The problem is that all cipher suites for TLSv11 have known vulnerabilities 
and have been disabled by Jetty.  If we bump the Jetty version we are 
essentially removing support for TLS v1.1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301612#comment-16301612
 ] 

ASF subversion and git services commented on GEODE-4030:


Commit 61ba3b69b3ec3093ae0610f428de62c57499b123 in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=61ba3b6 ]

GEODE-4030, GEODE-3495: Bump dependencies to new versions

* Jackson : 2.8.6 -> 2.9.3
* Jetty   : 9.3.10.v20160621 -> 9.4.8.v20171121
* Spring  :
* - Security  : 4.2.1.RELEASE -> 4.2.3.RELEASE
* - TX: 4.3.6.RELEASE -> 4.3.13.RELEASE
* - Framework : 4.3.6.RELEASE -> 4.3.13.RELEASE
*
* Log4j / slf4j dependency bump currently blocked by LOG4J2-2152.

This closes [#1199]


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301580#comment-16301580
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

jdeppe-pivotal commented on a change in pull request #1199: GEODE-4030, 
GEODE-3495: Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158513720
 
 

 ##
 File path: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java
 ##
 @@ -744,19 +766,6 @@ public void testSSLWithTLSProtocolLegacy() throws 
Exception {
 validateConnection(restEndpoint, "TLS", props);
   }
 
-  @Test
-  public void testSSLWithTLSv11ProtocolLegacy() throws Exception {
 
 Review comment:
   Ditto, above


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301581#comment-16301581
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

jdeppe-pivotal commented on a change in pull request #1199: GEODE-4030, 
GEODE-3495: Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158513687
 
 

 ##
 File path: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsWithSSLDUnitTest.java
 ##
 @@ -585,21 +622,6 @@ public void testSSLWithTLSProtocol() throws Exception {
 validateConnection(restEndpoint, "TLS", props);
   }
 
-  @Test
-  public void testSSLWithTLSv11Protocol() throws Exception {
 
 Review comment:
   This test should not be removed. Rather, mark as Ignore and provide Jira


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300214#comment-16300214
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

metatype commented on a change in pull request #1199: GEODE-4030, GEODE-3495: 
Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158311484
 
 

 ##
 File path: 
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
 ##
 @@ -617,23 +464,17 @@ public void call(HttpServletRequest request, 
HttpServletResponse response)
   /**
* Test that invalidating a session throws an exception on subsequent access.
*/
-  @Category(FlakyTest.class) // GEODE-1015: uses Jetty HttpTester, uses static 
vars with class
- // loader isolation, TODO: rewrite test with 
JUnit 4 rules including
- // TemporaryFolder
+  @Category(FlakyTest.class)
 
 Review comment:
   Same as above.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300215#comment-16300215
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

metatype commented on a change in pull request #1199: GEODE-4030, GEODE-3495: 
Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158311283
 
 

 ##
 File path: 
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
 ##
 @@ -451,102 +391,16 @@ private Cookie findUserCookie(Cookie[] cookies) {
 return userCookie;
   }
 
-  // Don't see how to do this currently as the SessionListener needs a full
-  // web context to work in.
-
-  // /**
-  // * Test that sessions expire correctly
-  // */
-  // public void testSessionExpiration() throws Exception {
-  // Callback c_1 = new Callback() {
-  // @Override
-  // public void call(HttpServletRequest request, HttpServletResponse response)
-  // throws IOException, ServletException {
-  // HttpSession s = request.getSession();
-  // s.setAttribute("foo", "bar");
-  // s.setMaxInactiveInterval(1);
-  //
-  // PrintWriter out = response.getWriter();
-  // out.write(s.getId());
-  // }
-  // };
-  //
-  // // This is the callback used to check if the session is still there
-  // Callback c_2 = new Callback() {
-  // @Override
-  // public void call(HttpServletRequest request, HttpServletResponse response)
-  // throws IOException, ServletException {
-  // HttpSession s = request.getSession(false);
-  // String output;
-  // if (s == null) {
-  // output = "null";
-  // } else {
-  // output = s.getId();
-  // }
-  //
-  // PrintWriter out = response.getWriter();
-  // out.write(output);
-  // }
-  // };
-  //
-  // tester.addEventListener(new SessionListener());
-  // tester.setAttribute("callback_1", c_1);
-  // tester.setAttribute("callback_2", c_2);
-  //
-  // servletHolder.setInitParameter("test.callback", "callback_1");
-  //
-  // ServletHolder sh2 = tester.addServlet(BasicServlet.class, "/request2");
-  // sh2.setInitParameter("test.callback", "callback_2");
-  //
-  // tester.start();
-  // ContextManager.getInstance().putContext(
-  // servletHolder.getServlet().getServletConfig().getServletContext());
-  //
-  // request.setMethod("GET");
-  // request.setURI("/test/hello");
-  // request.setHeader("Host", "tester");
-  // request.setVersion("HTTP/1.0");
-  // response.parse(tester.getResponses(request.generate()));
-  //
-  // String id = response.getContent();
-  //
-  // // Wait for the session to expire
-  // Thread.sleep(2000);
-  //
-  // request.setHeader("Cookie", "JSESSIONID=" + id);
-  // request.setURI("/test/request2");
-  // response.parse(tester.getResponses(request.generate()));
-  //
-  // assertIndexDetailsEquals("null", response.getContent());
-  //
-  // Region r = getRegion();
-  // assertNull("Region should not contain session", r.get(id));
-  // }
-
   /**
* Test that invalidating a session destroys it as well as the backend 
object.
*/
-  @Category(FlakyTest.class) // GEODE-1015: uses Jetty HttpTester, uses static 
vars with class
- // loader isolation, TODO: rewrite test with 
JUnit 4 rules including
- // TemporaryFolder
+  @Category(FlakyTest.class)
 
 Review comment:
   Why remove this comment?  Seems helpful to understand why the test was 
marked flaky.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299257#comment-16299257
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

PurelyApplied commented on issue #1199: GEODE-4030, GEODE-3495: Bump 
dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#issuecomment-353213342
 
 
   It also appears that I included some minor test refactorings in this commit. 
 Changes were largely driven by IDE inspections (`new Callable` to lambdas, 
etc) and the removal of dead code.
   
   The exception to this is changing how cookies were handled in the 
`SessionReplicationIntegrationJUnitTest` at the recommendation of @metatype 
with respect to the Jetty version bump.  This being outside my wheelhouse, I 
defer to anyone with greater insight into these tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299252#comment-16299252
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

PurelyApplied commented on issue #1199: GEODE-4030, GEODE-3495: Bump 
dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#issuecomment-353212343
 
 
   Precheck ran clean excepting one failure from 
   ```
   org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
testBug40165ClientReconnects
   ```
   
   This has been occurring intermittently and is likely unrelated, but I am 
rerunning the distributed tests in any case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299239#comment-16299239
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

PurelyApplied commented on issue #1199: GEODE-4030, GEODE-3495: Bump 
dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#issuecomment-353211910
 
 
   `SessionReplicationIntegrationJUnitTest` fails when Log4j is bumped.
   
   In the case of a bump to 2.9.x, it fails to 
[LOG4J2-2055](https://issues.apache.org/jira/browse/LOG4J2-2055).
   
   In the case of a bump to 2.10.x, it fails to 
[LOG4J2-2152](https://issues.apache.org/jira/browse/LOG4J2-2152).
   
   Log4j / slf4j updating must then either be deferred until these issues are 
addressed or until the ofending tests can be rewritten.
   
   After some confusing collaboration, this PR subsumed PR#903.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299231#comment-16299231
 ] 

ASF GitHub Bot commented on GEODE-4030:
---

PurelyApplied opened a new pull request #1199: GEODE-4030, GEODE-3495: Bump 
dependencies to new versions
URL: https://github.com/apache/geode/pull/1199
 
 
   * Jackson : 2.8.6 -> 2.9.3
   * Jetty   : 9.3.10.v20160621 -> 9.4.8.v20171121
   * Spring  :
   * - Security  : 4.2.1.RELEASE -> 4.2.3.RELEASE
   * - TX: 4.3.6.RELEASE -> 4.3.13.RELEASE
   * - Framework : 4.3.6.RELEASE -> 4.3.13.RELEASE
   *
   * Log4j / slf4j dependency bump currently blocked by LOG4J2-2152.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4030) Upgrade to the latest dependencies

2017-12-06 Thread Patrick Rhomberg (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280745#comment-16280745
 ] 

Patrick Rhomberg commented on GEODE-4030:
-

We currently reference the following spring versions:
{noformat}
spring-hateoas.version = 0.23.0.RELEASE
spring-ldap-core.version = 2.3.1.RELEASE
spring-security.version = 4.2.1.RELEASE
spring-shell.version = 1.2.0.RELEASE
spring-tx.version = 4.3.6.RELEASE
springframework.version = 4.3.6.RELEASE
{noformat}

Should the upgrade to {{4.3.13}} touch both {{springframework.version}} and 
{{spring-tx.version}}, or only the former?

> Upgrade to the latest dependencies
> --
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
>  Issue Type: Bug
>  Components: build, logging, rest (admin), rest (dev)
>Reporter: Swapnil Bawaskar
>Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> namefrom   to
> 
> Jackson   2.8.6 2.9.2
> log4j2  2.8.2  2.10.0
> spring  4.3.6  4.3.13
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)