[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2018-02-01 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349402#comment-16349402
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit a4abc21e57596deeb3b6366fa10c0acdd6a0f0df in geode's branch 
refs/heads/master from [~dbarnes97]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a4abc21 ]

GEODE-4079 Identify hash indexes as deprecated in docs for gfsh create index 
command


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
>Priority: Major
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2018-01-25 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338902#comment-16338902
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit 4d46ba5755444d5e25d7b025d4b7a57e99940881 in geode's branch 
refs/heads/feature/GEODE-3967 from [~dbarnes97]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4d46ba5 ]

GEODE-4079 Identify hash indexes as deprecated in docs for gfsh create index 
command


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
>Priority: Major
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2018-01-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338536#comment-16338536
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit a4abc21e57596deeb3b6366fa10c0acdd6a0f0df in geode's branch 
refs/heads/release/1.4.0 from [~dbarnes97]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a4abc21 ]

GEODE-4079 Identify hash indexes as deprecated in docs for gfsh create index 
command


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
>Priority: Major
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2018-01-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338006#comment-16338006
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit 4d46ba5755444d5e25d7b025d4b7a57e99940881 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4d46ba5 ]

GEODE-4079 Identify hash indexes as deprecated in docs for gfsh create index 
command


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
>Priority: Major
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295965#comment-16295965
 ] 

ASF GitHub Bot commented on GEODE-4079:
---

karensmolermiller closed pull request #1180: GEODE-4079 Identify hash indexes 
as deprecated in docs
URL: https://github.com/apache/geode/pull/1180
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb 
b/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb
index 0f8f8af367..e8302ad8d8 100644
--- a/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb
+++ b/geode-docs/developing/query_index/create_multiple_indexes.html.md.erb
@@ -34,8 +34,6 @@ gfsh> define index --name=myIndex1 --expression=exp1 
--region=/exampleRegion
 
 gfsh> define index --name=myIndex2 --expression="c.exp2" 
--region="/exampleRegion e, e.collection1 c" 
 
-gfsh> define index --name=myIndex3 --expression=exp3 --region=/exampleRegion 
--type=hash 
-
 gfsh> create defined indexes
  
 ```
@@ -56,7 +54,6 @@ Message : Region ' /r3' not found: from  /r3Occurred on 
following members
 QueryService queryService = cache.getQueryService();
 queryService.defineIndex("name1", "indexExpr1", "regionPath1");
 queryService.defineIndex("name2", "indexExpr2", "regionPath2");
-queryService.defineHashIndex("name3", "indexExpr3", "regionPath2");
 queryService.defineKeyIndex("name4", "indexExpr4", "regionPath2");
 List indexes = queryService.createDefinedIndexes();
 ```
diff --git a/geode-docs/developing/query_index/creating_an_index.html.md.erb 
b/geode-docs/developing/query_index/creating_an_index.html.md.erb
index abac6f340d..69846b32d7 100644
--- a/geode-docs/developing/query_index/creating_an_index.html.md.erb
+++ b/geode-docs/developing/query_index/creating_an_index.html.md.erb
@@ -29,7 +29,7 @@ To create an index, use one of the following `QueryService` 
methods:
 
 -   `createIndex`. Creates the default type of index, a range index. Use this 
type of index if you will be writing queries that will be doing any kind of 
comparison operation besides an equality comparison.
 -   `createKeyIndex`. Creates a key index. See [Creating Key 
Indexes](creating_key_indexes.html#concept_09E29507AF0D42CF81D261B030D0B7C8) 
for more information.
--   `createHashIndex`. Creates a hash index. See [Creating Hash 
Indexes](creating_hash_indexes.html#concept_5C7614F71F394C62ACA1BDC5684A7AC4) 
for more information.
+-   **Deprecated.** `createHashIndex`. Creates a hash index. See [Creating 
Hash 
Indexes](creating_hash_indexes.html#concept_5C7614F71F394C62ACA1BDC5684A7AC4) 
for more information.
 -   `createDefinedIndexes`. Creates multiple indexes that were previously 
defined using `defineIndex`. See [Creating Multiple Indexes at 
Once](create_multiple_indexes.html) for more information.
 
 The following sections provide examples of index creation:
@@ -39,7 +39,6 @@ The following sections provide examples of index creation:
 ``` pre
 gfsh> create index --name=myIndex --expression=status --region=/exampleRegion
 gfsh> create index --name=myKeyIndex --type=key --expression=id 
--region=/exampleRegion
-gfsh> create index --name=myHashIndex --type=hash --expression=mktValue 
--region=/exampleRegion
 ```
 
 See [Index 
Commands](../../tools_modules/gfsh/quick_ref_commands_by_area.html#topic_688C66526B4649AFA51C0F72F34FA45E)
 for more examples.
@@ -50,7 +49,6 @@ See [Index 
Commands](../../tools_modules/gfsh/quick_ref_commands_by_area.html#to
 QueryService qs = cache.getQueryService();
  qs.createIndex("myIndex", "status", "/exampleRegion");
  qs.createKeyIndex("myKeyIndex", "id", "/exampleRegion");
- qs.createHashIndex("myHashIndex", "mktValue", "/exampleRegion");
 ```
 
 **Using cache.xml:**
@@ -61,7 +59,6 @@ QueryService qs = cache.getQueryService();
  
  
  
- 
  ...
 
 ```
diff --git 
a/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb 
b/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb
index e785749d50..be8a119975 100644
--- a/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb
+++ b/geode-docs/developing/query_index/creating_hash_indexes.html.md.erb
@@ -19,8 +19,10 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
+**Hash indexes are deprecated.**
 <%=vars.product_name%> supports the creation of hash indexes for the purpose 
of performing equality-based queries.
 
+
 ## Hash Index Performance
 
 The performance of put operations and recovery time when using a hash index 
@@ -58,6 +60,8 @@ If memory is not a concern, use a range index instead of a

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295966#comment-16295966
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit afd72b06050bf84e456e982880e0ce639aec0001 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=afd72b0 ]

GEODE-4079 Identify hash indexes as deprecated in docs (#1180)



> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295671#comment-16295671
 ] 

ASF GitHub Bot commented on GEODE-4079:
---

karensmolermiller opened a new pull request #1180: GEODE-4079 Identify hash 
indexes as deprecated in docs
URL: https://github.com/apache/geode/pull/1180
 
 
   I have marked all subsections on hash indexes as deprecated, and I have 
removed all examples (java code, XML, and gfsh commands) that demonstrated how 
to do things with hash indexes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-18 Thread Karen Smoler Miller (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295351#comment-16295351
 ] 

Karen Smoler Miller commented on GEODE-4079:


Reopening this ticket for updating the documentation.


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
>Assignee: Karen Smoler Miller
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-15 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293456#comment-16293456
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit 59b949ee6afa7750e6f66c380724639a337b6f1f in geode's branch 
refs/heads/feature/GEODE-3781 from [~nnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=59b949e ]

GEODE-4079: Deprecated Hash Index

* Added deprecated tags on HashIndex class
* Deprecated createHashIndex calls in QueryService
* Deprecated HASH type in IndexType
* Added to the help text in gfsh create index mentioning hash index 
being deprecated since Apache Geode 1.4.0


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293287#comment-16293287
 ] 

ASF GitHub Bot commented on GEODE-4079:
---

nabarunnag closed pull request #1163: GEODE-4079: Deprecated Hash Index
URL: https://github.com/apache/geode/pull/1163
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/main/java/org/apache/geode/cache/query/IndexType.java 
b/geode-core/src/main/java/org/apache/geode/cache/query/IndexType.java
index 79bb0a38cb..702eca7026 100644
--- a/geode-core/src/main/java/org/apache/geode/cache/query/IndexType.java
+++ b/geode-core/src/main/java/org/apache/geode/cache/query/IndexType.java
@@ -50,7 +50,11 @@
* long int short byte char float double
*
* @see QueryService#createIndex(String, IndexType, String, String)
+   * @deprecated Due to the overhead caused by rehashing while expanding the 
backing array, hash
+   * index has been deprecated since Apache Geode 1.4.0. Use
+   * {@link IndexType#FUNCTIONAL} instead.
*/
+  @Deprecated
   HASH("HASH"),
 
 
diff --git 
a/geode-core/src/main/java/org/apache/geode/cache/query/QueryService.java 
b/geode-core/src/main/java/org/apache/geode/cache/query/QueryService.java
index f244b226d9..7e49eb4715 100644
--- a/geode-core/src/main/java/org/apache/geode/cache/query/QueryService.java
+++ b/geode-core/src/main/java/org/apache/geode/cache/query/QueryService.java
@@ -14,9 +14,11 @@
  */
 package org.apache.geode.cache.query;
 
-import java.util.*;
+import java.util.Collection;
+import java.util.List;
 
-import org.apache.geode.cache.*;
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
 import org.apache.geode.cache.query.internal.Undefined;
 
 /**
@@ -76,7 +78,11 @@
* @throws UnsupportedOperationException If Index is being created on a 
region which does not
* support indexes.
*
+   * @deprecated Due to the overhead caused by rehashing while expanding the 
backing array, hash
+   * index has been deprecated since Apache Geode 1.4.0. Use method
+   * {@link QueryService#createIndex(String, String, String)} 
instead.
*/
+  @Deprecated
   public Index createHashIndex(String indexName, String indexedExpression, 
String regionPath)
   throws IndexInvalidException, IndexNameConflictException, 
IndexExistsException,
   RegionNotFoundException, UnsupportedOperationException;
@@ -120,7 +126,11 @@ public void defineKeyIndex(String indexName, String 
indexedExpression, String re
*
* @throws RegionNotFoundException if the region referred to in the 
fromClause doesn't exist
*
+   * @deprecated Due to the overhead caused by rehashing while expanding the 
backing array, hash
+   * index has been deprecated since Apache Geode 1.4.0. Use method
+   * {@link QueryService#defineIndex(String, String, String)} 
instead.
*/
+  @Deprecated
   public void defineHashIndex(String indexName, String indexedExpression, 
String regionPath)
   throws RegionNotFoundException;
 
@@ -146,7 +156,12 @@ public void defineHashIndex(String indexName, String 
indexedExpression, String r
*mktValue field: indexExpression: "p.mktValue" regionPath: 
"/portfolio p"
*
* @throws RegionNotFoundException if the region referred to in the 
fromClause doesn't exist
+   *
+   * @deprecated Due to the overhead caused by rehashing while expanding the 
backing array, hash
+   * index has been deprecated since Apache Geode 1.4.0. Use method
+   * {@link QueryService#defineIndex(String, String, String, 
String)} instead.
*/
+  @Deprecated
   public void defineHashIndex(String indexName, String indexedExpression, 
String regionPath,
   String imports) throws RegionNotFoundException;
 
@@ -232,7 +247,12 @@ public void defineIndex(String indexName, String 
indexedExpression, String regio
* @throws RegionNotFoundException if the region referred to in the 
fromClause doesn't exist
* @throws UnsupportedOperationException If Index is being created on a 
region which overflows to
* disk
+   *
+   * @deprecated Due to the overhead caused by rehashing while expanding the 
backing array, hash
+   * index has been deprecated since Apache Geode 1.4.0. Use method
+   * {@link QueryService#createIndex(String, String, String, 
String)} instead
*/
+  @Deprecated
   public Index createHashIndex(String indexName, String indexedExpression, 
String regionPath,
   String imports) throws IndexInvalidException, IndexNameConflictException,
   IndexExistsException, RegionNotFoundException, 
Un

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-15 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293288#comment-16293288
 ] 

ASF subversion and git services commented on GEODE-4079:


Commit 59b949ee6afa7750e6f66c380724639a337b6f1f in geode's branch 
refs/heads/develop from [~nnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=59b949e ]

GEODE-4079: Deprecated Hash Index

* Added deprecated tags on HashIndex class
* Deprecated createHashIndex calls in QueryService
* Deprecated HASH type in IndexType
* Added to the help text in gfsh create index mentioning hash index 
being deprecated since Apache Geode 1.4.0


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-4079) Deprecate Hash Index and Hash Index APIs

2017-12-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289762#comment-16289762
 ] 

ASF GitHub Bot commented on GEODE-4079:
---

nabarunnag opened a new pull request #1163: GEODE-4079: Deprecated Hash Index
URL: https://github.com/apache/geode/pull/1163
 
 
* Added deprecated tags on HashIndex class
* Deprecated createHashIndex calls in QueryService
* Deprecated HASH type in IndexType
* Added to the help text in gfsh create index mentioning hash index 
being deprecated since Apache Geode 1.4.0
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Deprecate Hash Index and Hash Index APIs
> 
>
> Key: GEODE-4079
> URL: https://issues.apache.org/jira/browse/GEODE-4079
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Jason Huynh
> Fix For: 1.4.0
>
>
> As discussed on the user and dev list, we should deprecate the Hash Index and 
> the corresponding Hash Index APIs.
> The proposal:
> Currently the Hash Index name causes confusion. It is not a traditional hash 
> look up index, but more of memory savings index.  The index does not store 
> index keys in memory and must hash the keys every time.  The index 
> synchronizes on a backing array and when the backing array needs to be 
> expanded, it currently needs to rehash all elements in the array.  This can 
> be very problematic for larger data sets.
> There were improvements made to one of the functional indexes (compact range 
> index) prior to open sourcing.  These improvements helped reduce the memory 
> consumption of that index and makes it very similar sized to a hash index, 
> but the keys still are stored in memory.  Probably close enough to be a 
> replacement for the hash index in most cases.  The read/write performance on 
> it is also faster than the hash index.
> This works includes:
> Deprecating the Hash Index Class
> Deprecating the createHashIndex API's in query Service
> Deprecating the Hash Index type in IndexTypes (if possible)
> Deprecating the gfsh commands to create hash index and hash index types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)