[jira] [Commented] (GEODE-5464) Add generics to DistributionManager

2018-07-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562340#comment-16562340
 ] 

ASF subversion and git services commented on GEODE-5464:


Commit 58715ac2f0bb086c577d204131c129a4338b07c9 in geode's branch 
refs/heads/feature/GEODE-5400 from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=58715ac ]

GEODE-5464: Generify DistributionManager and related classes (#2174)

GEODE-5464: Generify DistributionManager and related classes

* Augment various collections to use generics
* Inline some iterator loops that were trivially "foreach" loops
* remove unused code
* Inline some redundant local variables
* make some methods more private
* change some tests to use `InternalDistributedMember` instead of
  `DistributedMember`.
* Make ThrottlingMemLinkedQueueWithDMStats generic and use atomic.
  - The previous synchronization looked quite wrong.

> Add generics to DistributionManager
> ---
>
> Key: GEODE-5464
> URL: https://issues.apache.org/jira/browse/GEODE-5464
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> DistributionManager has a number of methods that take/return various 
> {{Collection}} types without specifying the types of the elements in the 
> collection. This code would be significantly more readable and understandable 
> if generics were added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5464) Add generics to DistributionManager

2018-07-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562339#comment-16562339
 ] 

ASF subversion and git services commented on GEODE-5464:


Commit 58715ac2f0bb086c577d204131c129a4338b07c9 in geode's branch 
refs/heads/feature/GEODE-5400 from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=58715ac ]

GEODE-5464: Generify DistributionManager and related classes (#2174)

GEODE-5464: Generify DistributionManager and related classes

* Augment various collections to use generics
* Inline some iterator loops that were trivially "foreach" loops
* remove unused code
* Inline some redundant local variables
* make some methods more private
* change some tests to use `InternalDistributedMember` instead of
  `DistributedMember`.
* Make ThrottlingMemLinkedQueueWithDMStats generic and use atomic.
  - The previous synchronization looked quite wrong.

> Add generics to DistributionManager
> ---
>
> Key: GEODE-5464
> URL: https://issues.apache.org/jira/browse/GEODE-5464
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> DistributionManager has a number of methods that take/return various 
> {{Collection}} types without specifying the types of the elements in the 
> collection. This code would be significantly more readable and understandable 
> if generics were added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5464) Add generics to DistributionManager

2018-07-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562112#comment-16562112
 ] 

ASF subversion and git services commented on GEODE-5464:


Commit 58715ac2f0bb086c577d204131c129a4338b07c9 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=58715ac ]

GEODE-5464: Generify DistributionManager and related classes (#2174)

GEODE-5464: Generify DistributionManager and related classes

* Augment various collections to use generics
* Inline some iterator loops that were trivially "foreach" loops
* remove unused code
* Inline some redundant local variables
* make some methods more private
* change some tests to use `InternalDistributedMember` instead of
  `DistributedMember`.
* Make ThrottlingMemLinkedQueueWithDMStats generic and use atomic.
  - The previous synchronization looked quite wrong.

> Add generics to DistributionManager
> ---
>
> Key: GEODE-5464
> URL: https://issues.apache.org/jira/browse/GEODE-5464
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> DistributionManager has a number of methods that take/return various 
> {{Collection}} types without specifying the types of the elements in the 
> collection. This code would be significantly more readable and understandable 
> if generics were added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5464) Add generics to DistributionManager

2018-07-30 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562113#comment-16562113
 ] 

ASF subversion and git services commented on GEODE-5464:


Commit 58715ac2f0bb086c577d204131c129a4338b07c9 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=58715ac ]

GEODE-5464: Generify DistributionManager and related classes (#2174)

GEODE-5464: Generify DistributionManager and related classes

* Augment various collections to use generics
* Inline some iterator loops that were trivially "foreach" loops
* remove unused code
* Inline some redundant local variables
* make some methods more private
* change some tests to use `InternalDistributedMember` instead of
  `DistributedMember`.
* Make ThrottlingMemLinkedQueueWithDMStats generic and use atomic.
  - The previous synchronization looked quite wrong.

> Add generics to DistributionManager
> ---
>
> Key: GEODE-5464
> URL: https://issues.apache.org/jira/browse/GEODE-5464
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> DistributionManager has a number of methods that take/return various 
> {{Collection}} types without specifying the types of the elements in the 
> collection. This code would be significantly more readable and understandable 
> if generics were added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)