[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186632#comment-17186632 ] ASF subversion and git services commented on GEODE-8458: Commit d9d13100ae11e2eba8a6428fad29007388680b43 in geode's branch refs/heads/develop from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d9d1310 ] GEODE-8458: Use build metadata properties as task inputs (#5480) GEODE-8458: Use build metadata properties as task inputs * Rebuilds GemFireVersion.properties on Git repo or property changes * version * HEAD sha * build user * java version * productName * etc * Drops the 'Build-Date' field from GemFireVersion.properties * This changes output of `gfsh version --full` * Source commit-date is still available, as is source-SHA * Removes `Build-Date` from tests and pulse > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186631#comment-17186631 ] ASF subversion and git services commented on GEODE-8458: Commit d9d13100ae11e2eba8a6428fad29007388680b43 in geode's branch refs/heads/develop from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d9d1310 ] GEODE-8458: Use build metadata properties as task inputs (#5480) GEODE-8458: Use build metadata properties as task inputs * Rebuilds GemFireVersion.properties on Git repo or property changes * version * HEAD sha * build user * java version * productName * etc * Drops the 'Build-Date' field from GemFireVersion.properties * This changes output of `gfsh version --full` * Source commit-date is still available, as is source-SHA * Removes `Build-Date` from tests and pulse > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186627#comment-17186627 ] ASF subversion and git services commented on GEODE-8458: Commit d9d13100ae11e2eba8a6428fad29007388680b43 in geode's branch refs/heads/develop from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d9d1310 ] GEODE-8458: Use build metadata properties as task inputs (#5480) GEODE-8458: Use build metadata properties as task inputs * Rebuilds GemFireVersion.properties on Git repo or property changes * version * HEAD sha * build user * java version * productName * etc * Drops the 'Build-Date' field from GemFireVersion.properties * This changes output of `gfsh version --full` * Source commit-date is still available, as is source-SHA * Removes `Build-Date` from tests and pulse > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186628#comment-17186628 ] ASF subversion and git services commented on GEODE-8458: Commit d9d13100ae11e2eba8a6428fad29007388680b43 in geode's branch refs/heads/develop from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d9d1310 ] GEODE-8458: Use build metadata properties as task inputs (#5480) GEODE-8458: Use build metadata properties as task inputs * Rebuilds GemFireVersion.properties on Git repo or property changes * version * HEAD sha * build user * java version * productName * etc * Drops the 'Build-Date' field from GemFireVersion.properties * This changes output of `gfsh version --full` * Source commit-date is still available, as is source-SHA * Removes `Build-Date` from tests and pulse > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186624#comment-17186624 ] ASF GitHub Bot commented on GEODE-8458: --- rhoughton-pivot merged pull request #5480: URL: https://github.com/apache/geode/pull/5480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Priority: Major > Labels: pull-request-available > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186179#comment-17186179 ] ASF GitHub Bot commented on GEODE-8458: --- Bill commented on pull request #5480: URL: https://github.com/apache/geode/pull/5480#issuecomment-682255954 Testing… 1. `./gradlew build -PproductName="GemFire" -PgeodeVersion=1.14.0-build.0 -Pversion=1.14.0-build.0 -PbuildId=0 -x test` generates `GemFireVersion.properties` with timestamp 2. running same command again does not modify that file 3. running `./gradlew build -PproductName="GemFire" -PgeodeVersion=1.15.0-build.0 -Pversion=1.15.0-build.0 -PbuildId=0 -x test` causes `GemFireVersion.properties` to be modified. The product version is correct and the timestamp was updated. 4. running a similar command from a parallel project using `-Dcomposite` and `-PgeodeVersion=1.14.0-build.0` causes a new correct `GemFireVersion.properties` to be generated These are good things. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Priority: Major > Labels: pull-request-available > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8458) Rebuild GemFireVersion.properties on build-flag changes
[ https://issues.apache.org/jira/browse/GEODE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185368#comment-17185368 ] ASF GitHub Bot commented on GEODE-8458: --- rhoughton-pivot opened a new pull request #5480: URL: https://github.com/apache/geode/pull/5480 * Rebuilds GemFireVersion.properties on Git repo or property changes * version * build user * java version * productName * etc Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [n/a] Have you written or updated unit tests to verify your changes? - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Rebuild GemFireVersion.properties on build-flag changes > --- > > Key: GEODE-8458 > URL: https://issues.apache.org/jira/browse/GEODE-8458 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Robert Houghton >Priority: Major > > GemFireVersion.properties is a resource holding information about the product > and build metadata. It is possible to set these values for the first time > using Gradle property flags like '-Pversion=1.2.3-build.456'. On subsequent > runs, the property file should be re-built if those values have changed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
