[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489714#comment-17489714 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on pull request #823: URL: https://github.com/apache/geode-native/pull/823#issuecomment-1034043585 No, sorry. There is a ton of work left to get to a full client, and this particular attempt at a first cut may not even make it into the final product. You can build it yourself and use it's (extremely limited) functionality, but it's not up on Nuget and we don't post binaries for geode-native builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489678#comment-17489678 ] ASF GitHub Bot commented on GEODE-9360: --- prashant-upadhyay commented on pull request #823: URL: https://github.com/apache/geode-native/pull/823#issuecomment-1033966909 any public package available to use the .net core client of Geode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386487#comment-17386487 ] ASF subversion and git services commented on GEODE-9360: Commit d7445864c29d3b5e0152e7cad0dbd98278912436 in geode-native's branch refs/heads/develop from Blake Bender [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=d744586 ] GEODE-9360: Initial checkin of .net core support (#823) * GEODE-9360: Initial revision of Geode .net core library and tests Co-authored-by: Matthew Reddington Co-authored-by: Mike Martell > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386486#comment-17386486 ] ASF subversion and git services commented on GEODE-9360: Commit d7445864c29d3b5e0152e7cad0dbd98278912436 in geode-native's branch refs/heads/develop from Blake Bender [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=d744586 ] GEODE-9360: Initial checkin of .net core support (#823) * GEODE-9360: Initial revision of Geode .net core library and tests Co-authored-by: Matthew Reddington Co-authored-by: Mike Martell > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386488#comment-17386488 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey merged pull request #823: URL: https://github.com/apache/geode-native/pull/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384940#comment-17384940
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r674056114
##
File path: netcore/NetCore/IRegionService.cs
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+
+namespace Apache {
+ namespace Geode {
+namespace Client {
+ public interface IRegionService {
+//IPdxInstanceFactory CreatePdxInstanceFactory(String
className);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384938#comment-17384938
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r674049907
##
File path: netcore/NetCore.Test/xunit.runner.json
##
@@ -0,0 +1,5 @@
+{
+ "methodDisplay": "classAndMethod",
+ "parallelizeAssembly": true,
+ "parallelizeTestCollections": true
+}
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384937#comment-17384937
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r674049746
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+ [Collection("Geode .net Core Collection")]
+ public class CacheFactoryUnitTests {
+[Fact]
+public void TestCreateFactory() {
Review comment:
Removed `Test` prefix, and `Unit` from test class and test filename.
Added some more asserts, and made test case names a bit more descriptive where
warranted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384543#comment-17384543
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r673582739
##
File path: netcore/NetCore/Cache.cs
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using System.Collections.Generic;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+namespace Apache {
Review comment:
Totally - love that we can concatenate these in C#.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384542#comment-17384542
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r673582416
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+ [Collection("Geode .net Core Collection")]
+ public class CacheFactoryUnitTests {
Review comment:
Everything is now singular `Test`, and I removed `Unit` from all the
class names and renamed the files appropriately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384518#comment-17384518
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r673545627
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384509#comment-17384509 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r673536390 ## File path: .gitignore ## @@ -18,3 +18,7 @@ /tools/gnmsg/.idea/ /tools/gnmsg/__pycache__/ + +/netcore/*/bin/ Review comment: > Also, can you put these in a `.gitignore` in the `netcore` directory. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384455#comment-17384455 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r673434331 ## File path: .gitignore ## @@ -18,3 +18,7 @@ /tools/gnmsg/.idea/ /tools/gnmsg/__pycache__/ + +/netcore/*/bin/ Review comment: RIght, cmake generates the "old" style .csproj and .sln files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384453#comment-17384453 ] ASF GitHub Bot commented on GEODE-9360: --- pivotal-jbarrett commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r673427639 ## File path: .gitignore ## @@ -18,3 +18,7 @@ /tools/gnmsg/.idea/ /tools/gnmsg/__pycache__/ + +/netcore/*/bin/ Review comment: Ok, so this is a function you you checking in the csproj as source rather than generating it with CMake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384452#comment-17384452 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r673423735 ## File path: .gitignore ## @@ -18,3 +18,7 @@ /tools/gnmsg/.idea/ /tools/gnmsg/__pycache__/ + +/netcore/*/bin/ Review comment: > Is there any way to get .NET build tools to not build in the source tree? Not as far as I know. A quick web search yields a lot of info about MSBuild-style csproj files, but nothing about the new improved dotnet kind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382358#comment-17382358
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r671527167
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+ [Collection("Geode .net Core Collection")]
+ public class CacheFactoryUnitTests {
Review comment:
The naming convention used by the Java and C++ sources is `ClassTest(s)`
where `Class` is the class under testing and `Test` or `Tests` (not consistent)
is used to denote unit tests. Unit tests are also isolated away from other
forms of longer feedback tests, like integration, also suffixing them
`UnitTest` was deemed redundant.
##
File path: .gitignore
##
@@ -18,3 +18,7 @@
/tools/gnmsg/.idea/
/tools/gnmsg/__pycache__/
+
+/netcore/*/bin/
Review comment:
Is there any way to get .NET build tools to not build in the source tree?
##
File path: netcore/.clang-format
##
@@ -0,0 +1,3 @@
+---
+Language:CSharp
+BasedOnStyle: Google
Review comment:
YES!
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+ [Collection("Geode .net Core Collection")]
+ public class CacheFactoryUnitTests {
+[Fact]
+public void TestCreateFactory() {
Review comment:
Since all these methods are tests, does it make sense to redundantly
prefix them all with `Test`? If read in plain English you have "Fact, test
create factory." This is is not a complete fact. More appropriately it should
be called `CacheFactoryCreateIsNotNull` read as "Fact, CacheFactory.Create is
not null", which is an asserted fact of this test.
##
File path: netcore/NetCore/IRegionService.cs
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+
+namespace Apache {
+ namespace Geode {
+namespace Client {
+ public interface IRegionService {
+//IPdxInstanceFactory CreatePdxInstanceFactory(String
className);
Review comment:
Delete commented out code.
##
File path: netcore/scripts/run-clang-format.cmd
##
@@ -0,0 +1,
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381434#comment-17381434 ] ASF GitHub Bot commented on GEODE-9360: --- mmartell commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r670594434 ## File path: netcore/NetCore/NetCore.csproj ## @@ -0,0 +1,10 @@ + + + +netcoreapp3.1 Review comment: Good catch! 5 looks like more of an interim release for unification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378225#comment-17378225 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r667134346 ## File path: netcore/utility/UserPasswordAuthInit.java ## @@ -0,0 +1,81 @@ +/* Review comment: Don't think it makes sense right now to modify the Java code, since we'll ultimately be removing it and building from a shared directory. Again, https://issues.apache.org/jira/browse/GEODE-9422 is tracking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378222#comment-17378222
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r667133615
##
File path: netcore/utility/SimpleSecurityManager.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javaobject;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.SecurityManager;
+
+import java.util.Properties;
+
+import javaobject.UserPasswordAuthInit;
+import javaobject.UsernamePrincipal;
+
+/**
+ * This Security manager only Authenticates - and allows any operations.
+ */
+public class SimpleSecurityManager implements SecurityManager {
Review comment:
https://issues.apache.org/jira/browse/GEODE-9422 filed to remove
duplicate Java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378219#comment-17378219 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r667130870 ## File path: netcore/geode-dotnet-core.sln ## @@ -0,0 +1,31 @@ + Review comment: FWIW, based on earlier comments I moved us back to .net core 3.1 until such time as we can go to v6. So don't bother installing 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376662#comment-17376662 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r665497262 ## File path: netcore/startserver.ps1 ## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Moved all scripts to `/scripts` dir at root of netcore tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376660#comment-17376660
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r665496736
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
Added minimal `.clang-format` file and reformatted the code. Using
Google style guide by default, since we know from past queries that no one on
the team has strong opinions re: style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376657#comment-17376657
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r665494772
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fact]
+public void TestCreateFactory()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+Assert.NotNull(cacheFactory);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetVersion()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var version = cacheFactory.Version;
+Assert.NotEqual(version, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetProductDescription()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var description = cacheFactory.ProductDescription;
+Assert.NotEqual(description, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxIgnoreUnreadFields()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxIgnoreUnreadFields = true;
+cacheFactory.PdxIgnoreUnreadFields = false;
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxReadSerialized()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxReadSerialized = true;
+cacheFactory.PdxReadSerialized = false;
+}
+}
+
+[Fact]
+public void TestCacheFactoryCreateCache()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+using (var cache = cacheFactory.CreateCache()) // lgtm[cs /
useless - assignment - to - local]
+{
+;
+}
+}
+}
+
+[Fact]
+public void TestCacheFactorySetProperty()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.SetProperty("log-level", "none")
+.SetProperty("log-file", "geode_native.log");
+}
+}
+}
+}
Review comment:
Manually added newline at EOF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376656#comment-17376656
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r665493595
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fact]
+public void TestCreateFactory()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+Assert.NotNull(cacheFactory);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetVersion()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var version = cacheFactory.Version;
+Assert.NotEqual(version, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetProductDescription()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var description = cacheFactory.ProductDescription;
+Assert.NotEqual(description, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxIgnoreUnreadFields()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxIgnoreUnreadFields = true;
+cacheFactory.PdxIgnoreUnreadFields = false;
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxReadSerialized()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxReadSerialized = true;
+cacheFactory.PdxReadSerialized = false;
+}
+}
+
+[Fact]
+public void TestCacheFactoryCreateCache()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+using (var cache = cacheFactory.CreateCache()) // lgtm[cs /
useless - assignment - to - local]
+{
+;
+}
+}
+}
+
+[Fact]
+public void TestCacheFactorySetProperty()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.SetProperty("log-level", "none")
+.SetProperty("log-file", "geode_native.log");
+}
+}
+}
+}
Review comment:
After a bit of Googling, it is pretty apparent to me that `clang-format`
does _not_ enforce this, and I can only conclude this is why we can't have nice
things >:(. Also disappointing, Visual Studio likewise appears to lack this
feature. It is available as an option in the `clang-format` VS _plugin_ and in
VS Code, again via a plugin, neither of which is particularly helpful given
that `clang-format` on Windows has a bad habit of formatting differently than
on other platforms. What a mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375960#comment-17375960 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r664819175 ## File path: netcore/utility/CMakeLists.txt ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +cmake_minimum_required (VERSION 3.4) Review comment: Bumped to 3.10, that's what most of the rest of the tree seems to want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375912#comment-17375912 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r664770220 ## File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs ## @@ -0,0 +1,97 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +using System; +using Apache.Geode.NetCore; Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375903#comment-17375903 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r664757865 ## File path: netcore/NOTICE ## @@ -0,0 +1,6 @@ +Apache Geode Review comment: removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375900#comment-17375900 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r664753303 ## File path: netcore/LICENSE ## @@ -0,0 +1,201 @@ + Apache License Review comment: removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375898#comment-17375898 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r664752008 ## File path: netcore/NetCore/NetCore.csproj ## @@ -0,0 +1,10 @@ + + + +netcoreapp3.1 Review comment: Actually wait - we need to stick with 3.1. 3.1 is LTS, 5 is not, it's some weird interim release that we should just ignore. 3.1 is actually supported _longer_ than 5, and we can go directly from 3.1 to 6 in the fall when it comes out - see this tech note: https://dotnet.microsoft.com/platform/support/policy/dotnet-core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371812#comment-17371812
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r661131144
##
File path: netcore/NetCore/CacheFactory.cs
##
@@ -0,0 +1,129 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using System.Runtime.InteropServices;
+
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
Review comment:
Yes, C# supports a single line namespace.
```C#
namespace Apache.Geode.Client {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371523#comment-17371523
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r660792414
##
File path: netcore/utility/SimpleSecurityManager.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javaobject;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.SecurityManager;
+
+import java.util.Properties;
+
+import javaobject.UserPasswordAuthInit;
+import javaobject.UsernamePrincipal;
+
+/**
+ * This Security manager only Authenticates - and allows any operations.
+ */
+public class SimpleSecurityManager implements SecurityManager {
Review comment:
I am cool with that. Of all the issues raised in this PR I think we only
need to address the namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371522#comment-17371522
]
ASF GitHub Bot commented on GEODE-9360:
---
echobravopapa commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r660788600
##
File path: netcore/utility/SimpleSecurityManager.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javaobject;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.SecurityManager;
+
+import java.util.Properties;
+
+import javaobject.UserPasswordAuthInit;
+import javaobject.UsernamePrincipal;
+
+/**
+ * This Security manager only Authenticates - and allows any operations.
+ */
+public class SimpleSecurityManager implements SecurityManager {
Review comment:
@pivotal-jbarrett would you be opposed to follow on ticket(s) to address
these examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371378#comment-17371378
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659921472
##
File path: netcore/LICENSE
##
@@ -0,0 +1,201 @@
+ Apache License
Review comment:
This directory does not need to carry a separate license file. The root
of the repository has the appropriate license.
##
File path: netcore/NetCore/CacheFactory.cs
##
@@ -0,0 +1,129 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using System.Runtime.InteropServices;
+
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+public class CacheFactory : GeodeNativeObject, ICacheFactory
+{
+private string _version = String.Empty;
Review comment:
From this convention of `_` before a name it looks like you have derived
from
https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions.
Let's get this documented an enforced.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
In our contributing guide we should have a mention of the style guide
use for .NET Core sources. We never derived one for the old .NET Framework
C++/CLI sources because they were C++ based and loosely followed the C++ style
where it was even possible to apply it. No tooling completely supported C++/CLI
formatting so it is largely a mess. There is plenty of C# formatting tooling
out there including `clang-format`. Since `clang-format` is already a
requirement for C++ source formatting it make sense to extend it to C# sources
with the agreed apon style applied.
##
File path: netcore/NOTICE
##
@@ -0,0 +1,6 @@
+Apache Geode
Review comment:
Same as license, no need for notice here.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fa
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371355#comment-17371355
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659917215
##
File path: netcore/NetCore/NetCore.csproj
##
@@ -0,0 +1,10 @@
+
+
+
+netcoreapp3.1
+Apache.Geode.NetCore
+Apache.Geode.NetCore
+AnyCPU;x64
Review comment:
Fixed.
##
File path: netcore/NetCore/Constants.cs
##
@@ -0,0 +1,30 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+
+public class Constants
+{
+public const string libPath = "apache-geode-c";
Review comment:
Handy (and probably necessary) feature :).
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
Review comment:
I've been leaning that way too. It will make porting ever-so-slightly
easier, if nothing else.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
Works for me, though it does lend more urgency to the task to find a
!@#$)*(&!@^$ version of `clang-format` that's consistent across platforms.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+u
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370751#comment-17370751 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659977903 ## File path: netcore/utility/UserPasswordAuthInit.java ## @@ -0,0 +1,81 @@ +/* Review comment: Will look into this. I just copied in the minimal amount to build the existing fake `SecurityManager` class without editing Java code. We're probably just being lazy in the Java code and referring to something we shouldn't be. May want to fix this in the main tree as well, same for the required `cmake` version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370750#comment-17370750
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659976430
##
File path: netcore/utility/SimpleSecurityManager.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package javaobject;
+
+import org.apache.geode.security.AuthenticationFailedException;
+import org.apache.geode.security.SecurityManager;
+
+import java.util.Properties;
+
+import javaobject.UserPasswordAuthInit;
+import javaobject.UsernamePrincipal;
+
+/**
+ * This Security manager only Authenticates - and allows any operations.
+ */
+public class SimpleSecurityManager implements SecurityManager {
Review comment:
Copied this from the main repo, because the earlier procedure was clumsy:
* Build NC
* Build installer
* Build examples (this builds the .jar file)
* set environment variable to root of the example build, so that
`startserver.sh/startserver.ps1` can set CLASSPATH in `gfsh` command
I'm open to suggestions for improvement, but not a fan of tying .net core
build to the main build, especially not (ugh!) the examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370738#comment-17370738 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659973041 ## File path: netcore/geode-dotnet-core.sln ## @@ -0,0 +1,31 @@ + Review comment: Sorry, forgot to answer your question: Yes, you should be able to build and run tests on Mac without any IDE, just an install of the .net 5.0 SDK. I'm working on a BUILDING.md for .net core, but the short version is: * Install .net 5.0 SDK and set up PATH to tools * From $GeodeNative_ROOT/netcore: `dotnet build` `startserver.sh` `dotnet test` `stopserver.sh` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370731#comment-17370731 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659965672 ## File path: netcore/geode-dotnet-core.sln ## @@ -0,0 +1,31 @@ + Review comment: Yeah, it's weird, esp given that the new format is so darned simplified. What we know so far about the new solution/project format: * Mac and Linux platforms can be a little "grumpy" about the ones created in VS2019, though they ostensibly read em. We haven't characterized the issue(s) yet, but for right now I would avoid messing with project files in VS2019. * VS2019, JetBrains Rider, and VS Code can read, build, and test with them, on all platforms * The preferred way to edit them appears to be `dotnet` command from the command line. This is actually awesome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370725#comment-17370725 ] ASF GitHub Bot commented on GEODE-9360: --- pivotal-jbarrett commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659948766 ## File path: netcore/geode-dotnet-core.sln ## @@ -0,0 +1,31 @@ + Review comment: That seems odd to me since most of the work to support C# and .NET in CMake is for .NET Core but perhaps with an emphasis on not being stuck with VS build as the build toolkit. Since I should be able to build .NET Core on my Mac I shouldn't need VS Studio and build tools to do so right? Something we should certainly improve on because checking in any project files has never gone well in all of the history of software development. ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370723#comment-17370723
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659946703
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fact]
+public void TestCreateFactory()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+Assert.NotNull(cacheFactory);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetVersion()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var version = cacheFactory.Version;
+Assert.NotEqual(version, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetProductDescription()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var description = cacheFactory.ProductDescription;
+Assert.NotEqual(description, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxIgnoreUnreadFields()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxIgnoreUnreadFields = true;
+cacheFactory.PdxIgnoreUnreadFields = false;
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxReadSerialized()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxReadSerialized = true;
+cacheFactory.PdxReadSerialized = false;
+}
+}
+
+[Fact]
+public void TestCacheFactoryCreateCache()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+using (var cache = cacheFactory.CreateCache()) // lgtm[cs /
useless - assignment - to - local]
+{
+;
+}
+}
+}
+
+[Fact]
+public void TestCacheFactorySetProperty()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.SetProperty("log-level", "none")
+.SetProperty("log-file", "geode_native.log");
+}
+}
+}
+}
Review comment:
clang-format will enforce for sure. Kind of surprised the VS formatter
didn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370721#comment-17370721
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659946185
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
I think adding in C# will have less urgency given that 99% of the work
will likely be on Windows anyway. I also thing the variants in formatting are
much fewer than C++ given the relative age ad popularity C++ has of C#.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
I think adding in C# will have less urgency given that 99% of the work
will likely be on Windows anyway. I also thing the variants in formatting are
much fewer than C++ given the relative age and popularity C++ has of C#.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370719#comment-17370719 ] ASF GitHub Bot commented on GEODE-9360: --- pivotal-jbarrett commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659945257 ## File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs ## @@ -0,0 +1,97 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +using System; +using Apache.Geode.NetCore; Review comment: It will be very complicated to change after the first non-beta release too, so sooner than later on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370716#comment-17370716 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659940754 ## File path: netcore/geode-dotnet-core.sln ## @@ -0,0 +1,31 @@ + Review comment: cmake can't, as far as we can tell, generate the "new, improved" .sln and .csproj files to target .net core. Quite a bit of online chatter about it, but nothing conclusive, and our investigation of it has not yielded any working solution. Since the new files are _insanely_ simple, we decided not to spend further cycles on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370712#comment-17370712
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659939227
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fact]
+public void TestCreateFactory()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+Assert.NotNull(cacheFactory);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetVersion()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var version = cacheFactory.Version;
+Assert.NotEqual(version, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactoryGetProductDescription()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+var description = cacheFactory.ProductDescription;
+Assert.NotEqual(description, String.Empty);
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxIgnoreUnreadFields()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxIgnoreUnreadFields = true;
+cacheFactory.PdxIgnoreUnreadFields = false;
+}
+}
+
+[Fact]
+public void TestCacheFactorySetPdxReadSerialized()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.PdxReadSerialized = true;
+cacheFactory.PdxReadSerialized = false;
+}
+}
+
+[Fact]
+public void TestCacheFactoryCreateCache()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+using (var cache = cacheFactory.CreateCache()) // lgtm[cs /
useless - assignment - to - local]
+{
+;
+}
+}
+}
+
+[Fact]
+public void TestCacheFactorySetProperty()
+{
+using (var cacheFactory = CacheFactory.Create())
+{
+cacheFactory.SetProperty("log-level", "none")
+.SetProperty("log-file", "geode_native.log");
+}
+}
+}
+}
Review comment:
So much better if I can just rely on a formatter to fix stuff like this
for me :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370710#comment-17370710
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659938815
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
Works for me, though it does lend more urgency to the task to find a
!@#$)*(&!@^$ version of `clang-format` that's consistent across platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370708#comment-17370708 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659938137 ## File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs ## @@ -0,0 +1,97 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +using System; +using Apache.Geode.NetCore; Review comment: I've been leaning that way too. It will make porting ever-so-slightly easier, if nothing else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370706#comment-17370706
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659921472
##
File path: netcore/LICENSE
##
@@ -0,0 +1,201 @@
+ Apache License
Review comment:
This directory does not need to carry a separate license file. The root
of the repository has the appropriate license.
##
File path: netcore/NetCore/CacheFactory.cs
##
@@ -0,0 +1,129 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using System.Runtime.InteropServices;
+
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+public class CacheFactory : GeodeNativeObject, ICacheFactory
+{
+private string _version = String.Empty;
Review comment:
From this convention of `_` before a name it looks like you have derived
from
https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions.
Let's get this documented an enforced.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
Review comment:
In our contributing guide we should have a mention of the style guide
use for .NET Core sources. We never derived one for the old .NET Framework
C++/CLI sources because they were C++ based and loosely followed the C++ style
where it was even possible to apply it. No tooling completely supported C++/CLI
formatting so it is largely a mess. There is plenty of C# formatting tooling
out there including `clang-format`. Since `clang-format` is already a
requirement for C++ source formatting it make sense to extend it to C# sources
with the agreed apon style applied.
##
File path: netcore/NOTICE
##
@@ -0,0 +1,6 @@
+Apache Geode
Review comment:
Same as license, no need for notice here.
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+using System;
+using Apache.Geode.NetCore;
+using Xunit;
+
+namespace GemfireDotNetTest
+{
+[Collection("Geode .net Core Collection")]
+public class CacheFactoryUnitTests
+{
+[Fa
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370685#comment-17370685
]
ASF GitHub Bot commented on GEODE-9360:
---
pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r659917708
##
File path: netcore/NetCore/Constants.cs
##
@@ -0,0 +1,30 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+
+public class Constants
+{
+public const string libPath = "apache-geode-c";
Review comment:
Handy (and probably necessary) feature :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370684#comment-17370684 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r659917215 ## File path: netcore/NetCore/NetCore.csproj ## @@ -0,0 +1,10 @@ + + + +netcoreapp3.1 +Apache.Geode.NetCore +Apache.Geode.NetCore +AnyCPU;x64 Review comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369611#comment-17369611 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r658926272 ## File path: netcore/NetCore/NetCore.csproj ## @@ -0,0 +1,10 @@ + + + +netcoreapp3.1 Review comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369102#comment-17369102 ] ASF GitHub Bot commented on GEODE-9360: --- lgtm-com[bot] commented on pull request #823: URL: https://github.com/apache/geode-native/pull/823#issuecomment-867987623 This pull request **introduces 8 alerts** when merging 8ea159a0e65007d7101a0404f4819f3029012608 into f6b0ef6634ebf9f8fa58e04478fe47307a238167 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-86c6bc488d6c6a168fd3d6985c887ffab660d0a3) **new alerts:** * 8 for Useless assignment to local variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368914#comment-17368914
]
ASF GitHub Bot commented on GEODE-9360:
---
mmartell commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r658016638
##
File path: netcore/NetCore/NetCore.csproj
##
@@ -0,0 +1,10 @@
+
+
+
+netcoreapp3.1
Review comment:
Change to netcoreapp5.0. I see no need to support 3.1.
##
File path: netcore/NetCore/Constants.cs
##
@@ -0,0 +1,30 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+namespace Apache
+{
+namespace Geode
+{
+namespace NetCore
+{
+
+public class Constants
+{
+public const string libPath = "apache-geode-c";
Review comment:
Nice. P/Invoke handles the abstraction, so will resolve to:
- libapache-geode-c.dylib on OSX
- libapache-geode-c.so on Linux
- apache-geode-c.dll on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native
> API. To facilitate this, we need to implement a minimal set of C# classes
> that use p/invoke to access geode-native via C bindings (GEODE-9358).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368897#comment-17368897 ] ASF GitHub Bot commented on GEODE-9360: --- mmartell commented on a change in pull request #823: URL: https://github.com/apache/geode-native/pull/823#discussion_r658014419 ## File path: netcore/NetCore/NetCore.csproj ## @@ -0,0 +1,10 @@ + + + +netcoreapp3.1 +Apache.Geode.NetCore +Apache.Geode.NetCore +AnyCPU;x64 Review comment: AnyCPU should be removed as we don't support 32 bits. Note: I doubt this would create any problems (we have no 32 dependencies), but doesn't hurt to be explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367704#comment-17367704 ] ASF GitHub Bot commented on GEODE-9360: --- lgtm-com[bot] commented on pull request #823: URL: https://github.com/apache/geode-native/pull/823#issuecomment-866358526 This pull request **introduces 8 alerts** when merging e2429240d7952a71842d5e5fc67c7e7e76009131 into f6b0ef6634ebf9f8fa58e04478fe47307a238167 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-dc431a3087a93cf5247dbe5a3a7ac04e7fcd20ab) **new alerts:** * 8 for Useless assignment to local variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367685#comment-17367685 ] ASF GitHub Bot commented on GEODE-9360: --- lgtm-com[bot] commented on pull request #823: URL: https://github.com/apache/geode-native/pull/823#issuecomment-866340358 This pull request **introduces 9 alerts** when merging 9ee58f1505c5a4f6372a2a7527d6ea96f74fcae8 into f6b0ef6634ebf9f8fa58e04478fe47307a238167 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-f076e865735722df6eaacf5735e03d4dbd98ac34) **new alerts:** * 9 for Useless assignment to local variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367667#comment-17367667 ] ASF GitHub Bot commented on GEODE-9360: --- lgtm-com[bot] commented on pull request #823: URL: https://github.com/apache/geode-native/pull/823#issuecomment-866317624 This pull request **introduces 9 alerts** when merging 12ffdba3ab53f7be430eba60a0ee2ae15d7d021c into f6b0ef6634ebf9f8fa58e04478fe47307a238167 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-56131b3fcdadde0464867b8cef2310e9d91635e9) **new alerts:** * 9 for Useless assignment to local variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[ https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367657#comment-17367657 ] ASF GitHub Bot commented on GEODE-9360: --- pdxcodemonkey opened a new pull request #823: URL: https://github.com/apache/geode-native/pull/823 Still a long way to go with this, but basic put/get/remove of strings works, along with infrastructure to get there, and AuthInitialize. To build, after installing .net core: * `dotnet build` from `/netcore` in `geode-native` tree To run tests: * Add `geode-native` library directory to `$PATH` (Windows) or `$LD_LIBRARY_PATH` (Linux), or * Put `geode-native` library and `apache-geode-c` library in standard library location (Linux, MacOS), or * Put `geode-native` library and `apache-geode-c` library in app working directory (Windows, MacOS), then * `dotnet test` from `/netcore` in `geode-native` tree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Initial revision of .net core support > - > > Key: GEODE-9360 > URL: https://issues.apache.org/jira/browse/GEODE-9360 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Priority: Major > > As a .net core developer, I would like to be able to access the geode-native > API. To facilitate this, we need to implement a minimal set of C# classes > that use p/invoke to access geode-native via C bindings (GEODE-9358). -- This message was sent by Atlassian Jira (v8.3.4#803005)
