[jira] [Assigned] (GEODE-8347) use benchmarks branch corresponding to geode branch
[ https://issues.apache.org/jira/browse/GEODE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols reassigned GEODE-8347: --- Assignee: Owen Nichols > use benchmarks branch corresponding to geode branch > --- > > Key: GEODE-8347 > URL: https://issues.apache.org/jira/browse/GEODE-8347 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > Geode 1.12 release included geode-benchmarks from support/1.12, but the > pipeline definition is still using benchmarks from develop, as is 1.13. Fix > to use matching branch names between geode and geode-examples. Also need to > rebalance max_in_flight based on how long each benchmark job takes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8347) use benchmarks branch corresponding to geode branch
[ https://issues.apache.org/jira/browse/GEODE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154306#comment-17154306 ] ASF GitHub Bot commented on GEODE-8347: --- onichols-pivotal opened a new pull request #5361: URL: https://github.com/apache/geode/pull/5361 Geode 1.12 release included geode-benchmarks from support/1.12, but the pipeline definition is still using benchmarks from develop, as is 1.13. Fix to use matching branch names between geode and geode-examples. Also rebalance max_in_flight based on how long each benchmark job takes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > use benchmarks branch corresponding to geode branch > --- > > Key: GEODE-8347 > URL: https://issues.apache.org/jira/browse/GEODE-8347 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > Geode 1.12 release included geode-benchmarks from support/1.12, but the > pipeline definition is still using benchmarks from develop, as is 1.13. Fix > to use matching branch names between geode and geode-examples. Also need to > rebalance max_in_flight based on how long each benchmark job takes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8347) use benchmarks branch corresponding to geode branch
Owen Nichols created GEODE-8347: --- Summary: use benchmarks branch corresponding to geode branch Key: GEODE-8347 URL: https://issues.apache.org/jira/browse/GEODE-8347 Project: Geode Issue Type: Improvement Components: ci Reporter: Owen Nichols Geode 1.12 release included geode-benchmarks from support/1.12, but the pipeline definition is still using benchmarks from develop, as is 1.13. Fix to use matching branch names between geode and geode-examples. Also need to rebalance max_in_flight based on how long each benchmark job takes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[ https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154709#comment-17154709 ] ASF GitHub Bot commented on GEODE-7956: --- davebarnes97 opened a new pull request #5362: URL: https://github.com/apache/geode/pull/5362 Fix how the back-quote is displayed in the compiled user guide. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct documentation of legal region names > --- > > Key: GEODE-7956 > URL: https://issues.apache.org/jira/browse/GEODE-7956 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Darrel Schneider >Assignee: Mario Kevo >Priority: Major > Fix For: 1.13.0, 1.14.0 > > > According to this: > https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html > region names can only contain alphanumeric, dash, and underscore. > But the product also supports a dot '.'. > See RegionNameValidation and RegionNameValidationTest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8298) member version comparison sense inconsistent when deciding on multicast
[
https://issues.apache.org/jira/browse/GEODE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Burcham updated GEODE-8298:
Description:
Since about 2014 when we introduced the {{Version}} class to replace use of
{{short}}s all over the place for serialization versions, these two loops in
{{GMSMembership.processView()}} have used comparisons that disagree in sense:
{code}
// We perform the update under a global lock so that other
// incoming events will not be lost in terms of our global view.
latestViewWriteLock.lock();
try {
// first determine the version for multicast message serialization
VersionOrdinal version = Version.CURRENT;
for (final Entry internalIDLongEntry : surpriseMembers
.entrySet()) {
ID mbr = internalIDLongEntry.getKey();
final VersionOrdinal itsVersion = mbr.getVersionObject();
if (itsVersion != null && version.compareTo(itsVersion) < 0) {
version = itsVersion;
}
}
for (ID mbr : newView.getMembers()) {
final VersionOrdinal itsVersion = mbr.getVersionObject();
if (itsVersion != null && itsVersion.compareTo(version) < 0) {
version = mbr.getVersionObject();
}
}
disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
{code}
The goal here is to find the oldest version and if that version is older than
our local version we disable multicast. So we want to put the minimum into
{{version}}. So the first loop's comparison is wrong and the second one is
right.
While we are in here let's combine the two loops using
{{Stream.concat(surpriseMembers.entrySet().stream().map(entry->entry.getKey()),
newView.getMembers().stream()).forEach(member -> ...)}}.
Alternatives are described here:
https://www.baeldung.com/java-combine-multiple-collections
Once we have the combined {{Iterable}} we can use something like
{{Collections.min()}} to find the minimum in one swell foop and this whole
thing collapses to one or two declarative expressions.
When this story is complete, the functionality will be in a separate method and
we'll have a unit test for it.
was:
Since about 2014 when we introduced the {{Version}} class to replace use of
{{short}}s all over the place for serialization versions, these two loops in
{{GMSMembership.processView()}} have used comparisons that disagree in sense:
{code}
// We perform the update under a global lock so that other
// incoming events will not be lost in terms of our global view.
latestViewWriteLock.lock();
try {
// first determine the version for multicast message serialization
VersionOrdinal version = Version.CURRENT;
for (final Entry internalIDLongEntry : surpriseMembers
.entrySet()) {
ID mbr = internalIDLongEntry.getKey();
final VersionOrdinal itsVersion = mbr.getVersionObject();
if (itsVersion != null && version.compareTo(itsVersion) < 0) {
version = itsVersion;
}
}
for (ID mbr : newView.getMembers()) {
final VersionOrdinal itsVersion = mbr.getVersionObject();
if (itsVersion != null && itsVersion.compareTo(version) < 0) {
version = mbr.getVersionObject();
}
}
disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
{code}
The goal here is to find the oldest version and if that version is older than
our local version we disable multicast. So we want to put the minimum into
{{version}}. So the first loop's comparison is wrong and the second one is
right.
While we are in here let's combine the two loops using a {{Iterable}}
combinator like Guava's {{Iterables.concat()}} or Apache Commons Collections
{{IterableUtils.chainedIterable()}} to combine the two iterables:
{{surpriseMembers}} and {{newView.getMembers()}} into one iterable. If we don't
want to introduce either of those two libraries into the product we can write
our own {{concat()}} utility like the one described here:
https://www.baeldung.com/java-combine-multiple-collections
Once we have the combined {{Iterable}} we can use something like
{{Collections.min()}} to find the minimum in one swell foop and this whole
thing collapses to one or two declarative expressions.
When this story is complete, the functionality will be in a separate method and
we'll have a unit test for it.
> member version comparison sense inconsistent when deciding on multicast
> ---
>
> Key: GEODE-8298
> URL: https://issues.apache.org/jira/browse/GEODE-8298
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Bill Burcham
>Priority: Major
> Labels: starter
>
> Since about 2014 when we introduced the {{Version}} class to replace use of
>
[jira] [Commented] (GEODE-8302) WAN Conflation stats are being incorrectly incremented
[
https://issues.apache.org/jira/browse/GEODE-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154731#comment-17154731
]
ASF GitHub Bot commented on GEODE-8302:
---
alb3rtobr commented on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-656236457
@nabarunnag I agree that is not recommended to include more than one ticket
solution in the same commit, but in this case one ticket is a subset of the
other one. Luckily Alberto has solved the bigger one, that as a side effect
solves the other. Or even you can think that it is invalidating the other one,
as it cannot be reproduced after merging GEODE-8302.
Anyway independently of the decision taken, GEODE-8302 can be merged into
develop if there is no other problem with the review. Then Alberto could
prepare a separate PR with the code of GEODE-8320 that will result on an empty
commit in develop because the code is already there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> WAN Conflation stats are being incorrectly incremented
> --
>
> Key: GEODE-8302
> URL: https://issues.apache.org/jira/browse/GEODE-8302
> Project: Geode
> Issue Type: Bug
> Components: statistics, wan
>Affects Versions: 1.14.0
>Reporter: Donal Evans
>Assignee: Alberto Gomez
>Priority: Major
>
> When the below diff (which adds checks to confirm that conflation stats are
> not incremented in WAN tests with conflation disabled) is applied, the
> modified tests fail due to conflation stats being incorrectly incremented.
> This behaviour is only observed since the changes included in this PR were
> introduced: https://github.com/apache/geode/pull/4928
> {noformat}
> diff --git
> a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
>
> b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
> index b2ed76728f..bc6beb0002 100644
> ---
> a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
> +++
> b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
> @@ -209,6 +209,7 @@ public class SerialWANStatsDUnitTest extends WANTestBase {
>
> vm4.invoke(() -> WANTestBase.checkQueueStats("ln", 0, entries, entries,
> entries));
> vm4.invoke(() -> WANTestBase.checkBatchStats("ln", 1, true));
> +vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
>
> // wait until queue is empty
> vm5.invoke(() -> await()
> @@ -354,6 +355,7 @@ public class SerialWANStatsDUnitTest extends WANTestBase {
>
> vm4.invoke(() -> WANTestBase.checkQueueStats("ln", 0, entries, entries,
> entries));
> vm4.invoke(() -> WANTestBase.checkBatchStats("ln", 2, true, true));
> +vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
>
> // wait until queue is empty
> vm5.invoke(() -> await()
> {noformat}
> In addition to the tests above,
> SerialWANPropagation_PartitionedRegionDUnitTest.testPartitionedSerialPropagationHA()
> fails with incorrectly incremented conflation stats if a similar check is
> introduced at the end of the test. Again, without the changes introduced by
> PR #4928, this modified test passes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8326) CI Failure: FixedPartitioningWithTransactionDistributedTest.clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled times out waiting for client metadata
[
https://issues.apache.org/jira/browse/GEODE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154758#comment-17154758
]
ASF GitHub Bot commented on GEODE-8326:
---
pivotal-eshu commented on pull request #5358:
URL: https://github.com/apache/geode/pull/5358#issuecomment-656260343
Thanks for pointing out the default timeout time. I have updated the test so
that stack dump can be generated if failed again.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI Failure:
> FixedPartitioningWithTransactionDistributedTest.clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled
> times out waiting for client metadata
> ---
>
> Key: GEODE-8326
> URL: https://issues.apache.org/jira/browse/GEODE-8326
> Project: Geode
> Issue Type: Bug
> Components: client/server, tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> CI Failure:
> http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0296/test-results/distributedTest/1592846714/
> {noformat}
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest
> >
> clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled[ExecuteFunctionByObject]
> FAILED
> org.awaitility.core.ConditionTimeoutException: Condition with lambda
> expression in
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest
> that uses org.apache.geode.cache.client.internal.ClientMetadataService was
> not fulfilled within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> at
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> at
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest.forceClientMetadataUpdate(FixedPartitioningWithTransactionDistributedTest.java:241)
> at
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest.doFunctionTransactionAndSuspend(FixedPartitioningWithTransactionDistributedTest.java:458)
> at
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest.clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled(FixedPartitioningWithTransactionDistributedTest.java:254)
> {noformat}
> The failure occurs after waiting 5 minutes for the ClientMetadataService to
> stabilize. See ClientMetadataService#isMetadataStable.
> The timeout occurs within a block of test code that was introduced by Jake in
> PR #3840:
> {noformat}
> GEODE-7006: Fixes function execution by id with transactions. (#3840)
> * Fixes test to force and wait for PR metadata to update.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8349) reinstate use of SSLSocket for cluster communication
Bruce J Schuchardt created GEODE-8349: - Summary: reinstate use of SSLSocket for cluster communication Key: GEODE-8349 URL: https://issues.apache.org/jira/browse/GEODE-8349 Project: Geode Issue Type: Bug Components: membership, messaging Reporter: Bruce J Schuchardt We've found problems with "new IO"'s SSLEngine with respect to support for TLSV1. We've also seen anomalous performance using that secure communications mechanism. The introduction of the use of the "new IO" SSLEngine was originally to 1) reduce code complexity in the org.apache.geode.internal.tcp package and 2) to set the stage for its use in client/server communications so that selectors could be used in c/s communications. This ticket aims to reintroduce the use of SSLSocket in cluster communications without restoring the old, poorly tested SSL code paths. The new implementation should have as good or better performance than the previous"old IO" implementation and the more recent "new IO" SSLEngine implementation as well. This should be apparent in the CI benchmark jobs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154849#comment-17154849 ] ASF subversion and git services commented on GEODE-7676: Commit 75ae5912f83a9cd12516726532574d70b7774c45 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=75ae591 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154848#comment-17154848 ] ASF subversion and git services commented on GEODE-7983: Commit 32f59fc78357aa5fdd28358c716cc4d7e6f5f1b7 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=32f59fc ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154847#comment-17154847 ] ASF subversion and git services commented on GEODE-7912: Commit 2840a19ce2fc35796a3197f215bee7b62da36c2f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2840a19 ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154853#comment-17154853 ] ASF subversion and git services commented on GEODE-7667: Commit 2e8c7a8ccbb8c7d60c69e0a70b3ca9205a529eb8 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2e8c7a8 ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154841#comment-17154841 ] ASF subversion and git services commented on GEODE-7667: Commit 2e8c7a8ccbb8c7d60c69e0a70b3ca9205a529eb8 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2e8c7a8 ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154842#comment-17154842 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154843#comment-17154843 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154834#comment-17154834 ] ASF subversion and git services commented on GEODE-7912: Commit 2840a19ce2fc35796a3197f215bee7b62da36c2f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2840a19 ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException
[
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154839#comment-17154839
]
ASF subversion and git services commented on GEODE-7894:
Commit 43192d27213b458db38cdbf14f4cec7f484c717b in geode's branch
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43192d2 ]
GEODE-7894: Moving expiry tasks to AbstractRegion.
> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
> Labels: flakey
> Fix For: 1.13.0
>
>
> See:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest >
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT tid=215] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154838#comment-17154838 ] ASF subversion and git services commented on GEODE-7676: Commit c78064a23c9897b39056a78ffdcec53bb5b80266 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c78064a ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154845#comment-17154845 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154835#comment-17154835 ] ASF subversion and git services commented on GEODE-7983: Commit 32f59fc78357aa5fdd28358c716cc4d7e6f5f1b7 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=32f59fc ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154846#comment-17154846 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154837#comment-17154837 ] ASF subversion and git services commented on GEODE-7667: Commit 9bf176cc7822f7328fef80e9f0797293d6f4e98e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9bf176c ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154844#comment-17154844 ] ASF subversion and git services commented on GEODE-7669: Commit b49e67cb9dee328221d7052d4b8c8f70c9210929 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b49e67c ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException
[
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154852#comment-17154852
]
ASF subversion and git services commented on GEODE-7894:
Commit 43192d27213b458db38cdbf14f4cec7f484c717b in geode's branch
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43192d2 ]
GEODE-7894: Moving expiry tasks to AbstractRegion.
> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
> Labels: flakey
> Fix For: 1.13.0
>
>
> See:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest >
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT tid=215] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154857#comment-17154857 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154850#comment-17154850 ] ASF subversion and git services commented on GEODE-7667: Commit 9bf176cc7822f7328fef80e9f0797293d6f4e98e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9bf176c ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154851#comment-17154851 ] ASF subversion and git services commented on GEODE-7676: Commit c78064a23c9897b39056a78ffdcec53bb5b80266 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c78064a ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154858#comment-17154858 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154855#comment-17154855 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154856#comment-17154856 ] ASF subversion and git services commented on GEODE-7669: Commit b49e67cb9dee328221d7052d4b8c8f70c9210929 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b49e67c ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8348) CI does not build benchmarks image
Sean Goller created GEODE-8348: -- Summary: CI does not build benchmarks image Key: GEODE-8348 URL: https://issues.apache.org/jira/browse/GEODE-8348 Project: Geode Issue Type: Bug Components: ci Reporter: Sean Goller The CI infrastructure relies on the existence of a google compute image in order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8315) Upgrade Shiro to 1.5.3
[ https://issues.apache.org/jira/browse/GEODE-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-8315: Fix Version/s: 1.13.0 1.12.1 > Upgrade Shiro to 1.5.3 > -- > > Key: GEODE-8315 > URL: https://issues.apache.org/jira/browse/GEODE-8315 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > our current Shiro version (1.5.2) is below the recommended version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8349) reinstate use of SSLSocket for cluster communication
[ https://issues.apache.org/jira/browse/GEODE-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce J Schuchardt reassigned GEODE-8349: - Assignee: Bruce J Schuchardt > reinstate use of SSLSocket for cluster communication > > > Key: GEODE-8349 > URL: https://issues.apache.org/jira/browse/GEODE-8349 > Project: Geode > Issue Type: Bug > Components: membership, messaging >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > > We've found problems with "new IO"'s SSLEngine with respect to support for > TLSV1. We've also seen anomalous performance using that secure > communications mechanism. The introduction of the use of the "new IO" > SSLEngine was originally to 1) reduce code complexity in the > org.apache.geode.internal.tcp package and 2) to set the stage for its use in > client/server communications so that selectors could be used in c/s > communications. > This ticket aims to reintroduce the use of SSLSocket in cluster > communications without restoring the old, poorly tested SSL code paths. The > new implementation should have as good or better performance than the > previous"old IO" implementation and the more recent "new IO" SSLEngine > implementation as well. This should be apparent in the CI benchmark jobs. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154866#comment-17154866 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException
[
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154864#comment-17154864
]
ASF subversion and git services commented on GEODE-7894:
Commit 43192d27213b458db38cdbf14f4cec7f484c717b in geode's branch
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43192d2 ]
GEODE-7894: Moving expiry tasks to AbstractRegion.
> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
> Labels: flakey
> Fix For: 1.13.0
>
>
> See:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest >
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT tid=215] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154870#comment-17154870 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154860#comment-17154860 ] ASF subversion and git services commented on GEODE-7983: Commit 32f59fc78357aa5fdd28358c716cc4d7e6f5f1b7 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=32f59fc ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154867#comment-17154867 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154862#comment-17154862 ] ASF subversion and git services commented on GEODE-7667: Commit 9bf176cc7822f7328fef80e9f0797293d6f4e98e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9bf176c ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154861#comment-17154861 ] ASF subversion and git services commented on GEODE-7676: Commit 75ae5912f83a9cd12516726532574d70b7774c45 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=75ae591 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154865#comment-17154865 ] ASF subversion and git services commented on GEODE-7667: Commit 2e8c7a8ccbb8c7d60c69e0a70b3ca9205a529eb8 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2e8c7a8 ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154868#comment-17154868 ] ASF subversion and git services commented on GEODE-7669: Commit b49e67cb9dee328221d7052d4b8c8f70c9210929 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b49e67c ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154854#comment-17154854 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154863#comment-17154863 ] ASF subversion and git services commented on GEODE-7676: Commit c78064a23c9897b39056a78ffdcec53bb5b80266 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c78064a ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154859#comment-17154859 ] ASF subversion and git services commented on GEODE-7912: Commit 2840a19ce2fc35796a3197f215bee7b62da36c2f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2840a19 ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154869#comment-17154869 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8266) StatForNotQueuedConflated not incremented in time
[
https://issues.apache.org/jira/browse/GEODE-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154876#comment-17154876
]
Jianxia Chen commented on GEODE-8266:
-
Also failed on JDK8:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK8/builds/331
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0215/test-results/test/1594319840/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0215/test-artifacts/1594319840/windows-unittestfiles-OpenJDK8-1.14.0-build.0215.tgz
> StatForNotQueuedConflated not incremented in time
> -
>
> Key: GEODE-8266
> URL: https://issues.apache.org/jira/browse/GEODE-8266
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Bill Burcham
>Priority: Major
>
> Failed here:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/259#A
> {code}
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest
> >
> whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented
> FAILED
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest.whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented(ParallelGatewaySenderQueueJUnitTest.java:146)
> {code}
> It appears we are waiting 100ms for the statistic to be incremented. Perhaps
> we need to wait longer. Or maybe there is product bug here?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8020) buffer corruption in SSL communications
[
https://issues.apache.org/jira/browse/GEODE-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruce J Schuchardt updated GEODE-8020:
--
Fix Version/s: 1.13.0
> buffer corruption in SSL communications
> ---
>
> Key: GEODE-8020
> URL: https://issues.apache.org/jira/browse/GEODE-8020
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Fix For: 1.13.0, 1.14.0
>
>
> update: May 8, 2020: the main problem described here seemed to only occur on
> JDK8 when TLSv1 is used. JDK11 with TLSv1 doesn't exhibit the problem. Nor is
> the problem apparent when TLSv1.2 is used on either JDK. This issue is marked
> resolved but the problem still occurs on JDK8 with TLSv1. Recommend customers
> use TLSv1.2 or later. Other buffering problems were found in this
> investigation and a PR was merged to address those.
> When running an application with SSL enabled I ran into a hang with a lost
> message. The sender had a 15 second ack-wait warning pointing to another
> server in the cluster. That server had this in its log file at the time the
> message would have been processed:
> {noformat}
> [info 2020/04/21 11:22:39.437 PDT rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003
> unshared ordered uid=354 dom #2 port=55262> tid=0xad] P2P message
> reader@2580db5f io exception for
> rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003@354(GEODE
> 1.10.0)
> javax.net.ssl.SSLException: bad record MAC
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:214)
> at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1728)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:986)
> at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:912)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:782)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:626)
> at
> org.apache.geode.internal.net.NioSslEngine.unwrap(NioSslEngine.java:275)
> at
> org.apache.geode.internal.tcp.Connection.processInputBuffer(Connection.java:2894)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1745)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1577)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: javax.crypto.BadPaddingException: bad record MAC
> at sun.security.ssl.InputRecord.decrypt(InputRecord.java:219)
> at
> sun.security.ssl.EngineInputRecord.decrypt(EngineInputRecord.java:177)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:979)
> ... 10 more
> {noformat}
> I bisected to see when this problem was introduced and found it was this
> commit:
> {noformat}
> commit 418d929e3e03185cd6330c828c9b9ed395a76d4b
> Author: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> Date: Fri Nov 1 20:28:57 2019 +0100
> GEODE-6661: Fixed use of Direct and Non-Direct buffers (#4267)
> - Fixed use of Direct and Non-Direct buffers
> {noformat}
> That commit modified the NioSSLEngine to use a "direct" byte buffer instead
> of a heap byte buffer. If I revert that one part of the PR the test works
> okay.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[ https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154767#comment-17154767 ] ASF subversion and git services commented on GEODE-7956: Commit fae1c94187d1b354c8705e8d4dc46842a12a9bcd in geode's branch refs/heads/develop from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fae1c94 ] GEODE-7956: Correct documentation of legal region names (format fix) (#5362) > Correct documentation of legal region names > --- > > Key: GEODE-7956 > URL: https://issues.apache.org/jira/browse/GEODE-7956 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Darrel Schneider >Assignee: Mario Kevo >Priority: Major > Fix For: 1.13.0, 1.14.0 > > > According to this: > https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html > region names can only contain alphanumeric, dash, and underscore. > But the product also supports a dot '.'. > See RegionNameValidation and RegionNameValidationTest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7956) Correct documentation of legal region names
[ https://issues.apache.org/jira/browse/GEODE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154766#comment-17154766 ] ASF GitHub Bot commented on GEODE-7956: --- davebarnes97 merged pull request #5362: URL: https://github.com/apache/geode/pull/5362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Correct documentation of legal region names > --- > > Key: GEODE-7956 > URL: https://issues.apache.org/jira/browse/GEODE-7956 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Darrel Schneider >Assignee: Mario Kevo >Priority: Major > Fix For: 1.13.0, 1.14.0 > > > According to this: > https://geode.apache.org/docs/guide/111/basic_config/data_regions/region_naming.html > region names can only contain alphanumeric, dash, and underscore. > But the product also supports a dot '.'. > See RegionNameValidation and RegionNameValidationTest -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8350) Offical Docker Image Needs ENTRYPOINT
Bill Burcham created GEODE-8350:
---
Summary: Offical Docker Image Needs ENTRYPOINT
Key: GEODE-8350
URL: https://issues.apache.org/jira/browse/GEODE-8350
Project: Geode
Issue Type: Bug
Reporter: Bill Burcham
The official docker image defines a {{CMD ["gfsh"]}} but no {{ENTRYPOINT}}. As
a result, it's easy to run {{gfsh}} interactively:
{noformat}
docker run -it apachegeode/geode
{noformat}
but to run a non-interactive {{gfsh}} command/script takes extra effort:
{noformat}
docker run --entrypoint gfsh apachegeode/geode -e version
{noformat}
When this story is complete, the official Docker image will define an
{{ENTRYPOINT ["gfsh"]}} that will allow execution of a non-interactive script
like:
{noformat}
docker run apachegeode/geode -e version
{noformat}
As before, it will be possible to enter an interactive {{gfsh}} session via:
{noformat}
docker run -it apachegeode/geode
{noformat}
Note, the Dockerfile probably won't need to define any {{CMD}} at all when this
story is complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154833#comment-17154833 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154829#comment-17154829 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154831#comment-17154831 ] ASF subversion and git services commented on GEODE-7669: Commit b49e67cb9dee328221d7052d4b8c8f70c9210929 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b49e67c ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException
[
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154827#comment-17154827
]
ASF subversion and git services commented on GEODE-7894:
Commit 43192d27213b458db38cdbf14f4cec7f484c717b in geode's branch
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43192d2 ]
GEODE-7894: Moving expiry tasks to AbstractRegion.
> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
> Labels: flakey
> Fix For: 1.13.0
>
>
> See:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest >
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT tid=215] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154826#comment-17154826 ] ASF subversion and git services commented on GEODE-7676: Commit c78064a23c9897b39056a78ffdcec53bb5b80266 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c78064a ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154818#comment-17154818 ] ASF subversion and git services commented on GEODE-7669: Commit b49e67cb9dee328221d7052d4b8c8f70c9210929 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b49e67c ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154809#comment-17154809 ] ASF subversion and git services commented on GEODE-7912: Commit 2840a19ce2fc35796a3197f215bee7b62da36c2f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2840a19 ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154817#comment-17154817 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154813#comment-17154813 ] ASF subversion and git services commented on GEODE-7676: Commit c78064a23c9897b39056a78ffdcec53bb5b80266 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c78064a ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154820#comment-17154820 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException
[
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154814#comment-17154814
]
ASF subversion and git services commented on GEODE-7894:
Commit 43192d27213b458db38cdbf14f4cec7f484c717b in geode's branch
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43192d2 ]
GEODE-7894: Moving expiry tasks to AbstractRegion.
> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
> Labels: flakey
> Fix For: 1.13.0
>
>
> See:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest >
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT tid=215] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154810#comment-17154810 ] ASF subversion and git services commented on GEODE-7983: Commit 32f59fc78357aa5fdd28358c716cc4d7e6f5f1b7 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=32f59fc ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154815#comment-17154815 ] ASF subversion and git services commented on GEODE-7667: Commit 2e8c7a8ccbb8c7d60c69e0a70b3ca9205a529eb8 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2e8c7a8 ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154812#comment-17154812 ] ASF subversion and git services commented on GEODE-7667: Commit 9bf176cc7822f7328fef80e9f0797293d6f4e98e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9bf176c ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154816#comment-17154816 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154811#comment-17154811 ] ASF subversion and git services commented on GEODE-7676: Commit 75ae5912f83a9cd12516726532574d70b7774c45 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=75ae591 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154819#comment-17154819 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154825#comment-17154825 ] ASF subversion and git services commented on GEODE-7667: Commit 9bf176cc7822f7328fef80e9f0797293d6f4e98e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9bf176c ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154828#comment-17154828 ] ASF subversion and git services commented on GEODE-7667: Commit 2e8c7a8ccbb8c7d60c69e0a70b3ca9205a529eb8 in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2e8c7a8 ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154832#comment-17154832 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154823#comment-17154823 ] ASF subversion and git services commented on GEODE-7983: Commit 32f59fc78357aa5fdd28358c716cc4d7e6f5f1b7 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=32f59fc ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154830#comment-17154830 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154824#comment-17154824 ] ASF subversion and git services commented on GEODE-7676: Commit 75ae5912f83a9cd12516726532574d70b7774c45 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=75ae591 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154822#comment-17154822 ] ASF subversion and git services commented on GEODE-7912: Commit 2840a19ce2fc35796a3197f215bee7b62da36c2f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2840a19 ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8020) buffer corruption in SSL communications
[
https://issues.apache.org/jira/browse/GEODE-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154753#comment-17154753
]
ASF subversion and git services commented on GEODE-8020:
Commit 120f94a3ee1b7934673978ae9c82f1d3e30cb9c8 in geode's branch
refs/heads/support/1.13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=120f94a ]
GEODE-8020: buffer management problems (#5048)
* GEODE-8020: buffer management problems
This fixes some buffer handling in MsgStreamerList and alters
MstStreamer to avoid creating MsgStreamerList and VersionedMsgStreamers
during normal, non-upgrade, operations.
It also changes NioSslEngine to use synchronization in more places,
notably the close() method, which was possibly allowing multiple threads to
change the state of the engine.
* revert unnecessary change to ClusterCommunicationsDUnitTest
* fixing another null version check
* renamed new BufferPool property
* restore logging of ssl exceptions
(cherry picked from commit 7375c591f25bbba413237aed1f56f8a9f70075df)
> buffer corruption in SSL communications
> ---
>
> Key: GEODE-8020
> URL: https://issues.apache.org/jira/browse/GEODE-8020
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Fix For: 1.14.0
>
>
> update: May 8, 2020: the main problem described here seemed to only occur on
> JDK8 when TLSv1 is used. JDK11 with TLSv1 doesn't exhibit the problem. Nor is
> the problem apparent when TLSv1.2 is used on either JDK. This issue is marked
> resolved but the problem still occurs on JDK8 with TLSv1. Recommend customers
> use TLSv1.2 or later. Other buffering problems were found in this
> investigation and a PR was merged to address those.
> When running an application with SSL enabled I ran into a hang with a lost
> message. The sender had a 15 second ack-wait warning pointing to another
> server in the cluster. That server had this in its log file at the time the
> message would have been processed:
> {noformat}
> [info 2020/04/21 11:22:39.437 PDT rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003
> unshared ordered uid=354 dom #2 port=55262> tid=0xad] P2P message
> reader@2580db5f io exception for
> rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003@354(GEODE
> 1.10.0)
> javax.net.ssl.SSLException: bad record MAC
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:214)
> at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1728)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:986)
> at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:912)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:782)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:626)
> at
> org.apache.geode.internal.net.NioSslEngine.unwrap(NioSslEngine.java:275)
> at
> org.apache.geode.internal.tcp.Connection.processInputBuffer(Connection.java:2894)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1745)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1577)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: javax.crypto.BadPaddingException: bad record MAC
> at sun.security.ssl.InputRecord.decrypt(InputRecord.java:219)
> at
> sun.security.ssl.EngineInputRecord.decrypt(EngineInputRecord.java:177)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:979)
> ... 10 more
> {noformat}
> I bisected to see when this problem was introduced and found it was this
> commit:
> {noformat}
> commit 418d929e3e03185cd6330c828c9b9ed395a76d4b
> Author: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> Date: Fri Nov 1 20:28:57 2019 +0100
> GEODE-6661: Fixed use of Direct and Non-Direct buffers (#4267)
> - Fixed use of Direct and Non-Direct buffers
> {noformat}
> That commit modified the NioSSLEngine to use a "direct" byte buffer instead
> of a heap byte buffer. If I revert that one part of the PR the test works
> okay.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8020) buffer corruption in SSL communications
[
https://issues.apache.org/jira/browse/GEODE-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154754#comment-17154754
]
ASF subversion and git services commented on GEODE-8020:
Commit 120f94a3ee1b7934673978ae9c82f1d3e30cb9c8 in geode's branch
refs/heads/support/1.13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=120f94a ]
GEODE-8020: buffer management problems (#5048)
* GEODE-8020: buffer management problems
This fixes some buffer handling in MsgStreamerList and alters
MstStreamer to avoid creating MsgStreamerList and VersionedMsgStreamers
during normal, non-upgrade, operations.
It also changes NioSslEngine to use synchronization in more places,
notably the close() method, which was possibly allowing multiple threads to
change the state of the engine.
* revert unnecessary change to ClusterCommunicationsDUnitTest
* fixing another null version check
* renamed new BufferPool property
* restore logging of ssl exceptions
(cherry picked from commit 7375c591f25bbba413237aed1f56f8a9f70075df)
> buffer corruption in SSL communications
> ---
>
> Key: GEODE-8020
> URL: https://issues.apache.org/jira/browse/GEODE-8020
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Fix For: 1.14.0
>
>
> update: May 8, 2020: the main problem described here seemed to only occur on
> JDK8 when TLSv1 is used. JDK11 with TLSv1 doesn't exhibit the problem. Nor is
> the problem apparent when TLSv1.2 is used on either JDK. This issue is marked
> resolved but the problem still occurs on JDK8 with TLSv1. Recommend customers
> use TLSv1.2 or later. Other buffering problems were found in this
> investigation and a PR was merged to address those.
> When running an application with SSL enabled I ran into a hang with a lost
> message. The sender had a 15 second ack-wait warning pointing to another
> server in the cluster. That server had this in its log file at the time the
> message would have been processed:
> {noformat}
> [info 2020/04/21 11:22:39.437 PDT rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003
> unshared ordered uid=354 dom #2 port=55262> tid=0xad] P2P message
> reader@2580db5f io exception for
> rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003@354(GEODE
> 1.10.0)
> javax.net.ssl.SSLException: bad record MAC
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:214)
> at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1728)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:986)
> at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:912)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:782)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:626)
> at
> org.apache.geode.internal.net.NioSslEngine.unwrap(NioSslEngine.java:275)
> at
> org.apache.geode.internal.tcp.Connection.processInputBuffer(Connection.java:2894)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1745)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1577)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: javax.crypto.BadPaddingException: bad record MAC
> at sun.security.ssl.InputRecord.decrypt(InputRecord.java:219)
> at
> sun.security.ssl.EngineInputRecord.decrypt(EngineInputRecord.java:177)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:979)
> ... 10 more
> {noformat}
> I bisected to see when this problem was introduced and found it was this
> commit:
> {noformat}
> commit 418d929e3e03185cd6330c828c9b9ed395a76d4b
> Author: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> Date: Fri Nov 1 20:28:57 2019 +0100
> GEODE-6661: Fixed use of Direct and Non-Direct buffers (#4267)
> - Fixed use of Direct and Non-Direct buffers
> {noformat}
> That commit modified the NioSSLEngine to use a "direct" byte buffer instead
> of a heap byte buffer. If I revert that one part of the PR the test works
> okay.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8259) when client singlehop getAll encountered SerializationException, it should retry
[ https://issues.apache.org/jira/browse/GEODE-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-8259: Fix Version/s: 1.13.0 1.12.1 > when client singlehop getAll encountered SerializationException, it should > retry > > > Key: GEODE-8259 > URL: https://issues.apache.org/jira/browse/GEODE-8259 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Fix For: 1.12.1, 1.13.0, 1.14.0 > > > In GEOEDE-7090, DSFIDSerializerImpl.invokeFromData() will catch > RunTimeException and throw. But convert Exception to be IOException. The idea > is to avoid using SerializationException which is in another package. > However, if my fromData() failed with IndexOutOfBoundary exception (which is > an RTE), it will be thrown directly instead of treating it in > handleException(), thus my serialization exception will never get handled. > The fix is to merge the catch RunTimeException into catch Exception. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8346) NonTXEntry.getValue() may throw EntryDestroyedException during CQ execution
[
https://issues.apache.org/jira/browse/GEODE-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154905#comment-17154905
]
ASF subversion and git services commented on GEODE-8346:
Commit 62ee81fa428a80470083d1a304d7704b15658d2c in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=62ee81f ]
GEODE-8346: Add try/catch around Entry.getValue in CompiledComparison (#5359)
Authored-by: Donal Evans
> NonTXEntry.getValue() may throw EntryDestroyedException during CQ execution
> ---
>
> Key: GEODE-8346
> URL: https://issues.apache.org/jira/browse/GEODE-8346
> Project: Geode
> Issue Type: Bug
> Components: cq
>Affects Versions: 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>
> If a region entry is destroyed at the same time that a CQ is executed, there
> exists a race condition where a non-destroyed {{NonTXEntry}} is retrieved
> during iteration of results in {{CompiledSelect.doNestedIterations()}} but is
> marked as destroyed/removed before {{NonTXEntry.getValue()}} is called in
> {{CompiledComparison.evaluate()}}, which results in an
> {{EntryDestroyedException}} being thrown.
> {noformat}
> org.apache.geode.cache.query.CqException: Failed to execute the CQ. CqName:
> testCQ, Query String is: SELECT * FROM /testRegion entry WHERE entry = NULL,
> Error from last server: remote server on
> 10.212.3.32(84004:loner):49205:d737a530: While performing a remote
> createCQfetchInitialResult
> at
> org.apache.geode.cache.query.cq.internal.ClientCQImpl.executeCqOnRedundantsAndPrimary(ClientCQImpl.java:435)
> at
> org.apache.geode.cache.query.cq.internal.ClientCQImpl.executeWithInitialResults(ClientCQImpl.java:303)
> at
> org.apache.geode.cache.query.cq.DonalCQTest.lambda$test$bb17a952$2(DonalCQTest.java:84)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.geode.test.dunit.internal.MethodInvoker.executeObject(MethodInvoker.java:123)
> at
> org.apache.geode.test.dunit.internal.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:573)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:834)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:688)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:687)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.geode.cache.client.ServerOperationException: remote
> server on 10.212.3.32(84004:loner):49205:d737a530: While performing a remote
> createCQfetchInitialResult
> at
> org.apache.geode.cache.client.internal.AbstractOp.processChunkedResponse(AbstractOp.java:340)
> at
> org.apache.geode.cache.client.internal.QueryOp$QueryOpImpl.processResponse(QueryOp.java:168)
> at
> org.apache.geode.cache.client.internal.AbstractOp.processResponse(AbstractOp.java:222)
> at
> org.apache.geode.cache.client.internal.AbstractOp.attemptReadResponse(AbstractOp.java:195)
> at
> org.apache.geode.cache.client.internal.AbstractOp.attempt(AbstractOp.java:382)
> at
> org.apache.geode.cache.client.internal.ConnectionImpl.execute(ConnectionImpl.java:283)
> at
> org.apache.geode.cache.client.internal.QueueConnectionImpl.execute(QueueConnectionImpl.java:191)
> at
>
[jira] [Commented] (GEODE-8346) NonTXEntry.getValue() may throw EntryDestroyedException during CQ execution
[
https://issues.apache.org/jira/browse/GEODE-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154903#comment-17154903
]
ASF GitHub Bot commented on GEODE-8346:
---
DonalEvans merged pull request #5359:
URL: https://github.com/apache/geode/pull/5359
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NonTXEntry.getValue() may throw EntryDestroyedException during CQ execution
> ---
>
> Key: GEODE-8346
> URL: https://issues.apache.org/jira/browse/GEODE-8346
> Project: Geode
> Issue Type: Bug
> Components: cq
>Affects Versions: 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
>
> If a region entry is destroyed at the same time that a CQ is executed, there
> exists a race condition where a non-destroyed {{NonTXEntry}} is retrieved
> during iteration of results in {{CompiledSelect.doNestedIterations()}} but is
> marked as destroyed/removed before {{NonTXEntry.getValue()}} is called in
> {{CompiledComparison.evaluate()}}, which results in an
> {{EntryDestroyedException}} being thrown.
> {noformat}
> org.apache.geode.cache.query.CqException: Failed to execute the CQ. CqName:
> testCQ, Query String is: SELECT * FROM /testRegion entry WHERE entry = NULL,
> Error from last server: remote server on
> 10.212.3.32(84004:loner):49205:d737a530: While performing a remote
> createCQfetchInitialResult
> at
> org.apache.geode.cache.query.cq.internal.ClientCQImpl.executeCqOnRedundantsAndPrimary(ClientCQImpl.java:435)
> at
> org.apache.geode.cache.query.cq.internal.ClientCQImpl.executeWithInitialResults(ClientCQImpl.java:303)
> at
> org.apache.geode.cache.query.cq.DonalCQTest.lambda$test$bb17a952$2(DonalCQTest.java:84)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.geode.test.dunit.internal.MethodInvoker.executeObject(MethodInvoker.java:123)
> at
> org.apache.geode.test.dunit.internal.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:78)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:573)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:834)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:688)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:687)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.geode.cache.client.ServerOperationException: remote
> server on 10.212.3.32(84004:loner):49205:d737a530: While performing a remote
> createCQfetchInitialResult
> at
> org.apache.geode.cache.client.internal.AbstractOp.processChunkedResponse(AbstractOp.java:340)
> at
> org.apache.geode.cache.client.internal.QueryOp$QueryOpImpl.processResponse(QueryOp.java:168)
> at
> org.apache.geode.cache.client.internal.AbstractOp.processResponse(AbstractOp.java:222)
> at
> org.apache.geode.cache.client.internal.AbstractOp.attemptReadResponse(AbstractOp.java:195)
> at
> org.apache.geode.cache.client.internal.AbstractOp.attempt(AbstractOp.java:382)
> at
> org.apache.geode.cache.client.internal.ConnectionImpl.execute(ConnectionImpl.java:283)
> at
>
[jira] [Created] (GEODE-8351) DUnit tests for Delta Propagation
Sarah Abbey created GEODE-8351: -- Summary: DUnit tests for Delta Propagation Key: GEODE-8351 URL: https://issues.apache.org/jira/browse/GEODE-8351 Project: Geode Issue Type: Test Components: redis, tests Reporter: Sarah Abbey Need to confirm that when deltas are propagated, the data is correctly stored on the secondary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8347) use benchmarks branch corresponding to geode branch
[ https://issues.apache.org/jira/browse/GEODE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154958#comment-17154958 ] ASF GitHub Bot commented on GEODE-8347: --- onichols-pivotal merged pull request #5361: URL: https://github.com/apache/geode/pull/5361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > use benchmarks branch corresponding to geode branch > --- > > Key: GEODE-8347 > URL: https://issues.apache.org/jira/browse/GEODE-8347 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > Geode 1.12 release included geode-benchmarks from support/1.12, but the > pipeline definition is still using benchmarks from develop, as is 1.13. Fix > to use matching branch names between geode and geode-examples. Also need to > rebalance max_in_flight based on how long each benchmark job takes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8347) use benchmarks branch corresponding to geode branch
[ https://issues.apache.org/jira/browse/GEODE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154959#comment-17154959 ] ASF subversion and git services commented on GEODE-8347: Commit daa70d729b98f8edc3791a0dfccbf102ab94dd94 in geode's branch refs/heads/develop from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=daa70d7 ] GEODE-8347: use same benchmarks branch as geode branch, since that's the way we release (#5361) also balance max_in_flight according to how long each job takes > use benchmarks branch corresponding to geode branch > --- > > Key: GEODE-8347 > URL: https://issues.apache.org/jira/browse/GEODE-8347 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > Geode 1.12 release included geode-benchmarks from support/1.12, but the > pipeline definition is still using benchmarks from develop, as is 1.13. Fix > to use matching branch names between geode and geode-examples. Also need to > rebalance max_in_flight based on how long each benchmark job takes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8347) use benchmarks branch corresponding to geode branch
[ https://issues.apache.org/jira/browse/GEODE-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols resolved GEODE-8347. - Fix Version/s: 1.14.0 Resolution: Fixed > use benchmarks branch corresponding to geode branch > --- > > Key: GEODE-8347 > URL: https://issues.apache.org/jira/browse/GEODE-8347 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Fix For: 1.14.0 > > > Geode 1.12 release included geode-benchmarks from support/1.12, but the > pipeline definition is still using benchmarks from develop, as is 1.13. Fix > to use matching branch names between geode and geode-examples. Also need to > rebalance max_in_flight based on how long each benchmark job takes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8200) Rebalance operations stuck in "IN_PROGRESS" state forever
[
https://issues.apache.org/jira/browse/GEODE-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154964#comment-17154964
]
ASF GitHub Bot commented on GEODE-8200:
---
jchen21 commented on a change in pull request #5350:
URL: https://github.com/apache/geode/pull/5350#discussion_r452488277
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/operation/OperationState.java
##
@@ -28,12 +28,25 @@
*/
public class OperationState, V extends
OperationResult>
implements Identifiable {
+ private static final long serialVersionUID = 8212319653561969588L;
private final String opId;
private final A operation;
private final Date operationStart;
private Date operationEnd;
private V result;
private Throwable throwable;
+ private String locator;
+
+ public String getLocator() {
+return this.locator;
+ }
+
+ public void setLocator(
+ String locator) {
+synchronized (this) {
Review comment:
This is for consistency. `setOperationEnd()` does the same.
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/operation/OperationStateStore.java
##
@@ -53,6 +53,8 @@
*/
void recordEnd(String opId, V result, Throwable
exception);
+ void recordLocator(String opId, String locator);
Review comment:
Good point.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rebalance operations stuck in "IN_PROGRESS" state forever
> -
>
> Key: GEODE-8200
> URL: https://issues.apache.org/jira/browse/GEODE-8200
> Project: Geode
> Issue Type: Bug
> Components: management
>Reporter: Aaron Lindsey
>Assignee: Jianxia Chen
>Priority: Major
> Labels: GeodeOperationAPI
> Attachments: GEODE-8200-exportedLogs.zip
>
>
> We use the management REST API to call rebalance immediately before stopping
> a server to limit the possibility of data loss. In a cluster with 3 locators,
> 3 servers, and no regions, we noticed that sometimes the rebalance operation
> never ends if one of the locators is restarting concurrently with the
> rebalance operation.
> More specifically, the scenario where we see this issue crop up is during an
> automated "rolling restart" operation in a Kubernetes environment which
> proceeds as follows:
> * At most one locator and one server are restarting at any point in time
> * Each locator/server waits until the previous locator/server is fully online
> before restarting
> * Immediately before stopping a server, a rebalance operation is performed
> and the server is not stopped until the rebalance operation is completed
> The impact of this issue is that the "rolling restart" operation will never
> complete, because it cannot proceed with stopping a server until the
> rebalance operation is completed. A human is then required to intervene and
> manually trigger a rebalance and stop the server. This type of "rolling
> restart" operation is triggered fairly often in Kubernetes — any time part of
> the configuration of the locators or servers changes.
> The following JSON is a sample response from the management REST API that
> shows the rebalance operation stuck in "IN_PROGRESS".
> {code}
> {
> "statusCode": "IN_PROGRESS",
> "links": {
> "self":
> "http://geodecluster-sample-locator.default/management/v1/operations/rebalances/a47f23c8-02b3-443c-a367-636fd6921ea7;,
> "list":
> "http://geodecluster-sample-locator.default/management/v1/operations/rebalances;
> },
> "operationStart": "2020-05-27T22:38:30.619Z",
> "operationId": "a47f23c8-02b3-443c-a367-636fd6921ea7",
> "operation": {
> "simulate": false
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8351) DUnit tests for Delta Propagation
[
https://issues.apache.org/jira/browse/GEODE-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154965#comment-17154965
]
ASF GitHub Bot commented on GEODE-8351:
---
dschneider-pivotal commented on a change in pull request #5364:
URL: https://github.com/apache/geode/pull/5364#discussion_r452519968
##
File path:
geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/DeltaDUnitTest.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.data;
+
+import static
org.apache.geode.distributed.ConfigurationProperties.MAX_WAIT_TIME_RECONNECT;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import java.util.Set;
+
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import redis.clients.jedis.Jedis;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.partition.PartitionRegionHelper;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.test.awaitility.GeodeAwaitility;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.dunit.rules.RedisClusterStartupRule;
+
+public class DeltaDUnitTest {
+
+ @ClassRule
+ public static RedisClusterStartupRule clusterStartUp = new
RedisClusterStartupRule(4);
+
+ private static final String LOCAL_HOST = "127.0.0.1";
+ private static final int SET_SIZE = 10;
+ private static final int JEDIS_TIMEOUT =
+ Math.toIntExact(GeodeAwaitility.getTimeout().toMillis());
+ private static Jedis jedis1;
+ private static Jedis jedis2;
+
+ private static Properties locatorProperties;
+
+ private static MemberVM locator;
+ private static MemberVM server1;
+ private static MemberVM server2;
+
+ private static int redisServerPort1;
+ private static int redisServerPort2;
+
+ @BeforeClass
+ public static void classSetup() {
+locatorProperties = new Properties();
+locatorProperties.setProperty(MAX_WAIT_TIME_RECONNECT, "15000");
+
+locator = clusterStartUp.startLocatorVM(0, locatorProperties);
+server1 = clusterStartUp.startRedisVM(1, locator.getPort());
+server2 = clusterStartUp.startRedisVM(2, locator.getPort());
+
+redisServerPort1 = clusterStartUp.getRedisPort(1);
+redisServerPort2 = clusterStartUp.getRedisPort(2);
+
+jedis1 = new Jedis(LOCAL_HOST, redisServerPort1, JEDIS_TIMEOUT);
+jedis2 = new Jedis(LOCAL_HOST, redisServerPort2, JEDIS_TIMEOUT);
+ }
+
+ @Before
+ public void testSetup() {
+jedis1.flushAll();
+ }
+
+ @AfterClass
+ public static void tearDown() {
+jedis1.disconnect();
+jedis2.disconnect();
+
+server1.stop();
+server2.stop();
+ }
+
+ @Test
+ public void shouldCorrectlyPropagateDeltaToSecondaryServer_whenAppending() {
+String key = "key";
+String baseValue = "value-";
+jedis1.set(key, baseValue);
+for (int i = 0; i < SET_SIZE; i++) {
+ jedis1.set(key, String.valueOf(i));
Review comment:
I think you want this to be "append" instead of "set".
##
File path:
geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/DeltaDUnitTest.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ *
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154925#comment-17154925 ] ASF subversion and git services commented on GEODE-7983: Commit 32f59fc78357aa5fdd28358c716cc4d7e6f5f1b7 in geode's branch refs/heads/feature/GEODE-8334 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=32f59fc ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154927#comment-17154927 ] ASF subversion and git services commented on GEODE-7667: Commit 9bf176cc7822f7328fef80e9f0797293d6f4e98e in geode's branch refs/heads/feature/GEODE-8334 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9bf176c ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154926#comment-17154926 ] ASF subversion and git services commented on GEODE-7676: Commit 75ae5912f83a9cd12516726532574d70b7774c45 in geode's branch refs/heads/feature/GEODE-8334 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=75ae591 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154934#comment-17154934 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-8334 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException
[
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154929#comment-17154929
]
ASF subversion and git services commented on GEODE-7894:
Commit 43192d27213b458db38cdbf14f4cec7f484c717b in geode's branch
refs/heads/feature/GEODE-8334 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=43192d2 ]
GEODE-7894: Moving expiry tasks to AbstractRegion.
> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
> Labels: flakey
> Fix For: 1.13.0
>
>
> See:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest >
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT tid=215] Uncaught
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException:
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
> at
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
> at
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154933#comment-17154933 ] ASF subversion and git services commented on GEODE-7669: Commit b49e67cb9dee328221d7052d4b8c8f70c9210929 in geode's branch refs/heads/feature/GEODE-8334 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b49e67c ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154930#comment-17154930 ] ASF subversion and git services commented on GEODE-7667: Commit 2e8c7a8ccbb8c7d60c69e0a70b3ca9205a529eb8 in geode's branch refs/heads/feature/GEODE-8334 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2e8c7a8 ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154932#comment-17154932 ] ASF subversion and git services commented on GEODE-7678: Commit 8eeaac4b53a4a4dd3e91722855de6bcc6da04883 in geode's branch refs/heads/feature/GEODE-8334 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeaac4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154935#comment-17154935 ] ASF subversion and git services commented on GEODE-8173: Commit af4b35ae46fc63b178eb41f908c5f678d75068fa in geode's branch refs/heads/feature/GEODE-8334 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=af4b35a ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7665) Ability to clear a Partitioned Region
[ https://issues.apache.org/jira/browse/GEODE-7665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154936#comment-17154936 ] ASF subversion and git services commented on GEODE-7665: Commit a6a62c6840b4916611ed850f1dd17b9ed7a3b709 in geode's branch refs/heads/feature/GEODE-8334 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a6a62c6 ] Merge branch 'feature/GEODE-7665' into feature/GEODE-8334 > Ability to clear a Partitioned Region > - > > Key: GEODE-7665 > URL: https://issues.apache.org/jira/browse/GEODE-7665 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > > With the successful voting of the RFC for implementing clear operation on > Partitioned Region > [[https://cwiki.apache.org/confluence/display/GEODE/Support+for+clear+operation+on+partitioned+region]] > we are starting the code implementation. > > Details of the implementation and design are maintained in the RFC document > mentioned above. This ticket will act as a parent Jira under which all the > subsequent sub-JIRAs will be created. This ticket will be closed once all the > sub jiras are implemented. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154937#comment-17154937 ] ASF subversion and git services commented on GEODE-8334: Commit a6a62c6840b4916611ed850f1dd17b9ed7a3b709 in geode's branch refs/heads/feature/GEODE-8334 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a6a62c6 ] Merge branch 'feature/GEODE-7665' into feature/GEODE-8334 > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154928#comment-17154928 ] ASF subversion and git services commented on GEODE-7676: Commit c78064a23c9897b39056a78ffdcec53bb5b80266 in geode's branch refs/heads/feature/GEODE-8334 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c78064a ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154972#comment-17154972 ] ASF subversion and git services commented on GEODE-8334: Commit 43cb2781e34b0b24f2628236256e13027f4b4e50 in geode's branch refs/heads/feature/GEODE-8334 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=43cb278 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock Co-authored-by: Xiaojian Zhou Co-authored-by: Anil > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8200) Rebalance operations stuck in "IN_PROGRESS" state forever
[
https://issues.apache.org/jira/browse/GEODE-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154981#comment-17154981
]
ASF GitHub Bot commented on GEODE-8200:
---
jchen21 commented on a change in pull request #5350:
URL: https://github.com/apache/geode/pull/5350#discussion_r452537292
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/operation/OperationState.java
##
@@ -28,12 +28,25 @@
*/
public class OperationState, V extends
OperationResult>
implements Identifiable {
+ private static final long serialVersionUID = 8212319653561969588L;
private final String opId;
private final A operation;
private final Date operationStart;
private Date operationEnd;
private V result;
private Throwable throwable;
+ private String locator;
Review comment:
Do you mean `InternalDistributedMember` when you talk about
`DistributedID`? I was using the `InternalDistributedMember` as the type for
`locator` field. But it is a large object with many fields. We only need to
identify the locator, so a String type of a member's ID should be good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rebalance operations stuck in "IN_PROGRESS" state forever
> -
>
> Key: GEODE-8200
> URL: https://issues.apache.org/jira/browse/GEODE-8200
> Project: Geode
> Issue Type: Bug
> Components: management
>Reporter: Aaron Lindsey
>Assignee: Jianxia Chen
>Priority: Major
> Labels: GeodeOperationAPI
> Attachments: GEODE-8200-exportedLogs.zip
>
>
> We use the management REST API to call rebalance immediately before stopping
> a server to limit the possibility of data loss. In a cluster with 3 locators,
> 3 servers, and no regions, we noticed that sometimes the rebalance operation
> never ends if one of the locators is restarting concurrently with the
> rebalance operation.
> More specifically, the scenario where we see this issue crop up is during an
> automated "rolling restart" operation in a Kubernetes environment which
> proceeds as follows:
> * At most one locator and one server are restarting at any point in time
> * Each locator/server waits until the previous locator/server is fully online
> before restarting
> * Immediately before stopping a server, a rebalance operation is performed
> and the server is not stopped until the rebalance operation is completed
> The impact of this issue is that the "rolling restart" operation will never
> complete, because it cannot proceed with stopping a server until the
> rebalance operation is completed. A human is then required to intervene and
> manually trigger a rebalance and stop the server. This type of "rolling
> restart" operation is triggered fairly often in Kubernetes — any time part of
> the configuration of the locators or servers changes.
> The following JSON is a sample response from the management REST API that
> shows the rebalance operation stuck in "IN_PROGRESS".
> {code}
> {
> "statusCode": "IN_PROGRESS",
> "links": {
> "self":
> "http://geodecluster-sample-locator.default/management/v1/operations/rebalances/a47f23c8-02b3-443c-a367-636fd6921ea7;,
> "list":
> "http://geodecluster-sample-locator.default/management/v1/operations/rebalances;
> },
> "operationStart": "2020-05-27T22:38:30.619Z",
> "operationId": "a47f23c8-02b3-443c-a367-636fd6921ea7",
> "operation": {
> "simulate": false
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
