[jira] [Updated] (GEODE-880) Remove unused classes
[ https://issues.apache.org/jira/browse/GEODE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-880: Description: We would typically only keep unused classes if they were part of the user API in a previous release. If an unused class is not required for backwards compatibility then it should be deleted. This jira ticket lists unused classes that should be removed. If you delete any of these classes, please add an appropriate comment and then remove the class name from the ticket description. * geode-core/src/test/java/com/gemstone/gemfire/internal/JavaExec.java * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java was: We would typically only keep unused classes if they were part of the user API in a previous release. If an unused class is not required for backwards compatibility then it should be deleted. This jira ticket lists unused classes that should be removed. If you delete any of these classes, please add an appropriate comment and then remove the class name from the ticket description. * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java > Remove unused classes > - > > Key: GEODE-880 > URL: https://issues.apache.org/jira/browse/GEODE-880 > Project: Geode > Issue Type: Wish > Components: general >Reporter: Kirk Lund > > We would typically only keep unused classes if they were part of the user API > in a previous release. > If an unused class is not required for backwards compatibility then it should > be deleted. This jira ticket lists unused classes that should be removed. If > you delete any of these classes, please add an appropriate comment and then > remove the class name from the ticket description. > * geode-core/src/test/java/com/gemstone/gemfire/internal/JavaExec.java > * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-880) Remove unused classes
[ https://issues.apache.org/jira/browse/GEODE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408626#comment-15408626 ] Kirk Lund commented on GEODE-880: - These are now either removed or in use: * gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/RedisCommandParserException.java * gemfire-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImpl.java * gemfire-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImplWithValue.java > Remove unused classes > - > > Key: GEODE-880 > URL: https://issues.apache.org/jira/browse/GEODE-880 > Project: Geode > Issue Type: Wish > Components: general >Reporter: Kirk Lund > > We would typically only keep unused classes if they were part of the user API > in a previous release. > If an unused class is not required for backwards compatibility then it should > be deleted. This jira ticket lists unused classes that should be removed. If > you delete any of these classes, please add an appropriate comment and then > remove the class name from the ticket description. > * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (GEODE-880) Remove unused classes
[ https://issues.apache.org/jira/browse/GEODE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-880: Description: We would typically only keep unused classes if they were part of the user API in a previous release. If an unused class is not required for backwards compatibility then it should be deleted. This jira ticket lists unused classes that should be removed. If you delete any of these classes, please add an appropriate comment and then remove the class name from the ticket description. * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java was: We would typically only keep unused classes if they were part of the user API in a previous release. If an unused class is not required for backwards compatibility then it should be deleted. This jira ticket lists unused classes that should be removed. If you delete any of these classes, please add an appropriate comment and then remove the class name from the ticket description. * gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/RedisCommandParserException.java * gemfire-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImpl.java * gemfire-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImplWithValue.java > Remove unused classes > - > > Key: GEODE-880 > URL: https://issues.apache.org/jira/browse/GEODE-880 > Project: Geode > Issue Type: Wish > Components: general >Reporter: Kirk Lund > > We would typically only keep unused classes if they were part of the user API > in a previous release. > If an unused class is not required for backwards compatibility then it should > be deleted. This jira ticket lists unused classes that should be removed. If > you delete any of these classes, please add an appropriate comment and then > remove the class name from the ticket description. > * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-1730) Cleanup SmHelper, SharedLibrary, PureJavaMode classes
Kirk Lund created GEODE-1730: Summary: Cleanup SmHelper, SharedLibrary, PureJavaMode classes Key: GEODE-1730 URL: https://issues.apache.org/jira/browse/GEODE-1730 Project: Geode Issue Type: Improvement Components: general Reporter: Kirk Lund These classes are for the GemFire native code which is not in Geode. There are a couple of methods still used on these classes such as is64bit() which could be moved to another class such as SystemUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (GEODE-1730) Cleanup SmHelper, SharedLibrary, PureJavaMode classes
[ https://issues.apache.org/jira/browse/GEODE-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-1730: Assignee: Kirk Lund > Cleanup SmHelper, SharedLibrary, PureJavaMode classes > - > > Key: GEODE-1730 > URL: https://issues.apache.org/jira/browse/GEODE-1730 > Project: Geode > Issue Type: Improvement > Components: general >Reporter: Kirk Lund >Assignee: Kirk Lund > > These classes are for the GemFire native code which is not in Geode. There > are a couple of methods still used on these classes such as is64bit() which > could be moved to another class such as SystemUtils. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1648) Provide ability to disable security for some components
[
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408492#comment-15408492
]
ASF GitHub Bot commented on GEODE-1648:
---
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/224
1) we need to fix the javadocs for security-enabled-components on
DistributedSystem class
2) move SecurableComponent enum into internal.security pkg
3) consider collapsing SecurableComponents interface into
SecurableComponent enum (we don't really need both
> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
> Issue Type: Sub-task
> Components: security
>Reporter: Swapnil Bawaskar
>Assignee: Grace Meilen
>
> When the new {{SecurityManager}} interface is used, it will enable
> authentication and authorization for client-server, jmx, peer-to-peer and
> WAN. Not all users will want authentication and authorization for all these
> components as explained in this comment:
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (GEODE-1729) Removing redundant import of org.junit.experimental.categories.Category
nabarun created GEODE-1729: -- Summary: Removing redundant import of org.junit.experimental.categories.Category Key: GEODE-1729 URL: https://issues.apache.org/jira/browse/GEODE-1729 Project: Geode Issue Type: Bug Components: build Reporter: nabarun While updating from JUnit 3 to Junit 4 redundant org.junit.experimental.categories.Category import statements were inserted. These need to be removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (GEODE-1729) Removing redundant import of org.junit.experimental.categories.Category
[ https://issues.apache.org/jira/browse/GEODE-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun reassigned GEODE-1729: -- Assignee: nabarun > Removing redundant import of org.junit.experimental.categories.Category > --- > > Key: GEODE-1729 > URL: https://issues.apache.org/jira/browse/GEODE-1729 > Project: Geode > Issue Type: Bug > Components: build >Reporter: nabarun >Assignee: nabarun > > While updating from JUnit 3 to Junit 4 redundant > org.junit.experimental.categories.Category import statements were inserted. > These need to be removed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1727) NPE in JGroups during shutdown
[
https://issues.apache.org/jira/browse/GEODE-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408193#comment-15408193
]
ASF subversion and git services commented on GEODE-1727:
Commit c7a0a458fd9593f4158a1e64a181034b0cb4da8e in incubator-geode's branch
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c7a0a45 ]
GEODE-1727 NPE in JGroups during shutdown
Moved the shutdown of the JGroups timer to before super.stop() so that
timer tasks won't fire after the bundler variable has been nulled out.
> NPE in JGroups during shutdown
> --
>
> Key: GEODE-1727
> URL: https://issues.apache.org/jira/browse/GEODE-1727
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Bruce Schuchardt
>
> A test failed with a suspect string during shutdown.
> {noformat}
> [error 2016/07/28 06:52:39.126 UTC locatorgemfire_3_2_client-06_5333 UDP Timer-2,client-06-34033> tid=0x27] Exception caught while sending message
> java.lang.NullPointerException
> at org.jgroups.protocols.TP.send(TP.java:1861)
> at
> com.gemstone.gemfire.distributed.internal.membership.gms.messenger.Transport._send(Transport.java:54)
> at org.jgroups.protocols.TP.down(TP.java:1474)
> at org.jgroups.stack.Protocol.down(Protocol.java:439)
> at
> com.gemstone.gemfire.distributed.internal.membership.gms.messenger.StatRecorder.down(StatRecorder.java:90)
> at org.jgroups.protocols.UNICAST3.sendAck(UNICAST3.java:1126)
> at org.jgroups.protocols.UNICAST3.triggerXmit(UNICAST3.java:1521)
> at
> org.jgroups.protocols.UNICAST3$RetransmitTask.run(UNICAST3.java:1502)
> at org.jgroups.util.TimeScheduler3$Task.run(TimeScheduler3.java:291)
> at
> org.jgroups.util.TimeScheduler3$RecurringTask.run(TimeScheduler3.java:325)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security
[ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408182#comment-15408182 ] ASF subversion and git services commented on GEODE-1712: Commit 64c3c62783a2890c333c8330feaaf4df7fd0d4ff in incubator-geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=64c3c62 ] GEODE-1712: fix AnalyzeSerializablesJUnitTest for GEODE-1712 changes > Need unit tests for classes using Integrated Security > - > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.0.0-incubating.M1 >Reporter: Grace Meilen >Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit > Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can > be mocked so it's possible to write Unit Tests for all of the classes using > Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security
[ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408183#comment-15408183 ] ASF subversion and git services commented on GEODE-1712: Commit 64c3c62783a2890c333c8330feaaf4df7fd0d4ff in incubator-geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=64c3c62 ] GEODE-1712: fix AnalyzeSerializablesJUnitTest for GEODE-1712 changes > Need unit tests for classes using Integrated Security > - > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.0.0-incubating.M1 >Reporter: Grace Meilen >Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit > Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can > be mocked so it's possible to write Unit Tests for all of the classes using > Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (GEODE-1718) Region replace can return false when it should not and can fail with an NPE
[ https://issues.apache.org/jira/browse/GEODE-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-1718. - Resolution: Fixed Fix Version/s: 1.0.0-incubating > Region replace can return false when it should not and can fail with an NPE > --- > > Key: GEODE-1718 > URL: https://issues.apache.org/jira/browse/GEODE-1718 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider > Fix For: 1.0.0-incubating > > > The Region replace method may return false when it should have returned true. > The can happen on a region configured with overflow when the entry being > replaced has overflowed to disk. It can also happen on a persistent region if > the entry being replaced has not yet initialized its value from disk. > The NPE happens under the same configurations but when the expected old value > was serialized with PDX and read-serialized was set to true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (GEODE-1727) NPE in JGroups during shutdown
[
https://issues.apache.org/jira/browse/GEODE-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruce Schuchardt resolved GEODE-1727.
-
Resolution: Fixed
> NPE in JGroups during shutdown
> --
>
> Key: GEODE-1727
> URL: https://issues.apache.org/jira/browse/GEODE-1727
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Bruce Schuchardt
>
> A test failed with a suspect string during shutdown.
> {noformat}
> [error 2016/07/28 06:52:39.126 UTC locatorgemfire_3_2_client-06_5333 UDP Timer-2,client-06-34033> tid=0x27] Exception caught while sending message
> java.lang.NullPointerException
> at org.jgroups.protocols.TP.send(TP.java:1861)
> at
> com.gemstone.gemfire.distributed.internal.membership.gms.messenger.Transport._send(Transport.java:54)
> at org.jgroups.protocols.TP.down(TP.java:1474)
> at org.jgroups.stack.Protocol.down(Protocol.java:439)
> at
> com.gemstone.gemfire.distributed.internal.membership.gms.messenger.StatRecorder.down(StatRecorder.java:90)
> at org.jgroups.protocols.UNICAST3.sendAck(UNICAST3.java:1126)
> at org.jgroups.protocols.UNICAST3.triggerXmit(UNICAST3.java:1521)
> at
> org.jgroups.protocols.UNICAST3$RetransmitTask.run(UNICAST3.java:1502)
> at org.jgroups.util.TimeScheduler3$Task.run(TimeScheduler3.java:291)
> at
> org.jgroups.util.TimeScheduler3$RecurringTask.run(TimeScheduler3.java:325)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1718) Region replace can return false when it should not and can fail with an NPE
[ https://issues.apache.org/jira/browse/GEODE-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408132#comment-15408132 ] ASF subversion and git services commented on GEODE-1718: Commit 91e234f85a6f8dfe1eedd59f6978e3667d0fd92a in incubator-geode's branch refs/heads/develop from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=91e234f ] GEODE-1718: fix replace on overflowed entry When replace checks the current value for equality with the expected value it now gets it from the EntryEventImpl which the replace operation had already called setOldValue on. Added a unit test that confirms that replace works on an overflowed entry and also handles INVALID values correctly. > Region replace can return false when it should not and can fail with an NPE > --- > > Key: GEODE-1718 > URL: https://issues.apache.org/jira/browse/GEODE-1718 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider > > The Region replace method may return false when it should have returned true. > The can happen on a region configured with overflow when the entry being > replaced has overflowed to disk. It can also happen on a persistent region if > the entry being replaced has not yet initialized its value from disk. > The NPE happens under the same configurations but when the expected old value > was serialized with PDX and read-serialized was set to true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1713) CQ client commands have inconsistent security support
[ https://issues.apache.org/jira/browse/GEODE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408119#comment-15408119 ] ASF subversion and git services commented on GEODE-1713: Commit 3ac987fe8be0888db00c7bbb12125467564c56f1 in incubator-geode's branch refs/heads/develop from gmeilen [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3ac987f ] GEODE-1713: cleanup imports > CQ client commands have inconsistent security support > - > > Key: GEODE-1713 > URL: https://issues.apache.org/jira/browse/GEODE-1713 > Project: Geode > Issue Type: Bug > Components: security >Reporter: Grace Meilen >Assignee: Kirk Lund > > The following CQ client commands appear to be using old security but not new > Integrated Security: > * ExecuteCQ > * ExecuteCQ61 > The following appear to be using new Integrated Security but not old security > (these may not need any security): > * GetCQStats > * MonitorCQ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security
[ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408121#comment-15408121 ] ASF subversion and git services commented on GEODE-1712: Commit a9791ad9522c5307b554600feafb738ee987afa2 in incubator-geode's branch refs/heads/develop from gmeilen [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=a9791ad ] GEODE-1712: add missing categories and fix test failures This closes #226 > Need unit tests for classes using Integrated Security > - > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.0.0-incubating.M1 >Reporter: Grace Meilen >Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit > Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can > be mocked so it's possible to write Unit Tests for all of the classes using > Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security
[ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408118#comment-15408118 ] ASF subversion and git services commented on GEODE-1712: Commit f93b748537138b970b944f3aec05363de9bc7ffa in incubator-geode's branch refs/heads/develop from gmeilen [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=f93b748 ] GEODE-1712: introduce SecurityService interface for mocking * create Unit Tests for client commands that use security > Need unit tests for classes using Integrated Security > - > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.0.0-incubating.M1 >Reporter: Grace Meilen >Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit > Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can > be mocked so it's possible to write Unit Tests for all of the classes using > Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security
[ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408120#comment-15408120 ] ASF subversion and git services commented on GEODE-1712: Commit 8dea2cf100c7220c673f8bcd6033ae35c67eeb90 in incubator-geode's branch refs/heads/develop from gmeilen [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=8dea2cf ] GEODE-1712: add static factory methods to SecurityService > Need unit tests for classes using Integrated Security > - > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.0.0-incubating.M1 >Reporter: Grace Meilen >Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit > Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can > be mocked so it's possible to write Unit Tests for all of the classes using > Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1712) Need unit tests for classes using Integrated Security
[ https://issues.apache.org/jira/browse/GEODE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408122#comment-15408122 ] ASF GitHub Bot commented on GEODE-1712: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/226 > Need unit tests for classes using Integrated Security > - > > Key: GEODE-1712 > URL: https://issues.apache.org/jira/browse/GEODE-1712 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.0.0-incubating.M1 >Reporter: Grace Meilen >Assignee: Grace Meilen > Labels: security > > Most of the classes using Integrated Security (GEODE-17) do not have Unit > Tests (some have Integrated Test coverage). > We need to wrap GeodeSecurityUtil in an interface (SecurityService) that can > be mocked so it's possible to write Unit Tests for all of the classes using > Integrated Security. > Client command classes that need Unit Tests: > * CommitCommand > * ContainsKey > * ContainsKey66 > * CreateRegion > * Destroy65 > * DestroyRegion > * Destroy > * ExecuteFunction65 > * ExecuteFunction66 > * ExecuteFunction > * Get70 > * GetAll70 > * GetAll651 > * GetAll > * GetAllWithCallback > * GetClientPartitionAttributesCommand66 > * GetClientPartitionAttributesCommand > * Invalidate > * KeySet > * Put61 > * Put65 > * Put > * RegisterInterest61 > * RegisterInterestList61 > * RegisterInterestList66 > * RegisterInterest > * RemoveAll > * Request > * UnregisterInterest > Non-core client command classes needing Unit Tests: > * CloseCQ > * ExecuteCQ > * ExecuteCQ61 > * GetCQStats > * GetDurableCQs > * MonitorCQ > * StopCQ > More classes needing Unit Tests: > * AcceptorImpl > * CacheClientProxy > * HandShake > * ServerConnection > * CreateAllterDestroyRegionCommands > * DataCommands > * IndexCommands > * DataCommandFunction > * CommandProcessor > * AccessControlMBean > * MBeanServerWrapper > * LoginHandlerInterceptor > * LuceneIndexCommands > * SystemManagementService -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (GEODE-1648) Provide ability to disable security for some components
[
https://issues.apache.org/jira/browse/GEODE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grace Meilen reassigned GEODE-1648:
---
Assignee: Grace Meilen
> Provide ability to disable security for some components
> ---
>
> Key: GEODE-1648
> URL: https://issues.apache.org/jira/browse/GEODE-1648
> Project: Geode
> Issue Type: Sub-task
> Components: security
>Reporter: Swapnil Bawaskar
>Assignee: Grace Meilen
>
> When the new {{SecurityManager}} interface is used, it will enable
> authentication and authorization for client-server, jmx, peer-to-peer and
> WAN. Not all users will want authentication and authorization for all these
> components as explained in this comment:
> https://issues.apache.org/jira/browse/GEODE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369089#comment-15369089
> We should add new geode properties:
> {noformat}
> enable-peer-to-peer-authentication
> enable-client-server-security
> enable-msnsgement-security
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (GEODE-1728) SessionCachingFilter can create multiple sessions when requests are forwarded
[
https://issues.apache.org/jira/browse/GEODE-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Smith reassigned GEODE-1728:
Assignee: Dan Smith
> SessionCachingFilter can create multiple sessions when requests are forwarded
> -
>
> Key: GEODE-1728
> URL: https://issues.apache.org/jira/browse/GEODE-1728
> Project: Geode
> Issue Type: Bug
> Components: http session
>Reporter: Dan Smith
>Assignee: Dan Smith
>
> Our installer adds this configuration to the users web.xml file for the
> session state replication:
> {code}
>
> gemfire-session-filter
> /*
> FORWARD
> INCLUDE
> REQUEST
> ERROR
>
> {code}
> This means that our filter will be applied to all incoming requests, and it
> will be applied *again* if the request is forwarded to or includes another
> servlet.
> We wrap the HttpServletRequest in our own RequestWrapper class. We have some
> code that tries to prevent wrapping a request multiple times:
> {code}
> /**
> * Early out if this isn't the right kind of request. We might see a
> * RequestWrapper instance during a forward or include request.
> */
> if (request instanceof RequestWrapper ||
> !(request instanceof HttpServletRequest)) {
> LOG.debug("Handling already-wrapped request");
> chain.doFilter(request, response);
> return;
> }
> {code}
> Unfortunately, this check will not work if there are *other* filters in the
> chain that also wrap the HttpServletRequest. That can result in us wrapping
> the forwarded request in a new RequestWrapper that will create another
> session.
> We should not add these elements to the web.xml; it should be
> sufficient for our filter to intercept all requests initially. In addition,
> we might want to enhance our check to see if we have already wrapped a
> request to follow the chain of wrapped requests deeper. As long as other
> filters wrap the request in a subclass of HttpServletRequestWrapper we should
> be able to unwrap the request if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (GEODE-1728) SessionCachingFilter can create multiple sessions when requests are forwarded
Dan Smith created GEODE-1728:
Summary: SessionCachingFilter can create multiple sessions when
requests are forwarded
Key: GEODE-1728
URL: https://issues.apache.org/jira/browse/GEODE-1728
Project: Geode
Issue Type: Bug
Components: http session
Reporter: Dan Smith
Our installer adds this configuration to the users web.xml file for the session
state replication:
{code}
gemfire-session-filter
/*
FORWARD
INCLUDE
REQUEST
ERROR
{code}
This means that our filter will be applied to all incoming requests, and it
will be applied *again* if the request is forwarded to or includes another
servlet.
We wrap the HttpServletRequest in our own RequestWrapper class. We have some
code that tries to prevent wrapping a request multiple times:
{code}
/**
* Early out if this isn't the right kind of request. We might see a
* RequestWrapper instance during a forward or include request.
*/
if (request instanceof RequestWrapper ||
!(request instanceof HttpServletRequest)) {
LOG.debug("Handling already-wrapped request");
chain.doFilter(request, response);
return;
}
{code}
Unfortunately, this check will not work if there are *other* filters in the
chain that also wrap the HttpServletRequest. That can result in us wrapping the
forwarded request in a new RequestWrapper that will create another session.
We should not add these elements to the web.xml; it should be
sufficient for our filter to intercept all requests initially. In addition, we
might want to enhance our check to see if we have already wrapped a request to
follow the chain of wrapped requests deeper. As long as other filters wrap the
request in a subclass of HttpServletRequestWrapper we should be able to unwrap
the request if needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-225) excessive CPU utilization and garbage collection strain for JSON processing
[
https://issues.apache.org/jira/browse/GEODE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408052#comment-15408052
]
Bruce Schuchardt commented on GEODE-225:
Performance tests show that it takes a microsecond to create and configure an
ObjectMapper. Using the same ObjectMapper in concurrent threads could cause a
thread to stall so we need to talk about the trade-off.
> excessive CPU utilization and garbage collection strain for JSON processing
> ---
>
> Key: GEODE-225
> URL: https://issues.apache.org/jira/browse/GEODE-225
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Affects Versions: 1.0.0-incubating
>Reporter: Konstantin Ignatyev
>
> I have been looking at Geode-s code and come across major performance killer
> for JSON handling in Geode, namely implementation of
> com.gemstone.gemfire.pdx.internal.PdxInstanceImpl#getObject
> as you can see in the snipped below the code creates ObjectMapper every time
> it needs to convert PDX instance into JSON. According to docs and examples on
> Jackson’s site instances of ObjectMapper should be shared globally. Creating
> it for every transaction is quite expensive in terms of CPU and garbage
> collection.
> public Object getObject() {
> if (getPdxType().getNoDomainClass()) {
> //In case of Developer Rest APIs, All PdxInstances converted from Json
> will have a className =__GEMFIRE_JSON.
> //Following code added to convert Json/PdxInstance into the Java object.
> if(this.getClassName().equals("__GEMFIRE_JSON")){
>
> //introspect the JSON, does the @type meta-data exist.
> String className = extractTypeMetaData();
>
> if(StringUtils.hasText(className)) {
> try {
> ObjectMapper mapper = new ObjectMapper();
> mapper.setDateFormat(new SimpleDateFormat("MM/dd/"));
> mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
> false);
>
> mapper.configure(com.fasterxml.jackson.core.JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES,
> true);
> String JSON = JSONFormatter.toJSON(this);
> Object classInstance = mapper.readValue(JSON,
> ClassPathLoader.getLatest().forName(className));
> return classInstance;
> }catch(Exception e){
> throw new PdxSerializationException("Could not deserialize as java
> class type could not resolved", e);
> }
> }
> }
> return this;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (GEODE-225) excessive CPU utilization and garbage collection strain for JSON processing
[
https://issues.apache.org/jira/browse/GEODE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruce Schuchardt updated GEODE-225:
---
Comment: was deleted
(was: Performance tests for creating and configuring an Object mapper show that
it takes only a few nanoseconds. Using the same ObjectMapper in concurrent
threads has the potential to cause threads to stall so I don't think we want to
do this.)
> excessive CPU utilization and garbage collection strain for JSON processing
> ---
>
> Key: GEODE-225
> URL: https://issues.apache.org/jira/browse/GEODE-225
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Affects Versions: 1.0.0-incubating
>Reporter: Konstantin Ignatyev
>
> I have been looking at Geode-s code and come across major performance killer
> for JSON handling in Geode, namely implementation of
> com.gemstone.gemfire.pdx.internal.PdxInstanceImpl#getObject
> as you can see in the snipped below the code creates ObjectMapper every time
> it needs to convert PDX instance into JSON. According to docs and examples on
> Jackson’s site instances of ObjectMapper should be shared globally. Creating
> it for every transaction is quite expensive in terms of CPU and garbage
> collection.
> public Object getObject() {
> if (getPdxType().getNoDomainClass()) {
> //In case of Developer Rest APIs, All PdxInstances converted from Json
> will have a className =__GEMFIRE_JSON.
> //Following code added to convert Json/PdxInstance into the Java object.
> if(this.getClassName().equals("__GEMFIRE_JSON")){
>
> //introspect the JSON, does the @type meta-data exist.
> String className = extractTypeMetaData();
>
> if(StringUtils.hasText(className)) {
> try {
> ObjectMapper mapper = new ObjectMapper();
> mapper.setDateFormat(new SimpleDateFormat("MM/dd/"));
> mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
> false);
>
> mapper.configure(com.fasterxml.jackson.core.JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES,
> true);
> String JSON = JSONFormatter.toJSON(this);
> Object classInstance = mapper.readValue(JSON,
> ClassPathLoader.getLatest().forName(className));
> return classInstance;
> }catch(Exception e){
> throw new PdxSerializationException("Could not deserialize as java
> class type could not resolved", e);
> }
> }
> }
> return this;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (GEODE-225) excessive CPU utilization and garbage collection strain for JSON processing
[
https://issues.apache.org/jira/browse/GEODE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruce Schuchardt updated GEODE-225:
---
Assignee: (was: Bruce Schuchardt)
> excessive CPU utilization and garbage collection strain for JSON processing
> ---
>
> Key: GEODE-225
> URL: https://issues.apache.org/jira/browse/GEODE-225
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Affects Versions: 1.0.0-incubating
>Reporter: Konstantin Ignatyev
>
> I have been looking at Geode-s code and come across major performance killer
> for JSON handling in Geode, namely implementation of
> com.gemstone.gemfire.pdx.internal.PdxInstanceImpl#getObject
> as you can see in the snipped below the code creates ObjectMapper every time
> it needs to convert PDX instance into JSON. According to docs and examples on
> Jackson’s site instances of ObjectMapper should be shared globally. Creating
> it for every transaction is quite expensive in terms of CPU and garbage
> collection.
> public Object getObject() {
> if (getPdxType().getNoDomainClass()) {
> //In case of Developer Rest APIs, All PdxInstances converted from Json
> will have a className =__GEMFIRE_JSON.
> //Following code added to convert Json/PdxInstance into the Java object.
> if(this.getClassName().equals("__GEMFIRE_JSON")){
>
> //introspect the JSON, does the @type meta-data exist.
> String className = extractTypeMetaData();
>
> if(StringUtils.hasText(className)) {
> try {
> ObjectMapper mapper = new ObjectMapper();
> mapper.setDateFormat(new SimpleDateFormat("MM/dd/"));
> mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
> false);
>
> mapper.configure(com.fasterxml.jackson.core.JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES,
> true);
> String JSON = JSONFormatter.toJSON(this);
> Object classInstance = mapper.readValue(JSON,
> ClassPathLoader.getLatest().forName(className));
> return classInstance;
> }catch(Exception e){
> throw new PdxSerializationException("Could not deserialize as java
> class type could not resolved", e);
> }
> }
> }
> return this;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-225) excessive CPU utilization and garbage collection strain for JSON processing
[
https://issues.apache.org/jira/browse/GEODE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408021#comment-15408021
]
Bruce Schuchardt commented on GEODE-225:
Performance tests for creating and configuring an Object mapper show that it
takes only a few nanoseconds. Using the same ObjectMapper in concurrent
threads has the potential to cause threads to stall so I don't think we want to
do this.
> excessive CPU utilization and garbage collection strain for JSON processing
> ---
>
> Key: GEODE-225
> URL: https://issues.apache.org/jira/browse/GEODE-225
> Project: Geode
> Issue Type: Improvement
> Components: serialization
>Affects Versions: 1.0.0-incubating
>Reporter: Konstantin Ignatyev
>Assignee: Bruce Schuchardt
>
> I have been looking at Geode-s code and come across major performance killer
> for JSON handling in Geode, namely implementation of
> com.gemstone.gemfire.pdx.internal.PdxInstanceImpl#getObject
> as you can see in the snipped below the code creates ObjectMapper every time
> it needs to convert PDX instance into JSON. According to docs and examples on
> Jackson’s site instances of ObjectMapper should be shared globally. Creating
> it for every transaction is quite expensive in terms of CPU and garbage
> collection.
> public Object getObject() {
> if (getPdxType().getNoDomainClass()) {
> //In case of Developer Rest APIs, All PdxInstances converted from Json
> will have a className =__GEMFIRE_JSON.
> //Following code added to convert Json/PdxInstance into the Java object.
> if(this.getClassName().equals("__GEMFIRE_JSON")){
>
> //introspect the JSON, does the @type meta-data exist.
> String className = extractTypeMetaData();
>
> if(StringUtils.hasText(className)) {
> try {
> ObjectMapper mapper = new ObjectMapper();
> mapper.setDateFormat(new SimpleDateFormat("MM/dd/"));
> mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
> false);
>
> mapper.configure(com.fasterxml.jackson.core.JsonParser.Feature.ALLOW_UNQUOTED_FIELD_NAMES,
> true);
> String JSON = JSONFormatter.toJSON(this);
> Object classInstance = mapper.readValue(JSON,
> ClassPathLoader.getLatest().forName(className));
> return classInstance;
> }catch(Exception e){
> throw new PdxSerializationException("Could not deserialize as java
> class type could not resolved", e);
> }
> }
> }
> return this;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1570) developer REST API should be secured
[ https://issues.apache.org/jira/browse/GEODE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408009#comment-15408009 ] ASF subversion and git services commented on GEODE-1570: Commit 88247e32132c4a0f2de00db51b57d6e3fe48b5f2 in incubator-geode's branch refs/heads/develop from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=88247e3 ] GEODE-1570: add rest security test harness and rearranged the tests rearranged the tests > developer REST API should be secured > > > Key: GEODE-1570 > URL: https://issues.apache.org/jira/browse/GEODE-1570 > Project: Geode > Issue Type: Sub-task > Components: rest (dev), security >Reporter: Swapnil Bawaskar > > The developer REST API should require authentication when security is > enabled. For authorization, the implementation should use the new > Resource:Operation permissions API that is used by JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-1727) NPE in JGroups during shutdown
Bruce Schuchardt created GEODE-1727:
---
Summary: NPE in JGroups during shutdown
Key: GEODE-1727
URL: https://issues.apache.org/jira/browse/GEODE-1727
Project: Geode
Issue Type: Bug
Components: membership
Reporter: Bruce Schuchardt
A test failed with a suspect string during shutdown.
{noformat}
[error 2016/07/28 06:52:39.126 UTC locatorgemfire_3_2_client-06_5333 tid=0x27] Exception caught while sending message
java.lang.NullPointerException
at org.jgroups.protocols.TP.send(TP.java:1861)
at
com.gemstone.gemfire.distributed.internal.membership.gms.messenger.Transport._send(Transport.java:54)
at org.jgroups.protocols.TP.down(TP.java:1474)
at org.jgroups.stack.Protocol.down(Protocol.java:439)
at
com.gemstone.gemfire.distributed.internal.membership.gms.messenger.StatRecorder.down(StatRecorder.java:90)
at org.jgroups.protocols.UNICAST3.sendAck(UNICAST3.java:1126)
at org.jgroups.protocols.UNICAST3.triggerXmit(UNICAST3.java:1521)
at org.jgroups.protocols.UNICAST3$RetransmitTask.run(UNICAST3.java:1502)
at org.jgroups.util.TimeScheduler3$Task.run(TimeScheduler3.java:291)
at
org.jgroups.util.TimeScheduler3$RecurringTask.run(TimeScheduler3.java:325)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (GEODE-1722) Distributed tests should use a restricted membership-port-range
[ https://issues.apache.org/jira/browse/GEODE-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-1722. - Resolution: Fixed > Distributed tests should use a restricted membership-port-range > --- > > Key: GEODE-1722 > URL: https://issues.apache.org/jira/browse/GEODE-1722 > Project: Geode > Issue Type: Improvement >Reporter: Bruce Schuchardt >Assignee: Bruce Schuchardt > > Distributed unit tests are using a membership-port-range that includes the > pool of port numbers used by AvailablePort and AvailablePortHelper. Since > most tests grab available port during set-up and then create caches this > makes it possible for the caches to grab the "available" ports and cause the > test to fail when the test tells a cache-server or other component to use the > ports returned by AvailablePort or AvailablePortHelper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-1726) Clean up compilation warnings in new GMS
Bruce Schuchardt created GEODE-1726: --- Summary: Clean up compilation warnings in new GMS Key: GEODE-1726 URL: https://issues.apache.org/jira/browse/GEODE-1726 Project: Geode Issue Type: Bug Components: membership Reporter: Bruce Schuchardt We have not made a serious pass over the new GMS classes to clean up compilation warnings. IntelliJ shows a lot of unused parameters, non-final variables used for synchronization, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
