[jira] [Resolved] (GEODE-1761) Clients don't fail back to servers containing non-redundant partitioned regions when they are bounced and rebalanced
[ https://issues.apache.org/jira/browse/GEODE-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] William Markito Oliveira resolved GEODE-1761. - Resolution: Fixed > Clients don't fail back to servers containing non-redundant partitioned > regions when they are bounced and rebalanced > > > Key: GEODE-1761 > URL: https://issues.apache.org/jira/browse/GEODE-1761 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Bruce Schuchardt > Fix For: 1.0.0-incubating > > > Clients don't fail back to servers containing non-redundant partitioned > regions when they are bounced and rebalanced. > When one of the servers is stopped, the client switches to the server(s) > containing the new primary. When the server is restarted and rebalanced > (which recovers primaryness), the clients do not switch back even though the > server continually sends the metadata refresh byte on each operation. > If the partitioned region has a redundant copy, clients do switch back. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (GEODE-1761) Clients don't fail back to servers containing non-redundant partitioned regions when they are bounced and rebalanced
[ https://issues.apache.org/jira/browse/GEODE-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] William Markito Oliveira updated GEODE-1761: Fix Version/s: 1.0.0-incubating > Clients don't fail back to servers containing non-redundant partitioned > regions when they are bounced and rebalanced > > > Key: GEODE-1761 > URL: https://issues.apache.org/jira/browse/GEODE-1761 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Bruce Schuchardt > Fix For: 1.0.0-incubating > > > Clients don't fail back to servers containing non-redundant partitioned > regions when they are bounced and rebalanced. > When one of the servers is stopped, the client switches to the server(s) > containing the new primary. When the server is restarted and rebalanced > (which recovers primaryness), the clients do not switch back even though the > server continually sends the metadata refresh byte on each operation. > If the partitioned region has a redundant copy, clients do switch back. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (GEODE-1803) Inefficient code in ClientMetadataService.getServerToFilterMap()
[ https://issues.apache.org/jira/browse/GEODE-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt reassigned GEODE-1803: --- Assignee: Bruce Schuchardt > Inefficient code in ClientMetadataService.getServerToFilterMap() > > > Key: GEODE-1803 > URL: https://issues.apache.org/jira/browse/GEODE-1803 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Bruce Schuchardt >Assignee: Bruce Schuchardt > > This method is using Collections.shuffle(List).get(0) to select a random > server when it would be a lot cheaper to pick a random element from the > unshuffled list of server locations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-1803) Inefficient code in ClientMetadataService.getServerToFilterMap()
Bruce Schuchardt created GEODE-1803: --- Summary: Inefficient code in ClientMetadataService.getServerToFilterMap() Key: GEODE-1803 URL: https://issues.apache.org/jira/browse/GEODE-1803 Project: Geode Issue Type: Bug Components: client/server Reporter: Bruce Schuchardt This method is using Collections.shuffle(List).get(0) to select a random server when it would be a lot cheaper to pick a random element from the unshuffled list of server locations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (GEODE-1800) StoppableCondition has faulty code in await()
[ https://issues.apache.org/jira/browse/GEODE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-1800. - Resolution: Fixed Fix Version/s: 1.0.0-incubating > StoppableCondition has faulty code in await() > - > > Key: GEODE-1800 > URL: https://issues.apache.org/jira/browse/GEODE-1800 > Project: Geode > Issue Type: Bug > Components: general >Reporter: Bruce Schuchardt > Fix For: 1.0.0-incubating > > > StoppableCondition.await() loops invoking await(long). This can loop > indefinitely if the first invocation of await(long) times out. We need to > remove this method and replace all uses with await(long). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1800) StoppableCondition has faulty code in await()
[ https://issues.apache.org/jira/browse/GEODE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428873#comment-15428873 ] ASF subversion and git services commented on GEODE-1800: Commit 88b561d64dc328ca2cf9d36ea4a94bc58d80ff19 in incubator-geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=88b561d ] GEODE-1800 StoppableCondition has faulty code in await() The faulty methods in StoppableCondition have been removed. I considered removing StoppableCondition entirely and just using a Condition on the lock wrapped by the Stoppable lock class but doing so would require additional work to make the CancelCriterion available to the code that uses these StoppableConditions, so other than removing the methods I've left the class alone. > StoppableCondition has faulty code in await() > - > > Key: GEODE-1800 > URL: https://issues.apache.org/jira/browse/GEODE-1800 > Project: Geode > Issue Type: Bug > Components: general >Reporter: Bruce Schuchardt > > StoppableCondition.await() loops invoking await(long). This can loop > indefinitely if the first invocation of await(long) times out. We need to > remove this method and replace all uses with await(long). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-11) Lucene Integration
[ https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428627#comment-15428627 ] ASF subversion and git services commented on GEODE-11: -- Commit 1ab59ffb20346a957cfcbc8324376f772f14da96 in incubator-geode's branch refs/heads/develop from [~adharmakkan] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=1ab59ff ] GEODE-11: Fixing bug that arises while using user defined analyzer in gfsh. This closes #233 When we use an user defined analyzer class in gfsh, the cluster hangs because the create region message that is sent has a LuceneIndexCreationProfile has a user defined analyzer class. Fixed this by storing only the class name in LuceneIndexCreationProfile. Signed-off-by: Gester Zhou GEODE-11: StandardAnalyzer is used when analyzer option is null Using the string "null" in the analyzer option for create lucene index command will now set the field analyzer to be StandardAnalyzer. GEODE-11: Added CliAvailabilityIndicator to lucene gfsh commands The lucene gfsh commands were available offline. Changed this behavior by adding CliAvailabilityIndicator. GEODE-11:Fix for "Comparison method violates general contract" The search results are sorted by score and the compareTo method caused the "Comparison method violates general contract" error when it returned multiple results with same score. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Clean up of comparison code in LuceneIndexCreationProfile Since the null in fieldAnalyzers are converted to Standard analyzer, a few checks become irrelevant. Modified the code and relevant tests. Signed-off-by: Gester Zhou fix merge issue > Lucene Integration > -- > > Key: GEODE-11 > URL: https://issues.apache.org/jira/browse/GEODE-11 > Project: Geode > Issue Type: New Feature > Components: docs, querying >Reporter: Dan Smith >Assignee: xiaojian zhou > Labels: experimental > > This is a feature that has been under development for GemFire but was not > part of the initial drop of code for geode. > Allow Lucene indexes to be stored in Geode regions allowing users to do text > searches on data stored in Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-11) Lucene Integration
[ https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428628#comment-15428628 ] ASF subversion and git services commented on GEODE-11: -- Commit 1ab59ffb20346a957cfcbc8324376f772f14da96 in incubator-geode's branch refs/heads/develop from [~adharmakkan] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=1ab59ff ] GEODE-11: Fixing bug that arises while using user defined analyzer in gfsh. This closes #233 When we use an user defined analyzer class in gfsh, the cluster hangs because the create region message that is sent has a LuceneIndexCreationProfile has a user defined analyzer class. Fixed this by storing only the class name in LuceneIndexCreationProfile. Signed-off-by: Gester Zhou GEODE-11: StandardAnalyzer is used when analyzer option is null Using the string "null" in the analyzer option for create lucene index command will now set the field analyzer to be StandardAnalyzer. GEODE-11: Added CliAvailabilityIndicator to lucene gfsh commands The lucene gfsh commands were available offline. Changed this behavior by adding CliAvailabilityIndicator. GEODE-11:Fix for "Comparison method violates general contract" The search results are sorted by score and the compareTo method caused the "Comparison method violates general contract" error when it returned multiple results with same score. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Clean up of comparison code in LuceneIndexCreationProfile Since the null in fieldAnalyzers are converted to Standard analyzer, a few checks become irrelevant. Modified the code and relevant tests. Signed-off-by: Gester Zhou fix merge issue > Lucene Integration > -- > > Key: GEODE-11 > URL: https://issues.apache.org/jira/browse/GEODE-11 > Project: Geode > Issue Type: New Feature > Components: docs, querying >Reporter: Dan Smith >Assignee: xiaojian zhou > Labels: experimental > > This is a feature that has been under development for GemFire but was not > part of the initial drop of code for geode. > Allow Lucene indexes to be stored in Geode regions allowing users to do text > searches on data stored in Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-11) Lucene Integration
[ https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428626#comment-15428626 ] ASF subversion and git services commented on GEODE-11: -- Commit 1ab59ffb20346a957cfcbc8324376f772f14da96 in incubator-geode's branch refs/heads/develop from [~adharmakkan] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=1ab59ff ] GEODE-11: Fixing bug that arises while using user defined analyzer in gfsh. This closes #233 When we use an user defined analyzer class in gfsh, the cluster hangs because the create region message that is sent has a LuceneIndexCreationProfile has a user defined analyzer class. Fixed this by storing only the class name in LuceneIndexCreationProfile. Signed-off-by: Gester Zhou GEODE-11: StandardAnalyzer is used when analyzer option is null Using the string "null" in the analyzer option for create lucene index command will now set the field analyzer to be StandardAnalyzer. GEODE-11: Added CliAvailabilityIndicator to lucene gfsh commands The lucene gfsh commands were available offline. Changed this behavior by adding CliAvailabilityIndicator. GEODE-11:Fix for "Comparison method violates general contract" The search results are sorted by score and the compareTo method caused the "Comparison method violates general contract" error when it returned multiple results with same score. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Clean up of comparison code in LuceneIndexCreationProfile Since the null in fieldAnalyzers are converted to Standard analyzer, a few checks become irrelevant. Modified the code and relevant tests. Signed-off-by: Gester Zhou fix merge issue > Lucene Integration > -- > > Key: GEODE-11 > URL: https://issues.apache.org/jira/browse/GEODE-11 > Project: Geode > Issue Type: New Feature > Components: docs, querying >Reporter: Dan Smith >Assignee: xiaojian zhou > Labels: experimental > > This is a feature that has been under development for GemFire but was not > part of the initial drop of code for geode. > Allow Lucene indexes to be stored in Geode regions allowing users to do text > searches on data stored in Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-11) Lucene Integration
[ https://issues.apache.org/jira/browse/GEODE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428629#comment-15428629 ] ASF subversion and git services commented on GEODE-11: -- Commit 1ab59ffb20346a957cfcbc8324376f772f14da96 in incubator-geode's branch refs/heads/develop from [~adharmakkan] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=1ab59ff ] GEODE-11: Fixing bug that arises while using user defined analyzer in gfsh. This closes #233 When we use an user defined analyzer class in gfsh, the cluster hangs because the create region message that is sent has a LuceneIndexCreationProfile has a user defined analyzer class. Fixed this by storing only the class name in LuceneIndexCreationProfile. Signed-off-by: Gester Zhou GEODE-11: StandardAnalyzer is used when analyzer option is null Using the string "null" in the analyzer option for create lucene index command will now set the field analyzer to be StandardAnalyzer. GEODE-11: Added CliAvailabilityIndicator to lucene gfsh commands The lucene gfsh commands were available offline. Changed this behavior by adding CliAvailabilityIndicator. GEODE-11:Fix for "Comparison method violates general contract" The search results are sorted by score and the compareTo method caused the "Comparison method violates general contract" error when it returned multiple results with same score. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Added a check to make sure StandardAnalyzer and NULL were considered the same. LuceneIndexCreationProfile checks to makes sure the newly created index's field analyzers are consistent with existing indexes' field analyzers. However, when a field's analyzer is null and a new index is created with StandardAnalyzer on the same field, it failed. Fixed this issue by modifying the conditional checks. Added dunit tests to verify. Signed-off-by: Gester Zhou GEODE 11: Clean up of comparison code in LuceneIndexCreationProfile Since the null in fieldAnalyzers are converted to Standard analyzer, a few checks become irrelevant. Modified the code and relevant tests. Signed-off-by: Gester Zhou fix merge issue > Lucene Integration > -- > > Key: GEODE-11 > URL: https://issues.apache.org/jira/browse/GEODE-11 > Project: Geode > Issue Type: New Feature > Components: docs, querying >Reporter: Dan Smith >Assignee: xiaojian zhou > Labels: experimental > > This is a feature that has been under development for GemFire but was not > part of the initial drop of code for geode. > Allow Lucene indexes to be stored in Geode regions allowing users to do text > searches on data stored in Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1761) Clients don't fail back to servers containing non-redundant partitioned regions when they are bounced and rebalanced
[ https://issues.apache.org/jira/browse/GEODE-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428606#comment-15428606 ] ASF subversion and git services commented on GEODE-1761: Commit cea5535cf2e0de1ee1ef8ea902ea44a2f48b4fd5 in incubator-geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=cea5535 ] GEODE-1761 Clients don't fail back when servers are bounced Servers will send a refresh hint to clients if they detect that a request had to be send to a different server who owned the primary bucket affected by the operation. Clients should always refresh when this happens unless they have connection-pool size constraints that force them to use non-optimal servers. Client-side operation classes have been modified to initiate the refresh. I've added code in the meta-data service class to avoid performing multiple concurrent refreshes on the same region. On the server-side I've cleaned up some of the network-hop detection code to stop using hard-coded integers and to consolidate some of the code that resets the ThreadLocals being used to record network- hops detected. > Clients don't fail back to servers containing non-redundant partitioned > regions when they are bounced and rebalanced > > > Key: GEODE-1761 > URL: https://issues.apache.org/jira/browse/GEODE-1761 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Bruce Schuchardt > > Clients don't fail back to servers containing non-redundant partitioned > regions when they are bounced and rebalanced. > When one of the servers is stopped, the client switches to the server(s) > containing the new primary. When the server is restarted and rebalanced > (which recovers primaryness), the clients do not switch back even though the > server continually sends the metadata refresh byte on each operation. > If the partitioned region has a redundant copy, clients do switch back. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
