[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669437#comment-15669437
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
Thanks @kirklund, @metatype I have followed the process from 
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
Please do let me know if everything is correct.


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
> Fix For: 1.1.0-incubating
>
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2104) GFSH parsing of options following --J options are interpreted as part of the --J value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669016#comment-15669016
 ] 

ASF GitHub Bot commented on GEODE-2104:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/286


> GFSH parsing of options following --J options are interpreted as part of the 
> --J value
> --
>
> Key: GEODE-2104
> URL: https://issues.apache.org/jira/browse/GEODE-2104
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>
> GFSH parsing of options following --J options are interpreted as part of the 
> --J value.
> $ start server --name=me3 --J=-Dgemfire.jmx-manager=true 
> --J=-Dgemfire.jmx-manager-start=true --http-service-port=8080` 
> In the above GFSH does not interpret the `http-service-port` option 
> correctly.  If you look in the log, the value for `gemfire.jmx-manager-start` 
> is `true --http-service-port=8080`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2104) GFSH parsing of options following --J options are interpreted as part of the --J value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668250#comment-15668250
 ] 

ASF GitHub Bot commented on GEODE-2104:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/286
  
LGTM. build it and start up gfsh and play with it with different options 
and see if it's not having some side effects. After that I can pull this in.


> GFSH parsing of options following --J options are interpreted as part of the 
> --J value
> --
>
> Key: GEODE-2104
> URL: https://issues.apache.org/jira/browse/GEODE-2104
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>
> GFSH parsing of options following --J options are interpreted as part of the 
> --J value.
> $ start server --name=me3 --J=-Dgemfire.jmx-manager=true 
> --J=-Dgemfire.jmx-manager-start=true --http-service-port=8080` 
> In the above GFSH does not interpret the `http-service-port` option 
> correctly.  If you look in the log, the value for `gemfire.jmx-manager-start` 
> is `true --http-service-port=8080`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668156#comment-15668156
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/285


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2104) GFSH parsing of options following --J options are interpreted as part of the --J value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668006#comment-15668006
 ] 

ASF GitHub Bot commented on GEODE-2104:
---

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/286

GEODE-2104: Fix parsing of options following --J



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-2104

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #286


commit b4f1596bac584a1e0a82cb4a1065df5f496f1ee9
Author: Jared Stewart 
Date:   2016-11-15T18:57:11Z

GEODE-2104: Fix parsing of options following --J




> GFSH parsing of options following --J options are interpreted as part of the 
> --J value
> --
>
> Key: GEODE-2104
> URL: https://issues.apache.org/jira/browse/GEODE-2104
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>
> GFSH parsing of options following --J options are interpreted as part of the 
> --J value.
> $ start server --name=me3 --J=-Dgemfire.jmx-manager=true 
> --J=-Dgemfire.jmx-manager-start=true --http-service-port=8080` 
> In the above GFSH does not interpret the `http-service-port` option 
> correctly.  If you look in the log, the value for `gemfire.jmx-manager-start` 
> is `true --http-service-port=8080`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667883#comment-15667883
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/285#discussion_r88080988
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java
 ---
@@ -0,0 +1,75 @@
+package org.apache.geode.cache;
+
+import static org.junit.Assert.fail;
+
+import org.apache.geode.internal.cache.InternalRegionArguments;
+import org.apache.geode.internal.cache.LocalRegion;
+import org.apache.geode.test.junit.categories.UnitTest;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+@Category(UnitTest.class)
+public class RegionNameValidationJUnitTest {
+  private static final Pattern NAME_PATTERN = 
Pattern.compile("[aA-zZ0-9-_.]+");
+  private static final String REGION_NAME = "MyRegion";
+
+
+  @Test
+  public void testInvalidNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(false);
+try {
+  LocalRegion.validateRegionName(null, ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+try {
+  LocalRegion.validateRegionName("", ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+try {
+  LocalRegion.validateRegionName("FOO" + Region.SEPARATOR, ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+
+  }
+
+  @Test
+  public void testExternalRegionNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(false);
+validateCharacters(ira);
+try {
+  LocalRegion.validateRegionName("__InvalidInternalRegionName", ira);
--- End diff --

Yes, fixed.


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667885#comment-15667885
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/285#discussion_r88081170
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java
 ---
@@ -0,0 +1,75 @@
+package org.apache.geode.cache;
+
+import static org.junit.Assert.fail;
+
+import org.apache.geode.internal.cache.InternalRegionArguments;
+import org.apache.geode.internal.cache.LocalRegion;
+import org.apache.geode.test.junit.categories.UnitTest;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+@Category(UnitTest.class)
+public class RegionNameValidationJUnitTest {
+  private static final Pattern NAME_PATTERN = 
Pattern.compile("[aA-zZ0-9-_.]+");
+  private static final String REGION_NAME = "MyRegion";
+
+
+  @Test
+  public void testInvalidNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(false);
+try {
+  LocalRegion.validateRegionName(null, ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+try {
+  LocalRegion.validateRegionName("", ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+try {
+  LocalRegion.validateRegionName("FOO" + Region.SEPARATOR, ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+
+  }
+
+  @Test
+  public void testExternalRegionNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(false);
+validateCharacters(ira);
+try {
+  LocalRegion.validateRegionName("__InvalidInternalRegionName", ira);
+} catch (IllegalArgumentException ignore) {
+}
+  }
+
+  @Test
+  public void testInternalRegionNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(true);
+LocalRegion.validateRegionName("__ValidInternalRegionName", ira);
+  }
+
+  private void validateCharacters(InternalRegionArguments ira) {
+for (int x = 0; x < Character.MAX_VALUE; x++) {
+  String name = (char) x + REGION_NAME;
+  Matcher matcher = NAME_PATTERN.matcher(name);
+  if (matcher.matches()) {
+LocalRegion.validateRegionName(name, ira);
+  } else {
+try {
+  LocalRegion.validateRegionName(name, ira);
+  fail("Should have received an IllegalArgumentException");
--- End diff --

I added printing the offending character and the numeric value of it.


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667814#comment-15667814
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/285#discussion_r88075502
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java
 ---
@@ -0,0 +1,75 @@
+package org.apache.geode.cache;
+
+import static org.junit.Assert.fail;
+
+import org.apache.geode.internal.cache.InternalRegionArguments;
+import org.apache.geode.internal.cache.LocalRegion;
+import org.apache.geode.test.junit.categories.UnitTest;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+@Category(UnitTest.class)
+public class RegionNameValidationJUnitTest {
+  private static final Pattern NAME_PATTERN = 
Pattern.compile("[aA-zZ0-9-_.]+");
+  private static final String REGION_NAME = "MyRegion";
+
+
+  @Test
+  public void testInvalidNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(false);
+try {
+  LocalRegion.validateRegionName(null, ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+try {
+  LocalRegion.validateRegionName("", ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+try {
+  LocalRegion.validateRegionName("FOO" + Region.SEPARATOR, ira);
+  fail();
+} catch (IllegalArgumentException ignore) {
+}
+
+  }
+
+  @Test
+  public void testExternalRegionNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(false);
+validateCharacters(ira);
+try {
+  LocalRegion.validateRegionName("__InvalidInternalRegionName", ira);
+} catch (IllegalArgumentException ignore) {
+}
+  }
+
+  @Test
+  public void testInternalRegionNames() {
+InternalRegionArguments ira = new InternalRegionArguments();
+ira.setInternalRegion(true);
+LocalRegion.validateRegionName("__ValidInternalRegionName", ira);
+  }
+
+  private void validateCharacters(InternalRegionArguments ira) {
+for (int x = 0; x < Character.MAX_VALUE; x++) {
+  String name = (char) x + REGION_NAME;
+  Matcher matcher = NAME_PATTERN.matcher(name);
+  if (matcher.matches()) {
+LocalRegion.validateRegionName(name, ira);
+  } else {
+try {
+  LocalRegion.validateRegionName(name, ira);
+  fail("Should have received an IllegalArgumentException");
--- End diff --

Recommend adding which character to the message so we get instant info 
about which character should have been illegal but was allowed.


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2112) UITests are failing due to insufficient tearDown

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1566#comment-1566
 ] 

ASF GitHub Bot commented on GEODE-2112:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/284
  
I reworded your commit message (including line feed):

```
GEODE-2112: Improved cleanup for UITests

UITests were failing when more than one was run because
they all share a base class that was not properly cleaned up.

This closes #284
```


> UITests are failing due to insufficient tearDown
> 
>
> Key: GEODE-2112
> URL: https://issues.apache.org/jira/browse/GEODE-2112
> Project: Geode
>  Issue Type: Bug
>  Components: pulse, tests
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>
> UITests are failing due to insufficient tearDown
> {noformat}
> INFO: Connecting to jmxURL : 
> service:jmx:rmi://localhost/jndi/rmi://localhost:/jmxrmi
> [info 2016/11/14 15:51:15.940 PST  
> tid=0x14] Logging in admin
> [warn 2016/11/14 15:51:15.940 PST  
> tid=0x14] Authentication failed for token submission 
> [org.apache.geode.internal.security.shiro.GeodeAuthenticationToken - admin, 
> rememberMe=false].  Possible unexpected error? (Typical or expected login 
> exceptions should extend from AuthenticationException).
> org.apache.geode.security.AuthenticationFailedException: 
> SampleSecurityManager: wrong username/password
> at 
> org.apache.geode.security.templates.SampleSecurityManager.authenticate(SampleSecurityManager.java:146)
> at 
> org.apache.geode.internal.security.shiro.CustomAuthRealm.doGetAuthenticationInfo(CustomAuthRealm.java:66)
> at 
> org.apache.shiro.realm.AuthenticatingRealm.getAuthenticationInfo(AuthenticatingRealm.java:568)
> at 
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doSingleRealmAuthentication(ModularRealmAuthenticator.java:180)
> at 
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doAuthenticate(ModularRealmAuthenticator.java:267)
> at 
> org.apache.shiro.authc.AbstractAuthenticator.authenticate(AbstractAuthenticator.java:198)
> at 
> org.apache.shiro.mgt.AuthenticatingSecurityManager.authenticate(AuthenticatingSecurityManager.java:106)
> at 
> org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:270)
> at 
> org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
> at 
> org.apache.geode.internal.security.IntegratedSecurityService.login(IntegratedSecurityService.java:151)
> at 
> org.apache.geode.internal.security.shiro.JMXShiroAuthenticator.authenticate(JMXShiroAuthenticator.java:58)
> at 
> javax.management.remote.rmi.RMIServerImpl.doNewClient(RMIServerImpl.java:232)
> at 
> javax.management.remote.rmi.RMIServerImpl.newClient(RMIServerImpl.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:324)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at 
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> at java.security.AccessController.doPrivileged(Native Method)
> at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667773#comment-15667773
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/285
  
I reworded your commit message:

```
GEODE-1617: add test for region names

Added comprehensive test to validate region names

This closes #285
```


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667765#comment-15667765
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
+1 looks ready to push to develop. 

Once it's committed on develop, then mark the Jira ticket Resolved (not 
Closed) and Fix Version(s) should say 1.1.0-incubating. When 1.1.0 is released, 
all Resolved tickets are moved to Closed (all such tickets will be part of 
release notes automatically I think).


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667757#comment-15667757
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/285
  
+1


> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667746#comment-15667746
 ] 

ASF GitHub Bot commented on GEODE-1617:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/285

GEODE-1617: Regions can be created with a variety of characters that …

…are unsupported

Added comprehensive test to validate region names

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1617

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit 1672018170c979a4104dce83224a3d697becfe13
Author: Kevin Duling 
Date:   2016-11-15T17:33:59Z

GEODE-1617: Regions can be created with a variety of characters that are 
unsupported

Added comprehensive test to validate region names




> Regions can be created with a variety of characters that are unsupported
> 
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
>  and this 
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
>  on the dev forums and [geode 
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
>  region names may only consist of alphanumeric characters, an underscore, and 
> a hyphen.  These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while 
> others cannot be located.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666006#comment-15666006
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
Thanks @kirklund @metatype @upthewaterspout. Do I need to mark the JIRA for 
release notes ? If not I will merge this PR, please let me know.


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666001#comment-15666001
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user davinash commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
@kirklund 
What OS does DiskSpaceLimitIntegrationTest fail on for you?
[ Avinash ] Linux


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664935#comment-15664935
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user metatype commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
Agreed.  This could be handled in a release note:  “If you want to preserve 
your gfsh history, please copy…”

Anthony

> On Nov 14, 2016, at 10:57 AM, Dan Smith  wrote:
> 
> IMO losing your gfsh history on an upgrade is probably not a big deal.
> 
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub 
, or 
mute the thread 
.
> 




> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664691#comment-15664691
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
IMO losing your gfsh history on an upgrade is probably not a big deal.


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664673#comment-15664673
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
I recommend discussing backwards compatibility of .gemfire vs .geode 
directory (which contains gfsh history file) on the dev list. I don't really 
feel strongly one way or the other (supporting .gemfire vs just a hard switch 
to .geode). Dev list is good place to discuss backwards compatibility though.


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664666#comment-15664666
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/283
  
Since Geode 1.0 released using .gemfire history file, we should probably 
read and use .gemfire if .geode does not exist. If both files exist then .geode 
should take precedence.

What OS does DiskSpaceLimitIntegrationTest fail on for you?


> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664393#comment-15664393
 ] 

ASF GitHub Bot commented on GEODE-2098:
---

GitHub user davinash opened a pull request:

https://github.com/apache/incubator-geode/pull/283

GEODE-2098: Moved gfsh history file location from .gemfire to .geode

Made the code changes and added a test for the same.

Following Test is failing with precheckin, but works fine when ran 
individually.
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/incubator-geode feature/GEODE-2098

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit 6e1377a0f3f32aef279e9cbea3741c90aad95f30
Author: adongre 
Date:   2016-11-13T14:11:44Z

GEODE-2098: Moved gfsh history file location from .gemfire to .geode

Made the code changes and added a test for the same.




> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory.  We should change 
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
>   if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
>   }
> }
> return homeDirPath;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1896) unable to specify a PartitionResolver in gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659994#comment-15659994
 ] 

ASF GitHub Bot commented on GEODE-1896:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/278


> unable to specify a PartitionResolver in gfsh
> -
>
> Key: GEODE-1896
> URL: https://issues.apache.org/jira/browse/GEODE-1896
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> While creating a region in gfsh, users should be able to provide a 
> PartitionResolver, something like:
> {noformat}
> gfsh>create region --name=myRegion --type=PARTITION 
> --partition-resolver=com.mycompany.MyCustomPartitionResolver
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1740) Potential region inconsistency with concurrent region operation during transaction commit processing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658628#comment-15658628
 ] 

ASF GitHub Bot commented on GEODE-1740:
---

Github user gemzdude commented on the issue:

https://github.com/apache/incubator-geode/pull/282
  
Spotless check has been applied


> Potential region inconsistency with concurrent region operation during 
> transaction commit processing
> 
>
> Key: GEODE-1740
> URL: https://issues.apache.org/jira/browse/GEODE-1740
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Scott Jewell
>
> There is a possible region inconsistency if region operations such as CLEAR 
> are performed during transaction commit processing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1740) Potential region inconsistency with concurrent region operation during transaction commit processing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658605#comment-15658605
 ] 

ASF GitHub Bot commented on GEODE-1740:
---

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/282

GEODE-1740: Inconsistencies with concurrent clear and commit

There is a possible region inconsistency if region operations such as CLEAR 
are performed during transaction commit processing.

Commit processing has been modified to acquire and hold a read on each 
region
involved in a transaction for the duration of commit processing.  This 
prevents
clear from being able to acquire a write lock until commit processing is 
complete.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-1740

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #282


commit deab93b8e72f6bb1248a19bdb4a993d0ef980718
Author: Scott Jewell 
Date:   2016-11-02T22:59:35Z

GEODE-1740: Correct potential region inconsistencies with concurrent clear 
and transaction commit




> Potential region inconsistency with concurrent region operation during 
> transaction commit processing
> 
>
> Key: GEODE-1740
> URL: https://issues.apache.org/jira/browse/GEODE-1740
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Scott Jewell
>
> There is a possible region inconsistency if region operations such as CLEAR 
> are performed during transaction commit processing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655461#comment-15655461
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/276


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2084) When executing a rest api in a browser, the login page presented in the browser is not setting the username/password correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655413#comment-15655413
 ] 

ASF GitHub Bot commented on GEODE-2084:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/281


> When executing a rest api in a browser, the login page presented in the 
> browser is not setting the username/password correctly
> --
>
> Key: GEODE-2084
> URL: https://issues.apache.org/jira/browse/GEODE-2084
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Steps to reproduce:
> 1. start up a server with security
> 2. in a browser address bar, type in: http:// address>:7070/geode/v1/servers, after putting in username/password, I should 
> see the result json, but instead, I keep getting the login page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655344#comment-15655344
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/276
  
Precheckin successful


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2084) When executing a rest api in a browser, the login page presented in the browser is not setting the username/password correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654819#comment-15654819
 ] 

ASF GitHub Bot commented on GEODE-2084:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/281
  
Precheckin is running


> When executing a rest api in a browser, the login page presented in the 
> browser is not setting the username/password correctly
> --
>
> Key: GEODE-2084
> URL: https://issues.apache.org/jira/browse/GEODE-2084
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Steps to reproduce:
> 1. start up a server with security
> 2. in a browser address bar, type in: http:// address>:7070/geode/v1/servers, after putting in username/password, I should 
> see the result json, but instead, I keep getting the login page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2084) When executing a rest api in a browser, the login page presented in the browser is not setting the username/password correctly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654816#comment-15654816
 ] 

ASF GitHub Bot commented on GEODE-2084:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/281

GEODE-2084 - When executing a rest api in a browser, the login page p…

…resented in the browser is not setting the username/password correctly

Changed RestSecurityConfiguration to not call login(), which will bring up 
the browsers Authentication dialog instead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2084

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit d51ebc32a2da6afd7d7c483872a06e9ddafe5960
Author: Kevin Duling 
Date:   2016-11-10T18:44:37Z

GEODE-2084 - When executing a rest api in a browser, the login page 
presented in the browser is not setting the username/password correctly

Changed RestSecurityConfiguration to not call login(), which will bring up 
the browsers Authentication dialog instead.




> When executing a rest api in a browser, the login page presented in the 
> browser is not setting the username/password correctly
> --
>
> Key: GEODE-2084
> URL: https://issues.apache.org/jira/browse/GEODE-2084
> Project: Geode
>  Issue Type: Bug
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Steps to reproduce:
> 1. start up a server with security
> 2. in a browser address bar, type in: http:// address>:7070/geode/v1/servers, after putting in username/password, I should 
> see the result json, but instead, I keep getting the login page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1740) Potential region inconsistency with concurrent region operation during transaction commit processing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648432#comment-15648432
 ] 

ASF GitHub Bot commented on GEODE-1740:
---

Github user gemzdude closed the pull request at:

https://github.com/apache/incubator-geode/pull/280


> Potential region inconsistency with concurrent region operation during 
> transaction commit processing
> 
>
> Key: GEODE-1740
> URL: https://issues.apache.org/jira/browse/GEODE-1740
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Scott Jewell
>
> There is a possible region inconsistency if region operations such as CLEAR 
> are performed during transaction commit processing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1740) Potential region inconsistency with concurrent region operation during transaction commit processing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648435#comment-15648435
 ] 

ASF GitHub Bot commented on GEODE-1740:
---

Github user gemzdude commented on the issue:

https://github.com/apache/incubator-geode/pull/280
  
Closed as incomplete


> Potential region inconsistency with concurrent region operation during 
> transaction commit processing
> 
>
> Key: GEODE-1740
> URL: https://issues.apache.org/jira/browse/GEODE-1740
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Scott Jewell
>
> There is a possible region inconsistency if region operations such as CLEAR 
> are performed during transaction commit processing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648189#comment-15648189
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/276
  
1. I am using Autowire, the annotation is on the base class's constructor.  
But as for the injection via the constructor, please review 
https://spring.io/blog/2015/11/29/how-not-to-hate-spring-in-2016 which 
references http://olivergierke.de/2013/11/why-field-injection-is-evil/ and 
http://docs.spring.io/spring-framework/docs/current/spring-framework-reference/htmlsingle/#beans-constructor-injection

Do you think it would be better to only add the RestSecurityService to the 
controllers that actually need it instead of adding it to the base class?  I 
think that would complicate the constructors.

2 & 3. Agreed, that'll make the test cleaner.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646421#comment-15646421
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86920722
  
--- Diff: 
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 ---
@@ -50,6 +52,11 @@
 
   protected static final String REST_API_VERSION = "/v1";
 
+  public BaseControllerAdvice(final RestSecurityService securityService,
--- End diff --

use Autowire inside AbstractBaseController to auto wire the 
RestSecurityService instead of using constructors. 


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646418#comment-15646418
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86920671
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645947#comment-15645947
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86900866
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/security/PostProcessor.java ---
@@ -44,6 +47,9 @@ default void init(Properties securityProps) {}
*/
   Object processRegionValue(Object principal, String regionName, Object 
key, Object value);
 
+  Collection processQueryResult(Object principal, Query query, 
Collection regions,
--- End diff --

removed


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645946#comment-15645946
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86900849
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 ---
@@ -87,6 +89,12 @@
   Object postProcess(Object principal, String regionPath, Object key, 
Object value,
   boolean valueIsSerialized);
 
+  Collection postProcess(Query query, Collection 
regionNames,
--- End diff --

done


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645945#comment-15645945
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86900842
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 ---
@@ -87,6 +89,12 @@
   Object postProcess(Object principal, String regionPath, Object key, 
Object value,
   boolean valueIsSerialized);
 
+  Collection postProcess(Query query, Collection 
regionNames,
+  Collection results);
+
+  Collection postProcess(Object principal, Query query, 
Collection regionNames,
--- End diff --

done


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645944#comment-15645944
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86900814
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
 ---
@@ -409,6 +435,34 @@ public Object postProcess(Object principal, String 
regionPath, Object key, Objec
 return newValue;
   }
 
+  private Object getPrincipal(Object principal) {
+if (principal == null) {
+  Subject subject = getSubject();
+  if (subject == null)
+return null;
+  principal = subject.getPrincipal();
+}
+return principal;
+  }
+
+  @Override
+  public Collection postProcess(Query query, Collection 
regionNames,
+  Collection results) {
+return postProcess(null, query, regionNames, results);
+  }
+
+  @Override
+  public Collection postProcess(Object principal, Query query,
--- End diff --

done


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645942#comment-15645942
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/276
  
precheckin successful


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1740) Potential region inconsistency with concurrent region operation during transaction commit processing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645747#comment-15645747
 ] 

ASF GitHub Bot commented on GEODE-1740:
---

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/280

GEODE-1740: Potential region inconsistency with concurrent clear during 
commit processing

It was observed that region operations performed within a transaction were 
not
 * acquiring region modification locks during commit processing. This lock 
is used to ensure region
 * consistency during CLEAR processing.
 * 
 * The fix for GEODE-1740 was to acquire cache modification locks for 
regions involved during commit
 * processing. A read lock is taken for each region involved thus allowing 
concurrent region
 * operations while preventing CLEAR from being able to acquire the write 
lock and thus waiting
 * until transaction processing is complete.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-1740

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #280


commit 0cdcf254ae1238a52d3c07f25c9fa0da27e55e1e
Author: Scott Jewell 
Date:   2016-11-02T22:59:35Z

GEODE-1740: Correct potential region inconsistencies with concurrent clear 
and transaction commit

commit d93a3b4ebbb98786abb049f58417e9e7f66fc01e
Author: Scott Jewell 
Date:   2016-11-07T22:04:54Z

Merge branch 'develop' of github.com:apache/incubator-geode into 
feature/GEODE-1740

commit 1bf75fd0fed913d0e1d1b0424bdbc3ec26dde53e
Author: Scott Jewell 
Date:   2016-11-07T22:49:44Z

GEODE-1740: Potential region inconsistency with concurrent region operation 
during transaction commit processing




> Potential region inconsistency with concurrent region operation during 
> transaction commit processing
> 
>
> Key: GEODE-1740
> URL: https://issues.apache.org/jira/browse/GEODE-1740
> Project: Geode
>  Issue Type: Bug
>  Components: regions, transactions
>Reporter: Scott Jewell
>
> There is a possible region inconsistency if region operations such as CLEAR 
> are performed during transaction commit processing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645207#comment-15645207
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86852092
  
--- Diff: 
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 ---
@@ -50,6 +52,11 @@
 
   protected static final String REST_API_VERSION = "/v1";
 
+  public BaseControllerAdvice(final RestSecurityService securityService,
--- End diff --

BaseControllerAdvice extends AbstractBaseController.  Since the 
RestSecurityService lives in AbstractBaseController, yes.  Otherwise, we define 
separate member variables in PdxBasedCrudController, CommonCrudController, and 
QueryAccessContoller.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645205#comment-15645205
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86852018
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645176#comment-15645176
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86848834
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645151#comment-15645151
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86847492
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644975#comment-15644975
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86836374
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
 ---
@@ -409,6 +435,34 @@ public Object postProcess(Object principal, String 
regionPath, Object key, Objec
 return newValue;
   }
 
+  private Object getPrincipal(Object principal) {
+if (principal == null) {
+  Subject subject = getSubject();
+  if (subject == null)
+return null;
+  principal = subject.getPrincipal();
+}
+return principal;
+  }
+
+  @Override
+  public Collection postProcess(Query query, Collection 
regionNames,
--- End diff --

remove this.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644965#comment-15644965
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86836336
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
 ---
@@ -409,6 +435,34 @@ public Object postProcess(Object principal, String 
regionPath, Object key, Objec
 return newValue;
   }
 
+  private Object getPrincipal(Object principal) {
+if (principal == null) {
+  Subject subject = getSubject();
+  if (subject == null)
+return null;
+  principal = subject.getPrincipal();
+}
+return principal;
+  }
+
+  @Override
+  public Collection postProcess(Query query, Collection 
regionNames,
+  Collection results) {
+return postProcess(null, query, regionNames, results);
+  }
+
+  @Override
+  public Collection postProcess(Object principal, Query query,
--- End diff --

remove this.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644972#comment-15644972
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86822046
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644970#comment-15644970
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86822375
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644964#comment-15644964
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86836287
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 ---
@@ -87,6 +89,12 @@
   Object postProcess(Object principal, String regionPath, Object key, 
Object value,
   boolean valueIsSerialized);
 
+  Collection postProcess(Query query, Collection 
regionNames,
+  Collection results);
+
+  Collection postProcess(Object principal, Query query, 
Collection regionNames,
--- End diff --

remove this


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644969#comment-15644969
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86819415
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644967#comment-15644967
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86836714
  
--- Diff: 
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 ---
@@ -50,6 +52,11 @@
 
   protected static final String REST_API_VERSION = "/v1";
 
+  public BaseControllerAdvice(final RestSecurityService securityService,
--- End diff --

do we need this?


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644974#comment-15644974
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86836201
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/security/PostProcessor.java ---
@@ -44,6 +47,9 @@ default void init(Properties securityProps) {}
*/
   Object processRegionValue(Object principal, String regionName, Object 
key, Object value);
 
+  Collection processQueryResult(Object principal, Query query, 
Collection regions,
--- End diff --

I don't think we want to add this method in the interface. For query,  
essentially it's still getting value from region. Customers should not be 
burdened with another method to implement if they just want to manipulate the 
data. See how query result get post processed in gfsh queries. 


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644973#comment-15644973
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86820194
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
+Region region =
+
serverStarter.cache.createRegionFactory(RegionShortcut.REPLICATE).create(REGION_NAME);
+region.put("key1",
+
"{\"@type\":\"com.gemstone.gemfire.web.rest.domain.Order\",\"purchaseOrderNo\":1121,\"customerId\":1012,\"description\":\"Order
 for  XYZ 
Corp\",\"orderDate\":\"02/10/2014\",\"deliveryDate\":\"02/20/2014\",\"contact\":\"Jelly
 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644971#comment-15644971
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86836263
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 ---
@@ -87,6 +89,12 @@
   Object postProcess(Object principal, String regionPath, Object key, 
Object value,
   boolean valueIsSerialized);
 
+  Collection postProcess(Query query, Collection 
regionNames,
--- End diff --

remove this.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644968#comment-15644968
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/276#discussion_r86821510
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
 ---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_BIND_ADDRESS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_MANAGER;
+import static 
org.apache.geode.distributed.ConfigurationProperties.SECURITY_POST_PROCESSOR;
+import static 
org.apache.geode.distributed.ConfigurationProperties.START_DEV_REST_API;
+import static org.apache.geode.rest.internal.web.GeodeRestClient.getCode;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getContentType;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonArray;
+import static 
org.apache.geode.rest.internal.web.GeodeRestClient.getJsonObject;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.rest.internal.web.controllers.GetRegions;
+import org.apache.geode.security.templates.SamplePostProcessor;
+import org.apache.geode.security.templates.SampleSecurityManager;
+import org.apache.geode.test.dunit.rules.ServerStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.categories.SecurityTest;
+import org.apache.http.HttpResponse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.springframework.http.MediaType;
+
+import java.net.URLEncoder;
+import java.util.Properties;
+
+
+@Category({IntegrationTest.class, SecurityTest.class})
+public class RestSecurityPostProcessorTest {
+
+  static final String REGION_NAME = "AuthRegion";
+
+  static int restPort = AvailablePortHelper.getRandomAvailableTCPPort();
+  static Properties properties = new Properties() {
+{
+  setProperty(SampleSecurityManager.SECURITY_JSON,
+  
"org/apache/geode/management/internal/security/clientServer.json");
+  setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
+  setProperty(START_DEV_REST_API, "true");
+  setProperty(HTTP_SERVICE_BIND_ADDRESS, "localhost");
+  setProperty(HTTP_SERVICE_PORT, restPort + "");
+  setProperty(SECURITY_POST_PROCESSOR, 
SamplePostProcessor.class.getName());
+}
+  };
+
+  @ClassRule
+  public static ServerStarterRule serverStarter = new 
ServerStarterRule(properties);
+  private final GeodeRestClient restClient = new 
GeodeRestClient("localhost", restPort);
+
+  @BeforeClass
+  public static void before() throws Exception {
+serverStarter.startServer();
--- End diff --

I think I just made a change in the rule that you don't need to call 
startServer anymore if you are using is as a rule.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
>

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644682#comment-15644682
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/276
  
Precheckin successful except for one flaky test, 
QueueCommandsDUnitTest.testCreateUpdatesSharedConfig which doesn't appear to be 
related to this change.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637605#comment-15637605
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/276
  
precheckin running


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633512#comment-15633512
 ] 

ASF GitHub Bot commented on GEODE-1821:
---

GitHub user pdxrunner opened a pull request:

https://github.com/apache/incubator-geode/pull/279

GEODE-1821: Adjust timing to wait for async thread

Increased timeout for waiting on aysnc thread termination. The wait timeout 
in DUnit test did not allow sufficient margin over the time required for the 
async thread to complete its task.

See Review Board https://reviews.apache.org/r/53431/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1821-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #279


commit c269825a1098fd4608a8a868da28552bae7accf1
Author: Ken Howe 
Date:   2016-11-02T18:14:13Z

GEODE-1821: Adjust timing to wait for async thread




> CI Failure: 
> PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
> ---
>
> Key: GEODE-1821
> URL: https://issues.apache.org/jira/browse/GEODE-1821
> Project: Geode
>  Issue Type: Bug
>  Components: persistence, regions
>Reporter: Anilkumar Gingade
>Assignee: Kenneth Howe
> Fix For: 1.0.0-incubating
>
>
> Build #3755 (Aug 24, 2016 5:09:20 AM)
> Revision: 37269735eec44f51ee53075718afe2fa85edc22e
> refs/remotes/origin/develop
> Error Message
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
> Stacktrace
> java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds 
> for AsyncInvocation to complete.
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443)
>   at 
> com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390)
>   at 
> com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at 

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630909#comment-15630909
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/276
  
Don't accept this PR yet.  This is just a checkin to preserve work.

Addressed all of the issues listed above.  Added test for adhoc queries.  
Still need a test for named queries.  Also need to verify functions won't 
return any region data without being post-processed.

Have not run precheckin yet, either.


> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1098) gfsh.bat error with default Java installation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623828#comment-15623828
 ] 

ASF GitHub Bot commented on GEODE-1098:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/277


> gfsh.bat error with default Java installation
> -
>
> Key: GEODE-1098
> URL: https://issues.apache.org/jira/browse/GEODE-1098
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
>Reporter: Karen Smoler Miller
> Fix For: 1.1.0-incubating
>
>
> The Windows gfsh.bat script issues an error when invoked from the command 
> line, and the JAVA_HOME variable has a path name component that contains a 
> space. JAVA_HOME is used when no GF_JAVA variable is defined.
> The default Java installation on Windows places itself into {{C:\Program 
> Files\Java\...}}, therefore there will be a space in the {{Program Files}} 
> portion of the path name.
> The error message looks similar to: 
> {{'"C:Program' is not recognized as an internal or external command, operable 
> program, or batch file.}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1896) unable to specify a PartitionResolver in gfsh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618196#comment-15618196
 ] 

ASF GitHub Bot commented on GEODE-1896:
---

GitHub user davinash opened a pull request:

https://github.com/apache/incubator-geode/pull/278

Feature/geode 1896 unable to specify a PartitionResolver in gfsh

GEODE-1896: Added a argument in Create Region to specify Partition Resolver.
 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/incubator-geode feature/GEODE-1896

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit 0541cff3445a1f57fb48e642faa955829f6f7872
Author: adongre 
Date:   2016-10-28T10:34:15Z

Adding option partition-resolver in gfsh while creating a region.

commit 00f7f5faf92dd44aa174648557d2ce4ac64ce17b
Author: adongre 
Date:   2016-10-29T03:05:39Z

Fixing test org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest 
testSerializables




> unable to specify a PartitionResolver in gfsh
> -
>
> Key: GEODE-1896
> URL: https://issues.apache.org/jira/browse/GEODE-1896
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Avinash
>
> While creating a region in gfsh, users should be able to provide a 
> PartitionResolver, something like:
> {noformat}
> gfsh>create region --name=myRegion --type=PARTITION 
> --partition-resolver=com.mycompany.MyCustomPartitionResolver
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1098) gfsh.bat error with default Java installation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617249#comment-15617249
 ] 

ASF GitHub Bot commented on GEODE-1098:
---

Github user metatype commented on the issue:

https://github.com/apache/incubator-geode/pull/277
  
@upthewaterspout I think you closed PR "227" instead of "277".


> gfsh.bat error with default Java installation
> -
>
> Key: GEODE-1098
> URL: https://issues.apache.org/jira/browse/GEODE-1098
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
>Reporter: Karen Smoler Miller
> Fix For: 1.1.0-incubating
>
>
> The Windows gfsh.bat script issues an error when invoked from the command 
> line, and the JAVA_HOME variable has a path name component that contains a 
> space. JAVA_HOME is used when no GF_JAVA variable is defined.
> The default Java installation on Windows places itself into {{C:\Program 
> Files\Java\...}}, therefore there will be a space in the {{Program Files}} 
> portion of the path name.
> The error message looks similar to: 
> {{'"C:Program' is not recognized as an internal or external command, operable 
> program, or batch file.}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1871) Update Dockerfile for Geode 1.0.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617219#comment-15617219
 ] 

ASF GitHub Bot commented on GEODE-1871:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/275#discussion_r85631878
  
--- Diff: docker/Dockerfile ---
@@ -14,25 +14,34 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM geode/base:0.1
-MAINTAINER Geode Community 
+FROM centos:7
+MAINTAINER Apache Geode Community 
 
 LABEL Vendor="Apache Geode (incubating)"
-LABEL version=unstable
+LABEL version=1.0.0
 
 # download JDK 8
-# ENV  JAVA_HOME /jdk1.8.0_51
+ENVJAVA_HOME /jdk1.8.0_111
 
-RUNgit clone -b develop 
https://github.com/apache/incubator-geode.git \
+RUNyum install -y wget which tar git \
+   && wget --no-cookies --no-check-certificate --header "Cookie: 
gpw_e24=http%3A%2F%2Fwww.oracle.com%2F; 
oraclelicense=accept-securebackup-cookie" 
"http://download.oracle.com/otn-pub/java/jdk/8u111-b14/jdk-8u111-linux-x64.tar.gz;
 \
--- End diff --

What about just doing `yum install java-1.8.0-openjdk` and avoid any legal 
issues with redistributing the oracle jdk?


> Update Dockerfile for Geode 1.0.0
> -
>
> Key: GEODE-1871
> URL: https://issues.apache.org/jira/browse/GEODE-1871
> Project: Geode
>  Issue Type: Improvement
>  Components: general
>Reporter: William Markito Oliveira
>
> Need to update Dockerfile under incubator-geode/docker for 1.0.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1098) gfsh.bat error with default Java installation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617199#comment-15617199
 ] 

ASF GitHub Bot commented on GEODE-1098:
---

Github user metatype commented on the issue:

https://github.com/apache/incubator-geode/pull/277
  
Thanks for your contribution!


> gfsh.bat error with default Java installation
> -
>
> Key: GEODE-1098
> URL: https://issues.apache.org/jira/browse/GEODE-1098
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
>Reporter: Karen Smoler Miller
> Fix For: 1.1.0-incubating
>
>
> The Windows gfsh.bat script issues an error when invoked from the command 
> line, and the JAVA_HOME variable has a path name component that contains a 
> space. JAVA_HOME is used when no GF_JAVA variable is defined.
> The default Java installation on Windows places itself into {{C:\Program 
> Files\Java\...}}, therefore there will be a space in the {{Program Files}} 
> portion of the path name.
> The error message looks similar to: 
> {{'"C:Program' is not recognized as an internal or external command, operable 
> program, or batch file.}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1098) gfsh.bat error with default Java installation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617018#comment-15617018
 ] 

ASF GitHub Bot commented on GEODE-1098:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/incubator-geode/pull/277
  
+1 Looks good to me. I'll merge this. Thanks!

The travis failure appears to be code checked in on develop with formatting 
changes. I'm looking into that, but it's not related to this change.


> gfsh.bat error with default Java installation
> -
>
> Key: GEODE-1098
> URL: https://issues.apache.org/jira/browse/GEODE-1098
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
>Reporter: Karen Smoler Miller
> Fix For: 1.1.0-incubating
>
>
> The Windows gfsh.bat script issues an error when invoked from the command 
> line, and the JAVA_HOME variable has a path name component that contains a 
> space. JAVA_HOME is used when no GF_JAVA variable is defined.
> The default Java installation on Windows places itself into {{C:\Program 
> Files\Java\...}}, therefore there will be a space in the {{Program Files}} 
> portion of the path name.
> The error message looks similar to: 
> {{'"C:Program' is not recognized as an internal or external command, operable 
> program, or batch file.}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1098) gfsh.bat error with default Java installation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616658#comment-15616658
 ] 

ASF GitHub Bot commented on GEODE-1098:
---

GitHub user mmurdoch opened a pull request:

https://github.com/apache/incubator-geode/pull/277

GEODE-1098: Fix gfsh.bat error with default Java installation

Paths to JAR dependencies quoted to prevent spaces from causing error

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmurdoch/incubator-geode feature/GEODE-1098

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #277






> gfsh.bat error with default Java installation
> -
>
> Key: GEODE-1098
> URL: https://issues.apache.org/jira/browse/GEODE-1098
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
>Reporter: Karen Smoler Miller
> Fix For: 1.1.0-incubating
>
>
> The Windows gfsh.bat script issues an error when invoked from the command 
> line, and the JAVA_HOME variable has a path name component that contains a 
> space. JAVA_HOME is used when no GF_JAVA variable is defined.
> The default Java installation on Windows places itself into {{C:\Program 
> Files\Java\...}}, therefore there will be a space in the {{Program Files}} 
> portion of the path name.
> The error message looks similar to: 
> {{'"C:Program' is not recognized as an internal or external command, operable 
> program, or batch file.}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616471#comment-15616471
 ] 

ASF GitHub Bot commented on GEODE-1993:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/276

GEODE-1993: postprocess region/key

Add post processing to the GET {region}/{key..key} endpoint
precheckin running

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1993

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #276


commit 41559682c95f844018fa285f35a1adf2f7fcf0ba
Author: Kevin Duling 
Date:   2016-10-28T20:27:56Z

GEODE-1993: postprocess region/key




> value returned through /region/key rest service needs to be post processed
> --
>
> Key: GEODE-1993
> URL: https://issues.apache.org/jira/browse/GEODE-1993
> Project: Geode
>  Issue Type: New Feature
>  Components: management
>Reporter: Jinmei Liao
>
> The new rest security did not use post processor before returning the value 
> back to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1871) Update Dockerfile for Geode 1.0.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614468#comment-15614468
 ] 

ASF GitHub Bot commented on GEODE-1871:
---

GitHub user markito opened a pull request:

https://github.com/apache/incubator-geode/pull/275

[GEODE-1871] - Updating and cleaning up Dockerfile for Geode 1.0.0

Removed unused files. Updated JDK version and Docker tag for 1.0.0. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markito/incubator-geode feature/GEODE-1871

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #275


commit b566a46e8349612386c91c5d135636ac334218ad
Author: William Markito 
Date:   2016-10-28T06:11:39Z

Updating and cleaning up Dockerfile for 1.0.0




> Update Dockerfile for Geode 1.0.0
> -
>
> Key: GEODE-1871
> URL: https://issues.apache.org/jira/browse/GEODE-1871
> Project: Geode
>  Issue Type: Improvement
>  Components: general
>Reporter: William Markito Oliveira
>
> Need to update Dockerfile under incubator-geode/docker for 1.0.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1983) Swagger is broken with integrated security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612270#comment-15612270
 ] 

ASF GitHub Bot commented on GEODE-1983:
---

Github user kjduling closed the pull request at:

https://github.com/apache/incubator-geode/pull/272


> Swagger is broken with integrated security
> --
>
> Key: GEODE-1983
> URL: https://issues.apache.org/jira/browse/GEODE-1983
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Diane Hardman
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Swagger UI does not work with latest integrated security. After configuring 
> security manager and attempting up to open up Swagger UI we get a prompt for 
> username and password. Entering credentials does not bring up the UI, instead 
> asking for credentials again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1983) Swagger is broken with integrated security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612257#comment-15612257
 ] 

ASF GitHub Bot commented on GEODE-1983:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/272

GEODE-1983: Swagger is broken with integrated security

Updated the spring security configuration to support the Swagger2 resources.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1983

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #272


commit abf3ff1d41bb2bdb43dec0caa1cf4829d13921d3
Author: Kevin Duling 
Date:   2016-10-18T17:33:37Z

GEODE-1983: Swagger is broken with integrated security

This required a simple configuration change.




> Swagger is broken with integrated security
> --
>
> Key: GEODE-1983
> URL: https://issues.apache.org/jira/browse/GEODE-1983
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Diane Hardman
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Swagger UI does not work with latest integrated security. After configuring 
> security manager and attempting up to open up Swagger UI we get a prompt for 
> username and password. Entering credentials does not bring up the UI, instead 
> asking for credentials again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1983) Swagger is broken with integrated security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612260#comment-15612260
 ] 

ASF GitHub Bot commented on GEODE-1983:
---

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/272
  
precheckin successful


> Swagger is broken with integrated security
> --
>
> Key: GEODE-1983
> URL: https://issues.apache.org/jira/browse/GEODE-1983
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Diane Hardman
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Swagger UI does not work with latest integrated security. After configuring 
> security manager and attempting up to open up Swagger UI we get a prompt for 
> username and password. Entering credentials does not bring up the UI, instead 
> asking for credentials again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605557#comment-15605557
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/270


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603581#comment-15603581
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/270

GEODE-2014: Upgrade Swagger libraries

Updated expected jars list after swagger update

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2014

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #270


commit 07d8ed53d6a69123011e05db5a5bf3c47dc2a35a
Author: Kevin Duling 
Date:   2016-10-24T23:23:26Z

GEODE-2014: Upgrade Swagger libraries

Updated expected jars list after swagger update




> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2015) Host Geode docs on Geode website

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603164#comment-15603164
 ] 

ASF GitHub Bot commented on GEODE-2015:
---

Github user joeymcallister closed the pull request at:

https://github.com/apache/incubator-geode/pull/269


> Host Geode docs on Geode website
> 
>
> Key: GEODE-2015
> URL: https://issues.apache.org/jira/browse/GEODE-2015
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
> Fix For: 1.1.0-incubating
>
>
> Now that the Geode docs have been donated to the project, let's host them on 
> the Geode website.
> Also document process for posting new docs builds to the website.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2015) Host Geode docs on Geode website

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603163#comment-15603163
 ] 

ASF GitHub Bot commented on GEODE-2015:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/incubator-geode/pull/269
  
This PR is complete. Closing.


> Host Geode docs on Geode website
> 
>
> Key: GEODE-2015
> URL: https://issues.apache.org/jira/browse/GEODE-2015
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
> Fix For: 1.1.0-incubating
>
>
> Now that the Geode docs have been donated to the project, let's host them on 
> the Geode website.
> Also document process for posting new docs builds to the website.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602896#comment-15602896
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/265


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596047#comment-15596047
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84528366
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
 ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+
+import static org.hamcrest.CoreMatchers.*;
+import static org.junit.Assert.*;
+
+import org.apache.http.HttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.json.JSONObject;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.internal.i18n.LocalizedStrings;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+
+@Category(IntegrationTest.class)
+
+public class SwaggerVerificationTest extends AbstractRestTest {
+
+  @Test
+  public void isSwaggerRunning() throws Exception {
+// Check the UI
+HttpResponse response = doRequest(new 
HttpGet("/geode/swagger-ui.html"), "", "");
+assertThat(getCode(response), is(200));
+
+// Check the JSON
+response = doRequest(new HttpGet("/geode/v2/api-docs"), "", "");
--- End diff --

"geode/v2/api-docs" is the endpoint for Swagger2 documentation.  Swagger 
was "geode/api-docs".  Geode's endpoints are all "geode/v1/*" and I've verified 
that if/when the REST API revision is bumped to "v2", there will be no conflict 
unless we create a new endpoint called "v2/api-docs".

This is supposed to be able to be overridden with the 
"springfox.documentation.swagger.v2.path" env property, but it doesn't seem to 
be honored.  Or SwaggerConfig is being loaded too late in the lifecycle, which 
I doubt.  At any rate, I am adding the structure to use this, but leaving the 
values set to the default ones.


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595414#comment-15595414
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84500905
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
 ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.rest.internal.web;
+
+
+import static org.hamcrest.CoreMatchers.*;
+import static org.junit.Assert.*;
+
+import org.apache.http.HttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.json.JSONObject;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.internal.i18n.LocalizedStrings;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+
+@Category(IntegrationTest.class)
+
+public class SwaggerVerificationTest extends AbstractRestTest {
+
+  @Test
+  public void isSwaggerRunning() throws Exception {
+// Check the UI
+HttpResponse response = doRequest(new 
HttpGet("/geode/swagger-ui.html"), "", "");
+assertThat(getCode(response), is(200));
+
+// Check the JSON
+response = doRequest(new HttpGet("/geode/v2/api-docs"), "", "");
--- End diff --

Just curious, why this is geode/v2, but all the api is still geode/v1


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595413#comment-15595413
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84501406
  
--- Diff: 
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
 ---
@@ -93,8 +93,7 @@ protected String getRestApiVersion() {
   response = void.class
   )
   @ApiResponses({
-  @ApiResponse(code = 200, message = "OK."),
-  @ApiResponse( code = 401, message = "Invalid Username or Password." 
),
+  @ApiResponse(code = 200, message = "OK."), @ApiResponse(code = 401, 
message = "Invalid Username or Password."),
--- End diff --

use the old fomat?


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2015) Host Geode docs on Geode website

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593374#comment-15593374
 ] 

ASF GitHub Bot commented on GEODE-2015:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/266


> Host Geode docs on Geode website
> 
>
> Key: GEODE-2015
> URL: https://issues.apache.org/jira/browse/GEODE-2015
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
> Fix For: 1.1.0-incubating
>
>
> Now that the Geode docs have been donated to the project, let's host them on 
> the Geode website.
> Also document process for posting new docs builds to the website.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2015) Host Geode docs on Geode website

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592867#comment-15592867
 ] 

ASF GitHub Bot commented on GEODE-2015:
---

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/266

Add user guide doc to website

Added the user guide built using `geode-docs` and `geode-book` to 
`geode-site/content/`. Built and reviewed the site locally. Related 
docs/website changes are in feature/GEODE-2015.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode asf-site

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #266


commit f717e5138bfc2ee9bedf942c986ad498102e6f8d
Author: Joey McAllister 
Date:   2016-10-20T20:09:09Z

Add user guide doc to website




> Host Geode docs on Geode website
> 
>
> Key: GEODE-2015
> URL: https://issues.apache.org/jira/browse/GEODE-2015
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
> Fix For: 1.1.0-incubating
>
>
> Now that the Geode docs have been donated to the project, let's host them on 
> the Geode website.
> Also document process for posting new docs builds to the website.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-88) Build fails on Windows with Caused by: java.lang.ClassCastException: org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591857#comment-15591857
 ] 

ASF GitHub Bot commented on GEODE-88:
-

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/incubator-geode/pull/199
  
How do these changes at all relate to 
https://issues.apache.org/jira/browse/GEODE-88?


> Build fails on Windows with Caused by: java.lang.ClassCastException: 
> org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory
> --
>
> Key: GEODE-88
> URL: https://issues.apache.org/jira/browse/GEODE-88
> Project: Geode
>  Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.0.0-incubating.M1
>
>
> Caused by: java.lang.ExceptionInInitializerError
> at org.dom4j.DocumentFactory.createNamespace(DocumentFactory.java:185)
> at 
> org.dom4j.tree.NamespaceStack.createNamespace(NamespaceStack.java:407)
> at org.dom4j.tree.NamespaceStack.push(NamespaceStack.java:276)
> at 
> org.dom4j.io.SAXContentHandler.startPrefixMapping(SAXContentHandler.java:191)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startNamespaceMapping(AbstractSAXParser.java:2164)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:469)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:379)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:605)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3138)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:880)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
> at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
> at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
> at 
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
> at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:649)
> at org.dom4j.io.SAXReader.read(SAXReader.java:465)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.extractCredentialsFromSettings(SettingsXmlCredentialsProvider.java:85)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.(SettingsXmlCredentialsProvider.java:62)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.(SettingsXmlCredentialsProvider.java:54)
> at 
> org.hibernate.build.gradle.publish.auth.maven.CredentialsProviderRegistry.buildStandardAuthenticationProviders(CredentialsProviderRegistry.java:39)
> at 
> org.hibernate.build.gradle.publish.auth.maven.CredentialsProviderRegistry.(CredentialsProviderRegistry.java:34)
> at 
> org.hibernate.build.gradle.publish.auth.maven.AuthenticationManager.apply(AuthenticationManager.java:37)
> at 
> org.hibernate.build.gradle.publish.auth.maven.AuthenticationManager.apply(AuthenticationManager.java:34)
> at 
> org.gradle.api.internal.plugins.ImperativeOnlyPluginApplicator.applyImperative(ImperativeOnlyPluginApplicator.java:35)
> at 
> org.gradle.api.internal.plugins.RulesCapablePluginApplicator.applyImperative(RulesCapablePluginApplicator.java:42)
> at 
> org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:133)
> at 
> org.gradle.api.internal.plugins.DefaultPluginManager.apply(DefaultPluginManager.java:102)
> at 
> org.gradle.api.internal.plugins.DefaultObjectConfigurationAction.applyType(DefaultObjectConfigurationAction.java:113)
> at 
> org.gradle.api.internal.plugins.DefaultObjectConfigurationAction.access$200(DefaultObjectConfigurationAction.java:36)
> at 
> 

[jira] [Commented] (GEODE-88) Build fails on Windows with Caused by: java.lang.ClassCastException: org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591854#comment-15591854
 ] 

ASF GitHub Bot commented on GEODE-88:
-

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/incubator-geode/pull/199
  
All Copyright statements must be removed.

Please describe rational for changes to variable attributes (const, 
volatile, etc.)

Removal of ACE::init() only benefits your singular use case and requires 
all other users to leak ACE into their client code.



> Build fails on Windows with Caused by: java.lang.ClassCastException: 
> org.dom4j.DocumentFactory cannot be cast to org.dom4j.DocumentFactory
> --
>
> Key: GEODE-88
> URL: https://issues.apache.org/jira/browse/GEODE-88
> Project: Geode
>  Issue Type: Bug
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.0.0-incubating.M1
>
>
> Caused by: java.lang.ExceptionInInitializerError
> at org.dom4j.DocumentFactory.createNamespace(DocumentFactory.java:185)
> at 
> org.dom4j.tree.NamespaceStack.createNamespace(NamespaceStack.java:407)
> at org.dom4j.tree.NamespaceStack.push(NamespaceStack.java:276)
> at 
> org.dom4j.io.SAXContentHandler.startPrefixMapping(SAXContentHandler.java:191)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startNamespaceMapping(AbstractSAXParser.java:2164)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:469)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:379)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:605)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3138)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:880)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
> at 
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
> at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
> at 
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
> at 
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> at 
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
> at 
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:649)
> at org.dom4j.io.SAXReader.read(SAXReader.java:465)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.extractCredentialsFromSettings(SettingsXmlCredentialsProvider.java:85)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.(SettingsXmlCredentialsProvider.java:62)
> at 
> org.hibernate.build.gradle.publish.auth.maven.SettingsXmlCredentialsProvider.(SettingsXmlCredentialsProvider.java:54)
> at 
> org.hibernate.build.gradle.publish.auth.maven.CredentialsProviderRegistry.buildStandardAuthenticationProviders(CredentialsProviderRegistry.java:39)
> at 
> org.hibernate.build.gradle.publish.auth.maven.CredentialsProviderRegistry.(CredentialsProviderRegistry.java:34)
> at 
> org.hibernate.build.gradle.publish.auth.maven.AuthenticationManager.apply(AuthenticationManager.java:37)
> at 
> org.hibernate.build.gradle.publish.auth.maven.AuthenticationManager.apply(AuthenticationManager.java:34)
> at 
> org.gradle.api.internal.plugins.ImperativeOnlyPluginApplicator.applyImperative(ImperativeOnlyPluginApplicator.java:35)
> at 
> org.gradle.api.internal.plugins.RulesCapablePluginApplicator.applyImperative(RulesCapablePluginApplicator.java:42)
> at 
> org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:133)
> at 
> org.gradle.api.internal.plugins.DefaultPluginManager.apply(DefaultPluginManager.java:102)
> at 
> org.gradle.api.internal.plugins.DefaultObjectConfigurationAction.applyType(DefaultObjectConfigurationAction.java:113)
> at 
> 

[jira] [Commented] (GEODE-1983) Swagger is broken with integrated security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589655#comment-15589655
 ] 

ASF GitHub Bot commented on GEODE-1983:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/263


> Swagger is broken with integrated security
> --
>
> Key: GEODE-1983
> URL: https://issues.apache.org/jira/browse/GEODE-1983
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Diane Hardman
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Swagger UI does not work with latest integrated security. After configuring 
> security manager and attempting up to open up Swagger UI we get a prompt for 
> username and password. Entering credentials does not bring up the UI, instead 
> asking for credentials again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1983) Swagger is broken with integrated security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589641#comment-15589641
 ] 

ASF GitHub Bot commented on GEODE-1983:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/263
  
I'll pull this in now.


> Swagger is broken with integrated security
> --
>
> Key: GEODE-1983
> URL: https://issues.apache.org/jira/browse/GEODE-1983
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Diane Hardman
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Swagger UI does not work with latest integrated security. After configuring 
> security manager and attempting up to open up Swagger UI we get a prompt for 
> username and password. Entering credentials does not bring up the UI, instead 
> asking for credentials again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589274#comment-15589274
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84119234
  
--- Diff: gradle/dependency-versions.properties ---
@@ -100,8 +100,8 @@ spring-tx.version = 4.3.2.RELEASE
 springframework.version = 4.3.2.RELEASE
 stephenc-findbugs.version = 1.3.9-1
 spymemcached.version = 2.9.0
-swagger.version = 1.3.2
-swagger-springmvc.version = 0.8.2
+swagger.version=1.3.13
--- End diff --

However, 1.3.13 is an old Swagger release. I don't think we should upgrade 
to an old version. If we're going to upgrade then let's upgrade to the latest 
version (1.5.10?).


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589189#comment-15589189
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84112416
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
 ---
@@ -94,7 +94,7 @@ public static void before() throws Exception {
   @Test
   public void testFunctions() throws Exception {
 String json = "{\"@type\":\"double\",\"@value\":210}";
-
+Thread.sleep(50);
--- End diff --

This seems like a really long pause for an integration test.  Is there 
another way to do this?


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589185#comment-15589185
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/265#discussion_r84111969
  
--- Diff: gradle/dependency-versions.properties ---
@@ -100,8 +100,8 @@ spring-tx.version = 4.3.2.RELEASE
 springframework.version = 4.3.2.RELEASE
 stephenc-findbugs.version = 1.3.9-1
 spymemcached.version = 2.9.0
-swagger.version = 1.3.2
-swagger-springmvc.version = 0.8.2
+swagger.version=1.3.13
--- End diff --

Verified that the license is still ASL 2.0 so no changes to LICENSE.  Also 
does not include a NOTICE file so we do not need to propagate anything in our 
NOTICE.


> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589159#comment-15589159
 ] 

ASF GitHub Bot commented on GEODE-2014:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/265

GEODE-2014: Upgrade Swagger libraries



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2014

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit c2b15f22886431588e8a21a80e7ff13ea69a7ec2
Author: Kevin Duling 
Date:   2016-10-18T22:54:55Z

GEODE-2014: Upgrade Swagger libraries




> Upgrade Swagger libraries
> -
>
> Key: GEODE-2014
> URL: https://issues.apache.org/jira/browse/GEODE-2014
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (dev)
>Affects Versions: 1.0.0-incubating
>Reporter: Kevin Duling
>Assignee: Kevin Duling
>
> Upgrade swagger and swagger-springmvc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1983) Swagger is broken with integrated security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586106#comment-15586106
 ] 

ASF GitHub Bot commented on GEODE-1983:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/263

GEODE-1983: Swagger is broken with integrated security

This required a simple configuration change.  The swagger endpoints needed 
to be marked as permitAll so that the resources could be read.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1983

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #263


commit abf3ff1d41bb2bdb43dec0caa1cf4829d13921d3
Author: Kevin Duling 
Date:   2016-10-18T17:33:37Z

GEODE-1983: Swagger is broken with integrated security

This required a simple configuration change.




> Swagger is broken with integrated security
> --
>
> Key: GEODE-1983
> URL: https://issues.apache.org/jira/browse/GEODE-1983
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev), security
>Reporter: Diane Hardman
>Assignee: Kevin Duling
> Fix For: 1.1.0-incubating
>
>
> Swagger UI does not work with latest integrated security. After configuring 
> security manager and attempting up to open up Swagger UI we get a prompt for 
> username and password. Entering credentials does not bring up the UI, instead 
> asking for credentials again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2004) Create/update/delete query through rest api should require DATA:READ instead of DATA:WRITE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583109#comment-15583109
 ] 

ASF GitHub Bot commented on GEODE-2004:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/262


> Create/update/delete query through rest api should require DATA:READ instead 
> of DATA:WRITE
> --
>
> Key: GEODE-2004
> URL: https://issues.apache.org/jira/browse/GEODE-2004
> Project: Geode
>  Issue Type: Bug
>  Components: management, security
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2004) Create/update/delete query through rest api should require DATA:READ instead of DATA:WRITE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582947#comment-15582947
 ] 

ASF GitHub Bot commented on GEODE-2004:
---

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/262

GEODE-2004: Create/update/delete query through rest api should requir…

…e DATA:READ instead of DATA:WRITE

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2004

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 08745c9084c7cbfb4229bb0e9edcced1363224bd
Author: Kevin Duling 
Date:   2016-10-17T18:02:54Z

GEODE-2004: Create/update/delete query through rest api should require 
DATA:READ instead of DATA:WRITE




> Create/update/delete query through rest api should require DATA:READ instead 
> of DATA:WRITE
> --
>
> Key: GEODE-2004
> URL: https://issues.apache.org/jira/browse/GEODE-2004
> Project: Geode
>  Issue Type: Bug
>  Components: management, security
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1952) Merge documentation to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576512#comment-15576512
 ] 

ASF GitHub Bot commented on GEODE-1952:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/259


> Merge documentation to develop branch
> -
>
> Key: GEODE-1952
> URL: https://issues.apache.org/jira/browse/GEODE-1952
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.0.0-incubating
>
>
> The staging/docs-grant1 branch [1] contains the source current used to build 
> the documentation site [2] for geode.  In order to merge this source init the 
> develop branch, we need to:
> 1) Review the files and determine if there are any licensing or dependency 
> considerations.  Update the LICENSE and NOTICE files as necessary.
> 2) Update the source headers and replace with the Apache source header as 
> needed.  Since these are documentation files, determine if a source header is 
> required.
> 3) Improve the build process to make it simpler for contributors and users. 
> This includes writing up build instructions.  We will need to create a 
> top-level directory (geode-docs?) to hold the files.
> 4) Include the documentation in the source distributions created by the build.
> 5) Incorporate other suggestions from the community.
> Once the branch has been merged, we should host the documentation site on 
> geode.apache.org.
> [1] 
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;h=refs/heads/staging/docs-grant1;hb=refs/heads/staging/docs-grant1
> [2] http://geode.docs.pivotal.io



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1952) Merge documentation to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576238#comment-15576238
 ] 

ASF GitHub Bot commented on GEODE-1952:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/incubator-geode/pull/259
  
Tweaked the build instructions to include `build install` before `rackup`. 
Also moved the README, which focuses on building the docs, to the `geode-book` 
dir (and pointed to it from `geode-docs/CONTRIBUTE.md`, which focuses on 
working with the raw content).

If it's okay with everyone, I'd like to call GEODE-1952 done and revisit 
any outstanding issues from the thread (e.g., dir structure) in future 
work/tickets.


> Merge documentation to develop branch
> -
>
> Key: GEODE-1952
> URL: https://issues.apache.org/jira/browse/GEODE-1952
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.0.0-incubating
>
>
> The staging/docs-grant1 branch [1] contains the source current used to build 
> the documentation site [2] for geode.  In order to merge this source init the 
> develop branch, we need to:
> 1) Review the files and determine if there are any licensing or dependency 
> considerations.  Update the LICENSE and NOTICE files as necessary.
> 2) Update the source headers and replace with the Apache source header as 
> needed.  Since these are documentation files, determine if a source header is 
> required.
> 3) Improve the build process to make it simpler for contributors and users. 
> This includes writing up build instructions.  We will need to create a 
> top-level directory (geode-docs?) to hold the files.
> 4) Include the documentation in the source distributions created by the build.
> 5) Incorporate other suggestions from the community.
> Once the branch has been merged, we should host the documentation site on 
> geode.apache.org.
> [1] 
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;h=refs/heads/staging/docs-grant1;hb=refs/heads/staging/docs-grant1
> [2] http://geode.docs.pivotal.io



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1952) Merge documentation to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570430#comment-15570430
 ] 

ASF GitHub Bot commented on GEODE-1952:
---

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/259

Feature/geode 1952 2

This merges feature/GEODE-1952, which was branched from the
docs donation staging branch, into feature/GEODE-1952-2, which
was branched from develop.

In addition to merging the docs donation, it adds the
geode-book directory for building the end-user documentation
from the content in the geode-docs directory. It also updates the
geode-docs README for building the docs locally.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode 
feature/GEODE-1952-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #259


commit d9d8b59b325c0581ff54c97db91b52adb0f4714c
Author: Joey McAllister 
Date:   2016-10-11T20:34:06Z

Add geode-book dir for docs build

commit 1c98ba56cf609ee61b5872cd696db95d4bcfebaa
Author: Joey McAllister 
Date:   2016-10-11T21:06:36Z

Revert "Add geode-book dir for docs build"

This reverts commit d9d8b59b325c0581ff54c97db91b52adb0f4714c.

commit e9b44af4e996ac739cd632704e925d525b9fcca1
Author: Joey McAllister 
Date:   2016-10-11T21:24:40Z

GEODE-1952 Add geode-book dir to build docs

commit 7592ba1027e51ae84dcfbed297534522557fbbec
Author: Joey McAllister 
Date:   2016-10-11T21:38:11Z

GEODE-1952 Remove old redirects

commit 36d1f39d68a847dc574e267c51efa89f9c980bd6
Author: Joey McAllister 
Date:   2016-10-11T22:54:54Z

GEODE-1952 Update docs README, config

commit 0b31275966beaf4039afd913b8644c81a32c1758
Author: Joey McAllister 
Date:   2016-10-12T00:29:12Z

GEODE-1952 Add book README; edit docs README, CONTRIBUTE

commit 14a32e2ebaa88726e3d70c9b69c1aacae3f3b4e1
Author: Joey McAllister 
Date:   2016-10-12T20:38:00Z

Edit README; rm pdf_header

commit 98ed943a9ac3a8ab9ff941fd3f1527ebd1600209
Author: Joey McAllister 
Date:   2016-10-12T21:41:27Z

Merge branch 'feature/GEODE-1952' into feature/GEODE-1952-2

GEODE-1952 was branched from the docs donation staging branch.
This merges docs work from that branch to 1952-2, which is
branched from develop.

commit dcc9de7702ba0f2de60f1e2983b472b2cf89404d
Author: Joey McAllister 
Date:   2016-10-12T21:49:46Z

Fix README numbering, anchors

commit a5d1e957a825e2d5f76764182f58b9f257730af4
Author: Joey McAllister 
Date:   2016-10-13T00:56:09Z

GEODE-1952: Change Project G to Apache G; other edits




> Merge documentation to develop branch
> -
>
> Key: GEODE-1952
> URL: https://issues.apache.org/jira/browse/GEODE-1952
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.0.0-incubating
>
>
> The staging/docs-grant1 branch [1] contains the source current used to build 
> the documentation site [2] for geode.  In order to merge this source init the 
> develop branch, we need to:
> 1) Review the files and determine if there are any licensing or dependency 
> considerations.  Update the LICENSE and NOTICE files as necessary.
> 2) Update the source headers and replace with the Apache source header as 
> needed.  Since these are documentation files, determine if a source header is 
> required.
> 3) Improve the build process to make it simpler for contributors and users. 
> This includes writing up build instructions.  We will need to create a 
> top-level directory (geode-docs?) to hold the files.
> 4) Include the documentation in the source distributions created by the build.
> 5) Incorporate other suggestions from the community.
> Once the branch has been merged, we should host the documentation site on 
> geode.apache.org.
> [1] 
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;h=refs/heads/staging/docs-grant1;hb=refs/heads/staging/docs-grant1
> [2] http://geode.docs.pivotal.io



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1952) Merge documentation to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570422#comment-15570422
 ] 

ASF GitHub Bot commented on GEODE-1952:
---

Github user joeymcallister closed the pull request at:

https://github.com/apache/incubator-geode/pull/258


> Merge documentation to develop branch
> -
>
> Key: GEODE-1952
> URL: https://issues.apache.org/jira/browse/GEODE-1952
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.0.0-incubating
>
>
> The staging/docs-grant1 branch [1] contains the source current used to build 
> the documentation site [2] for geode.  In order to merge this source init the 
> develop branch, we need to:
> 1) Review the files and determine if there are any licensing or dependency 
> considerations.  Update the LICENSE and NOTICE files as necessary.
> 2) Update the source headers and replace with the Apache source header as 
> needed.  Since these are documentation files, determine if a source header is 
> required.
> 3) Improve the build process to make it simpler for contributors and users. 
> This includes writing up build instructions.  We will need to create a 
> top-level directory (geode-docs?) to hold the files.
> 4) Include the documentation in the source distributions created by the build.
> 5) Incorporate other suggestions from the community.
> Once the branch has been merged, we should host the documentation site on 
> geode.apache.org.
> [1] 
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tree;h=refs/heads/staging/docs-grant1;hb=refs/heads/staging/docs-grant1
> [2] http://geode.docs.pivotal.io



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1952) Merge documentation to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569985#comment-15569985
 ] 

ASF GitHub Bot commented on GEODE-1952:
---

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/258

Feature/geode 1952 2

This merges feature/GEODE-1952, which was branched from the
docs donation staging branch, into feature/GEODE-1952-2, which
was branched from develop.

In addition to merging the docs donation, it adds the
geode-book directory for building the end-user documentation
from the content in the geode-docs directory. It also updates the
geode-docs README for building the docs locally.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode 
feature/GEODE-1952-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #258


commit 01875e90b417cd045a8b070152fbf10fec64bdb9
Author: Joey McAllister 
Date:   2016-04-22T00:53:18Z

First commit

commit 9b064e81a49302904f2259f93ad909d12c47fdaa
Author: Joey McAllister 
Date:   2016-06-16T02:58:09Z

Added markdown build v2 for testing.

commit d21bdba95e449fa6c7d951dedbe007eb1f5c3a8c
Author: Joey McAllister 
Date:   2016-06-16T22:27:50Z

Converted for Geode.

commit cae14a4e06d8eb92b8ea70009ae362b2d5668c17
Author: Joey McAllister 
Date:   2016-06-17T01:23:35Z

Deleting old md conversion.

commit 657e48144bb9ed4cdb007b2a3ec6949a5863e436
Author: Joey McAllister 
Date:   2016-06-27T16:33:30Z

Commit initial markdown code

commit 23a30d78ad5c2d2fbeb48de625e6b0d12a3c6e76
Author: Joey McAllister 
Date:   2016-06-28T18:40:29Z

Add .gitignore file

commit 30b2f133bbd1926151cae3dd4a0db87cde8eb4fa
Author: Joey McAllister 
Date:   2016-06-29T00:14:59Z

Add new markdown conversion.

commit db585e11122bf9e6b6d070969cc89a4dc2dca5ff
Author: Joey McAllister 
Date:   2016-06-29T19:30:18Z

Fix broken link in CONTRIBUTE

commit 7ed14b45cd7e52b9aaf8b547cd1161e6cdda74d8
Author: Karen Miller 
Date:   2016-06-29T21:03:26Z

update documentation for subregions [#123529761]

commit 44c6344f794e2b5264b4a85bf037a1ae3eb03598
Author: Joey McAllister 
Date:   2016-06-29T22:20:28Z

Add 2 missing conversion files

commit 03c5973f47f82d8a4d6135ce6d4e178c08a44f73
Author: Joey McAllister 
Date:   2016-06-29T22:20:46Z

Merge branch 'develop' of https://github.com/gemfire/docs-geode-md into 
develop

commit dff48188cba5e3436169493af7dac14c140c3363
Author: Joey McAllister 
Date:   2016-06-29T22:36:32Z

Add another missing converted file

commit 3c5523b503bdb553984c08f619540aeaa436115f
Author: Karen Miller 
Date:   2016-06-29T23:08:55Z

fix of poorly interpreted markdown with nested lists [#122664681]

commit a63dc114777578591894a2651be1fb837ededcf4
Author: Karen Miller 
Date:   2016-06-29T23:10:12Z

Merge branch 'develop' of https://github.com/gemfire/docs-geode-md into 
develop

commit 4d145299e863ee445ccee6e9f923d3a204c8d575
Author: Karen Miller 
Date:   2016-06-30T00:06:54Z

review/fix markdown for the Basic Configuration and
Programming section [#122664681]

commit 907634a4d341fe6eef566ce09863156bfa57f88f
Author: Karen Miller 
Date:   2016-06-30T16:58:02Z

review/fix markdown for the Getting Started section [#122663941]

commit 7dce9ea9051f853b24256739a8c3e76f27df346a
Author: Karen Miller 
Date:   2016-06-30T22:55:05Z

review/fix markdown for the Topologies and Communication
section [#122665061]

commit 16e7efad0da5fe2e4df871aadc9cf099c5b76bc0
Author: Karen Miller 
Date:   2016-07-01T16:43:02Z

First commit for review/fix markdown in the Managing
section [#122665421]

commit 8d07513353f62a60f6344979f28a26023c65b804
Author: Karen Miller 
Date:   2016-07-01T16:48:14Z

correct signature in AsynccEventListener code example [#124028111]

commit 8c9b29b181a34c1ceb69ec2fae0e1db9054c61df
Author: Dave Barnes 
Date:   2016-07-01T17:29:21Z

Reviewed markdown "Configuring and Running a Cluster" section. [Closes 
#122664151]

commit 6e393014c814f6054aa23b47a79e96190de806df
Author: Joey McAllister 
Date:   2016-07-01T20:38:41Z

Fix typo

Typo submitted by 

[jira] [Commented] (GEODE-999) Explore the ways to run pulse ui tests in headless mode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569269#comment-15569269
 ] 

ASF GitHub Bot commented on GEODE-999:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/256


> Explore the ways to run pulse ui tests in headless mode
> ---
>
> Key: GEODE-999
> URL: https://issues.apache.org/jira/browse/GEODE-999
> Project: Geode
>  Issue Type: Task
>  Components: pulse
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
> Fix For: 1.0.0-incubating.M2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-999) Explore the ways to run pulse ui tests in headless mode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565923#comment-15565923
 ] 

ASF GitHub Bot commented on GEODE-999:
--

GitHub user jaredjstewart opened a pull request:

https://github.com/apache/incubator-geode/pull/256

Feature/geode 1532

GEODE-999: Convert pulse uiTests to phantomJS.
GEODE-1966: Prevent unauthorized users from viewing pulseVersion details.
GEODE-1532: Fix Pulse clickjacking vulnerability.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaredjstewart/incubator-geode 
feature/GEODE-1532

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #256


commit 96f10a5b2aad7c0a2b3c34d16c0cffdca7c1156e
Author: Jared Stewart 
Date:   2016-10-03T21:15:59Z

GEODE-999: All unignored UITests now pass

commit ed66a2dab64f3adbfb19b66f2daf8f367cdd8002
Author: Jared Stewart 
Date:   2016-10-05T19:09:12Z

GEODE-999: Converted from Firefox driver to PhantomJS driver to run UITests 
in headless mode

commit a7d537fee7a70ca4b696b7c87ccb9873d4f91ecb
Author: Jared Stewart 
Date:   2016-10-10T18:50:42Z

Moved pulse ui tests into their own package.

commit 0b9e625dc866fff1281255095d632f0119ae4086
Author: Jared Stewart 
Date:   2016-10-10T23:59:07Z

GEODE-1966: Unauthorized users cannot access pulseVersion details

commit 655f2286efe3218f419b614d9e4ceb15c6cfe505
Author: Jared Stewart 
Date:   2016-10-11T01:48:01Z

GEODE-1532: Fix Pulse Clickjacking vuln.




> Explore the ways to run pulse ui tests in headless mode
> ---
>
> Key: GEODE-999
> URL: https://issues.apache.org/jira/browse/GEODE-999
> Project: Geode
>  Issue Type: Task
>  Components: pulse
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
> Fix For: 1.0.0-incubating.M2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-136) Fix possible NullPointerException in Gfsh's 'list regions' command's GetRegionsFunction.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547139#comment-15547139
 ] 

ASF GitHub Bot commented on GEODE-136:
--

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/253

GEODE-136: Fix possible NullPointerException in GetRegionsFunction

Addresses an unlikely but possible NPE.
Removes use of a deprecated interface.
Introduces a missing unit test.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-136

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit 99114411aae2e9238f1a1e8e115b1e494e78e000
Author: Kevin Duling 
Date:   2016-10-05T00:08:17Z

GEODE-136: Fix possible NullPointerException in Gfsh's 'list regions' 
command's GetRegionsFunction.




> Fix possible NullPointerException in Gfsh's 'list regions' command's 
> GetRegionsFunction.
> 
>
> Key: GEODE-136
> URL: https://issues.apache.org/jira/browse/GEODE-136
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
> Environment: GemFire Manager + Gfsh
>Reporter: John Blum
>Assignee: Kevin Duling
>  Labels: ApacheGeode, CLI, GFSH, GetRegionsFunction, list-regions
> Fix For: 1.0.0-incubating
>
>
> The following line 
> ([#48|https://github.com/apache/incubator-geode/blob/develop/gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/GetRegionsFunction.java#L48])
>  in the {{GetRegionsFunction}} class could possibly lead to a NPE if the 
> {{regions}} _Set_ is null since the {{regions.isEmpty()}} call proceeds the 
> {{regions == null}} check.
> Of course, one should argue whether {{Cache.rootRegions()}} should be 
> returning a null _Set_ at all rather than an empty _Set_ if there are in fact 
> no "root" _Regions_ in the Geode _Cache_.
> But then, one could also argue that this {{GetRegionsFunction}} should not be 
> returning a null "array" if there are no "root" _Regions_ in the Geode 
> _Cache_ either.  It too should be returning an "empty" array.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-136) Fix possible NullPointerException in Gfsh's 'list regions' command's GetRegionsFunction.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547068#comment-15547068
 ] 

ASF GitHub Bot commented on GEODE-136:
--

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/252
  
That doesn't look right...


> Fix possible NullPointerException in Gfsh's 'list regions' command's 
> GetRegionsFunction.
> 
>
> Key: GEODE-136
> URL: https://issues.apache.org/jira/browse/GEODE-136
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating
> Environment: GemFire Manager + Gfsh
>Reporter: John Blum
>Assignee: Kevin Duling
>  Labels: ApacheGeode, CLI, GFSH, GetRegionsFunction, list-regions
> Fix For: 1.0.0-incubating
>
>
> The following line 
> ([#48|https://github.com/apache/incubator-geode/blob/develop/gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/GetRegionsFunction.java#L48])
>  in the {{GetRegionsFunction}} class could possibly lead to a NPE if the 
> {{regions}} _Set_ is null since the {{regions.isEmpty()}} call proceeds the 
> {{regions == null}} check.
> Of course, one should argue whether {{Cache.rootRegions()}} should be 
> returning a null _Set_ at all rather than an empty _Set_ if there are in fact 
> no "root" _Regions_ in the Geode _Cache_.
> But then, one could also argue that this {{GetRegionsFunction}} should not be 
> returning a null "array" if there are no "root" _Regions_ in the Geode 
> _Cache_ either.  It too should be returning an "empty" array.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)