[jira] [Commented] (GEODE-2114) Add user and password to gfsh connect docs
[ https://issues.apache.org/jira/browse/GEODE-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671639#comment-15671639 ] ASF subversion and git services commented on GEODE-2114: Commit c45fe4ca54ccef9b2f2a223a0f0de0737ab2b911 in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c45fe4c ] GEODE-2114 Revise user and password options to gfsh connect - Note that the password is clear text. - State that user and password are used for authentication. > Add user and password to gfsh connect docs > -- > > Key: GEODE-2114 > URL: https://issues.apache.org/jira/browse/GEODE-2114 > Project: Geode > Issue Type: Task > Components: docs >Reporter: Karen Smoler Miller > > The gfsh connect command has --user and --password options that are not > completely documented. The task here is to complete that documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2073) CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
[
https://issues.apache.org/jira/browse/GEODE-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671242#comment-15671242
]
ASF subversion and git services commented on GEODE-2073:
Commit bb7a5e218e446e296df8f71b3578daf152ab0c8c in incubator-geode's branch
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=bb7a5e2 ]
GEODE-2073 CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
I modified the test to wait longer and not require that the "next neighbor"
be an exact member but merely a different one than the initial "next neigbor".
Also, the diagnostic test in the exception thrown by this method was
including the JoinLeave membership view but that is null in these
tests. Instead it needs to show the HealthMonitor's membership view.
I added a method to GMSHealthMonitor to allow access to its view.
> CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
>
>
> Key: GEODE-2073
> URL: https://issues.apache.org/jira/browse/GEODE-2073
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, flaky
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest
> > testHMNextNeighborAfterTimeout FAILED
> java.lang.AssertionError: expected
> 09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8893 but found
> 09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8892. view=null
> expected:<09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8893> but
> was:<09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8892>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout(GMSHealthMonitorJUnitTest.java:183)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode
[
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669446#comment-15669446
]
ASF subversion and git services commented on GEODE-2098:
Commit 216a10917533a2f287d0bf509424f52716b81c6e in incubator-geode's branch
refs/heads/develop from adongre
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=216a109 ]
GEODE-2098: Moved gfsh history file location from .gemfire to .geode
Made the code changes and added a test for the same.
> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
> Fix For: 1.1.0-incubating
>
>
> Currently gfsh stores history in the ~/.gemfire directory. We should change
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
> if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
> }
> }
> return homeDirPath;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2098) gfsh history should be stored in ~/.geode
[
https://issues.apache.org/jira/browse/GEODE-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669412#comment-15669412
]
ASF subversion and git services commented on GEODE-2098:
Commit 6e1377a0f3f32aef279e9cbea3741c90aad95f30 in incubator-geode's branch
refs/heads/feature/GEODE-2098 from adongre
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6e1377a ]
GEODE-2098: Moved gfsh history file location from .gemfire to .geode
Made the code changes and added a test for the same.
> gfsh history should be stored in ~/.geode
> -
>
> Key: GEODE-2098
> URL: https://issues.apache.org/jira/browse/GEODE-2098
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
>Reporter: Anthony Baker
>Assignee: Avinash Dongre
>
> Currently gfsh stores history in the ~/.gemfire directory. We should change
> that to be ~/.geode.
> {code}
> private static String getHomeGemFireDirectory() {
> String userHome = System.getProperty("user.home");
> String homeDirPath = userHome + "/.gemfire";
> File alternateDir = new File(homeDirPath);
> if (!alternateDir.exists()) {
> if (!alternateDir.mkdirs()) {
> homeDirPath = ".";
> }
> }
> return homeDirPath;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2104) GFSH parsing of options following --J options are interpreted as part of the --J value
[ https://issues.apache.org/jira/browse/GEODE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669015#comment-15669015 ] ASF subversion and git services commented on GEODE-2104: Commit 4a913fe7a65ea4d5d91ff04f671bf94205b60b62 in incubator-geode's branch refs/heads/develop from [~jstewart] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4a913fe ] GEODE-2104: Fix parsing of options following --J This closes #286 > GFSH parsing of options following --J options are interpreted as part of the > --J value > -- > > Key: GEODE-2104 > URL: https://issues.apache.org/jira/browse/GEODE-2104 > Project: Geode > Issue Type: Bug > Components: management >Affects Versions: 1.0.0-incubating >Reporter: Kirk Lund >Assignee: Jared Stewart > > GFSH parsing of options following --J options are interpreted as part of the > --J value. > $ start server --name=me3 --J=-Dgemfire.jmx-manager=true > --J=-Dgemfire.jmx-manager-start=true --http-service-port=8080` > In the above GFSH does not interpret the `http-service-port` option > correctly. If you look in the log, the value for `gemfire.jmx-manager-start` > is `true --http-service-port=8080` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1247) Unable to stop members by name when using gfsh over http
[
https://issues.apache.org/jira/browse/GEODE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668457#comment-15668457
]
ASF subversion and git services commented on GEODE-1247:
Commit bb3db4a6a6f5057c8d4ebb87961708d131e5b447 in incubator-geode's branch
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=bb3db4a ]
GEODE-1247: unable to stop server using http connection
> Unable to stop members by name when using gfsh over http
>
>
> Key: GEODE-1247
> URL: https://issues.apache.org/jira/browse/GEODE-1247
> Project: Geode
> Issue Type: Bug
> Components: gfsh, rest (admin)
>Reporter: Jens Deppe
>
> I'm connecting to my cluster with http:
> {noformat}
> gfsh>connect --use-http=true --url=http://localhost:7070/gemfire/v1
> {noformat}
> And creating a server...
> {noformat}
> gfsh>start server --name=server1
> Starting a GemFire Server in /Users/jdeppe/debug/server1...
> .
> Server in /Users/jdeppe/debug/server1 on 192.168.99.1[40404] as server1 is
> currently online.
> Process ID: 97639
> Uptime: 2 seconds
> GemFire Version: 1.0.0-incubating.M3-SNAPSHOT
> Java Version: 1.8.0_77
> Log File: /Users/jdeppe/debug/server1/server1.log
> JVM Arguments: -Dgemfire.default.locators=192.168.99.1[19991]
> -Dgemfire.use-cluster-configuration=true -XX:OnOutOfMemoryError=kill -KILL %p
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true
> -Dsun.rmi.dgc.server.gcInterval=9223372036854775806
> Class-Path:
> /Users/jdeppe/git/gemfire-develop/open/geode-assembly/build/install/apache-geode/lib/geode-core-1.0.0-incubating.M3-SNAPSHOT.jar:/Users/jdeppe/git/gemfire-develop/open/geode-assembly/build/install/apache-geode/lib/geode-dependencies.jar
> gfsh>list members;
> Name | Id
> | -
> locator1 | 192.168.99.1(locator1:97595:locator):1024
> server1 | 192.168.99.1(server1:97639):1025
> {noformat}
> But cannot stop it...
> {noformat}
> gfsh>stop server --name=server1
> An error occurred while attempting to stop a Cache Server: The HTTP request
> failed with: 500 - Server Error
> {noformat}
> The locator log shows this error:
> {noformat}
> [severe 2016/04/18 13:54:49.754 PDT locator1 tid=0x42]
> org.springframework.http.converter.HttpMessageNotReadableException: Could not
> read document: invalid stream header: 7B226F62; nested exception is
> java.io.StreamCorruptedException: invalid stream header: 7B226F62
> at
> org.springframework.web.servlet.mvc.method.annotation.AbstractMessageConverterMethodArgumentResolver.readWithMessageConverters(AbstractMessageConverterMethodArgumentResolver.java:227)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestResponseBodyMethodProcessor.readWithMessageConverters(RequestResponseBodyMethodProcessor.java:147)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestResponseBodyMethodProcessor.resolveArgument(RequestResponseBodyMethodProcessor.java:125)
> at
> org.springframework.web.method.support.HandlerMethodArgumentResolverComposite.resolveArgument(HandlerMethodArgumentResolverComposite.java:78)
> at
> org.springframework.web.method.support.InvocableHandlerMethod.getMethodArgumentValues(InvocableHandlerMethod.java:162)
> at
> org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:129)
> at
> org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:814)
> at
> org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:737)
> at
> org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
> at
> org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:959)
> at
> org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)
> at
> org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:969)
> at
> org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:871)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> at
> org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:845)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.han
[jira] [Commented] (GEODE-1955) JMX suspect string causes tests to fail
[ https://issues.apache.org/jira/browse/GEODE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668451#comment-15668451 ] ASF subversion and git services commented on GEODE-1955: Commit 58e0026c6dda077fbcedea1289993f5d36b67a74 in incubator-geode's branch refs/heads/develop from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=58e0026 ] GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests * fix the test so that it truely tests the jmx ssl > JMX suspect string causes tests to fail > --- > > Key: GEODE-1955 > URL: https://issues.apache.org/jira/browse/GEODE-1955 > Project: Geode > Issue Type: Bug > Components: jmx >Reporter: Bruce Schuchardt >Assignee: Jinmei Liao > Labels: ci > > This suspect string is causing periodic failures in a number of unit tests: > Error Message > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > --- > Found suspect string in log4j at line 283 > [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] > (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2110) Add user and password to gfsh start server docs
[ https://issues.apache.org/jira/browse/GEODE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668383#comment-15668383 ] ASF subversion and git services commented on GEODE-2110: Commit b35e2a448311db6994f907464528266e897f0a46 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b35e2a4 ] GEODE-2110 Revised wording of gfsh start server --password Added a note to make it clear that specifying --password on the command line means that a clear text password is visible. > Add user and password to gfsh start server docs > --- > > Key: GEODE-2110 > URL: https://issues.apache.org/jira/browse/GEODE-2110 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > Options to the gfsh start server command specify the user and password to use > as credentials in authentication. These options are nicely printed in the > gfsh help option, but they did not make it into the command reference page > for the gfsh start server command. Thus, they need to be added. > From the help output: > user > User name to securely connect to the cluster. If the --password > parameter is not specified then it will be prompted for. > Required: false > password > Password to securely connect to the cluster. > Required: false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-288) Remove deprecated Admin API
[ https://issues.apache.org/jira/browse/GEODE-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668385#comment-15668385 ] ASF subversion and git services commented on GEODE-288: --- Commit b6c305f88b9708d8bfeb9d5d8bff9fc950bf4d5c in incubator-geode's branch refs/heads/feature/GEODE-288 from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b6c305f ] GEODE-288: move admin packages to internal * org.apache.geode.admin (old Admin API) moves to org.apache.geode.internal.admin.api * org.apache.geode.admin.internal (old Amin API implementation) moves to org.apache.geode.internal.admin.api.impl * org.apache.geode.admin.jmx (old JMX API) moves to org.apache.geode.internal.admin.api.jmx * org.apache.geode.admin.jmx.internal (old JMX API implementation) moves to org.apache.geode.internal.admin.api.jmx.impl > Remove deprecated Admin API > --- > > Key: GEODE-288 > URL: https://issues.apache.org/jira/browse/GEODE-288 > Project: Geode > Issue Type: Sub-task > Components: docs, jmx >Affects Versions: 1.0.0-incubating >Reporter: Kirk Lund >Assignee: Kirk Lund > > The Admin API (com.gemstone.gemfire.admin) and old JMX Agent have been > deprecated since GemFire 7.0. The Admin API was retired in favor of using the > new Management JMX API (com.gemstone.gemfire.management) and GFSH. > #1) move some Admin classes used internally by non-Admin code: > move com.gemstone.gemfire.admin.BackupStatus > move com.gemstone.gemfire.admin.OperationCancelledException > move com.gemstone.gemfire.admin.RegionNotFoundException > move > com.gemstone.gemfire.admin.internal.AdminDistributedSystemImpl.backupAllMembers > move > com.gemstone.gemfire.admin.internal.AdminDistributedSystemImpl.compactAllDiskStores > move com.gemstone.gemfire.admin.internal.FinishBackupRequest > move com.gemstone.gemfire.admin.internal.FlushToDiskRequest > move com.gemstone.gemfire.admin.internal.InetAddressUtil > move com.gemstone.gemfire.admin.internal.PrepareBackupRequest > #2) move com.gemstone.gemfire.admin to > com.gemstone.gemfire.internal.admin.api (temporarily) > #3) remove com.gemstone.gemfire.cache.* usage of admin > #4) remove com.gemstone.gemfire.distributed.* usage of admin > #5) remove com.gemstone.gemfire.internal.* usage of admin (except for > internal.admin.*) > #6) remove com.gemstone.gemfire.management.* usage of admin > #7) remove com.gemstone.gemfire.internal.admin.api if possible > #8) remove unused classes from com.gemstone.gemfire.internal.admin.* > Breakdown by package and class: > com.gemstone.gemfire > --change DataSerializer to use moved RegionNotFoundException > com.gemstone.gemfire.cache > com.gemstone.gemfire.cache.persistence > com.gemstone.gemfire.cache.util > --remove com.gemstone.gemfire.cache.util.UniversalMembershipListenerAdapter > com.gemstone.gemfire.distributed > --remove Admin API from javadocs in Locator and DistributedSystem > com.gemstone.gemfire.distributed.internal > --remove > com.gemstone.gemfire.distributed.internal.DistributionManager.createHealthMonitor > --remove remove com.gemstone.gemfire.distributed.internal.HealthMonitor > --remove remove com.gemstone.gemfire.distributed.internal.HealthMonitorImpl > --change > com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.hasAlertListenerFor > to not use AlertLevel > com.gemstone.gemfire.internal > --remove DSFIDFactory support for admin messages > --remove com.gemstone.gemfire.admin.jmx.internal.AgentLauncher from > GemFireUtilLauncher > --change MigrationServer to use moved InetAddressUtil > --change SocketCreator to use moved InetAddressUtil > --remove SystemAdmin.backup > --remove SystemAdmin.compactAllDiskStores > --remove SystemAdmin.shutDownAll > --remove SystemAdmin.listMissingDiskStores > --remove SystemAdmin.revokeMissingDiskStores > com.gemstone.gemfire.internal.cache > --replace use of com.gemstone.gemfire.admin.OperationCancelledException > --remove use of > com.gemstone.gemfire.admin.internal.SystemMemberCacheEventProcessor > com.gemstone.gemfire.internal.cache.partitioned > --replace use of com.gemstone.gemfire.admin.OperationCancelledException > com.gemstone.gemfire.internal.cache.snapshot > --replace use of com.gemstone.gemfire.admin.RegionNotFoundException > com.gemstone.gemfire.internal.tools.gfsh.app.command.task > --reimplement PartitionedRegionAttributeTask > com.gemstone.gemfire.internal.tools.gfsh.util > --reimplement RegionUtil > com.gemstone.gemfire.management.internal.beans > --change DistributedSystemBridge to use moved classes > com.gemstone.gemfire.management.internal.cli.commands > --change DiskStoreCommands to use moved classes > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported
[
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668384#comment-15668384
]
ASF subversion and git services commented on GEODE-1617:
Commit 0c9002b205e64cb248ab6ab26f2df27bf821c54c in incubator-geode's branch
refs/heads/feature/GEODE-288 from [~kduling]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=0c9002b ]
GEODE-1617: add test for region names
Added comprehensive test to validate region names
This closes #285
> Regions can be created with a variety of characters that are unsupported
>
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
> and this
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
> on the dev forums and [geode
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
> region names may only consist of alphanumeric characters, an underscore, and
> a hyphen. These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while
> others cannot be located.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2112) UITests are failing due to insufficient tearDown
[
https://issues.apache.org/jira/browse/GEODE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668382#comment-15668382
]
ASF subversion and git services commented on GEODE-2112:
Commit cc996a61d72123c358ced362fb884169e068bcff in incubator-geode's branch
refs/heads/feature/GEODE-288 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=cc996a6 ]
GEODE-2112: Improved cleanup for UITests
UITests were failing when more than one was run because
they all share a base class that was not properly cleaned up.
This closes #284
> UITests are failing due to insufficient tearDown
>
>
> Key: GEODE-2112
> URL: https://issues.apache.org/jira/browse/GEODE-2112
> Project: Geode
> Issue Type: Bug
> Components: pulse, tests
>Reporter: Kirk Lund
>Assignee: Jared Stewart
> Fix For: 1.1.0-incubating
>
>
> UITests are failing due to insufficient tearDown
> {noformat}
> INFO: Connecting to jmxURL :
> service:jmx:rmi://localhost/jndi/rmi://localhost:/jmxrmi
> [info 2016/11/14 15:51:15.940 PST
> tid=0x14] Logging in admin
> [warn 2016/11/14 15:51:15.940 PST
> tid=0x14] Authentication failed for token submission
> [org.apache.geode.internal.security.shiro.GeodeAuthenticationToken - admin,
> rememberMe=false]. Possible unexpected error? (Typical or expected login
> exceptions should extend from AuthenticationException).
> org.apache.geode.security.AuthenticationFailedException:
> SampleSecurityManager: wrong username/password
> at
> org.apache.geode.security.templates.SampleSecurityManager.authenticate(SampleSecurityManager.java:146)
> at
> org.apache.geode.internal.security.shiro.CustomAuthRealm.doGetAuthenticationInfo(CustomAuthRealm.java:66)
> at
> org.apache.shiro.realm.AuthenticatingRealm.getAuthenticationInfo(AuthenticatingRealm.java:568)
> at
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doSingleRealmAuthentication(ModularRealmAuthenticator.java:180)
> at
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doAuthenticate(ModularRealmAuthenticator.java:267)
> at
> org.apache.shiro.authc.AbstractAuthenticator.authenticate(AbstractAuthenticator.java:198)
> at
> org.apache.shiro.mgt.AuthenticatingSecurityManager.authenticate(AuthenticatingSecurityManager.java:106)
> at
> org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:270)
> at
> org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
> at
> org.apache.geode.internal.security.IntegratedSecurityService.login(IntegratedSecurityService.java:151)
> at
> org.apache.geode.internal.security.shiro.JMXShiroAuthenticator.authenticate(JMXShiroAuthenticator.java:58)
> at
> javax.management.remote.rmi.RMIServerImpl.doNewClient(RMIServerImpl.java:232)
> at
> javax.management.remote.rmi.RMIServerImpl.newClient(RMIServerImpl.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:324)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-79) Provide utility to collect log artifacts
[ https://issues.apache.org/jira/browse/GEODE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668376#comment-15668376 ] ASF subversion and git services commented on GEODE-79: -- Commit ddc4819b01470825997b8504c0971d04ddfab2f3 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ddc4819 ] GEODE-2105 Remove docs about log collection utility The log collection utility is not part of the release, so remove the documentation. The content removed by this commit has been placed on the feature/GEODE-79 branch. > Provide utility to collect log artifacts > > > Key: GEODE-79 > URL: https://issues.apache.org/jira/browse/GEODE-79 > Project: Geode > Issue Type: New Feature > Components: general >Reporter: Darrel Schneider >Assignee: Vincent Ford >Priority: Minor > > A utility named "gfe-sendlogs.py" exists and can be used to collect all the > log files of a distributed system so they can be easily collected and sent to > support. This task tracks the donation of the code to Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2105) Remove documentation of Log Collection Utility
[ https://issues.apache.org/jira/browse/GEODE-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668375#comment-15668375 ] ASF subversion and git services commented on GEODE-2105: Commit ddc4819b01470825997b8504c0971d04ddfab2f3 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ddc4819 ] GEODE-2105 Remove docs about log collection utility The log collection utility is not part of the release, so remove the documentation. The content removed by this commit has been placed on the feature/GEODE-79 branch. > Remove documentation of Log Collection Utility > -- > > Key: GEODE-2105 > URL: https://issues.apache.org/jira/browse/GEODE-2105 > Project: Geode > Issue Type: Task >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > The log collection utility is not part of Geode releases, so remove it from > the documentation. > https://issues.apache.org/jira/browse/GEODE-79 and the feature/GEODE-79 > branch has the code for the Log Collection Utility, but exists from a time > when the Geode docs were not yet donated to the ASF. The existing > documentation in file log_collection_utility.html.md.erb will be placed onto > that branch so it is not lost. No testing or checks will be done on the > feature/GEODE-79 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2101) Improve WAN topology terminology in docs
[ https://issues.apache.org/jira/browse/GEODE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668377#comment-15668377 ] ASF subversion and git services commented on GEODE-2101: Commit c9e3b05405a2e82a00f9b3ac15ed259a2829a053 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c9e3b05 ] GEODE-2101 Improve WAN topology terminology in docs The terms parallel and serial are not right, so change them: - a parallel multi-site topology is a fully connected mesh - a serial multi-site topology is a ring > Improve WAN topology terminology in docs > > > Key: GEODE-2101 > URL: https://issues.apache.org/jira/browse/GEODE-2101 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Minor > Fix For: 1.1.0-incubating > > > In our documentation description of WAN topologies, the term "parallel > multi-site topology" is a fully connected mesh. The "serial multi-site > topology" is a ring. It will improve the docs to change our descriptions to > use the common and accepted terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2088) A get in transaction may get incorrect TransactionDataNotColocatedException when bucket is not hosted locally
[
https://issues.apache.org/jira/browse/GEODE-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668379#comment-15668379
]
ASF subversion and git services commented on GEODE-2088:
Commit 139398a1f5af656c59eeacdb2dd9283a7145d992 in incubator-geode's branch
refs/heads/feature/GEODE-288 from [~eshu]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=139398a ]
GEODE-2088: Correctly throw TransactionDataRebalancedException when bucket is
moved during rebalance.
Turns out the transaction layer code has already handled when to throw
TransactionDataNotColocatedException in getTransactionException method call in
TXStateProxyImpl by checking whether the key is colocated with the keys already
touched in the transaction. Only need to make sure that piece of code will be
executed by throwing correct TransactionException.
> A get in transaction may get incorrect TransactionDataNotColocatedException
> when bucket is not hosted locally
> -
>
> Key: GEODE-2088
> URL: https://issues.apache.org/jira/browse/GEODE-2088
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Reporter: Eric Shu
>
> Currently a get of a PR in transaction on a data node with TXState will first
> check if the bucket is hosted locally by following code.
> {noformat}
> public Object getLocally(int bucketId, final Object key, final Object
> aCallbackArgument,
> boolean disableCopyOnRead, boolean preferCD, ClientProxyMembershipID
> requestingClient,
> EntryEventImpl clientEvent, boolean returnTombstones, boolean
> opScopeIsLocal)
> throws PrimaryBucketException, ForceReattemptException,
> PRLocallyDestroyedException {
> final BucketRegion bucketRegion = getInitializedBucketForId(key,
> Integer.valueOf(bucketId));
> {noformat}
> The BucketNotFoundException is thrown if the node does not host the bucket:
> {noformat}
> public BucketRegion getInitializedBucketForId(Object key, Integer bucketId)
> throws ForceReattemptException {
> final BucketRegion bucketRegion =
> this.localBucket2RegionMap.get(bucketId);
> if (null == bucketRegion) {
> this.partitionedRegion.checkReadiness();
> if (logger.isDebugEnabled()) {
> logger.debug("Got null bucket region for bucketId={}{}{} for
> PartitionedRegion = {}",
> this.partitionedRegion.getPRId(),
> PartitionedRegion.BUCKET_ID_SEPARATOR, bucketId,
> this.partitionedRegion);
> }
> ForceReattemptException fre = new BucketNotFoundException(
>
> LocalizedStrings.PartitionedRegionDataStore_BUCKET_ID_0_NOT_FOUND_ON_VM_1
> .toLocalizedString(
> new Object[]
> {this.partitionedRegion.bucketStringForLogs(bucketId.intValue()),
> this.partitionedRegion.getMyId()}));
> if (key != null) {
> fre.setHash(key.hashCode());
> }
> throw fre;
> }
> {noformat}
> Currently, transaction would fail with the
> TransactionDataNotColocatedException if bucket is not on local data store
> {noformat}
> if (prce instanceof BucketNotFoundException) {
> TransactionException ex = new
> TransactionDataNotColocatedException(
>
> LocalizedStrings.PartitionedRegion_KEY_0_NOT_COLOCATED_WITH_TRANSACTION
> .toLocalizedString(key));
> ex.initCause(prce);
> throw ex;
> }
> {noformat}
> This TransactionDataNotColocatedException is fine if the node never hosts
> bucket, or only previous operations within the transaction touches replicate
> regions earlier. However, if a bucket is moved to another node due to
> rebalance, and previous entry operations within the transaction only touches
> colocated regions, the transaction should fail with
> TransactionDataRebalancedException.
> We do not have a good way currently to throw the correct exception. One idea
> is to iterate through the existing TXRegions in the TXState to see whether we
> should throw TransactionDataRebalancedException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2110) Add user and password to gfsh start server docs
[ https://issues.apache.org/jira/browse/GEODE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668380#comment-15668380 ] ASF subversion and git services commented on GEODE-2110: Commit 6118a6a95cad3bc4708c535cabb9f9bdc9d10738 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6118a6a ] GEODE-2110 Add gfsh start server user and password options Modifies gfsh start server command reference page to add the two missing options: --user and --password > Add user and password to gfsh start server docs > --- > > Key: GEODE-2110 > URL: https://issues.apache.org/jira/browse/GEODE-2110 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > Options to the gfsh start server command specify the user and password to use > as credentials in authentication. These options are nicely printed in the > gfsh help option, but they did not make it into the command reference page > for the gfsh start server command. Thus, they need to be added. > From the help output: > user > User name to securely connect to the cluster. If the --password > parameter is not specified then it will be prompted for. > Required: false > password > Password to securely connect to the cluster. > Required: false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2110) Add user and password to gfsh start server docs
[ https://issues.apache.org/jira/browse/GEODE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668265#comment-15668265 ] ASF subversion and git services commented on GEODE-2110: Commit 6118a6a95cad3bc4708c535cabb9f9bdc9d10738 in incubator-geode's branch refs/heads/feature/GEODE-1930 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6118a6a ] GEODE-2110 Add gfsh start server user and password options Modifies gfsh start server command reference page to add the two missing options: --user and --password > Add user and password to gfsh start server docs > --- > > Key: GEODE-2110 > URL: https://issues.apache.org/jira/browse/GEODE-2110 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > Options to the gfsh start server command specify the user and password to use > as credentials in authentication. These options are nicely printed in the > gfsh help option, but they did not make it into the command reference page > for the gfsh start server command. Thus, they need to be added. > From the help output: > user > User name to securely connect to the cluster. If the --password > parameter is not specified then it will be prompted for. > Required: false > password > Password to securely connect to the cluster. > Required: false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported
[
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668268#comment-15668268
]
ASF subversion and git services commented on GEODE-1617:
Commit 0c9002b205e64cb248ab6ab26f2df27bf821c54c in incubator-geode's branch
refs/heads/feature/GEODE-1930 from [~kduling]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=0c9002b ]
GEODE-1617: add test for region names
Added comprehensive test to validate region names
This closes #285
> Regions can be created with a variety of characters that are unsupported
>
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
> and this
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
> on the dev forums and [geode
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
> region names may only consist of alphanumeric characters, an underscore, and
> a hyphen. These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while
> others cannot be located.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2088) A get in transaction may get incorrect TransactionDataNotColocatedException when bucket is not hosted locally
[
https://issues.apache.org/jira/browse/GEODE-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668264#comment-15668264
]
ASF subversion and git services commented on GEODE-2088:
Commit 139398a1f5af656c59eeacdb2dd9283a7145d992 in incubator-geode's branch
refs/heads/feature/GEODE-1930 from [~eshu]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=139398a ]
GEODE-2088: Correctly throw TransactionDataRebalancedException when bucket is
moved during rebalance.
Turns out the transaction layer code has already handled when to throw
TransactionDataNotColocatedException in getTransactionException method call in
TXStateProxyImpl by checking whether the key is colocated with the keys already
touched in the transaction. Only need to make sure that piece of code will be
executed by throwing correct TransactionException.
> A get in transaction may get incorrect TransactionDataNotColocatedException
> when bucket is not hosted locally
> -
>
> Key: GEODE-2088
> URL: https://issues.apache.org/jira/browse/GEODE-2088
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Reporter: Eric Shu
>
> Currently a get of a PR in transaction on a data node with TXState will first
> check if the bucket is hosted locally by following code.
> {noformat}
> public Object getLocally(int bucketId, final Object key, final Object
> aCallbackArgument,
> boolean disableCopyOnRead, boolean preferCD, ClientProxyMembershipID
> requestingClient,
> EntryEventImpl clientEvent, boolean returnTombstones, boolean
> opScopeIsLocal)
> throws PrimaryBucketException, ForceReattemptException,
> PRLocallyDestroyedException {
> final BucketRegion bucketRegion = getInitializedBucketForId(key,
> Integer.valueOf(bucketId));
> {noformat}
> The BucketNotFoundException is thrown if the node does not host the bucket:
> {noformat}
> public BucketRegion getInitializedBucketForId(Object key, Integer bucketId)
> throws ForceReattemptException {
> final BucketRegion bucketRegion =
> this.localBucket2RegionMap.get(bucketId);
> if (null == bucketRegion) {
> this.partitionedRegion.checkReadiness();
> if (logger.isDebugEnabled()) {
> logger.debug("Got null bucket region for bucketId={}{}{} for
> PartitionedRegion = {}",
> this.partitionedRegion.getPRId(),
> PartitionedRegion.BUCKET_ID_SEPARATOR, bucketId,
> this.partitionedRegion);
> }
> ForceReattemptException fre = new BucketNotFoundException(
>
> LocalizedStrings.PartitionedRegionDataStore_BUCKET_ID_0_NOT_FOUND_ON_VM_1
> .toLocalizedString(
> new Object[]
> {this.partitionedRegion.bucketStringForLogs(bucketId.intValue()),
> this.partitionedRegion.getMyId()}));
> if (key != null) {
> fre.setHash(key.hashCode());
> }
> throw fre;
> }
> {noformat}
> Currently, transaction would fail with the
> TransactionDataNotColocatedException if bucket is not on local data store
> {noformat}
> if (prce instanceof BucketNotFoundException) {
> TransactionException ex = new
> TransactionDataNotColocatedException(
>
> LocalizedStrings.PartitionedRegion_KEY_0_NOT_COLOCATED_WITH_TRANSACTION
> .toLocalizedString(key));
> ex.initCause(prce);
> throw ex;
> }
> {noformat}
> This TransactionDataNotColocatedException is fine if the node never hosts
> bucket, or only previous operations within the transaction touches replicate
> regions earlier. However, if a bucket is moved to another node due to
> rebalance, and previous entry operations within the transaction only touches
> colocated regions, the transaction should fail with
> TransactionDataRebalancedException.
> We do not have a good way currently to throw the correct exception. One idea
> is to iterate through the existing TXRegions in the TXState to see whether we
> should throw TransactionDataRebalancedException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2110) Add user and password to gfsh start server docs
[ https://issues.apache.org/jira/browse/GEODE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668267#comment-15668267 ] ASF subversion and git services commented on GEODE-2110: Commit b35e2a448311db6994f907464528266e897f0a46 in incubator-geode's branch refs/heads/feature/GEODE-1930 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b35e2a4 ] GEODE-2110 Revised wording of gfsh start server --password Added a note to make it clear that specifying --password on the command line means that a clear text password is visible. > Add user and password to gfsh start server docs > --- > > Key: GEODE-2110 > URL: https://issues.apache.org/jira/browse/GEODE-2110 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > Options to the gfsh start server command specify the user and password to use > as credentials in authentication. These options are nicely printed in the > gfsh help option, but they did not make it into the command reference page > for the gfsh start server command. Thus, they need to be added. > From the help output: > user > User name to securely connect to the cluster. If the --password > parameter is not specified then it will be prompted for. > Required: false > password > Password to securely connect to the cluster. > Required: false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2112) UITests are failing due to insufficient tearDown
[
https://issues.apache.org/jira/browse/GEODE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668266#comment-15668266
]
ASF subversion and git services commented on GEODE-2112:
Commit cc996a61d72123c358ced362fb884169e068bcff in incubator-geode's branch
refs/heads/feature/GEODE-1930 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=cc996a6 ]
GEODE-2112: Improved cleanup for UITests
UITests were failing when more than one was run because
they all share a base class that was not properly cleaned up.
This closes #284
> UITests are failing due to insufficient tearDown
>
>
> Key: GEODE-2112
> URL: https://issues.apache.org/jira/browse/GEODE-2112
> Project: Geode
> Issue Type: Bug
> Components: pulse, tests
>Reporter: Kirk Lund
>Assignee: Jared Stewart
> Fix For: 1.1.0-incubating
>
>
> UITests are failing due to insufficient tearDown
> {noformat}
> INFO: Connecting to jmxURL :
> service:jmx:rmi://localhost/jndi/rmi://localhost:/jmxrmi
> [info 2016/11/14 15:51:15.940 PST
> tid=0x14] Logging in admin
> [warn 2016/11/14 15:51:15.940 PST
> tid=0x14] Authentication failed for token submission
> [org.apache.geode.internal.security.shiro.GeodeAuthenticationToken - admin,
> rememberMe=false]. Possible unexpected error? (Typical or expected login
> exceptions should extend from AuthenticationException).
> org.apache.geode.security.AuthenticationFailedException:
> SampleSecurityManager: wrong username/password
> at
> org.apache.geode.security.templates.SampleSecurityManager.authenticate(SampleSecurityManager.java:146)
> at
> org.apache.geode.internal.security.shiro.CustomAuthRealm.doGetAuthenticationInfo(CustomAuthRealm.java:66)
> at
> org.apache.shiro.realm.AuthenticatingRealm.getAuthenticationInfo(AuthenticatingRealm.java:568)
> at
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doSingleRealmAuthentication(ModularRealmAuthenticator.java:180)
> at
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doAuthenticate(ModularRealmAuthenticator.java:267)
> at
> org.apache.shiro.authc.AbstractAuthenticator.authenticate(AbstractAuthenticator.java:198)
> at
> org.apache.shiro.mgt.AuthenticatingSecurityManager.authenticate(AuthenticatingSecurityManager.java:106)
> at
> org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:270)
> at
> org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
> at
> org.apache.geode.internal.security.IntegratedSecurityService.login(IntegratedSecurityService.java:151)
> at
> org.apache.geode.internal.security.shiro.JMXShiroAuthenticator.authenticate(JMXShiroAuthenticator.java:58)
> at
> javax.management.remote.rmi.RMIServerImpl.doNewClient(RMIServerImpl.java:232)
> at
> javax.management.remote.rmi.RMIServerImpl.newClient(RMIServerImpl.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:324)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2101) Improve WAN topology terminology in docs
[ https://issues.apache.org/jira/browse/GEODE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668263#comment-15668263 ] ASF subversion and git services commented on GEODE-2101: Commit c9e3b05405a2e82a00f9b3ac15ed259a2829a053 in incubator-geode's branch refs/heads/feature/GEODE-1930 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c9e3b05 ] GEODE-2101 Improve WAN topology terminology in docs The terms parallel and serial are not right, so change them: - a parallel multi-site topology is a fully connected mesh - a serial multi-site topology is a ring > Improve WAN topology terminology in docs > > > Key: GEODE-2101 > URL: https://issues.apache.org/jira/browse/GEODE-2101 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Minor > Fix For: 1.1.0-incubating > > > In our documentation description of WAN topologies, the term "parallel > multi-site topology" is a fully connected mesh. The "serial multi-site > topology" is a ring. It will improve the docs to change our descriptions to > use the common and accepted terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1617) Regions can be created with a variety of characters that are unsupported
[
https://issues.apache.org/jira/browse/GEODE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668152#comment-15668152
]
ASF subversion and git services commented on GEODE-1617:
Commit 0c9002b205e64cb248ab6ab26f2df27bf821c54c in incubator-geode's branch
refs/heads/develop from [~kduling]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=0c9002b ]
GEODE-1617: add test for region names
Added comprehensive test to validate region names
This closes #285
> Regions can be created with a variety of characters that are unsupported
>
>
> Key: GEODE-1617
> URL: https://issues.apache.org/jira/browse/GEODE-1617
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Affects Versions: 1.0.0-incubating.M2
>Reporter: Kevin Duling
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>
> Per this
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg04046.html],
> and this
> [thread|https://www.mail-archive.com/dev@geode.incubator.apache.org/msg07079.html]
> on the dev forums and [geode
> documentation|http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html],
> region names may only consist of alphanumeric characters, an underscore, and
> a hyphen. These rules are not enforced.
> E.g., it is possible to create a region with:
> {{gfsh> create region --name=not^good --type=REPLICATE}}
> Some of these regions may be removed with the {{destroy}} command, while
> others cannot be located.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2110) Add user and password to gfsh start server docs
[ https://issues.apache.org/jira/browse/GEODE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667973#comment-15667973 ] ASF subversion and git services commented on GEODE-2110: Commit b35e2a448311db6994f907464528266e897f0a46 in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b35e2a4 ] GEODE-2110 Revised wording of gfsh start server --password Added a note to make it clear that specifying --password on the command line means that a clear text password is visible. > Add user and password to gfsh start server docs > --- > > Key: GEODE-2110 > URL: https://issues.apache.org/jira/browse/GEODE-2110 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > Options to the gfsh start server command specify the user and password to use > as credentials in authentication. These options are nicely printed in the > gfsh help option, but they did not make it into the command reference page > for the gfsh start server command. Thus, they need to be added. > From the help output: > user > User name to securely connect to the cluster. If the --password > parameter is not specified then it will be prompted for. > Required: false > password > Password to securely connect to the cluster. > Required: false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2112) UITests are failing due to insufficient tearDown
[
https://issues.apache.org/jira/browse/GEODE-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667767#comment-15667767
]
ASF subversion and git services commented on GEODE-2112:
Commit cc996a61d72123c358ced362fb884169e068bcff in incubator-geode's branch
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=cc996a6 ]
GEODE-2112: Improved cleanup for UITests
UITests were failing when more than one was run because
they all share a base class that was not properly cleaned up.
This closes #284
> UITests are failing due to insufficient tearDown
>
>
> Key: GEODE-2112
> URL: https://issues.apache.org/jira/browse/GEODE-2112
> Project: Geode
> Issue Type: Bug
> Components: pulse, tests
>Reporter: Kirk Lund
>Assignee: Jared Stewart
>
> UITests are failing due to insufficient tearDown
> {noformat}
> INFO: Connecting to jmxURL :
> service:jmx:rmi://localhost/jndi/rmi://localhost:/jmxrmi
> [info 2016/11/14 15:51:15.940 PST
> tid=0x14] Logging in admin
> [warn 2016/11/14 15:51:15.940 PST
> tid=0x14] Authentication failed for token submission
> [org.apache.geode.internal.security.shiro.GeodeAuthenticationToken - admin,
> rememberMe=false]. Possible unexpected error? (Typical or expected login
> exceptions should extend from AuthenticationException).
> org.apache.geode.security.AuthenticationFailedException:
> SampleSecurityManager: wrong username/password
> at
> org.apache.geode.security.templates.SampleSecurityManager.authenticate(SampleSecurityManager.java:146)
> at
> org.apache.geode.internal.security.shiro.CustomAuthRealm.doGetAuthenticationInfo(CustomAuthRealm.java:66)
> at
> org.apache.shiro.realm.AuthenticatingRealm.getAuthenticationInfo(AuthenticatingRealm.java:568)
> at
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doSingleRealmAuthentication(ModularRealmAuthenticator.java:180)
> at
> org.apache.shiro.authc.pam.ModularRealmAuthenticator.doAuthenticate(ModularRealmAuthenticator.java:267)
> at
> org.apache.shiro.authc.AbstractAuthenticator.authenticate(AbstractAuthenticator.java:198)
> at
> org.apache.shiro.mgt.AuthenticatingSecurityManager.authenticate(AuthenticatingSecurityManager.java:106)
> at
> org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:270)
> at
> org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
> at
> org.apache.geode.internal.security.IntegratedSecurityService.login(IntegratedSecurityService.java:151)
> at
> org.apache.geode.internal.security.shiro.JMXShiroAuthenticator.authenticate(JMXShiroAuthenticator.java:58)
> at
> javax.management.remote.rmi.RMIServerImpl.doNewClient(RMIServerImpl.java:232)
> at
> javax.management.remote.rmi.RMIServerImpl.newClient(RMIServerImpl.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:324)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2110) Add user and password to gfsh start server docs
[ https://issues.apache.org/jira/browse/GEODE-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667633#comment-15667633 ] ASF subversion and git services commented on GEODE-2110: Commit 6118a6a95cad3bc4708c535cabb9f9bdc9d10738 in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=6118a6a ] GEODE-2110 Add gfsh start server user and password options Modifies gfsh start server command reference page to add the two missing options: --user and --password > Add user and password to gfsh start server docs > --- > > Key: GEODE-2110 > URL: https://issues.apache.org/jira/browse/GEODE-2110 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > > Options to the gfsh start server command specify the user and password to use > as credentials in authentication. These options are nicely printed in the > gfsh help option, but they did not make it into the command reference page > for the gfsh start server command. Thus, they need to be added. > From the help output: > user > User name to securely connect to the cluster. If the --password > parameter is not specified then it will be prompted for. > Required: false > password > Password to securely connect to the cluster. > Required: false -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2088) A get in transaction may get incorrect TransactionDataNotColocatedException when bucket is not hosted locally
[
https://issues.apache.org/jira/browse/GEODE-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667602#comment-15667602
]
ASF subversion and git services commented on GEODE-2088:
Commit 139398a1f5af656c59eeacdb2dd9283a7145d992 in incubator-geode's branch
refs/heads/develop from [~eshu]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=139398a ]
GEODE-2088: Correctly throw TransactionDataRebalancedException when bucket is
moved during rebalance.
Turns out the transaction layer code has already handled when to throw
TransactionDataNotColocatedException in getTransactionException method call in
TXStateProxyImpl by checking whether the key is colocated with the keys already
touched in the transaction. Only need to make sure that piece of code will be
executed by throwing correct TransactionException.
> A get in transaction may get incorrect TransactionDataNotColocatedException
> when bucket is not hosted locally
> -
>
> Key: GEODE-2088
> URL: https://issues.apache.org/jira/browse/GEODE-2088
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Reporter: Eric Shu
>
> Currently a get of a PR in transaction on a data node with TXState will first
> check if the bucket is hosted locally by following code.
> {noformat}
> public Object getLocally(int bucketId, final Object key, final Object
> aCallbackArgument,
> boolean disableCopyOnRead, boolean preferCD, ClientProxyMembershipID
> requestingClient,
> EntryEventImpl clientEvent, boolean returnTombstones, boolean
> opScopeIsLocal)
> throws PrimaryBucketException, ForceReattemptException,
> PRLocallyDestroyedException {
> final BucketRegion bucketRegion = getInitializedBucketForId(key,
> Integer.valueOf(bucketId));
> {noformat}
> The BucketNotFoundException is thrown if the node does not host the bucket:
> {noformat}
> public BucketRegion getInitializedBucketForId(Object key, Integer bucketId)
> throws ForceReattemptException {
> final BucketRegion bucketRegion =
> this.localBucket2RegionMap.get(bucketId);
> if (null == bucketRegion) {
> this.partitionedRegion.checkReadiness();
> if (logger.isDebugEnabled()) {
> logger.debug("Got null bucket region for bucketId={}{}{} for
> PartitionedRegion = {}",
> this.partitionedRegion.getPRId(),
> PartitionedRegion.BUCKET_ID_SEPARATOR, bucketId,
> this.partitionedRegion);
> }
> ForceReattemptException fre = new BucketNotFoundException(
>
> LocalizedStrings.PartitionedRegionDataStore_BUCKET_ID_0_NOT_FOUND_ON_VM_1
> .toLocalizedString(
> new Object[]
> {this.partitionedRegion.bucketStringForLogs(bucketId.intValue()),
> this.partitionedRegion.getMyId()}));
> if (key != null) {
> fre.setHash(key.hashCode());
> }
> throw fre;
> }
> {noformat}
> Currently, transaction would fail with the
> TransactionDataNotColocatedException if bucket is not on local data store
> {noformat}
> if (prce instanceof BucketNotFoundException) {
> TransactionException ex = new
> TransactionDataNotColocatedException(
>
> LocalizedStrings.PartitionedRegion_KEY_0_NOT_COLOCATED_WITH_TRANSACTION
> .toLocalizedString(key));
> ex.initCause(prce);
> throw ex;
> }
> {noformat}
> This TransactionDataNotColocatedException is fine if the node never hosts
> bucket, or only previous operations within the transaction touches replicate
> regions earlier. However, if a bucket is moved to another node due to
> rebalance, and previous entry operations within the transaction only touches
> colocated regions, the transaction should fail with
> TransactionDataRebalancedException.
> We do not have a good way currently to throw the correct exception. One idea
> is to iterate through the existing TXRegions in the TXState to see whether we
> should throw TransactionDataRebalancedException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2101) Improve WAN topology terminology in docs
[ https://issues.apache.org/jira/browse/GEODE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665433#comment-15665433 ] ASF subversion and git services commented on GEODE-2101: Commit c9e3b05405a2e82a00f9b3ac15ed259a2829a053 in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c9e3b05 ] GEODE-2101 Improve WAN topology terminology in docs The terms parallel and serial are not right, so change them: - a parallel multi-site topology is a fully connected mesh - a serial multi-site topology is a ring > Improve WAN topology terminology in docs > > > Key: GEODE-2101 > URL: https://issues.apache.org/jira/browse/GEODE-2101 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Minor > > In our documentation description of WAN topologies, the term "parallel > multi-site topology" is a fully connected mesh. The "serial multi-site > topology" is a ring. It will improve the docs to change our descriptions to > use the common and accepted terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-79) Provide utility to collect log artifacts
[ https://issues.apache.org/jira/browse/GEODE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665428#comment-15665428 ] ASF subversion and git services commented on GEODE-79: -- Commit ddc4819b01470825997b8504c0971d04ddfab2f3 in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ddc4819 ] GEODE-2105 Remove docs about log collection utility The log collection utility is not part of the release, so remove the documentation. The content removed by this commit has been placed on the feature/GEODE-79 branch. > Provide utility to collect log artifacts > > > Key: GEODE-79 > URL: https://issues.apache.org/jira/browse/GEODE-79 > Project: Geode > Issue Type: New Feature > Components: general >Reporter: Darrel Schneider >Assignee: Vincent Ford >Priority: Minor > > A utility named "gfe-sendlogs.py" exists and can be used to collect all the > log files of a distributed system so they can be easily collected and sent to > support. This task tracks the donation of the code to Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2105) Remove documentation of Log Collection Utility
[ https://issues.apache.org/jira/browse/GEODE-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665426#comment-15665426 ] ASF subversion and git services commented on GEODE-2105: Commit ddc4819b01470825997b8504c0971d04ddfab2f3 in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ddc4819 ] GEODE-2105 Remove docs about log collection utility The log collection utility is not part of the release, so remove the documentation. The content removed by this commit has been placed on the feature/GEODE-79 branch. > Remove documentation of Log Collection Utility > -- > > Key: GEODE-2105 > URL: https://issues.apache.org/jira/browse/GEODE-2105 > Project: Geode > Issue Type: Task >Reporter: Karen Smoler Miller > > The log collection utility is not part of Geode releases, so remove it from > the documentation. > https://issues.apache.org/jira/browse/GEODE-79 and the feature/GEODE-79 > branch has the code for the Log Collection Utility, but exists from a time > when the Geode docs were not yet donated to the ASF. The existing > documentation in file log_collection_utility.html.md.erb will be placed onto > that branch so it is not lost. No testing or checks will be done on the > feature/GEODE-79 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-79) Provide utility to collect log artifacts
[ https://issues.apache.org/jira/browse/GEODE-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665184#comment-15665184 ] ASF subversion and git services commented on GEODE-79: -- Commit 567fa241187ca831d42f6f815ba308e2775b171f in incubator-geode's branch refs/heads/feature/GEODE-79 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=567fa24 ] GEODE-79 Add doc file with docs of log collection utility Add file managing/logging/log_collection_utility.html from the documentation to this feature branch, such that its content is captured along with the code that implements the log collection utility. > Provide utility to collect log artifacts > > > Key: GEODE-79 > URL: https://issues.apache.org/jira/browse/GEODE-79 > Project: Geode > Issue Type: New Feature > Components: general >Reporter: Darrel Schneider >Assignee: Vincent Ford >Priority: Minor > > A utility named "gfe-sendlogs.py" exists and can be used to collect all the > log files of a distributed system so they can be easily collected and sent to > support. This task tracks the donation of the code to Geode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2102) CI Failure: DiskStoreCommandsDUnitTest.testMissingDiskStore fails assertion
[
https://issues.apache.org/jira/browse/GEODE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664646#comment-15664646
]
ASF subversion and git services commented on GEODE-2102:
Commit 8c383ee358d7b972e89458e6670395a97a27c477 in incubator-geode's branch
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=8c383ee ]
GEODE-2102: annotate flaky test with FlakyTest category
> CI Failure: DiskStoreCommandsDUnitTest.testMissingDiskStore fails assertion
> ---
>
> Key: GEODE-2102
> URL: https://issues.apache.org/jira/browse/GEODE-2102
> Project: Geode
> Issue Type: Bug
> Components: management, persistence, tests
>Reporter: Kirk Lund
> Labels: CI, Flaky
>
> This is a FlakyTest. It is a repeat offender with tickets being opened and
> closed without fixing the test. Do not close this ticket unless you actually
> rewrite the test.
> {noformat}
> java.lang.AssertionError: expected: but was:
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.geode.management.internal.cli.commands.DiskStoreCommandsDUnitTest.testMissingDiskStore(DiskStoreCommandsDUnitTest.java:225)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2074) CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
[
https://issues.apache.org/jira/browse/GEODE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664577#comment-15664577
]
ASF subversion and git services commented on GEODE-2074:
Commit 665570e438386a11f2071160e14ef3861bbfba51 in incubator-geode's branch
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=665570e ]
GEODE-2074 GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
I've run this test class hundreds of times with only one failure in
a different test. I've also run the individual test many hundreds of times
with no failures. Since the ticket didn't include any of the test
output or any information about past tests run that could have affected
this test I am closing the ticket and modifying the test's failure
text to give more information about the state of the Join/Leave processor
if the test should fail again.
This commit also includes a fix for the other test method that failed.
> CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
> -
>
> Key: GEODE-2074
> URL: https://issues.apache.org/jira/browse/GEODE-2074
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, Flaky
> Fix For: 1.1.0-incubating
>
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
> > testDuplicateJoinRequestDoesNotCauseNewView FAILED
> java.lang.RuntimeException: timeout waiting for view #7
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.waitForViewAndNoRequestsInProgress(GMSJoinLeaveJUnitTest.java:536)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView(GMSJoinLeaveJUnitTest.java:508)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2078) Fix *-dependencies jar classpath
[
https://issues.apache.org/jira/browse/GEODE-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660011#comment-15660011
]
ASF subversion and git services commented on GEODE-2078:
Commit 366f0894e6ddfdd4321cc40cdd4dcd46499a97fe in incubator-geode's branch
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=366f089 ]
GEODE-2078: Fix manifest classpath
The manifest classpath for *-dependencies.jar was pulling in
dependencies from geode-pulse and geode-web-api. Filter out those
projects before collecting the jars.
> Fix *-dependencies jar classpath
>
>
> Key: GEODE-2078
> URL: https://issues.apache.org/jira/browse/GEODE-2078
> Project: Geode
> Issue Type: Bug
> Components: build
>Reporter: Anthony Baker
>
> The dependency jars classpath include multiple versions of slf4j and
> jackson-annotations since the dependencies for geode-web-api and geode-pulse
> are used to build the classpath. Those projects should not be considered.
> {code}
> diff --git a/geode-assembly/build.gradle b/geode-assembly/build.gradle
> index cc2518b..690f677 100644
> --- a/geode-assembly/build.gradle
> +++ b/geode-assembly/build.gradle
> @@ -126,56 +126,58 @@ task defaultCacheConfig(type: JavaExec, dependsOn:
> classes) {
> def cp = {
>// first add all the dependent project jars
>def jars = configurations.archives.dependencies.collect {
> it.dependencyProject }
> -.findAll { !it.name.contains('web') }
> +.findAll { !(it.name.contains('web') || it.name.contains('pulse')) }
> .collect { it.jar.archiveName }
> .join(' ')
>
>// then add all the dependencies of the dependent jars
>jars += ' ' + configurations.archives.dependencies.collect {
> -it.dependencyProject.configurations.runtime.collect { it.getName()
> }.findAll {
> - // depedencies from geode-core
> - it.contains('antlr') ||
> - it.contains('commons-io') ||
> - it.contains('commons-lang') ||
> - it.contains('commons-logging') ||
> - it.contains('fastutil') ||
> - it.contains('jackson-annotations') ||
> - it.contains('jackson-core') ||
> - it.contains('jackson-databind') ||
> - it.contains('jansi') ||
> - it.contains('javax.resource-api') ||
> - it.contains('javax.servlet-api') ||
> - it.contains('javax.transaction-api') ||
> - it.contains('jetty-http') ||
> - it.contains('jetty-io') ||
> - it.contains('jetty-security') ||
> - it.contains('jetty-server') ||
> - it.contains('jetty-servlet') ||
> - it.contains('jetty-webapp') ||
> - it.contains('jetty-util') ||
> - it.contains('jetty-xml') ||
> - it.contains('jline') ||
> - it.contains('jna') ||
> - it.contains('jopt-simple') ||
> - it.contains('log4j-api') ||
> - it.contains('log4j-core') ||
> - it.contains('log4j-jcl') ||
> - it.contains('log4j-jul') ||
> - it.contains('log4j-slf4j-impl') ||
> - it.contains('shiro') ||
> - it.contains('slf4j-api') ||
> - it.contains('spring-core') ||
> - it.contains('spring-shell') ||
> - it.contains('snappy') ||
> - it.contains('hbase') ||
> - it.contains('jgroups') ||
> - it.contains('netty') ||
> -
> - // dependencies from geode-lucene
> - it.contains('lucene-analyzers-common') ||
> - it.contains('lucene-core') ||
> - it.contains('lucene-queries') ||
> - it.contains('lucene-queryparser')
> +it.dependencyProject.findAll { !(it.name.contains('web-api') ||
> it.name.contains('pulse')) }
> + .collect { it.configurations.runtime.collect { it.getName() }.findAll {
> +// depedencies from geode-core
> +it.contains('antlr') ||
> +it.contains('commons-io') ||
> +it.contains('commons-lang') ||
> +it.contains('commons-logging') ||
> +it.contains('fastutil') ||
> +it.contains('jackson-annotations') ||
> +it.contains('jackson-core') ||
> +it.contains('jackson-databind') ||
> +it.contains('jansi') ||
> +it.contains('javax.resource-api') ||
> +it.contains('javax.servlet-api') ||
> +it.contains('javax.transaction-api') ||
> +it.contains('jetty-http') ||
> +it.contains('jetty-io') ||
> +it.contains('jetty-security') ||
> +it.contains('jetty-server') ||
> +it.contains('jetty-servlet') ||
> +it.contains('jetty-webapp') ||
> +it.contains('jetty-util') ||
> +it.contains('jetty-xml') ||
> +it.contains('jline') ||
> +it.contains('jna') ||
> +it.contains('jopt-simple') ||
> +it.contains('log4j-api') ||
> +it.contains('log4j-core') ||
> +it.contains('log4j-jcl') ||
> +it
[jira] [Commented] (GEODE-2094) Update admin/dev REST API documentation
[ https://issues.apache.org/jira/browse/GEODE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658438#comment-15658438 ] ASF subversion and git services commented on GEODE-2094: Commit 3db9b309740ff10a7bc0bc6c4ad9bcea3124f29a in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3db9b30 ] GEODE-2094 Update admin/dev REST API documentation - Add 3 missing gfsh start server options: --http-service-port --http-service-bind-address --start-rest-api - Update examples to use these options, instead of using the older --J=-gemfire. property specification. > Update admin/dev REST API documentation > --- > > Key: GEODE-2094 > URL: https://issues.apache.org/jira/browse/GEODE-2094 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > > These 3 options for the gfsh start server command are not documented, so also > add them to the command reference page: > --http-service-port > --http-service-bind-address > --start-rest-api > The commands to start a server can be simplified in the prose on using gfsh > with REST commands. > 1. In the docs file > geode-docs/configuring/cluster_config/gfsh_remote.html.md.erb, about using > the admin REST interface, the sample gfsh start server command can be > simplified. > --J=-Dgemfire.http-service-port=8080 > becomes > --http-service-port=8080 > --J=-Dgemfire.http-service-bind-address=myremotecluster.example.com > becomes > --http-service-bind-address=myremotecluster.example.com > 2. In the docs file geode-docs/rest_apps/setup_config.html.md.erb, about > using the dev REST API, the gfsh start server commands given in steps 2 and 3 > can be simplified (corrected). > --J=-Dgemfire.start-dev-rest-api=true > becomes > --start-rest-api=true > --J=-Dgemfire.http-service-port=8080 > becomes > --http-service-port=8080 > --J=-Dgemfire.http-service-bind-address=localhost > becomes > --http-service-bind-address=localhost -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2080) Rest POST put call not working with region valueConstraint
[ https://issues.apache.org/jira/browse/GEODE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655495#comment-15655495 ] ASF subversion and git services commented on GEODE-2080: Commit d65b79a4634325edb73e2136f1e59d6879845faf in incubator-geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=d65b79a ] GEODE-2080 Rest POST put call not working with region valueConstraint If you set a value constraint on a cache Region you will be unable to store objects in the region via the Rest API. This change-set modifies LocalRegion's constraint check to look for a Rest document and use its type name in the constraint check > Rest POST put call not working with region valueConstraint > -- > > Key: GEODE-2080 > URL: https://issues.apache.org/jira/browse/GEODE-2080 > Project: Geode > Issue Type: Bug > Components: rest (dev) >Reporter: Bruce Schuchardt > > Gemfire REST POST call does not work on a region with value constraint eg If > I have a region definition like > > > > >com.support.pivotal.domain.Company > > > > and try to do a POST call like > ResponseEntity< String> result = RestClientUtils.getRestTemplate().exchange( > "http://localhost:8080/gemfire-api/v1/regionOne?key=CITI-123"; , > HttpMethod.POST, >entity, String.class); > It fails, whereas If I remove the value constraint in the region definition > it works fine. It is eaily reproducible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2091) PartitionedRegion containsValueForKey() in transaction may return false if there is a rebalance
[ https://issues.apache.org/jira/browse/GEODE-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655469#comment-15655469 ] ASF subversion and git services commented on GEODE-2091: Commit e01dbe6f557a11aa99cd6ec4da349a38a97d678e in incubator-geode's branch refs/heads/develop from [~eshu] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=e01dbe6 ] GEODE-2091: Do not return false when containsValueForKey call failed in a transaction Correctly handle exception to fail the transaction instead of returning null. Add check for colocated buckets so that correct TrasactionException can be thrown. Fix containsKey method call as well. Add test cases in dunit test. > PartitionedRegion containsValueForKey() in transaction may return false if > there is a rebalance > --- > > Key: GEODE-2091 > URL: https://issues.apache.org/jira/browse/GEODE-2091 > Project: Geode > Issue Type: Bug > Components: transactions >Reporter: Eric Shu > > PartitionedRegion containsValueForKey() in transaction may return false if > the bucket contains the entry is moved to other node due to rebalance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1993) value returned through /region/key rest service needs to be post processed
[ https://issues.apache.org/jira/browse/GEODE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655458#comment-15655458 ] ASF subversion and git services commented on GEODE-1993: Commit bd229d7681376a11ba2e37747e48844ffe65584c in incubator-geode's branch refs/heads/develop from [~kduling] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=bd229d7 ] GEODE-1993: postprocess region/key in developer rest api * This closes #276 > value returned through /region/key rest service needs to be post processed > -- > > Key: GEODE-1993 > URL: https://issues.apache.org/jira/browse/GEODE-1993 > Project: Geode > Issue Type: New Feature > Components: management >Reporter: Jinmei Liao >Assignee: Kevin Duling > Fix For: 1.1.0-incubating > > > The new rest security did not use post processor before returning the value > back to the client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2089) entry-idle-time setting on the client side cache is not working as expected
[ https://issues.apache.org/jira/browse/GEODE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655423#comment-15655423 ] ASF subversion and git services commented on GEODE-2089: Commit e584c4e658a082155613323748f4d849bc531bdb in incubator-geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=e584c4e ] GEODE-2089 entry-idle-time on client side cache is not working as expected When we pull an entry in from another cache in LocalRegion.findObjectInSystem() we end up invoking updateStatsForPut and then updateStatsForGet. The former method installs a lastModifiedTime from the version tag that came from the other cache and this is used in updateStatsForPut to schedule an expiry-task for the entry. Then updateStatsForGet is invoked to set the lastAccessed time of the entry to the current time. However, by the time this is done the entry may have already been removed by the expiry-task if the lastModified time was too far in the past. The fix is to establish both the lastModified and lastAccessed times in updateStatsForPut. I've included two of the "leaf" RegionEntry classes in the diff but all of them had to be modified in the same way. > entry-idle-time setting on the client side cache is not working as expected > > > Key: GEODE-2089 > URL: https://issues.apache.org/jira/browse/GEODE-2089 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: Bruce Schuchardt >Assignee: Bruce Schuchardt > > I wrote a unit test that sets an entry-idle-time timeout on a client cache > with action local-destroy. When the client cache pulls an old entry from the > server the cache appears to ignore the entry-idle-time and expires the entry > immediately after it is put in the cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2084) When executing a rest api in a browser, the login page presented in the browser is not setting the username/password correctly
[ https://issues.apache.org/jira/browse/GEODE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655405#comment-15655405 ] ASF subversion and git services commented on GEODE-2084: Commit aac49f3f0c17c1e396e6dbe9fb84849bd6c9b2c6 in incubator-geode's branch refs/heads/develop from [~kduling] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=aac49f3 ] GEODE-2084 - When executing a rest api in a browser, the login page presented in the browser is not setting the username/password correctly * Changed RestSecurityConfiguration to not call login(), which will bring up the browsers Authentication dialog instead. * this closes #281 > When executing a rest api in a browser, the login page presented in the > browser is not setting the username/password correctly > -- > > Key: GEODE-2084 > URL: https://issues.apache.org/jira/browse/GEODE-2084 > Project: Geode > Issue Type: Bug > Components: configuration, rest (dev) >Affects Versions: 1.0.0-incubating >Reporter: Jinmei Liao >Assignee: Kevin Duling > Fix For: 1.1.0-incubating > > > Steps to reproduce: > 1. start up a server with security > 2. in a browser address bar, type in: http:// address>:7070/geode/v1/servers, after putting in username/password, I should > see the result json, but instead, I keep getting the login page. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2050) Update documentation of statistics
[ https://issues.apache.org/jira/browse/GEODE-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655383#comment-15655383 ] ASF subversion and git services commented on GEODE-2050: Commit 89569fd3956c175d073592503a475b3d157c1579 in incubator-geode's branch refs/heads/feature/GEODE-1930 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=89569fd ] GEODE-2050 Add docs for new membership svc statistics > Update documentation of statistics > -- > > Key: GEODE-2050 > URL: https://issues.apache.org/jira/browse/GEODE-2050 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > With JGroups 3.6.10, a set of statistics have been removed. They need to be > removed from the documentation: > - "batchCopyTime", "Total amount of time, in nanoseconds, spent copying > messages for batched transmission", "nanoseconds"), > - "batchFlushTime", "Total amount of time, in nanoseconds, spent flushing > batched messages to the network", "nanoseconds"), > - "ucastFlushes", "Total number of flushes of the unicast datagram protocol, > prior to sending a multicast message", "flushes"), > - "ucastFlushTime", "Total amount of time, in nanoseconds, spent waiting for > acknowledgements for outstanding unicast datagram messages", "nanoseconds"), > - "flowControlRequests", "Total number of flow control credit requests sent > to other processes", "messages"), > - "flowControlResponses", "Total number of flow control credit responses sent > to a requestor", "messages"), > "flowControlWaitsInProgress", "Number of threads blocked waiting for > flow-control recharges from other processes", "threads"), > - "flowControlWaitTime", "Total amount of time, in nanoseconds, spent waiting > for other processes to recharge the flow of control meter", "nanoseconds"), > - "flowControlThrottleWaitsInProgress", "Number of threads blocked waiting > due to flow-control throttle requests from other members", "threads"), > - "jgNAKACKreceivedMessages", "Number of received messages awaiting stability > in NAKACK", "messages"), > - "jgNAKACKsentMessages", "Number of sent messages awaiting stability in > NAKACK", "messages"), > - "jgQueuedMessages", "Number of messages queued by transport and awaiting > processing", "messages"), *is not in the documentation* > - "jgUNICASTreceivedMessages", "Number of received messages awaiting receipt > of prior messages", "messages"), > - "jgUNICASTsentMessages", "Number of un-acked normal priority messages", > "messages"), > - "jgUNICASTsentHighPriorityMessages", "Number of un-acked high priority > messages", "messages"), > - "jgUNICASTdataReceivedTime", "Amount of time spent in JGroups UNICAST > send", "nanoseconds"), > - "jgSTABLEsuspendTime", "Amount of time JGroups STABLE is suspended", > "nanoseconds"), > - "jgSTABLEmessages", "Number of STABLE messages received by JGroups", > "messages"), > - "jgSTABLEmessagesSent", "Number of STABLE messages sent by JGroups", > "messages"), > - "jgSTABILITYmessages", "Number of STABILITY messages received by JGroups", > "messages"), > - "jgDownTime", "Down Time spent in JGroups stacks", "nanoseconds"), > - "jgUpTime", "Up Time spent in JGroups stacks", "nanoseconds"), > - "jChannelUpTime", "Up Time spent in JChannel including jgroup stack", > "nanoseconds"), > - "jgFCsendBlocks", "Number of times JGroups FC halted sends due to > backpressure", "events"), > - "jgFCautoRequests", "Number of times JGroups FC automatically sent > replenishment requests", "events"), > - "jgFCreplenish", "Number of times JGroups FC received replenishments from > receivers", "messages"), > - "jgFCresumes", "Number of times JGroups FC resumed sends due to > backpressure", "events"), > - "jgFCsentCredits", "Number of times JGroups FC sent credits to a sender", > "events"), > - "jgFCsentThrottleRequests","Number of times JGroups FC sent throttle > requests to a sender", "events"), > - "jgNAKACKwaits", "Number of delays created by NAKACK sent_msgs overflow", > "events"), *is not in the documentation* > With the new membership service, these statistics have been added. Each has > a name, a description, and a unit of measure: > - "heartbeatRequestsSent", "Heartbeat request messages that this member has > sent.", "messages"), > - "heartbeatRequestsReceived", "Heartbeat request messages that this member > has received.", "messages"), > - "heartbeatsSent", "Heartbeat messages that this member has sent.", > "messages"), > - "heartbeatsReceived", "Heartbeat messages that this member has received.", > "messages"), > - "suspectsSent", "Suspect member messages that this member has sent.", > "messages"), > - "sus
[jira] [Commented] (GEODE-2051) CI failure: RegionCloseDUnitTest.testCloseRegionOnClient
[
https://issues.apache.org/jira/browse/GEODE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655385#comment-15655385
]
ASF subversion and git services commented on GEODE-2051:
Commit 5000bbe449c5881d608cdfb0e0e3f8c2f2bb6373 in incubator-geode's branch
refs/heads/feature/GEODE-1930 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=5000bbe ]
GEODE-2051 - marking this test as flaky
> CI failure: RegionCloseDUnitTest.testCloseRegionOnClient
>
>
> Key: GEODE-2051
> URL: https://issues.apache.org/jira/browse/GEODE-2051
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Bruce Schuchardt
> Labels: ci, flaky
>
> This test closes a region in the client and then waits for the queue proxies
> in the server to shut down. In one CI run (at least) this did not happen.
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.RegionCloseDUnitTest$$Lambda$14/306382798.run
> in VM 0 running on Host a81cbe5930a0 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at
> org.apache.geode.internal.cache.tier.sockets.RegionCloseDUnitTest.testCloseRegionOnClient(RegionCloseDUnitTest.java:97)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.Nat
[jira] [Commented] (GEODE-2028) Fix license issues from 1.0.0-incubating release
[
https://issues.apache.org/jira/browse/GEODE-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655382#comment-15655382
]
ASF subversion and git services commented on GEODE-2028:
Commit 9aa7fa120781e77eaa905e63bd9f9346dfa99260 in incubator-geode's branch
refs/heads/feature/GEODE-1930 from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9aa7fa1 ]
GEODE-2028: Fix license issues from 1.0.0-incubating release
Remove bootstrap from LICENSE as v3.0.0 that we bundle is Apache
licensed.
> Fix license issues from 1.0.0-incubating release
>
>
> Key: GEODE-2028
> URL: https://issues.apache.org/jira/browse/GEODE-2028
> Project: Geode
> Issue Type: Bug
>Reporter: Anthony Baker
> Fix For: 1.1.0-incubating
>
>
> See
> http://mail-archives.apache.org/mod_mbox/incubator-general/201610.mbox/%3cca53f203-bef1-4bdb-a8b3-313ab035c...@classsoftware.com%3e
> {quote}
> - How is this this file licensed? [1]
> - Looks like the bundled version of bootstrap is Apache licensed and not MIT
> licensed as mentioned in the LICENSE file.
> - License is missing MIT/GPL licensed jQuery hashchange bundled inside this
> file [2]
> 1. ./geode-web-api/src/main/webapp/docs/css/screen.css
> 2. ./geode-web-api/src/main/webapp/docs/lib/jquery.ba-bbq.min.js
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2050) Update documentation of statistics
[ https://issues.apache.org/jira/browse/GEODE-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655386#comment-15655386 ] ASF subversion and git services commented on GEODE-2050: Commit a00a2ff2920fd273747e3852b00ec91e48b3b390 in incubator-geode's branch refs/heads/feature/GEODE-1930 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=a00a2ff ] Merge branch 'feature/GEODE-2050' into develop > Update documentation of statistics > -- > > Key: GEODE-2050 > URL: https://issues.apache.org/jira/browse/GEODE-2050 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > With JGroups 3.6.10, a set of statistics have been removed. They need to be > removed from the documentation: > - "batchCopyTime", "Total amount of time, in nanoseconds, spent copying > messages for batched transmission", "nanoseconds"), > - "batchFlushTime", "Total amount of time, in nanoseconds, spent flushing > batched messages to the network", "nanoseconds"), > - "ucastFlushes", "Total number of flushes of the unicast datagram protocol, > prior to sending a multicast message", "flushes"), > - "ucastFlushTime", "Total amount of time, in nanoseconds, spent waiting for > acknowledgements for outstanding unicast datagram messages", "nanoseconds"), > - "flowControlRequests", "Total number of flow control credit requests sent > to other processes", "messages"), > - "flowControlResponses", "Total number of flow control credit responses sent > to a requestor", "messages"), > "flowControlWaitsInProgress", "Number of threads blocked waiting for > flow-control recharges from other processes", "threads"), > - "flowControlWaitTime", "Total amount of time, in nanoseconds, spent waiting > for other processes to recharge the flow of control meter", "nanoseconds"), > - "flowControlThrottleWaitsInProgress", "Number of threads blocked waiting > due to flow-control throttle requests from other members", "threads"), > - "jgNAKACKreceivedMessages", "Number of received messages awaiting stability > in NAKACK", "messages"), > - "jgNAKACKsentMessages", "Number of sent messages awaiting stability in > NAKACK", "messages"), > - "jgQueuedMessages", "Number of messages queued by transport and awaiting > processing", "messages"), *is not in the documentation* > - "jgUNICASTreceivedMessages", "Number of received messages awaiting receipt > of prior messages", "messages"), > - "jgUNICASTsentMessages", "Number of un-acked normal priority messages", > "messages"), > - "jgUNICASTsentHighPriorityMessages", "Number of un-acked high priority > messages", "messages"), > - "jgUNICASTdataReceivedTime", "Amount of time spent in JGroups UNICAST > send", "nanoseconds"), > - "jgSTABLEsuspendTime", "Amount of time JGroups STABLE is suspended", > "nanoseconds"), > - "jgSTABLEmessages", "Number of STABLE messages received by JGroups", > "messages"), > - "jgSTABLEmessagesSent", "Number of STABLE messages sent by JGroups", > "messages"), > - "jgSTABILITYmessages", "Number of STABILITY messages received by JGroups", > "messages"), > - "jgDownTime", "Down Time spent in JGroups stacks", "nanoseconds"), > - "jgUpTime", "Up Time spent in JGroups stacks", "nanoseconds"), > - "jChannelUpTime", "Up Time spent in JChannel including jgroup stack", > "nanoseconds"), > - "jgFCsendBlocks", "Number of times JGroups FC halted sends due to > backpressure", "events"), > - "jgFCautoRequests", "Number of times JGroups FC automatically sent > replenishment requests", "events"), > - "jgFCreplenish", "Number of times JGroups FC received replenishments from > receivers", "messages"), > - "jgFCresumes", "Number of times JGroups FC resumed sends due to > backpressure", "events"), > - "jgFCsentCredits", "Number of times JGroups FC sent credits to a sender", > "events"), > - "jgFCsentThrottleRequests","Number of times JGroups FC sent throttle > requests to a sender", "events"), > - "jgNAKACKwaits", "Number of delays created by NAKACK sent_msgs overflow", > "events"), *is not in the documentation* > With the new membership service, these statistics have been added. Each has > a name, a description, and a unit of measure: > - "heartbeatRequestsSent", "Heartbeat request messages that this member has > sent.", "messages"), > - "heartbeatRequestsReceived", "Heartbeat request messages that this member > has received.", "messages"), > - "heartbeatsSent", "Heartbeat messages that this member has sent.", > "messages"), > - "heartbeatsReceived", "Heartbeat messages that this member has received.", > "messages"), > - "suspectsSent", "Suspect member messages that this member has sent.", > "messages"), > - "suspectsRe
[jira] [Commented] (GEODE-2051) CI failure: RegionCloseDUnitTest.testCloseRegionOnClient
[
https://issues.apache.org/jira/browse/GEODE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655384#comment-15655384
]
ASF subversion and git services commented on GEODE-2051:
Commit 76efb2513d4672abf137aeb00d5a67679ef30da3 in incubator-geode's branch
refs/heads/feature/GEODE-1930 from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=76efb25 ]
GEODE-2051 - marking this test as flaky
> CI failure: RegionCloseDUnitTest.testCloseRegionOnClient
>
>
> Key: GEODE-2051
> URL: https://issues.apache.org/jira/browse/GEODE-2051
> Project: Geode
> Issue Type: Bug
> Components: client queues
>Reporter: Bruce Schuchardt
> Labels: ci, flaky
>
> This test closes a region in the client and then waits for the queue proxies
> in the server to shut down. In one CI run (at least) this did not happen.
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.RegionCloseDUnitTest$$Lambda$14/306382798.run
> in VM 0 running on Host a81cbe5930a0 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at
> org.apache.geode.internal.cache.tier.sockets.RegionCloseDUnitTest.testCloseRegionOnClient(RegionCloseDUnitTest.java:97)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.Nat
[jira] [Commented] (GEODE-2050) Update documentation of statistics
[ https://issues.apache.org/jira/browse/GEODE-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655381#comment-15655381 ] ASF subversion and git services commented on GEODE-2050: Commit 4c5fca6ef20ff9c529d0adce888cd9f2302fdf7a in incubator-geode's branch refs/heads/feature/GEODE-1930 from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4c5fca6 ] GEODE-2050 Remove doc of statistics no longer present JGroups-related statistics were removed. > Update documentation of statistics > -- > > Key: GEODE-2050 > URL: https://issues.apache.org/jira/browse/GEODE-2050 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > Fix For: 1.1.0-incubating > > > With JGroups 3.6.10, a set of statistics have been removed. They need to be > removed from the documentation: > - "batchCopyTime", "Total amount of time, in nanoseconds, spent copying > messages for batched transmission", "nanoseconds"), > - "batchFlushTime", "Total amount of time, in nanoseconds, spent flushing > batched messages to the network", "nanoseconds"), > - "ucastFlushes", "Total number of flushes of the unicast datagram protocol, > prior to sending a multicast message", "flushes"), > - "ucastFlushTime", "Total amount of time, in nanoseconds, spent waiting for > acknowledgements for outstanding unicast datagram messages", "nanoseconds"), > - "flowControlRequests", "Total number of flow control credit requests sent > to other processes", "messages"), > - "flowControlResponses", "Total number of flow control credit responses sent > to a requestor", "messages"), > "flowControlWaitsInProgress", "Number of threads blocked waiting for > flow-control recharges from other processes", "threads"), > - "flowControlWaitTime", "Total amount of time, in nanoseconds, spent waiting > for other processes to recharge the flow of control meter", "nanoseconds"), > - "flowControlThrottleWaitsInProgress", "Number of threads blocked waiting > due to flow-control throttle requests from other members", "threads"), > - "jgNAKACKreceivedMessages", "Number of received messages awaiting stability > in NAKACK", "messages"), > - "jgNAKACKsentMessages", "Number of sent messages awaiting stability in > NAKACK", "messages"), > - "jgQueuedMessages", "Number of messages queued by transport and awaiting > processing", "messages"), *is not in the documentation* > - "jgUNICASTreceivedMessages", "Number of received messages awaiting receipt > of prior messages", "messages"), > - "jgUNICASTsentMessages", "Number of un-acked normal priority messages", > "messages"), > - "jgUNICASTsentHighPriorityMessages", "Number of un-acked high priority > messages", "messages"), > - "jgUNICASTdataReceivedTime", "Amount of time spent in JGroups UNICAST > send", "nanoseconds"), > - "jgSTABLEsuspendTime", "Amount of time JGroups STABLE is suspended", > "nanoseconds"), > - "jgSTABLEmessages", "Number of STABLE messages received by JGroups", > "messages"), > - "jgSTABLEmessagesSent", "Number of STABLE messages sent by JGroups", > "messages"), > - "jgSTABILITYmessages", "Number of STABILITY messages received by JGroups", > "messages"), > - "jgDownTime", "Down Time spent in JGroups stacks", "nanoseconds"), > - "jgUpTime", "Up Time spent in JGroups stacks", "nanoseconds"), > - "jChannelUpTime", "Up Time spent in JChannel including jgroup stack", > "nanoseconds"), > - "jgFCsendBlocks", "Number of times JGroups FC halted sends due to > backpressure", "events"), > - "jgFCautoRequests", "Number of times JGroups FC automatically sent > replenishment requests", "events"), > - "jgFCreplenish", "Number of times JGroups FC received replenishments from > receivers", "messages"), > - "jgFCresumes", "Number of times JGroups FC resumed sends due to > backpressure", "events"), > - "jgFCsentCredits", "Number of times JGroups FC sent credits to a sender", > "events"), > - "jgFCsentThrottleRequests","Number of times JGroups FC sent throttle > requests to a sender", "events"), > - "jgNAKACKwaits", "Number of delays created by NAKACK sent_msgs overflow", > "events"), *is not in the documentation* > With the new membership service, these statistics have been added. Each has > a name, a description, and a unit of measure: > - "heartbeatRequestsSent", "Heartbeat request messages that this member has > sent.", "messages"), > - "heartbeatRequestsReceived", "Heartbeat request messages that this member > has received.", "messages"), > - "heartbeatsSent", "Heartbeat messages that this member has sent.", > "messages"), > - "heartbeatsReceived", "Heartbeat messages that this member has received.", > "messages"), > - "suspectsSent", "Suspect member messages that this m
[jira] [Commented] (GEODE-2090) Update off-heap statistics documentation
[
https://issues.apache.org/jira/browse/GEODE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654539#comment-15654539
]
ASF subversion and git services commented on GEODE-2090:
Commit 88e5d0f154b919d1f73316cd0ea01970e40a4067 in incubator-geode's branch
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=88e5d0f ]
GEODE-2090 Update off-heap statistics documentation
- add/correct the gfsh show metrics command reference
page to include the offheap category for when the member
is specified
- in the list of OffHeapMemoryStats, correct the name of
a statistic: compactions should be defragmentations
> Update off-heap statistics documentation
>
>
> Key: GEODE-2090
> URL: https://issues.apache.org/jira/browse/GEODE-2090
> Project: Geode
> Issue Type: Bug
> Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> The {{gfsh show metrics}} command reference page is missing the optional
> {{--category=offheap}} option.
> Also, verify if the statistic {{compactions}} ought to be called
> {{defragmentations}}. If so, fix the error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1808) gemstone.gemfire.internal.cache.MinimumSystemRequirements can't handle java version 1.7.0_101
[
https://issues.apache.org/jira/browse/GEODE-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654343#comment-15654343
]
ASF subversion and git services commented on GEODE-1808:
Commit e7e372368941dc391669015716e7e03f1e163679 in incubator-geode's branch
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=e7e3723 ]
GEODE-1808 Remove broken check for jdk1.7.0_72
The logic for evaluating jdk versions is incorrect for 3-digit builds.
Since we require a jdk1.8 version anyway, remove the check.
> gemstone.gemfire.internal.cache.MinimumSystemRequirements can't handle java
> version 1.7.0_101
> -
>
> Key: GEODE-1808
> URL: https://issues.apache.org/jira/browse/GEODE-1808
> Project: Geode
> Issue Type: Bug
> Components: general
>Reporter: Sergio Valenti
>
> We have recently updated out Java version to 1.7.0_101 on our server.
> However, after starting our java component which runs Gemfire version 8, we
> get the following log line:
> | FATAL | 20160821 18:05:30,626 | main |
> gemstone.gemfire.internal.cache.MinimumSystemRequirements | Java version
> older than 1.7.0_72.
> After looking at the source, it is apparent that the issue is in
> com.gemstone.gemfire.internal.lang.SystemUtils when dealing with java
> revisions which are 3 digits long
> public static boolean isJavaVersionAtLeast(String expectedVersion)
> {
> String actualVersionDigits =
> StringUtils.getDigitsOnly(System.getProperty("java.version"));
> String expectedVersionDigits =
> StringUtils.padEnding(StringUtils.getDigitsOnly(expectedVersion), '0',
> actualVersionDigits.length());
> try
> {
> return Long.parseLong(actualVersionDigits) >=
> Long.parseLong(expectedVersionDigits);
> }
> catch(NumberFormatException ignore)
> {
> return false;
> }
> }
> If you walk through this code with an expected version of java: 1.7.0_72 and
> an actual version of java: 1.7.0_101, it will create the following two long
> variables and compare them:
> actualVersionDigits "170101"
> expectedVersionDigits "170720"
> Which causes the comparison check to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1785) generated AbstractRegionEntry subclasses can no longer be generated
[ https://issues.apache.org/jira/browse/GEODE-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652615#comment-15652615 ] ASF subversion and git services commented on GEODE-1785: Commit 2162effc8fd23b2c4648ef6f30545777bc3388e3 in incubator-geode's branch refs/heads/feature/GEODE-1895 from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2162eff ] Merge branch 'feature/GEODE-1785' into feature/GEODE-1895 > generated AbstractRegionEntry subclasses can no longer be generated > --- > > Key: GEODE-1785 > URL: https://issues.apache.org/jira/browse/GEODE-1785 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider > > A large number of the subclasses of AbstractRegionEntry are generated. > They have comments instructing developers to not modify them. For example: > /** > * Do not modify this class. It was generated. > * Instead modify LeafRegionEntry.cpp and then run > * bin/generateRegionEntryClasses.sh from the directory > * that contains your build.xml. > */ > But Geode does not include LeafRegionEntry.cpp nor > bin/generateRegionEntryClasses.sh. It also no longer has a build.xml. > This is not a show stopper since the classes can be modified in place just > like any other java file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1895) refactor code that does instanceof OffHeapRegionEntry
[ https://issues.apache.org/jira/browse/GEODE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652616#comment-15652616 ] ASF subversion and git services commented on GEODE-1895: Commit 2162effc8fd23b2c4648ef6f30545777bc3388e3 in incubator-geode's branch refs/heads/feature/GEODE-1895 from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2162eff ] Merge branch 'feature/GEODE-1785' into feature/GEODE-1895 > refactor code that does instanceof OffHeapRegionEntry > - > > Key: GEODE-1895 > URL: https://issues.apache.org/jira/browse/GEODE-1895 > Project: Geode > Issue Type: Improvement > Components: offheap >Reporter: Darrel Schneider >Assignee: Darrel Schneider > > The code has about 10 places it does "instanceof OffHeapRegionEntry." > It should be pretty easy to refactor these away. > In most of these places we can just call a method on RegionEntry that does > nothing (by default), and then override that method on OffHeapRegionEntry to > do the offheap work. > Using "default" methods on interfaces (new in JDK 1.8) should make this easy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1895) refactor code that does instanceof OffHeapRegionEntry
[ https://issues.apache.org/jira/browse/GEODE-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652434#comment-15652434 ] ASF subversion and git services commented on GEODE-1895: Commit 2f9ea5e8f22ba5fb9c4e9f39f5dae7c4863e0edc in incubator-geode's branch refs/heads/feature/GEODE-1895 from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2f9ea5e ] Merge branch 'feature/GEODE-1785' into feature/GEODE-1895 > refactor code that does instanceof OffHeapRegionEntry > - > > Key: GEODE-1895 > URL: https://issues.apache.org/jira/browse/GEODE-1895 > Project: Geode > Issue Type: Improvement > Components: offheap >Reporter: Darrel Schneider >Assignee: Darrel Schneider > > The code has about 10 places it does "instanceof OffHeapRegionEntry." > It should be pretty easy to refactor these away. > In most of these places we can just call a method on RegionEntry that does > nothing (by default), and then override that method on OffHeapRegionEntry to > do the offheap work. > Using "default" methods on interfaces (new in JDK 1.8) should make this easy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1785) generated AbstractRegionEntry subclasses can no longer be generated
[ https://issues.apache.org/jira/browse/GEODE-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652433#comment-15652433 ] ASF subversion and git services commented on GEODE-1785: Commit 2f9ea5e8f22ba5fb9c4e9f39f5dae7c4863e0edc in incubator-geode's branch refs/heads/feature/GEODE-1895 from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2f9ea5e ] Merge branch 'feature/GEODE-1785' into feature/GEODE-1895 > generated AbstractRegionEntry subclasses can no longer be generated > --- > > Key: GEODE-1785 > URL: https://issues.apache.org/jira/browse/GEODE-1785 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Darrel Schneider >Assignee: Darrel Schneider > > A large number of the subclasses of AbstractRegionEntry are generated. > They have comments instructing developers to not modify them. For example: > /** > * Do not modify this class. It was generated. > * Instead modify LeafRegionEntry.cpp and then run > * bin/generateRegionEntryClasses.sh from the directory > * that contains your build.xml. > */ > But Geode does not include LeafRegionEntry.cpp nor > bin/generateRegionEntryClasses.sh. It also no longer has a build.xml. > This is not a show stopper since the classes can be modified in place just > like any other java file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1570) developer REST API should be secured
[ https://issues.apache.org/jira/browse/GEODE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651705#comment-15651705 ] ASF subversion and git services commented on GEODE-1570: Commit 7973d578ec16b8c9d185d8e291193b8828fde856 in incubator-geode's branch refs/heads/develop from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=7973d57 ] GEODE-1570: add a test to verify rest security with SSL, fix the format. > developer REST API should be secured > > > Key: GEODE-1570 > URL: https://issues.apache.org/jira/browse/GEODE-1570 > Project: Geode > Issue Type: Sub-task > Components: rest (dev), security >Reporter: Swapnil Bawaskar >Assignee: Kevin Duling > Fix For: 1.0.0-incubating > > > The developer REST API should require authentication when security is > enabled. For authorization, the implementation should use the new > Resource:Operation permissions API that is used by JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1883) AuthInitializer should be made optional
[
https://issues.apache.org/jira/browse/GEODE-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651334#comment-15651334
]
ASF subversion and git services commented on GEODE-1883:
Commit d54080aa48194e6861d1e463b6ab5e70c39a80e6 in incubator-geode's branch
refs/heads/feature/GEODE-1883 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=d54080a ]
GEODE-1883: make auth-init optional
* Failed Tests:
CQClientAuthDunitTest. testPostProcess
ClientCQPostAuthorizationDUnitTest. testAllowCQForAllMultiusers
ClientCQPostAuthorizationDUnitTest. testAllowCQForAllMultiusersWithFailover
ClientCQPostAuthorizationDUnitTest. testDisallowCQForAllMultiusers
ClientCQPostAuthorizationDUnitTest. testDisallowCQForSomeMultiusers
ClientMultiUserAuthzDUnitTest. testOps1
ClientMultiUserAuthzDUnitTest. testOps2
ClientMultiUserAuthzDUnitTest. testOpsWithClientsInDifferentModes
MultiUserDurableCQAuthzDUnitTest. testCQForDurableClientsWithCloseKeepAliveFalse
MultiUserDurableCQAuthzDUnitTest. testCQForDurableClientsWithCloseKeepAliveTrue
MultiUserDurableCQAuthzDUnitTest. testCQForDurableClientsWithDefaultClose
> AuthInitializer should be made optional
> ---
>
> Key: GEODE-1883
> URL: https://issues.apache.org/jira/browse/GEODE-1883
> Project: Geode
> Issue Type: New Feature
> Components: docs, management
>Reporter: Swapnil Bawaskar
>
> {{AuthInitializer}} is the interface that a client must implement that
> provides credentials that are verified by the server. The same interface is
> also used for peer authentication.
> In order to configure {{AuthInitialize}} any Geode property starting with
> {{security-}} is passed through to the {{AuthInitialize.getCredentials}}
> method.
> For simple authentication where only a username and a password are required,
> users should not really be required to implement the AuthInitialize interface
> in the presence of property passthrough.
> Geode should detect {{security-username}} and {{security-password}}
> properties in gemfire.security OR gfsecurity.properties file and use those
> for authentication.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2014) Upgrade Swagger libraries
[ https://issues.apache.org/jira/browse/GEODE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651327#comment-15651327 ] ASF subversion and git services commented on GEODE-2014: Commit 5907e988bfa56550cb8faae789dec564c3ed5d43 in incubator-geode's branch refs/heads/develop from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=5907e98 ] GEODE-2014: explicitly declare spring-web as a direct dependency rather than a transitive one. > Upgrade Swagger libraries > - > > Key: GEODE-2014 > URL: https://issues.apache.org/jira/browse/GEODE-2014 > Project: Geode > Issue Type: Improvement > Components: docs, rest (dev) >Affects Versions: 1.0.0-incubating >Reporter: Kevin Duling >Assignee: Kevin Duling > Fix For: 1.1.0-incubating > > > Upgrade swagger and swagger-springmvc -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1570) developer REST API should be secured
[ https://issues.apache.org/jira/browse/GEODE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651318#comment-15651318 ] ASF subversion and git services commented on GEODE-1570: Commit a515ee06deeca3adf0ba053883a488787267ebcb in incubator-geode's branch refs/heads/develop from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=a515ee0 ] GEODE-1570: add a test to verify rest security with SSL. > developer REST API should be secured > > > Key: GEODE-1570 > URL: https://issues.apache.org/jira/browse/GEODE-1570 > Project: Geode > Issue Type: Sub-task > Components: rest (dev), security >Reporter: Swapnil Bawaskar >Assignee: Kevin Duling > Fix For: 1.0.0-incubating > > > The developer REST API should require authentication when security is > enabled. For authorization, the implementation should use the new > Resource:Operation permissions API that is used by JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2070) Improve documentation of region management
[ https://issues.apache.org/jira/browse/GEODE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648857#comment-15648857 ] ASF subversion and git services commented on GEODE-2070: Commit 95f56b0b2eeb0be73d7f9f1cd361f0ba5c11bb0a in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=95f56b0 ] GEODE-2070 Improve documentation of region management > Improve documentation of region management > -- > > Key: GEODE-2070 > URL: https://issues.apache.org/jira/browse/GEODE-2070 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > > The outline and navigation of the material on regions is > Basic Configuration and Programming > Data Regions > Data Region Management > Creating a Region with gfsh > Creating a Region Through the cache.xml File > Creating a Region Through the API > ... > The information in the 3 'Creating' sections is partially covered in the > Data Region Management section. Reorganize and collapse into a single > section on management that covers region management the 3 ways: > 1. APIs > 2. cache.xml declaration > 3. gfsh -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2070) Improve documentation of region management
[ https://issues.apache.org/jira/browse/GEODE-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648858#comment-15648858 ] ASF subversion and git services commented on GEODE-2070: Commit 9dfb4ac2fa9b5388a745fdd0aa2ba25058d95c2e in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9dfb4ac ] Merge branch 'feature/GEODE-2070' into develop > Improve documentation of region management > -- > > Key: GEODE-2070 > URL: https://issues.apache.org/jira/browse/GEODE-2070 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > > The outline and navigation of the material on regions is > Basic Configuration and Programming > Data Regions > Data Region Management > Creating a Region with gfsh > Creating a Region Through the cache.xml File > Creating a Region Through the API > ... > The information in the 3 'Creating' sections is partially covered in the > Data Region Management section. Reorganize and collapse into a single > section on management that covers region management the 3 ways: > 1. APIs > 2. cache.xml declaration > 3. gfsh -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2068) Improve documentation on serial/parallel gateway senders
[ https://issues.apache.org/jira/browse/GEODE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648836#comment-15648836 ] ASF subversion and git services commented on GEODE-2068: Commit 9092b4d79f1ae96fc4d3f677d09946e96b573a5e in incubator-geode's branch refs/heads/develop from [~karensmolermiller] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9092b4d ] GEODE-2068 Improve documentation on serial/parallel gateway senders No parallel senders for distributed regions. > Improve documentation on serial/parallel gateway senders > > > Key: GEODE-2068 > URL: https://issues.apache.org/jira/browse/GEODE-2068 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller > > The documentation on Serial Gateway Senders implies that the events queued > are generated from a single server. Not true. The events generated from a > cluster are funneled through a single server. > For the material on Parallel Gateway Senders, the terminology "simultaneous" > implies timing, and we don't coordinate the timing of when events are sent. > What we're doing is to identify that an event is sent from the server that > hosts the primary bucket. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2005) gradle javadoc is reporting warnings
[ https://issues.apache.org/jira/browse/GEODE-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648466#comment-15648466 ] ASF subversion and git services commented on GEODE-2005: Commit e7d5c6aaf0a688546fe8be5b84b80f80f7bda73b in incubator-geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=e7d5c6a ] GEODE-2005: Fix javadocs warnings in IntegratedSecurityService > gradle javadoc is reporting warnings > > > Key: GEODE-2005 > URL: https://issues.apache.org/jira/browse/GEODE-2005 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Kirk Lund >Assignee: Kirk Lund > Fix For: 1.1.0-incubating > > > Latest warning: > :geode-web-api:javadoc/tmp/build/ae3c03f4/geode/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java:196: > warning - @return tag has no arguments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2082) CI Failure: DiskSpaceLimitIntegrationTest.sameKeepsOneFile fails intermittently
[ https://issues.apache.org/jira/browse/GEODE-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645842#comment-15645842 ] ASF subversion and git services commented on GEODE-2082: Commit 35f92e074e4b7e24c471e9b37d2f5fe08a0d9cd7 in incubator-geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=35f92e0 ] GEODE-2082: rename aboveZeroKeepsAtLeastOneFile to aboveZeroDeletesOldestFile > CI Failure: DiskSpaceLimitIntegrationTest.sameKeepsOneFile fails > intermittently > --- > > Key: GEODE-2082 > URL: https://issues.apache.org/jira/browse/GEODE-2082 > Project: Geode > Issue Type: Bug > Components: tests >Affects Versions: 1.1.0-incubating >Reporter: Kirk Lund >Assignee: Kirk Lund > Labels: CI, Flaky > > DiskSpaceLimitIntegrationTest.sameKeepsOneFile is file-system sensitive. It > passes on one file-system and then fails on another. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2082) CI Failure: DiskSpaceLimitIntegrationTest.sameKeepsOneFile fails intermittently
[ https://issues.apache.org/jira/browse/GEODE-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645836#comment-15645836 ] ASF subversion and git services commented on GEODE-2082: Commit 64da18de4fb64f59eab537fb7d01edf8d1117a9b in incubator-geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=64da18d ] GEODE-2082: fix flakiness in sameKeepsOneFile * rename sameKeepsOneFile to aboveZeroKeepsAtLeastOneFile > CI Failure: DiskSpaceLimitIntegrationTest.sameKeepsOneFile fails > intermittently > --- > > Key: GEODE-2082 > URL: https://issues.apache.org/jira/browse/GEODE-2082 > Project: Geode > Issue Type: Bug > Components: tests >Affects Versions: 1.1.0-incubating >Reporter: Kirk Lund >Assignee: Kirk Lund > Labels: CI, Flaky > > DiskSpaceLimitIntegrationTest.sameKeepsOneFile is file-system sensitive. It > passes on one file-system and then fails on another. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2077) getFromBucket() in PartitionedRegion with transaction sometimes returns null when it failed with certain e
[ https://issues.apache.org/jira/browse/GEODE-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645745#comment-15645745 ] ASF subversion and git services commented on GEODE-2077: Commit 89c522ad6ff75766c6ee80d0c45e995d571a57f2 in incubator-geode's branch refs/heads/develop from [~eshu] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=89c522a ] GEODE-2077: Throw appropriate exceptions when get op in a transaction failed instead of return null. Also added a dunit test which fails without the fix. > getFromBucket() in PartitionedRegion with transaction sometimes returns null > when it failed with certain e > -- > > Key: GEODE-2077 > URL: https://issues.apache.org/jira/browse/GEODE-2077 > Project: Geode > Issue Type: Bug > Components: transactions >Reporter: Eric Shu >Assignee: Eric Shu > > getFromBucket() in PartitionedRegion with transaction should throw exception > back to indicate region.get() call failed. Transaction could then be retried > if necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1971) Hang in node simultaneously creating and shutting down with shutdownAll
[
https://issues.apache.org/jira/browse/GEODE-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645572#comment-15645572
]
ASF subversion and git services commented on GEODE-1971:
Commit 02d962c20830e2d35347af3cc718eb3ccb3a40f4 in incubator-geode's branch
refs/heads/develop from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=02d962c ]
GEODE-1971: fix shutDownAll hang
changed to an AtomicBoolean, remove cache sync on addPartitionedRegion and
requiresNotificationFromPR
> Hang in node simultaneously creating and shutting down with shutdownAll
> ---
>
> Key: GEODE-1971
> URL: https://issues.apache.org/jira/browse/GEODE-1971
> Project: Geode
> Issue Type: Bug
> Components: core, persistence
>Reporter: Bruce Schuchardt
>Assignee: Darrel Schneider
>
> A new member of the distributed system was in the middle of creating its
> cache when it received a shutdownAll request. Due to lock inversion between
> the two threads performing these operations the shutdownAll hung.
> The two threads were in this state:
> {noformat}
> "Pooled Message Processor 2":
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.close(GemFireCacheImpl.java:1966)
> - waiting to lock <0xf730a958> (a java.lang.Class for
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl)
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.shutDownAll(GemFireCacheImpl.java:1662)
> - locked <0xf730aa28> (a
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl)
> at
> com.gemstone.gemfire.internal.admin.remote.ShutdownAllRequest.createResponse(ShutdownAllRequest.java:175)
> at
> com.gemstone.gemfire.internal.admin.remote.AdminRequest.process(AdminRequest.java:139)
> at
> com.gemstone.gemfire.internal.admin.remote.ShutdownAllRequest.process(ShutdownAllRequest.java:134)
> at
> com.gemstone.gemfire.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:378)
> at
> com.gemstone.gemfire.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:449)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at
> com.gemstone.gemfire.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:603)
> at
> com.gemstone.gemfire.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:862)
> at java.lang.Thread.run(Thread.java:745)
> "vm_8_thr_14_dataStore5_client-07_29751":
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.initializePdxRegistry(GemFireCacheImpl.java:1356)
> - waiting to lock <0xf730aa28> (a
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl)
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1297)
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1123)
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:764)
> - locked <0xf730a958> (a java.lang.Class for
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl)
> at
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:751)
> at
> com.gemstone.gemfire.cache.CacheFactory.create(CacheFactory.java:181)
> - locked <0xf731be40> (a java.lang.Class for
> com.gemstone.gemfire.cache.CacheFactory)
> at
> com.gemstone.gemfire.cache.CacheFactory.create(CacheFactory.java:231)
> - locked <0xf731be40> (a java.lang.Class for
> com.gemstone.gemfire.cache.CacheFactory)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:50)
> at hydra.CacheHelper.createCache(CacheHelper.java:100)
> - locked <0xf731bf18> (a java.lang.Class for
> hydra.CacheHelper)
> at
> diskRecovery.StartupShutdownTest.HydraTask_initialize(StartupShutdownTest.java:169)
> - locked <0xf731bce8> (a java.lang.Class for
> diskRecovery.StartupShutdownTest)
> at
> diskRecovery.StartupShutdownTest.HydraTask_initializeDuringShutDownAll(StartupShutdownTest.java:187)
> - locked <0xf731bce8> (a java.lang.Class for
> diskRecovery.StartupShutdownTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccess
[jira] [Commented] (GEODE-2063) testConcurrentMultiIndexCreationAndQuery CacheClosedException
[
https://issues.apache.org/jira/browse/GEODE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645521#comment-15645521
]
ASF subversion and git services commented on GEODE-2063:
Commit a20a6ba098ae2418134fc0deb42da3dcda8ea97c in incubator-geode's branch
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=a20a6ba ]
GEODE-2063: Increased the timeout on async thread join
* Increase the time for the main thread to wait for the async operation
to complete.
> testConcurrentMultiIndexCreationAndQuery CacheClosedException
> --
>
> Key: GEODE-2063
> URL: https://issues.apache.org/jira/browse/GEODE-2063
> Project: Geode
> Issue Type: Task
> Components: querying
>Reporter: nabarun
>Assignee: nabarun
>
> Here the timeout to wait for the asynchronous operation is 6 seconds, which
> is very less. When it times out, the test start shutting down all components
> and this leads to cascading exceptions in different threads.
> {noformat}
> java.lang.AssertionError: Thread did not terminate after 6000 ms: Thread[call
> invoked on an instance of
> org.apache.geode.cache.query.internal.index.MultiIndexCreationDUnitTest$1,5,Async
> Invocations]
> at org.junit.Assert.fail(Assert.java:88)
> at org.apache.geode.test.dunit.ThreadUtils.join(ThreadUtils.java:147)
> at org.apache.geode.test.dunit.ThreadUtils.join(ThreadUtils.java:110)
> at
> org.apache.geode.cache.query.internal.index.MultiIndexCreationDUnitTest.testConcurrentMultiIndexCreationAndQuery(MultiIndexCreationDUnitTest.java:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source
[jira] [Commented] (GEODE-2064) Unable to detect system shutdown during message delivery.
[ https://issues.apache.org/jira/browse/GEODE-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645368#comment-15645368 ] ASF subversion and git services commented on GEODE-2064: Commit 0a96cbd9ade0023a68d1487c90e892978ded79cc in incubator-geode's branch refs/heads/develop from [~agingade] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=0a96cbd ] GEODE-2064: Added check for system shutdown while handlling connect exception While message send in progress, if the system gets shutdown (forced disconnect), the send (message delivery to peers) reports connect exception and ignores detecting/throwing SystemDisconnect exception. This results in client missing an event and resulting in data mismatch between client and server. Made changes to throw "DistributedSystemDisconnectedException" if system is shutting down. This will result in caller to retry the operation. > Unable to detect system shutdown during message delivery. > - > > Key: GEODE-2064 > URL: https://issues.apache.org/jira/browse/GEODE-2064 > Project: Geode > Issue Type: Bug > Components: messaging >Reporter: Anilkumar Gingade >Assignee: Anilkumar Gingade > > While message send in progress, if the system gets shutdown (forced > disconnect), the send (message delivery to peers) reports connect exception > and ignores detecting/throwing SystemDisconnect exception. > In "DirectChannel.getConnection()" it checks for "mgr.shutdownInProgress()" > and returns ConnectException to the caller > "GMSMembershipManager.directChannelSend()" > In client/server scenario, if the client is performing cache operation, the > cache operation may succeed in server that is getting down and failure to > deliver the message to other peers/servers. The client will see the operation > getting successfully completed. > The above scenario could result in client missing an event and resulting in > data mismatch between client and server. > Consider scenario: > -- 2 servers, server1 and server2 in distributed system. > -- client1 has subscribed for events, with its primary queue on server1 and > secondary queue on server2. > -- client2 does an put with Key1 on server1. > -- the server1 sends the event to client1 (client1 now has key1) and while > sending the message to server 2, it gets disconnected. While shutdown in > progress, its unable to deliver the message to server2 and instead of > throwing the exception to client, it responds to client with success. The > client1 now fails-over to server1; its out of sync with server1 cache (which > doesn't has key1). > Solution: By throwing the disconnect exception back to the caller. This > enables the caller (client) to retry the operation on the live server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1985) IndexManager.needsRecalculation can miss cases where recalulation is needed
[ https://issues.apache.org/jira/browse/GEODE-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645358#comment-15645358 ] ASF subversion and git services commented on GEODE-1985: Commit 2e1a8c420fd984bdcc605ababe93b0e6c6b29919 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2e1a8c4 ] GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes This is a fix for pretty specific race condition 1) T1 does a put and gets to the point of calling setIndexBufferTime, but hasn't updated the indexes 2) T2 starts a query and finds the entry in the index even though the value no longer matches the query 3) T1 finishes the put 4) T2 checks to see if should revaluate the entry, but decides not to because based on the SAFE_QUERY_TIME value the entry changed before the query started. By moving the update to SAFE_QUERY_TIME down, the if the an entry doesn't need reevaluation based on the SAFE_QUERY_TIME, we know the index was updated before the query started. There is currently an updateInProgress flag to handle the issue of the query executing before the SAFE_QUERY_TIME is updated. If the entry is updated, but not the index, the updateInProgress flag will be set. > IndexManager.needsRecalculation can miss cases where recalulation is needed > --- > > Key: GEODE-1985 > URL: https://issues.apache.org/jira/browse/GEODE-1985 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.1.0-incubating > > > When returning query results from an index, we check > IndexManager.needsRecalculation to see if an entry might have changed while > the query was in progress. > Unfortunately, this method can return false negatives If an entry has not yet > updated the SAFE_QUERY_TIME field. > The SAFE_QUERY_TIME is updated in LocalRegion.updateStatsForPut. That method > is called *after* the region entry was modified. So the SAFE_QUERY_TIME could > be 0, even though an entry was modified, which will make this expression > false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1985) IndexManager.needsRecalculation can miss cases where recalulation is needed
[ https://issues.apache.org/jira/browse/GEODE-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645357#comment-15645357 ] ASF subversion and git services commented on GEODE-1985: Commit 4c0d302fcacdc338d967c2fb873c05d0a52f109f in incubator-geode's branch refs/heads/feature/GEODE-288 from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4c0d302 ] GEODE-1985 Removing some string comparisons in the AttributesDescriptor Optimizing the attributes descriptor by removing some string comparisons. > IndexManager.needsRecalculation can miss cases where recalulation is needed > --- > > Key: GEODE-1985 > URL: https://issues.apache.org/jira/browse/GEODE-1985 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.1.0-incubating > > > When returning query results from an index, we check > IndexManager.needsRecalculation to see if an entry might have changed while > the query was in progress. > Unfortunately, this method can return false negatives If an entry has not yet > updated the SAFE_QUERY_TIME field. > The SAFE_QUERY_TIME is updated in LocalRegion.updateStatsForPut. That method > is called *after* the region entry was modified. So the SAFE_QUERY_TIME could > be 0, even though an entry was modified, which will make this expression > false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2079) CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL
[ https://issues.apache.org/jira/browse/GEODE-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645359#comment-15645359 ] ASF subversion and git services commented on GEODE-2079: Commit b4077414ef859b627c7961d86b4704c2034ebfb1 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b407741 ] GEODE-2079: mark the test as flaky > CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL > - > > Key: GEODE-2079 > URL: https://issues.apache.org/jira/browse/GEODE-2079 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Jinmei Liao > Labels: CI, flaky > > org.apache.geode.InternalGemFireError > at org.apache.geode.internal.Assert.throwError(Assert.java:96) > at org.apache.geode.internal.Assert.assertTrue(Assert.java:56) > at > org.apache.geode.management.ConnectToLocatorSSLDUnitTest.setUpLocatorAndConnect(ConnectToLocatorSSLDUnitTest.java:132) > at > org.apache.geode.management.ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL(ConnectToLocatorSSLDUnitTest.java:118) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAc
[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
[ https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645356#comment-15645356 ] ASF subversion and git services commented on GEODE-1821: Commit 2993e6d6fac49b5601fde5d740b0ff81712f8977 in incubator-geode's branch refs/heads/feature/GEODE-288 from [~khowe] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2993e6d ] GEODE-1821: Adjust timing to wait for async thread This closes #279 > CI Failure: > PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions > --- > > Key: GEODE-1821 > URL: https://issues.apache.org/jira/browse/GEODE-1821 > Project: Geode > Issue Type: Bug > Components: persistence, regions >Reporter: Anilkumar Gingade >Assignee: Kenneth Howe > Fix For: 1.1.0-incubating > > > Build #3755 (Aug 24, 2016 5:09:20 AM) > Revision: 37269735eec44f51ee53075718afe2fa85edc22e > refs/remotes/origin/develop > Error Message > java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds > for AsyncInvocation to complete. > Stacktrace > java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds > for AsyncInvocation to complete. > at > com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443) > at > com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390) > at > com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93
[jira] [Commented] (GEODE-2074) CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
[
https://issues.apache.org/jira/browse/GEODE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645355#comment-15645355
]
ASF subversion and git services commented on GEODE-2074:
Commit 9f0919f09f7fe2b977955f83fae95b1a3d174d18 in incubator-geode's branch
refs/heads/feature/GEODE-288 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9f0919f ]
GEODE-2074: annotate flaky test with FlakyTest category
> CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
> -
>
> Key: GEODE-2074
> URL: https://issues.apache.org/jira/browse/GEODE-2074
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, Flaky
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
> > testDuplicateJoinRequestDoesNotCauseNewView FAILED
> java.lang.RuntimeException: timeout waiting for view #7
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.waitForViewAndNoRequestsInProgress(GMSJoinLeaveJUnitTest.java:536)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView(GMSJoinLeaveJUnitTest.java:508)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2072) CI Failure: TestFunctionsDUnitTest.testNumOfRunningFunctions
[
https://issues.apache.org/jira/browse/GEODE-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645353#comment-15645353
]
ASF subversion and git services commented on GEODE-2072:
Commit 3154cb406799e928c9f9911dcbbc6607efb83a5d in incubator-geode's branch
refs/heads/feature/GEODE-288 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3154cb4 ]
GEODE-2072: annotate flaky test with FlakyTest category
> CI Failure: TestFunctionsDUnitTest.testNumOfRunningFunctions
>
>
> Key: GEODE-2072
> URL: https://issues.apache.org/jira/browse/GEODE-2072
> Project: Geode
> Issue Type: Bug
> Components: management, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Labels: CI, Flaky
>
> {noformat}
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest >
> testNumOfRunningFunctions FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest$$Lambda$15/1807889435.call
> in VM 0 running on Host a00f4285b6a8 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:282)
> at
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest.testNumOfRunningFunctions(TestFunctionsDUnitTest.java:100)
> Caused by:
> java.lang.AssertionError: Event never occurred after 12 ms: wait
> for getNumOfRunningFunction to complete and get results
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
> at
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest.getNumOfRunningFunction(TestFunctionsDUnitTest.java:77)
> at
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest.lambda$testNumOfRunningFunctions$5c4d653a$1(TestFunctionsDUnitTest.java:100)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2073) CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
[
https://issues.apache.org/jira/browse/GEODE-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645354#comment-15645354
]
ASF subversion and git services commented on GEODE-2073:
Commit 88b563bdc0f4cee0cede20ba6e8af106ec54d0ac in incubator-geode's branch
refs/heads/feature/GEODE-288 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=88b563b ]
GEODE-2073: annotate flaky test with FlakyTest category
> CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
>
>
> Key: GEODE-2073
> URL: https://issues.apache.org/jira/browse/GEODE-2073
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, flaky
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest
> > testHMNextNeighborAfterTimeout FAILED
> java.lang.AssertionError: expected
> 09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8893 but found
> 09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8892. view=null
> expected:<09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8893> but
> was:<09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8892>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout(GMSHealthMonitorJUnitTest.java:183)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1874) setNextNeighbor method allocates a HashSet on every p2p message received
[
https://issues.apache.org/jira/browse/GEODE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645308#comment-15645308
]
ASF subversion and git services commented on GEODE-1874:
Commit b3d3285088c1c3950ba9c8e638e02ca8b852bd01 in incubator-geode's branch
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b3d3285 ]
GEODE-1874: Changed setNextNeighbor to not create HashMap for every p2p
invocation
> setNextNeighbor method allocates a HashSet on every p2p message received
>
>
> Key: GEODE-1874
> URL: https://issues.apache.org/jira/browse/GEODE-1874
> Project: Geode
> Issue Type: Bug
> Components: messaging
>Reporter: Darrel Schneider
>Assignee: Udo Kohlmeyer
>
> Every time a peer receives a message it ends up calling setNextNeighbor in
> com.gemstone.gemfire.distributed.internal.membership.gms.fd.GMSHealthMonitor.
> This method always allocates and add all the existing members to it just so
> it can figure out if all other members are suspected.
> I was doing performance analysis of a PR get test and this HashSet resulted
> in a 10% decrease in the put rate.
> It is not clear why setNextNeighbor is even being called by contactedBy since
> the actual view did not change. So one possible fix would be to not call
> setNextNeighbor from contactedBy.
> But here is an optimization of setNextNeighbor that prevents any work from
> being done if the sizes indicate that not all other members are suspects.
> When it does need to check the new code just reads the existing state instead
> of allocating and adding to a new HashSet:
> {noformat}
> diff --git
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> index 9fdbb64..fcb2826 100644
> ---
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> +++
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> @@ -818,13 +818,22 @@ public class GMSHealthMonitor implements HealthMonitor,
> MessageHandler {
>
> List allMembers = newView.getMembers();
>
> -Set checkAllSuspected = new
> HashSet<>(allMembers);
> -checkAllSuspected.removeAll(suspectedMemberInView.keySet());
> -checkAllSuspected.remove(localAddress);
> -if (checkAllSuspected.isEmpty() && allMembers.size() > 1) {
> - logger.info("All other members are suspect at this point");
> - nextNeighbor = null;
> - return;
> +if (allMembers.size() > 1 && suspectedMemberInView.size() >=
> allMembers.size()-1) {
> + boolean nonSuspectFound = false;
> + for (InternalDistributedMember member: allMembers) {
> +if (member.equals(localAddress)) {
> + continue;
> +}
> +if (!suspectedMemberInView.containsKey(member)) {
> + nonSuspectFound = true;
> + break;
> +}
> + }
> + if (!nonSuspectFound) {
> +logger.info("All other members are suspect at this point");
> +nextNeighbor = null;
> +return;
> + }
> }
>
> int index = allMembers.indexOf(nextTo);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1874) setNextNeighbor method allocates a HashSet on every p2p message received
[
https://issues.apache.org/jira/browse/GEODE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645312#comment-15645312
]
ASF subversion and git services commented on GEODE-1874:
Commit 1661504f2944870d59a8c545bba80dfc19a58b94 in incubator-geode's branch
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=1661504 ]
GEODE-1874: Checkin after code formatting refactor
> setNextNeighbor method allocates a HashSet on every p2p message received
>
>
> Key: GEODE-1874
> URL: https://issues.apache.org/jira/browse/GEODE-1874
> Project: Geode
> Issue Type: Bug
> Components: messaging
>Reporter: Darrel Schneider
>Assignee: Udo Kohlmeyer
>
> Every time a peer receives a message it ends up calling setNextNeighbor in
> com.gemstone.gemfire.distributed.internal.membership.gms.fd.GMSHealthMonitor.
> This method always allocates and add all the existing members to it just so
> it can figure out if all other members are suspected.
> I was doing performance analysis of a PR get test and this HashSet resulted
> in a 10% decrease in the put rate.
> It is not clear why setNextNeighbor is even being called by contactedBy since
> the actual view did not change. So one possible fix would be to not call
> setNextNeighbor from contactedBy.
> But here is an optimization of setNextNeighbor that prevents any work from
> being done if the sizes indicate that not all other members are suspects.
> When it does need to check the new code just reads the existing state instead
> of allocating and adding to a new HashSet:
> {noformat}
> diff --git
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> index 9fdbb64..fcb2826 100644
> ---
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> +++
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> @@ -818,13 +818,22 @@ public class GMSHealthMonitor implements HealthMonitor,
> MessageHandler {
>
> List allMembers = newView.getMembers();
>
> -Set checkAllSuspected = new
> HashSet<>(allMembers);
> -checkAllSuspected.removeAll(suspectedMemberInView.keySet());
> -checkAllSuspected.remove(localAddress);
> -if (checkAllSuspected.isEmpty() && allMembers.size() > 1) {
> - logger.info("All other members are suspect at this point");
> - nextNeighbor = null;
> - return;
> +if (allMembers.size() > 1 && suspectedMemberInView.size() >=
> allMembers.size()-1) {
> + boolean nonSuspectFound = false;
> + for (InternalDistributedMember member: allMembers) {
> +if (member.equals(localAddress)) {
> + continue;
> +}
> +if (!suspectedMemberInView.containsKey(member)) {
> + nonSuspectFound = true;
> + break;
> +}
> + }
> + if (!nonSuspectFound) {
> +logger.info("All other members are suspect at this point");
> +nextNeighbor = null;
> +return;
> + }
> }
>
> int index = allMembers.indexOf(nextTo);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1874) setNextNeighbor method allocates a HashSet on every p2p message received
[
https://issues.apache.org/jira/browse/GEODE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645309#comment-15645309
]
ASF subversion and git services commented on GEODE-1874:
Commit 5b0c56504080f19064e677d79aecf880cd80d091 in incubator-geode's branch
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=5b0c565 ]
GEODE-1874: Changed setNextNeighbor to not create HashMap for every p2p
invocation
> setNextNeighbor method allocates a HashSet on every p2p message received
>
>
> Key: GEODE-1874
> URL: https://issues.apache.org/jira/browse/GEODE-1874
> Project: Geode
> Issue Type: Bug
> Components: messaging
>Reporter: Darrel Schneider
>Assignee: Udo Kohlmeyer
>
> Every time a peer receives a message it ends up calling setNextNeighbor in
> com.gemstone.gemfire.distributed.internal.membership.gms.fd.GMSHealthMonitor.
> This method always allocates and add all the existing members to it just so
> it can figure out if all other members are suspected.
> I was doing performance analysis of a PR get test and this HashSet resulted
> in a 10% decrease in the put rate.
> It is not clear why setNextNeighbor is even being called by contactedBy since
> the actual view did not change. So one possible fix would be to not call
> setNextNeighbor from contactedBy.
> But here is an optimization of setNextNeighbor that prevents any work from
> being done if the sizes indicate that not all other members are suspects.
> When it does need to check the new code just reads the existing state instead
> of allocating and adding to a new HashSet:
> {noformat}
> diff --git
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> index 9fdbb64..fcb2826 100644
> ---
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> +++
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> @@ -818,13 +818,22 @@ public class GMSHealthMonitor implements HealthMonitor,
> MessageHandler {
>
> List allMembers = newView.getMembers();
>
> -Set checkAllSuspected = new
> HashSet<>(allMembers);
> -checkAllSuspected.removeAll(suspectedMemberInView.keySet());
> -checkAllSuspected.remove(localAddress);
> -if (checkAllSuspected.isEmpty() && allMembers.size() > 1) {
> - logger.info("All other members are suspect at this point");
> - nextNeighbor = null;
> - return;
> +if (allMembers.size() > 1 && suspectedMemberInView.size() >=
> allMembers.size()-1) {
> + boolean nonSuspectFound = false;
> + for (InternalDistributedMember member: allMembers) {
> +if (member.equals(localAddress)) {
> + continue;
> +}
> +if (!suspectedMemberInView.containsKey(member)) {
> + nonSuspectFound = true;
> + break;
> +}
> + }
> + if (!nonSuspectFound) {
> +logger.info("All other members are suspect at this point");
> +nextNeighbor = null;
> +return;
> + }
> }
>
> int index = allMembers.indexOf(nextTo);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1874) setNextNeighbor method allocates a HashSet on every p2p message received
[
https://issues.apache.org/jira/browse/GEODE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645311#comment-15645311
]
ASF subversion and git services commented on GEODE-1874:
Commit b0c6f05b22a2cfda4005b1812285c77ad24d7c44 in incubator-geode's branch
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b0c6f05 ]
GEODE-1874: Changed setNextNeighbor to not create HashMap for every p2p
invocation
> setNextNeighbor method allocates a HashSet on every p2p message received
>
>
> Key: GEODE-1874
> URL: https://issues.apache.org/jira/browse/GEODE-1874
> Project: Geode
> Issue Type: Bug
> Components: messaging
>Reporter: Darrel Schneider
>Assignee: Udo Kohlmeyer
>
> Every time a peer receives a message it ends up calling setNextNeighbor in
> com.gemstone.gemfire.distributed.internal.membership.gms.fd.GMSHealthMonitor.
> This method always allocates and add all the existing members to it just so
> it can figure out if all other members are suspected.
> I was doing performance analysis of a PR get test and this HashSet resulted
> in a 10% decrease in the put rate.
> It is not clear why setNextNeighbor is even being called by contactedBy since
> the actual view did not change. So one possible fix would be to not call
> setNextNeighbor from contactedBy.
> But here is an optimization of setNextNeighbor that prevents any work from
> being done if the sizes indicate that not all other members are suspects.
> When it does need to check the new code just reads the existing state instead
> of allocating and adding to a new HashSet:
> {noformat}
> diff --git
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> index 9fdbb64..fcb2826 100644
> ---
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> +++
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> @@ -818,13 +818,22 @@ public class GMSHealthMonitor implements HealthMonitor,
> MessageHandler {
>
> List allMembers = newView.getMembers();
>
> -Set checkAllSuspected = new
> HashSet<>(allMembers);
> -checkAllSuspected.removeAll(suspectedMemberInView.keySet());
> -checkAllSuspected.remove(localAddress);
> -if (checkAllSuspected.isEmpty() && allMembers.size() > 1) {
> - logger.info("All other members are suspect at this point");
> - nextNeighbor = null;
> - return;
> +if (allMembers.size() > 1 && suspectedMemberInView.size() >=
> allMembers.size()-1) {
> + boolean nonSuspectFound = false;
> + for (InternalDistributedMember member: allMembers) {
> +if (member.equals(localAddress)) {
> + continue;
> +}
> +if (!suspectedMemberInView.containsKey(member)) {
> + nonSuspectFound = true;
> + break;
> +}
> + }
> + if (!nonSuspectFound) {
> +logger.info("All other members are suspect at this point");
> +nextNeighbor = null;
> +return;
> + }
> }
>
> int index = allMembers.indexOf(nextTo);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1874) setNextNeighbor method allocates a HashSet on every p2p message received
[
https://issues.apache.org/jira/browse/GEODE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645314#comment-15645314
]
ASF subversion and git services commented on GEODE-1874:
Commit 15450f5c3251b00db845867db804921223bf4ed6 in incubator-geode's branch
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=15450f5 ]
GEODE-1874: Fix formatting
> setNextNeighbor method allocates a HashSet on every p2p message received
>
>
> Key: GEODE-1874
> URL: https://issues.apache.org/jira/browse/GEODE-1874
> Project: Geode
> Issue Type: Bug
> Components: messaging
>Reporter: Darrel Schneider
>Assignee: Udo Kohlmeyer
>
> Every time a peer receives a message it ends up calling setNextNeighbor in
> com.gemstone.gemfire.distributed.internal.membership.gms.fd.GMSHealthMonitor.
> This method always allocates and add all the existing members to it just so
> it can figure out if all other members are suspected.
> I was doing performance analysis of a PR get test and this HashSet resulted
> in a 10% decrease in the put rate.
> It is not clear why setNextNeighbor is even being called by contactedBy since
> the actual view did not change. So one possible fix would be to not call
> setNextNeighbor from contactedBy.
> But here is an optimization of setNextNeighbor that prevents any work from
> being done if the sizes indicate that not all other members are suspects.
> When it does need to check the new code just reads the existing state instead
> of allocating and adding to a new HashSet:
> {noformat}
> diff --git
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> index 9fdbb64..fcb2826 100644
> ---
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> +++
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> @@ -818,13 +818,22 @@ public class GMSHealthMonitor implements HealthMonitor,
> MessageHandler {
>
> List allMembers = newView.getMembers();
>
> -Set checkAllSuspected = new
> HashSet<>(allMembers);
> -checkAllSuspected.removeAll(suspectedMemberInView.keySet());
> -checkAllSuspected.remove(localAddress);
> -if (checkAllSuspected.isEmpty() && allMembers.size() > 1) {
> - logger.info("All other members are suspect at this point");
> - nextNeighbor = null;
> - return;
> +if (allMembers.size() > 1 && suspectedMemberInView.size() >=
> allMembers.size()-1) {
> + boolean nonSuspectFound = false;
> + for (InternalDistributedMember member: allMembers) {
> +if (member.equals(localAddress)) {
> + continue;
> +}
> +if (!suspectedMemberInView.containsKey(member)) {
> + nonSuspectFound = true;
> + break;
> +}
> + }
> + if (!nonSuspectFound) {
> +logger.info("All other members are suspect at this point");
> +nextNeighbor = null;
> +return;
> + }
> }
>
> int index = allMembers.indexOf(nextTo);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1874) setNextNeighbor method allocates a HashSet on every p2p message received
[
https://issues.apache.org/jira/browse/GEODE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645310#comment-15645310
]
ASF subversion and git services commented on GEODE-1874:
Commit 593c7025f929819fde2e12ca05d24c6abe29b3a4 in incubator-geode's branch
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=593c702 ]
GEODE-1874: Changed setNextNeighbor to not create HashMap for every p2p
invocation
> setNextNeighbor method allocates a HashSet on every p2p message received
>
>
> Key: GEODE-1874
> URL: https://issues.apache.org/jira/browse/GEODE-1874
> Project: Geode
> Issue Type: Bug
> Components: messaging
>Reporter: Darrel Schneider
>Assignee: Udo Kohlmeyer
>
> Every time a peer receives a message it ends up calling setNextNeighbor in
> com.gemstone.gemfire.distributed.internal.membership.gms.fd.GMSHealthMonitor.
> This method always allocates and add all the existing members to it just so
> it can figure out if all other members are suspected.
> I was doing performance analysis of a PR get test and this HashSet resulted
> in a 10% decrease in the put rate.
> It is not clear why setNextNeighbor is even being called by contactedBy since
> the actual view did not change. So one possible fix would be to not call
> setNextNeighbor from contactedBy.
> But here is an optimization of setNextNeighbor that prevents any work from
> being done if the sizes indicate that not all other members are suspects.
> When it does need to check the new code just reads the existing state instead
> of allocating and adding to a new HashSet:
> {noformat}
> diff --git
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> index 9fdbb64..fcb2826 100644
> ---
> a/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> +++
> b/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
> @@ -818,13 +818,22 @@ public class GMSHealthMonitor implements HealthMonitor,
> MessageHandler {
>
> List allMembers = newView.getMembers();
>
> -Set checkAllSuspected = new
> HashSet<>(allMembers);
> -checkAllSuspected.removeAll(suspectedMemberInView.keySet());
> -checkAllSuspected.remove(localAddress);
> -if (checkAllSuspected.isEmpty() && allMembers.size() > 1) {
> - logger.info("All other members are suspect at this point");
> - nextNeighbor = null;
> - return;
> +if (allMembers.size() > 1 && suspectedMemberInView.size() >=
> allMembers.size()-1) {
> + boolean nonSuspectFound = false;
> + for (InternalDistributedMember member: allMembers) {
> +if (member.equals(localAddress)) {
> + continue;
> +}
> +if (!suspectedMemberInView.containsKey(member)) {
> + nonSuspectFound = true;
> + break;
> +}
> + }
> + if (!nonSuspectFound) {
> +logger.info("All other members are suspect at this point");
> +nextNeighbor = null;
> +return;
> + }
> }
>
> int index = allMembers.indexOf(nextTo);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2017) Removal of nonSingleHopsCount stat in client
[ https://issues.apache.org/jira/browse/GEODE-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645276#comment-15645276 ] ASF subversion and git services commented on GEODE-2017: Commit 3046ea831746f1d710b7f2d66b9e6793b8448274 in incubator-geode's branch refs/heads/develop from [~ukohlmeyer] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3046ea8 ] GEODE-2017: removal of nonPRSingleHop stat in client > Removal of nonSingleHopsCount stat in client > > > Key: GEODE-2017 > URL: https://issues.apache.org/jira/browse/GEODE-2017 > Project: Geode > Issue Type: Bug > Components: client/server, docs, native client >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer > > Currently, the nonSingleHopsCount stat in the client is defined as "Total > number of times client request observed more than one hop during operation." > From this definition, this stat should track every time a client operation > requires more than one hop. Currently, this stat is only incremented when > "singleHop" is enabled on the pool. If this is correct then > metaDataRefreshCount will track the same metric, as the client will > automatically refresh when more than one hop is required for a prSingleHop > enabled pool. > If the nonSingleHopsCount metric where to track every non-one hop operation, > regardless of the "singleHop" flag on the pool, then the implementation of > this stat would need to change. > Otherwise we remove this stat and only track all nonSingleHop operation with > the metaDataRefresh count. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2017) Removal of nonSingleHopsCount stat in client
[ https://issues.apache.org/jira/browse/GEODE-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645275#comment-15645275 ] ASF subversion and git services commented on GEODE-2017: Commit 3046ea831746f1d710b7f2d66b9e6793b8448274 in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~ukohlmeyer] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3046ea8 ] GEODE-2017: removal of nonPRSingleHop stat in client > Removal of nonSingleHopsCount stat in client > > > Key: GEODE-2017 > URL: https://issues.apache.org/jira/browse/GEODE-2017 > Project: Geode > Issue Type: Bug > Components: client/server, docs, native client >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer > > Currently, the nonSingleHopsCount stat in the client is defined as "Total > number of times client request observed more than one hop during operation." > From this definition, this stat should track every time a client operation > requires more than one hop. Currently, this stat is only incremented when > "singleHop" is enabled on the pool. If this is correct then > metaDataRefreshCount will track the same metric, as the client will > automatically refresh when more than one hop is required for a prSingleHop > enabled pool. > If the nonSingleHopsCount metric where to track every non-one hop operation, > regardless of the "singleHop" flag on the pool, then the implementation of > this stat would need to change. > Otherwise we remove this stat and only track all nonSingleHop operation with > the metaDataRefresh count. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2079) CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL
[ https://issues.apache.org/jira/browse/GEODE-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645062#comment-15645062 ] ASF subversion and git services commented on GEODE-2079: Commit 4e51ac5dbf2061fd5f347ff7ae3d6954e3a6266c in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4e51ac5 ] GEODE-2079: mark the test as flaky > CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL > - > > Key: GEODE-2079 > URL: https://issues.apache.org/jira/browse/GEODE-2079 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Jinmei Liao > Labels: CI, flaky > > org.apache.geode.InternalGemFireError > at org.apache.geode.internal.Assert.throwError(Assert.java:96) > at org.apache.geode.internal.Assert.assertTrue(Assert.java:56) > at > org.apache.geode.management.ConnectToLocatorSSLDUnitTest.setUpLocatorAndConnect(ConnectToLocatorSSLDUnitTest.java:132) > at > org.apache.geode.management.ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL(ConnectToLocatorSSLDUnitTest.java:118) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodA
[jira] [Commented] (GEODE-2017) Removal of nonSingleHopsCount stat in client
[ https://issues.apache.org/jira/browse/GEODE-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645033#comment-15645033 ] ASF subversion and git services commented on GEODE-2017: Commit b62cb1d1afb95868a4e1909e2936b2998fc928ff in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~ukohlmeyer] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b62cb1d ] GEODE-2017: Fixing Formatting > Removal of nonSingleHopsCount stat in client > > > Key: GEODE-2017 > URL: https://issues.apache.org/jira/browse/GEODE-2017 > Project: Geode > Issue Type: Bug > Components: client/server, docs, native client >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer > > Currently, the nonSingleHopsCount stat in the client is defined as "Total > number of times client request observed more than one hop during operation." > From this definition, this stat should track every time a client operation > requires more than one hop. Currently, this stat is only incremented when > "singleHop" is enabled on the pool. If this is correct then > metaDataRefreshCount will track the same metric, as the client will > automatically refresh when more than one hop is required for a prSingleHop > enabled pool. > If the nonSingleHopsCount metric where to track every non-one hop operation, > regardless of the "singleHop" flag on the pool, then the implementation of > this stat would need to change. > Otherwise we remove this stat and only track all nonSingleHop operation with > the metaDataRefresh count. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2079) CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL
[ https://issues.apache.org/jira/browse/GEODE-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645029#comment-15645029 ] ASF subversion and git services commented on GEODE-2079: Commit b4077414ef859b627c7961d86b4704c2034ebfb1 in incubator-geode's branch refs/heads/develop from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=b407741 ] GEODE-2079: mark the test as flaky > CI failure: ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL > - > > Key: GEODE-2079 > URL: https://issues.apache.org/jira/browse/GEODE-2079 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Jinmei Liao > Labels: CI, flaky > > org.apache.geode.InternalGemFireError > at org.apache.geode.internal.Assert.throwError(Assert.java:96) > at org.apache.geode.internal.Assert.assertTrue(Assert.java:56) > at > org.apache.geode.management.ConnectToLocatorSSLDUnitTest.setUpLocatorAndConnect(ConnectToLocatorSSLDUnitTest.java:132) > at > org.apache.geode.management.ConnectToLocatorSSLDUnitTest.testConnectToLocatorWithLegacyJMXSSL(ConnectToLocatorSSLDUnitTest.java:118) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl
[jira] [Commented] (GEODE-1912) gfsh does not validate start server command
[
https://issues.apache.org/jira/browse/GEODE-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645020#comment-15645020
]
ASF subversion and git services commented on GEODE-1912:
Commit 809d64d712c0e31115b79c424e40fb87b3c46d79 in incubator-geode's branch
refs/heads/feature/GEODE-1912 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=809d64d ]
GEODE-1912: use Spring shell's parser and delete our own parsing code
> gfsh does not validate start server command
> ---
>
> Key: GEODE-1912
> URL: https://issues.apache.org/jira/browse/GEODE-1912
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Swapnil Bawaskar
>Priority: Minor
>
> When I tried to start a server from gfsh I accidently used {{--locator}}
> (singular) rather than -{{-locators}}. gfsh did not throw an error and
> started the server without connecting to the locator.
> We should throw an error for unrecognized command options in gfsh.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2073) CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
[
https://issues.apache.org/jira/browse/GEODE-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645010#comment-15645010
]
ASF subversion and git services commented on GEODE-2073:
Commit 082c0849fae5a56ab5f530990a0dc6342022c670 in incubator-geode's branch
refs/heads/feature/GEODE-2017 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=082c084 ]
GEODE-2073: annotate flaky test with FlakyTest category
> CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout
>
>
> Key: GEODE-2073
> URL: https://issues.apache.org/jira/browse/GEODE-2073
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, flaky
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest
> > testHMNextNeighborAfterTimeout FAILED
> java.lang.AssertionError: expected
> 09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8893 but found
> 09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8892. view=null
> expected:<09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8893> but
> was:<09c3cb70-4f42-49ab-6059-e2467bdf5211(96747):8892>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout(GMSHealthMonitorJUnitTest.java:183)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1955) JMX suspect string causes tests to fail
[ https://issues.apache.org/jira/browse/GEODE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645007#comment-15645007 ] ASF subversion and git services commented on GEODE-1955: Commit 151df7bf5f186c115ca8ea048167b9559f419395 in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=151df7b ] GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest > JMX suspect string causes tests to fail > --- > > Key: GEODE-1955 > URL: https://issues.apache.org/jira/browse/GEODE-1955 > Project: Geode > Issue Type: Bug > Components: jmx >Reporter: Bruce Schuchardt >Assignee: Jinmei Liao > Labels: ci > > This suspect string is causing periodic failures in a number of unit tests: > Error Message > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > --- > Found suspect string in log4j at line 283 > [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] > (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1955) JMX suspect string causes tests to fail
[ https://issues.apache.org/jira/browse/GEODE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645006#comment-15645006 ] ASF subversion and git services commented on GEODE-1955: Commit 151df7bf5f186c115ca8ea048167b9559f419395 in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=151df7b ] GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest > JMX suspect string causes tests to fail > --- > > Key: GEODE-1955 > URL: https://issues.apache.org/jira/browse/GEODE-1955 > Project: Geode > Issue Type: Bug > Components: jmx >Reporter: Bruce Schuchardt >Assignee: Jinmei Liao > Labels: ci > > This suspect string is causing periodic failures in a number of unit tests: > Error Message > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > --- > Found suspect string in log4j at line 283 > [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] > (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1985) IndexManager.needsRecalculation can miss cases where recalulation is needed
[ https://issues.apache.org/jira/browse/GEODE-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645013#comment-15645013 ] ASF subversion and git services commented on GEODE-1985: Commit fdf632901e15c40a5c5510e24d57e0ecfa0ba32e in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=fdf6329 ] GEODE-1985 Removing some string comparisons in the AttributesDescriptor Optimizing the attributes descriptor by removing some string comparisons. > IndexManager.needsRecalculation can miss cases where recalulation is needed > --- > > Key: GEODE-1985 > URL: https://issues.apache.org/jira/browse/GEODE-1985 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.1.0-incubating > > > When returning query results from an index, we check > IndexManager.needsRecalculation to see if an entry might have changed while > the query was in progress. > Unfortunately, this method can return false negatives If an entry has not yet > updated the SAFE_QUERY_TIME field. > The SAFE_QUERY_TIME is updated in LocalRegion.updateStatsForPut. That method > is called *after* the region entry was modified. So the SAFE_QUERY_TIME could > be 0, even though an entry was modified, which will make this expression > false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
[ https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645012#comment-15645012 ] ASF subversion and git services commented on GEODE-1821: Commit dd2df31b42cdfdb2728828ff5640b897d480d819 in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~khowe] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=dd2df31 ] GEODE-1821: Adjust timing to wait for async thread This closes #279 > CI Failure: > PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions > --- > > Key: GEODE-1821 > URL: https://issues.apache.org/jira/browse/GEODE-1821 > Project: Geode > Issue Type: Bug > Components: persistence, regions >Reporter: Anilkumar Gingade >Assignee: Kenneth Howe > Fix For: 1.1.0-incubating > > > Build #3755 (Aug 24, 2016 5:09:20 AM) > Revision: 37269735eec44f51ee53075718afe2fa85edc22e > refs/remotes/origin/develop > Error Message > java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds > for AsyncInvocation to complete. > Stacktrace > java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds > for AsyncInvocation to complete. > at > com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443) > at > com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390) > at > com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:9
[jira] [Commented] (GEODE-2074) CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
[
https://issues.apache.org/jira/browse/GEODE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645011#comment-15645011
]
ASF subversion and git services commented on GEODE-2074:
Commit 3cf725f46b3847e4939ce0256221f8dc10a54bcc in incubator-geode's branch
refs/heads/feature/GEODE-2017 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3cf725f ]
GEODE-2074: annotate flaky test with FlakyTest category
> CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
> -
>
> Key: GEODE-2074
> URL: https://issues.apache.org/jira/browse/GEODE-2074
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, Flaky
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
> > testDuplicateJoinRequestDoesNotCauseNewView FAILED
> java.lang.RuntimeException: timeout waiting for view #7
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.waitForViewAndNoRequestsInProgress(GMSJoinLeaveJUnitTest.java:536)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView(GMSJoinLeaveJUnitTest.java:508)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1955) JMX suspect string causes tests to fail
[ https://issues.apache.org/jira/browse/GEODE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645004#comment-15645004 ] ASF subversion and git services commented on GEODE-1955: Commit 151df7bf5f186c115ca8ea048167b9559f419395 in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~jinmeiliao] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=151df7b ] GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest > JMX suspect string causes tests to fail > --- > > Key: GEODE-1955 > URL: https://issues.apache.org/jira/browse/GEODE-1955 > Project: Geode > Issue Type: Bug > Components: jmx >Reporter: Bruce Schuchardt >Assignee: Jinmei Liao > Labels: ci > > This suspect string is causing periodic failures in a number of unit tests: > Error Message > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > --- > Found suspect string in log4j at line 283 > [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] > (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2072) CI Failure: TestFunctionsDUnitTest.testNumOfRunningFunctions
[
https://issues.apache.org/jira/browse/GEODE-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645009#comment-15645009
]
ASF subversion and git services commented on GEODE-2072:
Commit c73bea742e5c89bc9af7a5db3b2016f10d0cd056 in incubator-geode's branch
refs/heads/feature/GEODE-2017 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=c73bea7 ]
GEODE-2072: annotate flaky test with FlakyTest category
> CI Failure: TestFunctionsDUnitTest.testNumOfRunningFunctions
>
>
> Key: GEODE-2072
> URL: https://issues.apache.org/jira/browse/GEODE-2072
> Project: Geode
> Issue Type: Bug
> Components: management, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Labels: CI, Flaky
>
> {noformat}
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest >
> testNumOfRunningFunctions FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest$$Lambda$15/1807889435.call
> in VM 0 running on Host a00f4285b6a8 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:282)
> at
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest.testNumOfRunningFunctions(TestFunctionsDUnitTest.java:100)
> Caused by:
> java.lang.AssertionError: Event never occurred after 12 ms: wait
> for getNumOfRunningFunction to complete and get results
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.geode.test.dunit.Wait.waitForCriterion(Wait.java:190)
> at
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest.getNumOfRunningFunction(TestFunctionsDUnitTest.java:77)
> at
> org.apache.geode.management.internal.pulse.TestFunctionsDUnitTest.lambda$testNumOfRunningFunctions$5c4d653a$1(TestFunctionsDUnitTest.java:100)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2071) CI Failure: ClientAuthzObjectModDUnitTest.testAllOpsObjectModWithFailover
[
https://issues.apache.org/jira/browse/GEODE-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645008#comment-15645008
]
ASF subversion and git services commented on GEODE-2071:
Commit 3c0de2a83b961a3320066b267ad4e34fc2010cec in incubator-geode's branch
refs/heads/feature/GEODE-2017 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3c0de2a ]
GEODE-2071: annotate flaky test with FlakyTest category
> CI Failure: ClientAuthzObjectModDUnitTest.testAllOpsObjectModWithFailover
> -
>
> Key: GEODE-2071
> URL: https://issues.apache.org/jira/browse/GEODE-2071
> Project: Geode
> Issue Type: Bug
> Components: security, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, Flaky
>
> {noformat}
> org.apache.geode.security.ClientAuthzObjectModDUnitTest >
> testAllOpsObjectModWithFailover FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.NamedRunnable.run in VM 3 running on Host
> c0444d5751d1 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:247)
> at
> org.apache.geode.security.ClientAuthorizationTestCase.executeOpBlock(ClientAuthorizationTestCase.java:793)
> at
> org.apache.geode.security.ClientAuthzObjectModDUnitTest.testAllOpsObjectModWithFailover(ClientAuthzObjectModDUnitTest.java:123)
> Caused by:
> java.lang.AssertionError: doOp: Got unexpected exception when doing
> operation. Policy = KEYS_VALUES flags =
> [CHECK_NOTAUTHZ,USE_NEWVAL,CHECK_NOKEY,USE_OLDCONN,]
> Caused by:
> org.apache.geode.cache.client.NoAvailableServersException
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 7230
> [fatal 2016/11/02 21:01:43.926 UTC
> tid=0x139] Membership service failure: Failed to acknowledge a new membership
> view and then failed tcp/ip connection attempt
> org.apache.geode.ForcedDisconnectException: Failed to acknowledge a new
> membership view and then failed tcp/ip connection attempt
> at
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2510)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:999)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1698)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
> at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
> at org.jgroups.JChannel.up(JChannel.java:741)
> at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
> at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
> at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
> at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
> at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
> at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
> at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
> at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
> at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
> at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
> at org.jgroups.protocols.TP.receive(TP.java:1654)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
> at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1985) IndexManager.needsRecalculation can miss cases where recalulation is needed
[ https://issues.apache.org/jira/browse/GEODE-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645014#comment-15645014 ] ASF subversion and git services commented on GEODE-1985: Commit cc67eddb6c385bf5f87db0dae488bf0b0a5a8d5d in incubator-geode's branch refs/heads/feature/GEODE-2017 from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=cc67edd ] GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes This is a fix for pretty specific race condition 1) T1 does a put and gets to the point of calling setIndexBufferTime, but hasn't updated the indexes 2) T2 starts a query and finds the entry in the index even though the value no longer matches the query 3) T1 finishes the put 4) T2 checks to see if should revaluate the entry, but decides not to because based on the SAFE_QUERY_TIME value the entry changed before the query started. By moving the update to SAFE_QUERY_TIME down, the if the an entry doesn't need reevaluation based on the SAFE_QUERY_TIME, we know the index was updated before the query started. There is currently an updateInProgress flag to handle the issue of the query executing before the SAFE_QUERY_TIME is updated. If the entry is updated, but not the index, the updateInProgress flag will be set. > IndexManager.needsRecalculation can miss cases where recalulation is needed > --- > > Key: GEODE-1985 > URL: https://issues.apache.org/jira/browse/GEODE-1985 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.1.0-incubating > > > When returning query results from an index, we check > IndexManager.needsRecalculation to see if an entry might have changed while > the query was in progress. > Unfortunately, this method can return false negatives If an entry has not yet > updated the SAFE_QUERY_TIME field. > The SAFE_QUERY_TIME is updated in LocalRegion.updateStatsForPut. That method > is called *after* the region entry was modified. So the SAFE_QUERY_TIME could > be 0, even though an entry was modified, which will make this expression > false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2013) StatArchiveReader throws NullPointerException due to missing ResourceType
[
https://issues.apache.org/jira/browse/GEODE-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645003#comment-15645003
]
ASF subversion and git services commented on GEODE-2013:
Commit 789814d5c0239d86c9a4f7970eabc0a7ad9473a7 in incubator-geode's branch
refs/heads/feature/GEODE-2017 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=789814d ]
GEODE-2013: throw IllegalStateException if resource type is missing
> StatArchiveReader throws NullPointerException due to missing ResourceType
> -
>
> Key: GEODE-2013
> URL: https://issues.apache.org/jira/browse/GEODE-2013
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> StatArchiveReader will throw a NullPointerException while loading a Resource
> from a stat archive file that is missing the corresponding ResourceType.
> GEODE-2012 can result in a stat archive file that is missing a ResourceType.
> Example of stack trace:
> {noformat}
> ERROR: Operation "stats" failed because: java.lang.NullPointerException.
> java.lang.NullPointerException
> at
> org.apache.geode.internal.statistics.StatArchiveReader$StatArchiveFile.loadInstance(StatArchiveReader.java:3049)
> at
> org.apache.geode.internal.statistics.StatArchiveReader$StatArchiveFile.readResourceInstanceCreateToken(StatArchiveReader.java:3159)
> at
> org.apache.geode.internal.statistics.StatArchiveReader$StatArchiveFile.readToken(StatArchiveReader.java:3308)
> at
> org.apache.geode.internal.statistics.StatArchiveReader$StatArchiveFile.update(StatArchiveReader.java:2884)
> at
> org.apache.geode.internal.statistics.StatArchiveReader.update(StatArchiveReader.java:145)
> at
> org.apache.geode.internal.statistics.StatArchiveReader.(StatArchiveReader.java:77)
> at
> org.apache.geode.internal.SystemAdmin.statistics(SystemAdmin.java:1136)
> at org.apache.geode.internal.SystemAdmin.invoke(SystemAdmin.java:2063)
> at org.apache.geode.internal.SystemAdmin.main(SystemAdmin.java:1977)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> {noformat}
> The NullPointerException is not helpful. The StatArchiveReader should be
> changed to throw an IllegalStateException with a message that provides
> helpful information about what's wrong/missing. Message should be
> "ResourceType is missing for resourceTypeId n" where "n" is the id for the
> missing ResourceType.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1985) IndexManager.needsRecalculation can miss cases where recalulation is needed
[ https://issues.apache.org/jira/browse/GEODE-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644888#comment-15644888 ] ASF subversion and git services commented on GEODE-1985: Commit 2e1a8c420fd984bdcc605ababe93b0e6c6b29919 in incubator-geode's branch refs/heads/develop from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2e1a8c4 ] GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes This is a fix for pretty specific race condition 1) T1 does a put and gets to the point of calling setIndexBufferTime, but hasn't updated the indexes 2) T2 starts a query and finds the entry in the index even though the value no longer matches the query 3) T1 finishes the put 4) T2 checks to see if should revaluate the entry, but decides not to because based on the SAFE_QUERY_TIME value the entry changed before the query started. By moving the update to SAFE_QUERY_TIME down, the if the an entry doesn't need reevaluation based on the SAFE_QUERY_TIME, we know the index was updated before the query started. There is currently an updateInProgress flag to handle the issue of the query executing before the SAFE_QUERY_TIME is updated. If the entry is updated, but not the index, the updateInProgress flag will be set. > IndexManager.needsRecalculation can miss cases where recalulation is needed > --- > > Key: GEODE-1985 > URL: https://issues.apache.org/jira/browse/GEODE-1985 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: Dan Smith > > When returning query results from an index, we check > IndexManager.needsRecalculation to see if an entry might have changed while > the query was in progress. > Unfortunately, this method can return false negatives If an entry has not yet > updated the SAFE_QUERY_TIME field. > The SAFE_QUERY_TIME is updated in LocalRegion.updateStatsForPut. That method > is called *after* the region entry was modified. So the SAFE_QUERY_TIME could > be 0, even though an entry was modified, which will make this expression > false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1985) IndexManager.needsRecalculation can miss cases where recalulation is needed
[ https://issues.apache.org/jira/browse/GEODE-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644887#comment-15644887 ] ASF subversion and git services commented on GEODE-1985: Commit 4c0d302fcacdc338d967c2fb873c05d0a52f109f in incubator-geode's branch refs/heads/develop from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=4c0d302 ] GEODE-1985 Removing some string comparisons in the AttributesDescriptor Optimizing the attributes descriptor by removing some string comparisons. > IndexManager.needsRecalculation can miss cases where recalulation is needed > --- > > Key: GEODE-1985 > URL: https://issues.apache.org/jira/browse/GEODE-1985 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: Dan Smith > > When returning query results from an index, we check > IndexManager.needsRecalculation to see if an entry might have changed while > the query was in progress. > Unfortunately, this method can return false negatives If an entry has not yet > updated the SAFE_QUERY_TIME field. > The SAFE_QUERY_TIME is updated in LocalRegion.updateStatsForPut. That method > is called *after* the region entry was modified. So the SAFE_QUERY_TIME could > be 0, even though an entry was modified, which will make this expression > false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1821) CI Failure: PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions
[ https://issues.apache.org/jira/browse/GEODE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637655#comment-15637655 ] ASF subversion and git services commented on GEODE-1821: Commit 2993e6d6fac49b5601fde5d740b0ff81712f8977 in incubator-geode's branch refs/heads/develop from [~khowe] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=2993e6d ] GEODE-1821: Adjust timing to wait for async thread This closes #279 > CI Failure: > PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions > --- > > Key: GEODE-1821 > URL: https://issues.apache.org/jira/browse/GEODE-1821 > Project: Geode > Issue Type: Bug > Components: persistence, regions >Reporter: Anilkumar Gingade >Assignee: Kenneth Howe > Fix For: 1.0.0-incubating > > > Build #3755 (Aug 24, 2016 5:09:20 AM) > Revision: 37269735eec44f51ee53075718afe2fa85edc22e > refs/remotes/origin/develop > Error Message > java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds > for AsyncInvocation to complete. > Stacktrace > java.util.concurrent.TimeoutException: Timed out waiting 3 milliseconds > for AsyncInvocation to complete. > at > com.gemstone.gemfire.test.dunit.AsyncInvocation.timeoutIfAlive(AsyncInvocation.java:443) > at > com.gemstone.gemfire.test.dunit.AsyncInvocation.get(AsyncInvocation.java:390) > at > com.gemstone.gemfire.internal.cache.partitioned.PersistentColocatedPartitionedRegionDUnitTest.testFullTreeOfColocatedChildPRsWithMissingRegions(PersistentColocatedPartitionedRegionDUnitTest.java:1197) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) >
[jira] [Commented] (GEODE-2074) CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
[
https://issues.apache.org/jira/browse/GEODE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637313#comment-15637313
]
ASF subversion and git services commented on GEODE-2074:
Commit 9f0919f09f7fe2b977955f83fae95b1a3d174d18 in incubator-geode's branch
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=9f0919f ]
GEODE-2074: annotate flaky test with FlakyTest category
> CI Failure: GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView
> -
>
> Key: GEODE-2074
> URL: https://issues.apache.org/jira/browse/GEODE-2074
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
> Labels: CI, Flaky
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
> > testDuplicateJoinRequestDoesNotCauseNewView FAILED
> java.lang.RuntimeException: timeout waiting for view #7
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.waitForViewAndNoRequestsInProgress(GMSJoinLeaveJUnitTest.java:536)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testDuplicateJoinRequestDoesNotCauseNewView(GMSJoinLeaveJUnitTest.java:508)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
