[jira] [Comment Edited] (GEODE-1506) gfsh should not display call stack, just the error message

2016-06-05 Thread Jens Deppe (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316160#comment-15316160
 ] 

Jens Deppe edited comment on GEODE-1506 at 6/6/16 3:29 AM:
---

See also GEODE-1025 which introduced {{DefaultServerLauncherCacheProvider}}.


was (Author: jens.deppe):
See also GEODE-1025

> gfsh should not display call stack, just the error message
> --
>
> Key: GEODE-1506
> URL: https://issues.apache.org/jira/browse/GEODE-1506
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Anthony Baker
>
> See the following email thread:
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201606.mbox/%3ccafdh8_1xbyzf44ksai_p9jeu43tajamovagqrtucwvstlgt...@mail.gmail.com%3e
> Instead of printing the call stack, we should just display the error message. 
>  Perhaps the full details can be written to the log instead of the console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (GEODE-1506) gfsh should not display call stack, just the error message

2016-11-04 Thread Jinmei Liao (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317166#comment-15317166
 ] 

Jinmei Liao edited comment on GEODE-1506 at 11/4/16 2:58 PM:
-

When server is started with an error, it writes the errors to System.err 
because the log writer isn't available at that point yet. Gfsh just blindly 
displays the System.err messages line by line. We have these three choices:

1. Have the server only sending the message line to the system.err instead of 
the entire stack.  -- low effort.
2. Have Gfsh parse the entire errors, and only shows the first message line, 
and logs the stack trace into gfsh log. ( We will also need to deal with the 
line saying "going to the server log for more details").  - more code change
3. Leave as it is.  - no effort



was (Author: jinmeiliao):
When server is started with an error, it writes the errors to System.err 
because the log writer isn't available at that point yet. Gfsh just blindly 
displays the System.err messages line by line. We have these three choices:

1. Have the server only sending the message line to the system.err instead of 
the entire stack.  -- low effort.
2. Have Gfsh parse the entire errors, and only shows the first message line, 
and logs the stack trace into gfsh log. ( We will also need to deal with the 
line saying "going to the server log for more details").  - more code change
3. Leave as it is.  - no effort

Assigning to PM for assessment.

> gfsh should not display call stack, just the error message
> --
>
> Key: GEODE-1506
> URL: https://issues.apache.org/jira/browse/GEODE-1506
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Anthony Baker
>Assignee: Swapnil Bawaskar
>
> See the following email thread:
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201606.mbox/%3ccafdh8_1xbyzf44ksai_p9jeu43tajamovagqrtucwvstlgt...@mail.gmail.com%3e
> Instead of printing the call stack, we should just display the error message. 
>  Perhaps the full details can be written to the log instead of the console.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)