[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346805#comment-15346805 ] ASF subversion and git services commented on GEODE-117: --- Commit 91f92a49726be20dd3000738f77b3b383518adc2 in incubator-geode's branch refs/heads/feature/GEODE-1573 from [~kduling] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=91f92a4 ] GEODE-117 - gfsh put ignores --skip-if-exists flag Fixed test, which erroneously reported that the --skip-if-exists flag is honored. Implemented check for flag within the put operation. This closes #166 > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Kevin Duling > Labels: gfsh, starter > Fix For: 1.0.0-incubating.M3 > > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342143#comment-15342143 ] ASF subversion and git services commented on GEODE-117: --- Commit 91f92a49726be20dd3000738f77b3b383518adc2 in incubator-geode's branch refs/heads/develop from [~kduling] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=91f92a4 ] GEODE-117 - gfsh put ignores --skip-if-exists flag Fixed test, which erroneously reported that the --skip-if-exists flag is honored. Implemented check for flag within the put operation. This closes #166 > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Kevin Duling > Labels: gfsh, starter > Fix For: 1.0.0-incubating.M3 > > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342145#comment-15342145 ] ASF GitHub Bot commented on GEODE-117: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/166 > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Kevin Duling > Labels: gfsh, starter > Fix For: 1.0.0-incubating.M3 > > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342128#comment-15342128 ] ASF GitHub Bot commented on GEODE-117: -- Github user jinmeiliao commented on the issue: https://github.com/apache/incubator-geode/pull/166 +1. I'll pull this in. > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Kevin Duling > Labels: gfsh, starter > Fix For: 1.0.0-incubating.M3 > > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336605#comment-15336605 ] ASF GitHub Bot commented on GEODE-117: -- GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/166 GEODE-117 - gfsh put ignores --skip-if-exists flag Fixed test, which erroneously reported that the --skip-if-exists flag is honored. Implemented check for flag within the put operation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-117 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/166.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #166 commit 5793770e559e054a5639f2f56ddcf07424e4c1ad Author: Kevin J. Duling Date: 2016-06-17T18:07:49Z GEODE-117 - gfsh put ignores --skip-if-exists flag Fixed test, which erroneously reported that the --skip-if-exists flag is honored. Implemented check for flag within the put operation. > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Kevin Duling > Labels: gfsh, starter > Fix For: 1.0.0-incubating.M3 > > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279220#comment-15279220 ] Dan Smith commented on GEODE-117: - [~manvsri] We just needed to add you as a contributor. You're now a contributor and I assigned the ticket to you, so have at it. > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Srikanth Manvi > Labels: gfsh, starter > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279069#comment-15279069 ] Srikanth Manvi commented on GEODE-117: -- BTW [~upthewaterspout], I don`t have access to assign this jira to myself. Can you please assign it to me ? Do only committers have edit rights on JIRA ? > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith > Labels: gfsh, starter > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279058#comment-15279058 ] Srikanth Manvi commented on GEODE-117: -- Thank you Dan. > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith > Labels: gfsh, starter > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278985#comment-15278985 ] Dan Smith commented on GEODE-117: - Hi [~manvsri], I don't think anyone is working on this issue. I unassigned Tushar, I think he was probably just automatically assigned. If you'd like to work on it, please do! -Dan > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith > Labels: gfsh, starter > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-117) gfsh put ignores --skip-if-exists flag
[ https://issues.apache.org/jira/browse/GEODE-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278797#comment-15278797 ] Srikanth Manvi commented on GEODE-117: -- [~tushark],[~upthewaterspout] Is somebody working on this ? I am not sure if it is auto-assigned to Tushar or if he is working on it. If not I would like to give it a try, I am new to Geode. Thanks, Srikanth Manvi > gfsh put ignores --skip-if-exists flag > -- > > Key: GEODE-117 > URL: https://issues.apache.org/jira/browse/GEODE-117 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Dan Smith >Assignee: Tushar Khairnar > Labels: gfsh, starter > > Someone hit this on a forum post: > https://support.pivotal.io/hc/communities/public/questions/204414098-put-in-gfsh-doesn-t-honor-skip-if-exists-true-flag-?flash_digest=f2441b8a96ac363d6da205c6f90a62035b1a3c21 > I looked into the code, and it looks like the flag gets lost somewhere along > the way. If you look at DataCommandFunction.put, it has a putIfAbsent flag, > but that flag is not used; the function just does a normal put. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
