[jira] [Commented] (GEODE-1511) geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
[
https://issues.apache.org/jira/browse/GEODE-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510941#comment-15510941
]
Anthony Baker commented on GEODE-1511:
--
If we ever want to remove the test dependencies from the pom, here's the diff:
{code}
diff --git a/gradle/publish.gradle b/gradle/publish.gradle
index 8a579c2..5319243 100644
--- a/gradle/publish.gradle
+++ b/gradle/publish.gradle
@@ -70,6 +70,11 @@ subprojects {
it.appendNode('optional', 'true')
}
}
+
+ // remove dependencies that are not needed for published pom
+ asNode().dependencies.dependency.findAll {
+it.scope.text() == 'test'
+ }.each { it.parent().remove(it) }
}
project {
{code}
> geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
> --
>
> Key: GEODE-1511
> URL: https://issues.apache.org/jira/browse/GEODE-1511
> Project: Geode
> Issue Type: Bug
> Components: build
>Reporter: John Blum
>Priority: Critical
> Fix For: 1.0.0-incubating
>
>
> The {{log4j-slf4j-impl}} SLF4J bridge JAR has been erroneously declared in
> the _Apache Geode_ {{geode-core}} Maven POM file.
> The inclusion of this declaration can have unintended consequences in a
> user's Geode-based application that might potentially rely on different
> and/or several logging frameworks (e.g. SLF4J, logback, etc), depending on
> the transitive dependencies of the application.
> Geode should not be including SLF4J bridge JARs in the applications CLASSPATH
> at runtime or otherwise.
> Additionally, the Geode POM file includes references to *test* dependencies
> that should be removed, specifically...
> junit
> asm
> system-rules
> mockito-core
> geode-junit
> hadoop-auth
> awaitility
> catch-exception
> cglib
> powermock-module-junit4
> jmock-junit4
> catch-throwable
> tempus-fugit
> commons-collections
> JUnitParams
> bcel
> assertj-core
> powermock-core
> jedis
> jmock-legacy
> powermock-api-mockito
> hamcrest-all
> commons-configuration
> spymemcached
> multithreadedtc
> derby
> The more dependencies you include, the greater chance for conflict an
> application developer may have when integrating with Apache Geode. The
> distributed/deployed (to Maven Central) is less about "building" the Apache
> Geode project and more about running an application built with Apache Geode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1511) geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
[
https://issues.apache.org/jira/browse/GEODE-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507224#comment-15507224
]
Anthony Baker commented on GEODE-1511:
--
You're right. And application projects that depend on geode-core don't pull in
optional deps.
> geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
> --
>
> Key: GEODE-1511
> URL: https://issues.apache.org/jira/browse/GEODE-1511
> Project: Geode
> Issue Type: Bug
> Components: build
>Reporter: John Blum
>Priority: Critical
>
> The {{log4j-slf4j-impl}} SLF4J bridge JAR has been erroneously declared in
> the _Apache Geode_ {{geode-core}} Maven POM file.
> The inclusion of this declaration can have unintended consequences in a
> user's Geode-based application that might potentially rely on different
> and/or several logging frameworks (e.g. SLF4J, logback, etc), depending on
> the transitive dependencies of the application.
> Geode should not be including SLF4J bridge JARs in the applications CLASSPATH
> at runtime or otherwise.
> Additionally, the Geode POM file includes references to *test* dependencies
> that should be removed, specifically...
> junit
> asm
> system-rules
> mockito-core
> geode-junit
> hadoop-auth
> awaitility
> catch-exception
> cglib
> powermock-module-junit4
> jmock-junit4
> catch-throwable
> tempus-fugit
> commons-collections
> JUnitParams
> bcel
> assertj-core
> powermock-core
> jedis
> jmock-legacy
> powermock-api-mockito
> hamcrest-all
> commons-configuration
> spymemcached
> multithreadedtc
> derby
> The more dependencies you include, the greater chance for conflict an
> application developer may have when integrating with Apache Geode. The
> distributed/deployed (to Maven Central) is less about "building" the Apache
> Geode project and more about running an application built with Apache Geode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1511) geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
[
https://issues.apache.org/jira/browse/GEODE-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507205#comment-15507205
]
Dan Smith commented on GEODE-1511:
--
This was already fixed as part of GEODE-1811. slf4j was being erroneously
included because although it was marked as optional in the gradle file, we were
not passing the optional flag on into the generated pom for runtime
dependencies. From the [latest
snapshot|https://repository.apache.org/content/repositories/snapshots/org/apache/geode/geode-core/1.0.0-incubating-SNAPSHOT/geode-core-1.0.0-incubating-20160920.160327-73.pom]
{code}
org.apache.logging.log4j
log4j-slf4j-impl
2.6.1
runtime
true
{code}
> geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
> --
>
> Key: GEODE-1511
> URL: https://issues.apache.org/jira/browse/GEODE-1511
> Project: Geode
> Issue Type: Bug
> Components: build
>Reporter: John Blum
>Priority: Critical
>
> The {{log4j-slf4j-impl}} SLF4J bridge JAR has been erroneously declared in
> the _Apache Geode_ {{geode-core}} Maven POM file.
> The inclusion of this declaration can have unintended consequences in a
> user's Geode-based application that might potentially rely on different
> and/or several logging frameworks (e.g. SLF4J, logback, etc), depending on
> the transitive dependencies of the application.
> Geode should not be including SLF4J bridge JARs in the applications CLASSPATH
> at runtime or otherwise.
> Additionally, the Geode POM file includes references to *test* dependencies
> that should be removed, specifically...
> junit
> asm
> system-rules
> mockito-core
> geode-junit
> hadoop-auth
> awaitility
> catch-exception
> cglib
> powermock-module-junit4
> jmock-junit4
> catch-throwable
> tempus-fugit
> commons-collections
> JUnitParams
> bcel
> assertj-core
> powermock-core
> jedis
> jmock-legacy
> powermock-api-mockito
> hamcrest-all
> commons-configuration
> spymemcached
> multithreadedtc
> derby
> The more dependencies you include, the greater chance for conflict an
> application developer may have when integrating with Apache Geode. The
> distributed/deployed (to Maven Central) is less about "building" the Apache
> Geode project and more about running an application built with Apache Geode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1511) geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
[
https://issues.apache.org/jira/browse/GEODE-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504089#comment-15504089
]
Anthony Baker commented on GEODE-1511:
--
Link to M3 pom:
https://repository.apache.org/service/local/repositories/releases/content/org/apache/geode/geode-core/1.0.0-incubating.M3/geode-core-1.0.0-incubating.M3.pom
> geode-core Maven POM File incorrectly includes the log4j-slf4j-impl bridge JAR
> --
>
> Key: GEODE-1511
> URL: https://issues.apache.org/jira/browse/GEODE-1511
> Project: Geode
> Issue Type: Bug
> Components: build
>Reporter: John Blum
>Priority: Critical
>
> The {{log4j-slf4j-impl}} SLF4J bridge JAR has been erroneously declared in
> the _Apache Geode_ {{geode-core}} Maven POM file.
> The inclusion of this declaration can have unintended consequences in a
> user's Geode-based application that might potentially rely on different
> and/or several logging frameworks (e.g. SLF4J, logback, etc), depending on
> the transitive dependencies of the application.
> Geode should not be including SLF4J bridge JARs in the applications CLASSPATH
> at runtime or otherwise.
> Additionally, the Geode POM file includes references to *test* dependencies
> that should be removed, specifically...
> junit
> asm
> system-rules
> mockito-core
> geode-junit
> hadoop-auth
> awaitility
> catch-exception
> cglib
> powermock-module-junit4
> jmock-junit4
> catch-throwable
> tempus-fugit
> commons-collections
> JUnitParams
> bcel
> assertj-core
> powermock-core
> jedis
> jmock-legacy
> powermock-api-mockito
> hamcrest-all
> commons-configuration
> spymemcached
> multithreadedtc
> derby
> The more dependencies you include, the greater chance for conflict an
> application developer may have when integrating with Apache Geode. The
> distributed/deployed (to Maven Central) is less about "building" the Apache
> Geode project and more about running an application built with Apache Geode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
